diff --git a/src/node/rpc/common_handler_registry.h b/src/node/rpc/common_handler_registry.h index 9582a2c76..063eccef7 100644 --- a/src/node/rpc/common_handler_registry.h +++ b/src/node/rpc/common_handler_registry.h @@ -269,7 +269,6 @@ namespace ccf .set_execute_locally(true); install(GeneralProcs::GET_TX_STATUS, json_adapter(get_tx_status), Read) .set_auto_schema() - .set_execute_locally(true) .set_http_get_only(); install(GeneralProcs::GET_METRICS, json_adapter(get_metrics), Read) .set_auto_schema() diff --git a/src/node/rpc/test/tx_status_test.cpp b/src/node/rpc/test/tx_status_test.cpp index 52394c6f3..14ef49e5d 100644 --- a/src/node/rpc/test/tx_status_test.cpp +++ b/src/node/rpc/test/tx_status_test.cpp @@ -92,19 +92,6 @@ TEST_CASE("edge cases") { INFO("Node is in a newer view"); - // Impossible: cannot have local progress in a view without an initial - // global point in that view - // get_tx_status(a, b, N, committed_view) - { - throw std::logic_error(fmt::format( - "Should not believe {} occurred in view {}, ahead of the current " - "committed view {}", - target_view, - local_view, - committed_view)); - } - if (is_committed) { // The requested seqno has been committed, so we know for certain whether @@ -65,7 +55,7 @@ namespace ccf return TxStatus::Invalid; } } - else if (local_view == target_view) + else if (views_match) { // This node knows about the requested tx id, but it is not globally // committed