Clean up test TODOs (#6178)

tests/fuzzing.py

@@ -115,7 +115,6 @@ def fuzz_node_to_node(network, args):
                     ),
                 ],
             ),
-            # TODO: Different types of body, based on message type?
             boofuzz.Block(
                 "Body",
                 children=[

tests/infra/checker.py

@@ -11,7 +11,6 @@ class Checker:
         self.client = client
         self.notified_commit = 0
 
-    # TODO: that API's not right!
     def __call__(self, rpc_result, result=None, error=None):
         if error is not None:
             if callable(error):

tests/infra/piccolo_driver.py

@@ -212,15 +212,6 @@ def run(get_command, args):
                         perf_result = round(len(df_sends.index) / time_spent, 1)
                         LOG.success(f"{args.label}/{remote_client.name}: {perf_result}")
 
-                        # TODO: Only results for first client are uploaded
-                        # https://github.com/microsoft/CCF/issues/1046
-                        # https://github.com/microsoft/CCF/issues/6126
-                        # if remote_client == clients[0]:
-                        #     LOG.success(f"Uploading results for {remote_client.name}")
-                        #     metrics.put(args.label, perf_result)
-                        # else:
-                        #     LOG.warning(f"Skipping upload for {remote_client.name}")
-
                     primary, _ = network.find_primary()
                     with primary.client() as nc:
                         r = nc.get("/node/memory")

tests/infra/runner.py

@@ -160,15 +160,6 @@ def run(get_command, args):
                         perf_result = remote_client.get_result()
                         LOG.success(f"{args.label}/{remote_client.name}: {perf_result}")
 
-                        # TODO: Only results for first client are uploaded
-                        # https://github.com/microsoft/CCF/issues/1046
-                        # https://github.com/microsoft/CCF/issues/6126
-                        # if remote_client == clients[0]:
-                        #     LOG.success(f"Uploading results for {remote_client.name}")
-                        #     metrics.put(args.label, perf_result)
-                        # else:
-                        #     LOG.warning(f"Skipping upload for {remote_client.name}")
-
                     primary, _ = network.find_primary()
                     with primary.client() as nc:
                         r = nc.get("/node/memory")