зеркало из https://github.com/microsoft/DeepSpeed.git
99e9cbed16
There is a typing error & inconsistency in cpu-adam code, while not affecting functionality, impacts code readability. Specifically, the type name `ds_params_percision_t` contains a typo ('percision'), whereas the related type name `ds_state_precision_t` is spelled correctly. I think it is beneficial to fix this typo&inconsistency to improve code readability, maintainability and further development. I have tested the corrected version of cpu_adam, and it compiles and runs successfully. Compilation Log: <img width="2560" alt="image" src="https://github.com/user-attachments/assets/b7bc307d-9c9d-4ab7-8671-34e565903ca5"> Co-authored-by: Logan Adams <114770087+loadams@users.noreply.github.com> Co-authored-by: Olatunji Ruwase <olruwase@microsoft.com> |
||
---|---|---|
.. | ||
StopWatch.h | ||
Timer.h | ||
activation_type.h | ||
compat.h | ||
context.h | ||
conversion_utils.h | ||
cpu_adagrad.h | ||
cpu_adam.h | ||
cpu_lion.h | ||
cublas_wrappers.h | ||
custom_cuda_layers.h | ||
dequantization_utils.h | ||
dropout.h | ||
ds_kernel_utils.h | ||
ds_transformer_cuda.h | ||
feed_forward.h | ||
gelu.h | ||
gemm_test.h | ||
general_kernels.h | ||
memory_access_utils.h | ||
normalize_layer.h | ||
quantization.h | ||
quantization_utils.h | ||
quantizer.h | ||
reduction_utils.h | ||
simd.h | ||
softmax.h | ||
strided_batch_gemm.h | ||
type_shim.h |