From 2ae63c93833dcc957d9b4e0c91053e64ccf25d1e Mon Sep 17 00:00:00 2001 From: Tex Riddell Date: Tue, 6 Feb 2024 15:48:01 -0800 Subject: [PATCH] NFC: Resolve PRERELEASE-TODO cases related to deep RDAT validation (#6226) These TODOs were intended for if we were to implement deep RDAT validation rather than relying on the exact binary comparison. This isn't happening for SM 6.8, so these are no longer PRERELEASE-TODOs. The comment in RDAT_Macros.inl didn't really belong there in the first place, so I removed it. Fixes #5699. --- include/dxc/DxilContainer/DxilRuntimeReflection.inl | 4 ++-- include/dxc/DxilContainer/RDAT_Macros.inl | 3 --- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/include/dxc/DxilContainer/DxilRuntimeReflection.inl b/include/dxc/DxilContainer/DxilRuntimeReflection.inl index a0f9e8b0f..9850484a5 100644 --- a/include/dxc/DxilContainer/DxilRuntimeReflection.inl +++ b/include/dxc/DxilContainer/DxilRuntimeReflection.inl @@ -167,9 +167,9 @@ bool DxilRuntimeData::InitFromRDAT(const void *pRDAT, size_t size) { return false; } -// PRERELEASE-TODO: Incorporate field names and report errors in error stream +// TODO: Incorporate field names and report errors in error stream -// PRERELEASE-TODO: Low-pri: Check other things like that all the index, string, +// TODO: Low-pri: Check other things like that all the index, string, // and binary buffer space is actually used. template diff --git a/include/dxc/DxilContainer/RDAT_Macros.inl b/include/dxc/DxilContainer/RDAT_Macros.inl index da550538b..e12e0bb27 100644 --- a/include/dxc/DxilContainer/RDAT_Macros.inl +++ b/include/dxc/DxilContainer/RDAT_Macros.inl @@ -46,9 +46,6 @@ // DEF_RDAT_TYPES and DEF_RDAT_ENUMS - define structural validation #define DEF_RDAT_STRUCT_VALIDATION 13 -// PRERELEASE-TODO: deeper validation for DxilValidation (limiting enum values -// and other such things) - // clang-format off #define CLOSE_COMPOUND_DECL }; // clang-format on