diff --git a/include/dxc/Test/HlslTestUtils.h b/include/dxc/Test/HlslTestUtils.h index 33cd026d8..615dac4d8 100644 --- a/include/dxc/Test/HlslTestUtils.h +++ b/include/dxc/Test/HlslTestUtils.h @@ -26,10 +26,8 @@ using namespace std; -#ifndef HLSLDATAFILEPARAM #define HLSLDATAFILEPARAM L"HlslDataDir" #define FILECHECKDUMPDIRPARAM L"FileCheckDumpDir" -#endif // If TAEF verify macros are available, use them to alias other legacy // comparison macros that don't have a direct translation. diff --git a/projects/dxilconv/unittests/DxilConvTests.cpp b/projects/dxilconv/unittests/DxilConvTests.cpp index 6377c78ea..93ff72fd2 100644 --- a/projects/dxilconv/unittests/DxilConvTests.cpp +++ b/projects/dxilconv/unittests/DxilConvTests.cpp @@ -27,10 +27,7 @@ #include #include "dxc/test/HLSLTestData.h" - -#define HLSLDATAFILEPARAM L"DxilConvDataDir" #include "dxc/test/HlslTestUtils.h" - #include "dxc/test/DxcTestUtils.h" #include "llvm/Support/raw_os_ostream.h" diff --git a/projects/dxilconv/unittests/dxilconv-tests.vcxproj.user.txt b/projects/dxilconv/unittests/dxilconv-tests.vcxproj.user.txt index 799a57e9d..d402f6a4c 100644 --- a/projects/dxilconv/unittests/dxilconv-tests.vcxproj.user.txt +++ b/projects/dxilconv/unittests/dxilconv-tests.vcxproj.user.txt @@ -3,7 +3,7 @@ ${DOS_TAEF_BIN_DIR}\$(PlatformTarget)\Te.exe ${DOS_TAEF_BIN_DIR}\amd64\Te.exe - $(TargetPath) /inproc /p:"DxilConvDataDir=${DOS_STYLE_SOURCE_DIR}\..\test" /name:* + $(TargetPath) /inproc /p:"HlslDataDir=${DOS_STYLE_SOURCE_DIR}\..\test" /name:* WindowsLocalDebugger diff --git a/utils/hct/hcttest.cmd b/utils/hct/hcttest.cmd index 6cb171df3..dbcaea486 100644 --- a/utils/hct/hcttest.cmd +++ b/utils/hct/hcttest.cmd @@ -203,10 +203,12 @@ if "%GENERATOR_NINJA%"=="1" ( set TEST_DIR=%HLSL_BLD_DIR%\%BUILD_CONFIG%\test ) +if "%DXILCONV_LOC%"=="" ( + set DXILCONV_LOC=%BIN_DIR% +) if "%TEST_DXILCONV%"=="1" ( - if "%DXILCONV_LOC%"=="" ( set DXILCONV_LOC=%BIN_DIR%\dxilconv.dll ) - if not exist "%DXILCONV_LOC%" ( - echo Skipping dxilconv tests, dxilconv.dll not found. + if not exist "%DXILCONV_LOC%\dxilconv.dll" ( + echo Skipping dxilconv tests, dxilconv.dll not found at %DXILCONV_LOC%. set TEST_DXILCONV=0 ) ) @@ -315,7 +317,7 @@ if exist "%HCT_EXTRAS%\hcttest-extras.cmd" ( ) if "%TEST_DXILCONV%"=="1" ( - call :runte dxilconv-tests.dll /p:"DxilConvDataDir=%HLSL_SRC_DIR%\projects\dxilconv\test" %TEST_DXILCONV_FILTER% + call :runte dxilconv-tests.dll /p:"HlslDataDir=%HLSL_SRC_DIR%\projects\dxilconv\test" %TEST_DXILCONV_FILTER% set RES_DXILCONV=!ERRORLEVEL! ) @@ -407,7 +409,7 @@ echo. echo Delete test directory and do not copy binaries or run tests: echo hcttest clean echo. -call :showtesample clang-hlsl-tests.dll /p:"DxilConvDataDir=%HLSL_SRC_DIR%\tools\clang\test\HLSL" +call :showtesample clang-hlsl-tests.dll /p:"HlslDataDir=%HLSL_SRC_DIR%\tools\clang\test\HLSL" goto :eof