Fix pipeline warnings (#438)

* Suppress warning in WRL from Windows SDK 20348

* Fix pipeline warnings

Src/pch.h

@@ -167,7 +167,7 @@
 #endif
 
 #pragma warning(push)
-#pragma warning(disable : 4467 5038 5204 5220)
+#pragma warning(disable : 4467 4986 5038 5204 5220)
 #ifdef __MINGW32__
 #include <wrl/client.h>
 #else

build/DirectXTK-GitHub-GDK-Dev17.yml

@@ -31,6 +31,7 @@ variables:
   GDK_EDITION: $(GDKEditionNumber)
   GDKEnableBWOI: true
   URL_FEED: $(ADOFeedURL)
+  skipNugetSecurityAnalysis: true # We explicitly call this task so we don't need it to be auto-injected
 
 jobs:
 - job: BUILD_GDK
@@ -62,6 +63,8 @@ jobs:
         $clearadd = $doc.configuration.packageSources.PrependChild($newelement)
         $doc.OuterXml | Set-Content $file
 
+  - task: nuget-security-analysis@0
+    displayName: 'Secure Supply Chain Analysis'
   - task: NuGetCommand@2
     displayName: NuGet install PGDK
     inputs:

build/DirectXTK-GitHub-GDK.yml

@@ -53,6 +53,7 @@ variables:
   GDKEnableBWOI: true
   GITHUB_PAT: $(GITHUBPUBLICTOKEN)
   URL_FEED: $(ADOFeedURL)
+  skipNugetSecurityAnalysis: true # We explicitly call this task so we don't need it to be auto-injected
 
 jobs:
 - job: BUILD_GDK
@@ -84,6 +85,8 @@ jobs:
         $clearadd = $doc.configuration.packageSources.PrependChild($newelement)
         $doc.OuterXml | Set-Content $file
 
+  - task: nuget-security-analysis@0
+    displayName: 'Secure Supply Chain Analysis'
   - task: NuGetCommand@2
     displayName: NuGet install PGDK
     inputs:
@@ -152,6 +155,8 @@ jobs:
         $clearadd = $doc.configuration.packageSources.PrependChild($newelement)
         $doc.OuterXml | Set-Content $file
 
+  - task: nuget-security-analysis@0
+    displayName: 'Secure Supply Chain Analysis'
   - task: NuGetCommand@2
     displayName: NuGet install PGDK
     inputs:

build/DirectXTK-GitHub-SDK-prerelease.yml

@@ -28,6 +28,7 @@ variables:
   EXTRACTED_FOLDER: $(ExtractedFolder)
   WSDKEnableBWOI: true
   URL_FEED: $(ADOFeedURL)
+  skipNugetSecurityAnalysis: true # We explicitly call this task so we don't need it to be auto-injected
 
 pool:
   vmImage: windows-2022
@@ -62,6 +63,8 @@ jobs:
         $clearadd = $doc.configuration.packageSources.PrependChild($newelement)
         $doc.OuterXml | Set-Content $file
 
+  - task: nuget-security-analysis@0
+    displayName: 'Secure Supply Chain Analysis'
   - task: NuGetCommand@2
     displayName: NuGet Install WSDK x64
     inputs:
@@ -236,6 +239,8 @@ jobs:
         $clearadd = $doc.configuration.packageSources.PrependChild($newelement)
         $doc.OuterXml | Set-Content $file
 
+  - task: nuget-security-analysis@0
+    displayName: 'Secure Supply Chain Analysis'
   - task: NuGetCommand@2
     displayName: NuGet Install WSDK x64
     inputs:
@@ -307,6 +312,8 @@ jobs:
         $clearadd = $doc.configuration.packageSources.PrependChild($newelement)
         $doc.OuterXml | Set-Content $file
 
+  - task: nuget-security-analysis@0
+    displayName: 'Secure Supply Chain Analysis'
   - task: NuGetCommand@2
     displayName: NuGet Install WSDK arm64
     inputs:

build/DirectXTK-GitHub-SDK-release.yml

@@ -28,6 +28,7 @@ variables:
   EXTRACTED_FOLDER: $(ExtractedFolder)
   WSDKEnableBWOI: true
   URL_FEED: $(ADOFeedURL)
+  skipNugetSecurityAnalysis: true # We explicitly call this task so we don't need it to be auto-injected
 
 pool:
   vmImage: windows-2022
@@ -62,6 +63,8 @@ jobs:
         $clearadd = $doc.configuration.packageSources.PrependChild($newelement)
         $doc.OuterXml | Set-Content $file
 
+  - task: nuget-security-analysis@0
+    displayName: 'Secure Supply Chain Analysis'
   - task: NuGetCommand@2
     displayName: NuGet Install WSDK x64
     inputs:
@@ -236,6 +239,8 @@ jobs:
         $clearadd = $doc.configuration.packageSources.PrependChild($newelement)
         $doc.OuterXml | Set-Content $file
 
+  - task: nuget-security-analysis@0
+    displayName: 'Secure Supply Chain Analysis'
   - task: NuGetCommand@2
     displayName: NuGet Install WSDK x64
     inputs:
@@ -307,6 +312,8 @@ jobs:
         $clearadd = $doc.configuration.packageSources.PrependChild($newelement)
         $doc.OuterXml | Set-Content $file
 
+  - task: nuget-security-analysis@0
+    displayName: 'Secure Supply Chain Analysis'
   - task: NuGetCommand@2
     displayName: NuGet Install WSDK arm64
     inputs:

build/DirectXTK-SDL.yml

@@ -25,6 +25,8 @@ name: $(Year:yyyy).$(Month).$(DayOfMonth)$(Rev:.r)
 
 variables:
   VS_GENERATOR: 'Visual Studio 17 2022'
+  URL_FEED: $(ADOFeedURL)
+  skipNugetSecurityAnalysis: true # We explicitly call this task so we don't need it to be auto-injected
 
 pool:
   vmImage: windows-2022
@@ -38,6 +40,24 @@ jobs:
   - checkout: self
     clean: true
     fetchTags: false
+  - task: NuGetCommand@2
+    displayName: 'NuGet set package source to ADO feed'
+    inputs:
+      command: custom
+      arguments: sources add -Name xboxgdk -Source $(URL_FEED) -ConfigFile $(Build.SourcesDirectory)\NuGet.config
+  - task: PowerShell@2
+    displayName: 'Set nuget.config to single source'
+    inputs:
+      targetType: inline
+      script: |
+        $file = '.\NuGet.Config'
+        $doc = [xml](Get-Content $file)
+        $newelement = $doc.CreateElement("clear")
+        $clearadd = $doc.configuration.packageSources.PrependChild($newelement)
+        $doc.OuterXml | Set-Content $file
+
+  - task: nuget-security-analysis@0
+    displayName: 'Secure Supply Chain Analysis'
   - task: NodeTool@0
     displayName: 'NPM install'
     inputs: