diff --git a/Audio/WAVFileReader.cpp b/Audio/WAVFileReader.cpp index 5f82973..14fec9e 100644 --- a/Audio/WAVFileReader.cpp +++ b/Audio/WAVFileReader.cpp @@ -486,18 +486,16 @@ namespace // open the file #if (_WIN32_WINNT >= _WIN32_WINNT_WIN8) - ScopedHandle hFile(safe_handle(CreateFile2(szFileName, - GENERIC_READ, - FILE_SHARE_READ, - OPEN_EXISTING, + ScopedHandle hFile(safe_handle(CreateFile2( + szFileName, + GENERIC_READ, FILE_SHARE_READ, OPEN_EXISTING, nullptr))); #else - ScopedHandle hFile(safe_handle(CreateFileW(szFileName, - GENERIC_READ, - FILE_SHARE_READ, + ScopedHandle hFile(safe_handle(CreateFileW( + szFileName, + GENERIC_READ, FILE_SHARE_READ, nullptr, - OPEN_EXISTING, - FILE_ATTRIBUTE_NORMAL, + OPEN_EXISTING, FILE_ATTRIBUTE_NORMAL, nullptr))); #endif diff --git a/Audio/WaveBankReader.cpp b/Audio/WaveBankReader.cpp index eb1ac65..2335ae4 100644 --- a/Audio/WaveBankReader.cpp +++ b/Audio/WaveBankReader.cpp @@ -519,19 +519,17 @@ HRESULT WaveBankReader::Impl::Open(const wchar_t* szFileName) noexcept(false) CREATEFILE2_EXTENDED_PARAMETERS params = { sizeof(CREATEFILE2_EXTENDED_PARAMETERS), 0, 0, 0, {}, nullptr }; params.dwFileAttributes = FILE_ATTRIBUTE_NORMAL; params.dwFileFlags = FILE_FLAG_OVERLAPPED | FILE_FLAG_SEQUENTIAL_SCAN; - ScopedHandle hFile(safe_handle(CreateFile2(szFileName, - GENERIC_READ, - FILE_SHARE_READ, - OPEN_EXISTING, - ¶ms))); + ScopedHandle hFile(safe_handle(CreateFile2( + szFileName, + GENERIC_READ, FILE_SHARE_READ, OPEN_EXISTING, + ¶ms))); #else - ScopedHandle hFile(safe_handle(CreateFileW(szFileName, - GENERIC_READ, - FILE_SHARE_READ, - nullptr, - OPEN_EXISTING, - FILE_FLAG_OVERLAPPED | FILE_FLAG_SEQUENTIAL_SCAN, - nullptr))); + ScopedHandle hFile(safe_handle(CreateFileW( + szFileName, + GENERIC_READ, FILE_SHARE_READ, + nullptr, + OPEN_EXISTING, FILE_FLAG_OVERLAPPED | FILE_FLAG_SEQUENTIAL_SCAN, + nullptr))); #endif if (!hFile) @@ -554,10 +552,14 @@ HRESULT WaveBankReader::Impl::Open(const wchar_t* szFileName) noexcept(false) DWORD bytes; #if (_WIN32_WINNT >= _WIN32_WINNT_WIN8) + std::ignore = wait; + BOOL result = GetOverlappedResultEx(hFile.get(), &request, &bytes, INFINITE, FALSE); #else if (wait) + { std::ignore = WaitForSingleObject(m_event.get(), INFINITE); + } BOOL result = GetOverlappedResult(hFile.get(), &request, &bytes, FALSE); #endif @@ -602,7 +604,9 @@ HRESULT WaveBankReader::Impl::Open(const wchar_t* szFileName) noexcept(false) result = GetOverlappedResultEx(hFile.get(), &request, &bytes, INFINITE, FALSE); #else if (wait) + { std::ignore = WaitForSingleObject(m_event.get(), INFINITE); + } result = GetOverlappedResult(hFile.get(), &request, &bytes, FALSE); #endif @@ -686,7 +690,9 @@ HRESULT WaveBankReader::Impl::Open(const wchar_t* szFileName) noexcept(false) result = GetOverlappedResultEx(hFile.get(), &request, &bytes, INFINITE, FALSE); #else if (wait) + { std::ignore = WaitForSingleObject(m_event.get(), INFINITE); + } result = GetOverlappedResult(hFile.get(), &request, &bytes, FALSE); #endif @@ -737,7 +743,9 @@ HRESULT WaveBankReader::Impl::Open(const wchar_t* szFileName) noexcept(false) result = GetOverlappedResultEx(hFile.get(), &request, &bytes, INFINITE, FALSE); #else if (wait) + { std::ignore = WaitForSingleObject(m_event.get(), INFINITE); + } result = GetOverlappedResult(hFile.get(), &request, &bytes, FALSE); #endif @@ -788,7 +796,9 @@ HRESULT WaveBankReader::Impl::Open(const wchar_t* szFileName) noexcept(false) result = GetOverlappedResultEx(hFile.get(), &request, &bytes, INFINITE, FALSE); #else if (wait) + { std::ignore = WaitForSingleObject(m_event.get(), INFINITE); + } result = GetOverlappedResult(hFile.get(), &request, &bytes, FALSE); #endif diff --git a/Src/BinaryReader.cpp b/Src/BinaryReader.cpp index d8947c8..e1cf143 100644 --- a/Src/BinaryReader.cpp +++ b/Src/BinaryReader.cpp @@ -56,9 +56,17 @@ HRESULT BinaryReader::ReadEntireFile( // Open the file. #if (_WIN32_WINNT >= _WIN32_WINNT_WIN8) - ScopedHandle hFile(safe_handle(CreateFile2(fileName, GENERIC_READ, FILE_SHARE_READ, OPEN_EXISTING, nullptr))); + ScopedHandle hFile(safe_handle(CreateFile2( + fileName, + GENERIC_READ, FILE_SHARE_READ, OPEN_EXISTING, + nullptr))); #else - ScopedHandle hFile(safe_handle(CreateFileW(fileName, GENERIC_READ, FILE_SHARE_READ, nullptr, OPEN_EXISTING, FILE_ATTRIBUTE_NORMAL, nullptr))); + ScopedHandle hFile(safe_handle(CreateFileW( + fileName, + GENERIC_READ, FILE_SHARE_READ, + nullptr, + OPEN_EXISTING, FILE_ATTRIBUTE_NORMAL, + nullptr))); #endif if (!hFile) diff --git a/Src/LoaderHelpers.h b/Src/LoaderHelpers.h index e88183c..25c608f 100644 --- a/Src/LoaderHelpers.h +++ b/Src/LoaderHelpers.h @@ -366,19 +366,17 @@ namespace DirectX // open the file #if (_WIN32_WINNT >= _WIN32_WINNT_WIN8) - ScopedHandle hFile(safe_handle(CreateFile2(fileName, - GENERIC_READ, - FILE_SHARE_READ, - OPEN_EXISTING, - nullptr))); + ScopedHandle hFile(safe_handle(CreateFile2( + fileName, + GENERIC_READ, FILE_SHARE_READ, OPEN_EXISTING, + nullptr))); #else - ScopedHandle hFile(safe_handle(CreateFileW(fileName, - GENERIC_READ, - FILE_SHARE_READ, - nullptr, - OPEN_EXISTING, - FILE_ATTRIBUTE_NORMAL, - nullptr))); + ScopedHandle hFile(safe_handle(CreateFileW( + fileName, + GENERIC_READ, FILE_SHARE_READ, + nullptr, + OPEN_EXISTING, FILE_ATTRIBUTE_NORMAL, + nullptr))); #endif if (!hFile) diff --git a/Src/ScreenGrab.cpp b/Src/ScreenGrab.cpp index 4401d92..11354a1 100644 --- a/Src/ScreenGrab.cpp +++ b/Src/ScreenGrab.cpp @@ -270,7 +270,10 @@ HRESULT DirectX::SaveDDSTextureToFile( return hr; // Create file - ScopedHandle hFile(safe_handle(CreateFile2(fileName, GENERIC_WRITE, 0, CREATE_ALWAYS, nullptr))); + ScopedHandle hFile(safe_handle(CreateFile2( + fileName, + GENERIC_WRITE, 0, CREATE_ALWAYS, + nullptr))); if (!hFile) return HRESULT_FROM_WIN32(GetLastError()); @@ -427,7 +430,10 @@ HRESULT DirectX::SaveDDSTextureToFile( //-------------------------------------------------------------------------------------- namespace DirectX { - extern IWICImagingFactory2* _GetWIC() noexcept; + namespace Internal + { + extern IWICImagingFactory2* GetWIC() noexcept; + } } _Use_decl_annotations_ @@ -442,6 +448,8 @@ HRESULT DirectX::SaveWICTextureToFile( std::function setCustomProps, bool forceSRGB) { + using namespace DirectX::Internal; + if (!fileName) return E_INVALIDARG; @@ -534,7 +542,7 @@ HRESULT DirectX::SaveWICTextureToFile( return HRESULT_FROM_WIN32(ERROR_NOT_SUPPORTED); } - auto pWIC = _GetWIC(); + auto pWIC = GetWIC(); if (!pWIC) return E_NOINTERFACE; diff --git a/Src/WICTextureLoader.cpp b/Src/WICTextureLoader.cpp index 034114f..7abcd9d 100644 --- a/Src/WICTextureLoader.cpp +++ b/Src/WICTextureLoader.cpp @@ -154,32 +154,36 @@ namespace //-------------------------------------------------------------------------------------- namespace DirectX { - IWICImagingFactory2* _GetWIC() noexcept; - // Also used by ScreenGrab - - IWICImagingFactory2* _GetWIC() noexcept + namespace Internal { - static INIT_ONCE s_initOnce = INIT_ONCE_STATIC_INIT; - - IWICImagingFactory2* factory = nullptr; - if (!InitOnceExecuteOnce( - &s_initOnce, - InitializeWICFactory, - nullptr, - reinterpret_cast(&factory))) - { - return nullptr; - } - - return factory; + IWICImagingFactory2* GetWIC() noexcept; + // Also used by ScreenGrab } -} // namespace DirectX +} +IWICImagingFactory2* DirectX::Internal::GetWIC() noexcept +{ + static INIT_ONCE s_initOnce = INIT_ONCE_STATIC_INIT; + + IWICImagingFactory2* factory = nullptr; + if (!InitOnceExecuteOnce( + &s_initOnce, + InitializeWICFactory, + nullptr, + reinterpret_cast(&factory))) + { + return nullptr; + } + + return factory; +} + +using namespace Internal; namespace { //--------------------------------------------------------------------------------- - DXGI_FORMAT _WICToDXGI(const GUID& guid) noexcept + DXGI_FORMAT WICToDXGI(const GUID& guid) noexcept { for (size_t i = 0; i < std::size(g_WICFormats); ++i) { @@ -191,9 +195,9 @@ namespace } //--------------------------------------------------------------------------------- - size_t _WICBitsPerPixel(REFGUID targetGuid) noexcept + size_t WICBitsPerPixel(REFGUID targetGuid) noexcept { - auto pWIC = _GetWIC(); + auto pWIC = GetWIC(); if (!pWIC) return 0; @@ -283,7 +287,7 @@ namespace size_t bpp = 0; - DXGI_FORMAT format = _WICToDXGI(pixelFormat); + DXGI_FORMAT format = WICToDXGI(pixelFormat); if (format == DXGI_FORMAT_UNKNOWN) { for (size_t i = 0; i < std::size(g_WICConvert); ++i) @@ -292,9 +296,9 @@ namespace { memcpy_s(&convertGUID, sizeof(WICPixelFormatGUID), &g_WICConvert[i].target, sizeof(GUID)); - format = _WICToDXGI(g_WICConvert[i].target); + format = WICToDXGI(g_WICConvert[i].target); assert(format != DXGI_FORMAT_UNKNOWN); - bpp = _WICBitsPerPixel(convertGUID); + bpp = WICBitsPerPixel(convertGUID); break; } } @@ -310,7 +314,7 @@ namespace } else { - bpp = _WICBitsPerPixel(pixelFormat); + bpp = WICBitsPerPixel(pixelFormat); } if (loadFlags & WIC_LOADER_FORCE_RGBA32) @@ -427,7 +431,7 @@ namespace else if (twidth != width || theight != height) { // Resize - auto pWIC = _GetWIC(); + auto pWIC = GetWIC(); if (!pWIC) return E_NOINTERFACE; @@ -478,7 +482,7 @@ namespace else { // Format conversion but no resize - auto pWIC = _GetWIC(); + auto pWIC = GetWIC(); if (!pWIC) return E_NOINTERFACE; @@ -578,14 +582,14 @@ namespace if (FAILED(frame->GetPixelFormat(&pixelFormat))) return DXGI_FORMAT_UNKNOWN; - DXGI_FORMAT format = _WICToDXGI(pixelFormat); + DXGI_FORMAT format = WICToDXGI(pixelFormat); if (format == DXGI_FORMAT_UNKNOWN) { for (size_t i = 0; i < std::size(g_WICConvert); ++i) { if (memcmp(&g_WICConvert[i].source, &pixelFormat, sizeof(WICPixelFormatGUID)) == 0) { - return _WICToDXGI(g_WICConvert[i].target); + return WICToDXGI(g_WICConvert[i].target); } } } @@ -667,7 +671,7 @@ HRESULT DirectX::LoadWICTextureFromMemoryEx( if (wicDataSize > UINT32_MAX) return HRESULT_FROM_WIN32(ERROR_FILE_TOO_LARGE); - auto pWIC = _GetWIC(); + auto pWIC = GetWIC(); if (!pWIC) return E_NOINTERFACE; @@ -730,7 +734,7 @@ HRESULT DirectX::CreateWICTextureFromMemoryEx( if (wicDataSize > UINT32_MAX) return HRESULT_FROM_WIN32(ERROR_FILE_TOO_LARGE); - auto pWIC = _GetWIC(); + auto pWIC = GetWIC(); if (!pWIC) return E_NOINTERFACE; @@ -861,7 +865,7 @@ HRESULT DirectX::LoadWICTextureFromFileEx( if (!d3dDevice || !fileName || !texture) return E_INVALIDARG; - auto pWIC = _GetWIC(); + auto pWIC = GetWIC(); if (!pWIC) return E_NOINTERFACE; @@ -910,7 +914,7 @@ HRESULT DirectX::CreateWICTextureFromFileEx( if (!d3dDevice || !fileName || !texture) return E_INVALIDARG; - auto pWIC = _GetWIC(); + auto pWIC = GetWIC(); if (!pWIC) return E_NOINTERFACE; diff --git a/Src/XboxDDSTextureLoader.cpp b/Src/XboxDDSTextureLoader.cpp index 2c9e8e6..a2551bb 100644 --- a/Src/XboxDDSTextureLoader.cpp +++ b/Src/XboxDDSTextureLoader.cpp @@ -85,10 +85,9 @@ namespace } // open the file - ScopedHandle hFile(safe_handle(CreateFile2(fileName, - GENERIC_READ, - FILE_SHARE_READ, - OPEN_EXISTING, + ScopedHandle hFile(safe_handle(CreateFile2( + fileName, + GENERIC_READ, FILE_SHARE_READ, OPEN_EXISTING, nullptr))); if (!hFile) diff --git a/Src/d3dx12.h b/Src/d3dx12.h index 0b09386..623d0ef 100644 --- a/Src/d3dx12.h +++ b/Src/d3dx12.h @@ -2463,16 +2463,16 @@ template CD3DX12_PIPELINE_STATE_STREAM_FLAGS;