Code review for standard library header usage for standalone mods

DDSTextureLoader/DDSTextureLoader11.cpp

@@ -16,8 +16,8 @@
 
 #include "DDSTextureLoader11.h"
 
-#include <assert.h>
 #include <algorithm>
+#include <cassert>
 #include <memory>
 
 #ifdef __clang__

DDSTextureLoader/DDSTextureLoader11.h

@@ -18,6 +18,7 @@
 
 #include <d3d11_1.h>
 
+#include <cstddef>
 #include <cstdint>
 
 

DDSTextureLoader/DDSTextureLoader12.cpp

@@ -16,8 +16,8 @@
 
 #include "DDSTextureLoader12.h"
 
-#include <assert.h>
 #include <algorithm>
+#include <cassert>
 #include <memory>
 
 #ifdef __clang__

DDSTextureLoader/DDSTextureLoader12.h

@@ -18,6 +18,7 @@
 
 #include <d3d12.h>
 
+#include <cstddef>
 #include <cstdint>
 #include <memory>
 #include <vector>

DDSTextureLoader/DDSTextureLoader9.cpp

@@ -18,8 +18,9 @@
 
 #include <d3d9types.h>
 
-#include <assert.h>
 #include <algorithm>
+#include <cassert>
+#include <cstring>
 #include <memory>
 
 #include <wrl/client.h>

DDSTextureLoader/DDSTextureLoader9.h

@@ -21,6 +21,7 @@
 
 #include <d3d9.h>
 
+#include <cstddef>
 #include <cstdint>
 
 

ScreenGrab/ScreenGrab11.cpp

@@ -23,8 +23,10 @@
 
 #include "ScreenGrab11.h"
 
-#include <assert.h>
 #include <algorithm>
+#include <cassert>
+#include <cstddef>
+#include <cstring>
 #include <memory>
 
 #include <wincodec.h>

ScreenGrab/ScreenGrab12.cpp

@@ -23,8 +23,10 @@
 
 #include "ScreenGrab12.h"
 
-#include <assert.h>
 #include <algorithm>
+#include <cassert>
+#include <cstddef>
+#include <cstring>
 #include <memory>
 
 #include <wincodec.h>

ScreenGrab/ScreenGrab9.cpp

@@ -17,8 +17,10 @@
 
 #include "ScreenGrab9.h"
 
-#include <assert.h>
 #include <algorithm>
+#include <cassert>
+#include <cstddef>
+#include <cstring>
 #include <memory>
 
 #include <wincodec.h>

WICTextureLoader/WICTextureLoader11.cpp

@@ -27,13 +27,14 @@
 #include "WICTextureLoader11.h"
 
 #include <dxgiformat.h>
-#include <assert.h>
 
 #include <wincodec.h>
 
 #include <wrl\client.h>
 
 #include <algorithm>
+#include <cassert>
+#include <cstring>
 #include <memory>
 
 #ifdef __clang__
@@ -41,6 +42,13 @@
 #pragma clang diagnostic ignored "-Wswitch-enum"
 #endif
 
+// Off by default warnings
+#pragma warning(disable : 4619 4616 4623 4626 5027)
+// C4619/4616 #pragma warning warnings
+// C4623 default constructor was implicitly defined as deleted
+// C4626 assignment operator was implicitly defined as deleted
+// C5027 move assignment operator was implicitly defined as deleted
+
 using namespace DirectX;
 using Microsoft::WRL::ComPtr;
 

WICTextureLoader/WICTextureLoader11.h

@@ -25,6 +25,7 @@
 
 #include <d3d11_1.h>
 
+#include <cstddef>
 #include <cstdint>
 
 namespace DirectX

WICTextureLoader/WICTextureLoader12.cpp

@@ -23,8 +23,9 @@
 
 #include "WICTextureLoader12.h"
 
-#include <assert.h>
 #include <algorithm>
+#include <cassert>
+#include <cstring>
 
 #include <wincodec.h>
 
@@ -37,6 +38,13 @@
 #pragma clang diagnostic ignored "-Wswitch-enum"
 #endif
 
+// Off by default warnings
+#pragma warning(disable : 4619 4616 4623 4626 5027)
+// C4619/4616 #pragma warning warnings
+// C4623 default constructor was implicitly defined as deleted
+// C4626 assignment operator was implicitly defined as deleted
+// C5027 move assignment operator was implicitly defined as deleted
+
 #define D3DX12_NO_STATE_OBJECT_HELPERS
 #include "d3dx12.h"
 

WICTextureLoader/WICTextureLoader12.h

@@ -22,6 +22,7 @@
 
 #include <d3d12.h>
 
+#include <cstddef>
 #include <cstdint>
 #include <memory>
 

WICTextureLoader/WICTextureLoader9.cpp

@@ -24,8 +24,9 @@
 
 #include <d3d9types.h>
 
-#include <assert.h>
 #include <algorithm>
+#include <cassert>
+#include <cstring>
 #include <memory>
 
 #include <wincodec.h>
@@ -37,6 +38,13 @@
 #pragma clang diagnostic ignored "-Wswitch-enum"
 #endif
 
+// Off by default warnings
+#pragma warning(disable : 4619 4616 4623 4626 5027)
+// C4619/4616 #pragma warning warnings
+// C4623 default constructor was implicitly defined as deleted
+// C4626 assignment operator was implicitly defined as deleted
+// C5027 move assignment operator was implicitly defined as deleted
+
 using namespace DirectX;
 using Microsoft::WRL::ComPtr;
 

WICTextureLoader/WICTextureLoader9.h

@@ -24,6 +24,7 @@
 #endif
 #include <d3d9.h>
 
+#include <cstddef>
 #include <cstdint>
 
 namespace DirectX