Moving common-definitions and common-utils out of mono-repo (#1065)

These packages are shared amongst client and server code. Pulling them out of client code so we don't have circular dependencies between the mono-repo.

.gitignore

@@ -14,4 +14,4 @@ package-deps.json
 *.tsbuildinfo
 
 # Temporary api-extractor build artifacts
-packages/_api-extractor-temp/**
+**/_api-extractor-temp/**

common/lib/common-definitions/.npmrc

@@ -0,0 +1,31 @@
+registry=https://registry.npmjs.org/
+always-auth=false
+
+//packages.wu2.prague.office-int.com/:_authToken="mQ12JIgL/OVL2fiPinbqIA=="
+//packages.wu2.prague.office-int.com/:always-auth=true
+@prague:registry=https://packages.wu2.prague.office-int.com
+@prague:always-auth=true
+
+@chaincode:registry=https://packages.wu2.prague.office-int.com
+@chaincode:always-auth=true
+
+@component:registry=https://packages.wu2.prague.office-int.com
+@component:always-auth=true
+
+@ms:registry=https://packages.wu2.prague.office-int.com
+@ms:always-auth=true
+
+@tiny-calc:registry=https://packages.wu2.prague.office-int.com
+@tiny-calc:always-auth=true
+
+@tiny:registry=https://packages.wu2.prague.office-int.com
+@tiny:always-auth=true
+
+@microsoft:registry=https://packages.wu2.prague.office-int.com
+@microsoft:always-auth=true
+
+@fluid-internal:registry=https://packages.wu2.prague.office-int.com
+@fluid-internal:always-auth=true
+
+@fluid-example:registry=https://packages.wu2.prague.office-int.com
+@fluid-example:always-auth=true

common/lib/common-definitions/package.json

@@ -11,8 +11,8 @@
   "types": "dist/index.d.ts",
   "scripts": {
     "build": "concurrently npm:build:compile npm:lint",
+    "build:ci": "npm run build:compile",
     "build:compile": "concurrently npm:tsc npm:build:esnext",
-    "build:compile:min": "npm run build:compile",
     "build:docs": "api-extractor run --local",
     "build:esnext": "tsc --project ./tsconfig.esnext.json",
     "build:full": "npm run build",
@@ -22,6 +22,7 @@
     "eslint:fix": "eslint --ext=ts,tsx --format stylish src --fix",
     "lint": "npm run eslint",
     "lint:fix": "npm run eslint:fix",
+    "test:ci": "echo No test for this package",
     "tsc": "tsc",
     "tsc:watch": "tsc --watch"
   },

common/lib/common-utils/.npmrc

@@ -0,0 +1,31 @@
+registry=https://registry.npmjs.org/
+always-auth=false
+
+//packages.wu2.prague.office-int.com/:_authToken="mQ12JIgL/OVL2fiPinbqIA=="
+//packages.wu2.prague.office-int.com/:always-auth=true
+@prague:registry=https://packages.wu2.prague.office-int.com
+@prague:always-auth=true
+
+@chaincode:registry=https://packages.wu2.prague.office-int.com
+@chaincode:always-auth=true
+
+@component:registry=https://packages.wu2.prague.office-int.com
+@component:always-auth=true
+
+@ms:registry=https://packages.wu2.prague.office-int.com
+@ms:always-auth=true
+
+@tiny-calc:registry=https://packages.wu2.prague.office-int.com
+@tiny-calc:always-auth=true
+
+@tiny:registry=https://packages.wu2.prague.office-int.com
+@tiny:always-auth=true
+
+@microsoft:registry=https://packages.wu2.prague.office-int.com
+@microsoft:always-auth=true
+
+@fluid-internal:registry=https://packages.wu2.prague.office-int.com
+@fluid-internal:always-auth=true
+
+@fluid-example:registry=https://packages.wu2.prague.office-int.com
+@fluid-example:always-auth=true

common/lib/common-utils/package.json

@@ -12,8 +12,8 @@
   "scripts": {
     "bench": "ts-node bench/src/index.ts",
     "build": "npm run build:genver && concurrently npm:build:compile npm:lint",
+    "build:ci": "npm run build:genver && npm run build:compile",
     "build:compile": "concurrently npm:tsc npm:build:esnext",
-    "build:compile:min": "npm run build:compile",
     "build:docs": "api-extractor run --local",
     "build:esnext": "tsc --project ./tsconfig.esnext.json",
     "build:full": "npm run build",
@@ -25,6 +25,7 @@
     "lint": "npm run eslint",
     "lint:fix": "npm run eslint:fix",
     "test": "npm run test:mocha",
+    "test:ci": "npm run test",
     "test:coverage": "nyc npm test -- --reporter mocha-junit-reporter --reporter-options mochaFile=nyc/junit-report.xml",
     "test:mocha": "mocha --recursive dist/test -r make-promises-safe",
     "tsc": "tsc"

packages/loader/common-definitions/package-lock.json

@@ -1,14 +0,0 @@
-{
-	"name": "@microsoft/fluid-common-definitions",
-	"version": "0.13.0",
-	"lockfileVersion": 1,
-	"requires": true,
-	"dependencies": {
-		"typescript": {
-			"version": "3.7.4",
-			"resolved": "https://registry.npmjs.org/typescript/-/typescript-3.7.4.tgz",
-			"integrity": "sha512-A25xv5XCtarLwXpcDNZzCGvW2D1S3/bACratYBx2sax8PefsFhlYmkQicKHvpYflFS8if4zne5zT5kpJ7pzuvw==",
-			"dev": true
-		}
-	}
-}

packages/loader/utils/package-lock.json

@@ -1,14 +0,0 @@
-{
-	"name": "@microsoft/fluid-core-utils",
-	"version": "0.13.0",
-	"lockfileVersion": 1,
-	"requires": true,
-	"dependencies": {
-		"typescript": {
-			"version": "3.7.4",
-			"resolved": "https://registry.npmjs.org/typescript/-/typescript-3.7.4.tgz",
-			"integrity": "sha512-A25xv5XCtarLwXpcDNZzCGvW2D1S3/bACratYBx2sax8PefsFhlYmkQicKHvpYflFS8if4zne5zT5kpJ7pzuvw==",
-			"dev": true
-		}
-	}
-}

server/routerlicious/Dockerfile

@@ -64,7 +64,6 @@ COPY packages/framework/aqueduct-react/package*.json packages/framework/aqueduct
 COPY packages/framework/experimental/package*.json packages/framework/experimental/
 COPY packages/framework/framework-definitions/package*.json packages/framework/framework-definitions/
 COPY packages/framework/undo-redo/package*.json packages/framework/undo-redo/
-COPY packages/loader/common-definitions/package*.json packages/loader/common-definitions/
 COPY packages/loader/component-core-interfaces/package*.json packages/loader/component-core-interfaces/
 COPY packages/loader/container-definitions/package*.json packages/loader/container-definitions/
 COPY packages/loader/container-loader/package*.json packages/loader/container-loader/
@@ -72,7 +71,6 @@ COPY packages/loader/driver-definitions/package*.json packages/loader/driver-def
 COPY packages/loader/driver-utils/package*.json packages/loader/driver-utils/
 COPY packages/loader/execution-context-loader/package*.json packages/loader/execution-context-loader/
 COPY packages/loader/loader-web/package*.json packages/loader/loader-web/
-COPY packages/loader/utils/package*.json packages/loader/utils/
 COPY packages/loader/test-loader-utils/package*.json packages/loader/test-loader-utils/
 COPY packages/hosts/base-host/package*.json packages/hosts/base-host/
 COPY packages/hosts/host-service-interfaces/package*.json packages/hosts/host-service-interfaces/

tools/fluid-build/src/layerCheck/layerCheck.ts

@@ -81,6 +81,7 @@ async function main() {
     const resolvedRoot = await getResolvedFluidRoot();
 
     const baseDirectories = [
+        path.join(resolvedRoot, "common"),
         path.join(resolvedRoot, "packages"),
         path.join(resolvedRoot, "samples/chaincode"),
         path.join(resolvedRoot, "server/routerlicious/packages")