From a127c7cebe73daf48dee5969f3d75aa629753630 Mon Sep 17 00:00:00 2001 From: Alex Villarreal <716334+alexvy86@users.noreply.github.com> Date: Tue, 1 Oct 2024 15:22:25 -0500 Subject: [PATCH] refactor(server): Remove deprecated version property from docker-compose files (#22546) ## Description The version property in docker-compose files is deprecated and only used for backwards compatibility. When using the docker-compose files in ADO we get warnings like these: ![image](https://github.com/user-attachments/assets/d9ec81d5-7fc9-4ef7-80a4-8d20502f1e93) I don't think we support using older versions of docker compose so removing the optional/deprecated property seems fine. See https://docs.docker.com/reference/compose-file/version-and-name/#version-top-level-element-optional --- server/docker-compose.dev.yml | 1 - server/docker-compose.yml | 1 - server/gitrest/docker-compose.dev.yml | 1 - server/gitrest/docker-compose.yml | 1 - server/routerlicious/docker-compose.debug.yml | 1 - server/routerlicious/docker-compose.dev.yml | 1 - server/routerlicious/docker-compose.yml | 1 - 7 files changed, 7 deletions(-) diff --git a/server/docker-compose.dev.yml b/server/docker-compose.dev.yml index bd95c3ca1a9..5de11fe4181 100644 --- a/server/docker-compose.dev.yml +++ b/server/docker-compose.dev.yml @@ -1,4 +1,3 @@ -version: "3.4" services: proxy: platform: linux/arm64/v8 diff --git a/server/docker-compose.yml b/server/docker-compose.yml index f660a7db51f..ff43ee80074 100644 --- a/server/docker-compose.yml +++ b/server/docker-compose.yml @@ -1,4 +1,3 @@ -version: "3.4" services: alfred: image: ${REGISTRY_URL:-mcr.microsoft.com}/fluidframework/routerlicious/server:${ALFRED_IMAGE_TAG:-latest} diff --git a/server/gitrest/docker-compose.dev.yml b/server/gitrest/docker-compose.dev.yml index 0e391871c4b..6e7a73aff99 100644 --- a/server/gitrest/docker-compose.dev.yml +++ b/server/gitrest/docker-compose.dev.yml @@ -1,4 +1,3 @@ -version: "3" services: gitrest: volumes: diff --git a/server/gitrest/docker-compose.yml b/server/gitrest/docker-compose.yml index 6661b4c573f..982788fe57d 100644 --- a/server/gitrest/docker-compose.yml +++ b/server/gitrest/docker-compose.yml @@ -1,4 +1,3 @@ -version: "3" services: gitrest: build: diff --git a/server/routerlicious/docker-compose.debug.yml b/server/routerlicious/docker-compose.debug.yml index db104f4fac4..a714ab43a23 100644 --- a/server/routerlicious/docker-compose.debug.yml +++ b/server/routerlicious/docker-compose.debug.yml @@ -1,4 +1,3 @@ -version: "3.4" services: alfred: ports: diff --git a/server/routerlicious/docker-compose.dev.yml b/server/routerlicious/docker-compose.dev.yml index 3ff0f30afa1..977f2b5da28 100644 --- a/server/routerlicious/docker-compose.dev.yml +++ b/server/routerlicious/docker-compose.dev.yml @@ -1,4 +1,3 @@ -version: "3.4" services: alfred: volumes: diff --git a/server/routerlicious/docker-compose.yml b/server/routerlicious/docker-compose.yml index c2bc8c8bf2c..bfb9bd1a4ee 100644 --- a/server/routerlicious/docker-compose.yml +++ b/server/routerlicious/docker-compose.yml @@ -1,4 +1,3 @@ -version: "3.4" services: proxy: image: nginx:latest