* [R-package] enable use of trees with linear models at leaves (fixes#3319)
* remove problematic pragmas
* fix tests
* try to fix build scripts
* try fixing pragma check
* more pragma checks
* ok fix pragma stuff for real
* empty commit
* regenerate documentation
* try skipping test
* uncomment CI
* add note on missing value types for R
* add tests on saving and re-loading booster
* Fix LightGBM models locale sensitivity and improve R/W performance.
When Java is used, the default C++ locale is broken. This is true for
Java providers that use the C API or even Python models that require JEP.
This patch solves that issue making the model reads/writes insensitive
to such settings.
To achieve it, within the model read/write codebase:
- C++ streams are imbued with the classic locale
- Calls to functions that are dependent on the locale are replaced
- The default locale is not changed!
This approach means:
- The user's locale is never tampered with, avoiding issues such as
https://github.com/microsoft/LightGBM/issues/2979 with the previous
approach https://github.com/microsoft/LightGBM/pull/2891
- Datasets can still be read according the user's locale
- The model file has a single format independent of locale
Changes:
- Add CommonC namespace which provides faster locale-independent versions of Common's methods
- Model code makes conversions through CommonC
- Cleanup unused Common methods
- Performance improvements. Use fast libraries for locale-agnostic conversion:
- value->string: https://github.com/fmtlib/fmt
- string->double: https://github.com/lemire/fast_double_parser (10x
faster double parsing according to their benchmark)
Bugfixes:
- https://github.com/microsoft/LightGBM/issues/2500
- https://github.com/microsoft/LightGBM/issues/2890
- https://github.com/ninia/jep/issues/205 (as it is related to LGBM as well)
* Align CommonC namespace
* Add new external_libs/ to python setup
* Try fast_double_parser fix#1
Testing commit e09e5aad828bcb16bea7ed0ed8322e019112fdbe
If it works it should fix more LGBM builds
* CMake: Attempt to link fmt without explicit PUBLIC tag
* Exclude external_libs from linting
* Add exernal_libs to MANIFEST.in
* Set dynamic linking option for fmt.
* linting issues
* Try to fix lint includes
* Try to pass fPIC with static fmt lib
* Try CMake P_I_C option with fmt library
* [R-package] Add CMake support for R and CRAN
* Cleanup CMakeLists
* Try fmt hack to remove stdout
* Switch to header-only mode
* Add PRIVATE argument to target_link_libraries
* use fmt in header-only mode
* Remove CMakeLists comment
* Change OpenMP to PUBLIC linking in Mac
* Update fmt submodule to 7.1.2
* Use fmt in header-only-mode
* Remove fmt from CMakeLists.txt
* Upgrade fast_double_parser to v0.2.0
* Revert "Add PRIVATE argument to target_link_libraries"
This reverts commit 3dd45dde7b92531b2530ab54522bb843c56227a7.
* Address James Lamb's comments
* Update R-package/.Rbuildignore
Co-authored-by: James Lamb <jaylamb20@gmail.com>
* Upgrade to fast_double_parser v0.3.0 - Solaris support
* Use legacy code only in Solaris
* Fix lint issues
* Fix comment
* Address StrikerRUS's comments (solaris ifdef).
* Change header guards
Co-authored-by: James Lamb <jaylamb20@gmail.com>
* Modified script to also remove pragma warnings.
This also includes modifying the scope of the pragma removal.
Previously this script only searched inside the ./src/include/LightGMB directory.
This was not inclusive enough to remove the warnings in files shown in the ticket.
* Adds CI test that exits if unknown pragma warnings are present.
* Expanding pragma removal to cpp and hpp files.
* Update .ci/test_r_package.sh
Removing unneeded conditions since this script will only run on Linux and Mac builds anyway.
Co-authored-by: James Lamb <jaylamb20@gmail.com>
* Update .ci/test_r_package.sh
Fixes typo
Co-authored-by: James Lamb <jaylamb20@gmail.com>
* replacing double quotes with single quotes
* Using a more portable find syntax so it works on macOS and Linux
Co-authored-by: James Lamb <jaylamb20@gmail.com>
* [R-package] make package installable with CRAN toolchain (fixes#2960)
* Apply suggestions from code review
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
* remove GPU stuff
* use wildcard to find objects to build
* use -lomp
* build configure before moving files
* using wildcard for objects
* Update .github/workflows/main.yml
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
* add explicit objects back
* reduce allowed R CMD check NOTEs and catch stderr from build-cran-package on Windows
* fixing things
* pin autoconf version
* show diff
* add automake back
* run less checks
* command was in the wrong place
* fix autoconf version
* change strategy for handling configure
* fix Rbuildignore
* fix NOTEs
* fix notes about unrecognized files
* fixing extra files
* remove USE_R35
* add OpenMP check for Mac CRAN build
* run all checks
* Apply suggestions from code review
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
* suggestions from code review
* undo indenting
* remove 03 from Makevars.win.in
* update language about OpenMP in configure script
* checking if configure.ac check works
* add autoconf back
* remove testing code in configure.ac
* more fixes for CI on configure script
* print git diff
* add VERSION.txt when checking configure
* fix relative paths
* remove git diff
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
James Lamb
Nikita Titov
Alberto Ferreira
Josh Maxwell
Guolin Ke