Add TODO comments for remaining hard-coded paths
This commit is contained in:
Родитель
80361299f0
Коммит
4584fb3878
|
@ -153,6 +153,7 @@ class Spreadsheet:
|
||||||
|
|
||||||
# Collect the commits in the database and not in the workbook, but that we want to include.
|
# Collect the commits in the database and not in the workbook, but that we want to include.
|
||||||
db_commits = self.get_db_commits()
|
db_commits = self.get_db_commits()
|
||||||
|
# TODO (Issue 50): Don't use a hard-coded value here, use --upstream_since instead
|
||||||
tag = "v4.15"
|
tag = "v4.15"
|
||||||
if tag in self.repo.references:
|
if tag in self.repo.references:
|
||||||
LOGGER.info("Skipping commits before tag '%s'!", tag)
|
LOGGER.info("Skipping commits before tag '%s'!", tag)
|
||||||
|
|
|
@ -72,6 +72,7 @@ class Symbols:
|
||||||
self.repo.get_tracked_paths(self.config.upstream.sections),
|
self.repo.get_tracked_paths(self.config.upstream.sections),
|
||||||
)
|
)
|
||||||
|
|
||||||
|
# TODO (Issue 65): Avoid hard-coding commit ID
|
||||||
def map_symbols_to_patch(
|
def map_symbols_to_patch(
|
||||||
self, commits: Iterable[str], paths, prev_commit="097c1bd5673edaf2a162724636858b71f658fdd2"
|
self, commits: Iterable[str], paths, prev_commit="097c1bd5673edaf2a162724636858b71f658fdd2"
|
||||||
):
|
):
|
||||||
|
|
|
@ -111,6 +111,7 @@ class Repo:
|
||||||
paths = set()
|
paths = set()
|
||||||
|
|
||||||
# All tags starting with v4, also master.
|
# All tags starting with v4, also master.
|
||||||
|
# TODO (Issue 66): This uses a hard-coded regex and relies on tags that may not be available
|
||||||
refs = [
|
refs = [
|
||||||
tag
|
tag
|
||||||
for tag in self.obj.git.tag("v[^123]*", list=True).split()
|
for tag in self.obj.git.tag("v[^123]*", list=True).split()
|
||||||
|
|
Загрузка…
Ссылка в новой задаче