Added design time check to the Activity Execution Condition for a Boolean function.

src/WorkflowActivityLibrary.UI/ActivitySettings.Designer.cs

@@ -87,6 +87,15 @@ namespace MicrosoftServices.IdentityManagement.WorkflowActivityLibrary.UI {
             }
         }
         
+        /// <summary>
+        ///   Looks up a localized string similar to The activity execution condition must be a boolean function. Consider wrapping your current condition inside a ConverToBoolean() function..
+        /// </summary>
+        internal static string ActivityExecutionConditionValidationError {
+            get {
+                return ResourceManager.GetString("ActivityExecutionConditionValidationError", resourceCulture);
+            }
+        }
+        
         /// <summary>
         ///   Looks up a localized string similar to Actor String.
         /// </summary>

src/WorkflowActivityLibrary.UI/ActivitySettings.resx

@@ -798,4 +798,7 @@
   <data name="RequestApprovalEscalationEmailTemplateFieldValidationError" xml:space="preserve">
     <value>Escalation email template is required when escalated approvers are specified.</value>
   </data>
+  <data name="ActivityExecutionConditionValidationError" xml:space="preserve">
+    <value>The activity execution condition must be a boolean function. Consider wrapping your current condition inside a ConverToBoolean() function.</value>
+  </data>
 </root>

src/WorkflowActivityLibrary.UI/Forms/AddDelayForm.cs

@@ -289,7 +289,12 @@ namespace MicrosoftServices.IdentityManagement.WorkflowActivityLibrary.UI.Forms
                 {
                     if (!string.IsNullOrEmpty(this.activityExecutionCondition.Value))
                     {
-                        evaluator.ParseExpression(this.activityExecutionCondition.Value);
+                        // Verify that the activity execution condition resolves to a Boolean value
+                        if (!evaluator.IsBooleanExpression(this.activityExecutionCondition.Value))
+                        {
+                            this.controller.ValidationError = ActivitySettings.ActivityExecutionConditionValidationError;
+                            return false;
+                        }
                     }
                 }
                 catch (WorkflowActivityLibraryException ex)

src/WorkflowActivityLibrary.UI/Forms/CreateResourceForm.cs

@@ -484,7 +484,12 @@ namespace MicrosoftServices.IdentityManagement.WorkflowActivityLibrary.UI.Forms
                     {
                         if (!string.IsNullOrEmpty(this.activityExecutionCondition.Value))
                         {
-                            evaluator.ParseExpression(this.activityExecutionCondition.Value);
+                            // Verify that the activity execution condition resolves to a Boolean value
+                            if (!evaluator.IsBooleanExpression(this.activityExecutionCondition.Value))
+                            {
+                                this.controller.ValidationError = ActivitySettings.ActivityExecutionConditionValidationError;
+                                return false;
+                            }
                         }
 
                         if (!string.IsNullOrEmpty(this.iteration.Value))

src/WorkflowActivityLibrary.UI/Forms/DeleteResourcesForm.cs

@@ -343,7 +343,12 @@ namespace MicrosoftServices.IdentityManagement.WorkflowActivityLibrary.UI.Forms
                     {
                         if (!string.IsNullOrEmpty(this.activityExecutionCondition.Value))
                         {
-                            evaluator.ParseExpression(this.activityExecutionCondition.Value);
+                            // Verify that the activity execution condition resolves to a Boolean value
+                            if (!evaluator.IsBooleanExpression(this.activityExecutionCondition.Value))
+                            {
+                                this.controller.ValidationError = ActivitySettings.ActivityExecutionConditionValidationError;
+                                return false;
+                            }
                         }
 
                         if (!string.IsNullOrEmpty(this.iteration.Value))

src/WorkflowActivityLibrary.UI/Forms/GenerateUniqueValueForm.cs

@@ -455,7 +455,12 @@ namespace MicrosoftServices.IdentityManagement.WorkflowActivityLibrary.UI.Forms
                 {
                     if (!string.IsNullOrEmpty(this.activityExecutionCondition.Value))
                     {
-                        evaluator.ParseExpression(this.activityExecutionCondition.Value);
+                        // Verify that the activity execution condition resolves to a Boolean value
+                        if (!evaluator.IsBooleanExpression(this.activityExecutionCondition.Value))
+                        {
+                            this.controller.ValidationError = ActivitySettings.ActivityExecutionConditionValidationError;
+                            return false;
+                        }
                     }
                 }
                 catch (WorkflowActivityLibraryException ex)

src/WorkflowActivityLibrary.UI/Forms/RequestApprovalForm.cs

@@ -361,7 +361,12 @@ namespace MicrosoftServices.IdentityManagement.WorkflowActivityLibrary.UI.Forms
                 {
                     if (!string.IsNullOrEmpty(this.activityExecutionCondition.Value))
                     {
-                        evaluator.ParseExpression(this.activityExecutionCondition.Value);
+                        // Verify that the activity execution condition resolves to a Boolean value
+                        if (!evaluator.IsBooleanExpression(this.activityExecutionCondition.Value))
+                        {
+                            this.controller.ValidationError = ActivitySettings.ActivityExecutionConditionValidationError;
+                            return false;
+                        }
                     }
 
                     ParseApprovers(this.approvers.Value);

src/WorkflowActivityLibrary.UI/Forms/RunPowerShellScriptForm.cs

@@ -526,7 +526,12 @@ namespace MicrosoftServices.IdentityManagement.WorkflowActivityLibrary.UI.Forms
                 {
                     if (!string.IsNullOrEmpty(this.activityExecutionCondition.Value))
                     {
-                        evaluator.ParseExpression(this.activityExecutionCondition.Value);
+                        // Verify that the activity execution condition resolves to a Boolean value
+                        if (!evaluator.IsBooleanExpression(this.activityExecutionCondition.Value))
+                        {
+                            this.controller.ValidationError = ActivitySettings.ActivityExecutionConditionValidationError;
+                            return false;
+                        }
                     }
                 }
                 catch (WorkflowActivityLibraryException ex)

src/WorkflowActivityLibrary.UI/Forms/SendEmailNotificationForm.cs

@@ -330,7 +330,12 @@ namespace MicrosoftServices.IdentityManagement.WorkflowActivityLibrary.UI.Forms
                     {
                         if (!string.IsNullOrEmpty(this.activityExecutionCondition.Value))
                         {
-                            evaluator.ParseExpression(this.activityExecutionCondition.Value);
+                            // Verify that the activity execution condition resolves to a Boolean value
+                            if (!evaluator.IsBooleanExpression(this.activityExecutionCondition.Value))
+                            {
+                                this.controller.ValidationError = ActivitySettings.ActivityExecutionConditionValidationError;
+                                return false;
+                            }
                         }
 
                         ParseRecipient(this.cc.Value);

src/WorkflowActivityLibrary.UI/Forms/UpdateResourcesForm.cs

@@ -413,7 +413,12 @@ namespace MicrosoftServices.IdentityManagement.WorkflowActivityLibrary.UI.Forms
                     {
                         if (!string.IsNullOrEmpty(this.activityExecutionCondition.Value))
                         {
-                            evaluator.ParseExpression(this.activityExecutionCondition.Value);
+                            // Verify that the activity execution condition resolves to a Boolean value
+                            if (!evaluator.IsBooleanExpression(this.activityExecutionCondition.Value))
+                            {
+                                this.controller.ValidationError = ActivitySettings.ActivityExecutionConditionValidationError;
+                                return false;
+                            }
                         }
 
                         if (!string.IsNullOrEmpty(this.iteration.Value))

src/WorkflowActivityLibrary.UI/Forms/VerifyRequestForm.cs

@@ -411,7 +411,12 @@ namespace MicrosoftServices.IdentityManagement.WorkflowActivityLibrary.UI.Forms
                     {
                         if (!string.IsNullOrEmpty(this.activityExecutionCondition.Value))
                         {
-                            evaluator.ParseExpression(this.activityExecutionCondition.Value);
+                            // Verify that the activity execution condition resolves to a Boolean value
+                            if (!evaluator.IsBooleanExpression(this.activityExecutionCondition.Value))
+                            {
+                                this.controller.ValidationError = ActivitySettings.ActivityExecutionConditionValidationError;
+                                return false;
+                            }
                         }
                     }
                 }