Enable validation of ignored warnings (#124)

* Enable warning validation

* Add new lines

* Fix build

Directory.Build.props

@@ -58,8 +58,4 @@
     <!-- Optional: Include the PDB in the built .nupkg -->
     <AllowedOutputExtensionsInPackageBuildOutputFolder>$(AllowedOutputExtensionsInPackageBuildOutputFolder);.pdb</AllowedOutputExtensionsInPackageBuildOutputFolder>
   </PropertyGroup>
-  <!-- Bad properties from old projects to make them work -->
-  <PropertyGroup>
-    <NoWarn>1591;NU5104</NoWarn>
-  </PropertyGroup>
 </Project>

src/DocumentDb/DocumentDbSettings.cs

@@ -12,6 +12,9 @@ namespace Microsoft.Omex.DocumentDb
 	/// </summary>
 	public class DocumentDbSettings
 	{
+		/// <summary> 
+		/// Document db settings class.
+		/// </summary>
 		protected DocumentDbSettings(string endpoint, DocumentDbSettingsConfig config = null)
 		{
 			Code.ExpectsNotNullOrWhiteSpaceArgument(endpoint, nameof(endpoint), TaggingUtilities.ReserveTag(0x2381b146 /* tag_961fg */));

src/Gating/Configuration/GatingConfiguration.cs

@@ -259,6 +259,7 @@ namespace Gating.Configuration
 
         private bool enabledField;
 
+        /// <remarks/>
         public BaseGateType()
         {
             this.secureField = false;
@@ -908,6 +909,7 @@ namespace Gating.Configuration
 
         private string activeForField;
 
+        /// <remarks/>
         public BaseGateTypeService()
         {
             this.activeForField = "All";

src/System.AspNetCore/LogicalCallContext.cs

@@ -28,6 +28,7 @@ namespace Microsoft.Omex.System.AspNetCore
 		private static readonly AsyncLocal<IImmutableStack<IImmutableDictionary<string, object>>> s_stackAsyncLocal = new AsyncLocal<IImmutableStack<IImmutableDictionary<string, object>>>();
 
 
+		/// <summary> Context data stored on LogicalCallContext </summary>
 		public LogicalCallContext(IMachineInformation machineInformation)
 		{
 			MachineInformation = machineInformation;
@@ -174,6 +175,9 @@ namespace Microsoft.Omex.System.AspNetCore
 		}
 
 
+		/// <summary>
+		/// Machine information
+		/// </summary>
 		public static IMachineInformation MachineInformation { get; set; }