Граф коммитов

6 Коммитов

Автор SHA1 Сообщение Дата
Mike Stall 3e4e9fb5c1
Fix IDE rules to not complain about existing code. (#2209)
Opening in VS 17.9.0, something has changed about how VS reads IDE rules
and it's now complinaing about 100s of things.
2024-02-15 20:25:17 +00:00
Mike Stall 1ef5c20ca1
Tweak 2 editor rules. (#966)
I'd like to tweak our Style Cop rules and disable these restrictions:


https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0003-ide0009

https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0007-ide0008

IDE003:
Today, we require 'var' instead of more explicit types --> I'd like to
turn that off because a) sometimes the types are more readable; b)
sometimes it's a nice enforcement check. 

We require:

`var sym = ComputeTables()  // not sure the type `

I want to allow:

`ReadOnlySymbolTable sym = ComputeTables()`

[2] we disallow 'this' qualifiers. --> I'd like to allow them as it also
helps readability and being explicit.  
Today:
`var sym = SpecialValue` // I have to think where SpecialValue came from
... is it instance/static/ from an outer class/ etc? 

I want to allow:
`var sym = this.SpecialValue  // it's an instance property. `

Co-authored-by: Mike Stall <jmstall@microsoft.com>
2023-01-06 14:30:31 +01:00
Luc Genetier a079e229bc
Enable .Net analyzers (#456) 2022-07-06 21:16:00 +02:00
McCall Saltzman 7a9c67d96a
Hygiene: Fix or disable all warnings, enable Warnings-As-Errors (#400)
* Improve local package debugging

* script fix

* More test

* Fix or hide warnings, treat as errors

* Minor changes

* interim

* discussion

* Missed one
2022-05-23 11:02:25 -07:00
McCall Saltzman 1fe70c71cd
Enforce Code Style on build (#98)
Add StyleCop to PowerFx and apply rules
2022-01-11 13:45:22 -08:00
McCall Saltzman 47f0dfc2b1
Snap code from staging branch (#35) 2021-11-01 17:55:50 -07:00