fix comments from review - adding null checks.

This commit is contained in:
ali-hamud 2016-11-14 11:44:15 +02:00
Родитель 23b13fd038
Коммит e72fcc1e45
4 изменённых файлов: 10 добавлений и 16 удалений

Просмотреть файл

@ -38,22 +38,13 @@ function UpdateSessions() {
function SetAccessTokenFromSession() {
var sessionAccessToken = GetSession("accessToken");
if (sessionAccessToken)
{
$("#txtAccessToken").val(sessionAccessToken);
}
$("#txtAccessToken").val(sessionAccessToken);
}
function SetEmbedUrlFromSession() {
var sessionEmbedUrl = GetSession("embedUrl");
if (sessionEmbedUrl)
{
$("#txtReportEmbed").val(sessionEmbedUrl);
}
$("#txtReportEmbed").val(sessionEmbedUrl);
var sessionEmbedId = GetSession("embedId");
if (sessionEmbedId)
{
$("#txtEmbedReportId").val(sessionEmbedId);
}
$("#txtEmbedReportId").val(sessionEmbedId);
}

Просмотреть файл

@ -1,6 +1,6 @@
var embedWithSpecificReportDivExpanded = false;
function ExpandEmbedWithSpecificReportDiv() {
function ToggleEmbedWithSpecificReportDiv() {
if (embedWithSpecificReportDivExpanded == true)
{
embedWithSpecificReportDivExpanded = false;

Просмотреть файл

@ -11,7 +11,10 @@
if (parts && parts.length > 0)
{
var guidParts = parts[parts.length -1].split("&");
id = guidParts[0];
if (guidParts && guidParts.length > 0)
{
id = guidParts[0];
}
}
if (!id)

Просмотреть файл

@ -3,7 +3,7 @@
<h4>Sample Report</h4>
To Embed using a sample report, you can just move to next step.<br/>
<button id="nextStepWithSample" class="btn btn-primary" onclick="OpenEmbedStepWithSample()">Embed Sample Report</button><br/><br/><br/>
<a href="#" onclick="ExpandEmbedWithSpecificReportDiv()">Embed Your Own Report</a><br/>
<a href="#" onclick="ToggleEmbedWithSpecificReportDiv()">Embed Your Own Report</a><br/>
</div>
<div id="EmbedWithSpecificReportDiv" style="display: none;">
<div class="line">
@ -16,7 +16,7 @@
<br/>
<div class="line">
<h4>Flow</h4>
Once you have a report imported to PowerBI Workspace, you are ready to Embed it.<br/>
Once you have a report imported to PowerBI Workspace, you are ready to embed it.<br/>
To Embed a report you need to get an Embed-Token. You can create this token in multiple ways:<br/>
<ul>
<li>Using <a href="https://github.com/Microsoft/PowerBI-cli">PowerBI-Cli</a> tool.<br/></li>