From 843d077da08705b6717c449aa82b56ff94a174b8 Mon Sep 17 00:00:00 2001 From: Clint Rutkas Date: Thu, 31 Dec 2020 10:00:26 -0800 Subject: [PATCH] Updating PR template (#8843) * Updating PR template due to a few recent misses, going to be a bit more rigorous * Update .github/pull_request_template.md Co-authored-by: Enrico Giordani * Update pull_request_template.md Didn't update one instance of wxs Co-authored-by: Enrico Giordani --- .github/pull_request_template.md | 27 ++++++++++++++++----------- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 87aa88b30a..b948638ca5 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,18 +1,23 @@ ## Summary of the Pull Request -_What is this about?_ +**What is this about:** -## PR Checklist -* [ ] Applies to #xxx -* [ ] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/PowerToys) and sign the CLA -* [ ] Tests added/passed -* [ ] Requires documentation to be updated -* [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx +**What is include in the PR:** -## Info on Pull Request +**How does someone test / validate:** -_What does this include?_ +## Quality Checklist -## Validation Steps Performed +- [ ] **Linked issue:** #xxx +- [ ] **Communication:** I've discussed this with core contributors in the issue. +- [ ] **Tests:** Added/updated and all pass +- [ ] **Installer:** Added/updated and all pass +- [ ] **Localization:** All end user facing strings can be localized +- [ ] **Docs:** Added/ updated +- [ ] **Binaries:** Any new files are added to WXS / YML + - [ ] No new binaries + - [ ] [YML for signing](https://github.com/microsoft/PowerToys/blob/master/.pipelines/pipeline.user.windows.yml#L68) for new binaries + - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/master/installer/PowerToysSetup/Product.wxs) for new binaries -_How does someone test & validate?_ +## Contributor License Agreement (CLA) +A CLA must be signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/PowerToys) and sign the CLA.