PR feedback

.github/workflows/ci.yml

@@ -1,10 +1,6 @@
 name: CI
 
-on:
-  push:
-    branches:
-      - "*"
-      - "!master"
+on: pull_request
 
 jobs:
   validate:

README.md

@@ -207,7 +207,7 @@ function New-ResourceGroupRequirement {
         [string]$Location
     )
 
-    New-RequirementGroup "rg" {
+    New-RequirementGroup "rg" -ScriptBlock {
         @{
             Describe = "Logged in to Azure"
             Test     = { Get-AzAccount }
@@ -283,14 +283,14 @@ New-RequirementGroup "local" {
             Set      = { ... }
         }
     }
-} | Invoke-Requirement | Format-Checklist
+}
 New-RequirementGroup "cloud" {
     @{
         Describe = "Terraform is deployed"
         Test     = { ... }
         Set      = { ... }
     }
-} | Invoke-Requirement | Format-Checklist
+}
 ```
 
 The above example would result in the Requirements below.

src/interface.ps1

@@ -137,7 +137,9 @@ function New-RequirementGroup {
   Param(
     # The namespace identifier
     [Parameter(Mandatory, Position = 0)]
-    [string]$Namespace,
+    [Alias("Namespace")]
+    [ValidateNotNullOrEmpty()]
+    [string]$Name,
     # A scriptblock that writes Requirements to output when invoked
     [Parameter(Mandatory, Position = 1, ParameterSetName = "scriptblock")]
     [ValidateNotNullOrEmpty()]

test/integration/Format-Checklist.Set.txt

@@ -1,3 +1,3 @@
-  09:44:13 ns>MyDescribe
+  11:58:32 ns>MyDescribe
                         
-√ 09:44:13 ns>MyDescribe
+√ 11:58:32 ns>MyDescribe

test/integration/Format-Checklist.Test.txt

@@ -1,3 +1,3 @@
-  09:44:13 ns>MyDescribe
+  11:58:32 ns>MyDescribe
                         
-√ 09:44:13 ns>MyDescribe
+√ 11:58:32 ns>MyDescribe

test/integration/Format-Checklist.TestSet.txt

@@ -1,3 +1,3 @@
-  09:44:13 ns>MyDescribe
+  11:58:32 ns>MyDescribe
                         
-√ 09:44:13 ns>MyDescribe
+√ 11:58:32 ns>MyDescribe

test/integration/Format-Table.Set.txt

@@ -1,6 +1,6 @@
 
-Date               Method State Result Requirement
-----               ------ ----- ------ -----------
-12/2/19 9:44:13 PM    Set Start        ns>MyDescribe
-12/2/19 9:44:13 PM    Set  Stop True   ns>MyDescribe
+Date                Method State Result Requirement
+----                ------ ----- ------ -----------
+12/3/19 11:58:32 AM    Set Start        ns>MyDescribe
+12/3/19 11:58:32 AM    Set  Stop True   ns>MyDescribe
 

test/integration/Format-Table.Test.txt

@@ -1,6 +1,6 @@
 
-Date               Method State Result Requirement
-----               ------ ----- ------ -----------
-12/2/19 9:44:13 PM   Test Start        ns>MyDescribe
-12/2/19 9:44:13 PM   Test  Stop True   ns>MyDescribe
+Date                Method State Result Requirement
+----                ------ ----- ------ -----------
+12/3/19 11:58:32 AM   Test Start        ns>MyDescribe
+12/3/19 11:58:32 AM   Test  Stop True   ns>MyDescribe
 

test/integration/Format-Table.TestSet.txt

@@ -1,10 +1,10 @@
 
-Date                 Method State Result Requirement
-----                 ------ ----- ------ -----------
-12/2/19 9:44:13 PM     Test Start        ns>MyDescribe
-12/2/19 9:44:13 PM     Test  Stop False  ns>MyDescribe
-12/2/19 9:44:13 PM      Set Start        ns>MyDescribe
-12/2/19 9:44:13 PM      Set  Stop True   ns>MyDescribe
-12/2/19 9:44:13 PM Validate Start        ns>MyDescribe
-12/2/19 9:44:13 PM Validate  Stop True   ns>MyDescribe
+Date                  Method State Result Requirement
+----                  ------ ----- ------ -----------
+12/3/19 11:58:32 AM     Test Start        ns>MyDescribe
+12/3/19 11:58:32 AM     Test  Stop False  ns>MyDescribe
+12/3/19 11:58:32 AM      Set Start        ns>MyDescribe
+12/3/19 11:58:32 AM      Set  Stop True   ns>MyDescribe
+12/3/19 11:58:32 AM Validate Start        ns>MyDescribe
+12/3/19 11:58:32 AM Validate  Stop True   ns>MyDescribe
 

test/integration/Format-Verbose.Set.txt

@@ -1,2 +1,2 @@
-2019-12-02 21:44:13 Set      Start ns>MyDescribe
-2019-12-02 21:44:13 Set      Stop  ns>MyDescribe
+2019-12-03 11:58:32 Set      Start ns>MyDescribe
+2019-12-03 11:58:32 Set      Stop  ns>MyDescribe

test/integration/Format-Verbose.Test.txt

@@ -1,2 +1,2 @@
-2019-12-02 21:44:13 Test     Start ns>MyDescribe
-2019-12-02 21:44:13 Test     Stop  ns>MyDescribe
+2019-12-03 11:58:32 Test     Start ns>MyDescribe
+2019-12-03 11:58:32 Test     Stop  ns>MyDescribe

test/integration/Format-Verbose.TestSet.txt

@@ -1,6 +1,6 @@
-2019-12-02 21:44:13 Test     Start ns>MyDescribe
-2019-12-02 21:44:13 Test     Stop  ns>MyDescribe
-2019-12-02 21:44:13 Set      Start ns>MyDescribe
-2019-12-02 21:44:13 Set      Stop  ns>MyDescribe
-2019-12-02 21:44:13 Validate Start ns>MyDescribe
-2019-12-02 21:44:13 Validate Stop  ns>MyDescribe
+2019-12-03 11:58:32 Test     Start ns>MyDescribe
+2019-12-03 11:58:32 Test     Stop  ns>MyDescribe
+2019-12-03 11:58:32 Set      Start ns>MyDescribe
+2019-12-03 11:58:32 Set      Stop  ns>MyDescribe
+2019-12-03 11:58:32 Validate Start ns>MyDescribe
+2019-12-03 11:58:32 Validate Stop  ns>MyDescribe