Refactored some `for` loops to the normal pattern. (#709)

Fixes #678.

stl/inc/random

@@ -829,7 +829,7 @@ struct _Swc_traits { // traits for subtract_with_carry generator
 
         for (int _Ix = 0; _Ix < _Nw; ++_Ix) { // pack _Kx words
             _Ax[_Ix] = _Gx();
-            for (int _Jx = 0; ++_Jx < _Kx;) {
+            for (int _Jx = 1; _Jx < _Kx; ++_Jx) {
                 _Ax[_Ix] |= static_cast<_Ty>(_Gx()) << (32 * _Jx);
             }
         }
@@ -934,7 +934,7 @@ public:
         int _Idx0 = 0;
         for (int _Ix = 0; _Ix < _Rx; ++_Ix, _Idx0 += _Kx) { // pack _Kx words
             this->_Ax[_Ix] = _Arr[_Idx0];
-            for (int _Jx = 0; ++_Jx < _Kx;) {
+            for (int _Jx = 1; _Jx < _Kx; ++_Jx) {
                 this->_Ax[_Ix] |= static_cast<_Ty>(_Arr[_Idx0 + _Jx]) << (32 * _Jx);
             }
 
@@ -1263,7 +1263,7 @@ public:
         _Ty _Sum  = 0;
         for (size_t _Ix = 0; _Ix < _Nx; ++_Ix, _Idx0 += _Kx) { // pack _Kx words
             this->_Ax[_Ix] = _Arr[_Idx0];
-            for (int _Jx = 0; ++_Jx < _Kx;) {
+            for (int _Jx = 1; _Jx < _Kx; ++_Jx) {
                 this->_Ax[_Ix] |= static_cast<_Ty>(_Arr[_Idx0 + _Jx]) << (32 * _Jx);
             }
 

stl/inc/valarray

@@ -320,7 +320,7 @@ public:
 
     _NODISCARD _Ty sum() const {
         _Ty _Sum = _Myptr[0];
-        for (size_t _Idx = 0; ++_Idx < size();) {
+        for (size_t _Idx = 1; _Idx < size(); ++_Idx) {
             _Sum += _Myptr[_Idx];
         }
 
@@ -329,7 +329,7 @@ public:
 
     _NODISCARD _Ty(min)() const {
         _Ty _Min = _Myptr[0];
-        for (size_t _Idx = 0; ++_Idx < size();) {
+        for (size_t _Idx = 1; _Idx < size(); ++_Idx) {
             if (_Myptr[_Idx] < _Min) {
                 _Min = _Myptr[_Idx];
             }
@@ -340,7 +340,7 @@ public:
 
     _NODISCARD _Ty(max)() const {
         _Ty _Max = _Myptr[0];
-        for (size_t _Idx = 0; ++_Idx < size();) {
+        for (size_t _Idx = 1; _Idx < size(); ++_Idx) {
             if (_Max < _Myptr[_Idx]) {
                 _Max = _Myptr[_Idx];
             }
@@ -999,7 +999,7 @@ public:
         }
 
         size_t _Count = _Len[0];
-        for (size_t _Idx = 0; ++_Idx < _Len.size();) {
+        for (size_t _Idx = 1; _Idx < _Len.size(); ++_Idx) {
             _Count *= _Len[_Idx];
         }
 

stl/inc/yvals_core.h

@@ -411,13 +411,14 @@
 // warning C5026: move constructor was implicitly defined as deleted (/Wall)
 // warning C5027: move assignment operator was implicitly defined as deleted (/Wall)
 // warning C5045: Compiler will insert Spectre mitigation for memory load if /Qspectre switch specified (/Wall)
+// warning C6294: Ill-defined for-loop: initial condition does not satisfy test. Loop body not executed
 
 #ifndef _STL_DISABLED_WARNINGS
 // clang-format off
 #define _STL_DISABLED_WARNINGS                        \
     4180 4412 4455 4472 4494 4514 4571 4574 4582 4583 \
     4587 4588 4619 4623 4625 4626 4643 4648 4702 4793 \
-    4820 4988 5026 5027 5045                          \
+    4820 4988 5026 5027 5045 6294                     \
     _STL_DISABLED_WARNING_C4577                       \
     _STL_DISABLED_WARNING_C4984                       \
     _STL_DISABLED_WARNING_C5053                       \

stl/src/ios.cpp

@@ -74,7 +74,7 @@ void __CLRCALL_PURE_OR_CDECL ios_base::_Ios_base_dtor(ios_base* _This) { // dest
 
 void __CLRCALL_PURE_OR_CDECL ios_base::_Addstd(ios_base* _This) { // add standard stream to destructor list
     _BEGIN_LOCK(_LOCK_STREAM)
-    for (_This->_Stdstr = 0; ++_This->_Stdstr < _Nstdstr;) {
+    for (_This->_Stdstr = 1; _This->_Stdstr < _Nstdstr; ++_This->_Stdstr) {
         if (stdstr[_This->_Stdstr] == 0 || stdstr[_This->_Stdstr] == _This) {
             break; // found a candidate
         }