Removes the nullable attribute from window.parent (#1089)

* Remvoes the nullable attribute from parent

* Adds a comment about why it's not null

* Expand copy

* Update inputfiles/comments.json

Co-authored-by: Kagami Sascha Rosylight <saschanaz@outlook.com>

* Fix baselines

Co-authored-by: Kagami Sascha Rosylight <saschanaz@outlook.com>
This commit is contained in:
Orta Therox 2021-08-06 15:05:54 +01:00 коммит произвёл GitHub
Родитель cb20745f96
Коммит 76512b377c
Не найден ключ, соответствующий данной подписи
Идентификатор ключа GPG: 4AEE18F83AFDEB23
3 изменённых файлов: 24 добавлений и 2 удалений

14
baselines/dom.generated.d.ts поставляемый
Просмотреть файл

@ -17230,7 +17230,12 @@ interface Window extends EventTarget, AnimationFrameProvider, GlobalEventHandler
readonly pageXOffset: number;
/** @deprecated This is a legacy alias of `scrollY`. */
readonly pageYOffset: number;
readonly parent: WindowProxy | null;
/**
* Refers to either the parent WindowProxy, or itself.
*
* It can rarely be null e.g. for contentWindow of an iframe that is already removed from the parent.
*/
readonly parent: WindowProxy;
/**
* Returns true if the personal bar is visible; otherwise, returns false.
*/
@ -18294,7 +18299,12 @@ declare var outerWidth: number;
declare var pageXOffset: number;
/** @deprecated This is a legacy alias of `scrollY`. */
declare var pageYOffset: number;
declare var parent: WindowProxy | null;
/**
* Refers to either the parent WindowProxy, or itself.
*
* It can rarely be null e.g. for contentWindow of an iframe that is already removed from the parent.
*/
declare var parent: WindowProxy;
/**
* Returns true if the personal bar is visible; otherwise, returns false.
*/

Просмотреть файл

@ -1796,6 +1796,15 @@
}
}
}
},
"Window": {
"properties": {
"property": {
"parent": {
"comment" : "/**\n * Refers to either the parent WindowProxy, or itself.\n *\n * It can rarely be null e.g. for contentWindow of an iframe that is already removed from the parent.\n */"
}
}
}
}
}
}

Просмотреть файл

@ -500,6 +500,9 @@
},
"window": {
"overrideType": "Window & typeof globalThis"
},
"parent": {
"nullable": false
}
}
},