зеркало из https://github.com/microsoft/VFSForGit.git
Delete ProductUpgradeTimer
This timer is responsible for checking if there is a new VFS for Git version on a timer, then launches a notification to GVFS.Service.UI. I was hoping to delete all of GVFS.Service.UI, but we need the toast notifications for when we attempt to auto-mount and have a failure. Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
This commit is contained in:
Derrick Stolee
Родитель
bd54739454
Коммит
704411b3d3
|
|
@ -26,7 +26,6 @@ namespace GVFS.Service
|
|||
private string serviceName;
|
||||
private string serviceDataLocation;
|
||||
private RepoRegistry repoRegistry;
|
||||
private ProductUpgradeTimer productUpgradeTimer;
|
||||
private WindowsRequestHandler requestHandler;
|
||||
private INotificationHandler notificationHandler;
|
||||
|
||||
|
|
@ -36,7 +35,6 @@ namespace GVFS.Service
|
|||
this.serviceName = GVFSConstants.Service.ServiceName;
|
||||
this.CanHandleSessionChangeEvent = true;
|
||||
this.notificationHandler = new NotificationHandler(tracer);
|
||||
this.productUpgradeTimer = new ProductUpgradeTimer(tracer, this.notificationHandler);
|
||||
}
|
||||
|
||||
public void Run()
|
||||
|
|
@ -74,12 +72,6 @@ namespace GVFS.Service
|
|||
EnableAndAttachProjFSHandler.TryEnablePrjFlt(activity, out error);
|
||||
}
|
||||
|
||||
// Start product upgrade timer only after attempting to enable prjflt.
|
||||
// On Windows server (where PrjFlt is not inboxed) this helps avoid
|
||||
// a race between TryEnablePrjFlt() and installer pre-check which is
|
||||
// performed by UpgradeTimer in parallel.
|
||||
this.productUpgradeTimer.Start();
|
||||
|
||||
this.serviceStopped.WaitOne();
|
||||
}
|
||||
}
|
||||
|
|
@ -98,11 +90,6 @@ namespace GVFS.Service
|
|||
|
||||
try
|
||||
{
|
||||
if (this.productUpgradeTimer != null)
|
||||
{
|
||||
this.productUpgradeTimer.Stop();
|
||||
}
|
||||
|
||||
if (this.tracer != null)
|
||||
{
|
||||
this.tracer.RelatedInfo("Stopping");
|
||||
|
|
|
|||
|
|
@ -1,261 +0,0 @@
|
|||
using GVFS.Common;
|
||||
using GVFS.Common.FileSystem;
|
||||
using GVFS.Common.NamedPipes;
|
||||
using GVFS.Common.NuGetUpgrade;
|
||||
using GVFS.Common.Tracing;
|
||||
using GVFS.Service.Handlers;
|
||||
using GVFS.Upgrader;
|
||||
using System;
|
||||
using System.IO;
|
||||
using System.Threading;
|
||||
|
||||
namespace GVFS.Service
|
||||
{
|
||||
public class ProductUpgradeTimer : IDisposable
|
||||
{
|
||||
private static readonly TimeSpan TimeInterval = TimeSpan.FromDays(1);
|
||||
private JsonTracer tracer;
|
||||
private PhysicalFileSystem fileSystem;
|
||||
private Timer timer;
|
||||
private INotificationHandler notificationHandler;
|
||||
|
||||
public ProductUpgradeTimer(JsonTracer tracer, INotificationHandler notificationHandler)
|
||||
{
|
||||
this.tracer = tracer;
|
||||
this.notificationHandler = notificationHandler;
|
||||
this.fileSystem = new PhysicalFileSystem();
|
||||
}
|
||||
|
||||
public void Start()
|
||||
{
|
||||
if (!GVFSEnlistment.IsUnattended(this.tracer))
|
||||
{
|
||||
// Adding 60 seconds wait time here. This gives VFSForGit installer/upgrader
|
||||
// sufficient enough time to launch GVFS.Service.UI that is needed to display
|
||||
// Upgrade available toaster.
|
||||
TimeSpan startTime = TimeSpan.FromSeconds(60);
|
||||
|
||||
this.tracer.RelatedInfo("Starting auto upgrade checks.");
|
||||
this.timer = new Timer(
|
||||
this.TimerCallback,
|
||||
state: null,
|
||||
dueTime: startTime,
|
||||
period: TimeInterval);
|
||||
}
|
||||
else
|
||||
{
|
||||
this.tracer.RelatedInfo("No upgrade checks scheduled, GVFS is running in unattended mode.");
|
||||
}
|
||||
}
|
||||
|
||||
public void Stop()
|
||||
{
|
||||
this.tracer.RelatedInfo("Stopping auto upgrade checks");
|
||||
this.Dispose();
|
||||
}
|
||||
|
||||
public void Dispose()
|
||||
{
|
||||
if (this.timer != null)
|
||||
{
|
||||
this.timer.Dispose();
|
||||
this.timer = null;
|
||||
}
|
||||
}
|
||||
|
||||
private static EventMetadata CreateEventMetadata(Exception e)
|
||||
{
|
||||
EventMetadata metadata = new EventMetadata();
|
||||
if (e != null)
|
||||
{
|
||||
metadata.Add("Exception", e.ToString());
|
||||
}
|
||||
|
||||
return metadata;
|
||||
}
|
||||
|
||||
private void TimerCallback(object unusedState)
|
||||
{
|
||||
string errorMessage = null;
|
||||
|
||||
using (ITracer activity = this.tracer.StartActivity("Checking for product upgrades.", EventLevel.Informational))
|
||||
{
|
||||
try
|
||||
{
|
||||
ProductUpgraderInfo info = new ProductUpgraderInfo(
|
||||
this.tracer,
|
||||
this.fileSystem);
|
||||
|
||||
ProductUpgrader.TryCreateUpgrader(
|
||||
this.tracer,
|
||||
this.fileSystem,
|
||||
new LocalGVFSConfig(),
|
||||
credentialStore: null,
|
||||
dryRun: false,
|
||||
noVerify: false,
|
||||
newUpgrader: out ProductUpgrader productUpgrader,
|
||||
error: out errorMessage);
|
||||
|
||||
if (productUpgrader == null)
|
||||
{
|
||||
string message = string.Format(
|
||||
"{0}.{1}: failed to create upgrader: {2}",
|
||||
nameof(ProductUpgradeTimer),
|
||||
nameof(this.TimerCallback),
|
||||
errorMessage);
|
||||
|
||||
activity.RelatedWarning(
|
||||
metadata: new EventMetadata(),
|
||||
message: message,
|
||||
keywords: Keywords.Telemetry);
|
||||
|
||||
info.RecordHighestAvailableVersion(highestAvailableVersion: null);
|
||||
return;
|
||||
}
|
||||
|
||||
if (!productUpgrader.SupportsAnonymousVersionQuery)
|
||||
{
|
||||
// If this is a NuGetUpgrader that does not support anonymous version query,
|
||||
// fall back to using the GitHubUpgrader, to preserve existing behavior.
|
||||
// Once we have completely transitioned to using the anonymous endpoint,
|
||||
// we can remove this code.
|
||||
if (productUpgrader is NuGetUpgrader)
|
||||
{
|
||||
productUpgrader = GitHubUpgrader.Create(
|
||||
this.tracer,
|
||||
this.fileSystem,
|
||||
new LocalGVFSConfig(),
|
||||
dryRun: false,
|
||||
noVerify: false,
|
||||
error: out errorMessage);
|
||||
|
||||
if (productUpgrader == null)
|
||||
{
|
||||
string gitHubUpgraderFailedMessage = string.Format(
|
||||
"{0}.{1}: GitHubUpgrader.Create failed to create upgrader: {2}",
|
||||
nameof(ProductUpgradeTimer),
|
||||
nameof(this.TimerCallback),
|
||||
errorMessage);
|
||||
|
||||
activity.RelatedWarning(
|
||||
metadata: new EventMetadata(),
|
||||
message: gitHubUpgraderFailedMessage,
|
||||
keywords: Keywords.Telemetry);
|
||||
|
||||
info.RecordHighestAvailableVersion(highestAvailableVersion: null);
|
||||
return;
|
||||
}
|
||||
}
|
||||
else
|
||||
{
|
||||
errorMessage = string.Format(
|
||||
"{0}.{1}: Configured Product Upgrader does not support anonymous version queries.",
|
||||
nameof(ProductUpgradeTimer),
|
||||
nameof(this.TimerCallback),
|
||||
errorMessage);
|
||||
|
||||
activity.RelatedWarning(
|
||||
metadata: new EventMetadata(),
|
||||
message: errorMessage,
|
||||
keywords: Keywords.Telemetry);
|
||||
|
||||
info.RecordHighestAvailableVersion(highestAvailableVersion: null);
|
||||
return;
|
||||
}
|
||||
}
|
||||
|
||||
InstallerPreRunChecker prerunChecker = new InstallerPreRunChecker(this.tracer, string.Empty);
|
||||
if (!prerunChecker.TryRunPreUpgradeChecks(out errorMessage))
|
||||
{
|
||||
string message = string.Format(
|
||||
"{0}.{1}: PreUpgradeChecks failed with: {2}",
|
||||
nameof(ProductUpgradeTimer),
|
||||
nameof(this.TimerCallback),
|
||||
errorMessage);
|
||||
|
||||
activity.RelatedWarning(
|
||||
metadata: new EventMetadata(),
|
||||
message: message,
|
||||
keywords: Keywords.Telemetry);
|
||||
|
||||
info.RecordHighestAvailableVersion(highestAvailableVersion: null);
|
||||
return;
|
||||
}
|
||||
|
||||
if (!productUpgrader.UpgradeAllowed(out errorMessage))
|
||||
{
|
||||
errorMessage = errorMessage ??
|
||||
$"{nameof(ProductUpgradeTimer)}.{nameof(this.TimerCallback)}: Upgrade is not allowed, but no reason provided.";
|
||||
activity.RelatedWarning(
|
||||
metadata: new EventMetadata(),
|
||||
message: errorMessage,
|
||||
keywords: Keywords.Telemetry);
|
||||
|
||||
info.RecordHighestAvailableVersion(highestAvailableVersion: null);
|
||||
return;
|
||||
}
|
||||
|
||||
if (!this.TryQueryForNewerVersion(
|
||||
activity,
|
||||
productUpgrader,
|
||||
out Version newerVersion,
|
||||
out errorMessage))
|
||||
{
|
||||
string message = string.Format(
|
||||
"{0}.{1}: TryQueryForNewerVersion failed with: {2}",
|
||||
nameof(ProductUpgradeTimer),
|
||||
nameof(this.TimerCallback),
|
||||
errorMessage);
|
||||
|
||||
activity.RelatedWarning(
|
||||
metadata: new EventMetadata(),
|
||||
message: message,
|
||||
keywords: Keywords.Telemetry);
|
||||
|
||||
info.RecordHighestAvailableVersion(highestAvailableVersion: null);
|
||||
return;
|
||||
}
|
||||
|
||||
info.RecordHighestAvailableVersion(highestAvailableVersion: newerVersion);
|
||||
|
||||
if (newerVersion != null)
|
||||
{
|
||||
this.DisplayUpgradeAvailableToast(newerVersion.ToString());
|
||||
}
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
this.tracer.RelatedWarning(
|
||||
CreateEventMetadata(ex),
|
||||
"Exception encountered recording highest available version");
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
private bool TryQueryForNewerVersion(ITracer tracer, ProductUpgrader productUpgrader, out Version newVersion, out string errorMessage)
|
||||
{
|
||||
errorMessage = null;
|
||||
tracer.RelatedInfo($"Querying server for latest version...");
|
||||
|
||||
if (!productUpgrader.TryQueryNewestVersion(out newVersion, out string detailedError))
|
||||
{
|
||||
errorMessage = "Could not fetch new version info. " + detailedError;
|
||||
return false;
|
||||
}
|
||||
|
||||
string logMessage = newVersion == null ? "No newer versions available." : $"Newer version available: {newVersion}.";
|
||||
tracer.RelatedInfo(logMessage);
|
||||
|
||||
return true;
|
||||
}
|
||||
|
||||
private void DisplayUpgradeAvailableToast(string version)
|
||||
{
|
||||
NamedPipeMessages.Notification.Request request = new NamedPipeMessages.Notification.Request();
|
||||
request.Id = NamedPipeMessages.Notification.Request.Identifier.UpgradeAvailable;
|
||||
request.NewVersion = version;
|
||||
|
||||
this.notificationHandler.SendNotification(request);
|
||||
}
|
||||
}
|
||||
}
|
||||
Загрузка…
Ссылка в новой задаче