RAS: Add a tracepoint for reporting memory controller events
Add a new tracepoint-based hardware events report method for
reporting Memory Controller events.
Part of the description bellow is shamelessly copied from Tony
Luck's notes about the Hardware Error BoF during LPC 2010 [1].
Tony, thanks for your notes and discussions to generate the
h/w error reporting requirements.
[1] http://lwn.net/Articles/416669/
We have several subsystems & methods for reporting hardware errors:
1) EDAC ("Error Detection and Correction"). In its original form
this consisted of a platform specific driver that read topology
information and error counts from chipset registers and reported
the results via a sysfs interface.
2) mcelog - x86 specific decoding of machine check bank registers
reporting in binary form via /dev/mcelog. Recent additions make use
of the APEI extensions that were documented in version 4.0a of the
ACPI specification to acquire more information about errors without
having to rely reading chipset registers directly. A user level
programs decodes into somewhat human readable format.
3) drivers/edac/mce_amd.c - this driver hooks into the mcelog path and
decodes errors reported via machine check bank registers in AMD
processors to the console log using printk();
Each of these mechanisms has a band of followers ... and none
of them appear to meet all the needs of all users.
As part of a RAS subsystem, let's encapsulate the memory error hardware
events into a trace facility.
The tracepoint printk will be displayed like:
mc_event: [quant] (Corrected|Uncorrected|Fatal) error:[error msg] on [label] ([location] [edac_mc detail] [driver_detail]
Where:
[quant] is the quantity of errors
[error msg] is the driver-specific error message
(e. g. "memory read", "bus error", ...);
[location] is the location in terms of memory controller and
branch/channel/slot, channel/slot or csrow/channel;
[label] is the memory stick label;
[edac_mc detail] describes the address location of the error
and the syndrome;
[driver detail] is driver-specifig error message details,
when needed/provided (e. g. "area:DMA", ...)
For example:
mc_event: 1 Corrected error:memory read on memory stick DIMM_1A (mc:0 location:0:0:0 page:0x586b6e offset:0xa66 grain:32 syndrome:0x0 area:DMA)
Of course, any userspace tools meant to handle errors should not parse
the above data. They should, instead, use the binary fields provided by
the tracepoint, mapping them directly into their Management Information
Base.
NOTE: The original patch was providing an additional mechanism for
MCA-based trace events that also contained MCA error register data.
However, as no agreement was reached so far for the MCA-based trace
events, for now, let's add events only for memory errors.
A latter patch is planned to change the tracepoint, for those types
of event.
Cc: Aristeu Rozanski <arozansk@redhat.com>
Cc: Doug Thompson <norsk5@yahoo.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2012-02-23 15:10:34 +04:00
|
|
|
#undef TRACE_SYSTEM
|
|
|
|
|
#define TRACE_SYSTEM ras
|
|
|
|
|
#define TRACE_INCLUDE_FILE ras_event
|
|
|
|
|
|
|
|
|
|
#if !defined(_TRACE_HW_EVENT_MC_H) || defined(TRACE_HEADER_MULTI_READ)
|
|
|
|
|
#define _TRACE_HW_EVENT_MC_H
|
|
|
|
|
|
|
|
|
|
#include <linux/tracepoint.h>
|
|
|
|
|
#include <linux/edac.h>
|
|
|
|
|
#include <linux/ktime.h>
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* Hardware Events Report
|
|
|
|
|
*
|
|
|
|
|
* Those events are generated when hardware detected a corrected or
|
|
|
|
|
* uncorrected event, and are meant to replace the current API to report
|
|
|
|
|
* errors defined on both EDAC and MCE subsystems.
|
|
|
|
|
*
|
|
|
|
|
* FIXME: Add events for handling memory errors originated from the
|
|
|
|
|
* MCE subsystem.
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* Hardware-independent Memory Controller specific events
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* Default error mechanisms for Memory Controller errors (CE and UE)
|
|
|
|
|
*/
|
|
|
|
|
TRACE_EVENT(mc_event,
|
|
|
|
|
|
|
|
|
|
TP_PROTO(const unsigned int err_type,
|
|
|
|
|
const char *error_msg,
|
|
|
|
|
const char *label,
|
|
|
|
|
const int error_count,
|
|
|
|
|
const u8 mc_index,
|
|
|
|
|
const s8 top_layer,
|
|
|
|
|
const s8 mid_layer,
|
|
|
|
|
const s8 low_layer,
|
|
|
|
|
unsigned long address,
|
|
|
|
|
const u8 grain_bits,
|
|
|
|
|
unsigned long syndrome,
|
|
|
|
|
const char *driver_detail),
|
|
|
|
|
|
|
|
|
|
TP_ARGS(err_type, error_msg, label, error_count, mc_index,
|
|
|
|
|
top_layer, mid_layer, low_layer, address, grain_bits,
|
|
|
|
|
syndrome, driver_detail),
|
|
|
|
|
|
|
|
|
|
TP_STRUCT__entry(
|
|
|
|
|
__field( unsigned int, error_type )
|
|
|
|
|
__string( msg, error_msg )
|
|
|
|
|
__string( label, label )
|
|
|
|
|
__field( u16, error_count )
|
|
|
|
|
__field( u8, mc_index )
|
|
|
|
|
__field( s8, top_layer )
|
|
|
|
|
__field( s8, middle_layer )
|
|
|
|
|
__field( s8, lower_layer )
|
|
|
|
|
__field( long, address )
|
|
|
|
|
__field( u8, grain_bits )
|
|
|
|
|
__field( long, syndrome )
|
|
|
|
|
__string( driver_detail, driver_detail )
|
|
|
|
|
),
|
|
|
|
|
|
|
|
|
|
TP_fast_assign(
|
|
|
|
|
__entry->error_type = err_type;
|
|
|
|
|
__assign_str(msg, error_msg);
|
|
|
|
|
__assign_str(label, label);
|
|
|
|
|
__entry->error_count = error_count;
|
|
|
|
|
__entry->mc_index = mc_index;
|
|
|
|
|
__entry->top_layer = top_layer;
|
|
|
|
|
__entry->middle_layer = mid_layer;
|
|
|
|
|
__entry->lower_layer = low_layer;
|
|
|
|
|
__entry->address = address;
|
|
|
|
|
__entry->grain_bits = grain_bits;
|
|
|
|
|
__entry->syndrome = syndrome;
|
|
|
|
|
__assign_str(driver_detail, driver_detail);
|
|
|
|
|
),
|
|
|
|
|
|
|
|
|
|
TP_printk("%d %s error%s:%s%s on %s (mc:%d location:%d:%d:%d address:0x%08lx grain:%d syndrome:0x%08lx%s%s)",
|
|
|
|
|
__entry->error_count,
|
2013-02-20 04:26:22 +04:00
|
|
|
mc_event_error_type(__entry->error_type),
|
RAS: Add a tracepoint for reporting memory controller events
Add a new tracepoint-based hardware events report method for
reporting Memory Controller events.
Part of the description bellow is shamelessly copied from Tony
Luck's notes about the Hardware Error BoF during LPC 2010 [1].
Tony, thanks for your notes and discussions to generate the
h/w error reporting requirements.
[1] http://lwn.net/Articles/416669/
We have several subsystems & methods for reporting hardware errors:
1) EDAC ("Error Detection and Correction"). In its original form
this consisted of a platform specific driver that read topology
information and error counts from chipset registers and reported
the results via a sysfs interface.
2) mcelog - x86 specific decoding of machine check bank registers
reporting in binary form via /dev/mcelog. Recent additions make use
of the APEI extensions that were documented in version 4.0a of the
ACPI specification to acquire more information about errors without
having to rely reading chipset registers directly. A user level
programs decodes into somewhat human readable format.
3) drivers/edac/mce_amd.c - this driver hooks into the mcelog path and
decodes errors reported via machine check bank registers in AMD
processors to the console log using printk();
Each of these mechanisms has a band of followers ... and none
of them appear to meet all the needs of all users.
As part of a RAS subsystem, let's encapsulate the memory error hardware
events into a trace facility.
The tracepoint printk will be displayed like:
mc_event: [quant] (Corrected|Uncorrected|Fatal) error:[error msg] on [label] ([location] [edac_mc detail] [driver_detail]
Where:
[quant] is the quantity of errors
[error msg] is the driver-specific error message
(e. g. "memory read", "bus error", ...);
[location] is the location in terms of memory controller and
branch/channel/slot, channel/slot or csrow/channel;
[label] is the memory stick label;
[edac_mc detail] describes the address location of the error
and the syndrome;
[driver detail] is driver-specifig error message details,
when needed/provided (e. g. "area:DMA", ...)
For example:
mc_event: 1 Corrected error:memory read on memory stick DIMM_1A (mc:0 location:0:0:0 page:0x586b6e offset:0xa66 grain:32 syndrome:0x0 area:DMA)
Of course, any userspace tools meant to handle errors should not parse
the above data. They should, instead, use the binary fields provided by
the tracepoint, mapping them directly into their Management Information
Base.
NOTE: The original patch was providing an additional mechanism for
MCA-based trace events that also contained MCA error register data.
However, as no agreement was reached so far for the MCA-based trace
events, for now, let's add events only for memory errors.
A latter patch is planned to change the tracepoint, for those types
of event.
Cc: Aristeu Rozanski <arozansk@redhat.com>
Cc: Doug Thompson <norsk5@yahoo.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2012-02-23 15:10:34 +04:00
|
|
|
__entry->error_count > 1 ? "s" : "",
|
|
|
|
|
((char *)__get_str(msg))[0] ? " " : "",
|
|
|
|
|
__get_str(msg),
|
|
|
|
|
__get_str(label),
|
|
|
|
|
__entry->mc_index,
|
|
|
|
|
__entry->top_layer,
|
|
|
|
|
__entry->middle_layer,
|
|
|
|
|
__entry->lower_layer,
|
|
|
|
|
__entry->address,
|
|
|
|
|
1 << __entry->grain_bits,
|
|
|
|
|
__entry->syndrome,
|
|
|
|
|
((char *)__get_str(driver_detail))[0] ? " " : "",
|
|
|
|
|
__get_str(driver_detail))
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
#endif /* _TRACE_HW_EVENT_MC_H */
|
|
|
|
|
|
|
|
|
|
/* This part must be outside protection */
|
|
|
|
|
#include <trace/define_trace.h>
|