2005-04-17 02:20:36 +04:00
|
|
|
/*
|
|
|
|
* Syncookies implementation for the Linux kernel
|
|
|
|
*
|
|
|
|
* Copyright (C) 1997 Andi Kleen
|
2007-02-09 17:24:47 +03:00
|
|
|
* Based on ideas by D.J.Bernstein and Eric Schenk.
|
2005-04-17 02:20:36 +04:00
|
|
|
*
|
|
|
|
* This program is free software; you can redistribute it and/or
|
|
|
|
* modify it under the terms of the GNU General Public License
|
|
|
|
* as published by the Free Software Foundation; either version
|
|
|
|
* 2 of the License, or (at your option) any later version.
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <linux/tcp.h>
|
|
|
|
#include <linux/slab.h>
|
|
|
|
#include <linux/random.h>
|
|
|
|
#include <linux/cryptohash.h>
|
|
|
|
#include <linux/kernel.h>
|
2011-07-15 19:47:34 +04:00
|
|
|
#include <linux/export.h>
|
2005-04-17 02:20:36 +04:00
|
|
|
#include <net/tcp.h>
|
2008-10-01 18:44:42 +04:00
|
|
|
#include <net/route.h>
|
2005-04-17 02:20:36 +04:00
|
|
|
|
2010-06-21 15:48:44 +04:00
|
|
|
/* Timestamps: lowest bits store TCP options */
|
2010-06-21 15:48:45 +04:00
|
|
|
#define TSBITS 6
|
2008-04-10 14:12:40 +04:00
|
|
|
#define TSMASK (((__u32)1 << TSBITS) - 1)
|
|
|
|
|
2005-04-17 02:20:36 +04:00
|
|
|
extern int sysctl_tcp_syncookies;
|
|
|
|
|
2008-03-24 08:21:28 +03:00
|
|
|
__u32 syncookie_secret[2][16-4+SHA_DIGEST_WORDS];
|
2008-02-08 08:49:26 +03:00
|
|
|
EXPORT_SYMBOL(syncookie_secret);
|
2005-04-17 02:20:36 +04:00
|
|
|
|
|
|
|
static __init int init_syncookies(void)
|
|
|
|
{
|
|
|
|
get_random_bytes(syncookie_secret, sizeof(syncookie_secret));
|
|
|
|
return 0;
|
|
|
|
}
|
2008-02-08 08:49:26 +03:00
|
|
|
__initcall(init_syncookies);
|
2005-04-17 02:20:36 +04:00
|
|
|
|
|
|
|
#define COOKIEBITS 24 /* Upper bits store count */
|
|
|
|
#define COOKIEMASK (((__u32)1 << COOKIEBITS) - 1)
|
|
|
|
|
2009-06-24 10:13:48 +04:00
|
|
|
static DEFINE_PER_CPU(__u32 [16 + 5 + SHA_WORKSPACE_WORDS],
|
|
|
|
ipv4_cookie_scratch);
|
2008-02-07 12:40:19 +03:00
|
|
|
|
2006-11-15 07:51:49 +03:00
|
|
|
static u32 cookie_hash(__be32 saddr, __be32 daddr, __be16 sport, __be16 dport,
|
2005-04-17 02:20:36 +04:00
|
|
|
u32 count, int c)
|
|
|
|
{
|
2009-06-24 10:13:48 +04:00
|
|
|
__u32 *tmp = __get_cpu_var(ipv4_cookie_scratch);
|
2005-04-17 02:20:36 +04:00
|
|
|
|
2008-03-24 08:21:28 +03:00
|
|
|
memcpy(tmp + 4, syncookie_secret[c], sizeof(syncookie_secret[c]));
|
2006-11-15 07:51:49 +03:00
|
|
|
tmp[0] = (__force u32)saddr;
|
|
|
|
tmp[1] = (__force u32)daddr;
|
|
|
|
tmp[2] = ((__force u32)sport << 16) + (__force u32)dport;
|
2005-04-17 02:20:36 +04:00
|
|
|
tmp[3] = count;
|
|
|
|
sha_transform(tmp + 16, (__u8 *)tmp, tmp + 16 + 5);
|
|
|
|
|
|
|
|
return tmp[17];
|
|
|
|
}
|
|
|
|
|
2008-04-10 14:12:40 +04:00
|
|
|
|
|
|
|
/*
|
|
|
|
* when syncookies are in effect and tcp timestamps are enabled we encode
|
2010-06-21 15:48:44 +04:00
|
|
|
* tcp options in the lower bits of the timestamp value that will be
|
2008-04-10 14:12:40 +04:00
|
|
|
* sent in the syn-ack.
|
|
|
|
* Since subsequent timestamps use the normal tcp_time_stamp value, we
|
|
|
|
* must make sure that the resulting initial timestamp is <= tcp_time_stamp.
|
|
|
|
*/
|
|
|
|
__u32 cookie_init_timestamp(struct request_sock *req)
|
|
|
|
{
|
|
|
|
struct inet_request_sock *ireq;
|
|
|
|
u32 ts, ts_now = tcp_time_stamp;
|
|
|
|
u32 options = 0;
|
|
|
|
|
|
|
|
ireq = inet_rsk(req);
|
2010-06-21 15:48:44 +04:00
|
|
|
|
|
|
|
options = ireq->wscale_ok ? ireq->snd_wscale : 0xf;
|
|
|
|
options |= ireq->sack_ok << 4;
|
2010-06-21 15:48:45 +04:00
|
|
|
options |= ireq->ecn_ok << 5;
|
2008-04-10 14:12:40 +04:00
|
|
|
|
|
|
|
ts = ts_now & ~TSMASK;
|
|
|
|
ts |= options;
|
|
|
|
if (ts > ts_now) {
|
|
|
|
ts >>= TSBITS;
|
|
|
|
ts--;
|
|
|
|
ts <<= TSBITS;
|
|
|
|
ts |= options;
|
|
|
|
}
|
|
|
|
return ts;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2006-11-15 07:51:49 +03:00
|
|
|
static __u32 secure_tcp_syn_cookie(__be32 saddr, __be32 daddr, __be16 sport,
|
|
|
|
__be16 dport, __u32 sseq, __u32 count,
|
2005-04-17 02:20:36 +04:00
|
|
|
__u32 data)
|
|
|
|
{
|
|
|
|
/*
|
|
|
|
* Compute the secure sequence number.
|
|
|
|
* The output should be:
|
2007-02-09 17:24:47 +03:00
|
|
|
* HASH(sec1,saddr,sport,daddr,dport,sec1) + sseq + (count * 2^24)
|
2005-04-17 02:20:36 +04:00
|
|
|
* + (HASH(sec2,saddr,sport,daddr,dport,count,sec2) % 2^24).
|
|
|
|
* Where sseq is their sequence number and count increases every
|
|
|
|
* minute by 1.
|
|
|
|
* As an extra hack, we add a small "data" value that encodes the
|
|
|
|
* MSS into the second hash value.
|
|
|
|
*/
|
|
|
|
|
|
|
|
return (cookie_hash(saddr, daddr, sport, dport, 0, 0) +
|
|
|
|
sseq + (count << COOKIEBITS) +
|
|
|
|
((cookie_hash(saddr, daddr, sport, dport, count, 1) + data)
|
|
|
|
& COOKIEMASK));
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* This retrieves the small "data" value from the syncookie.
|
|
|
|
* If the syncookie is bad, the data returned will be out of
|
|
|
|
* range. This must be checked by the caller.
|
|
|
|
*
|
|
|
|
* The count value used to generate the cookie must be within
|
|
|
|
* "maxdiff" if the current (passed-in) "count". The return value
|
|
|
|
* is (__u32)-1 if this test fails.
|
|
|
|
*/
|
2006-11-15 07:51:49 +03:00
|
|
|
static __u32 check_tcp_syn_cookie(__u32 cookie, __be32 saddr, __be32 daddr,
|
|
|
|
__be16 sport, __be16 dport, __u32 sseq,
|
2005-04-17 02:20:36 +04:00
|
|
|
__u32 count, __u32 maxdiff)
|
|
|
|
{
|
|
|
|
__u32 diff;
|
|
|
|
|
|
|
|
/* Strip away the layers from the cookie */
|
|
|
|
cookie -= cookie_hash(saddr, daddr, sport, dport, 0, 0) + sseq;
|
|
|
|
|
|
|
|
/* Cookie is now reduced to (count * 2^24) ^ (hash % 2^24) */
|
|
|
|
diff = (count - (cookie >> COOKIEBITS)) & ((__u32) - 1 >> COOKIEBITS);
|
|
|
|
if (diff >= maxdiff)
|
|
|
|
return (__u32)-1;
|
|
|
|
|
|
|
|
return (cookie -
|
|
|
|
cookie_hash(saddr, daddr, sport, dport, count - diff, 1))
|
|
|
|
& COOKIEMASK; /* Leaving the data behind */
|
|
|
|
}
|
|
|
|
|
2007-02-09 17:24:47 +03:00
|
|
|
/*
|
2010-06-03 04:43:57 +04:00
|
|
|
* MSS Values are taken from the 2009 paper
|
|
|
|
* 'Measuring TCP Maximum Segment Size' by S. Alcock and R. Nelson:
|
|
|
|
* - values 1440 to 1460 accounted for 80% of observed mss values
|
|
|
|
* - values outside the 536-1460 range are rare (<0.2%).
|
|
|
|
*
|
|
|
|
* Table must be sorted.
|
2005-04-17 02:20:36 +04:00
|
|
|
*/
|
|
|
|
static __u16 const msstab[] = {
|
2010-06-03 04:43:57 +04:00
|
|
|
64,
|
|
|
|
512,
|
|
|
|
536,
|
|
|
|
1024,
|
|
|
|
1440,
|
|
|
|
1460,
|
|
|
|
4312,
|
|
|
|
8960,
|
2005-04-17 02:20:36 +04:00
|
|
|
};
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Generate a syncookie. mssp points to the mss, which is returned
|
|
|
|
* rounded down to the value encoded in the cookie.
|
|
|
|
*/
|
2013-08-27 10:50:13 +04:00
|
|
|
u32 __cookie_v4_init_sequence(const struct iphdr *iph, const struct tcphdr *th,
|
|
|
|
u16 *mssp)
|
2005-04-17 02:20:36 +04:00
|
|
|
{
|
|
|
|
int mssind;
|
|
|
|
const __u16 mss = *mssp;
|
|
|
|
|
2010-06-03 04:43:57 +04:00
|
|
|
for (mssind = ARRAY_SIZE(msstab) - 1; mssind ; mssind--)
|
|
|
|
if (mss >= msstab[mssind])
|
|
|
|
break;
|
|
|
|
*mssp = msstab[mssind];
|
2005-04-17 02:20:36 +04:00
|
|
|
|
2007-04-11 08:04:22 +04:00
|
|
|
return secure_tcp_syn_cookie(iph->saddr, iph->daddr,
|
|
|
|
th->source, th->dest, ntohl(th->seq),
|
2005-04-17 02:20:36 +04:00
|
|
|
jiffies / (HZ * 60), mssind);
|
|
|
|
}
|
2013-08-27 10:50:13 +04:00
|
|
|
EXPORT_SYMBOL_GPL(__cookie_v4_init_sequence);
|
|
|
|
|
|
|
|
__u32 cookie_v4_init_sequence(struct sock *sk, struct sk_buff *skb, __u16 *mssp)
|
|
|
|
{
|
|
|
|
const struct iphdr *iph = ip_hdr(skb);
|
|
|
|
const struct tcphdr *th = tcp_hdr(skb);
|
|
|
|
|
|
|
|
tcp_synq_overflow(sk);
|
|
|
|
NET_INC_STATS_BH(sock_net(sk), LINUX_MIB_SYNCOOKIESSENT);
|
|
|
|
|
|
|
|
return __cookie_v4_init_sequence(iph, th, mssp);
|
|
|
|
}
|
2005-04-17 02:20:36 +04:00
|
|
|
|
2007-02-09 17:24:47 +03:00
|
|
|
/*
|
2005-04-17 02:20:36 +04:00
|
|
|
* This (misnamed) value is the age of syncookie which is permitted.
|
|
|
|
* Its ideal value should be dependent on TCP_TIMEOUT_INIT and
|
|
|
|
* sysctl_tcp_retries1. It's a rather complicated formula (exponential
|
|
|
|
* backoff) to compute at runtime so it's currently hardcoded here.
|
|
|
|
*/
|
|
|
|
#define COUNTER_TRIES 4
|
2007-02-09 17:24:47 +03:00
|
|
|
/*
|
|
|
|
* Check if a ack sequence number is a valid syncookie.
|
2005-04-17 02:20:36 +04:00
|
|
|
* Return the decoded mss if it is, or 0 if not.
|
|
|
|
*/
|
2013-08-27 10:50:13 +04:00
|
|
|
int __cookie_v4_check(const struct iphdr *iph, const struct tcphdr *th,
|
|
|
|
u32 cookie)
|
2005-04-17 02:20:36 +04:00
|
|
|
{
|
2007-04-11 08:04:22 +04:00
|
|
|
__u32 seq = ntohl(th->seq) - 1;
|
|
|
|
__u32 mssind = check_tcp_syn_cookie(cookie, iph->saddr, iph->daddr,
|
|
|
|
th->source, th->dest, seq,
|
|
|
|
jiffies / (HZ * 60),
|
|
|
|
COUNTER_TRIES);
|
2005-04-17 02:20:36 +04:00
|
|
|
|
2010-06-03 04:43:57 +04:00
|
|
|
return mssind < ARRAY_SIZE(msstab) ? msstab[mssind] : 0;
|
2005-04-17 02:20:36 +04:00
|
|
|
}
|
2013-08-27 10:50:13 +04:00
|
|
|
EXPORT_SYMBOL_GPL(__cookie_v4_check);
|
2005-04-17 02:20:36 +04:00
|
|
|
|
|
|
|
static inline struct sock *get_cookie_sock(struct sock *sk, struct sk_buff *skb,
|
2005-06-19 09:47:21 +04:00
|
|
|
struct request_sock *req,
|
2005-04-17 02:20:36 +04:00
|
|
|
struct dst_entry *dst)
|
|
|
|
{
|
2005-12-14 10:15:52 +03:00
|
|
|
struct inet_connection_sock *icsk = inet_csk(sk);
|
2005-04-17 02:20:36 +04:00
|
|
|
struct sock *child;
|
|
|
|
|
2005-12-14 10:15:52 +03:00
|
|
|
child = icsk->icsk_af_ops->syn_recv_sock(sk, skb, req, dst);
|
2005-04-17 02:20:36 +04:00
|
|
|
if (child)
|
2005-08-10 07:10:42 +04:00
|
|
|
inet_csk_reqsk_queue_add(sk, req, child);
|
2005-04-17 02:20:36 +04:00
|
|
|
else
|
2005-06-19 09:47:21 +04:00
|
|
|
reqsk_free(req);
|
2005-04-17 02:20:36 +04:00
|
|
|
|
|
|
|
return child;
|
|
|
|
}
|
|
|
|
|
2008-04-10 14:12:40 +04:00
|
|
|
|
|
|
|
/*
|
|
|
|
* when syncookies are in effect and tcp timestamps are enabled we stored
|
|
|
|
* additional tcp options in the timestamp.
|
|
|
|
* This extracts these options from the timestamp echo.
|
|
|
|
*
|
2010-06-21 15:48:44 +04:00
|
|
|
* The lowest 4 bits store snd_wscale.
|
2010-06-21 15:48:45 +04:00
|
|
|
* next 2 bits indicate SACK and ECN support.
|
2010-06-17 01:42:15 +04:00
|
|
|
*
|
|
|
|
* return false if we decode an option that should not be.
|
2008-04-10 14:12:40 +04:00
|
|
|
*/
|
2013-01-05 20:10:48 +04:00
|
|
|
bool cookie_check_timestamp(struct tcp_options_received *tcp_opt,
|
|
|
|
struct net *net, bool *ecn_ok)
|
2008-04-10 14:12:40 +04:00
|
|
|
{
|
2010-06-21 15:48:44 +04:00
|
|
|
/* echoed timestamp, lowest bits contain options */
|
2008-04-10 14:12:40 +04:00
|
|
|
u32 options = tcp_opt->rcv_tsecr & TSMASK;
|
|
|
|
|
2010-06-17 01:42:15 +04:00
|
|
|
if (!tcp_opt->saw_tstamp) {
|
|
|
|
tcp_clear_options(tcp_opt);
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!sysctl_tcp_timestamps)
|
|
|
|
return false;
|
|
|
|
|
2011-12-20 17:23:24 +04:00
|
|
|
tcp_opt->sack_ok = (options & (1 << 4)) ? TCP_SACK_SEEN : 0;
|
2010-06-21 15:48:45 +04:00
|
|
|
*ecn_ok = (options >> 5) & 1;
|
2013-01-05 20:10:48 +04:00
|
|
|
if (*ecn_ok && !net->ipv4.sysctl_tcp_ecn)
|
2010-06-21 15:48:45 +04:00
|
|
|
return false;
|
2008-04-10 14:12:40 +04:00
|
|
|
|
2010-06-17 01:42:15 +04:00
|
|
|
if (tcp_opt->sack_ok && !sysctl_tcp_sack)
|
|
|
|
return false;
|
2008-04-10 14:12:40 +04:00
|
|
|
|
2010-06-21 15:48:44 +04:00
|
|
|
if ((options & 0xf) == 0xf)
|
|
|
|
return true; /* no window scaling */
|
|
|
|
|
|
|
|
tcp_opt->wscale_ok = 1;
|
|
|
|
tcp_opt->snd_wscale = options & 0xf;
|
|
|
|
return sysctl_tcp_window_scaling != 0;
|
2008-04-10 14:12:40 +04:00
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(cookie_check_timestamp);
|
|
|
|
|
2005-04-17 02:20:36 +04:00
|
|
|
struct sock *cookie_v4_check(struct sock *sk, struct sk_buff *skb,
|
|
|
|
struct ip_options *opt)
|
|
|
|
{
|
2009-12-02 21:25:27 +03:00
|
|
|
struct tcp_options_received tcp_opt;
|
[NET] Generalise TCP's struct open_request minisock infrastructure
Kept this first changeset minimal, without changing existing names to
ease peer review.
Basicaly tcp_openreq_alloc now receives the or_calltable, that in turn
has two new members:
->slab, that replaces tcp_openreq_cachep
->obj_size, to inform the size of the openreq descendant for
a specific protocol
The protocol specific fields in struct open_request were moved to a
class hierarchy, with the things that are common to all connection
oriented PF_INET protocols in struct inet_request_sock, the TCP ones
in tcp_request_sock, that is an inet_request_sock, that is an
open_request.
I.e. this uses the same approach used for the struct sock class
hierarchy, with sk_prot indicating if the protocol wants to use the
open_request infrastructure by filling in sk_prot->rsk_prot with an
or_calltable.
Results? Performance is improved and TCP v4 now uses only 64 bytes per
open request minisock, down from 96 without this patch :-)
Next changeset will rename some of the structs, fields and functions
mentioned above, struct or_calltable is way unclear, better name it
struct request_sock_ops, s/struct open_request/struct request_sock/g,
etc.
Signed-off-by: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
2005-06-19 09:46:52 +04:00
|
|
|
struct inet_request_sock *ireq;
|
|
|
|
struct tcp_request_sock *treq;
|
2005-04-17 02:20:36 +04:00
|
|
|
struct tcp_sock *tp = tcp_sk(sk);
|
2007-04-11 08:04:22 +04:00
|
|
|
const struct tcphdr *th = tcp_hdr(skb);
|
|
|
|
__u32 cookie = ntohl(th->ack_seq) - 1;
|
2005-04-17 02:20:36 +04:00
|
|
|
struct sock *ret = sk;
|
2007-02-09 17:24:47 +03:00
|
|
|
struct request_sock *req;
|
|
|
|
int mss;
|
|
|
|
struct rtable *rt;
|
2005-04-17 02:20:36 +04:00
|
|
|
__u8 rcv_wscale;
|
2011-08-11 08:59:57 +04:00
|
|
|
bool ecn_ok = false;
|
2012-03-10 13:20:21 +04:00
|
|
|
struct flowi4 fl4;
|
2005-04-17 02:20:36 +04:00
|
|
|
|
2010-06-03 04:43:44 +04:00
|
|
|
if (!sysctl_tcp_syncookies || !th->ack || th->rst)
|
2005-04-17 02:20:36 +04:00
|
|
|
goto out;
|
|
|
|
|
2009-04-19 13:43:48 +04:00
|
|
|
if (tcp_synq_no_recent_overflow(sk) ||
|
2013-08-27 10:50:13 +04:00
|
|
|
(mss = __cookie_v4_check(ip_hdr(skb), th, cookie)) == 0) {
|
2008-07-17 07:31:16 +04:00
|
|
|
NET_INC_STATS_BH(sock_net(sk), LINUX_MIB_SYNCOOKIESFAILED);
|
2005-04-17 02:20:36 +04:00
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
2008-07-17 07:31:16 +04:00
|
|
|
NET_INC_STATS_BH(sock_net(sk), LINUX_MIB_SYNCOOKIESRECV);
|
2005-04-17 02:20:36 +04:00
|
|
|
|
tcp: Revert per-route SACK/DSACK/TIMESTAMP changes.
It creates a regression, triggering badness for SYN_RECV
sockets, for example:
[19148.022102] Badness at net/ipv4/inet_connection_sock.c:293
[19148.022570] NIP: c02a0914 LR: c02a0904 CTR: 00000000
[19148.023035] REGS: eeecbd30 TRAP: 0700 Not tainted (2.6.32)
[19148.023496] MSR: 00029032 <EE,ME,CE,IR,DR> CR: 24002442 XER: 00000000
[19148.024012] TASK = eee9a820[1756] 'privoxy' THREAD: eeeca000
This is likely caused by the change in the 'estab' parameter
passed to tcp_parse_options() when invoked by the functions
in net/ipv4/tcp_minisocks.c
But even if that is fixed, the ->conn_request() changes made in
this patch series is fundamentally wrong. They try to use the
listening socket's 'dst' to probe the route settings. The
listening socket doesn't even have a route, and you can't
get the right route (the child request one) until much later
after we setup all of the state, and it must be done by hand.
This stuff really isn't ready, so the best thing to do is a
full revert. This reverts the following commits:
f55017a93f1a74d50244b1254b9a2bd7ac9bbf7d
022c3f7d82f0f1c68018696f2f027b87b9bb45c2
1aba721eba1d84a2defce45b950272cee1e6c72a
cda42ebd67ee5fdf09d7057b5a4584d36fe8a335
345cda2fd695534be5a4494f1b59da9daed33663
dc343475ed062e13fc260acccaab91d7d80fd5b2
05eaade2782fb0c90d3034fd7a7d5a16266182bb
6a2a2d6bf8581216e08be15fcb563cfd6c430e1e
Signed-off-by: David S. Miller <davem@davemloft.net>
2009-12-16 07:56:42 +03:00
|
|
|
/* check for timestamp cookie support */
|
|
|
|
memset(&tcp_opt, 0, sizeof(tcp_opt));
|
2013-03-17 12:23:34 +04:00
|
|
|
tcp_parse_options(skb, &tcp_opt, 0, NULL);
|
tcp: Revert per-route SACK/DSACK/TIMESTAMP changes.
It creates a regression, triggering badness for SYN_RECV
sockets, for example:
[19148.022102] Badness at net/ipv4/inet_connection_sock.c:293
[19148.022570] NIP: c02a0914 LR: c02a0904 CTR: 00000000
[19148.023035] REGS: eeecbd30 TRAP: 0700 Not tainted (2.6.32)
[19148.023496] MSR: 00029032 <EE,ME,CE,IR,DR> CR: 24002442 XER: 00000000
[19148.024012] TASK = eee9a820[1756] 'privoxy' THREAD: eeeca000
This is likely caused by the change in the 'estab' parameter
passed to tcp_parse_options() when invoked by the functions
in net/ipv4/tcp_minisocks.c
But even if that is fixed, the ->conn_request() changes made in
this patch series is fundamentally wrong. They try to use the
listening socket's 'dst' to probe the route settings. The
listening socket doesn't even have a route, and you can't
get the right route (the child request one) until much later
after we setup all of the state, and it must be done by hand.
This stuff really isn't ready, so the best thing to do is a
full revert. This reverts the following commits:
f55017a93f1a74d50244b1254b9a2bd7ac9bbf7d
022c3f7d82f0f1c68018696f2f027b87b9bb45c2
1aba721eba1d84a2defce45b950272cee1e6c72a
cda42ebd67ee5fdf09d7057b5a4584d36fe8a335
345cda2fd695534be5a4494f1b59da9daed33663
dc343475ed062e13fc260acccaab91d7d80fd5b2
05eaade2782fb0c90d3034fd7a7d5a16266182bb
6a2a2d6bf8581216e08be15fcb563cfd6c430e1e
Signed-off-by: David S. Miller <davem@davemloft.net>
2009-12-16 07:56:42 +03:00
|
|
|
|
2013-01-05 20:10:48 +04:00
|
|
|
if (!cookie_check_timestamp(&tcp_opt, sock_net(sk), &ecn_ok))
|
2010-06-17 01:42:15 +04:00
|
|
|
goto out;
|
tcp: Revert per-route SACK/DSACK/TIMESTAMP changes.
It creates a regression, triggering badness for SYN_RECV
sockets, for example:
[19148.022102] Badness at net/ipv4/inet_connection_sock.c:293
[19148.022570] NIP: c02a0914 LR: c02a0904 CTR: 00000000
[19148.023035] REGS: eeecbd30 TRAP: 0700 Not tainted (2.6.32)
[19148.023496] MSR: 00029032 <EE,ME,CE,IR,DR> CR: 24002442 XER: 00000000
[19148.024012] TASK = eee9a820[1756] 'privoxy' THREAD: eeeca000
This is likely caused by the change in the 'estab' parameter
passed to tcp_parse_options() when invoked by the functions
in net/ipv4/tcp_minisocks.c
But even if that is fixed, the ->conn_request() changes made in
this patch series is fundamentally wrong. They try to use the
listening socket's 'dst' to probe the route settings. The
listening socket doesn't even have a route, and you can't
get the right route (the child request one) until much later
after we setup all of the state, and it must be done by hand.
This stuff really isn't ready, so the best thing to do is a
full revert. This reverts the following commits:
f55017a93f1a74d50244b1254b9a2bd7ac9bbf7d
022c3f7d82f0f1c68018696f2f027b87b9bb45c2
1aba721eba1d84a2defce45b950272cee1e6c72a
cda42ebd67ee5fdf09d7057b5a4584d36fe8a335
345cda2fd695534be5a4494f1b59da9daed33663
dc343475ed062e13fc260acccaab91d7d80fd5b2
05eaade2782fb0c90d3034fd7a7d5a16266182bb
6a2a2d6bf8581216e08be15fcb563cfd6c430e1e
Signed-off-by: David S. Miller <davem@davemloft.net>
2009-12-16 07:56:42 +03:00
|
|
|
|
2005-04-17 02:20:36 +04:00
|
|
|
ret = NULL;
|
2008-06-10 23:39:35 +04:00
|
|
|
req = inet_reqsk_alloc(&tcp_request_sock_ops); /* for safety */
|
2005-04-17 02:20:36 +04:00
|
|
|
if (!req)
|
|
|
|
goto out;
|
|
|
|
|
[NET] Generalise TCP's struct open_request minisock infrastructure
Kept this first changeset minimal, without changing existing names to
ease peer review.
Basicaly tcp_openreq_alloc now receives the or_calltable, that in turn
has two new members:
->slab, that replaces tcp_openreq_cachep
->obj_size, to inform the size of the openreq descendant for
a specific protocol
The protocol specific fields in struct open_request were moved to a
class hierarchy, with the things that are common to all connection
oriented PF_INET protocols in struct inet_request_sock, the TCP ones
in tcp_request_sock, that is an inet_request_sock, that is an
open_request.
I.e. this uses the same approach used for the struct sock class
hierarchy, with sk_prot indicating if the protocol wants to use the
open_request infrastructure by filling in sk_prot->rsk_prot with an
or_calltable.
Results? Performance is improved and TCP v4 now uses only 64 bytes per
open request minisock, down from 96 without this patch :-)
Next changeset will rename some of the structs, fields and functions
mentioned above, struct or_calltable is way unclear, better name it
struct request_sock_ops, s/struct open_request/struct request_sock/g,
etc.
Signed-off-by: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
2005-06-19 09:46:52 +04:00
|
|
|
ireq = inet_rsk(req);
|
|
|
|
treq = tcp_rsk(req);
|
2007-04-11 08:04:22 +04:00
|
|
|
treq->rcv_isn = ntohl(th->seq) - 1;
|
2007-02-09 17:24:47 +03:00
|
|
|
treq->snt_isn = cookie;
|
2005-04-17 02:20:36 +04:00
|
|
|
req->mss = mss;
|
2008-10-01 18:46:49 +04:00
|
|
|
ireq->loc_port = th->dest;
|
2007-04-11 08:04:22 +04:00
|
|
|
ireq->rmt_port = th->source;
|
2007-04-21 09:47:35 +04:00
|
|
|
ireq->loc_addr = ip_hdr(skb)->daddr;
|
|
|
|
ireq->rmt_addr = ip_hdr(skb)->saddr;
|
2010-06-21 15:48:45 +04:00
|
|
|
ireq->ecn_ok = ecn_ok;
|
tcp: Revert per-route SACK/DSACK/TIMESTAMP changes.
It creates a regression, triggering badness for SYN_RECV
sockets, for example:
[19148.022102] Badness at net/ipv4/inet_connection_sock.c:293
[19148.022570] NIP: c02a0914 LR: c02a0904 CTR: 00000000
[19148.023035] REGS: eeecbd30 TRAP: 0700 Not tainted (2.6.32)
[19148.023496] MSR: 00029032 <EE,ME,CE,IR,DR> CR: 24002442 XER: 00000000
[19148.024012] TASK = eee9a820[1756] 'privoxy' THREAD: eeeca000
This is likely caused by the change in the 'estab' parameter
passed to tcp_parse_options() when invoked by the functions
in net/ipv4/tcp_minisocks.c
But even if that is fixed, the ->conn_request() changes made in
this patch series is fundamentally wrong. They try to use the
listening socket's 'dst' to probe the route settings. The
listening socket doesn't even have a route, and you can't
get the right route (the child request one) until much later
after we setup all of the state, and it must be done by hand.
This stuff really isn't ready, so the best thing to do is a
full revert. This reverts the following commits:
f55017a93f1a74d50244b1254b9a2bd7ac9bbf7d
022c3f7d82f0f1c68018696f2f027b87b9bb45c2
1aba721eba1d84a2defce45b950272cee1e6c72a
cda42ebd67ee5fdf09d7057b5a4584d36fe8a335
345cda2fd695534be5a4494f1b59da9daed33663
dc343475ed062e13fc260acccaab91d7d80fd5b2
05eaade2782fb0c90d3034fd7a7d5a16266182bb
6a2a2d6bf8581216e08be15fcb563cfd6c430e1e
Signed-off-by: David S. Miller <davem@davemloft.net>
2009-12-16 07:56:42 +03:00
|
|
|
ireq->snd_wscale = tcp_opt.snd_wscale;
|
|
|
|
ireq->sack_ok = tcp_opt.sack_ok;
|
|
|
|
ireq->wscale_ok = tcp_opt.wscale_ok;
|
|
|
|
ireq->tstamp_ok = tcp_opt.saw_tstamp;
|
|
|
|
req->ts_recent = tcp_opt.saw_tstamp ? tcp_opt.rcv_tsval : 0;
|
2011-06-08 15:08:38 +04:00
|
|
|
treq->snt_synack = tcp_opt.saw_tstamp ? tcp_opt.rcv_tsecr : 0;
|
2012-08-31 16:29:12 +04:00
|
|
|
treq->listener = NULL;
|
2005-04-17 02:20:36 +04:00
|
|
|
|
|
|
|
/* We throwed the options of the initial SYN away, so we hope
|
|
|
|
* the ACK carries the same options again (see RFC1122 4.2.3.8)
|
|
|
|
*/
|
|
|
|
if (opt && opt->optlen) {
|
2011-04-21 13:45:37 +04:00
|
|
|
int opt_size = sizeof(struct ip_options_rcu) + opt->optlen;
|
2005-04-17 02:20:36 +04:00
|
|
|
|
[NET] Generalise TCP's struct open_request minisock infrastructure
Kept this first changeset minimal, without changing existing names to
ease peer review.
Basicaly tcp_openreq_alloc now receives the or_calltable, that in turn
has two new members:
->slab, that replaces tcp_openreq_cachep
->obj_size, to inform the size of the openreq descendant for
a specific protocol
The protocol specific fields in struct open_request were moved to a
class hierarchy, with the things that are common to all connection
oriented PF_INET protocols in struct inet_request_sock, the TCP ones
in tcp_request_sock, that is an inet_request_sock, that is an
open_request.
I.e. this uses the same approach used for the struct sock class
hierarchy, with sk_prot indicating if the protocol wants to use the
open_request infrastructure by filling in sk_prot->rsk_prot with an
or_calltable.
Results? Performance is improved and TCP v4 now uses only 64 bytes per
open request minisock, down from 96 without this patch :-)
Next changeset will rename some of the structs, fields and functions
mentioned above, struct or_calltable is way unclear, better name it
struct request_sock_ops, s/struct open_request/struct request_sock/g,
etc.
Signed-off-by: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
2005-06-19 09:46:52 +04:00
|
|
|
ireq->opt = kmalloc(opt_size, GFP_ATOMIC);
|
2011-04-21 13:45:37 +04:00
|
|
|
if (ireq->opt != NULL && ip_options_echo(&ireq->opt->opt, skb)) {
|
[NET] Generalise TCP's struct open_request minisock infrastructure
Kept this first changeset minimal, without changing existing names to
ease peer review.
Basicaly tcp_openreq_alloc now receives the or_calltable, that in turn
has two new members:
->slab, that replaces tcp_openreq_cachep
->obj_size, to inform the size of the openreq descendant for
a specific protocol
The protocol specific fields in struct open_request were moved to a
class hierarchy, with the things that are common to all connection
oriented PF_INET protocols in struct inet_request_sock, the TCP ones
in tcp_request_sock, that is an inet_request_sock, that is an
open_request.
I.e. this uses the same approach used for the struct sock class
hierarchy, with sk_prot indicating if the protocol wants to use the
open_request infrastructure by filling in sk_prot->rsk_prot with an
or_calltable.
Results? Performance is improved and TCP v4 now uses only 64 bytes per
open request minisock, down from 96 without this patch :-)
Next changeset will rename some of the structs, fields and functions
mentioned above, struct or_calltable is way unclear, better name it
struct request_sock_ops, s/struct open_request/struct request_sock/g,
etc.
Signed-off-by: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
2005-06-19 09:46:52 +04:00
|
|
|
kfree(ireq->opt);
|
|
|
|
ireq->opt = NULL;
|
2005-04-17 02:20:36 +04:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2009-03-28 00:10:28 +03:00
|
|
|
if (security_inet_conn_request(sk, skb, req)) {
|
|
|
|
reqsk_free(req);
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
2007-02-09 17:24:47 +03:00
|
|
|
req->expires = 0UL;
|
2012-10-28 03:16:46 +04:00
|
|
|
req->num_retrans = 0;
|
2007-02-09 17:24:47 +03:00
|
|
|
|
2005-04-17 02:20:36 +04:00
|
|
|
/*
|
|
|
|
* We need to lookup the route here to get at the correct
|
|
|
|
* window size. We should better make sure that the window size
|
|
|
|
* hasn't changed since we received the original syn, but I see
|
2007-02-09 17:24:47 +03:00
|
|
|
* no easy way to do this.
|
2005-04-17 02:20:36 +04:00
|
|
|
*/
|
tcp: incoming connections might use wrong route under synflood
There is a bug in cookie_v4_check (net/ipv4/syncookies.c):
flowi4_init_output(&fl4, 0, sk->sk_mark, RT_CONN_FLAGS(sk),
RT_SCOPE_UNIVERSE, IPPROTO_TCP,
inet_sk_flowi_flags(sk),
(opt && opt->srr) ? opt->faddr : ireq->rmt_addr,
ireq->loc_addr, th->source, th->dest);
Here we do not respect sk->sk_bound_dev_if, therefore wrong dst_entry may be
taken. This dst_entry is used by new socket (get_cookie_sock ->
tcp_v4_syn_recv_sock), so its packets may take the wrong path.
Signed-off-by: Dmitry Popov <dp@highloadlab.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2013-04-11 12:55:07 +04:00
|
|
|
flowi4_init_output(&fl4, sk->sk_bound_dev_if, sk->sk_mark,
|
|
|
|
RT_CONN_FLAGS(sk), RT_SCOPE_UNIVERSE, IPPROTO_TCP,
|
2012-03-10 13:20:21 +04:00
|
|
|
inet_sk_flowi_flags(sk),
|
|
|
|
(opt && opt->srr) ? opt->faddr : ireq->rmt_addr,
|
|
|
|
ireq->loc_addr, th->source, th->dest);
|
|
|
|
security_req_classify_flow(req, flowi4_to_flowi(&fl4));
|
|
|
|
rt = ip_route_output_key(sock_net(sk), &fl4);
|
|
|
|
if (IS_ERR(rt)) {
|
|
|
|
reqsk_free(req);
|
|
|
|
goto out;
|
2005-04-17 02:20:36 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
/* Try to redo what tcp_v4_send_synack did. */
|
2010-06-11 10:31:35 +04:00
|
|
|
req->window_clamp = tp->window_clamp ? :dst_metric(&rt->dst, RTAX_WINDOW);
|
2008-04-10 14:12:40 +04:00
|
|
|
|
2005-04-17 02:20:36 +04:00
|
|
|
tcp_select_initial_window(tcp_full_space(sk), req->mss,
|
2007-02-09 17:24:47 +03:00
|
|
|
&req->rcv_wnd, &req->window_clamp,
|
2009-12-15 14:15:28 +03:00
|
|
|
ireq->wscale_ok, &rcv_wscale,
|
2010-06-11 10:31:35 +04:00
|
|
|
dst_metric(&rt->dst, RTAX_INITRWND));
|
2008-04-10 14:12:40 +04:00
|
|
|
|
2007-02-09 17:24:47 +03:00
|
|
|
ireq->rcv_wscale = rcv_wscale;
|
2005-04-17 02:20:36 +04:00
|
|
|
|
2010-06-11 10:31:35 +04:00
|
|
|
ret = get_cookie_sock(sk, skb, req, &rt->dst);
|
2012-03-10 13:20:21 +04:00
|
|
|
/* ip_queue_xmit() depends on our flow being setup
|
|
|
|
* Normal sockets get it right from inet_csk_route_child_sock()
|
|
|
|
*/
|
|
|
|
if (ret)
|
|
|
|
inet_sk(ret)->cork.fl.u.ip4 = fl4;
|
2005-04-17 02:20:36 +04:00
|
|
|
out: return ret;
|
|
|
|
}
|