2022-10-31 16:28:35 +03:00
|
|
|
// SPDX-License-Identifier: GPL-2.0
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Copyright 2022 HabanaLabs, Ltd.
|
|
|
|
* All Rights Reserved.
|
|
|
|
*
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <linux/debugfs.h>
|
|
|
|
#include <linux/device.h>
|
accel: add dedicated minor for accelerator devices
The accelerator devices are exposed to user-space using a dedicated
major. In addition, they are represented in /dev with new, dedicated
device char names: /dev/accel/accel*. This is done to make sure any
user-space software that tries to open a graphic card won't open
the accelerator device by mistake.
The above implies that the minor numbering should be separated from
the rest of the DRM devices. However, to avoid code duplication, we
want the drm_minor structure to be able to represent the accelerator
device.
To achieve this, we add a new drm_minor* to drm_device that represents
the accelerator device. This pointer is initialized for drivers that
declare they handle compute accelerator, using a new driver feature
flag called DRIVER_COMPUTE_ACCEL. It is important to note that this
driver feature is mutually exclusive with DRIVER_RENDER. Devices that
want to expose both graphics and compute device char files should be
handled by two drivers that are connected using the auxiliary bus
framework.
In addition, we define a different IDR to handle the accelerators
minors. This is done to make the minor's index be identical to the
device index in /dev/. Any access to the IDR is done solely
by functions in accel_drv.c, as the IDR is define as static. The
DRM core functions call those functions in case they detect the minor's
type is DRM_MINOR_ACCEL.
We define a separate accel_open function (from drm_open) that the
accel drivers should set as their open callback function. Both these
functions eventually call the same drm_open_helper(), which had to be
changed to be non-static so it can be called from accel_drv.c.
accel_open() only partially duplicates drm_open as I removed some code
from it that handles legacy devices.
To help new drivers, I defined DEFINE_DRM_ACCEL_FOPS macro to easily
set the required function operations pointers structure.
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
Reviewed-by: Dave Airlie <airlied@redhat.com>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Tested-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Reviewed-by: Melissa Wen <mwen@igalia.com>
2022-10-31 16:33:06 +03:00
|
|
|
#include <linux/idr.h>
|
2022-10-31 16:28:35 +03:00
|
|
|
|
|
|
|
#include <drm/drm_accel.h>
|
accel: add dedicated minor for accelerator devices
The accelerator devices are exposed to user-space using a dedicated
major. In addition, they are represented in /dev with new, dedicated
device char names: /dev/accel/accel*. This is done to make sure any
user-space software that tries to open a graphic card won't open
the accelerator device by mistake.
The above implies that the minor numbering should be separated from
the rest of the DRM devices. However, to avoid code duplication, we
want the drm_minor structure to be able to represent the accelerator
device.
To achieve this, we add a new drm_minor* to drm_device that represents
the accelerator device. This pointer is initialized for drivers that
declare they handle compute accelerator, using a new driver feature
flag called DRIVER_COMPUTE_ACCEL. It is important to note that this
driver feature is mutually exclusive with DRIVER_RENDER. Devices that
want to expose both graphics and compute device char files should be
handled by two drivers that are connected using the auxiliary bus
framework.
In addition, we define a different IDR to handle the accelerators
minors. This is done to make the minor's index be identical to the
device index in /dev/. Any access to the IDR is done solely
by functions in accel_drv.c, as the IDR is define as static. The
DRM core functions call those functions in case they detect the minor's
type is DRM_MINOR_ACCEL.
We define a separate accel_open function (from drm_open) that the
accel drivers should set as their open callback function. Both these
functions eventually call the same drm_open_helper(), which had to be
changed to be non-static so it can be called from accel_drv.c.
accel_open() only partially duplicates drm_open as I removed some code
from it that handles legacy devices.
To help new drivers, I defined DEFINE_DRM_ACCEL_FOPS macro to easily
set the required function operations pointers structure.
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
Reviewed-by: Dave Airlie <airlied@redhat.com>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Tested-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Reviewed-by: Melissa Wen <mwen@igalia.com>
2022-10-31 16:33:06 +03:00
|
|
|
#include <drm/drm_debugfs.h>
|
|
|
|
#include <drm/drm_drv.h>
|
|
|
|
#include <drm/drm_file.h>
|
2022-10-31 16:28:35 +03:00
|
|
|
#include <drm/drm_ioctl.h>
|
|
|
|
#include <drm/drm_print.h>
|
|
|
|
|
accel: add dedicated minor for accelerator devices
The accelerator devices are exposed to user-space using a dedicated
major. In addition, they are represented in /dev with new, dedicated
device char names: /dev/accel/accel*. This is done to make sure any
user-space software that tries to open a graphic card won't open
the accelerator device by mistake.
The above implies that the minor numbering should be separated from
the rest of the DRM devices. However, to avoid code duplication, we
want the drm_minor structure to be able to represent the accelerator
device.
To achieve this, we add a new drm_minor* to drm_device that represents
the accelerator device. This pointer is initialized for drivers that
declare they handle compute accelerator, using a new driver feature
flag called DRIVER_COMPUTE_ACCEL. It is important to note that this
driver feature is mutually exclusive with DRIVER_RENDER. Devices that
want to expose both graphics and compute device char files should be
handled by two drivers that are connected using the auxiliary bus
framework.
In addition, we define a different IDR to handle the accelerators
minors. This is done to make the minor's index be identical to the
device index in /dev/. Any access to the IDR is done solely
by functions in accel_drv.c, as the IDR is define as static. The
DRM core functions call those functions in case they detect the minor's
type is DRM_MINOR_ACCEL.
We define a separate accel_open function (from drm_open) that the
accel drivers should set as their open callback function. Both these
functions eventually call the same drm_open_helper(), which had to be
changed to be non-static so it can be called from accel_drv.c.
accel_open() only partially duplicates drm_open as I removed some code
from it that handles legacy devices.
To help new drivers, I defined DEFINE_DRM_ACCEL_FOPS macro to easily
set the required function operations pointers structure.
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
Reviewed-by: Dave Airlie <airlied@redhat.com>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Tested-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Reviewed-by: Melissa Wen <mwen@igalia.com>
2022-10-31 16:33:06 +03:00
|
|
|
static DEFINE_SPINLOCK(accel_minor_lock);
|
|
|
|
static struct idr accel_minors_idr;
|
|
|
|
|
2022-10-31 16:28:35 +03:00
|
|
|
static struct dentry *accel_debugfs_root;
|
|
|
|
static struct class *accel_class;
|
|
|
|
|
accel: add dedicated minor for accelerator devices
The accelerator devices are exposed to user-space using a dedicated
major. In addition, they are represented in /dev with new, dedicated
device char names: /dev/accel/accel*. This is done to make sure any
user-space software that tries to open a graphic card won't open
the accelerator device by mistake.
The above implies that the minor numbering should be separated from
the rest of the DRM devices. However, to avoid code duplication, we
want the drm_minor structure to be able to represent the accelerator
device.
To achieve this, we add a new drm_minor* to drm_device that represents
the accelerator device. This pointer is initialized for drivers that
declare they handle compute accelerator, using a new driver feature
flag called DRIVER_COMPUTE_ACCEL. It is important to note that this
driver feature is mutually exclusive with DRIVER_RENDER. Devices that
want to expose both graphics and compute device char files should be
handled by two drivers that are connected using the auxiliary bus
framework.
In addition, we define a different IDR to handle the accelerators
minors. This is done to make the minor's index be identical to the
device index in /dev/. Any access to the IDR is done solely
by functions in accel_drv.c, as the IDR is define as static. The
DRM core functions call those functions in case they detect the minor's
type is DRM_MINOR_ACCEL.
We define a separate accel_open function (from drm_open) that the
accel drivers should set as their open callback function. Both these
functions eventually call the same drm_open_helper(), which had to be
changed to be non-static so it can be called from accel_drv.c.
accel_open() only partially duplicates drm_open as I removed some code
from it that handles legacy devices.
To help new drivers, I defined DEFINE_DRM_ACCEL_FOPS macro to easily
set the required function operations pointers structure.
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
Reviewed-by: Dave Airlie <airlied@redhat.com>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Tested-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Reviewed-by: Melissa Wen <mwen@igalia.com>
2022-10-31 16:33:06 +03:00
|
|
|
static struct device_type accel_sysfs_device_minor = {
|
|
|
|
.name = "accel_minor"
|
|
|
|
};
|
|
|
|
|
2022-12-16 22:04:15 +03:00
|
|
|
static char *accel_devnode(const struct device *dev, umode_t *mode)
|
2022-10-31 16:28:35 +03:00
|
|
|
{
|
|
|
|
return kasprintf(GFP_KERNEL, "accel/%s", dev_name(dev));
|
|
|
|
}
|
|
|
|
|
|
|
|
static int accel_sysfs_init(void)
|
|
|
|
{
|
|
|
|
accel_class = class_create(THIS_MODULE, "accel");
|
|
|
|
if (IS_ERR(accel_class))
|
|
|
|
return PTR_ERR(accel_class);
|
|
|
|
|
|
|
|
accel_class->devnode = accel_devnode;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void accel_sysfs_destroy(void)
|
|
|
|
{
|
|
|
|
if (IS_ERR_OR_NULL(accel_class))
|
|
|
|
return;
|
|
|
|
class_destroy(accel_class);
|
|
|
|
accel_class = NULL;
|
|
|
|
}
|
|
|
|
|
accel: add dedicated minor for accelerator devices
The accelerator devices are exposed to user-space using a dedicated
major. In addition, they are represented in /dev with new, dedicated
device char names: /dev/accel/accel*. This is done to make sure any
user-space software that tries to open a graphic card won't open
the accelerator device by mistake.
The above implies that the minor numbering should be separated from
the rest of the DRM devices. However, to avoid code duplication, we
want the drm_minor structure to be able to represent the accelerator
device.
To achieve this, we add a new drm_minor* to drm_device that represents
the accelerator device. This pointer is initialized for drivers that
declare they handle compute accelerator, using a new driver feature
flag called DRIVER_COMPUTE_ACCEL. It is important to note that this
driver feature is mutually exclusive with DRIVER_RENDER. Devices that
want to expose both graphics and compute device char files should be
handled by two drivers that are connected using the auxiliary bus
framework.
In addition, we define a different IDR to handle the accelerators
minors. This is done to make the minor's index be identical to the
device index in /dev/. Any access to the IDR is done solely
by functions in accel_drv.c, as the IDR is define as static. The
DRM core functions call those functions in case they detect the minor's
type is DRM_MINOR_ACCEL.
We define a separate accel_open function (from drm_open) that the
accel drivers should set as their open callback function. Both these
functions eventually call the same drm_open_helper(), which had to be
changed to be non-static so it can be called from accel_drv.c.
accel_open() only partially duplicates drm_open as I removed some code
from it that handles legacy devices.
To help new drivers, I defined DEFINE_DRM_ACCEL_FOPS macro to easily
set the required function operations pointers structure.
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
Reviewed-by: Dave Airlie <airlied@redhat.com>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Tested-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Reviewed-by: Melissa Wen <mwen@igalia.com>
2022-10-31 16:33:06 +03:00
|
|
|
static int accel_name_info(struct seq_file *m, void *data)
|
|
|
|
{
|
|
|
|
struct drm_info_node *node = (struct drm_info_node *) m->private;
|
|
|
|
struct drm_minor *minor = node->minor;
|
|
|
|
struct drm_device *dev = minor->dev;
|
|
|
|
struct drm_master *master;
|
|
|
|
|
|
|
|
mutex_lock(&dev->master_mutex);
|
|
|
|
master = dev->master;
|
|
|
|
seq_printf(m, "%s", dev->driver->name);
|
|
|
|
if (dev->dev)
|
|
|
|
seq_printf(m, " dev=%s", dev_name(dev->dev));
|
|
|
|
if (master && master->unique)
|
|
|
|
seq_printf(m, " master=%s", master->unique);
|
|
|
|
if (dev->unique)
|
|
|
|
seq_printf(m, " unique=%s", dev->unique);
|
|
|
|
seq_puts(m, "\n");
|
|
|
|
mutex_unlock(&dev->master_mutex);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static const struct drm_info_list accel_debugfs_list[] = {
|
|
|
|
{"name", accel_name_info, 0}
|
|
|
|
};
|
|
|
|
#define ACCEL_DEBUGFS_ENTRIES ARRAY_SIZE(accel_debugfs_list)
|
|
|
|
|
|
|
|
/**
|
|
|
|
* accel_debugfs_init() - Initialize debugfs for accel minor
|
|
|
|
* @minor: Pointer to the drm_minor instance.
|
|
|
|
* @minor_id: The minor's id
|
|
|
|
*
|
|
|
|
* This function initializes the drm minor's debugfs members and creates
|
|
|
|
* a root directory for the minor in debugfs. It also creates common files
|
|
|
|
* for accelerators and calls the driver's debugfs init callback.
|
|
|
|
*/
|
|
|
|
void accel_debugfs_init(struct drm_minor *minor, int minor_id)
|
|
|
|
{
|
|
|
|
struct drm_device *dev = minor->dev;
|
|
|
|
char name[64];
|
|
|
|
|
|
|
|
INIT_LIST_HEAD(&minor->debugfs_list);
|
|
|
|
mutex_init(&minor->debugfs_lock);
|
|
|
|
sprintf(name, "%d", minor_id);
|
|
|
|
minor->debugfs_root = debugfs_create_dir(name, accel_debugfs_root);
|
|
|
|
|
|
|
|
drm_debugfs_create_files(accel_debugfs_list, ACCEL_DEBUGFS_ENTRIES,
|
|
|
|
minor->debugfs_root, minor);
|
|
|
|
|
|
|
|
if (dev->driver->debugfs_init)
|
|
|
|
dev->driver->debugfs_init(minor);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* accel_set_device_instance_params() - Set some device parameters for accel device
|
|
|
|
* @kdev: Pointer to the device instance.
|
|
|
|
* @index: The minor's index
|
|
|
|
*
|
|
|
|
* This function creates the dev_t of the device using the accel major and
|
|
|
|
* the device's minor number. In addition, it sets the class and type of the
|
|
|
|
* device instance to the accel sysfs class and device type, respectively.
|
|
|
|
*/
|
|
|
|
void accel_set_device_instance_params(struct device *kdev, int index)
|
|
|
|
{
|
|
|
|
kdev->devt = MKDEV(ACCEL_MAJOR, index);
|
|
|
|
kdev->class = accel_class;
|
|
|
|
kdev->type = &accel_sysfs_device_minor;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* accel_minor_alloc() - Allocates a new accel minor
|
|
|
|
*
|
|
|
|
* This function access the accel minors idr and allocates from it
|
|
|
|
* a new id to represent a new accel minor
|
|
|
|
*
|
|
|
|
* Return: A new id on success or error code in case idr_alloc failed
|
|
|
|
*/
|
|
|
|
int accel_minor_alloc(void)
|
|
|
|
{
|
|
|
|
unsigned long flags;
|
|
|
|
int r;
|
|
|
|
|
|
|
|
spin_lock_irqsave(&accel_minor_lock, flags);
|
|
|
|
r = idr_alloc(&accel_minors_idr, NULL, 0, ACCEL_MAX_MINORS, GFP_NOWAIT);
|
|
|
|
spin_unlock_irqrestore(&accel_minor_lock, flags);
|
|
|
|
|
|
|
|
return r;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* accel_minor_remove() - Remove an accel minor
|
|
|
|
* @index: The minor id to remove.
|
|
|
|
*
|
|
|
|
* This function access the accel minors idr and removes from
|
|
|
|
* it the member with the id that is passed to this function.
|
|
|
|
*/
|
|
|
|
void accel_minor_remove(int index)
|
|
|
|
{
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
spin_lock_irqsave(&accel_minor_lock, flags);
|
|
|
|
idr_remove(&accel_minors_idr, index);
|
|
|
|
spin_unlock_irqrestore(&accel_minor_lock, flags);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* accel_minor_replace() - Replace minor pointer in accel minors idr.
|
|
|
|
* @minor: Pointer to the new minor.
|
|
|
|
* @index: The minor id to replace.
|
|
|
|
*
|
|
|
|
* This function access the accel minors idr structure and replaces the pointer
|
|
|
|
* that is associated with an existing id. Because the minor pointer can be
|
|
|
|
* NULL, we need to explicitly pass the index.
|
|
|
|
*
|
|
|
|
* Return: 0 for success, negative value for error
|
|
|
|
*/
|
|
|
|
void accel_minor_replace(struct drm_minor *minor, int index)
|
|
|
|
{
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
spin_lock_irqsave(&accel_minor_lock, flags);
|
|
|
|
idr_replace(&accel_minors_idr, minor, index);
|
|
|
|
spin_unlock_irqrestore(&accel_minor_lock, flags);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Looks up the given minor-ID and returns the respective DRM-minor object. The
|
|
|
|
* refence-count of the underlying device is increased so you must release this
|
|
|
|
* object with accel_minor_release().
|
|
|
|
*
|
|
|
|
* The object can be only a drm_minor that represents an accel device.
|
|
|
|
*
|
|
|
|
* As long as you hold this minor, it is guaranteed that the object and the
|
|
|
|
* minor->dev pointer will stay valid! However, the device may get unplugged and
|
|
|
|
* unregistered while you hold the minor.
|
|
|
|
*/
|
|
|
|
static struct drm_minor *accel_minor_acquire(unsigned int minor_id)
|
|
|
|
{
|
|
|
|
struct drm_minor *minor;
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
spin_lock_irqsave(&accel_minor_lock, flags);
|
|
|
|
minor = idr_find(&accel_minors_idr, minor_id);
|
|
|
|
if (minor)
|
|
|
|
drm_dev_get(minor->dev);
|
|
|
|
spin_unlock_irqrestore(&accel_minor_lock, flags);
|
|
|
|
|
|
|
|
if (!minor) {
|
|
|
|
return ERR_PTR(-ENODEV);
|
|
|
|
} else if (drm_dev_is_unplugged(minor->dev)) {
|
|
|
|
drm_dev_put(minor->dev);
|
|
|
|
return ERR_PTR(-ENODEV);
|
|
|
|
}
|
|
|
|
|
|
|
|
return minor;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void accel_minor_release(struct drm_minor *minor)
|
|
|
|
{
|
|
|
|
drm_dev_put(minor->dev);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* accel_open - open method for ACCEL file
|
|
|
|
* @inode: device inode
|
|
|
|
* @filp: file pointer.
|
|
|
|
*
|
|
|
|
* This function must be used by drivers as their &file_operations.open method.
|
|
|
|
* It looks up the correct ACCEL device and instantiates all the per-file
|
|
|
|
* resources for it. It also calls the &drm_driver.open driver callback.
|
|
|
|
*
|
|
|
|
* Return: 0 on success or negative errno value on failure.
|
|
|
|
*/
|
|
|
|
int accel_open(struct inode *inode, struct file *filp)
|
|
|
|
{
|
|
|
|
struct drm_device *dev;
|
|
|
|
struct drm_minor *minor;
|
|
|
|
int retcode;
|
|
|
|
|
|
|
|
minor = accel_minor_acquire(iminor(inode));
|
|
|
|
if (IS_ERR(minor))
|
|
|
|
return PTR_ERR(minor);
|
|
|
|
|
|
|
|
dev = minor->dev;
|
|
|
|
|
|
|
|
atomic_fetch_inc(&dev->open_count);
|
|
|
|
|
|
|
|
/* share address_space across all char-devs of a single device */
|
|
|
|
filp->f_mapping = dev->anon_inode->i_mapping;
|
|
|
|
|
|
|
|
retcode = drm_open_helper(filp, minor);
|
|
|
|
if (retcode)
|
|
|
|
goto err_undo;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
err_undo:
|
|
|
|
atomic_dec(&dev->open_count);
|
|
|
|
accel_minor_release(minor);
|
|
|
|
return retcode;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(accel_open);
|
|
|
|
|
2022-10-31 16:28:35 +03:00
|
|
|
static int accel_stub_open(struct inode *inode, struct file *filp)
|
|
|
|
{
|
accel: add dedicated minor for accelerator devices
The accelerator devices are exposed to user-space using a dedicated
major. In addition, they are represented in /dev with new, dedicated
device char names: /dev/accel/accel*. This is done to make sure any
user-space software that tries to open a graphic card won't open
the accelerator device by mistake.
The above implies that the minor numbering should be separated from
the rest of the DRM devices. However, to avoid code duplication, we
want the drm_minor structure to be able to represent the accelerator
device.
To achieve this, we add a new drm_minor* to drm_device that represents
the accelerator device. This pointer is initialized for drivers that
declare they handle compute accelerator, using a new driver feature
flag called DRIVER_COMPUTE_ACCEL. It is important to note that this
driver feature is mutually exclusive with DRIVER_RENDER. Devices that
want to expose both graphics and compute device char files should be
handled by two drivers that are connected using the auxiliary bus
framework.
In addition, we define a different IDR to handle the accelerators
minors. This is done to make the minor's index be identical to the
device index in /dev/. Any access to the IDR is done solely
by functions in accel_drv.c, as the IDR is define as static. The
DRM core functions call those functions in case they detect the minor's
type is DRM_MINOR_ACCEL.
We define a separate accel_open function (from drm_open) that the
accel drivers should set as their open callback function. Both these
functions eventually call the same drm_open_helper(), which had to be
changed to be non-static so it can be called from accel_drv.c.
accel_open() only partially duplicates drm_open as I removed some code
from it that handles legacy devices.
To help new drivers, I defined DEFINE_DRM_ACCEL_FOPS macro to easily
set the required function operations pointers structure.
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
Reviewed-by: Dave Airlie <airlied@redhat.com>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Tested-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Reviewed-by: Melissa Wen <mwen@igalia.com>
2022-10-31 16:33:06 +03:00
|
|
|
const struct file_operations *new_fops;
|
|
|
|
struct drm_minor *minor;
|
|
|
|
int err;
|
|
|
|
|
|
|
|
minor = accel_minor_acquire(iminor(inode));
|
|
|
|
if (IS_ERR(minor))
|
|
|
|
return PTR_ERR(minor);
|
|
|
|
|
|
|
|
new_fops = fops_get(minor->dev->driver->fops);
|
|
|
|
if (!new_fops) {
|
|
|
|
err = -ENODEV;
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
|
|
|
replace_fops(filp, new_fops);
|
|
|
|
if (filp->f_op->open)
|
|
|
|
err = filp->f_op->open(inode, filp);
|
|
|
|
else
|
|
|
|
err = 0;
|
|
|
|
|
|
|
|
out:
|
|
|
|
accel_minor_release(minor);
|
|
|
|
|
|
|
|
return err;
|
2022-10-31 16:28:35 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
static const struct file_operations accel_stub_fops = {
|
|
|
|
.owner = THIS_MODULE,
|
|
|
|
.open = accel_stub_open,
|
|
|
|
.llseek = noop_llseek,
|
|
|
|
};
|
|
|
|
|
|
|
|
void accel_core_exit(void)
|
|
|
|
{
|
|
|
|
unregister_chrdev(ACCEL_MAJOR, "accel");
|
|
|
|
debugfs_remove(accel_debugfs_root);
|
|
|
|
accel_sysfs_destroy();
|
accel: add dedicated minor for accelerator devices
The accelerator devices are exposed to user-space using a dedicated
major. In addition, they are represented in /dev with new, dedicated
device char names: /dev/accel/accel*. This is done to make sure any
user-space software that tries to open a graphic card won't open
the accelerator device by mistake.
The above implies that the minor numbering should be separated from
the rest of the DRM devices. However, to avoid code duplication, we
want the drm_minor structure to be able to represent the accelerator
device.
To achieve this, we add a new drm_minor* to drm_device that represents
the accelerator device. This pointer is initialized for drivers that
declare they handle compute accelerator, using a new driver feature
flag called DRIVER_COMPUTE_ACCEL. It is important to note that this
driver feature is mutually exclusive with DRIVER_RENDER. Devices that
want to expose both graphics and compute device char files should be
handled by two drivers that are connected using the auxiliary bus
framework.
In addition, we define a different IDR to handle the accelerators
minors. This is done to make the minor's index be identical to the
device index in /dev/. Any access to the IDR is done solely
by functions in accel_drv.c, as the IDR is define as static. The
DRM core functions call those functions in case they detect the minor's
type is DRM_MINOR_ACCEL.
We define a separate accel_open function (from drm_open) that the
accel drivers should set as their open callback function. Both these
functions eventually call the same drm_open_helper(), which had to be
changed to be non-static so it can be called from accel_drv.c.
accel_open() only partially duplicates drm_open as I removed some code
from it that handles legacy devices.
To help new drivers, I defined DEFINE_DRM_ACCEL_FOPS macro to easily
set the required function operations pointers structure.
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
Reviewed-by: Dave Airlie <airlied@redhat.com>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Tested-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Reviewed-by: Melissa Wen <mwen@igalia.com>
2022-10-31 16:33:06 +03:00
|
|
|
idr_destroy(&accel_minors_idr);
|
2022-10-31 16:28:35 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
int __init accel_core_init(void)
|
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
|
accel: add dedicated minor for accelerator devices
The accelerator devices are exposed to user-space using a dedicated
major. In addition, they are represented in /dev with new, dedicated
device char names: /dev/accel/accel*. This is done to make sure any
user-space software that tries to open a graphic card won't open
the accelerator device by mistake.
The above implies that the minor numbering should be separated from
the rest of the DRM devices. However, to avoid code duplication, we
want the drm_minor structure to be able to represent the accelerator
device.
To achieve this, we add a new drm_minor* to drm_device that represents
the accelerator device. This pointer is initialized for drivers that
declare they handle compute accelerator, using a new driver feature
flag called DRIVER_COMPUTE_ACCEL. It is important to note that this
driver feature is mutually exclusive with DRIVER_RENDER. Devices that
want to expose both graphics and compute device char files should be
handled by two drivers that are connected using the auxiliary bus
framework.
In addition, we define a different IDR to handle the accelerators
minors. This is done to make the minor's index be identical to the
device index in /dev/. Any access to the IDR is done solely
by functions in accel_drv.c, as the IDR is define as static. The
DRM core functions call those functions in case they detect the minor's
type is DRM_MINOR_ACCEL.
We define a separate accel_open function (from drm_open) that the
accel drivers should set as their open callback function. Both these
functions eventually call the same drm_open_helper(), which had to be
changed to be non-static so it can be called from accel_drv.c.
accel_open() only partially duplicates drm_open as I removed some code
from it that handles legacy devices.
To help new drivers, I defined DEFINE_DRM_ACCEL_FOPS macro to easily
set the required function operations pointers structure.
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
Reviewed-by: Dave Airlie <airlied@redhat.com>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Tested-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Reviewed-by: Melissa Wen <mwen@igalia.com>
2022-10-31 16:33:06 +03:00
|
|
|
idr_init(&accel_minors_idr);
|
|
|
|
|
2022-10-31 16:28:35 +03:00
|
|
|
ret = accel_sysfs_init();
|
|
|
|
if (ret < 0) {
|
|
|
|
DRM_ERROR("Cannot create ACCEL class: %d\n", ret);
|
|
|
|
goto error;
|
|
|
|
}
|
|
|
|
|
|
|
|
accel_debugfs_root = debugfs_create_dir("accel", NULL);
|
|
|
|
|
|
|
|
ret = register_chrdev(ACCEL_MAJOR, "accel", &accel_stub_fops);
|
|
|
|
if (ret < 0)
|
|
|
|
DRM_ERROR("Cannot register ACCEL major: %d\n", ret);
|
|
|
|
|
|
|
|
error:
|
|
|
|
/*
|
|
|
|
* Any cleanup due to errors will be done in drm_core_exit() that
|
|
|
|
* will call accel_core_exit()
|
|
|
|
*/
|
|
|
|
return ret;
|
|
|
|
}
|