rseq: Introduce restartable sequences system call
Expose a new system call allowing each thread to register one userspace
memory area to be used as an ABI between kernel and user-space for two
purposes: user-space restartable sequences and quick access to read the
current CPU number value from user-space.
* Restartable sequences (per-cpu atomics)
Restartables sequences allow user-space to perform update operations on
per-cpu data without requiring heavy-weight atomic operations.
The restartable critical sections (percpu atomics) work has been started
by Paul Turner and Andrew Hunter. It lets the kernel handle restart of
critical sections. [1] [2] The re-implementation proposed here brings a
few simplifications to the ABI which facilitates porting to other
architectures and speeds up the user-space fast path.
Here are benchmarks of various rseq use-cases.
Test hardware:
arm32: ARMv7 Processor rev 4 (v7l) "Cubietruck", 2-core
x86-64: Intel E5-2630 v3@2.40GHz, 16-core, hyperthreading
The following benchmarks were all performed on a single thread.
* Per-CPU statistic counter increment
getcpu+atomic (ns/op) rseq (ns/op) speedup
arm32: 344.0 31.4 11.0
x86-64: 15.3 2.0 7.7
* LTTng-UST: write event 32-bit header, 32-bit payload into tracer
per-cpu buffer
getcpu+atomic (ns/op) rseq (ns/op) speedup
arm32: 2502.0 2250.0 1.1
x86-64: 117.4 98.0 1.2
* liburcu percpu: lock-unlock pair, dereference, read/compare word
getcpu+atomic (ns/op) rseq (ns/op) speedup
arm32: 751.0 128.5 5.8
x86-64: 53.4 28.6 1.9
* jemalloc memory allocator adapted to use rseq
Using rseq with per-cpu memory pools in jemalloc at Facebook (based on
rseq 2016 implementation):
The production workload response-time has 1-2% gain avg. latency, and
the P99 overall latency drops by 2-3%.
* Reading the current CPU number
Speeding up reading the current CPU number on which the caller thread is
running is done by keeping the current CPU number up do date within the
cpu_id field of the memory area registered by the thread. This is done
by making scheduler preemption set the TIF_NOTIFY_RESUME flag on the
current thread. Upon return to user-space, a notify-resume handler
updates the current CPU value within the registered user-space memory
area. User-space can then read the current CPU number directly from
memory.
Keeping the current cpu id in a memory area shared between kernel and
user-space is an improvement over current mechanisms available to read
the current CPU number, which has the following benefits over
alternative approaches:
- 35x speedup on ARM vs system call through glibc
- 20x speedup on x86 compared to calling glibc, which calls vdso
executing a "lsl" instruction,
- 14x speedup on x86 compared to inlined "lsl" instruction,
- Unlike vdso approaches, this cpu_id value can be read from an inline
assembly, which makes it a useful building block for restartable
sequences.
- The approach of reading the cpu id through memory mapping shared
between kernel and user-space is portable (e.g. ARM), which is not the
case for the lsl-based x86 vdso.
On x86, yet another possible approach would be to use the gs segment
selector to point to user-space per-cpu data. This approach performs
similarly to the cpu id cache, but it has two disadvantages: it is
not portable, and it is incompatible with existing applications already
using the gs segment selector for other purposes.
Benchmarking various approaches for reading the current CPU number:
ARMv7 Processor rev 4 (v7l)
Machine model: Cubietruck
- Baseline (empty loop): 8.4 ns
- Read CPU from rseq cpu_id: 16.7 ns
- Read CPU from rseq cpu_id (lazy register): 19.8 ns
- glibc 2.19-0ubuntu6.6 getcpu: 301.8 ns
- getcpu system call: 234.9 ns
x86-64 Intel(R) Xeon(R) CPU E5-2630 v3 @ 2.40GHz:
- Baseline (empty loop): 0.8 ns
- Read CPU from rseq cpu_id: 0.8 ns
- Read CPU from rseq cpu_id (lazy register): 0.8 ns
- Read using gs segment selector: 0.8 ns
- "lsl" inline assembly: 13.0 ns
- glibc 2.19-0ubuntu6 getcpu: 16.6 ns
- getcpu system call: 53.9 ns
- Speed (benchmark taken on v8 of patchset)
Running 10 runs of hackbench -l 100000 seems to indicate, contrary to
expectations, that enabling CONFIG_RSEQ slightly accelerates the
scheduler:
Configuration: 2 sockets * 8-core Intel(R) Xeon(R) CPU E5-2630 v3 @
2.40GHz (directly on hardware, hyperthreading disabled in BIOS, energy
saving disabled in BIOS, turboboost disabled in BIOS, cpuidle.off=1
kernel parameter), with a Linux v4.6 defconfig+localyesconfig,
restartable sequences series applied.
* CONFIG_RSEQ=n
avg.: 41.37 s
std.dev.: 0.36 s
* CONFIG_RSEQ=y
avg.: 40.46 s
std.dev.: 0.33 s
- Size
On x86-64, between CONFIG_RSEQ=n/y, the text size increase of vmlinux is
567 bytes, and the data size increase of vmlinux is 5696 bytes.
[1] https://lwn.net/Articles/650333/
[2] http://www.linuxplumbersconf.org/2013/ocw/system/presentations/1695/original/LPC%20-%20PerCpu%20Atomics.pdf
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Joel Fernandes <joelaf@google.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Dave Watson <davejwatson@fb.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: "H . Peter Anvin" <hpa@zytor.com>
Cc: Chris Lameter <cl@linux.com>
Cc: Russell King <linux@arm.linux.org.uk>
Cc: Andrew Hunter <ahh@google.com>
Cc: Michael Kerrisk <mtk.manpages@gmail.com>
Cc: "Paul E . McKenney" <paulmck@linux.vnet.ibm.com>
Cc: Paul Turner <pjt@google.com>
Cc: Boqun Feng <boqun.feng@gmail.com>
Cc: Josh Triplett <josh@joshtriplett.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Ben Maurer <bmaurer@fb.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: linux-api@vger.kernel.org
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: http://lkml.kernel.org/r/20151027235635.16059.11630.stgit@pjt-glaptop.roam.corp.google.com
Link: http://lkml.kernel.org/r/20150624222609.6116.86035.stgit@kitami.mtv.corp.google.com
Link: https://lkml.kernel.org/r/20180602124408.8430-3-mathieu.desnoyers@efficios.com
2018-06-02 15:43:54 +03:00
|
|
|
// SPDX-License-Identifier: GPL-2.0+
|
|
|
|
/*
|
|
|
|
* Restartable sequences system call
|
|
|
|
*
|
|
|
|
* Copyright (C) 2015, Google, Inc.,
|
|
|
|
* Paul Turner <pjt@google.com> and Andrew Hunter <ahh@google.com>
|
|
|
|
* Copyright (C) 2015-2018, EfficiOS Inc.,
|
|
|
|
* Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <linux/sched.h>
|
|
|
|
#include <linux/uaccess.h>
|
|
|
|
#include <linux/syscalls.h>
|
|
|
|
#include <linux/rseq.h>
|
|
|
|
#include <linux/types.h>
|
|
|
|
#include <asm/ptrace.h>
|
|
|
|
|
|
|
|
#define CREATE_TRACE_POINTS
|
|
|
|
#include <trace/events/rseq.h>
|
|
|
|
|
|
|
|
#define RSEQ_CS_PREEMPT_MIGRATE_FLAGS (RSEQ_CS_FLAG_NO_RESTART_ON_MIGRATE | \
|
|
|
|
RSEQ_CS_FLAG_NO_RESTART_ON_PREEMPT)
|
|
|
|
|
|
|
|
/*
|
|
|
|
*
|
|
|
|
* Restartable sequences are a lightweight interface that allows
|
|
|
|
* user-level code to be executed atomically relative to scheduler
|
|
|
|
* preemption and signal delivery. Typically used for implementing
|
|
|
|
* per-cpu operations.
|
|
|
|
*
|
|
|
|
* It allows user-space to perform update operations on per-cpu data
|
|
|
|
* without requiring heavy-weight atomic operations.
|
|
|
|
*
|
|
|
|
* Detailed algorithm of rseq user-space assembly sequences:
|
|
|
|
*
|
|
|
|
* init(rseq_cs)
|
|
|
|
* cpu = TLS->rseq::cpu_id_start
|
|
|
|
* [1] TLS->rseq::rseq_cs = rseq_cs
|
|
|
|
* [start_ip] ----------------------------
|
|
|
|
* [2] if (cpu != TLS->rseq::cpu_id)
|
|
|
|
* goto abort_ip;
|
|
|
|
* [3] <last_instruction_in_cs>
|
|
|
|
* [post_commit_ip] ----------------------------
|
|
|
|
*
|
|
|
|
* The address of jump target abort_ip must be outside the critical
|
|
|
|
* region, i.e.:
|
|
|
|
*
|
|
|
|
* [abort_ip] < [start_ip] || [abort_ip] >= [post_commit_ip]
|
|
|
|
*
|
|
|
|
* Steps [2]-[3] (inclusive) need to be a sequence of instructions in
|
|
|
|
* userspace that can handle being interrupted between any of those
|
|
|
|
* instructions, and then resumed to the abort_ip.
|
|
|
|
*
|
|
|
|
* 1. Userspace stores the address of the struct rseq_cs assembly
|
|
|
|
* block descriptor into the rseq_cs field of the registered
|
|
|
|
* struct rseq TLS area. This update is performed through a single
|
|
|
|
* store within the inline assembly instruction sequence.
|
|
|
|
* [start_ip]
|
|
|
|
*
|
|
|
|
* 2. Userspace tests to check whether the current cpu_id field match
|
|
|
|
* the cpu number loaded before start_ip, branching to abort_ip
|
|
|
|
* in case of a mismatch.
|
|
|
|
*
|
|
|
|
* If the sequence is preempted or interrupted by a signal
|
|
|
|
* at or after start_ip and before post_commit_ip, then the kernel
|
|
|
|
* clears TLS->__rseq_abi::rseq_cs, and sets the user-space return
|
|
|
|
* ip to abort_ip before returning to user-space, so the preempted
|
|
|
|
* execution resumes at abort_ip.
|
|
|
|
*
|
|
|
|
* 3. Userspace critical section final instruction before
|
|
|
|
* post_commit_ip is the commit. The critical section is
|
|
|
|
* self-terminating.
|
|
|
|
* [post_commit_ip]
|
|
|
|
*
|
|
|
|
* 4. <success>
|
|
|
|
*
|
|
|
|
* On failure at [2], or if interrupted by preempt or signal delivery
|
|
|
|
* between [1] and [3]:
|
|
|
|
*
|
|
|
|
* [abort_ip]
|
|
|
|
* F1. <failure>
|
|
|
|
*/
|
|
|
|
|
|
|
|
static int rseq_update_cpu_id(struct task_struct *t)
|
|
|
|
{
|
|
|
|
u32 cpu_id = raw_smp_processor_id();
|
|
|
|
|
|
|
|
if (__put_user(cpu_id, &t->rseq->cpu_id_start))
|
|
|
|
return -EFAULT;
|
|
|
|
if (__put_user(cpu_id, &t->rseq->cpu_id))
|
|
|
|
return -EFAULT;
|
|
|
|
trace_rseq_update(t);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int rseq_reset_rseq_cpu_id(struct task_struct *t)
|
|
|
|
{
|
|
|
|
u32 cpu_id_start = 0, cpu_id = RSEQ_CPU_ID_UNINITIALIZED;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Reset cpu_id_start to its initial state (0).
|
|
|
|
*/
|
|
|
|
if (__put_user(cpu_id_start, &t->rseq->cpu_id_start))
|
|
|
|
return -EFAULT;
|
|
|
|
/*
|
|
|
|
* Reset cpu_id to RSEQ_CPU_ID_UNINITIALIZED, so any user coming
|
|
|
|
* in after unregistration can figure out that rseq needs to be
|
|
|
|
* registered again.
|
|
|
|
*/
|
|
|
|
if (__put_user(cpu_id, &t->rseq->cpu_id))
|
|
|
|
return -EFAULT;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int rseq_get_rseq_cs(struct task_struct *t, struct rseq_cs *rseq_cs)
|
|
|
|
{
|
|
|
|
struct rseq_cs __user *urseq_cs;
|
|
|
|
unsigned long ptr;
|
|
|
|
u32 __user *usig;
|
|
|
|
u32 sig;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
ret = __get_user(ptr, &t->rseq->rseq_cs);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
if (!ptr) {
|
|
|
|
memset(rseq_cs, 0, sizeof(*rseq_cs));
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
urseq_cs = (struct rseq_cs __user *)ptr;
|
|
|
|
if (copy_from_user(rseq_cs, urseq_cs, sizeof(*rseq_cs)))
|
|
|
|
return -EFAULT;
|
|
|
|
if (rseq_cs->version > 0)
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
/* Ensure that abort_ip is not in the critical section. */
|
|
|
|
if (rseq_cs->abort_ip - rseq_cs->start_ip < rseq_cs->post_commit_offset)
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
usig = (u32 __user *)(rseq_cs->abort_ip - sizeof(u32));
|
|
|
|
ret = get_user(sig, usig);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
if (current->rseq_sig != sig) {
|
|
|
|
printk_ratelimited(KERN_WARNING
|
|
|
|
"Possible attack attempt. Unexpected rseq signature 0x%x, expecting 0x%x (pid=%d, addr=%p).\n",
|
|
|
|
sig, current->rseq_sig, current->pid, usig);
|
|
|
|
return -EPERM;
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int rseq_need_restart(struct task_struct *t, u32 cs_flags)
|
|
|
|
{
|
|
|
|
u32 flags, event_mask;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
/* Get thread flags. */
|
|
|
|
ret = __get_user(flags, &t->rseq->flags);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
/* Take critical section flags into account. */
|
|
|
|
flags |= cs_flags;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Restart on signal can only be inhibited when restart on
|
|
|
|
* preempt and restart on migrate are inhibited too. Otherwise,
|
|
|
|
* a preempted signal handler could fail to restart the prior
|
|
|
|
* execution context on sigreturn.
|
|
|
|
*/
|
|
|
|
if (unlikely((flags & RSEQ_CS_FLAG_NO_RESTART_ON_SIGNAL) &&
|
|
|
|
(flags & RSEQ_CS_PREEMPT_MIGRATE_FLAGS) !=
|
|
|
|
RSEQ_CS_PREEMPT_MIGRATE_FLAGS))
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Load and clear event mask atomically with respect to
|
|
|
|
* scheduler preemption.
|
|
|
|
*/
|
|
|
|
preempt_disable();
|
|
|
|
event_mask = t->rseq_event_mask;
|
|
|
|
t->rseq_event_mask = 0;
|
|
|
|
preempt_enable();
|
|
|
|
|
|
|
|
return !!(event_mask & ~flags);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int clear_rseq_cs(struct task_struct *t)
|
|
|
|
{
|
|
|
|
/*
|
|
|
|
* The rseq_cs field is set to NULL on preemption or signal
|
|
|
|
* delivery on top of rseq assembly block, as well as on top
|
|
|
|
* of code outside of the rseq assembly block. This performs
|
|
|
|
* a lazy clear of the rseq_cs field.
|
|
|
|
*
|
|
|
|
* Set rseq_cs to NULL with single-copy atomicity.
|
|
|
|
*/
|
|
|
|
return __put_user(0UL, &t->rseq->rseq_cs);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Unsigned comparison will be true when ip >= start_ip, and when
|
|
|
|
* ip < start_ip + post_commit_offset.
|
|
|
|
*/
|
|
|
|
static bool in_rseq_cs(unsigned long ip, struct rseq_cs *rseq_cs)
|
|
|
|
{
|
|
|
|
return ip - rseq_cs->start_ip < rseq_cs->post_commit_offset;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int rseq_ip_fixup(struct pt_regs *regs)
|
|
|
|
{
|
|
|
|
unsigned long ip = instruction_pointer(regs);
|
|
|
|
struct task_struct *t = current;
|
|
|
|
struct rseq_cs rseq_cs;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
ret = rseq_get_rseq_cs(t, &rseq_cs);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Handle potentially not being within a critical section.
|
|
|
|
* If not nested over a rseq critical section, restart is useless.
|
|
|
|
* Clear the rseq_cs pointer and return.
|
|
|
|
*/
|
|
|
|
if (!in_rseq_cs(ip, &rseq_cs))
|
|
|
|
return clear_rseq_cs(t);
|
|
|
|
ret = rseq_need_restart(t, rseq_cs.flags);
|
|
|
|
if (ret <= 0)
|
|
|
|
return ret;
|
|
|
|
ret = clear_rseq_cs(t);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
trace_rseq_ip_fixup(ip, rseq_cs.start_ip, rseq_cs.post_commit_offset,
|
|
|
|
rseq_cs.abort_ip);
|
|
|
|
instruction_pointer_set(regs, (unsigned long)rseq_cs.abort_ip);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* This resume handler must always be executed between any of:
|
|
|
|
* - preemption,
|
|
|
|
* - signal delivery,
|
|
|
|
* and return to user-space.
|
|
|
|
*
|
|
|
|
* This is how we can ensure that the entire rseq critical section,
|
|
|
|
* consisting of both the C part and the assembly instruction sequence,
|
|
|
|
* will issue the commit instruction only if executed atomically with
|
|
|
|
* respect to other threads scheduled on the same CPU, and with respect
|
|
|
|
* to signal handlers.
|
|
|
|
*/
|
2018-06-22 13:45:07 +03:00
|
|
|
void __rseq_handle_notify_resume(struct ksignal *ksig, struct pt_regs *regs)
|
rseq: Introduce restartable sequences system call
Expose a new system call allowing each thread to register one userspace
memory area to be used as an ABI between kernel and user-space for two
purposes: user-space restartable sequences and quick access to read the
current CPU number value from user-space.
* Restartable sequences (per-cpu atomics)
Restartables sequences allow user-space to perform update operations on
per-cpu data without requiring heavy-weight atomic operations.
The restartable critical sections (percpu atomics) work has been started
by Paul Turner and Andrew Hunter. It lets the kernel handle restart of
critical sections. [1] [2] The re-implementation proposed here brings a
few simplifications to the ABI which facilitates porting to other
architectures and speeds up the user-space fast path.
Here are benchmarks of various rseq use-cases.
Test hardware:
arm32: ARMv7 Processor rev 4 (v7l) "Cubietruck", 2-core
x86-64: Intel E5-2630 v3@2.40GHz, 16-core, hyperthreading
The following benchmarks were all performed on a single thread.
* Per-CPU statistic counter increment
getcpu+atomic (ns/op) rseq (ns/op) speedup
arm32: 344.0 31.4 11.0
x86-64: 15.3 2.0 7.7
* LTTng-UST: write event 32-bit header, 32-bit payload into tracer
per-cpu buffer
getcpu+atomic (ns/op) rseq (ns/op) speedup
arm32: 2502.0 2250.0 1.1
x86-64: 117.4 98.0 1.2
* liburcu percpu: lock-unlock pair, dereference, read/compare word
getcpu+atomic (ns/op) rseq (ns/op) speedup
arm32: 751.0 128.5 5.8
x86-64: 53.4 28.6 1.9
* jemalloc memory allocator adapted to use rseq
Using rseq with per-cpu memory pools in jemalloc at Facebook (based on
rseq 2016 implementation):
The production workload response-time has 1-2% gain avg. latency, and
the P99 overall latency drops by 2-3%.
* Reading the current CPU number
Speeding up reading the current CPU number on which the caller thread is
running is done by keeping the current CPU number up do date within the
cpu_id field of the memory area registered by the thread. This is done
by making scheduler preemption set the TIF_NOTIFY_RESUME flag on the
current thread. Upon return to user-space, a notify-resume handler
updates the current CPU value within the registered user-space memory
area. User-space can then read the current CPU number directly from
memory.
Keeping the current cpu id in a memory area shared between kernel and
user-space is an improvement over current mechanisms available to read
the current CPU number, which has the following benefits over
alternative approaches:
- 35x speedup on ARM vs system call through glibc
- 20x speedup on x86 compared to calling glibc, which calls vdso
executing a "lsl" instruction,
- 14x speedup on x86 compared to inlined "lsl" instruction,
- Unlike vdso approaches, this cpu_id value can be read from an inline
assembly, which makes it a useful building block for restartable
sequences.
- The approach of reading the cpu id through memory mapping shared
between kernel and user-space is portable (e.g. ARM), which is not the
case for the lsl-based x86 vdso.
On x86, yet another possible approach would be to use the gs segment
selector to point to user-space per-cpu data. This approach performs
similarly to the cpu id cache, but it has two disadvantages: it is
not portable, and it is incompatible with existing applications already
using the gs segment selector for other purposes.
Benchmarking various approaches for reading the current CPU number:
ARMv7 Processor rev 4 (v7l)
Machine model: Cubietruck
- Baseline (empty loop): 8.4 ns
- Read CPU from rseq cpu_id: 16.7 ns
- Read CPU from rseq cpu_id (lazy register): 19.8 ns
- glibc 2.19-0ubuntu6.6 getcpu: 301.8 ns
- getcpu system call: 234.9 ns
x86-64 Intel(R) Xeon(R) CPU E5-2630 v3 @ 2.40GHz:
- Baseline (empty loop): 0.8 ns
- Read CPU from rseq cpu_id: 0.8 ns
- Read CPU from rseq cpu_id (lazy register): 0.8 ns
- Read using gs segment selector: 0.8 ns
- "lsl" inline assembly: 13.0 ns
- glibc 2.19-0ubuntu6 getcpu: 16.6 ns
- getcpu system call: 53.9 ns
- Speed (benchmark taken on v8 of patchset)
Running 10 runs of hackbench -l 100000 seems to indicate, contrary to
expectations, that enabling CONFIG_RSEQ slightly accelerates the
scheduler:
Configuration: 2 sockets * 8-core Intel(R) Xeon(R) CPU E5-2630 v3 @
2.40GHz (directly on hardware, hyperthreading disabled in BIOS, energy
saving disabled in BIOS, turboboost disabled in BIOS, cpuidle.off=1
kernel parameter), with a Linux v4.6 defconfig+localyesconfig,
restartable sequences series applied.
* CONFIG_RSEQ=n
avg.: 41.37 s
std.dev.: 0.36 s
* CONFIG_RSEQ=y
avg.: 40.46 s
std.dev.: 0.33 s
- Size
On x86-64, between CONFIG_RSEQ=n/y, the text size increase of vmlinux is
567 bytes, and the data size increase of vmlinux is 5696 bytes.
[1] https://lwn.net/Articles/650333/
[2] http://www.linuxplumbersconf.org/2013/ocw/system/presentations/1695/original/LPC%20-%20PerCpu%20Atomics.pdf
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Joel Fernandes <joelaf@google.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Dave Watson <davejwatson@fb.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: "H . Peter Anvin" <hpa@zytor.com>
Cc: Chris Lameter <cl@linux.com>
Cc: Russell King <linux@arm.linux.org.uk>
Cc: Andrew Hunter <ahh@google.com>
Cc: Michael Kerrisk <mtk.manpages@gmail.com>
Cc: "Paul E . McKenney" <paulmck@linux.vnet.ibm.com>
Cc: Paul Turner <pjt@google.com>
Cc: Boqun Feng <boqun.feng@gmail.com>
Cc: Josh Triplett <josh@joshtriplett.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Ben Maurer <bmaurer@fb.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: linux-api@vger.kernel.org
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: http://lkml.kernel.org/r/20151027235635.16059.11630.stgit@pjt-glaptop.roam.corp.google.com
Link: http://lkml.kernel.org/r/20150624222609.6116.86035.stgit@kitami.mtv.corp.google.com
Link: https://lkml.kernel.org/r/20180602124408.8430-3-mathieu.desnoyers@efficios.com
2018-06-02 15:43:54 +03:00
|
|
|
{
|
|
|
|
struct task_struct *t = current;
|
2018-06-22 13:45:07 +03:00
|
|
|
int ret, sig;
|
rseq: Introduce restartable sequences system call
Expose a new system call allowing each thread to register one userspace
memory area to be used as an ABI between kernel and user-space for two
purposes: user-space restartable sequences and quick access to read the
current CPU number value from user-space.
* Restartable sequences (per-cpu atomics)
Restartables sequences allow user-space to perform update operations on
per-cpu data without requiring heavy-weight atomic operations.
The restartable critical sections (percpu atomics) work has been started
by Paul Turner and Andrew Hunter. It lets the kernel handle restart of
critical sections. [1] [2] The re-implementation proposed here brings a
few simplifications to the ABI which facilitates porting to other
architectures and speeds up the user-space fast path.
Here are benchmarks of various rseq use-cases.
Test hardware:
arm32: ARMv7 Processor rev 4 (v7l) "Cubietruck", 2-core
x86-64: Intel E5-2630 v3@2.40GHz, 16-core, hyperthreading
The following benchmarks were all performed on a single thread.
* Per-CPU statistic counter increment
getcpu+atomic (ns/op) rseq (ns/op) speedup
arm32: 344.0 31.4 11.0
x86-64: 15.3 2.0 7.7
* LTTng-UST: write event 32-bit header, 32-bit payload into tracer
per-cpu buffer
getcpu+atomic (ns/op) rseq (ns/op) speedup
arm32: 2502.0 2250.0 1.1
x86-64: 117.4 98.0 1.2
* liburcu percpu: lock-unlock pair, dereference, read/compare word
getcpu+atomic (ns/op) rseq (ns/op) speedup
arm32: 751.0 128.5 5.8
x86-64: 53.4 28.6 1.9
* jemalloc memory allocator adapted to use rseq
Using rseq with per-cpu memory pools in jemalloc at Facebook (based on
rseq 2016 implementation):
The production workload response-time has 1-2% gain avg. latency, and
the P99 overall latency drops by 2-3%.
* Reading the current CPU number
Speeding up reading the current CPU number on which the caller thread is
running is done by keeping the current CPU number up do date within the
cpu_id field of the memory area registered by the thread. This is done
by making scheduler preemption set the TIF_NOTIFY_RESUME flag on the
current thread. Upon return to user-space, a notify-resume handler
updates the current CPU value within the registered user-space memory
area. User-space can then read the current CPU number directly from
memory.
Keeping the current cpu id in a memory area shared between kernel and
user-space is an improvement over current mechanisms available to read
the current CPU number, which has the following benefits over
alternative approaches:
- 35x speedup on ARM vs system call through glibc
- 20x speedup on x86 compared to calling glibc, which calls vdso
executing a "lsl" instruction,
- 14x speedup on x86 compared to inlined "lsl" instruction,
- Unlike vdso approaches, this cpu_id value can be read from an inline
assembly, which makes it a useful building block for restartable
sequences.
- The approach of reading the cpu id through memory mapping shared
between kernel and user-space is portable (e.g. ARM), which is not the
case for the lsl-based x86 vdso.
On x86, yet another possible approach would be to use the gs segment
selector to point to user-space per-cpu data. This approach performs
similarly to the cpu id cache, but it has two disadvantages: it is
not portable, and it is incompatible with existing applications already
using the gs segment selector for other purposes.
Benchmarking various approaches for reading the current CPU number:
ARMv7 Processor rev 4 (v7l)
Machine model: Cubietruck
- Baseline (empty loop): 8.4 ns
- Read CPU from rseq cpu_id: 16.7 ns
- Read CPU from rseq cpu_id (lazy register): 19.8 ns
- glibc 2.19-0ubuntu6.6 getcpu: 301.8 ns
- getcpu system call: 234.9 ns
x86-64 Intel(R) Xeon(R) CPU E5-2630 v3 @ 2.40GHz:
- Baseline (empty loop): 0.8 ns
- Read CPU from rseq cpu_id: 0.8 ns
- Read CPU from rseq cpu_id (lazy register): 0.8 ns
- Read using gs segment selector: 0.8 ns
- "lsl" inline assembly: 13.0 ns
- glibc 2.19-0ubuntu6 getcpu: 16.6 ns
- getcpu system call: 53.9 ns
- Speed (benchmark taken on v8 of patchset)
Running 10 runs of hackbench -l 100000 seems to indicate, contrary to
expectations, that enabling CONFIG_RSEQ slightly accelerates the
scheduler:
Configuration: 2 sockets * 8-core Intel(R) Xeon(R) CPU E5-2630 v3 @
2.40GHz (directly on hardware, hyperthreading disabled in BIOS, energy
saving disabled in BIOS, turboboost disabled in BIOS, cpuidle.off=1
kernel parameter), with a Linux v4.6 defconfig+localyesconfig,
restartable sequences series applied.
* CONFIG_RSEQ=n
avg.: 41.37 s
std.dev.: 0.36 s
* CONFIG_RSEQ=y
avg.: 40.46 s
std.dev.: 0.33 s
- Size
On x86-64, between CONFIG_RSEQ=n/y, the text size increase of vmlinux is
567 bytes, and the data size increase of vmlinux is 5696 bytes.
[1] https://lwn.net/Articles/650333/
[2] http://www.linuxplumbersconf.org/2013/ocw/system/presentations/1695/original/LPC%20-%20PerCpu%20Atomics.pdf
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Joel Fernandes <joelaf@google.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Dave Watson <davejwatson@fb.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: "H . Peter Anvin" <hpa@zytor.com>
Cc: Chris Lameter <cl@linux.com>
Cc: Russell King <linux@arm.linux.org.uk>
Cc: Andrew Hunter <ahh@google.com>
Cc: Michael Kerrisk <mtk.manpages@gmail.com>
Cc: "Paul E . McKenney" <paulmck@linux.vnet.ibm.com>
Cc: Paul Turner <pjt@google.com>
Cc: Boqun Feng <boqun.feng@gmail.com>
Cc: Josh Triplett <josh@joshtriplett.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Ben Maurer <bmaurer@fb.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: linux-api@vger.kernel.org
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: http://lkml.kernel.org/r/20151027235635.16059.11630.stgit@pjt-glaptop.roam.corp.google.com
Link: http://lkml.kernel.org/r/20150624222609.6116.86035.stgit@kitami.mtv.corp.google.com
Link: https://lkml.kernel.org/r/20180602124408.8430-3-mathieu.desnoyers@efficios.com
2018-06-02 15:43:54 +03:00
|
|
|
|
|
|
|
if (unlikely(t->flags & PF_EXITING))
|
|
|
|
return;
|
|
|
|
if (unlikely(!access_ok(VERIFY_WRITE, t->rseq, sizeof(*t->rseq))))
|
|
|
|
goto error;
|
|
|
|
ret = rseq_ip_fixup(regs);
|
|
|
|
if (unlikely(ret < 0))
|
|
|
|
goto error;
|
|
|
|
if (unlikely(rseq_update_cpu_id(t)))
|
|
|
|
goto error;
|
|
|
|
return;
|
|
|
|
|
|
|
|
error:
|
2018-06-22 13:45:07 +03:00
|
|
|
sig = ksig ? ksig->sig : 0;
|
|
|
|
force_sigsegv(sig, t);
|
rseq: Introduce restartable sequences system call
Expose a new system call allowing each thread to register one userspace
memory area to be used as an ABI between kernel and user-space for two
purposes: user-space restartable sequences and quick access to read the
current CPU number value from user-space.
* Restartable sequences (per-cpu atomics)
Restartables sequences allow user-space to perform update operations on
per-cpu data without requiring heavy-weight atomic operations.
The restartable critical sections (percpu atomics) work has been started
by Paul Turner and Andrew Hunter. It lets the kernel handle restart of
critical sections. [1] [2] The re-implementation proposed here brings a
few simplifications to the ABI which facilitates porting to other
architectures and speeds up the user-space fast path.
Here are benchmarks of various rseq use-cases.
Test hardware:
arm32: ARMv7 Processor rev 4 (v7l) "Cubietruck", 2-core
x86-64: Intel E5-2630 v3@2.40GHz, 16-core, hyperthreading
The following benchmarks were all performed on a single thread.
* Per-CPU statistic counter increment
getcpu+atomic (ns/op) rseq (ns/op) speedup
arm32: 344.0 31.4 11.0
x86-64: 15.3 2.0 7.7
* LTTng-UST: write event 32-bit header, 32-bit payload into tracer
per-cpu buffer
getcpu+atomic (ns/op) rseq (ns/op) speedup
arm32: 2502.0 2250.0 1.1
x86-64: 117.4 98.0 1.2
* liburcu percpu: lock-unlock pair, dereference, read/compare word
getcpu+atomic (ns/op) rseq (ns/op) speedup
arm32: 751.0 128.5 5.8
x86-64: 53.4 28.6 1.9
* jemalloc memory allocator adapted to use rseq
Using rseq with per-cpu memory pools in jemalloc at Facebook (based on
rseq 2016 implementation):
The production workload response-time has 1-2% gain avg. latency, and
the P99 overall latency drops by 2-3%.
* Reading the current CPU number
Speeding up reading the current CPU number on which the caller thread is
running is done by keeping the current CPU number up do date within the
cpu_id field of the memory area registered by the thread. This is done
by making scheduler preemption set the TIF_NOTIFY_RESUME flag on the
current thread. Upon return to user-space, a notify-resume handler
updates the current CPU value within the registered user-space memory
area. User-space can then read the current CPU number directly from
memory.
Keeping the current cpu id in a memory area shared between kernel and
user-space is an improvement over current mechanisms available to read
the current CPU number, which has the following benefits over
alternative approaches:
- 35x speedup on ARM vs system call through glibc
- 20x speedup on x86 compared to calling glibc, which calls vdso
executing a "lsl" instruction,
- 14x speedup on x86 compared to inlined "lsl" instruction,
- Unlike vdso approaches, this cpu_id value can be read from an inline
assembly, which makes it a useful building block for restartable
sequences.
- The approach of reading the cpu id through memory mapping shared
between kernel and user-space is portable (e.g. ARM), which is not the
case for the lsl-based x86 vdso.
On x86, yet another possible approach would be to use the gs segment
selector to point to user-space per-cpu data. This approach performs
similarly to the cpu id cache, but it has two disadvantages: it is
not portable, and it is incompatible with existing applications already
using the gs segment selector for other purposes.
Benchmarking various approaches for reading the current CPU number:
ARMv7 Processor rev 4 (v7l)
Machine model: Cubietruck
- Baseline (empty loop): 8.4 ns
- Read CPU from rseq cpu_id: 16.7 ns
- Read CPU from rseq cpu_id (lazy register): 19.8 ns
- glibc 2.19-0ubuntu6.6 getcpu: 301.8 ns
- getcpu system call: 234.9 ns
x86-64 Intel(R) Xeon(R) CPU E5-2630 v3 @ 2.40GHz:
- Baseline (empty loop): 0.8 ns
- Read CPU from rseq cpu_id: 0.8 ns
- Read CPU from rseq cpu_id (lazy register): 0.8 ns
- Read using gs segment selector: 0.8 ns
- "lsl" inline assembly: 13.0 ns
- glibc 2.19-0ubuntu6 getcpu: 16.6 ns
- getcpu system call: 53.9 ns
- Speed (benchmark taken on v8 of patchset)
Running 10 runs of hackbench -l 100000 seems to indicate, contrary to
expectations, that enabling CONFIG_RSEQ slightly accelerates the
scheduler:
Configuration: 2 sockets * 8-core Intel(R) Xeon(R) CPU E5-2630 v3 @
2.40GHz (directly on hardware, hyperthreading disabled in BIOS, energy
saving disabled in BIOS, turboboost disabled in BIOS, cpuidle.off=1
kernel parameter), with a Linux v4.6 defconfig+localyesconfig,
restartable sequences series applied.
* CONFIG_RSEQ=n
avg.: 41.37 s
std.dev.: 0.36 s
* CONFIG_RSEQ=y
avg.: 40.46 s
std.dev.: 0.33 s
- Size
On x86-64, between CONFIG_RSEQ=n/y, the text size increase of vmlinux is
567 bytes, and the data size increase of vmlinux is 5696 bytes.
[1] https://lwn.net/Articles/650333/
[2] http://www.linuxplumbersconf.org/2013/ocw/system/presentations/1695/original/LPC%20-%20PerCpu%20Atomics.pdf
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Joel Fernandes <joelaf@google.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Dave Watson <davejwatson@fb.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: "H . Peter Anvin" <hpa@zytor.com>
Cc: Chris Lameter <cl@linux.com>
Cc: Russell King <linux@arm.linux.org.uk>
Cc: Andrew Hunter <ahh@google.com>
Cc: Michael Kerrisk <mtk.manpages@gmail.com>
Cc: "Paul E . McKenney" <paulmck@linux.vnet.ibm.com>
Cc: Paul Turner <pjt@google.com>
Cc: Boqun Feng <boqun.feng@gmail.com>
Cc: Josh Triplett <josh@joshtriplett.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Ben Maurer <bmaurer@fb.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: linux-api@vger.kernel.org
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: http://lkml.kernel.org/r/20151027235635.16059.11630.stgit@pjt-glaptop.roam.corp.google.com
Link: http://lkml.kernel.org/r/20150624222609.6116.86035.stgit@kitami.mtv.corp.google.com
Link: https://lkml.kernel.org/r/20180602124408.8430-3-mathieu.desnoyers@efficios.com
2018-06-02 15:43:54 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
#ifdef CONFIG_DEBUG_RSEQ
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Terminate the process if a syscall is issued within a restartable
|
|
|
|
* sequence.
|
|
|
|
*/
|
|
|
|
void rseq_syscall(struct pt_regs *regs)
|
|
|
|
{
|
|
|
|
unsigned long ip = instruction_pointer(regs);
|
|
|
|
struct task_struct *t = current;
|
|
|
|
struct rseq_cs rseq_cs;
|
|
|
|
|
|
|
|
if (!t->rseq)
|
|
|
|
return;
|
|
|
|
if (!access_ok(VERIFY_READ, t->rseq, sizeof(*t->rseq)) ||
|
|
|
|
rseq_get_rseq_cs(t, &rseq_cs) || in_rseq_cs(ip, &rseq_cs))
|
|
|
|
force_sig(SIGSEGV, t);
|
|
|
|
}
|
|
|
|
|
|
|
|
#endif
|
|
|
|
|
|
|
|
/*
|
|
|
|
* sys_rseq - setup restartable sequences for caller thread.
|
|
|
|
*/
|
|
|
|
SYSCALL_DEFINE4(rseq, struct rseq __user *, rseq, u32, rseq_len,
|
|
|
|
int, flags, u32, sig)
|
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
if (flags & RSEQ_FLAG_UNREGISTER) {
|
|
|
|
/* Unregister rseq for current thread. */
|
|
|
|
if (current->rseq != rseq || !current->rseq)
|
|
|
|
return -EINVAL;
|
|
|
|
if (current->rseq_len != rseq_len)
|
|
|
|
return -EINVAL;
|
|
|
|
if (current->rseq_sig != sig)
|
|
|
|
return -EPERM;
|
|
|
|
ret = rseq_reset_rseq_cpu_id(current);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
current->rseq = NULL;
|
|
|
|
current->rseq_len = 0;
|
|
|
|
current->rseq_sig = 0;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (unlikely(flags))
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
if (current->rseq) {
|
|
|
|
/*
|
|
|
|
* If rseq is already registered, check whether
|
|
|
|
* the provided address differs from the prior
|
|
|
|
* one.
|
|
|
|
*/
|
|
|
|
if (current->rseq != rseq || current->rseq_len != rseq_len)
|
|
|
|
return -EINVAL;
|
|
|
|
if (current->rseq_sig != sig)
|
|
|
|
return -EPERM;
|
|
|
|
/* Already registered. */
|
|
|
|
return -EBUSY;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If there was no rseq previously registered,
|
|
|
|
* ensure the provided rseq is properly aligned and valid.
|
|
|
|
*/
|
|
|
|
if (!IS_ALIGNED((unsigned long)rseq, __alignof__(*rseq)) ||
|
|
|
|
rseq_len != sizeof(*rseq))
|
|
|
|
return -EINVAL;
|
|
|
|
if (!access_ok(VERIFY_WRITE, rseq, rseq_len))
|
|
|
|
return -EFAULT;
|
|
|
|
current->rseq = rseq;
|
|
|
|
current->rseq_len = rseq_len;
|
|
|
|
current->rseq_sig = sig;
|
|
|
|
/*
|
|
|
|
* If rseq was previously inactive, and has just been
|
|
|
|
* registered, ensure the cpu_id_start and cpu_id fields
|
|
|
|
* are updated before returning to user-space.
|
|
|
|
*/
|
|
|
|
rseq_set_notify_resume(current);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|