2019-05-19 15:08:20 +03:00
|
|
|
// SPDX-License-Identifier: GPL-2.0-only
|
2009-03-11 12:51:26 +03:00
|
|
|
/*
|
|
|
|
* Monitoring code for network dropped packet alerts
|
|
|
|
*
|
|
|
|
* Copyright (C) 2009 Neil Horman <nhorman@tuxdriver.com>
|
|
|
|
*/
|
|
|
|
|
2012-05-16 23:58:40 +04:00
|
|
|
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
|
|
|
|
|
2009-03-11 12:51:26 +03:00
|
|
|
#include <linux/netdevice.h>
|
|
|
|
#include <linux/etherdevice.h>
|
|
|
|
#include <linux/string.h>
|
|
|
|
#include <linux/if_arp.h>
|
|
|
|
#include <linux/inetdevice.h>
|
|
|
|
#include <linux/inet.h>
|
|
|
|
#include <linux/interrupt.h>
|
|
|
|
#include <linux/netpoll.h>
|
|
|
|
#include <linux/sched.h>
|
|
|
|
#include <linux/delay.h>
|
|
|
|
#include <linux/types.h>
|
|
|
|
#include <linux/workqueue.h>
|
|
|
|
#include <linux/netlink.h>
|
|
|
|
#include <linux/net_dropmon.h>
|
|
|
|
#include <linux/percpu.h>
|
|
|
|
#include <linux/timer.h>
|
|
|
|
#include <linux/bitops.h>
|
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files. percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.
percpu.h -> slab.h dependency is about to be removed. Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability. As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.
http://userweb.kernel.org/~tj/misc/slabh-sweep.py
The script does the followings.
* Scan files for gfp and slab usages and update includes such that
only the necessary includes are there. ie. if only gfp is used,
gfp.h, if slab is used, slab.h.
* When the script inserts a new include, it looks at the include
blocks and try to put the new include such that its order conforms
to its surrounding. It's put in the include block which contains
core kernel includes, in the same order that the rest are ordered -
alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
doesn't seem to be any matching order.
* If the script can't find a place to put a new include (mostly
because the file doesn't have fitting include block), it prints out
an error message indicating which .h file needs to be added to the
file.
The conversion was done in the following steps.
1. The initial automatic conversion of all .c files updated slightly
over 4000 files, deleting around 700 includes and adding ~480 gfp.h
and ~3000 slab.h inclusions. The script emitted errors for ~400
files.
2. Each error was manually checked. Some didn't need the inclusion,
some needed manual addition while adding it to implementation .h or
embedding .c file was more appropriate for others. This step added
inclusions to around 150 files.
3. The script was run again and the output was compared to the edits
from #2 to make sure no file was left behind.
4. Several build tests were done and a couple of problems were fixed.
e.g. lib/decompress_*.c used malloc/free() wrappers around slab
APIs requiring slab.h to be added manually.
5. The script was run on all .h files but without automatically
editing them as sprinkling gfp.h and slab.h inclusions around .h
files could easily lead to inclusion dependency hell. Most gfp.h
inclusion directives were ignored as stuff from gfp.h was usually
wildly available and often used in preprocessor macros. Each
slab.h inclusion directive was examined and added manually as
necessary.
6. percpu.h was updated not to include slab.h.
7. Build test were done on the following configurations and failures
were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
distributed build env didn't work with gcov compiles) and a few
more options had to be turned off depending on archs to make things
build (like ipr on powerpc/64 which failed due to missing writeq).
* x86 and x86_64 UP and SMP allmodconfig and a custom test config.
* powerpc and powerpc64 SMP allmodconfig
* sparc and sparc64 SMP allmodconfig
* ia64 SMP allmodconfig
* s390 SMP allmodconfig
* alpha SMP allmodconfig
* um on x86_64 SMP allmodconfig
8. percpu.h modifications were reverted so that it could be applied as
a separate patch and serve as bisection point.
Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.
Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
2010-03-24 11:04:11 +03:00
|
|
|
#include <linux/slab.h>
|
2012-05-17 14:04:00 +04:00
|
|
|
#include <linux/module.h>
|
2009-03-11 12:51:26 +03:00
|
|
|
#include <net/genetlink.h>
|
2009-05-21 11:36:08 +04:00
|
|
|
#include <net/netevent.h>
|
2020-02-25 13:45:20 +03:00
|
|
|
#include <net/flow_offload.h>
|
2020-09-29 11:15:51 +03:00
|
|
|
#include <net/devlink.h>
|
2009-03-11 12:51:26 +03:00
|
|
|
|
2009-04-15 03:39:12 +04:00
|
|
|
#include <trace/events/skb.h>
|
2009-06-15 14:02:23 +04:00
|
|
|
#include <trace/events/napi.h>
|
2020-09-29 11:15:52 +03:00
|
|
|
#include <trace/events/devlink.h>
|
2009-03-11 12:51:26 +03:00
|
|
|
|
|
|
|
#include <asm/unaligned.h>
|
|
|
|
|
|
|
|
#define TRACE_ON 1
|
|
|
|
#define TRACE_OFF 0
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Globals, our netlink socket pointer
|
|
|
|
* and the work handle that will send up
|
|
|
|
* netlink alerts
|
|
|
|
*/
|
2009-05-21 11:36:08 +04:00
|
|
|
static int trace_state = TRACE_OFF;
|
2019-08-17 16:28:12 +03:00
|
|
|
static bool monitor_hw;
|
2019-08-06 16:19:52 +03:00
|
|
|
|
|
|
|
/* net_dm_mutex
|
|
|
|
*
|
|
|
|
* An overall lock guarding every operation coming from userspace.
|
|
|
|
* It also guards the global 'hw_stats_list' list.
|
|
|
|
*/
|
|
|
|
static DEFINE_MUTEX(net_dm_mutex);
|
2009-03-11 12:51:26 +03:00
|
|
|
|
2019-08-11 10:35:55 +03:00
|
|
|
struct net_dm_stats {
|
|
|
|
u64 dropped;
|
|
|
|
struct u64_stats_sync syncp;
|
|
|
|
};
|
|
|
|
|
2019-08-17 16:28:15 +03:00
|
|
|
#define NET_DM_MAX_HW_TRAP_NAME_LEN 40
|
|
|
|
|
|
|
|
struct net_dm_hw_entry {
|
|
|
|
char trap_name[NET_DM_MAX_HW_TRAP_NAME_LEN];
|
|
|
|
u32 count;
|
|
|
|
};
|
|
|
|
|
|
|
|
struct net_dm_hw_entries {
|
|
|
|
u32 num_entries;
|
2020-02-28 16:43:24 +03:00
|
|
|
struct net_dm_hw_entry entries[];
|
2019-08-17 16:28:15 +03:00
|
|
|
};
|
|
|
|
|
2009-03-11 12:51:26 +03:00
|
|
|
struct per_cpu_dm_data {
|
drop_monitor: replace spin_lock by raw_spin_lock
[ Upstream commit f1e197a665c2148ebc25fe09c53689e60afea195 ]
trace_drop_common() is called with preemption disabled, and it acquires
a spin_lock. This is problematic for RT kernels because spin_locks are
sleeping locks in this configuration, which causes the following splat:
BUG: sleeping function called from invalid context at kernel/locking/spinlock_rt.c:48
in_atomic(): 1, irqs_disabled(): 1, non_block: 0, pid: 449, name: rcuc/47
preempt_count: 1, expected: 0
RCU nest depth: 2, expected: 2
5 locks held by rcuc/47/449:
#0: ff1100086ec30a60 ((softirq_ctrl.lock)){+.+.}-{2:2}, at: __local_bh_disable_ip+0x105/0x210
#1: ffffffffb394a280 (rcu_read_lock){....}-{1:2}, at: rt_spin_lock+0xbf/0x130
#2: ffffffffb394a280 (rcu_read_lock){....}-{1:2}, at: __local_bh_disable_ip+0x11c/0x210
#3: ffffffffb394a160 (rcu_callback){....}-{0:0}, at: rcu_do_batch+0x360/0xc70
#4: ff1100086ee07520 (&data->lock){+.+.}-{2:2}, at: trace_drop_common.constprop.0+0xb5/0x290
irq event stamp: 139909
hardirqs last enabled at (139908): [<ffffffffb1df2b33>] _raw_spin_unlock_irqrestore+0x63/0x80
hardirqs last disabled at (139909): [<ffffffffb19bd03d>] trace_drop_common.constprop.0+0x26d/0x290
softirqs last enabled at (139892): [<ffffffffb07a1083>] __local_bh_enable_ip+0x103/0x170
softirqs last disabled at (139898): [<ffffffffb0909b33>] rcu_cpu_kthread+0x93/0x1f0
Preemption disabled at:
[<ffffffffb1de786b>] rt_mutex_slowunlock+0xab/0x2e0
CPU: 47 PID: 449 Comm: rcuc/47 Not tainted 6.9.0-rc2-rt1+ #7
Hardware name: Dell Inc. PowerEdge R650/0Y2G81, BIOS 1.6.5 04/15/2022
Call Trace:
<TASK>
dump_stack_lvl+0x8c/0xd0
dump_stack+0x14/0x20
__might_resched+0x21e/0x2f0
rt_spin_lock+0x5e/0x130
? trace_drop_common.constprop.0+0xb5/0x290
? skb_queue_purge_reason.part.0+0x1bf/0x230
trace_drop_common.constprop.0+0xb5/0x290
? preempt_count_sub+0x1c/0xd0
? _raw_spin_unlock_irqrestore+0x4a/0x80
? __pfx_trace_drop_common.constprop.0+0x10/0x10
? rt_mutex_slowunlock+0x26a/0x2e0
? skb_queue_purge_reason.part.0+0x1bf/0x230
? __pfx_rt_mutex_slowunlock+0x10/0x10
? skb_queue_purge_reason.part.0+0x1bf/0x230
trace_kfree_skb_hit+0x15/0x20
trace_kfree_skb+0xe9/0x150
kfree_skb_reason+0x7b/0x110
skb_queue_purge_reason.part.0+0x1bf/0x230
? __pfx_skb_queue_purge_reason.part.0+0x10/0x10
? mark_lock.part.0+0x8a/0x520
...
trace_drop_common() also disables interrupts, but this is a minor issue
because we could easily replace it with a local_lock.
Replace the spin_lock with raw_spin_lock to avoid sleeping in atomic
context.
Signed-off-by: Wander Lairson Costa <wander@redhat.com>
Reported-by: Hu Chunyu <chuhu@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-04-11 17:13:46 +03:00
|
|
|
raw_spinlock_t lock; /* Protects 'skb', 'hw_entries' and
|
2019-08-17 16:28:15 +03:00
|
|
|
* 'send_timer'
|
|
|
|
*/
|
|
|
|
union {
|
|
|
|
struct sk_buff *skb;
|
|
|
|
struct net_dm_hw_entries *hw_entries;
|
|
|
|
};
|
2019-08-11 10:35:51 +03:00
|
|
|
struct sk_buff_head drop_queue;
|
2012-06-04 04:18:19 +04:00
|
|
|
struct work_struct dm_alert_work;
|
|
|
|
struct timer_list send_timer;
|
2019-08-11 10:35:55 +03:00
|
|
|
struct net_dm_stats stats;
|
2009-03-11 12:51:26 +03:00
|
|
|
};
|
|
|
|
|
2009-05-21 11:36:08 +04:00
|
|
|
struct dm_hw_stat_delta {
|
|
|
|
struct net_device *dev;
|
2009-09-03 01:37:45 +04:00
|
|
|
unsigned long last_rx;
|
2009-05-21 11:36:08 +04:00
|
|
|
struct list_head list;
|
|
|
|
struct rcu_head rcu;
|
|
|
|
unsigned long last_drop_val;
|
|
|
|
};
|
|
|
|
|
2016-10-24 15:40:03 +03:00
|
|
|
static struct genl_family net_drop_monitor_family;
|
2009-03-11 12:51:26 +03:00
|
|
|
|
|
|
|
static DEFINE_PER_CPU(struct per_cpu_dm_data, dm_cpu_data);
|
2019-08-17 16:28:11 +03:00
|
|
|
static DEFINE_PER_CPU(struct per_cpu_dm_data, dm_hw_cpu_data);
|
2009-03-11 12:51:26 +03:00
|
|
|
|
|
|
|
static int dm_hit_limit = 64;
|
|
|
|
static int dm_delay = 1;
|
2009-05-21 11:36:08 +04:00
|
|
|
static unsigned long dm_hw_check_delta = 2*HZ;
|
|
|
|
static LIST_HEAD(hw_stats_list);
|
2009-03-11 12:51:26 +03:00
|
|
|
|
2019-08-11 10:35:50 +03:00
|
|
|
static enum net_dm_alert_mode net_dm_alert_mode = NET_DM_ALERT_MODE_SUMMARY;
|
2019-08-11 10:35:52 +03:00
|
|
|
static u32 net_dm_trunc_len;
|
2019-08-11 10:35:54 +03:00
|
|
|
static u32 net_dm_queue_len = 1000;
|
2019-08-11 10:35:50 +03:00
|
|
|
|
|
|
|
struct net_dm_alert_ops {
|
|
|
|
void (*kfree_skb_probe)(void *ignore, struct sk_buff *skb,
|
2022-01-09 09:36:26 +03:00
|
|
|
void *location,
|
|
|
|
enum skb_drop_reason reason);
|
2019-08-11 10:35:50 +03:00
|
|
|
void (*napi_poll_probe)(void *ignore, struct napi_struct *napi,
|
|
|
|
int work, int budget);
|
|
|
|
void (*work_item_func)(struct work_struct *work);
|
2019-08-17 16:28:14 +03:00
|
|
|
void (*hw_work_item_func)(struct work_struct *work);
|
2020-09-29 11:15:51 +03:00
|
|
|
void (*hw_trap_probe)(void *ignore, const struct devlink *devlink,
|
|
|
|
struct sk_buff *skb,
|
|
|
|
const struct devlink_trap_metadata *metadata);
|
2019-08-11 10:35:50 +03:00
|
|
|
};
|
|
|
|
|
2019-08-11 10:35:51 +03:00
|
|
|
struct net_dm_skb_cb {
|
2019-08-17 16:28:14 +03:00
|
|
|
union {
|
2020-09-29 11:15:54 +03:00
|
|
|
struct devlink_trap_metadata *hw_metadata;
|
2019-08-17 16:28:14 +03:00
|
|
|
void *pc;
|
|
|
|
};
|
2019-08-11 10:35:51 +03:00
|
|
|
};
|
|
|
|
|
|
|
|
#define NET_DM_SKB_CB(__skb) ((struct net_dm_skb_cb *)&((__skb)->cb[0]))
|
|
|
|
|
2012-06-04 04:18:19 +04:00
|
|
|
static struct sk_buff *reset_per_cpu_data(struct per_cpu_dm_data *data)
|
2009-03-11 12:51:26 +03:00
|
|
|
{
|
|
|
|
size_t al;
|
|
|
|
struct net_dm_alert_msg *msg;
|
2009-04-27 14:17:31 +04:00
|
|
|
struct nlattr *nla;
|
2012-04-27 14:11:49 +04:00
|
|
|
struct sk_buff *skb;
|
2012-06-04 04:18:19 +04:00
|
|
|
unsigned long flags;
|
2016-12-31 23:11:57 +03:00
|
|
|
void *msg_header;
|
2009-03-11 12:51:26 +03:00
|
|
|
|
|
|
|
al = sizeof(struct net_dm_alert_msg);
|
|
|
|
al += dm_hit_limit * sizeof(struct net_dm_drop_point);
|
2009-04-27 14:17:31 +04:00
|
|
|
al += sizeof(struct nlattr);
|
|
|
|
|
2012-04-27 14:11:49 +04:00
|
|
|
skb = genlmsg_new(al, GFP_KERNEL);
|
|
|
|
|
2016-12-31 23:11:57 +03:00
|
|
|
if (!skb)
|
|
|
|
goto err;
|
2012-04-27 14:11:49 +04:00
|
|
|
|
2016-12-31 23:11:57 +03:00
|
|
|
msg_header = genlmsg_put(skb, 0, 0, &net_drop_monitor_family,
|
|
|
|
0, NET_DM_CMD_ALERT);
|
|
|
|
if (!msg_header) {
|
|
|
|
nlmsg_free(skb);
|
|
|
|
skb = NULL;
|
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
nla = nla_reserve(skb, NLA_UNSPEC,
|
|
|
|
sizeof(struct net_dm_alert_msg));
|
|
|
|
if (!nla) {
|
|
|
|
nlmsg_free(skb);
|
|
|
|
skb = NULL;
|
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
msg = nla_data(nla);
|
|
|
|
memset(msg, 0, al);
|
|
|
|
goto out;
|
|
|
|
|
|
|
|
err:
|
|
|
|
mod_timer(&data->send_timer, jiffies + HZ / 10);
|
|
|
|
out:
|
drop_monitor: replace spin_lock by raw_spin_lock
[ Upstream commit f1e197a665c2148ebc25fe09c53689e60afea195 ]
trace_drop_common() is called with preemption disabled, and it acquires
a spin_lock. This is problematic for RT kernels because spin_locks are
sleeping locks in this configuration, which causes the following splat:
BUG: sleeping function called from invalid context at kernel/locking/spinlock_rt.c:48
in_atomic(): 1, irqs_disabled(): 1, non_block: 0, pid: 449, name: rcuc/47
preempt_count: 1, expected: 0
RCU nest depth: 2, expected: 2
5 locks held by rcuc/47/449:
#0: ff1100086ec30a60 ((softirq_ctrl.lock)){+.+.}-{2:2}, at: __local_bh_disable_ip+0x105/0x210
#1: ffffffffb394a280 (rcu_read_lock){....}-{1:2}, at: rt_spin_lock+0xbf/0x130
#2: ffffffffb394a280 (rcu_read_lock){....}-{1:2}, at: __local_bh_disable_ip+0x11c/0x210
#3: ffffffffb394a160 (rcu_callback){....}-{0:0}, at: rcu_do_batch+0x360/0xc70
#4: ff1100086ee07520 (&data->lock){+.+.}-{2:2}, at: trace_drop_common.constprop.0+0xb5/0x290
irq event stamp: 139909
hardirqs last enabled at (139908): [<ffffffffb1df2b33>] _raw_spin_unlock_irqrestore+0x63/0x80
hardirqs last disabled at (139909): [<ffffffffb19bd03d>] trace_drop_common.constprop.0+0x26d/0x290
softirqs last enabled at (139892): [<ffffffffb07a1083>] __local_bh_enable_ip+0x103/0x170
softirqs last disabled at (139898): [<ffffffffb0909b33>] rcu_cpu_kthread+0x93/0x1f0
Preemption disabled at:
[<ffffffffb1de786b>] rt_mutex_slowunlock+0xab/0x2e0
CPU: 47 PID: 449 Comm: rcuc/47 Not tainted 6.9.0-rc2-rt1+ #7
Hardware name: Dell Inc. PowerEdge R650/0Y2G81, BIOS 1.6.5 04/15/2022
Call Trace:
<TASK>
dump_stack_lvl+0x8c/0xd0
dump_stack+0x14/0x20
__might_resched+0x21e/0x2f0
rt_spin_lock+0x5e/0x130
? trace_drop_common.constprop.0+0xb5/0x290
? skb_queue_purge_reason.part.0+0x1bf/0x230
trace_drop_common.constprop.0+0xb5/0x290
? preempt_count_sub+0x1c/0xd0
? _raw_spin_unlock_irqrestore+0x4a/0x80
? __pfx_trace_drop_common.constprop.0+0x10/0x10
? rt_mutex_slowunlock+0x26a/0x2e0
? skb_queue_purge_reason.part.0+0x1bf/0x230
? __pfx_rt_mutex_slowunlock+0x10/0x10
? skb_queue_purge_reason.part.0+0x1bf/0x230
trace_kfree_skb_hit+0x15/0x20
trace_kfree_skb+0xe9/0x150
kfree_skb_reason+0x7b/0x110
skb_queue_purge_reason.part.0+0x1bf/0x230
? __pfx_skb_queue_purge_reason.part.0+0x10/0x10
? mark_lock.part.0+0x8a/0x520
...
trace_drop_common() also disables interrupts, but this is a minor issue
because we could easily replace it with a local_lock.
Replace the spin_lock with raw_spin_lock to avoid sleeping in atomic
context.
Signed-off-by: Wander Lairson Costa <wander@redhat.com>
Reported-by: Hu Chunyu <chuhu@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-04-11 17:13:46 +03:00
|
|
|
raw_spin_lock_irqsave(&data->lock, flags);
|
2012-06-04 04:18:19 +04:00
|
|
|
swap(data->skb, skb);
|
drop_monitor: replace spin_lock by raw_spin_lock
[ Upstream commit f1e197a665c2148ebc25fe09c53689e60afea195 ]
trace_drop_common() is called with preemption disabled, and it acquires
a spin_lock. This is problematic for RT kernels because spin_locks are
sleeping locks in this configuration, which causes the following splat:
BUG: sleeping function called from invalid context at kernel/locking/spinlock_rt.c:48
in_atomic(): 1, irqs_disabled(): 1, non_block: 0, pid: 449, name: rcuc/47
preempt_count: 1, expected: 0
RCU nest depth: 2, expected: 2
5 locks held by rcuc/47/449:
#0: ff1100086ec30a60 ((softirq_ctrl.lock)){+.+.}-{2:2}, at: __local_bh_disable_ip+0x105/0x210
#1: ffffffffb394a280 (rcu_read_lock){....}-{1:2}, at: rt_spin_lock+0xbf/0x130
#2: ffffffffb394a280 (rcu_read_lock){....}-{1:2}, at: __local_bh_disable_ip+0x11c/0x210
#3: ffffffffb394a160 (rcu_callback){....}-{0:0}, at: rcu_do_batch+0x360/0xc70
#4: ff1100086ee07520 (&data->lock){+.+.}-{2:2}, at: trace_drop_common.constprop.0+0xb5/0x290
irq event stamp: 139909
hardirqs last enabled at (139908): [<ffffffffb1df2b33>] _raw_spin_unlock_irqrestore+0x63/0x80
hardirqs last disabled at (139909): [<ffffffffb19bd03d>] trace_drop_common.constprop.0+0x26d/0x290
softirqs last enabled at (139892): [<ffffffffb07a1083>] __local_bh_enable_ip+0x103/0x170
softirqs last disabled at (139898): [<ffffffffb0909b33>] rcu_cpu_kthread+0x93/0x1f0
Preemption disabled at:
[<ffffffffb1de786b>] rt_mutex_slowunlock+0xab/0x2e0
CPU: 47 PID: 449 Comm: rcuc/47 Not tainted 6.9.0-rc2-rt1+ #7
Hardware name: Dell Inc. PowerEdge R650/0Y2G81, BIOS 1.6.5 04/15/2022
Call Trace:
<TASK>
dump_stack_lvl+0x8c/0xd0
dump_stack+0x14/0x20
__might_resched+0x21e/0x2f0
rt_spin_lock+0x5e/0x130
? trace_drop_common.constprop.0+0xb5/0x290
? skb_queue_purge_reason.part.0+0x1bf/0x230
trace_drop_common.constprop.0+0xb5/0x290
? preempt_count_sub+0x1c/0xd0
? _raw_spin_unlock_irqrestore+0x4a/0x80
? __pfx_trace_drop_common.constprop.0+0x10/0x10
? rt_mutex_slowunlock+0x26a/0x2e0
? skb_queue_purge_reason.part.0+0x1bf/0x230
? __pfx_rt_mutex_slowunlock+0x10/0x10
? skb_queue_purge_reason.part.0+0x1bf/0x230
trace_kfree_skb_hit+0x15/0x20
trace_kfree_skb+0xe9/0x150
kfree_skb_reason+0x7b/0x110
skb_queue_purge_reason.part.0+0x1bf/0x230
? __pfx_skb_queue_purge_reason.part.0+0x10/0x10
? mark_lock.part.0+0x8a/0x520
...
trace_drop_common() also disables interrupts, but this is a minor issue
because we could easily replace it with a local_lock.
Replace the spin_lock with raw_spin_lock to avoid sleeping in atomic
context.
Signed-off-by: Wander Lairson Costa <wander@redhat.com>
Reported-by: Hu Chunyu <chuhu@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-04-11 17:13:46 +03:00
|
|
|
raw_spin_unlock_irqrestore(&data->lock, flags);
|
2012-06-04 04:18:19 +04:00
|
|
|
|
2017-01-03 03:39:10 +03:00
|
|
|
if (skb) {
|
|
|
|
struct nlmsghdr *nlh = (struct nlmsghdr *)skb->data;
|
|
|
|
struct genlmsghdr *gnlh = (struct genlmsghdr *)nlmsg_data(nlh);
|
|
|
|
|
|
|
|
genlmsg_end(skb, genlmsg_data(gnlh));
|
|
|
|
}
|
|
|
|
|
2012-06-04 04:18:19 +04:00
|
|
|
return skb;
|
2009-03-11 12:51:26 +03:00
|
|
|
}
|
|
|
|
|
2016-09-01 01:15:23 +03:00
|
|
|
static const struct genl_multicast_group dropmon_mcgrps[] = {
|
drop_monitor: Require 'CAP_SYS_ADMIN' when joining "events" group
[ Upstream commit e03781879a0d524ce3126678d50a80484a513c4b ]
The "NET_DM" generic netlink family notifies drop locations over the
"events" multicast group. This is problematic since by default generic
netlink allows non-root users to listen to these notifications.
Fix by adding a new field to the generic netlink multicast group
structure that when set prevents non-root users or root without the
'CAP_SYS_ADMIN' capability (in the user namespace owning the network
namespace) from joining the group. Set this field for the "events"
group. Use 'CAP_SYS_ADMIN' rather than 'CAP_NET_ADMIN' because of the
nature of the information that is shared over this group.
Note that the capability check in this case will always be performed
against the initial user namespace since the family is not netns aware
and only operates in the initial network namespace.
A new field is added to the structure rather than using the "flags"
field because the existing field uses uAPI flags and it is inappropriate
to add a new uAPI flag for an internal kernel check. In net-next we can
rework the "flags" field to use internal flags and fold the new field
into it. But for now, in order to reduce the amount of changes, add a
new field.
Since the information can only be consumed by root, mark the control
plane operations that start and stop the tracing as root-only using the
'GENL_ADMIN_PERM' flag.
Tested using [1].
Before:
# capsh -- -c ./dm_repo
# capsh --drop=cap_sys_admin -- -c ./dm_repo
After:
# capsh -- -c ./dm_repo
# capsh --drop=cap_sys_admin -- -c ./dm_repo
Failed to join "events" multicast group
[1]
$ cat dm.c
#include <stdio.h>
#include <netlink/genl/ctrl.h>
#include <netlink/genl/genl.h>
#include <netlink/socket.h>
int main(int argc, char **argv)
{
struct nl_sock *sk;
int grp, err;
sk = nl_socket_alloc();
if (!sk) {
fprintf(stderr, "Failed to allocate socket\n");
return -1;
}
err = genl_connect(sk);
if (err) {
fprintf(stderr, "Failed to connect socket\n");
return err;
}
grp = genl_ctrl_resolve_grp(sk, "NET_DM", "events");
if (grp < 0) {
fprintf(stderr,
"Failed to resolve \"events\" multicast group\n");
return grp;
}
err = nl_socket_add_memberships(sk, grp, NFNLGRP_NONE);
if (err) {
fprintf(stderr, "Failed to join \"events\" multicast group\n");
return err;
}
return 0;
}
$ gcc -I/usr/include/libnl3 -lnl-3 -lnl-genl-3 -o dm_repo dm.c
Fixes: 9a8afc8d3962 ("Network Drop Monitor: Adding drop monitor implementation & Netlink protocol")
Reported-by: "The UK's National Cyber Security Centre (NCSC)" <security@ncsc.gov.uk>
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Link: https://lore.kernel.org/r/20231206213102.1824398-3-idosch@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2023-12-07 00:31:02 +03:00
|
|
|
{ .name = "events", .cap_sys_admin = 1 },
|
2013-11-19 18:19:32 +04:00
|
|
|
};
|
|
|
|
|
2012-06-04 04:18:19 +04:00
|
|
|
static void send_dm_alert(struct work_struct *work)
|
2009-03-11 12:51:26 +03:00
|
|
|
{
|
|
|
|
struct sk_buff *skb;
|
2012-06-04 04:18:19 +04:00
|
|
|
struct per_cpu_dm_data *data;
|
2009-03-11 12:51:26 +03:00
|
|
|
|
2012-06-04 04:18:19 +04:00
|
|
|
data = container_of(work, struct per_cpu_dm_data, dm_alert_work);
|
drop_monitor: prevent init path from scheduling on the wrong cpu
I just noticed after some recent updates, that the init path for the drop
monitor protocol has a minor error. drop monitor maintains a per cpu structure,
that gets initalized from a single cpu. Normally this is fine, as the protocol
isn't in use yet, but I recently made a change that causes a failed skb
allocation to reschedule itself . Given the current code, the implication is
that this workqueue reschedule will take place on the wrong cpu. If drop
monitor is used early during the boot process, its possible that two cpus will
access a single per-cpu structure in parallel, possibly leading to data
corruption.
This patch fixes the situation, by storing the cpu number that a given instance
of this per-cpu data should be accessed from. In the case of a need for a
reschedule, the cpu stored in the struct is assigned the rescheule, rather than
the currently executing cpu
Tested successfully by myself.
Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
CC: David Miller <davem@davemloft.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
2012-05-01 12:18:02 +04:00
|
|
|
|
2012-06-04 04:18:19 +04:00
|
|
|
skb = reset_per_cpu_data(data);
|
2009-03-11 12:51:26 +03:00
|
|
|
|
2012-04-27 14:11:49 +04:00
|
|
|
if (skb)
|
2013-11-19 18:19:38 +04:00
|
|
|
genlmsg_multicast(&net_drop_monitor_family, skb, 0,
|
2013-11-19 18:19:39 +04:00
|
|
|
0, GFP_KERNEL);
|
2009-03-11 12:51:26 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* This is the timer function to delay the sending of an alert
|
|
|
|
* in the event that more drops will arrive during the
|
2012-06-04 04:18:19 +04:00
|
|
|
* hysteresis period.
|
2009-03-11 12:51:26 +03:00
|
|
|
*/
|
treewide: setup_timer() -> timer_setup()
This converts all remaining cases of the old setup_timer() API into using
timer_setup(), where the callback argument is the structure already
holding the struct timer_list. These should have no behavioral changes,
since they just change which pointer is passed into the callback with
the same available pointers after conversion. It handles the following
examples, in addition to some other variations.
Casting from unsigned long:
void my_callback(unsigned long data)
{
struct something *ptr = (struct something *)data;
...
}
...
setup_timer(&ptr->my_timer, my_callback, ptr);
and forced object casts:
void my_callback(struct something *ptr)
{
...
}
...
setup_timer(&ptr->my_timer, my_callback, (unsigned long)ptr);
become:
void my_callback(struct timer_list *t)
{
struct something *ptr = from_timer(ptr, t, my_timer);
...
}
...
timer_setup(&ptr->my_timer, my_callback, 0);
Direct function assignments:
void my_callback(unsigned long data)
{
struct something *ptr = (struct something *)data;
...
}
...
ptr->my_timer.function = my_callback;
have a temporary cast added, along with converting the args:
void my_callback(struct timer_list *t)
{
struct something *ptr = from_timer(ptr, t, my_timer);
...
}
...
ptr->my_timer.function = (TIMER_FUNC_TYPE)my_callback;
And finally, callbacks without a data assignment:
void my_callback(unsigned long data)
{
...
}
...
setup_timer(&ptr->my_timer, my_callback, 0);
have their argument renamed to verify they're unused during conversion:
void my_callback(struct timer_list *unused)
{
...
}
...
timer_setup(&ptr->my_timer, my_callback, 0);
The conversion is done with the following Coccinelle script:
spatch --very-quiet --all-includes --include-headers \
-I ./arch/x86/include -I ./arch/x86/include/generated \
-I ./include -I ./arch/x86/include/uapi \
-I ./arch/x86/include/generated/uapi -I ./include/uapi \
-I ./include/generated/uapi --include ./include/linux/kconfig.h \
--dir . \
--cocci-file ~/src/data/timer_setup.cocci
@fix_address_of@
expression e;
@@
setup_timer(
-&(e)
+&e
, ...)
// Update any raw setup_timer() usages that have a NULL callback, but
// would otherwise match change_timer_function_usage, since the latter
// will update all function assignments done in the face of a NULL
// function initialization in setup_timer().
@change_timer_function_usage_NULL@
expression _E;
identifier _timer;
type _cast_data;
@@
(
-setup_timer(&_E->_timer, NULL, _E);
+timer_setup(&_E->_timer, NULL, 0);
|
-setup_timer(&_E->_timer, NULL, (_cast_data)_E);
+timer_setup(&_E->_timer, NULL, 0);
|
-setup_timer(&_E._timer, NULL, &_E);
+timer_setup(&_E._timer, NULL, 0);
|
-setup_timer(&_E._timer, NULL, (_cast_data)&_E);
+timer_setup(&_E._timer, NULL, 0);
)
@change_timer_function_usage@
expression _E;
identifier _timer;
struct timer_list _stl;
identifier _callback;
type _cast_func, _cast_data;
@@
(
-setup_timer(&_E->_timer, _callback, _E);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E->_timer, &_callback, _E);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E->_timer, _callback, (_cast_data)_E);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E->_timer, &_callback, (_cast_data)_E);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E->_timer, (_cast_func)_callback, _E);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E->_timer, (_cast_func)&_callback, _E);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E->_timer, (_cast_func)_callback, (_cast_data)_E);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E->_timer, (_cast_func)&_callback, (_cast_data)_E);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E._timer, _callback, (_cast_data)_E);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_E._timer, _callback, (_cast_data)&_E);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_E._timer, &_callback, (_cast_data)_E);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_E._timer, &_callback, (_cast_data)&_E);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_E._timer, (_cast_func)_callback, (_cast_data)_E);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_E._timer, (_cast_func)_callback, (_cast_data)&_E);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_E._timer, (_cast_func)&_callback, (_cast_data)_E);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_E._timer, (_cast_func)&_callback, (_cast_data)&_E);
+timer_setup(&_E._timer, _callback, 0);
|
_E->_timer@_stl.function = _callback;
|
_E->_timer@_stl.function = &_callback;
|
_E->_timer@_stl.function = (_cast_func)_callback;
|
_E->_timer@_stl.function = (_cast_func)&_callback;
|
_E._timer@_stl.function = _callback;
|
_E._timer@_stl.function = &_callback;
|
_E._timer@_stl.function = (_cast_func)_callback;
|
_E._timer@_stl.function = (_cast_func)&_callback;
)
// callback(unsigned long arg)
@change_callback_handle_cast
depends on change_timer_function_usage@
identifier change_timer_function_usage._callback;
identifier change_timer_function_usage._timer;
type _origtype;
identifier _origarg;
type _handletype;
identifier _handle;
@@
void _callback(
-_origtype _origarg
+struct timer_list *t
)
{
(
... when != _origarg
_handletype *_handle =
-(_handletype *)_origarg;
+from_timer(_handle, t, _timer);
... when != _origarg
|
... when != _origarg
_handletype *_handle =
-(void *)_origarg;
+from_timer(_handle, t, _timer);
... when != _origarg
|
... when != _origarg
_handletype *_handle;
... when != _handle
_handle =
-(_handletype *)_origarg;
+from_timer(_handle, t, _timer);
... when != _origarg
|
... when != _origarg
_handletype *_handle;
... when != _handle
_handle =
-(void *)_origarg;
+from_timer(_handle, t, _timer);
... when != _origarg
)
}
// callback(unsigned long arg) without existing variable
@change_callback_handle_cast_no_arg
depends on change_timer_function_usage &&
!change_callback_handle_cast@
identifier change_timer_function_usage._callback;
identifier change_timer_function_usage._timer;
type _origtype;
identifier _origarg;
type _handletype;
@@
void _callback(
-_origtype _origarg
+struct timer_list *t
)
{
+ _handletype *_origarg = from_timer(_origarg, t, _timer);
+
... when != _origarg
- (_handletype *)_origarg
+ _origarg
... when != _origarg
}
// Avoid already converted callbacks.
@match_callback_converted
depends on change_timer_function_usage &&
!change_callback_handle_cast &&
!change_callback_handle_cast_no_arg@
identifier change_timer_function_usage._callback;
identifier t;
@@
void _callback(struct timer_list *t)
{ ... }
// callback(struct something *handle)
@change_callback_handle_arg
depends on change_timer_function_usage &&
!match_callback_converted &&
!change_callback_handle_cast &&
!change_callback_handle_cast_no_arg@
identifier change_timer_function_usage._callback;
identifier change_timer_function_usage._timer;
type _handletype;
identifier _handle;
@@
void _callback(
-_handletype *_handle
+struct timer_list *t
)
{
+ _handletype *_handle = from_timer(_handle, t, _timer);
...
}
// If change_callback_handle_arg ran on an empty function, remove
// the added handler.
@unchange_callback_handle_arg
depends on change_timer_function_usage &&
change_callback_handle_arg@
identifier change_timer_function_usage._callback;
identifier change_timer_function_usage._timer;
type _handletype;
identifier _handle;
identifier t;
@@
void _callback(struct timer_list *t)
{
- _handletype *_handle = from_timer(_handle, t, _timer);
}
// We only want to refactor the setup_timer() data argument if we've found
// the matching callback. This undoes changes in change_timer_function_usage.
@unchange_timer_function_usage
depends on change_timer_function_usage &&
!change_callback_handle_cast &&
!change_callback_handle_cast_no_arg &&
!change_callback_handle_arg@
expression change_timer_function_usage._E;
identifier change_timer_function_usage._timer;
identifier change_timer_function_usage._callback;
type change_timer_function_usage._cast_data;
@@
(
-timer_setup(&_E->_timer, _callback, 0);
+setup_timer(&_E->_timer, _callback, (_cast_data)_E);
|
-timer_setup(&_E._timer, _callback, 0);
+setup_timer(&_E._timer, _callback, (_cast_data)&_E);
)
// If we fixed a callback from a .function assignment, fix the
// assignment cast now.
@change_timer_function_assignment
depends on change_timer_function_usage &&
(change_callback_handle_cast ||
change_callback_handle_cast_no_arg ||
change_callback_handle_arg)@
expression change_timer_function_usage._E;
identifier change_timer_function_usage._timer;
identifier change_timer_function_usage._callback;
type _cast_func;
typedef TIMER_FUNC_TYPE;
@@
(
_E->_timer.function =
-_callback
+(TIMER_FUNC_TYPE)_callback
;
|
_E->_timer.function =
-&_callback
+(TIMER_FUNC_TYPE)_callback
;
|
_E->_timer.function =
-(_cast_func)_callback;
+(TIMER_FUNC_TYPE)_callback
;
|
_E->_timer.function =
-(_cast_func)&_callback
+(TIMER_FUNC_TYPE)_callback
;
|
_E._timer.function =
-_callback
+(TIMER_FUNC_TYPE)_callback
;
|
_E._timer.function =
-&_callback;
+(TIMER_FUNC_TYPE)_callback
;
|
_E._timer.function =
-(_cast_func)_callback
+(TIMER_FUNC_TYPE)_callback
;
|
_E._timer.function =
-(_cast_func)&_callback
+(TIMER_FUNC_TYPE)_callback
;
)
// Sometimes timer functions are called directly. Replace matched args.
@change_timer_function_calls
depends on change_timer_function_usage &&
(change_callback_handle_cast ||
change_callback_handle_cast_no_arg ||
change_callback_handle_arg)@
expression _E;
identifier change_timer_function_usage._timer;
identifier change_timer_function_usage._callback;
type _cast_data;
@@
_callback(
(
-(_cast_data)_E
+&_E->_timer
|
-(_cast_data)&_E
+&_E._timer
|
-_E
+&_E->_timer
)
)
// If a timer has been configured without a data argument, it can be
// converted without regard to the callback argument, since it is unused.
@match_timer_function_unused_data@
expression _E;
identifier _timer;
identifier _callback;
@@
(
-setup_timer(&_E->_timer, _callback, 0);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E->_timer, _callback, 0L);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E->_timer, _callback, 0UL);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E._timer, _callback, 0);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_E._timer, _callback, 0L);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_E._timer, _callback, 0UL);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_timer, _callback, 0);
+timer_setup(&_timer, _callback, 0);
|
-setup_timer(&_timer, _callback, 0L);
+timer_setup(&_timer, _callback, 0);
|
-setup_timer(&_timer, _callback, 0UL);
+timer_setup(&_timer, _callback, 0);
|
-setup_timer(_timer, _callback, 0);
+timer_setup(_timer, _callback, 0);
|
-setup_timer(_timer, _callback, 0L);
+timer_setup(_timer, _callback, 0);
|
-setup_timer(_timer, _callback, 0UL);
+timer_setup(_timer, _callback, 0);
)
@change_callback_unused_data
depends on match_timer_function_unused_data@
identifier match_timer_function_unused_data._callback;
type _origtype;
identifier _origarg;
@@
void _callback(
-_origtype _origarg
+struct timer_list *unused
)
{
... when != _origarg
}
Signed-off-by: Kees Cook <keescook@chromium.org>
2017-10-17 00:43:17 +03:00
|
|
|
static void sched_send_work(struct timer_list *t)
|
2009-03-11 12:51:26 +03:00
|
|
|
{
|
treewide: setup_timer() -> timer_setup()
This converts all remaining cases of the old setup_timer() API into using
timer_setup(), where the callback argument is the structure already
holding the struct timer_list. These should have no behavioral changes,
since they just change which pointer is passed into the callback with
the same available pointers after conversion. It handles the following
examples, in addition to some other variations.
Casting from unsigned long:
void my_callback(unsigned long data)
{
struct something *ptr = (struct something *)data;
...
}
...
setup_timer(&ptr->my_timer, my_callback, ptr);
and forced object casts:
void my_callback(struct something *ptr)
{
...
}
...
setup_timer(&ptr->my_timer, my_callback, (unsigned long)ptr);
become:
void my_callback(struct timer_list *t)
{
struct something *ptr = from_timer(ptr, t, my_timer);
...
}
...
timer_setup(&ptr->my_timer, my_callback, 0);
Direct function assignments:
void my_callback(unsigned long data)
{
struct something *ptr = (struct something *)data;
...
}
...
ptr->my_timer.function = my_callback;
have a temporary cast added, along with converting the args:
void my_callback(struct timer_list *t)
{
struct something *ptr = from_timer(ptr, t, my_timer);
...
}
...
ptr->my_timer.function = (TIMER_FUNC_TYPE)my_callback;
And finally, callbacks without a data assignment:
void my_callback(unsigned long data)
{
...
}
...
setup_timer(&ptr->my_timer, my_callback, 0);
have their argument renamed to verify they're unused during conversion:
void my_callback(struct timer_list *unused)
{
...
}
...
timer_setup(&ptr->my_timer, my_callback, 0);
The conversion is done with the following Coccinelle script:
spatch --very-quiet --all-includes --include-headers \
-I ./arch/x86/include -I ./arch/x86/include/generated \
-I ./include -I ./arch/x86/include/uapi \
-I ./arch/x86/include/generated/uapi -I ./include/uapi \
-I ./include/generated/uapi --include ./include/linux/kconfig.h \
--dir . \
--cocci-file ~/src/data/timer_setup.cocci
@fix_address_of@
expression e;
@@
setup_timer(
-&(e)
+&e
, ...)
// Update any raw setup_timer() usages that have a NULL callback, but
// would otherwise match change_timer_function_usage, since the latter
// will update all function assignments done in the face of a NULL
// function initialization in setup_timer().
@change_timer_function_usage_NULL@
expression _E;
identifier _timer;
type _cast_data;
@@
(
-setup_timer(&_E->_timer, NULL, _E);
+timer_setup(&_E->_timer, NULL, 0);
|
-setup_timer(&_E->_timer, NULL, (_cast_data)_E);
+timer_setup(&_E->_timer, NULL, 0);
|
-setup_timer(&_E._timer, NULL, &_E);
+timer_setup(&_E._timer, NULL, 0);
|
-setup_timer(&_E._timer, NULL, (_cast_data)&_E);
+timer_setup(&_E._timer, NULL, 0);
)
@change_timer_function_usage@
expression _E;
identifier _timer;
struct timer_list _stl;
identifier _callback;
type _cast_func, _cast_data;
@@
(
-setup_timer(&_E->_timer, _callback, _E);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E->_timer, &_callback, _E);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E->_timer, _callback, (_cast_data)_E);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E->_timer, &_callback, (_cast_data)_E);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E->_timer, (_cast_func)_callback, _E);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E->_timer, (_cast_func)&_callback, _E);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E->_timer, (_cast_func)_callback, (_cast_data)_E);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E->_timer, (_cast_func)&_callback, (_cast_data)_E);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E._timer, _callback, (_cast_data)_E);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_E._timer, _callback, (_cast_data)&_E);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_E._timer, &_callback, (_cast_data)_E);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_E._timer, &_callback, (_cast_data)&_E);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_E._timer, (_cast_func)_callback, (_cast_data)_E);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_E._timer, (_cast_func)_callback, (_cast_data)&_E);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_E._timer, (_cast_func)&_callback, (_cast_data)_E);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_E._timer, (_cast_func)&_callback, (_cast_data)&_E);
+timer_setup(&_E._timer, _callback, 0);
|
_E->_timer@_stl.function = _callback;
|
_E->_timer@_stl.function = &_callback;
|
_E->_timer@_stl.function = (_cast_func)_callback;
|
_E->_timer@_stl.function = (_cast_func)&_callback;
|
_E._timer@_stl.function = _callback;
|
_E._timer@_stl.function = &_callback;
|
_E._timer@_stl.function = (_cast_func)_callback;
|
_E._timer@_stl.function = (_cast_func)&_callback;
)
// callback(unsigned long arg)
@change_callback_handle_cast
depends on change_timer_function_usage@
identifier change_timer_function_usage._callback;
identifier change_timer_function_usage._timer;
type _origtype;
identifier _origarg;
type _handletype;
identifier _handle;
@@
void _callback(
-_origtype _origarg
+struct timer_list *t
)
{
(
... when != _origarg
_handletype *_handle =
-(_handletype *)_origarg;
+from_timer(_handle, t, _timer);
... when != _origarg
|
... when != _origarg
_handletype *_handle =
-(void *)_origarg;
+from_timer(_handle, t, _timer);
... when != _origarg
|
... when != _origarg
_handletype *_handle;
... when != _handle
_handle =
-(_handletype *)_origarg;
+from_timer(_handle, t, _timer);
... when != _origarg
|
... when != _origarg
_handletype *_handle;
... when != _handle
_handle =
-(void *)_origarg;
+from_timer(_handle, t, _timer);
... when != _origarg
)
}
// callback(unsigned long arg) without existing variable
@change_callback_handle_cast_no_arg
depends on change_timer_function_usage &&
!change_callback_handle_cast@
identifier change_timer_function_usage._callback;
identifier change_timer_function_usage._timer;
type _origtype;
identifier _origarg;
type _handletype;
@@
void _callback(
-_origtype _origarg
+struct timer_list *t
)
{
+ _handletype *_origarg = from_timer(_origarg, t, _timer);
+
... when != _origarg
- (_handletype *)_origarg
+ _origarg
... when != _origarg
}
// Avoid already converted callbacks.
@match_callback_converted
depends on change_timer_function_usage &&
!change_callback_handle_cast &&
!change_callback_handle_cast_no_arg@
identifier change_timer_function_usage._callback;
identifier t;
@@
void _callback(struct timer_list *t)
{ ... }
// callback(struct something *handle)
@change_callback_handle_arg
depends on change_timer_function_usage &&
!match_callback_converted &&
!change_callback_handle_cast &&
!change_callback_handle_cast_no_arg@
identifier change_timer_function_usage._callback;
identifier change_timer_function_usage._timer;
type _handletype;
identifier _handle;
@@
void _callback(
-_handletype *_handle
+struct timer_list *t
)
{
+ _handletype *_handle = from_timer(_handle, t, _timer);
...
}
// If change_callback_handle_arg ran on an empty function, remove
// the added handler.
@unchange_callback_handle_arg
depends on change_timer_function_usage &&
change_callback_handle_arg@
identifier change_timer_function_usage._callback;
identifier change_timer_function_usage._timer;
type _handletype;
identifier _handle;
identifier t;
@@
void _callback(struct timer_list *t)
{
- _handletype *_handle = from_timer(_handle, t, _timer);
}
// We only want to refactor the setup_timer() data argument if we've found
// the matching callback. This undoes changes in change_timer_function_usage.
@unchange_timer_function_usage
depends on change_timer_function_usage &&
!change_callback_handle_cast &&
!change_callback_handle_cast_no_arg &&
!change_callback_handle_arg@
expression change_timer_function_usage._E;
identifier change_timer_function_usage._timer;
identifier change_timer_function_usage._callback;
type change_timer_function_usage._cast_data;
@@
(
-timer_setup(&_E->_timer, _callback, 0);
+setup_timer(&_E->_timer, _callback, (_cast_data)_E);
|
-timer_setup(&_E._timer, _callback, 0);
+setup_timer(&_E._timer, _callback, (_cast_data)&_E);
)
// If we fixed a callback from a .function assignment, fix the
// assignment cast now.
@change_timer_function_assignment
depends on change_timer_function_usage &&
(change_callback_handle_cast ||
change_callback_handle_cast_no_arg ||
change_callback_handle_arg)@
expression change_timer_function_usage._E;
identifier change_timer_function_usage._timer;
identifier change_timer_function_usage._callback;
type _cast_func;
typedef TIMER_FUNC_TYPE;
@@
(
_E->_timer.function =
-_callback
+(TIMER_FUNC_TYPE)_callback
;
|
_E->_timer.function =
-&_callback
+(TIMER_FUNC_TYPE)_callback
;
|
_E->_timer.function =
-(_cast_func)_callback;
+(TIMER_FUNC_TYPE)_callback
;
|
_E->_timer.function =
-(_cast_func)&_callback
+(TIMER_FUNC_TYPE)_callback
;
|
_E._timer.function =
-_callback
+(TIMER_FUNC_TYPE)_callback
;
|
_E._timer.function =
-&_callback;
+(TIMER_FUNC_TYPE)_callback
;
|
_E._timer.function =
-(_cast_func)_callback
+(TIMER_FUNC_TYPE)_callback
;
|
_E._timer.function =
-(_cast_func)&_callback
+(TIMER_FUNC_TYPE)_callback
;
)
// Sometimes timer functions are called directly. Replace matched args.
@change_timer_function_calls
depends on change_timer_function_usage &&
(change_callback_handle_cast ||
change_callback_handle_cast_no_arg ||
change_callback_handle_arg)@
expression _E;
identifier change_timer_function_usage._timer;
identifier change_timer_function_usage._callback;
type _cast_data;
@@
_callback(
(
-(_cast_data)_E
+&_E->_timer
|
-(_cast_data)&_E
+&_E._timer
|
-_E
+&_E->_timer
)
)
// If a timer has been configured without a data argument, it can be
// converted without regard to the callback argument, since it is unused.
@match_timer_function_unused_data@
expression _E;
identifier _timer;
identifier _callback;
@@
(
-setup_timer(&_E->_timer, _callback, 0);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E->_timer, _callback, 0L);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E->_timer, _callback, 0UL);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E._timer, _callback, 0);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_E._timer, _callback, 0L);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_E._timer, _callback, 0UL);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_timer, _callback, 0);
+timer_setup(&_timer, _callback, 0);
|
-setup_timer(&_timer, _callback, 0L);
+timer_setup(&_timer, _callback, 0);
|
-setup_timer(&_timer, _callback, 0UL);
+timer_setup(&_timer, _callback, 0);
|
-setup_timer(_timer, _callback, 0);
+timer_setup(_timer, _callback, 0);
|
-setup_timer(_timer, _callback, 0L);
+timer_setup(_timer, _callback, 0);
|
-setup_timer(_timer, _callback, 0UL);
+timer_setup(_timer, _callback, 0);
)
@change_callback_unused_data
depends on match_timer_function_unused_data@
identifier match_timer_function_unused_data._callback;
type _origtype;
identifier _origarg;
@@
void _callback(
-_origtype _origarg
+struct timer_list *unused
)
{
... when != _origarg
}
Signed-off-by: Kees Cook <keescook@chromium.org>
2017-10-17 00:43:17 +03:00
|
|
|
struct per_cpu_dm_data *data = from_timer(data, t, send_timer);
|
2012-04-27 14:11:49 +04:00
|
|
|
|
2012-06-04 04:18:19 +04:00
|
|
|
schedule_work(&data->dm_alert_work);
|
2009-03-11 12:51:26 +03:00
|
|
|
}
|
|
|
|
|
2009-05-21 11:36:08 +04:00
|
|
|
static void trace_drop_common(struct sk_buff *skb, void *location)
|
2009-03-11 12:51:26 +03:00
|
|
|
{
|
|
|
|
struct net_dm_alert_msg *msg;
|
2020-05-01 00:30:49 +03:00
|
|
|
struct net_dm_drop_point *point;
|
2009-03-11 12:51:26 +03:00
|
|
|
struct nlmsghdr *nlh;
|
2009-04-27 14:17:31 +04:00
|
|
|
struct nlattr *nla;
|
2009-03-11 12:51:26 +03:00
|
|
|
int i;
|
2012-04-27 14:11:49 +04:00
|
|
|
struct sk_buff *dskb;
|
2012-06-04 04:18:19 +04:00
|
|
|
struct per_cpu_dm_data *data;
|
|
|
|
unsigned long flags;
|
2009-03-11 12:51:26 +03:00
|
|
|
|
2012-06-04 04:18:19 +04:00
|
|
|
local_irq_save(flags);
|
2014-08-17 21:30:35 +04:00
|
|
|
data = this_cpu_ptr(&dm_cpu_data);
|
drop_monitor: replace spin_lock by raw_spin_lock
[ Upstream commit f1e197a665c2148ebc25fe09c53689e60afea195 ]
trace_drop_common() is called with preemption disabled, and it acquires
a spin_lock. This is problematic for RT kernels because spin_locks are
sleeping locks in this configuration, which causes the following splat:
BUG: sleeping function called from invalid context at kernel/locking/spinlock_rt.c:48
in_atomic(): 1, irqs_disabled(): 1, non_block: 0, pid: 449, name: rcuc/47
preempt_count: 1, expected: 0
RCU nest depth: 2, expected: 2
5 locks held by rcuc/47/449:
#0: ff1100086ec30a60 ((softirq_ctrl.lock)){+.+.}-{2:2}, at: __local_bh_disable_ip+0x105/0x210
#1: ffffffffb394a280 (rcu_read_lock){....}-{1:2}, at: rt_spin_lock+0xbf/0x130
#2: ffffffffb394a280 (rcu_read_lock){....}-{1:2}, at: __local_bh_disable_ip+0x11c/0x210
#3: ffffffffb394a160 (rcu_callback){....}-{0:0}, at: rcu_do_batch+0x360/0xc70
#4: ff1100086ee07520 (&data->lock){+.+.}-{2:2}, at: trace_drop_common.constprop.0+0xb5/0x290
irq event stamp: 139909
hardirqs last enabled at (139908): [<ffffffffb1df2b33>] _raw_spin_unlock_irqrestore+0x63/0x80
hardirqs last disabled at (139909): [<ffffffffb19bd03d>] trace_drop_common.constprop.0+0x26d/0x290
softirqs last enabled at (139892): [<ffffffffb07a1083>] __local_bh_enable_ip+0x103/0x170
softirqs last disabled at (139898): [<ffffffffb0909b33>] rcu_cpu_kthread+0x93/0x1f0
Preemption disabled at:
[<ffffffffb1de786b>] rt_mutex_slowunlock+0xab/0x2e0
CPU: 47 PID: 449 Comm: rcuc/47 Not tainted 6.9.0-rc2-rt1+ #7
Hardware name: Dell Inc. PowerEdge R650/0Y2G81, BIOS 1.6.5 04/15/2022
Call Trace:
<TASK>
dump_stack_lvl+0x8c/0xd0
dump_stack+0x14/0x20
__might_resched+0x21e/0x2f0
rt_spin_lock+0x5e/0x130
? trace_drop_common.constprop.0+0xb5/0x290
? skb_queue_purge_reason.part.0+0x1bf/0x230
trace_drop_common.constprop.0+0xb5/0x290
? preempt_count_sub+0x1c/0xd0
? _raw_spin_unlock_irqrestore+0x4a/0x80
? __pfx_trace_drop_common.constprop.0+0x10/0x10
? rt_mutex_slowunlock+0x26a/0x2e0
? skb_queue_purge_reason.part.0+0x1bf/0x230
? __pfx_rt_mutex_slowunlock+0x10/0x10
? skb_queue_purge_reason.part.0+0x1bf/0x230
trace_kfree_skb_hit+0x15/0x20
trace_kfree_skb+0xe9/0x150
kfree_skb_reason+0x7b/0x110
skb_queue_purge_reason.part.0+0x1bf/0x230
? __pfx_skb_queue_purge_reason.part.0+0x10/0x10
? mark_lock.part.0+0x8a/0x520
...
trace_drop_common() also disables interrupts, but this is a minor issue
because we could easily replace it with a local_lock.
Replace the spin_lock with raw_spin_lock to avoid sleeping in atomic
context.
Signed-off-by: Wander Lairson Costa <wander@redhat.com>
Reported-by: Hu Chunyu <chuhu@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-04-11 17:13:46 +03:00
|
|
|
raw_spin_lock(&data->lock);
|
2012-06-04 04:18:19 +04:00
|
|
|
dskb = data->skb;
|
2012-04-27 14:11:49 +04:00
|
|
|
|
|
|
|
if (!dskb)
|
|
|
|
goto out;
|
|
|
|
|
|
|
|
nlh = (struct nlmsghdr *)dskb->data;
|
2009-04-27 14:17:31 +04:00
|
|
|
nla = genlmsg_data(nlmsg_data(nlh));
|
|
|
|
msg = nla_data(nla);
|
2020-05-01 00:30:49 +03:00
|
|
|
point = msg->points;
|
2009-03-11 12:51:26 +03:00
|
|
|
for (i = 0; i < msg->entries; i++) {
|
2020-05-01 00:30:49 +03:00
|
|
|
if (!memcmp(&location, &point->pc, sizeof(void *))) {
|
|
|
|
point->count++;
|
2009-03-11 12:51:26 +03:00
|
|
|
goto out;
|
|
|
|
}
|
2020-05-01 00:30:49 +03:00
|
|
|
point++;
|
2009-03-11 12:51:26 +03:00
|
|
|
}
|
2012-06-04 04:18:19 +04:00
|
|
|
if (msg->entries == dm_hit_limit)
|
|
|
|
goto out;
|
2009-03-11 12:51:26 +03:00
|
|
|
/*
|
|
|
|
* We need to create a new entry
|
|
|
|
*/
|
2012-04-27 14:11:49 +04:00
|
|
|
__nla_reserve_nohdr(dskb, sizeof(struct net_dm_drop_point));
|
2009-04-27 14:17:31 +04:00
|
|
|
nla->nla_len += NLA_ALIGN(sizeof(struct net_dm_drop_point));
|
2020-05-01 00:30:49 +03:00
|
|
|
memcpy(point->pc, &location, sizeof(void *));
|
|
|
|
point->count = 1;
|
2009-03-11 12:51:26 +03:00
|
|
|
msg->entries++;
|
|
|
|
|
|
|
|
if (!timer_pending(&data->send_timer)) {
|
|
|
|
data->send_timer.expires = jiffies + dm_delay * HZ;
|
2012-06-04 04:18:19 +04:00
|
|
|
add_timer(&data->send_timer);
|
2009-03-11 12:51:26 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
out:
|
drop_monitor: replace spin_lock by raw_spin_lock
[ Upstream commit f1e197a665c2148ebc25fe09c53689e60afea195 ]
trace_drop_common() is called with preemption disabled, and it acquires
a spin_lock. This is problematic for RT kernels because spin_locks are
sleeping locks in this configuration, which causes the following splat:
BUG: sleeping function called from invalid context at kernel/locking/spinlock_rt.c:48
in_atomic(): 1, irqs_disabled(): 1, non_block: 0, pid: 449, name: rcuc/47
preempt_count: 1, expected: 0
RCU nest depth: 2, expected: 2
5 locks held by rcuc/47/449:
#0: ff1100086ec30a60 ((softirq_ctrl.lock)){+.+.}-{2:2}, at: __local_bh_disable_ip+0x105/0x210
#1: ffffffffb394a280 (rcu_read_lock){....}-{1:2}, at: rt_spin_lock+0xbf/0x130
#2: ffffffffb394a280 (rcu_read_lock){....}-{1:2}, at: __local_bh_disable_ip+0x11c/0x210
#3: ffffffffb394a160 (rcu_callback){....}-{0:0}, at: rcu_do_batch+0x360/0xc70
#4: ff1100086ee07520 (&data->lock){+.+.}-{2:2}, at: trace_drop_common.constprop.0+0xb5/0x290
irq event stamp: 139909
hardirqs last enabled at (139908): [<ffffffffb1df2b33>] _raw_spin_unlock_irqrestore+0x63/0x80
hardirqs last disabled at (139909): [<ffffffffb19bd03d>] trace_drop_common.constprop.0+0x26d/0x290
softirqs last enabled at (139892): [<ffffffffb07a1083>] __local_bh_enable_ip+0x103/0x170
softirqs last disabled at (139898): [<ffffffffb0909b33>] rcu_cpu_kthread+0x93/0x1f0
Preemption disabled at:
[<ffffffffb1de786b>] rt_mutex_slowunlock+0xab/0x2e0
CPU: 47 PID: 449 Comm: rcuc/47 Not tainted 6.9.0-rc2-rt1+ #7
Hardware name: Dell Inc. PowerEdge R650/0Y2G81, BIOS 1.6.5 04/15/2022
Call Trace:
<TASK>
dump_stack_lvl+0x8c/0xd0
dump_stack+0x14/0x20
__might_resched+0x21e/0x2f0
rt_spin_lock+0x5e/0x130
? trace_drop_common.constprop.0+0xb5/0x290
? skb_queue_purge_reason.part.0+0x1bf/0x230
trace_drop_common.constprop.0+0xb5/0x290
? preempt_count_sub+0x1c/0xd0
? _raw_spin_unlock_irqrestore+0x4a/0x80
? __pfx_trace_drop_common.constprop.0+0x10/0x10
? rt_mutex_slowunlock+0x26a/0x2e0
? skb_queue_purge_reason.part.0+0x1bf/0x230
? __pfx_rt_mutex_slowunlock+0x10/0x10
? skb_queue_purge_reason.part.0+0x1bf/0x230
trace_kfree_skb_hit+0x15/0x20
trace_kfree_skb+0xe9/0x150
kfree_skb_reason+0x7b/0x110
skb_queue_purge_reason.part.0+0x1bf/0x230
? __pfx_skb_queue_purge_reason.part.0+0x10/0x10
? mark_lock.part.0+0x8a/0x520
...
trace_drop_common() also disables interrupts, but this is a minor issue
because we could easily replace it with a local_lock.
Replace the spin_lock with raw_spin_lock to avoid sleeping in atomic
context.
Signed-off-by: Wander Lairson Costa <wander@redhat.com>
Reported-by: Hu Chunyu <chuhu@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-04-11 17:13:46 +03:00
|
|
|
raw_spin_unlock_irqrestore(&data->lock, flags);
|
2009-03-11 12:51:26 +03:00
|
|
|
}
|
|
|
|
|
2022-01-09 09:36:26 +03:00
|
|
|
static void trace_kfree_skb_hit(void *ignore, struct sk_buff *skb,
|
|
|
|
void *location,
|
|
|
|
enum skb_drop_reason reason)
|
2009-05-21 11:36:08 +04:00
|
|
|
{
|
|
|
|
trace_drop_common(skb, location);
|
|
|
|
}
|
|
|
|
|
2016-07-07 19:01:32 +03:00
|
|
|
static void trace_napi_poll_hit(void *ignore, struct napi_struct *napi,
|
|
|
|
int work, int budget)
|
2009-05-21 11:36:08 +04:00
|
|
|
{
|
|
|
|
struct dm_hw_stat_delta *new_stat;
|
|
|
|
|
|
|
|
/*
|
2009-09-03 01:37:45 +04:00
|
|
|
* Don't check napi structures with no associated device
|
2009-05-21 11:36:08 +04:00
|
|
|
*/
|
2009-09-03 01:37:45 +04:00
|
|
|
if (!napi->dev)
|
2009-05-21 11:36:08 +04:00
|
|
|
return;
|
|
|
|
|
|
|
|
rcu_read_lock();
|
|
|
|
list_for_each_entry_rcu(new_stat, &hw_stats_list, list) {
|
2022-02-10 20:13:31 +03:00
|
|
|
struct net_device *dev;
|
|
|
|
|
2009-09-03 01:37:45 +04:00
|
|
|
/*
|
|
|
|
* only add a note to our monitor buffer if:
|
|
|
|
* 1) this is the dev we received on
|
|
|
|
* 2) its after the last_rx delta
|
|
|
|
* 3) our rx_dropped count has gone up
|
|
|
|
*/
|
2022-02-10 20:13:31 +03:00
|
|
|
/* Paired with WRITE_ONCE() in dropmon_net_event() */
|
|
|
|
dev = READ_ONCE(new_stat->dev);
|
|
|
|
if ((dev == napi->dev) &&
|
2009-09-03 01:37:45 +04:00
|
|
|
(time_after(jiffies, new_stat->last_rx + dm_hw_check_delta)) &&
|
2009-05-21 11:36:08 +04:00
|
|
|
(napi->dev->stats.rx_dropped != new_stat->last_drop_val)) {
|
|
|
|
trace_drop_common(NULL, NULL);
|
|
|
|
new_stat->last_drop_val = napi->dev->stats.rx_dropped;
|
2009-09-03 01:37:45 +04:00
|
|
|
new_stat->last_rx = jiffies;
|
2009-05-21 11:36:08 +04:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
rcu_read_unlock();
|
|
|
|
}
|
|
|
|
|
2019-08-17 16:28:15 +03:00
|
|
|
static struct net_dm_hw_entries *
|
|
|
|
net_dm_hw_reset_per_cpu_data(struct per_cpu_dm_data *hw_data)
|
|
|
|
{
|
|
|
|
struct net_dm_hw_entries *hw_entries;
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
hw_entries = kzalloc(struct_size(hw_entries, entries, dm_hit_limit),
|
|
|
|
GFP_KERNEL);
|
|
|
|
if (!hw_entries) {
|
|
|
|
/* If the memory allocation failed, we try to perform another
|
|
|
|
* allocation in 1/10 second. Otherwise, the probe function
|
|
|
|
* will constantly bail out.
|
|
|
|
*/
|
|
|
|
mod_timer(&hw_data->send_timer, jiffies + HZ / 10);
|
|
|
|
}
|
|
|
|
|
drop_monitor: replace spin_lock by raw_spin_lock
[ Upstream commit f1e197a665c2148ebc25fe09c53689e60afea195 ]
trace_drop_common() is called with preemption disabled, and it acquires
a spin_lock. This is problematic for RT kernels because spin_locks are
sleeping locks in this configuration, which causes the following splat:
BUG: sleeping function called from invalid context at kernel/locking/spinlock_rt.c:48
in_atomic(): 1, irqs_disabled(): 1, non_block: 0, pid: 449, name: rcuc/47
preempt_count: 1, expected: 0
RCU nest depth: 2, expected: 2
5 locks held by rcuc/47/449:
#0: ff1100086ec30a60 ((softirq_ctrl.lock)){+.+.}-{2:2}, at: __local_bh_disable_ip+0x105/0x210
#1: ffffffffb394a280 (rcu_read_lock){....}-{1:2}, at: rt_spin_lock+0xbf/0x130
#2: ffffffffb394a280 (rcu_read_lock){....}-{1:2}, at: __local_bh_disable_ip+0x11c/0x210
#3: ffffffffb394a160 (rcu_callback){....}-{0:0}, at: rcu_do_batch+0x360/0xc70
#4: ff1100086ee07520 (&data->lock){+.+.}-{2:2}, at: trace_drop_common.constprop.0+0xb5/0x290
irq event stamp: 139909
hardirqs last enabled at (139908): [<ffffffffb1df2b33>] _raw_spin_unlock_irqrestore+0x63/0x80
hardirqs last disabled at (139909): [<ffffffffb19bd03d>] trace_drop_common.constprop.0+0x26d/0x290
softirqs last enabled at (139892): [<ffffffffb07a1083>] __local_bh_enable_ip+0x103/0x170
softirqs last disabled at (139898): [<ffffffffb0909b33>] rcu_cpu_kthread+0x93/0x1f0
Preemption disabled at:
[<ffffffffb1de786b>] rt_mutex_slowunlock+0xab/0x2e0
CPU: 47 PID: 449 Comm: rcuc/47 Not tainted 6.9.0-rc2-rt1+ #7
Hardware name: Dell Inc. PowerEdge R650/0Y2G81, BIOS 1.6.5 04/15/2022
Call Trace:
<TASK>
dump_stack_lvl+0x8c/0xd0
dump_stack+0x14/0x20
__might_resched+0x21e/0x2f0
rt_spin_lock+0x5e/0x130
? trace_drop_common.constprop.0+0xb5/0x290
? skb_queue_purge_reason.part.0+0x1bf/0x230
trace_drop_common.constprop.0+0xb5/0x290
? preempt_count_sub+0x1c/0xd0
? _raw_spin_unlock_irqrestore+0x4a/0x80
? __pfx_trace_drop_common.constprop.0+0x10/0x10
? rt_mutex_slowunlock+0x26a/0x2e0
? skb_queue_purge_reason.part.0+0x1bf/0x230
? __pfx_rt_mutex_slowunlock+0x10/0x10
? skb_queue_purge_reason.part.0+0x1bf/0x230
trace_kfree_skb_hit+0x15/0x20
trace_kfree_skb+0xe9/0x150
kfree_skb_reason+0x7b/0x110
skb_queue_purge_reason.part.0+0x1bf/0x230
? __pfx_skb_queue_purge_reason.part.0+0x10/0x10
? mark_lock.part.0+0x8a/0x520
...
trace_drop_common() also disables interrupts, but this is a minor issue
because we could easily replace it with a local_lock.
Replace the spin_lock with raw_spin_lock to avoid sleeping in atomic
context.
Signed-off-by: Wander Lairson Costa <wander@redhat.com>
Reported-by: Hu Chunyu <chuhu@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-04-11 17:13:46 +03:00
|
|
|
raw_spin_lock_irqsave(&hw_data->lock, flags);
|
2019-08-17 16:28:15 +03:00
|
|
|
swap(hw_data->hw_entries, hw_entries);
|
drop_monitor: replace spin_lock by raw_spin_lock
[ Upstream commit f1e197a665c2148ebc25fe09c53689e60afea195 ]
trace_drop_common() is called with preemption disabled, and it acquires
a spin_lock. This is problematic for RT kernels because spin_locks are
sleeping locks in this configuration, which causes the following splat:
BUG: sleeping function called from invalid context at kernel/locking/spinlock_rt.c:48
in_atomic(): 1, irqs_disabled(): 1, non_block: 0, pid: 449, name: rcuc/47
preempt_count: 1, expected: 0
RCU nest depth: 2, expected: 2
5 locks held by rcuc/47/449:
#0: ff1100086ec30a60 ((softirq_ctrl.lock)){+.+.}-{2:2}, at: __local_bh_disable_ip+0x105/0x210
#1: ffffffffb394a280 (rcu_read_lock){....}-{1:2}, at: rt_spin_lock+0xbf/0x130
#2: ffffffffb394a280 (rcu_read_lock){....}-{1:2}, at: __local_bh_disable_ip+0x11c/0x210
#3: ffffffffb394a160 (rcu_callback){....}-{0:0}, at: rcu_do_batch+0x360/0xc70
#4: ff1100086ee07520 (&data->lock){+.+.}-{2:2}, at: trace_drop_common.constprop.0+0xb5/0x290
irq event stamp: 139909
hardirqs last enabled at (139908): [<ffffffffb1df2b33>] _raw_spin_unlock_irqrestore+0x63/0x80
hardirqs last disabled at (139909): [<ffffffffb19bd03d>] trace_drop_common.constprop.0+0x26d/0x290
softirqs last enabled at (139892): [<ffffffffb07a1083>] __local_bh_enable_ip+0x103/0x170
softirqs last disabled at (139898): [<ffffffffb0909b33>] rcu_cpu_kthread+0x93/0x1f0
Preemption disabled at:
[<ffffffffb1de786b>] rt_mutex_slowunlock+0xab/0x2e0
CPU: 47 PID: 449 Comm: rcuc/47 Not tainted 6.9.0-rc2-rt1+ #7
Hardware name: Dell Inc. PowerEdge R650/0Y2G81, BIOS 1.6.5 04/15/2022
Call Trace:
<TASK>
dump_stack_lvl+0x8c/0xd0
dump_stack+0x14/0x20
__might_resched+0x21e/0x2f0
rt_spin_lock+0x5e/0x130
? trace_drop_common.constprop.0+0xb5/0x290
? skb_queue_purge_reason.part.0+0x1bf/0x230
trace_drop_common.constprop.0+0xb5/0x290
? preempt_count_sub+0x1c/0xd0
? _raw_spin_unlock_irqrestore+0x4a/0x80
? __pfx_trace_drop_common.constprop.0+0x10/0x10
? rt_mutex_slowunlock+0x26a/0x2e0
? skb_queue_purge_reason.part.0+0x1bf/0x230
? __pfx_rt_mutex_slowunlock+0x10/0x10
? skb_queue_purge_reason.part.0+0x1bf/0x230
trace_kfree_skb_hit+0x15/0x20
trace_kfree_skb+0xe9/0x150
kfree_skb_reason+0x7b/0x110
skb_queue_purge_reason.part.0+0x1bf/0x230
? __pfx_skb_queue_purge_reason.part.0+0x10/0x10
? mark_lock.part.0+0x8a/0x520
...
trace_drop_common() also disables interrupts, but this is a minor issue
because we could easily replace it with a local_lock.
Replace the spin_lock with raw_spin_lock to avoid sleeping in atomic
context.
Signed-off-by: Wander Lairson Costa <wander@redhat.com>
Reported-by: Hu Chunyu <chuhu@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-04-11 17:13:46 +03:00
|
|
|
raw_spin_unlock_irqrestore(&hw_data->lock, flags);
|
2019-08-17 16:28:15 +03:00
|
|
|
|
|
|
|
return hw_entries;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int net_dm_hw_entry_put(struct sk_buff *msg,
|
|
|
|
const struct net_dm_hw_entry *hw_entry)
|
|
|
|
{
|
|
|
|
struct nlattr *attr;
|
|
|
|
|
|
|
|
attr = nla_nest_start(msg, NET_DM_ATTR_HW_ENTRY);
|
|
|
|
if (!attr)
|
|
|
|
return -EMSGSIZE;
|
|
|
|
|
|
|
|
if (nla_put_string(msg, NET_DM_ATTR_HW_TRAP_NAME, hw_entry->trap_name))
|
|
|
|
goto nla_put_failure;
|
|
|
|
|
|
|
|
if (nla_put_u32(msg, NET_DM_ATTR_HW_TRAP_COUNT, hw_entry->count))
|
|
|
|
goto nla_put_failure;
|
|
|
|
|
|
|
|
nla_nest_end(msg, attr);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
nla_put_failure:
|
|
|
|
nla_nest_cancel(msg, attr);
|
|
|
|
return -EMSGSIZE;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int net_dm_hw_entries_put(struct sk_buff *msg,
|
|
|
|
const struct net_dm_hw_entries *hw_entries)
|
|
|
|
{
|
|
|
|
struct nlattr *attr;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
attr = nla_nest_start(msg, NET_DM_ATTR_HW_ENTRIES);
|
|
|
|
if (!attr)
|
|
|
|
return -EMSGSIZE;
|
|
|
|
|
|
|
|
for (i = 0; i < hw_entries->num_entries; i++) {
|
|
|
|
int rc;
|
|
|
|
|
|
|
|
rc = net_dm_hw_entry_put(msg, &hw_entries->entries[i]);
|
|
|
|
if (rc)
|
|
|
|
goto nla_put_failure;
|
|
|
|
}
|
|
|
|
|
|
|
|
nla_nest_end(msg, attr);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
nla_put_failure:
|
|
|
|
nla_nest_cancel(msg, attr);
|
|
|
|
return -EMSGSIZE;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
|
|
|
net_dm_hw_summary_report_fill(struct sk_buff *msg,
|
|
|
|
const struct net_dm_hw_entries *hw_entries)
|
|
|
|
{
|
|
|
|
struct net_dm_alert_msg anc_hdr = { 0 };
|
|
|
|
void *hdr;
|
|
|
|
int rc;
|
|
|
|
|
|
|
|
hdr = genlmsg_put(msg, 0, 0, &net_drop_monitor_family, 0,
|
|
|
|
NET_DM_CMD_ALERT);
|
|
|
|
if (!hdr)
|
|
|
|
return -EMSGSIZE;
|
|
|
|
|
|
|
|
/* We need to put the ancillary header in order not to break user
|
|
|
|
* space.
|
|
|
|
*/
|
|
|
|
if (nla_put(msg, NLA_UNSPEC, sizeof(anc_hdr), &anc_hdr))
|
|
|
|
goto nla_put_failure;
|
|
|
|
|
|
|
|
rc = net_dm_hw_entries_put(msg, hw_entries);
|
|
|
|
if (rc)
|
|
|
|
goto nla_put_failure;
|
|
|
|
|
|
|
|
genlmsg_end(msg, hdr);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
nla_put_failure:
|
|
|
|
genlmsg_cancel(msg, hdr);
|
|
|
|
return -EMSGSIZE;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void net_dm_hw_summary_work(struct work_struct *work)
|
|
|
|
{
|
|
|
|
struct net_dm_hw_entries *hw_entries;
|
|
|
|
struct per_cpu_dm_data *hw_data;
|
|
|
|
struct sk_buff *msg;
|
|
|
|
int rc;
|
|
|
|
|
|
|
|
hw_data = container_of(work, struct per_cpu_dm_data, dm_alert_work);
|
|
|
|
|
|
|
|
hw_entries = net_dm_hw_reset_per_cpu_data(hw_data);
|
|
|
|
if (!hw_entries)
|
|
|
|
return;
|
|
|
|
|
|
|
|
msg = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL);
|
|
|
|
if (!msg)
|
|
|
|
goto out;
|
|
|
|
|
|
|
|
rc = net_dm_hw_summary_report_fill(msg, hw_entries);
|
|
|
|
if (rc) {
|
|
|
|
nlmsg_free(msg);
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
|
|
|
genlmsg_multicast(&net_drop_monitor_family, msg, 0, 0, GFP_KERNEL);
|
|
|
|
|
|
|
|
out:
|
|
|
|
kfree(hw_entries);
|
|
|
|
}
|
|
|
|
|
2020-09-29 11:15:51 +03:00
|
|
|
static void
|
|
|
|
net_dm_hw_trap_summary_probe(void *ignore, const struct devlink *devlink,
|
|
|
|
struct sk_buff *skb,
|
|
|
|
const struct devlink_trap_metadata *metadata)
|
|
|
|
{
|
|
|
|
struct net_dm_hw_entries *hw_entries;
|
|
|
|
struct net_dm_hw_entry *hw_entry;
|
|
|
|
struct per_cpu_dm_data *hw_data;
|
|
|
|
unsigned long flags;
|
|
|
|
int i;
|
|
|
|
|
2020-09-29 11:15:55 +03:00
|
|
|
if (metadata->trap_type == DEVLINK_TRAP_TYPE_CONTROL)
|
|
|
|
return;
|
|
|
|
|
2020-09-29 11:15:51 +03:00
|
|
|
hw_data = this_cpu_ptr(&dm_hw_cpu_data);
|
drop_monitor: replace spin_lock by raw_spin_lock
[ Upstream commit f1e197a665c2148ebc25fe09c53689e60afea195 ]
trace_drop_common() is called with preemption disabled, and it acquires
a spin_lock. This is problematic for RT kernels because spin_locks are
sleeping locks in this configuration, which causes the following splat:
BUG: sleeping function called from invalid context at kernel/locking/spinlock_rt.c:48
in_atomic(): 1, irqs_disabled(): 1, non_block: 0, pid: 449, name: rcuc/47
preempt_count: 1, expected: 0
RCU nest depth: 2, expected: 2
5 locks held by rcuc/47/449:
#0: ff1100086ec30a60 ((softirq_ctrl.lock)){+.+.}-{2:2}, at: __local_bh_disable_ip+0x105/0x210
#1: ffffffffb394a280 (rcu_read_lock){....}-{1:2}, at: rt_spin_lock+0xbf/0x130
#2: ffffffffb394a280 (rcu_read_lock){....}-{1:2}, at: __local_bh_disable_ip+0x11c/0x210
#3: ffffffffb394a160 (rcu_callback){....}-{0:0}, at: rcu_do_batch+0x360/0xc70
#4: ff1100086ee07520 (&data->lock){+.+.}-{2:2}, at: trace_drop_common.constprop.0+0xb5/0x290
irq event stamp: 139909
hardirqs last enabled at (139908): [<ffffffffb1df2b33>] _raw_spin_unlock_irqrestore+0x63/0x80
hardirqs last disabled at (139909): [<ffffffffb19bd03d>] trace_drop_common.constprop.0+0x26d/0x290
softirqs last enabled at (139892): [<ffffffffb07a1083>] __local_bh_enable_ip+0x103/0x170
softirqs last disabled at (139898): [<ffffffffb0909b33>] rcu_cpu_kthread+0x93/0x1f0
Preemption disabled at:
[<ffffffffb1de786b>] rt_mutex_slowunlock+0xab/0x2e0
CPU: 47 PID: 449 Comm: rcuc/47 Not tainted 6.9.0-rc2-rt1+ #7
Hardware name: Dell Inc. PowerEdge R650/0Y2G81, BIOS 1.6.5 04/15/2022
Call Trace:
<TASK>
dump_stack_lvl+0x8c/0xd0
dump_stack+0x14/0x20
__might_resched+0x21e/0x2f0
rt_spin_lock+0x5e/0x130
? trace_drop_common.constprop.0+0xb5/0x290
? skb_queue_purge_reason.part.0+0x1bf/0x230
trace_drop_common.constprop.0+0xb5/0x290
? preempt_count_sub+0x1c/0xd0
? _raw_spin_unlock_irqrestore+0x4a/0x80
? __pfx_trace_drop_common.constprop.0+0x10/0x10
? rt_mutex_slowunlock+0x26a/0x2e0
? skb_queue_purge_reason.part.0+0x1bf/0x230
? __pfx_rt_mutex_slowunlock+0x10/0x10
? skb_queue_purge_reason.part.0+0x1bf/0x230
trace_kfree_skb_hit+0x15/0x20
trace_kfree_skb+0xe9/0x150
kfree_skb_reason+0x7b/0x110
skb_queue_purge_reason.part.0+0x1bf/0x230
? __pfx_skb_queue_purge_reason.part.0+0x10/0x10
? mark_lock.part.0+0x8a/0x520
...
trace_drop_common() also disables interrupts, but this is a minor issue
because we could easily replace it with a local_lock.
Replace the spin_lock with raw_spin_lock to avoid sleeping in atomic
context.
Signed-off-by: Wander Lairson Costa <wander@redhat.com>
Reported-by: Hu Chunyu <chuhu@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-04-11 17:13:46 +03:00
|
|
|
raw_spin_lock_irqsave(&hw_data->lock, flags);
|
2020-09-29 11:15:51 +03:00
|
|
|
hw_entries = hw_data->hw_entries;
|
|
|
|
|
|
|
|
if (!hw_entries)
|
|
|
|
goto out;
|
|
|
|
|
|
|
|
for (i = 0; i < hw_entries->num_entries; i++) {
|
|
|
|
hw_entry = &hw_entries->entries[i];
|
|
|
|
if (!strncmp(hw_entry->trap_name, metadata->trap_name,
|
|
|
|
NET_DM_MAX_HW_TRAP_NAME_LEN - 1)) {
|
|
|
|
hw_entry->count++;
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if (WARN_ON_ONCE(hw_entries->num_entries == dm_hit_limit))
|
|
|
|
goto out;
|
|
|
|
|
|
|
|
hw_entry = &hw_entries->entries[hw_entries->num_entries];
|
2022-08-19 00:02:15 +03:00
|
|
|
strscpy(hw_entry->trap_name, metadata->trap_name,
|
2020-09-29 11:15:51 +03:00
|
|
|
NET_DM_MAX_HW_TRAP_NAME_LEN - 1);
|
|
|
|
hw_entry->count = 1;
|
|
|
|
hw_entries->num_entries++;
|
|
|
|
|
|
|
|
if (!timer_pending(&hw_data->send_timer)) {
|
|
|
|
hw_data->send_timer.expires = jiffies + dm_delay * HZ;
|
|
|
|
add_timer(&hw_data->send_timer);
|
|
|
|
}
|
|
|
|
|
|
|
|
out:
|
drop_monitor: replace spin_lock by raw_spin_lock
[ Upstream commit f1e197a665c2148ebc25fe09c53689e60afea195 ]
trace_drop_common() is called with preemption disabled, and it acquires
a spin_lock. This is problematic for RT kernels because spin_locks are
sleeping locks in this configuration, which causes the following splat:
BUG: sleeping function called from invalid context at kernel/locking/spinlock_rt.c:48
in_atomic(): 1, irqs_disabled(): 1, non_block: 0, pid: 449, name: rcuc/47
preempt_count: 1, expected: 0
RCU nest depth: 2, expected: 2
5 locks held by rcuc/47/449:
#0: ff1100086ec30a60 ((softirq_ctrl.lock)){+.+.}-{2:2}, at: __local_bh_disable_ip+0x105/0x210
#1: ffffffffb394a280 (rcu_read_lock){....}-{1:2}, at: rt_spin_lock+0xbf/0x130
#2: ffffffffb394a280 (rcu_read_lock){....}-{1:2}, at: __local_bh_disable_ip+0x11c/0x210
#3: ffffffffb394a160 (rcu_callback){....}-{0:0}, at: rcu_do_batch+0x360/0xc70
#4: ff1100086ee07520 (&data->lock){+.+.}-{2:2}, at: trace_drop_common.constprop.0+0xb5/0x290
irq event stamp: 139909
hardirqs last enabled at (139908): [<ffffffffb1df2b33>] _raw_spin_unlock_irqrestore+0x63/0x80
hardirqs last disabled at (139909): [<ffffffffb19bd03d>] trace_drop_common.constprop.0+0x26d/0x290
softirqs last enabled at (139892): [<ffffffffb07a1083>] __local_bh_enable_ip+0x103/0x170
softirqs last disabled at (139898): [<ffffffffb0909b33>] rcu_cpu_kthread+0x93/0x1f0
Preemption disabled at:
[<ffffffffb1de786b>] rt_mutex_slowunlock+0xab/0x2e0
CPU: 47 PID: 449 Comm: rcuc/47 Not tainted 6.9.0-rc2-rt1+ #7
Hardware name: Dell Inc. PowerEdge R650/0Y2G81, BIOS 1.6.5 04/15/2022
Call Trace:
<TASK>
dump_stack_lvl+0x8c/0xd0
dump_stack+0x14/0x20
__might_resched+0x21e/0x2f0
rt_spin_lock+0x5e/0x130
? trace_drop_common.constprop.0+0xb5/0x290
? skb_queue_purge_reason.part.0+0x1bf/0x230
trace_drop_common.constprop.0+0xb5/0x290
? preempt_count_sub+0x1c/0xd0
? _raw_spin_unlock_irqrestore+0x4a/0x80
? __pfx_trace_drop_common.constprop.0+0x10/0x10
? rt_mutex_slowunlock+0x26a/0x2e0
? skb_queue_purge_reason.part.0+0x1bf/0x230
? __pfx_rt_mutex_slowunlock+0x10/0x10
? skb_queue_purge_reason.part.0+0x1bf/0x230
trace_kfree_skb_hit+0x15/0x20
trace_kfree_skb+0xe9/0x150
kfree_skb_reason+0x7b/0x110
skb_queue_purge_reason.part.0+0x1bf/0x230
? __pfx_skb_queue_purge_reason.part.0+0x10/0x10
? mark_lock.part.0+0x8a/0x520
...
trace_drop_common() also disables interrupts, but this is a minor issue
because we could easily replace it with a local_lock.
Replace the spin_lock with raw_spin_lock to avoid sleeping in atomic
context.
Signed-off-by: Wander Lairson Costa <wander@redhat.com>
Reported-by: Hu Chunyu <chuhu@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-04-11 17:13:46 +03:00
|
|
|
raw_spin_unlock_irqrestore(&hw_data->lock, flags);
|
2020-09-29 11:15:51 +03:00
|
|
|
}
|
|
|
|
|
2019-08-11 10:35:50 +03:00
|
|
|
static const struct net_dm_alert_ops net_dm_alert_summary_ops = {
|
|
|
|
.kfree_skb_probe = trace_kfree_skb_hit,
|
|
|
|
.napi_poll_probe = trace_napi_poll_hit,
|
|
|
|
.work_item_func = send_dm_alert,
|
2019-08-17 16:28:15 +03:00
|
|
|
.hw_work_item_func = net_dm_hw_summary_work,
|
2020-09-29 11:15:51 +03:00
|
|
|
.hw_trap_probe = net_dm_hw_trap_summary_probe,
|
2019-08-11 10:35:50 +03:00
|
|
|
};
|
|
|
|
|
2019-08-11 10:35:51 +03:00
|
|
|
static void net_dm_packet_trace_kfree_skb_hit(void *ignore,
|
|
|
|
struct sk_buff *skb,
|
2022-01-09 09:36:26 +03:00
|
|
|
void *location,
|
|
|
|
enum skb_drop_reason reason)
|
2019-08-11 10:35:51 +03:00
|
|
|
{
|
|
|
|
ktime_t tstamp = ktime_get_real();
|
|
|
|
struct per_cpu_dm_data *data;
|
|
|
|
struct sk_buff *nskb;
|
|
|
|
unsigned long flags;
|
|
|
|
|
2019-09-15 09:46:36 +03:00
|
|
|
if (!skb_mac_header_was_set(skb))
|
|
|
|
return;
|
|
|
|
|
2019-08-11 10:35:51 +03:00
|
|
|
nskb = skb_clone(skb, GFP_ATOMIC);
|
|
|
|
if (!nskb)
|
|
|
|
return;
|
|
|
|
|
|
|
|
NET_DM_SKB_CB(nskb)->pc = location;
|
|
|
|
/* Override the timestamp because we care about the time when the
|
|
|
|
* packet was dropped.
|
|
|
|
*/
|
|
|
|
nskb->tstamp = tstamp;
|
|
|
|
|
|
|
|
data = this_cpu_ptr(&dm_cpu_data);
|
|
|
|
|
|
|
|
spin_lock_irqsave(&data->drop_queue.lock, flags);
|
2019-08-11 10:35:54 +03:00
|
|
|
if (skb_queue_len(&data->drop_queue) < net_dm_queue_len)
|
2019-08-11 10:35:51 +03:00
|
|
|
__skb_queue_tail(&data->drop_queue, nskb);
|
|
|
|
else
|
|
|
|
goto unlock_free;
|
|
|
|
spin_unlock_irqrestore(&data->drop_queue.lock, flags);
|
|
|
|
|
|
|
|
schedule_work(&data->dm_alert_work);
|
|
|
|
|
|
|
|
return;
|
|
|
|
|
|
|
|
unlock_free:
|
|
|
|
spin_unlock_irqrestore(&data->drop_queue.lock, flags);
|
2019-08-11 10:35:55 +03:00
|
|
|
u64_stats_update_begin(&data->stats.syncp);
|
|
|
|
data->stats.dropped++;
|
|
|
|
u64_stats_update_end(&data->stats.syncp);
|
2019-08-11 10:35:51 +03:00
|
|
|
consume_skb(nskb);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void net_dm_packet_trace_napi_poll_hit(void *ignore,
|
|
|
|
struct napi_struct *napi,
|
|
|
|
int work, int budget)
|
|
|
|
{
|
|
|
|
}
|
|
|
|
|
|
|
|
static size_t net_dm_in_port_size(void)
|
|
|
|
{
|
|
|
|
/* NET_DM_ATTR_IN_PORT nest */
|
|
|
|
return nla_total_size(0) +
|
|
|
|
/* NET_DM_ATTR_PORT_NETDEV_IFINDEX */
|
2019-08-17 16:28:14 +03:00
|
|
|
nla_total_size(sizeof(u32)) +
|
|
|
|
/* NET_DM_ATTR_PORT_NETDEV_NAME */
|
|
|
|
nla_total_size(IFNAMSIZ + 1);
|
2019-08-11 10:35:51 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
#define NET_DM_MAX_SYMBOL_LEN 40
|
|
|
|
|
|
|
|
static size_t net_dm_packet_report_size(size_t payload_len)
|
|
|
|
{
|
|
|
|
size_t size;
|
|
|
|
|
|
|
|
size = nlmsg_msg_size(GENL_HDRLEN + net_drop_monitor_family.hdrsize);
|
|
|
|
|
|
|
|
return NLMSG_ALIGN(size) +
|
2019-08-17 16:28:14 +03:00
|
|
|
/* NET_DM_ATTR_ORIGIN */
|
|
|
|
nla_total_size(sizeof(u16)) +
|
2019-08-11 10:35:51 +03:00
|
|
|
/* NET_DM_ATTR_PC */
|
|
|
|
nla_total_size(sizeof(u64)) +
|
|
|
|
/* NET_DM_ATTR_SYMBOL */
|
|
|
|
nla_total_size(NET_DM_MAX_SYMBOL_LEN + 1) +
|
|
|
|
/* NET_DM_ATTR_IN_PORT */
|
|
|
|
net_dm_in_port_size() +
|
|
|
|
/* NET_DM_ATTR_TIMESTAMP */
|
2019-08-23 18:47:21 +03:00
|
|
|
nla_total_size(sizeof(u64)) +
|
2019-08-11 10:35:52 +03:00
|
|
|
/* NET_DM_ATTR_ORIG_LEN */
|
|
|
|
nla_total_size(sizeof(u32)) +
|
2019-08-11 10:35:51 +03:00
|
|
|
/* NET_DM_ATTR_PROTO */
|
|
|
|
nla_total_size(sizeof(u16)) +
|
|
|
|
/* NET_DM_ATTR_PAYLOAD */
|
|
|
|
nla_total_size(payload_len);
|
|
|
|
}
|
|
|
|
|
2019-08-17 16:28:14 +03:00
|
|
|
static int net_dm_packet_report_in_port_put(struct sk_buff *msg, int ifindex,
|
|
|
|
const char *name)
|
2019-08-11 10:35:51 +03:00
|
|
|
{
|
|
|
|
struct nlattr *attr;
|
|
|
|
|
|
|
|
attr = nla_nest_start(msg, NET_DM_ATTR_IN_PORT);
|
|
|
|
if (!attr)
|
|
|
|
return -EMSGSIZE;
|
|
|
|
|
|
|
|
if (ifindex &&
|
|
|
|
nla_put_u32(msg, NET_DM_ATTR_PORT_NETDEV_IFINDEX, ifindex))
|
|
|
|
goto nla_put_failure;
|
|
|
|
|
2019-08-17 16:28:14 +03:00
|
|
|
if (name && nla_put_string(msg, NET_DM_ATTR_PORT_NETDEV_NAME, name))
|
|
|
|
goto nla_put_failure;
|
|
|
|
|
2019-08-11 10:35:51 +03:00
|
|
|
nla_nest_end(msg, attr);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
nla_put_failure:
|
|
|
|
nla_nest_cancel(msg, attr);
|
|
|
|
return -EMSGSIZE;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int net_dm_packet_report_fill(struct sk_buff *msg, struct sk_buff *skb,
|
|
|
|
size_t payload_len)
|
|
|
|
{
|
|
|
|
u64 pc = (u64)(uintptr_t) NET_DM_SKB_CB(skb)->pc;
|
|
|
|
char buf[NET_DM_MAX_SYMBOL_LEN];
|
|
|
|
struct nlattr *attr;
|
|
|
|
void *hdr;
|
|
|
|
int rc;
|
|
|
|
|
|
|
|
hdr = genlmsg_put(msg, 0, 0, &net_drop_monitor_family, 0,
|
|
|
|
NET_DM_CMD_PACKET_ALERT);
|
|
|
|
if (!hdr)
|
|
|
|
return -EMSGSIZE;
|
|
|
|
|
2019-08-17 16:28:14 +03:00
|
|
|
if (nla_put_u16(msg, NET_DM_ATTR_ORIGIN, NET_DM_ORIGIN_SW))
|
|
|
|
goto nla_put_failure;
|
|
|
|
|
2019-08-11 10:35:51 +03:00
|
|
|
if (nla_put_u64_64bit(msg, NET_DM_ATTR_PC, pc, NET_DM_ATTR_PAD))
|
|
|
|
goto nla_put_failure;
|
|
|
|
|
|
|
|
snprintf(buf, sizeof(buf), "%pS", NET_DM_SKB_CB(skb)->pc);
|
|
|
|
if (nla_put_string(msg, NET_DM_ATTR_SYMBOL, buf))
|
|
|
|
goto nla_put_failure;
|
|
|
|
|
2019-08-17 16:28:14 +03:00
|
|
|
rc = net_dm_packet_report_in_port_put(msg, skb->skb_iif, NULL);
|
2019-08-11 10:35:51 +03:00
|
|
|
if (rc)
|
|
|
|
goto nla_put_failure;
|
|
|
|
|
2019-08-23 18:47:21 +03:00
|
|
|
if (nla_put_u64_64bit(msg, NET_DM_ATTR_TIMESTAMP,
|
|
|
|
ktime_to_ns(skb->tstamp), NET_DM_ATTR_PAD))
|
2019-08-11 10:35:51 +03:00
|
|
|
goto nla_put_failure;
|
|
|
|
|
2019-08-11 10:35:52 +03:00
|
|
|
if (nla_put_u32(msg, NET_DM_ATTR_ORIG_LEN, skb->len))
|
|
|
|
goto nla_put_failure;
|
|
|
|
|
2019-08-11 10:35:51 +03:00
|
|
|
if (!payload_len)
|
|
|
|
goto out;
|
|
|
|
|
|
|
|
if (nla_put_u16(msg, NET_DM_ATTR_PROTO, be16_to_cpu(skb->protocol)))
|
|
|
|
goto nla_put_failure;
|
|
|
|
|
|
|
|
attr = skb_put(msg, nla_total_size(payload_len));
|
|
|
|
attr->nla_type = NET_DM_ATTR_PAYLOAD;
|
|
|
|
attr->nla_len = nla_attr_size(payload_len);
|
|
|
|
if (skb_copy_bits(skb, 0, nla_data(attr), payload_len))
|
|
|
|
goto nla_put_failure;
|
|
|
|
|
|
|
|
out:
|
|
|
|
genlmsg_end(msg, hdr);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
nla_put_failure:
|
|
|
|
genlmsg_cancel(msg, hdr);
|
|
|
|
return -EMSGSIZE;
|
|
|
|
}
|
|
|
|
|
|
|
|
#define NET_DM_MAX_PACKET_SIZE (0xffff - NLA_HDRLEN - NLA_ALIGNTO)
|
|
|
|
|
|
|
|
static void net_dm_packet_report(struct sk_buff *skb)
|
|
|
|
{
|
|
|
|
struct sk_buff *msg;
|
|
|
|
size_t payload_len;
|
|
|
|
int rc;
|
|
|
|
|
|
|
|
/* Make sure we start copying the packet from the MAC header */
|
|
|
|
if (skb->data > skb_mac_header(skb))
|
|
|
|
skb_push(skb, skb->data - skb_mac_header(skb));
|
|
|
|
else
|
|
|
|
skb_pull(skb, skb_mac_header(skb) - skb->data);
|
|
|
|
|
|
|
|
/* Ensure packet fits inside a single netlink attribute */
|
|
|
|
payload_len = min_t(size_t, skb->len, NET_DM_MAX_PACKET_SIZE);
|
2019-08-11 10:35:52 +03:00
|
|
|
if (net_dm_trunc_len)
|
|
|
|
payload_len = min_t(size_t, net_dm_trunc_len, payload_len);
|
2019-08-11 10:35:51 +03:00
|
|
|
|
|
|
|
msg = nlmsg_new(net_dm_packet_report_size(payload_len), GFP_KERNEL);
|
|
|
|
if (!msg)
|
|
|
|
goto out;
|
|
|
|
|
|
|
|
rc = net_dm_packet_report_fill(msg, skb, payload_len);
|
|
|
|
if (rc) {
|
|
|
|
nlmsg_free(msg);
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
|
|
|
genlmsg_multicast(&net_drop_monitor_family, msg, 0, 0, GFP_KERNEL);
|
|
|
|
|
|
|
|
out:
|
|
|
|
consume_skb(skb);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void net_dm_packet_work(struct work_struct *work)
|
|
|
|
{
|
|
|
|
struct per_cpu_dm_data *data;
|
|
|
|
struct sk_buff_head list;
|
|
|
|
struct sk_buff *skb;
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
data = container_of(work, struct per_cpu_dm_data, dm_alert_work);
|
|
|
|
|
|
|
|
__skb_queue_head_init(&list);
|
|
|
|
|
|
|
|
spin_lock_irqsave(&data->drop_queue.lock, flags);
|
|
|
|
skb_queue_splice_tail_init(&data->drop_queue, &list);
|
|
|
|
spin_unlock_irqrestore(&data->drop_queue.lock, flags);
|
|
|
|
|
|
|
|
while ((skb = __skb_dequeue(&list)))
|
|
|
|
net_dm_packet_report(skb);
|
|
|
|
}
|
|
|
|
|
2020-02-25 13:45:20 +03:00
|
|
|
static size_t
|
2020-09-29 11:15:54 +03:00
|
|
|
net_dm_flow_action_cookie_size(const struct devlink_trap_metadata *hw_metadata)
|
2020-02-25 13:45:20 +03:00
|
|
|
{
|
|
|
|
return hw_metadata->fa_cookie ?
|
|
|
|
nla_total_size(hw_metadata->fa_cookie->cookie_len) : 0;
|
|
|
|
}
|
|
|
|
|
2019-08-17 16:28:14 +03:00
|
|
|
static size_t
|
|
|
|
net_dm_hw_packet_report_size(size_t payload_len,
|
2020-09-29 11:15:54 +03:00
|
|
|
const struct devlink_trap_metadata *hw_metadata)
|
2019-08-17 16:28:14 +03:00
|
|
|
{
|
|
|
|
size_t size;
|
|
|
|
|
|
|
|
size = nlmsg_msg_size(GENL_HDRLEN + net_drop_monitor_family.hdrsize);
|
|
|
|
|
|
|
|
return NLMSG_ALIGN(size) +
|
|
|
|
/* NET_DM_ATTR_ORIGIN */
|
|
|
|
nla_total_size(sizeof(u16)) +
|
|
|
|
/* NET_DM_ATTR_HW_TRAP_GROUP_NAME */
|
|
|
|
nla_total_size(strlen(hw_metadata->trap_group_name) + 1) +
|
|
|
|
/* NET_DM_ATTR_HW_TRAP_NAME */
|
|
|
|
nla_total_size(strlen(hw_metadata->trap_name) + 1) +
|
|
|
|
/* NET_DM_ATTR_IN_PORT */
|
|
|
|
net_dm_in_port_size() +
|
2020-02-25 13:45:20 +03:00
|
|
|
/* NET_DM_ATTR_FLOW_ACTION_COOKIE */
|
|
|
|
net_dm_flow_action_cookie_size(hw_metadata) +
|
2019-08-17 16:28:14 +03:00
|
|
|
/* NET_DM_ATTR_TIMESTAMP */
|
2019-08-23 18:47:21 +03:00
|
|
|
nla_total_size(sizeof(u64)) +
|
2019-08-17 16:28:14 +03:00
|
|
|
/* NET_DM_ATTR_ORIG_LEN */
|
|
|
|
nla_total_size(sizeof(u32)) +
|
|
|
|
/* NET_DM_ATTR_PROTO */
|
|
|
|
nla_total_size(sizeof(u16)) +
|
|
|
|
/* NET_DM_ATTR_PAYLOAD */
|
|
|
|
nla_total_size(payload_len);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int net_dm_hw_packet_report_fill(struct sk_buff *msg,
|
|
|
|
struct sk_buff *skb, size_t payload_len)
|
|
|
|
{
|
2020-09-29 11:15:54 +03:00
|
|
|
struct devlink_trap_metadata *hw_metadata;
|
2019-08-17 16:28:14 +03:00
|
|
|
struct nlattr *attr;
|
|
|
|
void *hdr;
|
|
|
|
|
|
|
|
hw_metadata = NET_DM_SKB_CB(skb)->hw_metadata;
|
|
|
|
|
|
|
|
hdr = genlmsg_put(msg, 0, 0, &net_drop_monitor_family, 0,
|
|
|
|
NET_DM_CMD_PACKET_ALERT);
|
|
|
|
if (!hdr)
|
|
|
|
return -EMSGSIZE;
|
|
|
|
|
|
|
|
if (nla_put_u16(msg, NET_DM_ATTR_ORIGIN, NET_DM_ORIGIN_HW))
|
|
|
|
goto nla_put_failure;
|
|
|
|
|
|
|
|
if (nla_put_string(msg, NET_DM_ATTR_HW_TRAP_GROUP_NAME,
|
|
|
|
hw_metadata->trap_group_name))
|
|
|
|
goto nla_put_failure;
|
|
|
|
|
|
|
|
if (nla_put_string(msg, NET_DM_ATTR_HW_TRAP_NAME,
|
|
|
|
hw_metadata->trap_name))
|
|
|
|
goto nla_put_failure;
|
|
|
|
|
|
|
|
if (hw_metadata->input_dev) {
|
|
|
|
struct net_device *dev = hw_metadata->input_dev;
|
|
|
|
int rc;
|
|
|
|
|
|
|
|
rc = net_dm_packet_report_in_port_put(msg, dev->ifindex,
|
|
|
|
dev->name);
|
|
|
|
if (rc)
|
|
|
|
goto nla_put_failure;
|
|
|
|
}
|
|
|
|
|
2020-02-25 13:45:20 +03:00
|
|
|
if (hw_metadata->fa_cookie &&
|
|
|
|
nla_put(msg, NET_DM_ATTR_FLOW_ACTION_COOKIE,
|
|
|
|
hw_metadata->fa_cookie->cookie_len,
|
|
|
|
hw_metadata->fa_cookie->cookie))
|
|
|
|
goto nla_put_failure;
|
|
|
|
|
2019-08-23 18:47:21 +03:00
|
|
|
if (nla_put_u64_64bit(msg, NET_DM_ATTR_TIMESTAMP,
|
|
|
|
ktime_to_ns(skb->tstamp), NET_DM_ATTR_PAD))
|
2019-08-17 16:28:14 +03:00
|
|
|
goto nla_put_failure;
|
|
|
|
|
|
|
|
if (nla_put_u32(msg, NET_DM_ATTR_ORIG_LEN, skb->len))
|
|
|
|
goto nla_put_failure;
|
|
|
|
|
|
|
|
if (!payload_len)
|
|
|
|
goto out;
|
|
|
|
|
|
|
|
if (nla_put_u16(msg, NET_DM_ATTR_PROTO, be16_to_cpu(skb->protocol)))
|
|
|
|
goto nla_put_failure;
|
|
|
|
|
|
|
|
attr = skb_put(msg, nla_total_size(payload_len));
|
|
|
|
attr->nla_type = NET_DM_ATTR_PAYLOAD;
|
|
|
|
attr->nla_len = nla_attr_size(payload_len);
|
|
|
|
if (skb_copy_bits(skb, 0, nla_data(attr), payload_len))
|
|
|
|
goto nla_put_failure;
|
|
|
|
|
|
|
|
out:
|
|
|
|
genlmsg_end(msg, hdr);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
nla_put_failure:
|
|
|
|
genlmsg_cancel(msg, hdr);
|
|
|
|
return -EMSGSIZE;
|
|
|
|
}
|
|
|
|
|
2020-09-29 11:15:54 +03:00
|
|
|
static struct devlink_trap_metadata *
|
2020-09-29 11:15:51 +03:00
|
|
|
net_dm_hw_metadata_copy(const struct devlink_trap_metadata *metadata)
|
|
|
|
{
|
|
|
|
const struct flow_action_cookie *fa_cookie;
|
2020-09-29 11:15:54 +03:00
|
|
|
struct devlink_trap_metadata *hw_metadata;
|
2020-09-29 11:15:51 +03:00
|
|
|
const char *trap_group_name;
|
|
|
|
const char *trap_name;
|
|
|
|
|
|
|
|
hw_metadata = kzalloc(sizeof(*hw_metadata), GFP_ATOMIC);
|
|
|
|
if (!hw_metadata)
|
|
|
|
return NULL;
|
|
|
|
|
|
|
|
trap_group_name = kstrdup(metadata->trap_group_name, GFP_ATOMIC);
|
|
|
|
if (!trap_group_name)
|
|
|
|
goto free_hw_metadata;
|
|
|
|
hw_metadata->trap_group_name = trap_group_name;
|
|
|
|
|
|
|
|
trap_name = kstrdup(metadata->trap_name, GFP_ATOMIC);
|
|
|
|
if (!trap_name)
|
|
|
|
goto free_trap_group;
|
|
|
|
hw_metadata->trap_name = trap_name;
|
|
|
|
|
|
|
|
if (metadata->fa_cookie) {
|
|
|
|
size_t cookie_size = sizeof(*fa_cookie) +
|
|
|
|
metadata->fa_cookie->cookie_len;
|
|
|
|
|
|
|
|
fa_cookie = kmemdup(metadata->fa_cookie, cookie_size,
|
|
|
|
GFP_ATOMIC);
|
|
|
|
if (!fa_cookie)
|
|
|
|
goto free_trap_name;
|
|
|
|
hw_metadata->fa_cookie = fa_cookie;
|
|
|
|
}
|
|
|
|
|
|
|
|
hw_metadata->input_dev = metadata->input_dev;
|
2021-08-05 14:55:27 +03:00
|
|
|
dev_hold(hw_metadata->input_dev);
|
2020-09-29 11:15:51 +03:00
|
|
|
|
|
|
|
return hw_metadata;
|
|
|
|
|
|
|
|
free_trap_name:
|
|
|
|
kfree(trap_name);
|
|
|
|
free_trap_group:
|
|
|
|
kfree(trap_group_name);
|
|
|
|
free_hw_metadata:
|
|
|
|
kfree(hw_metadata);
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2019-08-17 16:28:14 +03:00
|
|
|
static void
|
2020-09-29 11:15:54 +03:00
|
|
|
net_dm_hw_metadata_free(const struct devlink_trap_metadata *hw_metadata)
|
2019-08-17 16:28:14 +03:00
|
|
|
{
|
2021-08-05 14:55:27 +03:00
|
|
|
dev_put(hw_metadata->input_dev);
|
2020-02-25 13:45:20 +03:00
|
|
|
kfree(hw_metadata->fa_cookie);
|
2019-08-17 16:28:14 +03:00
|
|
|
kfree(hw_metadata->trap_name);
|
|
|
|
kfree(hw_metadata->trap_group_name);
|
|
|
|
kfree(hw_metadata);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void net_dm_hw_packet_report(struct sk_buff *skb)
|
|
|
|
{
|
2020-09-29 11:15:54 +03:00
|
|
|
struct devlink_trap_metadata *hw_metadata;
|
2019-08-17 16:28:14 +03:00
|
|
|
struct sk_buff *msg;
|
|
|
|
size_t payload_len;
|
|
|
|
int rc;
|
|
|
|
|
|
|
|
if (skb->data > skb_mac_header(skb))
|
|
|
|
skb_push(skb, skb->data - skb_mac_header(skb));
|
|
|
|
else
|
|
|
|
skb_pull(skb, skb_mac_header(skb) - skb->data);
|
|
|
|
|
|
|
|
payload_len = min_t(size_t, skb->len, NET_DM_MAX_PACKET_SIZE);
|
|
|
|
if (net_dm_trunc_len)
|
|
|
|
payload_len = min_t(size_t, net_dm_trunc_len, payload_len);
|
|
|
|
|
|
|
|
hw_metadata = NET_DM_SKB_CB(skb)->hw_metadata;
|
|
|
|
msg = nlmsg_new(net_dm_hw_packet_report_size(payload_len, hw_metadata),
|
|
|
|
GFP_KERNEL);
|
|
|
|
if (!msg)
|
|
|
|
goto out;
|
|
|
|
|
|
|
|
rc = net_dm_hw_packet_report_fill(msg, skb, payload_len);
|
|
|
|
if (rc) {
|
|
|
|
nlmsg_free(msg);
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
|
|
|
genlmsg_multicast(&net_drop_monitor_family, msg, 0, 0, GFP_KERNEL);
|
|
|
|
|
|
|
|
out:
|
|
|
|
net_dm_hw_metadata_free(NET_DM_SKB_CB(skb)->hw_metadata);
|
|
|
|
consume_skb(skb);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void net_dm_hw_packet_work(struct work_struct *work)
|
|
|
|
{
|
|
|
|
struct per_cpu_dm_data *hw_data;
|
|
|
|
struct sk_buff_head list;
|
|
|
|
struct sk_buff *skb;
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
hw_data = container_of(work, struct per_cpu_dm_data, dm_alert_work);
|
|
|
|
|
|
|
|
__skb_queue_head_init(&list);
|
|
|
|
|
|
|
|
spin_lock_irqsave(&hw_data->drop_queue.lock, flags);
|
|
|
|
skb_queue_splice_tail_init(&hw_data->drop_queue, &list);
|
|
|
|
spin_unlock_irqrestore(&hw_data->drop_queue.lock, flags);
|
|
|
|
|
|
|
|
while ((skb = __skb_dequeue(&list)))
|
|
|
|
net_dm_hw_packet_report(skb);
|
|
|
|
}
|
|
|
|
|
2020-09-29 11:15:51 +03:00
|
|
|
static void
|
|
|
|
net_dm_hw_trap_packet_probe(void *ignore, const struct devlink *devlink,
|
|
|
|
struct sk_buff *skb,
|
|
|
|
const struct devlink_trap_metadata *metadata)
|
|
|
|
{
|
2020-09-29 11:15:54 +03:00
|
|
|
struct devlink_trap_metadata *n_hw_metadata;
|
2020-09-29 11:15:51 +03:00
|
|
|
ktime_t tstamp = ktime_get_real();
|
|
|
|
struct per_cpu_dm_data *hw_data;
|
|
|
|
struct sk_buff *nskb;
|
|
|
|
unsigned long flags;
|
|
|
|
|
2020-09-29 11:15:55 +03:00
|
|
|
if (metadata->trap_type == DEVLINK_TRAP_TYPE_CONTROL)
|
|
|
|
return;
|
|
|
|
|
2020-09-29 11:15:51 +03:00
|
|
|
if (!skb_mac_header_was_set(skb))
|
|
|
|
return;
|
|
|
|
|
|
|
|
nskb = skb_clone(skb, GFP_ATOMIC);
|
|
|
|
if (!nskb)
|
|
|
|
return;
|
|
|
|
|
|
|
|
n_hw_metadata = net_dm_hw_metadata_copy(metadata);
|
|
|
|
if (!n_hw_metadata)
|
|
|
|
goto free;
|
|
|
|
|
|
|
|
NET_DM_SKB_CB(nskb)->hw_metadata = n_hw_metadata;
|
|
|
|
nskb->tstamp = tstamp;
|
|
|
|
|
|
|
|
hw_data = this_cpu_ptr(&dm_hw_cpu_data);
|
|
|
|
|
|
|
|
spin_lock_irqsave(&hw_data->drop_queue.lock, flags);
|
|
|
|
if (skb_queue_len(&hw_data->drop_queue) < net_dm_queue_len)
|
|
|
|
__skb_queue_tail(&hw_data->drop_queue, nskb);
|
|
|
|
else
|
|
|
|
goto unlock_free;
|
|
|
|
spin_unlock_irqrestore(&hw_data->drop_queue.lock, flags);
|
|
|
|
|
|
|
|
schedule_work(&hw_data->dm_alert_work);
|
|
|
|
|
|
|
|
return;
|
|
|
|
|
|
|
|
unlock_free:
|
|
|
|
spin_unlock_irqrestore(&hw_data->drop_queue.lock, flags);
|
|
|
|
u64_stats_update_begin(&hw_data->stats.syncp);
|
|
|
|
hw_data->stats.dropped++;
|
|
|
|
u64_stats_update_end(&hw_data->stats.syncp);
|
|
|
|
net_dm_hw_metadata_free(n_hw_metadata);
|
|
|
|
free:
|
|
|
|
consume_skb(nskb);
|
|
|
|
}
|
|
|
|
|
2019-08-11 10:35:51 +03:00
|
|
|
static const struct net_dm_alert_ops net_dm_alert_packet_ops = {
|
|
|
|
.kfree_skb_probe = net_dm_packet_trace_kfree_skb_hit,
|
|
|
|
.napi_poll_probe = net_dm_packet_trace_napi_poll_hit,
|
|
|
|
.work_item_func = net_dm_packet_work,
|
2019-08-17 16:28:14 +03:00
|
|
|
.hw_work_item_func = net_dm_hw_packet_work,
|
2020-09-29 11:15:51 +03:00
|
|
|
.hw_trap_probe = net_dm_hw_trap_packet_probe,
|
2019-08-11 10:35:51 +03:00
|
|
|
};
|
|
|
|
|
2019-08-11 10:35:50 +03:00
|
|
|
static const struct net_dm_alert_ops *net_dm_alert_ops_arr[] = {
|
|
|
|
[NET_DM_ALERT_MODE_SUMMARY] = &net_dm_alert_summary_ops,
|
2019-08-11 10:35:51 +03:00
|
|
|
[NET_DM_ALERT_MODE_PACKET] = &net_dm_alert_packet_ops,
|
2019-08-11 10:35:50 +03:00
|
|
|
};
|
|
|
|
|
2020-09-29 11:15:52 +03:00
|
|
|
#if IS_ENABLED(CONFIG_NET_DEVLINK)
|
|
|
|
static int net_dm_hw_probe_register(const struct net_dm_alert_ops *ops)
|
2019-08-17 16:28:12 +03:00
|
|
|
{
|
2020-09-29 11:15:52 +03:00
|
|
|
return register_trace_devlink_trap_report(ops->hw_trap_probe, NULL);
|
|
|
|
}
|
2019-08-17 16:28:12 +03:00
|
|
|
|
2020-09-29 11:15:52 +03:00
|
|
|
static void net_dm_hw_probe_unregister(const struct net_dm_alert_ops *ops)
|
|
|
|
{
|
|
|
|
unregister_trace_devlink_trap_report(ops->hw_trap_probe, NULL);
|
|
|
|
tracepoint_synchronize_unregister();
|
|
|
|
}
|
|
|
|
#else
|
|
|
|
static int net_dm_hw_probe_register(const struct net_dm_alert_ops *ops)
|
|
|
|
{
|
|
|
|
return -EOPNOTSUPP;
|
|
|
|
}
|
2019-08-17 16:28:16 +03:00
|
|
|
|
2020-09-29 11:15:52 +03:00
|
|
|
static void net_dm_hw_probe_unregister(const struct net_dm_alert_ops *ops)
|
|
|
|
{
|
2019-08-17 16:28:12 +03:00
|
|
|
}
|
2020-09-29 11:15:52 +03:00
|
|
|
#endif
|
2019-08-17 16:28:12 +03:00
|
|
|
|
2019-08-17 16:28:16 +03:00
|
|
|
static int net_dm_hw_monitor_start(struct netlink_ext_ack *extack)
|
|
|
|
{
|
|
|
|
const struct net_dm_alert_ops *ops;
|
2020-09-29 11:15:52 +03:00
|
|
|
int cpu, rc;
|
2019-08-17 16:28:16 +03:00
|
|
|
|
|
|
|
if (monitor_hw) {
|
|
|
|
NL_SET_ERR_MSG_MOD(extack, "Hardware monitoring already enabled");
|
|
|
|
return -EAGAIN;
|
|
|
|
}
|
|
|
|
|
|
|
|
ops = net_dm_alert_ops_arr[net_dm_alert_mode];
|
|
|
|
|
|
|
|
if (!try_module_get(THIS_MODULE)) {
|
|
|
|
NL_SET_ERR_MSG_MOD(extack, "Failed to take reference on module");
|
|
|
|
return -ENODEV;
|
|
|
|
}
|
|
|
|
|
|
|
|
for_each_possible_cpu(cpu) {
|
|
|
|
struct per_cpu_dm_data *hw_data = &per_cpu(dm_hw_cpu_data, cpu);
|
|
|
|
struct net_dm_hw_entries *hw_entries;
|
|
|
|
|
|
|
|
INIT_WORK(&hw_data->dm_alert_work, ops->hw_work_item_func);
|
|
|
|
timer_setup(&hw_data->send_timer, sched_send_work, 0);
|
|
|
|
hw_entries = net_dm_hw_reset_per_cpu_data(hw_data);
|
|
|
|
kfree(hw_entries);
|
|
|
|
}
|
|
|
|
|
2020-09-29 11:15:52 +03:00
|
|
|
rc = net_dm_hw_probe_register(ops);
|
|
|
|
if (rc) {
|
|
|
|
NL_SET_ERR_MSG_MOD(extack, "Failed to connect probe to devlink_trap_probe() tracepoint");
|
|
|
|
goto err_module_put;
|
|
|
|
}
|
|
|
|
|
2019-08-17 16:28:16 +03:00
|
|
|
monitor_hw = true;
|
|
|
|
|
|
|
|
return 0;
|
2020-09-29 11:15:52 +03:00
|
|
|
|
|
|
|
err_module_put:
|
2021-03-10 13:28:01 +03:00
|
|
|
for_each_possible_cpu(cpu) {
|
|
|
|
struct per_cpu_dm_data *hw_data = &per_cpu(dm_hw_cpu_data, cpu);
|
|
|
|
struct sk_buff *skb;
|
|
|
|
|
|
|
|
del_timer_sync(&hw_data->send_timer);
|
|
|
|
cancel_work_sync(&hw_data->dm_alert_work);
|
|
|
|
while ((skb = __skb_dequeue(&hw_data->drop_queue))) {
|
|
|
|
struct devlink_trap_metadata *hw_metadata;
|
|
|
|
|
|
|
|
hw_metadata = NET_DM_SKB_CB(skb)->hw_metadata;
|
|
|
|
net_dm_hw_metadata_free(hw_metadata);
|
|
|
|
consume_skb(skb);
|
|
|
|
}
|
|
|
|
}
|
2020-09-29 11:15:52 +03:00
|
|
|
module_put(THIS_MODULE);
|
|
|
|
return rc;
|
2019-08-17 16:28:16 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
static void net_dm_hw_monitor_stop(struct netlink_ext_ack *extack)
|
|
|
|
{
|
2020-09-29 11:15:52 +03:00
|
|
|
const struct net_dm_alert_ops *ops;
|
2019-08-17 16:28:16 +03:00
|
|
|
int cpu;
|
|
|
|
|
2020-02-07 20:29:28 +03:00
|
|
|
if (!monitor_hw) {
|
2019-08-17 16:28:16 +03:00
|
|
|
NL_SET_ERR_MSG_MOD(extack, "Hardware monitoring already disabled");
|
2020-02-07 20:29:28 +03:00
|
|
|
return;
|
|
|
|
}
|
2019-08-17 16:28:16 +03:00
|
|
|
|
2020-09-29 11:15:52 +03:00
|
|
|
ops = net_dm_alert_ops_arr[net_dm_alert_mode];
|
|
|
|
|
2019-08-17 16:28:16 +03:00
|
|
|
monitor_hw = false;
|
|
|
|
|
2020-09-29 11:15:52 +03:00
|
|
|
net_dm_hw_probe_unregister(ops);
|
2019-08-17 16:28:16 +03:00
|
|
|
|
|
|
|
for_each_possible_cpu(cpu) {
|
|
|
|
struct per_cpu_dm_data *hw_data = &per_cpu(dm_hw_cpu_data, cpu);
|
|
|
|
struct sk_buff *skb;
|
|
|
|
|
|
|
|
del_timer_sync(&hw_data->send_timer);
|
|
|
|
cancel_work_sync(&hw_data->dm_alert_work);
|
|
|
|
while ((skb = __skb_dequeue(&hw_data->drop_queue))) {
|
2020-09-29 11:15:54 +03:00
|
|
|
struct devlink_trap_metadata *hw_metadata;
|
2019-08-17 16:28:16 +03:00
|
|
|
|
|
|
|
hw_metadata = NET_DM_SKB_CB(skb)->hw_metadata;
|
|
|
|
net_dm_hw_metadata_free(hw_metadata);
|
|
|
|
consume_skb(skb);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
module_put(THIS_MODULE);
|
|
|
|
}
|
|
|
|
|
2019-08-11 10:35:46 +03:00
|
|
|
static int net_dm_trace_on_set(struct netlink_ext_ack *extack)
|
|
|
|
{
|
2019-08-11 10:35:50 +03:00
|
|
|
const struct net_dm_alert_ops *ops;
|
2019-08-11 10:35:47 +03:00
|
|
|
int cpu, rc;
|
2019-08-11 10:35:46 +03:00
|
|
|
|
2019-08-11 10:35:50 +03:00
|
|
|
ops = net_dm_alert_ops_arr[net_dm_alert_mode];
|
|
|
|
|
2019-08-11 10:35:46 +03:00
|
|
|
if (!try_module_get(THIS_MODULE)) {
|
|
|
|
NL_SET_ERR_MSG_MOD(extack, "Failed to take reference on module");
|
|
|
|
return -ENODEV;
|
|
|
|
}
|
|
|
|
|
2019-08-11 10:35:47 +03:00
|
|
|
for_each_possible_cpu(cpu) {
|
|
|
|
struct per_cpu_dm_data *data = &per_cpu(dm_cpu_data, cpu);
|
2019-08-11 10:35:48 +03:00
|
|
|
struct sk_buff *skb;
|
2019-08-11 10:35:47 +03:00
|
|
|
|
2019-08-11 10:35:50 +03:00
|
|
|
INIT_WORK(&data->dm_alert_work, ops->work_item_func);
|
2019-08-11 10:35:47 +03:00
|
|
|
timer_setup(&data->send_timer, sched_send_work, 0);
|
2019-08-11 10:35:48 +03:00
|
|
|
/* Allocate a new per-CPU skb for the summary alert message and
|
|
|
|
* free the old one which might contain stale data from
|
|
|
|
* previous tracing.
|
|
|
|
*/
|
|
|
|
skb = reset_per_cpu_data(data);
|
|
|
|
consume_skb(skb);
|
2019-08-11 10:35:47 +03:00
|
|
|
}
|
|
|
|
|
2019-08-11 10:35:50 +03:00
|
|
|
rc = register_trace_kfree_skb(ops->kfree_skb_probe, NULL);
|
2019-08-11 10:35:46 +03:00
|
|
|
if (rc) {
|
|
|
|
NL_SET_ERR_MSG_MOD(extack, "Failed to connect probe to kfree_skb() tracepoint");
|
|
|
|
goto err_module_put;
|
|
|
|
}
|
|
|
|
|
2019-08-11 10:35:50 +03:00
|
|
|
rc = register_trace_napi_poll(ops->napi_poll_probe, NULL);
|
2019-08-11 10:35:46 +03:00
|
|
|
if (rc) {
|
|
|
|
NL_SET_ERR_MSG_MOD(extack, "Failed to connect probe to napi_poll() tracepoint");
|
|
|
|
goto err_unregister_trace;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
err_unregister_trace:
|
2019-08-11 10:35:50 +03:00
|
|
|
unregister_trace_kfree_skb(ops->kfree_skb_probe, NULL);
|
2019-08-11 10:35:46 +03:00
|
|
|
err_module_put:
|
2021-03-10 13:28:01 +03:00
|
|
|
for_each_possible_cpu(cpu) {
|
|
|
|
struct per_cpu_dm_data *data = &per_cpu(dm_cpu_data, cpu);
|
|
|
|
struct sk_buff *skb;
|
|
|
|
|
|
|
|
del_timer_sync(&data->send_timer);
|
|
|
|
cancel_work_sync(&data->dm_alert_work);
|
|
|
|
while ((skb = __skb_dequeue(&data->drop_queue)))
|
|
|
|
consume_skb(skb);
|
|
|
|
}
|
2019-08-11 10:35:46 +03:00
|
|
|
module_put(THIS_MODULE);
|
|
|
|
return rc;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void net_dm_trace_off_set(void)
|
|
|
|
{
|
|
|
|
struct dm_hw_stat_delta *new_stat, *temp;
|
2019-08-11 10:35:50 +03:00
|
|
|
const struct net_dm_alert_ops *ops;
|
2019-08-11 10:35:47 +03:00
|
|
|
int cpu;
|
2019-08-11 10:35:46 +03:00
|
|
|
|
2019-08-11 10:35:50 +03:00
|
|
|
ops = net_dm_alert_ops_arr[net_dm_alert_mode];
|
|
|
|
|
|
|
|
unregister_trace_napi_poll(ops->napi_poll_probe, NULL);
|
|
|
|
unregister_trace_kfree_skb(ops->kfree_skb_probe, NULL);
|
2019-08-11 10:35:46 +03:00
|
|
|
|
|
|
|
tracepoint_synchronize_unregister();
|
|
|
|
|
2019-08-11 10:35:47 +03:00
|
|
|
/* Make sure we do not send notifications to user space after request
|
|
|
|
* to stop tracing returns.
|
|
|
|
*/
|
|
|
|
for_each_possible_cpu(cpu) {
|
|
|
|
struct per_cpu_dm_data *data = &per_cpu(dm_cpu_data, cpu);
|
2019-08-11 10:35:51 +03:00
|
|
|
struct sk_buff *skb;
|
2019-08-11 10:35:47 +03:00
|
|
|
|
|
|
|
del_timer_sync(&data->send_timer);
|
|
|
|
cancel_work_sync(&data->dm_alert_work);
|
2019-08-11 10:35:51 +03:00
|
|
|
while ((skb = __skb_dequeue(&data->drop_queue)))
|
|
|
|
consume_skb(skb);
|
2019-08-11 10:35:47 +03:00
|
|
|
}
|
|
|
|
|
2019-08-11 10:35:46 +03:00
|
|
|
list_for_each_entry_safe(new_stat, temp, &hw_stats_list, list) {
|
|
|
|
if (new_stat->dev == NULL) {
|
|
|
|
list_del_rcu(&new_stat->list);
|
|
|
|
kfree_rcu(new_stat, rcu);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
module_put(THIS_MODULE);
|
|
|
|
}
|
|
|
|
|
2019-08-06 16:19:55 +03:00
|
|
|
static int set_all_monitor_traces(int state, struct netlink_ext_ack *extack)
|
2009-03-11 12:51:26 +03:00
|
|
|
{
|
|
|
|
int rc = 0;
|
2009-05-21 11:36:08 +04:00
|
|
|
|
2010-07-20 08:52:09 +04:00
|
|
|
if (state == trace_state) {
|
2019-08-06 16:19:55 +03:00
|
|
|
NL_SET_ERR_MSG_MOD(extack, "Trace state already set to requested state");
|
2019-08-06 16:19:56 +03:00
|
|
|
return -EAGAIN;
|
2010-07-20 08:52:09 +04:00
|
|
|
}
|
|
|
|
|
2009-03-11 12:51:26 +03:00
|
|
|
switch (state) {
|
|
|
|
case TRACE_ON:
|
2019-08-11 10:35:46 +03:00
|
|
|
rc = net_dm_trace_on_set(extack);
|
2009-03-11 12:51:26 +03:00
|
|
|
break;
|
|
|
|
case TRACE_OFF:
|
2019-08-11 10:35:46 +03:00
|
|
|
net_dm_trace_off_set();
|
2009-03-11 12:51:26 +03:00
|
|
|
break;
|
|
|
|
default:
|
|
|
|
rc = 1;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
2009-05-21 11:36:08 +04:00
|
|
|
if (!rc)
|
|
|
|
trace_state = state;
|
2010-07-20 08:52:09 +04:00
|
|
|
else
|
|
|
|
rc = -EINPROGRESS;
|
2009-05-21 11:36:08 +04:00
|
|
|
|
2009-03-11 12:51:26 +03:00
|
|
|
return rc;
|
|
|
|
}
|
|
|
|
|
2019-08-17 16:28:13 +03:00
|
|
|
static bool net_dm_is_monitoring(void)
|
|
|
|
{
|
|
|
|
return trace_state == TRACE_ON || monitor_hw;
|
|
|
|
}
|
|
|
|
|
2019-08-11 10:35:51 +03:00
|
|
|
static int net_dm_alert_mode_get_from_info(struct genl_info *info,
|
|
|
|
enum net_dm_alert_mode *p_alert_mode)
|
|
|
|
{
|
|
|
|
u8 val;
|
|
|
|
|
|
|
|
val = nla_get_u8(info->attrs[NET_DM_ATTR_ALERT_MODE]);
|
|
|
|
|
|
|
|
switch (val) {
|
2020-08-24 01:36:59 +03:00
|
|
|
case NET_DM_ALERT_MODE_SUMMARY:
|
2019-08-11 10:35:51 +03:00
|
|
|
case NET_DM_ALERT_MODE_PACKET:
|
|
|
|
*p_alert_mode = val;
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int net_dm_alert_mode_set(struct genl_info *info)
|
|
|
|
{
|
|
|
|
struct netlink_ext_ack *extack = info->extack;
|
|
|
|
enum net_dm_alert_mode alert_mode;
|
|
|
|
int rc;
|
|
|
|
|
|
|
|
if (!info->attrs[NET_DM_ATTR_ALERT_MODE])
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
rc = net_dm_alert_mode_get_from_info(info, &alert_mode);
|
|
|
|
if (rc) {
|
|
|
|
NL_SET_ERR_MSG_MOD(extack, "Invalid alert mode");
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
net_dm_alert_mode = alert_mode;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2019-08-11 10:35:52 +03:00
|
|
|
static void net_dm_trunc_len_set(struct genl_info *info)
|
|
|
|
{
|
|
|
|
if (!info->attrs[NET_DM_ATTR_TRUNC_LEN])
|
|
|
|
return;
|
|
|
|
|
|
|
|
net_dm_trunc_len = nla_get_u32(info->attrs[NET_DM_ATTR_TRUNC_LEN]);
|
|
|
|
}
|
|
|
|
|
2019-08-11 10:35:54 +03:00
|
|
|
static void net_dm_queue_len_set(struct genl_info *info)
|
|
|
|
{
|
|
|
|
if (!info->attrs[NET_DM_ATTR_QUEUE_LEN])
|
|
|
|
return;
|
|
|
|
|
|
|
|
net_dm_queue_len = nla_get_u32(info->attrs[NET_DM_ATTR_QUEUE_LEN]);
|
|
|
|
}
|
|
|
|
|
2009-03-11 12:51:26 +03:00
|
|
|
static int net_dm_cmd_config(struct sk_buff *skb,
|
|
|
|
struct genl_info *info)
|
|
|
|
{
|
2019-08-11 10:35:51 +03:00
|
|
|
struct netlink_ext_ack *extack = info->extack;
|
|
|
|
int rc;
|
2019-08-06 16:19:55 +03:00
|
|
|
|
2019-08-17 16:28:13 +03:00
|
|
|
if (net_dm_is_monitoring()) {
|
|
|
|
NL_SET_ERR_MSG_MOD(extack, "Cannot configure drop monitor during monitoring");
|
2019-08-11 10:35:51 +03:00
|
|
|
return -EBUSY;
|
|
|
|
}
|
|
|
|
|
|
|
|
rc = net_dm_alert_mode_set(info);
|
|
|
|
if (rc)
|
|
|
|
return rc;
|
|
|
|
|
2019-08-11 10:35:52 +03:00
|
|
|
net_dm_trunc_len_set(info);
|
|
|
|
|
2019-08-11 10:35:54 +03:00
|
|
|
net_dm_queue_len_set(info);
|
|
|
|
|
2019-08-11 10:35:51 +03:00
|
|
|
return 0;
|
2009-03-11 12:51:26 +03:00
|
|
|
}
|
|
|
|
|
2019-08-17 16:28:16 +03:00
|
|
|
static int net_dm_monitor_start(bool set_sw, bool set_hw,
|
|
|
|
struct netlink_ext_ack *extack)
|
|
|
|
{
|
|
|
|
bool sw_set = false;
|
|
|
|
int rc;
|
|
|
|
|
|
|
|
if (set_sw) {
|
|
|
|
rc = set_all_monitor_traces(TRACE_ON, extack);
|
|
|
|
if (rc)
|
|
|
|
return rc;
|
|
|
|
sw_set = true;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (set_hw) {
|
|
|
|
rc = net_dm_hw_monitor_start(extack);
|
|
|
|
if (rc)
|
|
|
|
goto err_monitor_hw;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
err_monitor_hw:
|
|
|
|
if (sw_set)
|
|
|
|
set_all_monitor_traces(TRACE_OFF, extack);
|
|
|
|
return rc;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void net_dm_monitor_stop(bool set_sw, bool set_hw,
|
|
|
|
struct netlink_ext_ack *extack)
|
|
|
|
{
|
|
|
|
if (set_hw)
|
|
|
|
net_dm_hw_monitor_stop(extack);
|
|
|
|
if (set_sw)
|
|
|
|
set_all_monitor_traces(TRACE_OFF, extack);
|
|
|
|
}
|
|
|
|
|
2009-03-11 12:51:26 +03:00
|
|
|
static int net_dm_cmd_trace(struct sk_buff *skb,
|
|
|
|
struct genl_info *info)
|
|
|
|
{
|
2019-08-17 16:28:16 +03:00
|
|
|
bool set_sw = !!info->attrs[NET_DM_ATTR_SW_DROPS];
|
|
|
|
bool set_hw = !!info->attrs[NET_DM_ATTR_HW_DROPS];
|
|
|
|
struct netlink_ext_ack *extack = info->extack;
|
|
|
|
|
|
|
|
/* To maintain backward compatibility, we start / stop monitoring of
|
|
|
|
* software drops if no flag is specified.
|
|
|
|
*/
|
|
|
|
if (!set_sw && !set_hw)
|
|
|
|
set_sw = true;
|
|
|
|
|
2009-03-11 12:51:26 +03:00
|
|
|
switch (info->genlhdr->cmd) {
|
|
|
|
case NET_DM_CMD_START:
|
2019-08-17 16:28:16 +03:00
|
|
|
return net_dm_monitor_start(set_sw, set_hw, extack);
|
2009-03-11 12:51:26 +03:00
|
|
|
case NET_DM_CMD_STOP:
|
2019-08-17 16:28:16 +03:00
|
|
|
net_dm_monitor_stop(set_sw, set_hw, extack);
|
|
|
|
return 0;
|
2009-03-11 12:51:26 +03:00
|
|
|
}
|
|
|
|
|
2019-08-06 16:19:51 +03:00
|
|
|
return -EOPNOTSUPP;
|
2009-03-11 12:51:26 +03:00
|
|
|
}
|
|
|
|
|
2019-08-11 10:35:53 +03:00
|
|
|
static int net_dm_config_fill(struct sk_buff *msg, struct genl_info *info)
|
|
|
|
{
|
|
|
|
void *hdr;
|
|
|
|
|
|
|
|
hdr = genlmsg_put(msg, info->snd_portid, info->snd_seq,
|
|
|
|
&net_drop_monitor_family, 0, NET_DM_CMD_CONFIG_NEW);
|
|
|
|
if (!hdr)
|
|
|
|
return -EMSGSIZE;
|
|
|
|
|
|
|
|
if (nla_put_u8(msg, NET_DM_ATTR_ALERT_MODE, net_dm_alert_mode))
|
|
|
|
goto nla_put_failure;
|
|
|
|
|
|
|
|
if (nla_put_u32(msg, NET_DM_ATTR_TRUNC_LEN, net_dm_trunc_len))
|
|
|
|
goto nla_put_failure;
|
|
|
|
|
2019-08-11 10:35:54 +03:00
|
|
|
if (nla_put_u32(msg, NET_DM_ATTR_QUEUE_LEN, net_dm_queue_len))
|
|
|
|
goto nla_put_failure;
|
|
|
|
|
2019-08-11 10:35:53 +03:00
|
|
|
genlmsg_end(msg, hdr);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
nla_put_failure:
|
|
|
|
genlmsg_cancel(msg, hdr);
|
|
|
|
return -EMSGSIZE;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int net_dm_cmd_config_get(struct sk_buff *skb, struct genl_info *info)
|
|
|
|
{
|
|
|
|
struct sk_buff *msg;
|
|
|
|
int rc;
|
|
|
|
|
|
|
|
msg = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL);
|
|
|
|
if (!msg)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
rc = net_dm_config_fill(msg, info);
|
|
|
|
if (rc)
|
|
|
|
goto free_msg;
|
|
|
|
|
|
|
|
return genlmsg_reply(msg, info);
|
|
|
|
|
|
|
|
free_msg:
|
|
|
|
nlmsg_free(msg);
|
|
|
|
return rc;
|
|
|
|
}
|
|
|
|
|
2019-08-11 10:35:55 +03:00
|
|
|
static void net_dm_stats_read(struct net_dm_stats *stats)
|
|
|
|
{
|
|
|
|
int cpu;
|
|
|
|
|
|
|
|
memset(stats, 0, sizeof(*stats));
|
|
|
|
for_each_possible_cpu(cpu) {
|
|
|
|
struct per_cpu_dm_data *data = &per_cpu(dm_cpu_data, cpu);
|
|
|
|
struct net_dm_stats *cpu_stats = &data->stats;
|
|
|
|
unsigned int start;
|
|
|
|
u64 dropped;
|
|
|
|
|
|
|
|
do {
|
|
|
|
start = u64_stats_fetch_begin_irq(&cpu_stats->syncp);
|
|
|
|
dropped = cpu_stats->dropped;
|
|
|
|
} while (u64_stats_fetch_retry_irq(&cpu_stats->syncp, start));
|
|
|
|
|
|
|
|
stats->dropped += dropped;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static int net_dm_stats_put(struct sk_buff *msg)
|
|
|
|
{
|
|
|
|
struct net_dm_stats stats;
|
|
|
|
struct nlattr *attr;
|
|
|
|
|
|
|
|
net_dm_stats_read(&stats);
|
|
|
|
|
|
|
|
attr = nla_nest_start(msg, NET_DM_ATTR_STATS);
|
|
|
|
if (!attr)
|
|
|
|
return -EMSGSIZE;
|
|
|
|
|
|
|
|
if (nla_put_u64_64bit(msg, NET_DM_ATTR_STATS_DROPPED,
|
|
|
|
stats.dropped, NET_DM_ATTR_PAD))
|
|
|
|
goto nla_put_failure;
|
|
|
|
|
|
|
|
nla_nest_end(msg, attr);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
nla_put_failure:
|
|
|
|
nla_nest_cancel(msg, attr);
|
|
|
|
return -EMSGSIZE;
|
|
|
|
}
|
|
|
|
|
2019-08-17 16:28:14 +03:00
|
|
|
static void net_dm_hw_stats_read(struct net_dm_stats *stats)
|
|
|
|
{
|
|
|
|
int cpu;
|
|
|
|
|
|
|
|
memset(stats, 0, sizeof(*stats));
|
|
|
|
for_each_possible_cpu(cpu) {
|
|
|
|
struct per_cpu_dm_data *hw_data = &per_cpu(dm_hw_cpu_data, cpu);
|
|
|
|
struct net_dm_stats *cpu_stats = &hw_data->stats;
|
|
|
|
unsigned int start;
|
|
|
|
u64 dropped;
|
|
|
|
|
|
|
|
do {
|
|
|
|
start = u64_stats_fetch_begin_irq(&cpu_stats->syncp);
|
|
|
|
dropped = cpu_stats->dropped;
|
|
|
|
} while (u64_stats_fetch_retry_irq(&cpu_stats->syncp, start));
|
|
|
|
|
|
|
|
stats->dropped += dropped;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static int net_dm_hw_stats_put(struct sk_buff *msg)
|
|
|
|
{
|
|
|
|
struct net_dm_stats stats;
|
|
|
|
struct nlattr *attr;
|
|
|
|
|
|
|
|
net_dm_hw_stats_read(&stats);
|
|
|
|
|
|
|
|
attr = nla_nest_start(msg, NET_DM_ATTR_HW_STATS);
|
|
|
|
if (!attr)
|
|
|
|
return -EMSGSIZE;
|
|
|
|
|
|
|
|
if (nla_put_u64_64bit(msg, NET_DM_ATTR_STATS_DROPPED,
|
|
|
|
stats.dropped, NET_DM_ATTR_PAD))
|
|
|
|
goto nla_put_failure;
|
|
|
|
|
|
|
|
nla_nest_end(msg, attr);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
nla_put_failure:
|
|
|
|
nla_nest_cancel(msg, attr);
|
|
|
|
return -EMSGSIZE;
|
|
|
|
}
|
|
|
|
|
2019-08-11 10:35:55 +03:00
|
|
|
static int net_dm_stats_fill(struct sk_buff *msg, struct genl_info *info)
|
|
|
|
{
|
|
|
|
void *hdr;
|
|
|
|
int rc;
|
|
|
|
|
|
|
|
hdr = genlmsg_put(msg, info->snd_portid, info->snd_seq,
|
|
|
|
&net_drop_monitor_family, 0, NET_DM_CMD_STATS_NEW);
|
|
|
|
if (!hdr)
|
|
|
|
return -EMSGSIZE;
|
|
|
|
|
|
|
|
rc = net_dm_stats_put(msg);
|
|
|
|
if (rc)
|
|
|
|
goto nla_put_failure;
|
|
|
|
|
2019-08-17 16:28:14 +03:00
|
|
|
rc = net_dm_hw_stats_put(msg);
|
|
|
|
if (rc)
|
|
|
|
goto nla_put_failure;
|
|
|
|
|
2019-08-11 10:35:55 +03:00
|
|
|
genlmsg_end(msg, hdr);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
nla_put_failure:
|
|
|
|
genlmsg_cancel(msg, hdr);
|
|
|
|
return -EMSGSIZE;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int net_dm_cmd_stats_get(struct sk_buff *skb, struct genl_info *info)
|
|
|
|
{
|
|
|
|
struct sk_buff *msg;
|
|
|
|
int rc;
|
|
|
|
|
|
|
|
msg = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL);
|
|
|
|
if (!msg)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
rc = net_dm_stats_fill(msg, info);
|
|
|
|
if (rc)
|
|
|
|
goto free_msg;
|
|
|
|
|
|
|
|
return genlmsg_reply(msg, info);
|
|
|
|
|
|
|
|
free_msg:
|
|
|
|
nlmsg_free(msg);
|
|
|
|
return rc;
|
|
|
|
}
|
|
|
|
|
2009-05-21 11:36:08 +04:00
|
|
|
static int dropmon_net_event(struct notifier_block *ev_block,
|
2013-05-28 05:30:21 +04:00
|
|
|
unsigned long event, void *ptr)
|
2009-05-21 11:36:08 +04:00
|
|
|
{
|
2013-05-28 05:30:21 +04:00
|
|
|
struct net_device *dev = netdev_notifier_info_to_dev(ptr);
|
2009-05-21 11:36:08 +04:00
|
|
|
struct dm_hw_stat_delta *new_stat = NULL;
|
|
|
|
struct dm_hw_stat_delta *tmp;
|
|
|
|
|
|
|
|
switch (event) {
|
|
|
|
case NETDEV_REGISTER:
|
|
|
|
new_stat = kzalloc(sizeof(struct dm_hw_stat_delta), GFP_KERNEL);
|
|
|
|
|
|
|
|
if (!new_stat)
|
|
|
|
goto out;
|
|
|
|
|
|
|
|
new_stat->dev = dev;
|
2009-09-03 01:37:45 +04:00
|
|
|
new_stat->last_rx = jiffies;
|
2019-08-06 16:19:52 +03:00
|
|
|
mutex_lock(&net_dm_mutex);
|
2009-05-21 11:36:08 +04:00
|
|
|
list_add_rcu(&new_stat->list, &hw_stats_list);
|
2019-08-06 16:19:52 +03:00
|
|
|
mutex_unlock(&net_dm_mutex);
|
2009-05-21 11:36:08 +04:00
|
|
|
break;
|
|
|
|
case NETDEV_UNREGISTER:
|
2019-08-06 16:19:52 +03:00
|
|
|
mutex_lock(&net_dm_mutex);
|
2009-05-21 11:36:08 +04:00
|
|
|
list_for_each_entry_safe(new_stat, tmp, &hw_stats_list, list) {
|
|
|
|
if (new_stat->dev == dev) {
|
2022-02-10 20:13:31 +03:00
|
|
|
|
|
|
|
/* Paired with READ_ONCE() in trace_napi_poll_hit() */
|
|
|
|
WRITE_ONCE(new_stat->dev, NULL);
|
|
|
|
|
2009-05-21 11:36:08 +04:00
|
|
|
if (trace_state == TRACE_OFF) {
|
|
|
|
list_del_rcu(&new_stat->list);
|
2011-03-18 06:39:43 +03:00
|
|
|
kfree_rcu(new_stat, rcu);
|
2009-05-21 11:36:08 +04:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2019-08-06 16:19:52 +03:00
|
|
|
mutex_unlock(&net_dm_mutex);
|
2009-05-21 11:36:08 +04:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
out:
|
|
|
|
return NOTIFY_DONE;
|
|
|
|
}
|
2009-03-11 12:51:26 +03:00
|
|
|
|
2019-08-11 10:35:51 +03:00
|
|
|
static const struct nla_policy net_dm_nl_policy[NET_DM_ATTR_MAX + 1] = {
|
|
|
|
[NET_DM_ATTR_UNSPEC] = { .strict_start_type = NET_DM_ATTR_UNSPEC + 1 },
|
|
|
|
[NET_DM_ATTR_ALERT_MODE] = { .type = NLA_U8 },
|
2019-08-11 10:35:52 +03:00
|
|
|
[NET_DM_ATTR_TRUNC_LEN] = { .type = NLA_U32 },
|
2019-08-11 10:35:54 +03:00
|
|
|
[NET_DM_ATTR_QUEUE_LEN] = { .type = NLA_U32 },
|
2019-08-17 16:28:16 +03:00
|
|
|
[NET_DM_ATTR_SW_DROPS] = {. type = NLA_FLAG },
|
|
|
|
[NET_DM_ATTR_HW_DROPS] = {. type = NLA_FLAG },
|
2019-08-11 10:35:51 +03:00
|
|
|
};
|
|
|
|
|
2020-10-03 00:49:54 +03:00
|
|
|
static const struct genl_small_ops dropmon_ops[] = {
|
2009-03-11 12:51:26 +03:00
|
|
|
{
|
|
|
|
.cmd = NET_DM_CMD_CONFIG,
|
2019-04-26 15:07:31 +03:00
|
|
|
.validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP,
|
2009-03-11 12:51:26 +03:00
|
|
|
.doit = net_dm_cmd_config,
|
2019-08-11 10:35:49 +03:00
|
|
|
.flags = GENL_ADMIN_PERM,
|
2009-03-11 12:51:26 +03:00
|
|
|
},
|
|
|
|
{
|
|
|
|
.cmd = NET_DM_CMD_START,
|
2019-04-26 15:07:31 +03:00
|
|
|
.validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP,
|
2009-03-11 12:51:26 +03:00
|
|
|
.doit = net_dm_cmd_trace,
|
drop_monitor: Require 'CAP_SYS_ADMIN' when joining "events" group
[ Upstream commit e03781879a0d524ce3126678d50a80484a513c4b ]
The "NET_DM" generic netlink family notifies drop locations over the
"events" multicast group. This is problematic since by default generic
netlink allows non-root users to listen to these notifications.
Fix by adding a new field to the generic netlink multicast group
structure that when set prevents non-root users or root without the
'CAP_SYS_ADMIN' capability (in the user namespace owning the network
namespace) from joining the group. Set this field for the "events"
group. Use 'CAP_SYS_ADMIN' rather than 'CAP_NET_ADMIN' because of the
nature of the information that is shared over this group.
Note that the capability check in this case will always be performed
against the initial user namespace since the family is not netns aware
and only operates in the initial network namespace.
A new field is added to the structure rather than using the "flags"
field because the existing field uses uAPI flags and it is inappropriate
to add a new uAPI flag for an internal kernel check. In net-next we can
rework the "flags" field to use internal flags and fold the new field
into it. But for now, in order to reduce the amount of changes, add a
new field.
Since the information can only be consumed by root, mark the control
plane operations that start and stop the tracing as root-only using the
'GENL_ADMIN_PERM' flag.
Tested using [1].
Before:
# capsh -- -c ./dm_repo
# capsh --drop=cap_sys_admin -- -c ./dm_repo
After:
# capsh -- -c ./dm_repo
# capsh --drop=cap_sys_admin -- -c ./dm_repo
Failed to join "events" multicast group
[1]
$ cat dm.c
#include <stdio.h>
#include <netlink/genl/ctrl.h>
#include <netlink/genl/genl.h>
#include <netlink/socket.h>
int main(int argc, char **argv)
{
struct nl_sock *sk;
int grp, err;
sk = nl_socket_alloc();
if (!sk) {
fprintf(stderr, "Failed to allocate socket\n");
return -1;
}
err = genl_connect(sk);
if (err) {
fprintf(stderr, "Failed to connect socket\n");
return err;
}
grp = genl_ctrl_resolve_grp(sk, "NET_DM", "events");
if (grp < 0) {
fprintf(stderr,
"Failed to resolve \"events\" multicast group\n");
return grp;
}
err = nl_socket_add_memberships(sk, grp, NFNLGRP_NONE);
if (err) {
fprintf(stderr, "Failed to join \"events\" multicast group\n");
return err;
}
return 0;
}
$ gcc -I/usr/include/libnl3 -lnl-3 -lnl-genl-3 -o dm_repo dm.c
Fixes: 9a8afc8d3962 ("Network Drop Monitor: Adding drop monitor implementation & Netlink protocol")
Reported-by: "The UK's National Cyber Security Centre (NCSC)" <security@ncsc.gov.uk>
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Link: https://lore.kernel.org/r/20231206213102.1824398-3-idosch@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2023-12-07 00:31:02 +03:00
|
|
|
.flags = GENL_ADMIN_PERM,
|
2009-03-11 12:51:26 +03:00
|
|
|
},
|
|
|
|
{
|
|
|
|
.cmd = NET_DM_CMD_STOP,
|
2019-04-26 15:07:31 +03:00
|
|
|
.validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP,
|
2009-03-11 12:51:26 +03:00
|
|
|
.doit = net_dm_cmd_trace,
|
drop_monitor: Require 'CAP_SYS_ADMIN' when joining "events" group
[ Upstream commit e03781879a0d524ce3126678d50a80484a513c4b ]
The "NET_DM" generic netlink family notifies drop locations over the
"events" multicast group. This is problematic since by default generic
netlink allows non-root users to listen to these notifications.
Fix by adding a new field to the generic netlink multicast group
structure that when set prevents non-root users or root without the
'CAP_SYS_ADMIN' capability (in the user namespace owning the network
namespace) from joining the group. Set this field for the "events"
group. Use 'CAP_SYS_ADMIN' rather than 'CAP_NET_ADMIN' because of the
nature of the information that is shared over this group.
Note that the capability check in this case will always be performed
against the initial user namespace since the family is not netns aware
and only operates in the initial network namespace.
A new field is added to the structure rather than using the "flags"
field because the existing field uses uAPI flags and it is inappropriate
to add a new uAPI flag for an internal kernel check. In net-next we can
rework the "flags" field to use internal flags and fold the new field
into it. But for now, in order to reduce the amount of changes, add a
new field.
Since the information can only be consumed by root, mark the control
plane operations that start and stop the tracing as root-only using the
'GENL_ADMIN_PERM' flag.
Tested using [1].
Before:
# capsh -- -c ./dm_repo
# capsh --drop=cap_sys_admin -- -c ./dm_repo
After:
# capsh -- -c ./dm_repo
# capsh --drop=cap_sys_admin -- -c ./dm_repo
Failed to join "events" multicast group
[1]
$ cat dm.c
#include <stdio.h>
#include <netlink/genl/ctrl.h>
#include <netlink/genl/genl.h>
#include <netlink/socket.h>
int main(int argc, char **argv)
{
struct nl_sock *sk;
int grp, err;
sk = nl_socket_alloc();
if (!sk) {
fprintf(stderr, "Failed to allocate socket\n");
return -1;
}
err = genl_connect(sk);
if (err) {
fprintf(stderr, "Failed to connect socket\n");
return err;
}
grp = genl_ctrl_resolve_grp(sk, "NET_DM", "events");
if (grp < 0) {
fprintf(stderr,
"Failed to resolve \"events\" multicast group\n");
return grp;
}
err = nl_socket_add_memberships(sk, grp, NFNLGRP_NONE);
if (err) {
fprintf(stderr, "Failed to join \"events\" multicast group\n");
return err;
}
return 0;
}
$ gcc -I/usr/include/libnl3 -lnl-3 -lnl-genl-3 -o dm_repo dm.c
Fixes: 9a8afc8d3962 ("Network Drop Monitor: Adding drop monitor implementation & Netlink protocol")
Reported-by: "The UK's National Cyber Security Centre (NCSC)" <security@ncsc.gov.uk>
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Link: https://lore.kernel.org/r/20231206213102.1824398-3-idosch@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2023-12-07 00:31:02 +03:00
|
|
|
.flags = GENL_ADMIN_PERM,
|
2009-03-11 12:51:26 +03:00
|
|
|
},
|
2019-08-11 10:35:53 +03:00
|
|
|
{
|
|
|
|
.cmd = NET_DM_CMD_CONFIG_GET,
|
|
|
|
.doit = net_dm_cmd_config_get,
|
|
|
|
},
|
2019-08-11 10:35:55 +03:00
|
|
|
{
|
|
|
|
.cmd = NET_DM_CMD_STATS_GET,
|
|
|
|
.doit = net_dm_cmd_stats_get,
|
|
|
|
},
|
2009-03-11 12:51:26 +03:00
|
|
|
};
|
|
|
|
|
2019-08-06 16:19:56 +03:00
|
|
|
static int net_dm_nl_pre_doit(const struct genl_ops *ops,
|
|
|
|
struct sk_buff *skb, struct genl_info *info)
|
|
|
|
{
|
|
|
|
mutex_lock(&net_dm_mutex);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void net_dm_nl_post_doit(const struct genl_ops *ops,
|
|
|
|
struct sk_buff *skb, struct genl_info *info)
|
|
|
|
{
|
|
|
|
mutex_unlock(&net_dm_mutex);
|
|
|
|
}
|
|
|
|
|
2016-10-24 15:40:05 +03:00
|
|
|
static struct genl_family net_drop_monitor_family __ro_after_init = {
|
2016-10-24 15:40:03 +03:00
|
|
|
.hdrsize = 0,
|
|
|
|
.name = "NET_DM",
|
|
|
|
.version = 2,
|
2019-08-11 10:35:51 +03:00
|
|
|
.maxattr = NET_DM_ATTR_MAX,
|
|
|
|
.policy = net_dm_nl_policy,
|
2019-08-06 16:19:56 +03:00
|
|
|
.pre_doit = net_dm_nl_pre_doit,
|
|
|
|
.post_doit = net_dm_nl_post_doit,
|
2016-10-24 15:40:03 +03:00
|
|
|
.module = THIS_MODULE,
|
2020-10-03 00:49:54 +03:00
|
|
|
.small_ops = dropmon_ops,
|
|
|
|
.n_small_ops = ARRAY_SIZE(dropmon_ops),
|
2016-10-24 15:40:03 +03:00
|
|
|
.mcgrps = dropmon_mcgrps,
|
|
|
|
.n_mcgrps = ARRAY_SIZE(dropmon_mcgrps),
|
|
|
|
};
|
|
|
|
|
2009-05-21 11:36:08 +04:00
|
|
|
static struct notifier_block dropmon_net_notifier = {
|
|
|
|
.notifier_call = dropmon_net_event
|
|
|
|
};
|
|
|
|
|
2019-08-17 16:28:10 +03:00
|
|
|
static void __net_dm_cpu_data_init(struct per_cpu_dm_data *data)
|
|
|
|
{
|
drop_monitor: replace spin_lock by raw_spin_lock
[ Upstream commit f1e197a665c2148ebc25fe09c53689e60afea195 ]
trace_drop_common() is called with preemption disabled, and it acquires
a spin_lock. This is problematic for RT kernels because spin_locks are
sleeping locks in this configuration, which causes the following splat:
BUG: sleeping function called from invalid context at kernel/locking/spinlock_rt.c:48
in_atomic(): 1, irqs_disabled(): 1, non_block: 0, pid: 449, name: rcuc/47
preempt_count: 1, expected: 0
RCU nest depth: 2, expected: 2
5 locks held by rcuc/47/449:
#0: ff1100086ec30a60 ((softirq_ctrl.lock)){+.+.}-{2:2}, at: __local_bh_disable_ip+0x105/0x210
#1: ffffffffb394a280 (rcu_read_lock){....}-{1:2}, at: rt_spin_lock+0xbf/0x130
#2: ffffffffb394a280 (rcu_read_lock){....}-{1:2}, at: __local_bh_disable_ip+0x11c/0x210
#3: ffffffffb394a160 (rcu_callback){....}-{0:0}, at: rcu_do_batch+0x360/0xc70
#4: ff1100086ee07520 (&data->lock){+.+.}-{2:2}, at: trace_drop_common.constprop.0+0xb5/0x290
irq event stamp: 139909
hardirqs last enabled at (139908): [<ffffffffb1df2b33>] _raw_spin_unlock_irqrestore+0x63/0x80
hardirqs last disabled at (139909): [<ffffffffb19bd03d>] trace_drop_common.constprop.0+0x26d/0x290
softirqs last enabled at (139892): [<ffffffffb07a1083>] __local_bh_enable_ip+0x103/0x170
softirqs last disabled at (139898): [<ffffffffb0909b33>] rcu_cpu_kthread+0x93/0x1f0
Preemption disabled at:
[<ffffffffb1de786b>] rt_mutex_slowunlock+0xab/0x2e0
CPU: 47 PID: 449 Comm: rcuc/47 Not tainted 6.9.0-rc2-rt1+ #7
Hardware name: Dell Inc. PowerEdge R650/0Y2G81, BIOS 1.6.5 04/15/2022
Call Trace:
<TASK>
dump_stack_lvl+0x8c/0xd0
dump_stack+0x14/0x20
__might_resched+0x21e/0x2f0
rt_spin_lock+0x5e/0x130
? trace_drop_common.constprop.0+0xb5/0x290
? skb_queue_purge_reason.part.0+0x1bf/0x230
trace_drop_common.constprop.0+0xb5/0x290
? preempt_count_sub+0x1c/0xd0
? _raw_spin_unlock_irqrestore+0x4a/0x80
? __pfx_trace_drop_common.constprop.0+0x10/0x10
? rt_mutex_slowunlock+0x26a/0x2e0
? skb_queue_purge_reason.part.0+0x1bf/0x230
? __pfx_rt_mutex_slowunlock+0x10/0x10
? skb_queue_purge_reason.part.0+0x1bf/0x230
trace_kfree_skb_hit+0x15/0x20
trace_kfree_skb+0xe9/0x150
kfree_skb_reason+0x7b/0x110
skb_queue_purge_reason.part.0+0x1bf/0x230
? __pfx_skb_queue_purge_reason.part.0+0x10/0x10
? mark_lock.part.0+0x8a/0x520
...
trace_drop_common() also disables interrupts, but this is a minor issue
because we could easily replace it with a local_lock.
Replace the spin_lock with raw_spin_lock to avoid sleeping in atomic
context.
Signed-off-by: Wander Lairson Costa <wander@redhat.com>
Reported-by: Hu Chunyu <chuhu@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-04-11 17:13:46 +03:00
|
|
|
raw_spin_lock_init(&data->lock);
|
2019-08-17 16:28:10 +03:00
|
|
|
skb_queue_head_init(&data->drop_queue);
|
|
|
|
u64_stats_init(&data->stats.syncp);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void __net_dm_cpu_data_fini(struct per_cpu_dm_data *data)
|
|
|
|
{
|
|
|
|
WARN_ON(!skb_queue_empty(&data->drop_queue));
|
|
|
|
}
|
|
|
|
|
|
|
|
static void net_dm_cpu_data_init(int cpu)
|
2009-03-11 12:51:26 +03:00
|
|
|
{
|
|
|
|
struct per_cpu_dm_data *data;
|
2019-08-17 16:28:10 +03:00
|
|
|
|
|
|
|
data = &per_cpu(dm_cpu_data, cpu);
|
|
|
|
__net_dm_cpu_data_init(data);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void net_dm_cpu_data_fini(int cpu)
|
|
|
|
{
|
|
|
|
struct per_cpu_dm_data *data;
|
|
|
|
|
|
|
|
data = &per_cpu(dm_cpu_data, cpu);
|
|
|
|
/* At this point, we should have exclusive access
|
|
|
|
* to this struct and can free the skb inside it.
|
|
|
|
*/
|
|
|
|
consume_skb(data->skb);
|
|
|
|
__net_dm_cpu_data_fini(data);
|
|
|
|
}
|
|
|
|
|
2019-08-17 16:28:11 +03:00
|
|
|
static void net_dm_hw_cpu_data_init(int cpu)
|
|
|
|
{
|
|
|
|
struct per_cpu_dm_data *hw_data;
|
|
|
|
|
|
|
|
hw_data = &per_cpu(dm_hw_cpu_data, cpu);
|
|
|
|
__net_dm_cpu_data_init(hw_data);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void net_dm_hw_cpu_data_fini(int cpu)
|
|
|
|
{
|
|
|
|
struct per_cpu_dm_data *hw_data;
|
|
|
|
|
|
|
|
hw_data = &per_cpu(dm_hw_cpu_data, cpu);
|
2019-08-17 16:28:15 +03:00
|
|
|
kfree(hw_data->hw_entries);
|
2019-08-17 16:28:11 +03:00
|
|
|
__net_dm_cpu_data_fini(hw_data);
|
|
|
|
}
|
|
|
|
|
2019-08-17 16:28:10 +03:00
|
|
|
static int __init init_net_drop_monitor(void)
|
|
|
|
{
|
2010-07-27 07:59:42 +04:00
|
|
|
int cpu, rc;
|
|
|
|
|
2012-05-16 23:58:40 +04:00
|
|
|
pr_info("Initializing network drop monitor service\n");
|
2009-03-11 12:51:26 +03:00
|
|
|
|
|
|
|
if (sizeof(void *) > 8) {
|
2012-05-16 23:58:40 +04:00
|
|
|
pr_err("Unable to store program counters on this arch, Drop monitor failed\n");
|
2009-03-11 12:51:26 +03:00
|
|
|
return -ENOSPC;
|
|
|
|
}
|
|
|
|
|
2016-10-24 15:40:03 +03:00
|
|
|
rc = genl_register_family(&net_drop_monitor_family);
|
2010-07-27 07:59:42 +04:00
|
|
|
if (rc) {
|
2012-05-16 23:58:40 +04:00
|
|
|
pr_err("Could not create drop monitor netlink family\n");
|
2010-07-27 07:59:42 +04:00
|
|
|
return rc;
|
2009-03-11 12:51:26 +03:00
|
|
|
}
|
2013-11-19 18:19:39 +04:00
|
|
|
WARN_ON(net_drop_monitor_family.mcgrp_offset != NET_DM_GRP_ALERT);
|
2013-11-19 18:19:32 +04:00
|
|
|
|
2009-05-21 11:36:08 +04:00
|
|
|
rc = register_netdevice_notifier(&dropmon_net_notifier);
|
|
|
|
if (rc < 0) {
|
2012-05-16 23:58:40 +04:00
|
|
|
pr_crit("Failed to register netdevice notifier\n");
|
2009-05-21 11:36:08 +04:00
|
|
|
goto out_unreg;
|
|
|
|
}
|
|
|
|
|
2009-03-11 12:51:26 +03:00
|
|
|
rc = 0;
|
|
|
|
|
2019-08-17 16:28:11 +03:00
|
|
|
for_each_possible_cpu(cpu) {
|
2019-08-17 16:28:10 +03:00
|
|
|
net_dm_cpu_data_init(cpu);
|
2019-08-17 16:28:11 +03:00
|
|
|
net_dm_hw_cpu_data_init(cpu);
|
|
|
|
}
|
2009-05-21 11:36:08 +04:00
|
|
|
|
2009-03-11 12:51:26 +03:00
|
|
|
goto out;
|
|
|
|
|
|
|
|
out_unreg:
|
|
|
|
genl_unregister_family(&net_drop_monitor_family);
|
|
|
|
out:
|
|
|
|
return rc;
|
|
|
|
}
|
|
|
|
|
2012-05-17 14:04:00 +04:00
|
|
|
static void exit_net_drop_monitor(void)
|
|
|
|
{
|
|
|
|
int cpu;
|
|
|
|
|
|
|
|
BUG_ON(unregister_netdevice_notifier(&dropmon_net_notifier));
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Because of the module_get/put we do in the trace state change path
|
2021-03-18 14:52:13 +03:00
|
|
|
* we are guaranteed not to have any current users when we get here
|
2012-05-17 14:04:00 +04:00
|
|
|
*/
|
|
|
|
|
2019-08-17 16:28:11 +03:00
|
|
|
for_each_possible_cpu(cpu) {
|
|
|
|
net_dm_hw_cpu_data_fini(cpu);
|
2019-08-17 16:28:10 +03:00
|
|
|
net_dm_cpu_data_fini(cpu);
|
2019-08-17 16:28:11 +03:00
|
|
|
}
|
2012-05-17 14:04:00 +04:00
|
|
|
|
|
|
|
BUG_ON(genl_unregister_family(&net_drop_monitor_family));
|
|
|
|
}
|
|
|
|
|
|
|
|
module_init(init_net_drop_monitor);
|
|
|
|
module_exit(exit_net_drop_monitor);
|
|
|
|
|
|
|
|
MODULE_LICENSE("GPL v2");
|
|
|
|
MODULE_AUTHOR("Neil Horman <nhorman@tuxdriver.com>");
|
2012-05-29 13:30:42 +04:00
|
|
|
MODULE_ALIAS_GENL_FAMILY("NET_DM");
|
2020-06-20 05:08:25 +03:00
|
|
|
MODULE_DESCRIPTION("Monitoring code for network dropped packet alerts");
|