2013-11-24 18:54:58 +04:00
|
|
|
/*
|
|
|
|
* kernfs.h - pseudo filesystem decoupled from vfs locking
|
|
|
|
*
|
|
|
|
* This file is released under the GPLv2.
|
|
|
|
*/
|
|
|
|
|
|
|
|
#ifndef __LINUX_KERNFS_H
|
|
|
|
#define __LINUX_KERNFS_H
|
|
|
|
|
2013-11-24 02:21:49 +04:00
|
|
|
#include <linux/kernel.h>
|
2013-11-24 02:21:50 +04:00
|
|
|
#include <linux/err.h>
|
2013-11-28 23:54:20 +04:00
|
|
|
#include <linux/list.h>
|
|
|
|
#include <linux/mutex.h>
|
2013-11-28 23:54:41 +04:00
|
|
|
#include <linux/idr.h>
|
2013-11-28 23:54:29 +04:00
|
|
|
#include <linux/lockdep.h>
|
2013-11-30 02:18:32 +04:00
|
|
|
#include <linux/rbtree.h>
|
|
|
|
#include <linux/atomic.h>
|
2018-07-21 00:56:47 +03:00
|
|
|
#include <linux/uidgid.h>
|
2014-02-03 23:02:55 +04:00
|
|
|
#include <linux/wait.h>
|
2013-11-24 02:21:49 +04:00
|
|
|
|
2013-11-24 02:21:52 +04:00
|
|
|
struct file;
|
2014-01-17 18:57:49 +04:00
|
|
|
struct dentry;
|
2013-11-24 02:21:52 +04:00
|
|
|
struct iattr;
|
2013-11-28 23:54:20 +04:00
|
|
|
struct seq_file;
|
|
|
|
struct vm_area_struct;
|
2013-11-28 23:54:43 +04:00
|
|
|
struct super_block;
|
|
|
|
struct file_system_type;
|
fs: kernfs: add poll file operation
Patch series "psi: pressure stall monitors", v3.
Android is adopting psi to detect and remedy memory pressure that
results in stuttering and decreased responsiveness on mobile devices.
Psi gives us the stall information, but because we're dealing with
latencies in the millisecond range, periodically reading the pressure
files to detect stalls in a timely fashion is not feasible. Psi also
doesn't aggregate its averages at a high enough frequency right now.
This patch series extends the psi interface such that users can
configure sensitive latency thresholds and use poll() and friends to be
notified when these are breached.
As high-frequency aggregation is costly, it implements an aggregation
method that is optimized for fast, short-interval averaging, and makes
the aggregation frequency adaptive, such that high-frequency updates
only happen while monitored stall events are actively occurring.
With these patches applied, Android can monitor for, and ward off,
mounting memory shortages before they cause problems for the user. For
example, using memory stall monitors in userspace low memory killer
daemon (lmkd) we can detect mounting pressure and kill less important
processes before device becomes visibly sluggish.
In our memory stress testing psi memory monitors produce roughly 10x
less false positives compared to vmpressure signals. Having ability to
specify multiple triggers for the same psi metric allows other parts of
Android framework to monitor memory state of the device and act
accordingly.
The new interface is straightforward. The user opens one of the
pressure files for writing and writes a trigger description into the
file descriptor that defines the stall state - some or full, and the
maximum stall time over a given window of time. E.g.:
/* Signal when stall time exceeds 100ms of a 1s window */
char trigger[] = "full 100000 1000000";
fd = open("/proc/pressure/memory");
write(fd, trigger, sizeof(trigger));
while (poll() >= 0) {
...
}
close(fd);
When the monitored stall state is entered, psi adapts its aggregation
frequency according to what the configured time window requires in order
to emit event signals in a timely fashion. Once the stalling subsides,
aggregation reverts back to normal.
The trigger is associated with the open file descriptor. To stop
monitoring, the user only needs to close the file descriptor and the
trigger is discarded.
Patches 1-4 prepare the psi code for polling support. Patch 5
implements the adaptive polling logic, the pressure growth detection
optimized for short intervals, and hooks up write() and poll() on the
pressure files.
The patches were developed in collaboration with Johannes Weiner.
This patch (of 5):
Kernfs has a standardized poll/notification mechanism for waking all
pollers on all fds when a filesystem node changes. To allow polling for
custom events, add a .poll callback that can override the default.
This is in preparation for pollable cgroup pressure files which have
per-fd trigger configurations.
Link: http://lkml.kernel.org/r/20190124211518.244221-2-surenb@google.com
Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Signed-off-by: Suren Baghdasaryan <surenb@google.com>
Cc: Dennis Zhou <dennis@kernel.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Li Zefan <lizefan@huawei.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Tejun Heo <tj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2019-03-06 02:45:45 +03:00
|
|
|
struct poll_table_struct;
|
kernfs, sysfs, cgroup, intel_rdt: Support fs_context
Make kernfs support superblock creation/mount/remount with fs_context.
This requires that sysfs, cgroup and intel_rdt, which are built on kernfs,
be made to support fs_context also.
Notes:
(1) A kernfs_fs_context struct is created to wrap fs_context and the
kernfs mount parameters are moved in here (or are in fs_context).
(2) kernfs_mount{,_ns}() are made into kernfs_get_tree(). The extra
namespace tag parameter is passed in the context if desired
(3) kernfs_free_fs_context() is provided as a destructor for the
kernfs_fs_context struct, but for the moment it does nothing except
get called in the right places.
(4) sysfs doesn't wrap kernfs_fs_context since it has no parameters to
pass, but possibly this should be done anyway in case someone wants to
add a parameter in future.
(5) A cgroup_fs_context struct is created to wrap kernfs_fs_context and
the cgroup v1 and v2 mount parameters are all moved there.
(6) cgroup1 parameter parsing error messages are now handled by invalf(),
which allows userspace to collect them directly.
(7) cgroup1 parameter cleanup is now done in the context destructor rather
than in the mount/get_tree and remount functions.
Weirdies:
(*) cgroup_do_get_tree() calls cset_cgroup_from_root() with locks held,
but then uses the resulting pointer after dropping the locks. I'm
told this is okay and needs commenting.
(*) The cgroup refcount web. This really needs documenting.
(*) cgroup2 only has one root?
Add a suggestion from Thomas Gleixner in which the RDT enablement code is
placed into its own function.
[folded a leak fix from Andrey Vagin]
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
cc: Tejun Heo <tj@kernel.org>
cc: Li Zefan <lizefan@huawei.com>
cc: Johannes Weiner <hannes@cmpxchg.org>
cc: cgroups@vger.kernel.org
cc: fenghua.yu@intel.com
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2018-11-02 02:07:26 +03:00
|
|
|
struct fs_context;
|
2013-11-24 02:21:52 +04:00
|
|
|
|
kernfs, sysfs, cgroup, intel_rdt: Support fs_context
Make kernfs support superblock creation/mount/remount with fs_context.
This requires that sysfs, cgroup and intel_rdt, which are built on kernfs,
be made to support fs_context also.
Notes:
(1) A kernfs_fs_context struct is created to wrap fs_context and the
kernfs mount parameters are moved in here (or are in fs_context).
(2) kernfs_mount{,_ns}() are made into kernfs_get_tree(). The extra
namespace tag parameter is passed in the context if desired
(3) kernfs_free_fs_context() is provided as a destructor for the
kernfs_fs_context struct, but for the moment it does nothing except
get called in the right places.
(4) sysfs doesn't wrap kernfs_fs_context since it has no parameters to
pass, but possibly this should be done anyway in case someone wants to
add a parameter in future.
(5) A cgroup_fs_context struct is created to wrap kernfs_fs_context and
the cgroup v1 and v2 mount parameters are all moved there.
(6) cgroup1 parameter parsing error messages are now handled by invalf(),
which allows userspace to collect them directly.
(7) cgroup1 parameter cleanup is now done in the context destructor rather
than in the mount/get_tree and remount functions.
Weirdies:
(*) cgroup_do_get_tree() calls cset_cgroup_from_root() with locks held,
but then uses the resulting pointer after dropping the locks. I'm
told this is okay and needs commenting.
(*) The cgroup refcount web. This really needs documenting.
(*) cgroup2 only has one root?
Add a suggestion from Thomas Gleixner in which the RDT enablement code is
placed into its own function.
[folded a leak fix from Andrey Vagin]
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
cc: Tejun Heo <tj@kernel.org>
cc: Li Zefan <lizefan@huawei.com>
cc: Johannes Weiner <hannes@cmpxchg.org>
cc: cgroups@vger.kernel.org
cc: fenghua.yu@intel.com
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2018-11-02 02:07:26 +03:00
|
|
|
struct kernfs_fs_context;
|
2013-12-11 23:11:55 +04:00
|
|
|
struct kernfs_open_node;
|
|
|
|
struct kernfs_iattrs;
|
2013-11-30 02:18:32 +04:00
|
|
|
|
|
|
|
enum kernfs_node_type {
|
2013-12-11 23:11:56 +04:00
|
|
|
KERNFS_DIR = 0x0001,
|
|
|
|
KERNFS_FILE = 0x0002,
|
|
|
|
KERNFS_LINK = 0x0004,
|
2013-11-30 02:18:32 +04:00
|
|
|
};
|
|
|
|
|
2013-12-11 23:11:56 +04:00
|
|
|
#define KERNFS_TYPE_MASK 0x000f
|
|
|
|
#define KERNFS_FLAG_MASK ~KERNFS_TYPE_MASK
|
2013-11-30 02:18:32 +04:00
|
|
|
|
|
|
|
enum kernfs_node_flag {
|
2014-02-03 23:09:12 +04:00
|
|
|
KERNFS_ACTIVATED = 0x0010,
|
2013-12-11 23:11:56 +04:00
|
|
|
KERNFS_NS = 0x0020,
|
|
|
|
KERNFS_HAS_SEQ_SHOW = 0x0040,
|
|
|
|
KERNFS_HAS_MMAP = 0x0080,
|
|
|
|
KERNFS_LOCKDEP = 0x0100,
|
kernfs, sysfs, driver-core: implement kernfs_remove_self() and its wrappers
Sometimes it's necessary to implement a node which wants to delete
nodes including itself. This isn't straightforward because of kernfs
active reference. While a file operation is in progress, an active
reference is held and kernfs_remove() waits for all such references to
drain before completing. For a self-deleting node, this is a deadlock
as kernfs_remove() ends up waiting for an active reference that itself
is sitting on top of.
This currently is worked around in the sysfs layer using
sysfs_schedule_callback() which makes such removals asynchronous.
While it works, it's rather cumbersome and inherently breaks
synchronicity of the operation - the file operation which triggered
the operation may complete before the removal is finished (or even
started) and the removal may fail asynchronously. If a removal
operation is immmediately followed by another operation which expects
the specific name to be available (e.g. removal followed by rename
onto the same name), there's no way to make the latter operation
reliable.
The thing is there's no inherent reason for this to be asynchrnous.
All that's necessary to do this synchronous is a dedicated operation
which drops its own active ref and deactivates self. This patch
implements kernfs_remove_self() and its wrappers in sysfs and driver
core. kernfs_remove_self() is to be called from one of the file
operations, drops the active ref the task is holding, removes the self
node, and restores active ref to the dead node so that the ref is
balanced afterwards. __kernfs_remove() is updated so that it takes an
early exit if the target node is already fully removed so that the
active ref restored by kernfs_remove_self() after removal doesn't
confuse the deactivation path.
This makes implementing self-deleting nodes very easy. The normal
removal path doesn't even need to be changed to use
kernfs_remove_self() for the self-deleting node. The method can
invoke kernfs_remove_self() on itself before proceeding the normal
removal path. kernfs_remove() invoked on the node by the normal
deletion path will simply be ignored.
This will replace sysfs_schedule_callback(). A subtle feature of
sysfs_schedule_callback() is that it collapses multiple invocations -
even if multiple removals are triggered, the removal callback is run
only once. An equivalent effect can be achieved by testing the return
value of kernfs_remove_self() - only the one which gets %true return
value should proceed with actual deletion. All other instances of
kernfs_remove_self() will wait till the enclosing kernfs operation
which invoked the winning instance of kernfs_remove_self() finishes
and then return %false. This trivially makes all users of
kernfs_remove_self() automatically show correct synchronous behavior
even when there are multiple concurrent operations - all "echo 1 >
delete" instances will finish only after the whole operation is
completed by one of the instances.
Note that manipulation of active ref is implemented in separate public
functions - kernfs_[un]break_active_protection().
kernfs_remove_self() is the only user at the moment but this will be
used to cater to more complex cases.
v2: For !CONFIG_SYSFS, dummy version kernfs_remove_self() was missing
and sysfs_remove_file_self() had incorrect return type. Fix it.
Reported by kbuild test bot.
v3: kernfs_[un]break_active_protection() separated out from
kernfs_remove_self() and exposed as public API.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-03 23:03:01 +04:00
|
|
|
KERNFS_SUICIDAL = 0x0400,
|
|
|
|
KERNFS_SUICIDED = 0x0800,
|
2015-05-14 00:09:29 +03:00
|
|
|
KERNFS_EMPTY_DIR = 0x1000,
|
2016-12-27 22:49:03 +03:00
|
|
|
KERNFS_HAS_RELEASE = 0x2000,
|
2013-11-30 02:18:32 +04:00
|
|
|
};
|
|
|
|
|
2014-02-03 23:09:12 +04:00
|
|
|
/* @flags for kernfs_create_root() */
|
|
|
|
enum kernfs_root_flag {
|
2014-05-12 21:56:27 +04:00
|
|
|
/*
|
|
|
|
* kernfs_nodes are created in the deactivated state and invisible.
|
|
|
|
* They require explicit kernfs_activate() to become visible. This
|
|
|
|
* can be used to make related nodes become visible atomically
|
|
|
|
* after all nodes are created successfully.
|
|
|
|
*/
|
|
|
|
KERNFS_ROOT_CREATE_DEACTIVATED = 0x0001,
|
|
|
|
|
|
|
|
/*
|
|
|
|
* For regular flies, if the opener has CAP_DAC_OVERRIDE, open(2)
|
|
|
|
* succeeds regardless of the RW permissions. sysfs had an extra
|
|
|
|
* layer of enforcement where open(2) fails with -EACCES regardless
|
|
|
|
* of CAP_DAC_OVERRIDE if the permission doesn't have the
|
|
|
|
* respective read or write access at all (none of S_IRUGO or
|
|
|
|
* S_IWUGO) or the respective operation isn't implemented. The
|
|
|
|
* following flag enables that behavior.
|
|
|
|
*/
|
|
|
|
KERNFS_ROOT_EXTRA_OPEN_PERM_CHECK = 0x0002,
|
2017-07-12 21:49:51 +03:00
|
|
|
|
|
|
|
/*
|
|
|
|
* The filesystem supports exportfs operation, so userspace can use
|
|
|
|
* fhandle to access nodes of the fs.
|
|
|
|
*/
|
|
|
|
KERNFS_ROOT_SUPPORT_EXPORTOP = 0x0004,
|
2014-02-03 23:09:12 +04:00
|
|
|
};
|
|
|
|
|
2013-12-11 23:11:53 +04:00
|
|
|
/* type-specific structures for kernfs_node union members */
|
|
|
|
struct kernfs_elem_dir {
|
2013-11-30 02:18:32 +04:00
|
|
|
unsigned long subdirs;
|
2013-12-11 23:11:54 +04:00
|
|
|
/* children rbtree starts here and goes through kn->rb */
|
2013-11-30 02:18:32 +04:00
|
|
|
struct rb_root children;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* The kernfs hierarchy this directory belongs to. This fits
|
2013-12-11 23:11:53 +04:00
|
|
|
* better directly in kernfs_node but is here to save space.
|
2013-11-30 02:18:32 +04:00
|
|
|
*/
|
|
|
|
struct kernfs_root *root;
|
|
|
|
};
|
|
|
|
|
2013-12-11 23:11:53 +04:00
|
|
|
struct kernfs_elem_symlink {
|
|
|
|
struct kernfs_node *target_kn;
|
2013-11-30 02:18:32 +04:00
|
|
|
};
|
|
|
|
|
2013-12-11 23:11:53 +04:00
|
|
|
struct kernfs_elem_attr {
|
2013-11-30 02:18:32 +04:00
|
|
|
const struct kernfs_ops *ops;
|
2013-12-11 23:11:55 +04:00
|
|
|
struct kernfs_open_node *open;
|
2013-11-30 02:18:32 +04:00
|
|
|
loff_t size;
|
2014-07-02 00:41:03 +04:00
|
|
|
struct kernfs_node *notify_next; /* for kernfs_notify() */
|
2013-11-30 02:18:32 +04:00
|
|
|
};
|
|
|
|
|
2017-07-12 21:49:50 +03:00
|
|
|
/* represent a kernfs node */
|
|
|
|
union kernfs_node_id {
|
|
|
|
struct {
|
2017-07-12 21:49:51 +03:00
|
|
|
/*
|
|
|
|
* blktrace will export this struct as a simplified 'struct
|
|
|
|
* fid' (which is a big data struction), so userspace can use
|
|
|
|
* it to find kernfs node. The layout must match the first two
|
|
|
|
* fields of 'struct fid' exactly.
|
|
|
|
*/
|
2017-07-12 21:49:50 +03:00
|
|
|
u32 ino;
|
|
|
|
u32 generation;
|
|
|
|
};
|
|
|
|
u64 id;
|
|
|
|
};
|
|
|
|
|
2013-11-30 02:18:32 +04:00
|
|
|
/*
|
2013-12-11 23:11:53 +04:00
|
|
|
* kernfs_node - the building block of kernfs hierarchy. Each and every
|
|
|
|
* kernfs node is represented by single kernfs_node. Most fields are
|
2013-11-30 02:18:32 +04:00
|
|
|
* private to kernfs and shouldn't be accessed directly by kernfs users.
|
|
|
|
*
|
2013-12-11 23:11:53 +04:00
|
|
|
* As long as s_count reference is held, the kernfs_node itself is
|
|
|
|
* accessible. Dereferencing elem or any other outer entity requires
|
|
|
|
* active reference.
|
2013-11-30 02:18:32 +04:00
|
|
|
*/
|
2013-12-11 23:11:53 +04:00
|
|
|
struct kernfs_node {
|
2013-12-11 23:11:54 +04:00
|
|
|
atomic_t count;
|
|
|
|
atomic_t active;
|
2013-11-30 02:18:32 +04:00
|
|
|
#ifdef CONFIG_DEBUG_LOCK_ALLOC
|
|
|
|
struct lockdep_map dep_map;
|
|
|
|
#endif
|
2014-02-07 22:32:07 +04:00
|
|
|
/*
|
|
|
|
* Use kernfs_get_parent() and kernfs_name/path() instead of
|
|
|
|
* accessing the following two fields directly. If the node is
|
|
|
|
* never moved to a different parent, it is safe to access the
|
|
|
|
* parent directly.
|
|
|
|
*/
|
2013-12-11 23:11:54 +04:00
|
|
|
struct kernfs_node *parent;
|
|
|
|
const char *name;
|
2013-11-30 02:18:32 +04:00
|
|
|
|
2013-12-11 23:11:54 +04:00
|
|
|
struct rb_node rb;
|
2013-11-30 02:18:32 +04:00
|
|
|
|
2013-12-11 23:11:54 +04:00
|
|
|
const void *ns; /* namespace tag */
|
2014-01-14 02:09:38 +04:00
|
|
|
unsigned int hash; /* ns + name hash */
|
2013-11-30 02:18:32 +04:00
|
|
|
union {
|
2013-12-11 23:11:54 +04:00
|
|
|
struct kernfs_elem_dir dir;
|
|
|
|
struct kernfs_elem_symlink symlink;
|
|
|
|
struct kernfs_elem_attr attr;
|
2013-11-30 02:18:32 +04:00
|
|
|
};
|
|
|
|
|
|
|
|
void *priv;
|
|
|
|
|
2017-07-12 21:49:50 +03:00
|
|
|
union kernfs_node_id id;
|
2013-12-11 23:11:54 +04:00
|
|
|
unsigned short flags;
|
|
|
|
umode_t mode;
|
2013-12-11 23:11:55 +04:00
|
|
|
struct kernfs_iattrs *iattr;
|
2013-11-30 02:18:32 +04:00
|
|
|
};
|
2013-11-24 18:54:58 +04:00
|
|
|
|
2013-12-12 01:03:00 +04:00
|
|
|
/*
|
2014-02-03 23:09:09 +04:00
|
|
|
* kernfs_syscall_ops may be specified on kernfs_create_root() to support
|
|
|
|
* syscalls. These optional callbacks are invoked on the matching syscalls
|
|
|
|
* and can perform any kernfs operations which don't necessarily have to be
|
|
|
|
* the exact operation requested. An active reference is held for each
|
|
|
|
* kernfs_node parameter.
|
2013-12-12 01:03:00 +04:00
|
|
|
*/
|
2014-02-03 23:09:09 +04:00
|
|
|
struct kernfs_syscall_ops {
|
2014-02-03 23:09:10 +04:00
|
|
|
int (*show_options)(struct seq_file *sf, struct kernfs_root *root);
|
|
|
|
|
2013-12-12 01:03:00 +04:00
|
|
|
int (*mkdir)(struct kernfs_node *parent, const char *name,
|
|
|
|
umode_t mode);
|
|
|
|
int (*rmdir)(struct kernfs_node *kn);
|
|
|
|
int (*rename)(struct kernfs_node *kn, struct kernfs_node *new_parent,
|
|
|
|
const char *new_name);
|
cgroup, kernfs: make mountinfo show properly scoped path for cgroup namespaces
Patch summary:
When showing a cgroupfs entry in mountinfo, show the path of the mount
root dentry relative to the reader's cgroup namespace root.
Short explanation (courtesy of mkerrisk):
If we create a new cgroup namespace, then we want both /proc/self/cgroup
and /proc/self/mountinfo to show cgroup paths that are correctly
virtualized with respect to the cgroup mount point. Previous to this
patch, /proc/self/cgroup shows the right info, but /proc/self/mountinfo
does not.
Long version:
When a uid 0 task which is in freezer cgroup /a/b, unshares a new cgroup
namespace, and then mounts a new instance of the freezer cgroup, the new
mount will be rooted at /a/b. The root dentry field of the mountinfo
entry will show '/a/b'.
cat > /tmp/do1 << EOF
mount -t cgroup -o freezer freezer /mnt
grep freezer /proc/self/mountinfo
EOF
unshare -Gm bash /tmp/do1
> 330 160 0:34 / /sys/fs/cgroup/freezer rw,nosuid,nodev,noexec,relatime - cgroup cgroup rw,freezer
> 355 133 0:34 /a/b /mnt rw,relatime - cgroup freezer rw,freezer
The task's freezer cgroup entry in /proc/self/cgroup will simply show
'/':
grep freezer /proc/self/cgroup
9:freezer:/
If instead the same task simply bind mounts the /a/b cgroup directory,
the resulting mountinfo entry will again show /a/b for the dentry root.
However in this case the task will find its own cgroup at /mnt/a/b,
not at /mnt:
mount --bind /sys/fs/cgroup/freezer/a/b /mnt
130 25 0:34 /a/b /mnt rw,nosuid,nodev,noexec,relatime shared:21 - cgroup cgroup rw,freezer
In other words, there is no way for the task to know, based on what is
in mountinfo, which cgroup directory is its own.
Example (by mkerrisk):
First, a little script to save some typing and verbiage:
echo -e "\t/proc/self/cgroup:\t$(cat /proc/self/cgroup | grep freezer)"
cat /proc/self/mountinfo | grep freezer |
awk '{print "\tmountinfo:\t\t" $4 "\t" $5}'
Create cgroup, place this shell into the cgroup, and look at the state
of the /proc files:
2653
2653 # Our shell
14254 # cat(1)
/proc/self/cgroup: 10:freezer:/a/b
mountinfo: / /sys/fs/cgroup/freezer
Create a shell in new cgroup and mount namespaces. The act of creating
a new cgroup namespace causes the process's current cgroups directories
to become its cgroup root directories. (Here, I'm using my own version
of the "unshare" utility, which takes the same options as the util-linux
version):
Look at the state of the /proc files:
/proc/self/cgroup: 10:freezer:/
mountinfo: / /sys/fs/cgroup/freezer
The third entry in /proc/self/cgroup (the pathname of the cgroup inside
the hierarchy) is correctly virtualized w.r.t. the cgroup namespace, which
is rooted at /a/b in the outer namespace.
However, the info in /proc/self/mountinfo is not for this cgroup
namespace, since we are seeing a duplicate of the mount from the
old mount namespace, and the info there does not correspond to the
new cgroup namespace. However, trying to create a new mount still
doesn't show us the right information in mountinfo:
# propagating to other mountns
/proc/self/cgroup: 7:freezer:/
mountinfo: /a/b /mnt/freezer
The act of creating a new cgroup namespace caused the process's
current freezer directory, "/a/b", to become its cgroup freezer root
directory. In other words, the pathname directory of the directory
within the newly mounted cgroup filesystem should be "/",
but mountinfo wrongly shows us "/a/b". The consequence of this is
that the process in the cgroup namespace cannot correctly construct
the pathname of its cgroup root directory from the information in
/proc/PID/mountinfo.
With this patch, the dentry root field in mountinfo is shown relative
to the reader's cgroup namespace. So the same steps as above:
/proc/self/cgroup: 10:freezer:/a/b
mountinfo: / /sys/fs/cgroup/freezer
/proc/self/cgroup: 10:freezer:/
mountinfo: /../.. /sys/fs/cgroup/freezer
/proc/self/cgroup: 10:freezer:/
mountinfo: / /mnt/freezer
cgroup.clone_children freezer.parent_freezing freezer.state tasks
cgroup.procs freezer.self_freezing notify_on_release
3164
2653 # First shell that placed in this cgroup
3164 # Shell started by 'unshare'
14197 # cat(1)
Signed-off-by: Serge Hallyn <serge.hallyn@ubuntu.com>
Tested-by: Michael Kerrisk <mtk.manpages@gmail.com>
Acked-by: Michael Kerrisk <mtk.manpages@gmail.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
2016-05-09 17:59:55 +03:00
|
|
|
int (*show_path)(struct seq_file *sf, struct kernfs_node *kn,
|
|
|
|
struct kernfs_root *root);
|
2013-12-12 01:03:00 +04:00
|
|
|
};
|
|
|
|
|
2013-11-28 23:54:40 +04:00
|
|
|
struct kernfs_root {
|
|
|
|
/* published fields */
|
2013-12-11 23:11:53 +04:00
|
|
|
struct kernfs_node *kn;
|
2014-02-03 23:09:12 +04:00
|
|
|
unsigned int flags; /* KERNFS_ROOT_* flags */
|
2013-11-28 23:54:41 +04:00
|
|
|
|
|
|
|
/* private fields, do not use outside kernfs proper */
|
2017-07-12 21:49:46 +03:00
|
|
|
struct idr ino_idr;
|
2017-07-12 21:49:47 +03:00
|
|
|
u32 next_generation;
|
2014-02-03 23:09:09 +04:00
|
|
|
struct kernfs_syscall_ops *syscall_ops;
|
2014-04-09 19:07:30 +04:00
|
|
|
|
|
|
|
/* list of kernfs_super_info of this root, protected by kernfs_mutex */
|
|
|
|
struct list_head supers;
|
|
|
|
|
2014-02-03 23:02:55 +04:00
|
|
|
wait_queue_head_t deactivate_waitq;
|
2013-11-28 23:54:40 +04:00
|
|
|
};
|
|
|
|
|
2013-12-11 23:11:55 +04:00
|
|
|
struct kernfs_open_file {
|
2013-11-28 23:54:20 +04:00
|
|
|
/* published fields */
|
2013-12-11 23:11:53 +04:00
|
|
|
struct kernfs_node *kn;
|
2013-11-28 23:54:20 +04:00
|
|
|
struct file *file;
|
2016-12-27 22:49:03 +03:00
|
|
|
struct seq_file *seq_file;
|
2014-02-03 23:09:14 +04:00
|
|
|
void *priv;
|
2013-11-28 23:54:20 +04:00
|
|
|
|
|
|
|
/* private fields, do not use outside kernfs proper */
|
|
|
|
struct mutex mutex;
|
2016-03-31 13:45:06 +03:00
|
|
|
struct mutex prealloc_mutex;
|
2013-11-28 23:54:20 +04:00
|
|
|
int event;
|
|
|
|
struct list_head list;
|
2014-10-13 09:41:28 +04:00
|
|
|
char *prealloc_buf;
|
2013-11-28 23:54:20 +04:00
|
|
|
|
2014-03-05 00:38:46 +04:00
|
|
|
size_t atomic_write_len;
|
2016-12-27 22:49:02 +03:00
|
|
|
bool mmapped:1;
|
2016-12-27 22:49:03 +03:00
|
|
|
bool released:1;
|
2013-11-28 23:54:20 +04:00
|
|
|
const struct vm_operations_struct *vm_ops;
|
|
|
|
};
|
|
|
|
|
2013-11-28 23:54:21 +04:00
|
|
|
struct kernfs_ops {
|
2016-12-27 22:49:03 +03:00
|
|
|
/*
|
|
|
|
* Optional open/release methods. Both are called with
|
|
|
|
* @of->seq_file populated.
|
|
|
|
*/
|
|
|
|
int (*open)(struct kernfs_open_file *of);
|
|
|
|
void (*release)(struct kernfs_open_file *of);
|
|
|
|
|
2013-11-28 23:54:21 +04:00
|
|
|
/*
|
|
|
|
* Read is handled by either seq_file or raw_read().
|
|
|
|
*
|
2013-11-28 23:54:26 +04:00
|
|
|
* If seq_show() is present, seq_file path is active. Other seq
|
|
|
|
* operations are optional and if not implemented, the behavior is
|
|
|
|
* equivalent to single_open(). @sf->private points to the
|
2013-12-11 23:11:55 +04:00
|
|
|
* associated kernfs_open_file.
|
2013-11-28 23:54:21 +04:00
|
|
|
*
|
|
|
|
* read() is bounced through kernel buffer and a read larger than
|
|
|
|
* PAGE_SIZE results in partial operation of PAGE_SIZE.
|
|
|
|
*/
|
|
|
|
int (*seq_show)(struct seq_file *sf, void *v);
|
2013-11-28 23:54:26 +04:00
|
|
|
|
|
|
|
void *(*seq_start)(struct seq_file *sf, loff_t *ppos);
|
|
|
|
void *(*seq_next)(struct seq_file *sf, void *v, loff_t *ppos);
|
|
|
|
void (*seq_stop)(struct seq_file *sf, void *v);
|
2013-11-28 23:54:21 +04:00
|
|
|
|
2013-12-11 23:11:55 +04:00
|
|
|
ssize_t (*read)(struct kernfs_open_file *of, char *buf, size_t bytes,
|
2013-11-28 23:54:21 +04:00
|
|
|
loff_t off);
|
|
|
|
|
|
|
|
/*
|
2014-02-03 23:09:13 +04:00
|
|
|
* write() is bounced through kernel buffer. If atomic_write_len
|
|
|
|
* is not set, a write larger than PAGE_SIZE results in partial
|
|
|
|
* operations of PAGE_SIZE chunks. If atomic_write_len is set,
|
|
|
|
* writes upto the specified size are executed atomically but
|
|
|
|
* larger ones are rejected with -E2BIG.
|
2013-11-28 23:54:21 +04:00
|
|
|
*/
|
2014-02-03 23:09:13 +04:00
|
|
|
size_t atomic_write_len;
|
2014-10-13 09:41:28 +04:00
|
|
|
/*
|
|
|
|
* "prealloc" causes a buffer to be allocated at open for
|
|
|
|
* all read/write requests. As ->seq_show uses seq_read()
|
|
|
|
* which does its own allocation, it is incompatible with
|
|
|
|
* ->prealloc. Provide ->read and ->write with ->prealloc.
|
|
|
|
*/
|
|
|
|
bool prealloc;
|
2013-12-11 23:11:55 +04:00
|
|
|
ssize_t (*write)(struct kernfs_open_file *of, char *buf, size_t bytes,
|
2013-11-28 23:54:21 +04:00
|
|
|
loff_t off);
|
|
|
|
|
fs: kernfs: add poll file operation
Patch series "psi: pressure stall monitors", v3.
Android is adopting psi to detect and remedy memory pressure that
results in stuttering and decreased responsiveness on mobile devices.
Psi gives us the stall information, but because we're dealing with
latencies in the millisecond range, periodically reading the pressure
files to detect stalls in a timely fashion is not feasible. Psi also
doesn't aggregate its averages at a high enough frequency right now.
This patch series extends the psi interface such that users can
configure sensitive latency thresholds and use poll() and friends to be
notified when these are breached.
As high-frequency aggregation is costly, it implements an aggregation
method that is optimized for fast, short-interval averaging, and makes
the aggregation frequency adaptive, such that high-frequency updates
only happen while monitored stall events are actively occurring.
With these patches applied, Android can monitor for, and ward off,
mounting memory shortages before they cause problems for the user. For
example, using memory stall monitors in userspace low memory killer
daemon (lmkd) we can detect mounting pressure and kill less important
processes before device becomes visibly sluggish.
In our memory stress testing psi memory monitors produce roughly 10x
less false positives compared to vmpressure signals. Having ability to
specify multiple triggers for the same psi metric allows other parts of
Android framework to monitor memory state of the device and act
accordingly.
The new interface is straightforward. The user opens one of the
pressure files for writing and writes a trigger description into the
file descriptor that defines the stall state - some or full, and the
maximum stall time over a given window of time. E.g.:
/* Signal when stall time exceeds 100ms of a 1s window */
char trigger[] = "full 100000 1000000";
fd = open("/proc/pressure/memory");
write(fd, trigger, sizeof(trigger));
while (poll() >= 0) {
...
}
close(fd);
When the monitored stall state is entered, psi adapts its aggregation
frequency according to what the configured time window requires in order
to emit event signals in a timely fashion. Once the stalling subsides,
aggregation reverts back to normal.
The trigger is associated with the open file descriptor. To stop
monitoring, the user only needs to close the file descriptor and the
trigger is discarded.
Patches 1-4 prepare the psi code for polling support. Patch 5
implements the adaptive polling logic, the pressure growth detection
optimized for short intervals, and hooks up write() and poll() on the
pressure files.
The patches were developed in collaboration with Johannes Weiner.
This patch (of 5):
Kernfs has a standardized poll/notification mechanism for waking all
pollers on all fds when a filesystem node changes. To allow polling for
custom events, add a .poll callback that can override the default.
This is in preparation for pollable cgroup pressure files which have
per-fd trigger configurations.
Link: http://lkml.kernel.org/r/20190124211518.244221-2-surenb@google.com
Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Signed-off-by: Suren Baghdasaryan <surenb@google.com>
Cc: Dennis Zhou <dennis@kernel.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Li Zefan <lizefan@huawei.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Tejun Heo <tj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2019-03-06 02:45:45 +03:00
|
|
|
__poll_t (*poll)(struct kernfs_open_file *of,
|
|
|
|
struct poll_table_struct *pt);
|
|
|
|
|
2013-12-11 23:11:55 +04:00
|
|
|
int (*mmap)(struct kernfs_open_file *of, struct vm_area_struct *vma);
|
2013-11-28 23:54:29 +04:00
|
|
|
|
|
|
|
#ifdef CONFIG_DEBUG_LOCK_ALLOC
|
|
|
|
struct lock_class_key lockdep_key;
|
|
|
|
#endif
|
2013-11-28 23:54:21 +04:00
|
|
|
};
|
|
|
|
|
kernfs, sysfs, cgroup, intel_rdt: Support fs_context
Make kernfs support superblock creation/mount/remount with fs_context.
This requires that sysfs, cgroup and intel_rdt, which are built on kernfs,
be made to support fs_context also.
Notes:
(1) A kernfs_fs_context struct is created to wrap fs_context and the
kernfs mount parameters are moved in here (or are in fs_context).
(2) kernfs_mount{,_ns}() are made into kernfs_get_tree(). The extra
namespace tag parameter is passed in the context if desired
(3) kernfs_free_fs_context() is provided as a destructor for the
kernfs_fs_context struct, but for the moment it does nothing except
get called in the right places.
(4) sysfs doesn't wrap kernfs_fs_context since it has no parameters to
pass, but possibly this should be done anyway in case someone wants to
add a parameter in future.
(5) A cgroup_fs_context struct is created to wrap kernfs_fs_context and
the cgroup v1 and v2 mount parameters are all moved there.
(6) cgroup1 parameter parsing error messages are now handled by invalf(),
which allows userspace to collect them directly.
(7) cgroup1 parameter cleanup is now done in the context destructor rather
than in the mount/get_tree and remount functions.
Weirdies:
(*) cgroup_do_get_tree() calls cset_cgroup_from_root() with locks held,
but then uses the resulting pointer after dropping the locks. I'm
told this is okay and needs commenting.
(*) The cgroup refcount web. This really needs documenting.
(*) cgroup2 only has one root?
Add a suggestion from Thomas Gleixner in which the RDT enablement code is
placed into its own function.
[folded a leak fix from Andrey Vagin]
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
cc: Tejun Heo <tj@kernel.org>
cc: Li Zefan <lizefan@huawei.com>
cc: Johannes Weiner <hannes@cmpxchg.org>
cc: cgroups@vger.kernel.org
cc: fenghua.yu@intel.com
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2018-11-02 02:07:26 +03:00
|
|
|
/*
|
|
|
|
* The kernfs superblock creation/mount parameter context.
|
|
|
|
*/
|
|
|
|
struct kernfs_fs_context {
|
|
|
|
struct kernfs_root *root; /* Root of the hierarchy being mounted */
|
|
|
|
void *ns_tag; /* Namespace tag of the mount (or NULL) */
|
|
|
|
unsigned long magic; /* File system specific magic number */
|
|
|
|
|
|
|
|
/* The following are set/used by kernfs_mount() */
|
|
|
|
bool new_sb_created; /* Set to T if we allocated a new sb */
|
|
|
|
};
|
|
|
|
|
2014-02-03 23:09:17 +04:00
|
|
|
#ifdef CONFIG_KERNFS
|
2013-11-24 02:21:49 +04:00
|
|
|
|
2013-12-11 23:11:56 +04:00
|
|
|
static inline enum kernfs_node_type kernfs_type(struct kernfs_node *kn)
|
2013-11-30 02:18:32 +04:00
|
|
|
{
|
2013-12-11 23:11:56 +04:00
|
|
|
return kn->flags & KERNFS_TYPE_MASK;
|
2013-11-30 02:18:32 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* kernfs_enable_ns - enable namespace under a directory
|
2013-12-11 23:11:53 +04:00
|
|
|
* @kn: directory of interest, should be empty
|
2013-11-30 02:18:32 +04:00
|
|
|
*
|
2013-12-11 23:11:53 +04:00
|
|
|
* This is to be called right after @kn is created to enable namespace
|
|
|
|
* under it. All children of @kn must have non-NULL namespace tags and
|
2013-11-30 02:18:32 +04:00
|
|
|
* only the ones which match the super_block's tag will be visible.
|
|
|
|
*/
|
2013-12-11 23:11:53 +04:00
|
|
|
static inline void kernfs_enable_ns(struct kernfs_node *kn)
|
2013-11-30 02:18:32 +04:00
|
|
|
{
|
2013-12-11 23:11:56 +04:00
|
|
|
WARN_ON_ONCE(kernfs_type(kn) != KERNFS_DIR);
|
2013-12-11 23:11:54 +04:00
|
|
|
WARN_ON_ONCE(!RB_EMPTY_ROOT(&kn->dir.children));
|
2013-12-11 23:11:56 +04:00
|
|
|
kn->flags |= KERNFS_NS;
|
2013-11-30 02:18:32 +04:00
|
|
|
}
|
|
|
|
|
2013-11-30 02:19:09 +04:00
|
|
|
/**
|
|
|
|
* kernfs_ns_enabled - test whether namespace is enabled
|
2013-12-11 23:11:53 +04:00
|
|
|
* @kn: the node to test
|
2013-11-30 02:19:09 +04:00
|
|
|
*
|
|
|
|
* Test whether namespace filtering is enabled for the children of @ns.
|
|
|
|
*/
|
2013-12-11 23:11:53 +04:00
|
|
|
static inline bool kernfs_ns_enabled(struct kernfs_node *kn)
|
2013-11-30 02:19:09 +04:00
|
|
|
{
|
2013-12-11 23:11:56 +04:00
|
|
|
return kn->flags & KERNFS_NS;
|
2013-11-30 02:19:09 +04:00
|
|
|
}
|
|
|
|
|
2014-02-07 22:32:07 +04:00
|
|
|
int kernfs_name(struct kernfs_node *kn, char *buf, size_t buflen);
|
2016-01-29 11:54:04 +03:00
|
|
|
int kernfs_path_from_node(struct kernfs_node *root_kn, struct kernfs_node *kn,
|
|
|
|
char *buf, size_t buflen);
|
2014-02-07 22:32:07 +04:00
|
|
|
void pr_cont_kernfs_name(struct kernfs_node *kn);
|
|
|
|
void pr_cont_kernfs_path(struct kernfs_node *kn);
|
|
|
|
struct kernfs_node *kernfs_get_parent(struct kernfs_node *kn);
|
2013-12-11 23:11:53 +04:00
|
|
|
struct kernfs_node *kernfs_find_and_get_ns(struct kernfs_node *parent,
|
|
|
|
const char *name, const void *ns);
|
2015-11-20 23:55:52 +03:00
|
|
|
struct kernfs_node *kernfs_walk_and_get_ns(struct kernfs_node *parent,
|
|
|
|
const char *path, const void *ns);
|
2013-12-11 23:11:53 +04:00
|
|
|
void kernfs_get(struct kernfs_node *kn);
|
|
|
|
void kernfs_put(struct kernfs_node *kn);
|
2013-11-28 23:54:30 +04:00
|
|
|
|
2014-02-03 23:09:15 +04:00
|
|
|
struct kernfs_node *kernfs_node_from_dentry(struct dentry *dentry);
|
|
|
|
struct kernfs_root *kernfs_root_from_sb(struct super_block *sb);
|
2015-06-18 23:54:28 +03:00
|
|
|
struct inode *kernfs_get_inode(struct super_block *sb, struct kernfs_node *kn);
|
2014-02-03 23:09:15 +04:00
|
|
|
|
2016-01-29 11:54:08 +03:00
|
|
|
struct dentry *kernfs_node_dentry(struct kernfs_node *kn,
|
|
|
|
struct super_block *sb);
|
2014-02-03 23:09:09 +04:00
|
|
|
struct kernfs_root *kernfs_create_root(struct kernfs_syscall_ops *scops,
|
2014-02-03 23:09:12 +04:00
|
|
|
unsigned int flags, void *priv);
|
2013-11-28 23:54:40 +04:00
|
|
|
void kernfs_destroy_root(struct kernfs_root *root);
|
|
|
|
|
2013-12-11 23:11:53 +04:00
|
|
|
struct kernfs_node *kernfs_create_dir_ns(struct kernfs_node *parent,
|
2013-12-12 01:02:55 +04:00
|
|
|
const char *name, umode_t mode,
|
2018-07-21 00:56:47 +03:00
|
|
|
kuid_t uid, kgid_t gid,
|
2013-12-12 01:02:55 +04:00
|
|
|
void *priv, const void *ns);
|
2015-05-14 00:09:29 +03:00
|
|
|
struct kernfs_node *kernfs_create_empty_dir(struct kernfs_node *parent,
|
|
|
|
const char *name);
|
2013-12-12 01:02:57 +04:00
|
|
|
struct kernfs_node *__kernfs_create_file(struct kernfs_node *parent,
|
2018-07-21 00:56:47 +03:00
|
|
|
const char *name, umode_t mode,
|
|
|
|
kuid_t uid, kgid_t gid,
|
|
|
|
loff_t size,
|
2013-12-12 01:02:57 +04:00
|
|
|
const struct kernfs_ops *ops,
|
|
|
|
void *priv, const void *ns,
|
|
|
|
struct lock_class_key *key);
|
2013-12-11 23:11:53 +04:00
|
|
|
struct kernfs_node *kernfs_create_link(struct kernfs_node *parent,
|
|
|
|
const char *name,
|
|
|
|
struct kernfs_node *target);
|
2014-02-03 23:09:12 +04:00
|
|
|
void kernfs_activate(struct kernfs_node *kn);
|
2013-12-11 23:11:53 +04:00
|
|
|
void kernfs_remove(struct kernfs_node *kn);
|
kernfs, sysfs, driver-core: implement kernfs_remove_self() and its wrappers
Sometimes it's necessary to implement a node which wants to delete
nodes including itself. This isn't straightforward because of kernfs
active reference. While a file operation is in progress, an active
reference is held and kernfs_remove() waits for all such references to
drain before completing. For a self-deleting node, this is a deadlock
as kernfs_remove() ends up waiting for an active reference that itself
is sitting on top of.
This currently is worked around in the sysfs layer using
sysfs_schedule_callback() which makes such removals asynchronous.
While it works, it's rather cumbersome and inherently breaks
synchronicity of the operation - the file operation which triggered
the operation may complete before the removal is finished (or even
started) and the removal may fail asynchronously. If a removal
operation is immmediately followed by another operation which expects
the specific name to be available (e.g. removal followed by rename
onto the same name), there's no way to make the latter operation
reliable.
The thing is there's no inherent reason for this to be asynchrnous.
All that's necessary to do this synchronous is a dedicated operation
which drops its own active ref and deactivates self. This patch
implements kernfs_remove_self() and its wrappers in sysfs and driver
core. kernfs_remove_self() is to be called from one of the file
operations, drops the active ref the task is holding, removes the self
node, and restores active ref to the dead node so that the ref is
balanced afterwards. __kernfs_remove() is updated so that it takes an
early exit if the target node is already fully removed so that the
active ref restored by kernfs_remove_self() after removal doesn't
confuse the deactivation path.
This makes implementing self-deleting nodes very easy. The normal
removal path doesn't even need to be changed to use
kernfs_remove_self() for the self-deleting node. The method can
invoke kernfs_remove_self() on itself before proceeding the normal
removal path. kernfs_remove() invoked on the node by the normal
deletion path will simply be ignored.
This will replace sysfs_schedule_callback(). A subtle feature of
sysfs_schedule_callback() is that it collapses multiple invocations -
even if multiple removals are triggered, the removal callback is run
only once. An equivalent effect can be achieved by testing the return
value of kernfs_remove_self() - only the one which gets %true return
value should proceed with actual deletion. All other instances of
kernfs_remove_self() will wait till the enclosing kernfs operation
which invoked the winning instance of kernfs_remove_self() finishes
and then return %false. This trivially makes all users of
kernfs_remove_self() automatically show correct synchronous behavior
even when there are multiple concurrent operations - all "echo 1 >
delete" instances will finish only after the whole operation is
completed by one of the instances.
Note that manipulation of active ref is implemented in separate public
functions - kernfs_[un]break_active_protection().
kernfs_remove_self() is the only user at the moment but this will be
used to cater to more complex cases.
v2: For !CONFIG_SYSFS, dummy version kernfs_remove_self() was missing
and sysfs_remove_file_self() had incorrect return type. Fix it.
Reported by kbuild test bot.
v3: kernfs_[un]break_active_protection() separated out from
kernfs_remove_self() and exposed as public API.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-03 23:03:01 +04:00
|
|
|
void kernfs_break_active_protection(struct kernfs_node *kn);
|
|
|
|
void kernfs_unbreak_active_protection(struct kernfs_node *kn);
|
|
|
|
bool kernfs_remove_self(struct kernfs_node *kn);
|
2013-12-11 23:11:53 +04:00
|
|
|
int kernfs_remove_by_name_ns(struct kernfs_node *parent, const char *name,
|
2013-11-24 02:21:49 +04:00
|
|
|
const void *ns);
|
2013-12-11 23:11:53 +04:00
|
|
|
int kernfs_rename_ns(struct kernfs_node *kn, struct kernfs_node *new_parent,
|
2013-11-24 02:21:51 +04:00
|
|
|
const char *new_name, const void *new_ns);
|
2013-12-11 23:11:53 +04:00
|
|
|
int kernfs_setattr(struct kernfs_node *kn, const struct iattr *iattr);
|
fs: kernfs: add poll file operation
Patch series "psi: pressure stall monitors", v3.
Android is adopting psi to detect and remedy memory pressure that
results in stuttering and decreased responsiveness on mobile devices.
Psi gives us the stall information, but because we're dealing with
latencies in the millisecond range, periodically reading the pressure
files to detect stalls in a timely fashion is not feasible. Psi also
doesn't aggregate its averages at a high enough frequency right now.
This patch series extends the psi interface such that users can
configure sensitive latency thresholds and use poll() and friends to be
notified when these are breached.
As high-frequency aggregation is costly, it implements an aggregation
method that is optimized for fast, short-interval averaging, and makes
the aggregation frequency adaptive, such that high-frequency updates
only happen while monitored stall events are actively occurring.
With these patches applied, Android can monitor for, and ward off,
mounting memory shortages before they cause problems for the user. For
example, using memory stall monitors in userspace low memory killer
daemon (lmkd) we can detect mounting pressure and kill less important
processes before device becomes visibly sluggish.
In our memory stress testing psi memory monitors produce roughly 10x
less false positives compared to vmpressure signals. Having ability to
specify multiple triggers for the same psi metric allows other parts of
Android framework to monitor memory state of the device and act
accordingly.
The new interface is straightforward. The user opens one of the
pressure files for writing and writes a trigger description into the
file descriptor that defines the stall state - some or full, and the
maximum stall time over a given window of time. E.g.:
/* Signal when stall time exceeds 100ms of a 1s window */
char trigger[] = "full 100000 1000000";
fd = open("/proc/pressure/memory");
write(fd, trigger, sizeof(trigger));
while (poll() >= 0) {
...
}
close(fd);
When the monitored stall state is entered, psi adapts its aggregation
frequency according to what the configured time window requires in order
to emit event signals in a timely fashion. Once the stalling subsides,
aggregation reverts back to normal.
The trigger is associated with the open file descriptor. To stop
monitoring, the user only needs to close the file descriptor and the
trigger is discarded.
Patches 1-4 prepare the psi code for polling support. Patch 5
implements the adaptive polling logic, the pressure growth detection
optimized for short intervals, and hooks up write() and poll() on the
pressure files.
The patches were developed in collaboration with Johannes Weiner.
This patch (of 5):
Kernfs has a standardized poll/notification mechanism for waking all
pollers on all fds when a filesystem node changes. To allow polling for
custom events, add a .poll callback that can override the default.
This is in preparation for pollable cgroup pressure files which have
per-fd trigger configurations.
Link: http://lkml.kernel.org/r/20190124211518.244221-2-surenb@google.com
Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Signed-off-by: Suren Baghdasaryan <surenb@google.com>
Cc: Dennis Zhou <dennis@kernel.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Li Zefan <lizefan@huawei.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Tejun Heo <tj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2019-03-06 02:45:45 +03:00
|
|
|
__poll_t kernfs_generic_poll(struct kernfs_open_file *of,
|
|
|
|
struct poll_table_struct *pt);
|
2013-12-11 23:11:53 +04:00
|
|
|
void kernfs_notify(struct kernfs_node *kn);
|
2013-11-24 02:21:49 +04:00
|
|
|
|
2013-11-28 23:54:43 +04:00
|
|
|
const void *kernfs_super_ns(struct super_block *sb);
|
kernfs, sysfs, cgroup, intel_rdt: Support fs_context
Make kernfs support superblock creation/mount/remount with fs_context.
This requires that sysfs, cgroup and intel_rdt, which are built on kernfs,
be made to support fs_context also.
Notes:
(1) A kernfs_fs_context struct is created to wrap fs_context and the
kernfs mount parameters are moved in here (or are in fs_context).
(2) kernfs_mount{,_ns}() are made into kernfs_get_tree(). The extra
namespace tag parameter is passed in the context if desired
(3) kernfs_free_fs_context() is provided as a destructor for the
kernfs_fs_context struct, but for the moment it does nothing except
get called in the right places.
(4) sysfs doesn't wrap kernfs_fs_context since it has no parameters to
pass, but possibly this should be done anyway in case someone wants to
add a parameter in future.
(5) A cgroup_fs_context struct is created to wrap kernfs_fs_context and
the cgroup v1 and v2 mount parameters are all moved there.
(6) cgroup1 parameter parsing error messages are now handled by invalf(),
which allows userspace to collect them directly.
(7) cgroup1 parameter cleanup is now done in the context destructor rather
than in the mount/get_tree and remount functions.
Weirdies:
(*) cgroup_do_get_tree() calls cset_cgroup_from_root() with locks held,
but then uses the resulting pointer after dropping the locks. I'm
told this is okay and needs commenting.
(*) The cgroup refcount web. This really needs documenting.
(*) cgroup2 only has one root?
Add a suggestion from Thomas Gleixner in which the RDT enablement code is
placed into its own function.
[folded a leak fix from Andrey Vagin]
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
cc: Tejun Heo <tj@kernel.org>
cc: Li Zefan <lizefan@huawei.com>
cc: Johannes Weiner <hannes@cmpxchg.org>
cc: cgroups@vger.kernel.org
cc: fenghua.yu@intel.com
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2018-11-02 02:07:26 +03:00
|
|
|
int kernfs_get_tree(struct fs_context *fc);
|
|
|
|
void kernfs_free_fs_context(struct fs_context *fc);
|
2013-11-28 23:54:43 +04:00
|
|
|
void kernfs_kill_sb(struct super_block *sb);
|
|
|
|
|
|
|
|
void kernfs_init(void);
|
|
|
|
|
2017-07-12 21:49:55 +03:00
|
|
|
struct kernfs_node *kernfs_get_node_by_id(struct kernfs_root *root,
|
|
|
|
const union kernfs_node_id *id);
|
2014-02-03 23:09:17 +04:00
|
|
|
#else /* CONFIG_KERNFS */
|
2013-11-24 02:21:49 +04:00
|
|
|
|
2013-12-11 23:11:56 +04:00
|
|
|
static inline enum kernfs_node_type kernfs_type(struct kernfs_node *kn)
|
2013-11-30 02:18:32 +04:00
|
|
|
{ return 0; } /* whatever */
|
|
|
|
|
2013-12-11 23:11:53 +04:00
|
|
|
static inline void kernfs_enable_ns(struct kernfs_node *kn) { }
|
2013-11-30 02:18:32 +04:00
|
|
|
|
2013-12-11 23:11:53 +04:00
|
|
|
static inline bool kernfs_ns_enabled(struct kernfs_node *kn)
|
2013-11-30 02:19:09 +04:00
|
|
|
{ return false; }
|
|
|
|
|
2014-02-07 22:32:07 +04:00
|
|
|
static inline int kernfs_name(struct kernfs_node *kn, char *buf, size_t buflen)
|
|
|
|
{ return -ENOSYS; }
|
|
|
|
|
2016-08-10 18:23:43 +03:00
|
|
|
static inline int kernfs_path_from_node(struct kernfs_node *root_kn,
|
|
|
|
struct kernfs_node *kn,
|
|
|
|
char *buf, size_t buflen)
|
|
|
|
{ return -ENOSYS; }
|
|
|
|
|
2014-02-07 22:32:07 +04:00
|
|
|
static inline void pr_cont_kernfs_name(struct kernfs_node *kn) { }
|
|
|
|
static inline void pr_cont_kernfs_path(struct kernfs_node *kn) { }
|
|
|
|
|
|
|
|
static inline struct kernfs_node *kernfs_get_parent(struct kernfs_node *kn)
|
|
|
|
{ return NULL; }
|
|
|
|
|
2013-12-11 23:11:53 +04:00
|
|
|
static inline struct kernfs_node *
|
|
|
|
kernfs_find_and_get_ns(struct kernfs_node *parent, const char *name,
|
2013-11-28 23:54:30 +04:00
|
|
|
const void *ns)
|
|
|
|
{ return NULL; }
|
2015-11-20 23:55:52 +03:00
|
|
|
static inline struct kernfs_node *
|
|
|
|
kernfs_walk_and_get_ns(struct kernfs_node *parent, const char *path,
|
|
|
|
const void *ns)
|
|
|
|
{ return NULL; }
|
2013-11-28 23:54:30 +04:00
|
|
|
|
2013-12-11 23:11:53 +04:00
|
|
|
static inline void kernfs_get(struct kernfs_node *kn) { }
|
|
|
|
static inline void kernfs_put(struct kernfs_node *kn) { }
|
2013-11-28 23:54:30 +04:00
|
|
|
|
2014-02-03 23:09:15 +04:00
|
|
|
static inline struct kernfs_node *kernfs_node_from_dentry(struct dentry *dentry)
|
|
|
|
{ return NULL; }
|
|
|
|
|
|
|
|
static inline struct kernfs_root *kernfs_root_from_sb(struct super_block *sb)
|
|
|
|
{ return NULL; }
|
|
|
|
|
2015-06-18 23:54:28 +03:00
|
|
|
static inline struct inode *
|
|
|
|
kernfs_get_inode(struct super_block *sb, struct kernfs_node *kn)
|
|
|
|
{ return NULL; }
|
|
|
|
|
2013-12-12 01:03:00 +04:00
|
|
|
static inline struct kernfs_root *
|
2014-02-03 23:09:12 +04:00
|
|
|
kernfs_create_root(struct kernfs_syscall_ops *scops, unsigned int flags,
|
|
|
|
void *priv)
|
2013-11-28 23:54:40 +04:00
|
|
|
{ return ERR_PTR(-ENOSYS); }
|
|
|
|
|
|
|
|
static inline void kernfs_destroy_root(struct kernfs_root *root) { }
|
|
|
|
|
2013-12-11 23:11:53 +04:00
|
|
|
static inline struct kernfs_node *
|
2013-12-12 01:02:55 +04:00
|
|
|
kernfs_create_dir_ns(struct kernfs_node *parent, const char *name,
|
2018-07-21 00:56:47 +03:00
|
|
|
umode_t mode, kuid_t uid, kgid_t gid,
|
|
|
|
void *priv, const void *ns)
|
2013-11-28 23:54:15 +04:00
|
|
|
{ return ERR_PTR(-ENOSYS); }
|
|
|
|
|
2013-12-11 23:11:53 +04:00
|
|
|
static inline struct kernfs_node *
|
2013-12-12 01:02:57 +04:00
|
|
|
__kernfs_create_file(struct kernfs_node *parent, const char *name,
|
2018-07-21 00:56:47 +03:00
|
|
|
umode_t mode, kuid_t uid, kgid_t gid,
|
|
|
|
loff_t size, const struct kernfs_ops *ops,
|
2015-02-14 01:36:31 +03:00
|
|
|
void *priv, const void *ns, struct lock_class_key *key)
|
2013-11-28 23:54:24 +04:00
|
|
|
{ return ERR_PTR(-ENOSYS); }
|
|
|
|
|
2013-12-11 23:11:53 +04:00
|
|
|
static inline struct kernfs_node *
|
|
|
|
kernfs_create_link(struct kernfs_node *parent, const char *name,
|
|
|
|
struct kernfs_node *target)
|
2013-11-24 02:21:50 +04:00
|
|
|
{ return ERR_PTR(-ENOSYS); }
|
|
|
|
|
2014-02-03 23:09:12 +04:00
|
|
|
static inline void kernfs_activate(struct kernfs_node *kn) { }
|
|
|
|
|
2013-12-11 23:11:53 +04:00
|
|
|
static inline void kernfs_remove(struct kernfs_node *kn) { }
|
2013-11-24 02:21:49 +04:00
|
|
|
|
kernfs, sysfs, driver-core: implement kernfs_remove_self() and its wrappers
Sometimes it's necessary to implement a node which wants to delete
nodes including itself. This isn't straightforward because of kernfs
active reference. While a file operation is in progress, an active
reference is held and kernfs_remove() waits for all such references to
drain before completing. For a self-deleting node, this is a deadlock
as kernfs_remove() ends up waiting for an active reference that itself
is sitting on top of.
This currently is worked around in the sysfs layer using
sysfs_schedule_callback() which makes such removals asynchronous.
While it works, it's rather cumbersome and inherently breaks
synchronicity of the operation - the file operation which triggered
the operation may complete before the removal is finished (or even
started) and the removal may fail asynchronously. If a removal
operation is immmediately followed by another operation which expects
the specific name to be available (e.g. removal followed by rename
onto the same name), there's no way to make the latter operation
reliable.
The thing is there's no inherent reason for this to be asynchrnous.
All that's necessary to do this synchronous is a dedicated operation
which drops its own active ref and deactivates self. This patch
implements kernfs_remove_self() and its wrappers in sysfs and driver
core. kernfs_remove_self() is to be called from one of the file
operations, drops the active ref the task is holding, removes the self
node, and restores active ref to the dead node so that the ref is
balanced afterwards. __kernfs_remove() is updated so that it takes an
early exit if the target node is already fully removed so that the
active ref restored by kernfs_remove_self() after removal doesn't
confuse the deactivation path.
This makes implementing self-deleting nodes very easy. The normal
removal path doesn't even need to be changed to use
kernfs_remove_self() for the self-deleting node. The method can
invoke kernfs_remove_self() on itself before proceeding the normal
removal path. kernfs_remove() invoked on the node by the normal
deletion path will simply be ignored.
This will replace sysfs_schedule_callback(). A subtle feature of
sysfs_schedule_callback() is that it collapses multiple invocations -
even if multiple removals are triggered, the removal callback is run
only once. An equivalent effect can be achieved by testing the return
value of kernfs_remove_self() - only the one which gets %true return
value should proceed with actual deletion. All other instances of
kernfs_remove_self() will wait till the enclosing kernfs operation
which invoked the winning instance of kernfs_remove_self() finishes
and then return %false. This trivially makes all users of
kernfs_remove_self() automatically show correct synchronous behavior
even when there are multiple concurrent operations - all "echo 1 >
delete" instances will finish only after the whole operation is
completed by one of the instances.
Note that manipulation of active ref is implemented in separate public
functions - kernfs_[un]break_active_protection().
kernfs_remove_self() is the only user at the moment but this will be
used to cater to more complex cases.
v2: For !CONFIG_SYSFS, dummy version kernfs_remove_self() was missing
and sysfs_remove_file_self() had incorrect return type. Fix it.
Reported by kbuild test bot.
v3: kernfs_[un]break_active_protection() separated out from
kernfs_remove_self() and exposed as public API.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-03 23:03:01 +04:00
|
|
|
static inline bool kernfs_remove_self(struct kernfs_node *kn)
|
|
|
|
{ return false; }
|
|
|
|
|
2013-12-11 23:11:53 +04:00
|
|
|
static inline int kernfs_remove_by_name_ns(struct kernfs_node *kn,
|
2013-11-24 02:21:49 +04:00
|
|
|
const char *name, const void *ns)
|
|
|
|
{ return -ENOSYS; }
|
|
|
|
|
2013-12-11 23:11:53 +04:00
|
|
|
static inline int kernfs_rename_ns(struct kernfs_node *kn,
|
|
|
|
struct kernfs_node *new_parent,
|
2013-11-24 02:21:51 +04:00
|
|
|
const char *new_name, const void *new_ns)
|
|
|
|
{ return -ENOSYS; }
|
|
|
|
|
2013-12-11 23:11:53 +04:00
|
|
|
static inline int kernfs_setattr(struct kernfs_node *kn,
|
2013-11-24 02:21:52 +04:00
|
|
|
const struct iattr *iattr)
|
|
|
|
{ return -ENOSYS; }
|
|
|
|
|
2013-12-11 23:11:53 +04:00
|
|
|
static inline void kernfs_notify(struct kernfs_node *kn) { }
|
2013-11-28 23:54:27 +04:00
|
|
|
|
2013-11-28 23:54:43 +04:00
|
|
|
static inline const void *kernfs_super_ns(struct super_block *sb)
|
|
|
|
{ return NULL; }
|
|
|
|
|
kernfs, sysfs, cgroup, intel_rdt: Support fs_context
Make kernfs support superblock creation/mount/remount with fs_context.
This requires that sysfs, cgroup and intel_rdt, which are built on kernfs,
be made to support fs_context also.
Notes:
(1) A kernfs_fs_context struct is created to wrap fs_context and the
kernfs mount parameters are moved in here (or are in fs_context).
(2) kernfs_mount{,_ns}() are made into kernfs_get_tree(). The extra
namespace tag parameter is passed in the context if desired
(3) kernfs_free_fs_context() is provided as a destructor for the
kernfs_fs_context struct, but for the moment it does nothing except
get called in the right places.
(4) sysfs doesn't wrap kernfs_fs_context since it has no parameters to
pass, but possibly this should be done anyway in case someone wants to
add a parameter in future.
(5) A cgroup_fs_context struct is created to wrap kernfs_fs_context and
the cgroup v1 and v2 mount parameters are all moved there.
(6) cgroup1 parameter parsing error messages are now handled by invalf(),
which allows userspace to collect them directly.
(7) cgroup1 parameter cleanup is now done in the context destructor rather
than in the mount/get_tree and remount functions.
Weirdies:
(*) cgroup_do_get_tree() calls cset_cgroup_from_root() with locks held,
but then uses the resulting pointer after dropping the locks. I'm
told this is okay and needs commenting.
(*) The cgroup refcount web. This really needs documenting.
(*) cgroup2 only has one root?
Add a suggestion from Thomas Gleixner in which the RDT enablement code is
placed into its own function.
[folded a leak fix from Andrey Vagin]
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
cc: Tejun Heo <tj@kernel.org>
cc: Li Zefan <lizefan@huawei.com>
cc: Johannes Weiner <hannes@cmpxchg.org>
cc: cgroups@vger.kernel.org
cc: fenghua.yu@intel.com
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2018-11-02 02:07:26 +03:00
|
|
|
static inline int kernfs_get_tree(struct fs_context *fc)
|
|
|
|
{ return -ENOSYS; }
|
|
|
|
|
|
|
|
static inline void kernfs_free_fs_context(struct fs_context *fc) { }
|
2013-11-28 23:54:43 +04:00
|
|
|
|
|
|
|
static inline void kernfs_kill_sb(struct super_block *sb) { }
|
|
|
|
|
|
|
|
static inline void kernfs_init(void) { }
|
|
|
|
|
2014-02-03 23:09:17 +04:00
|
|
|
#endif /* CONFIG_KERNFS */
|
2013-11-24 02:21:49 +04:00
|
|
|
|
2016-08-10 18:23:44 +03:00
|
|
|
/**
|
|
|
|
* kernfs_path - build full path of a given node
|
|
|
|
* @kn: kernfs_node of interest
|
|
|
|
* @buf: buffer to copy @kn's name into
|
|
|
|
* @buflen: size of @buf
|
|
|
|
*
|
2018-08-13 09:52:09 +03:00
|
|
|
* If @kn is NULL result will be "(null)".
|
|
|
|
*
|
|
|
|
* Returns the length of the full path. If the full length is equal to or
|
|
|
|
* greater than @buflen, @buf contains the truncated path with the trailing
|
|
|
|
* '\0'. On error, -errno is returned.
|
2016-08-10 18:23:44 +03:00
|
|
|
*/
|
|
|
|
static inline int kernfs_path(struct kernfs_node *kn, char *buf, size_t buflen)
|
|
|
|
{
|
|
|
|
return kernfs_path_from_node(kn, NULL, buf, buflen);
|
|
|
|
}
|
|
|
|
|
2013-12-11 23:11:53 +04:00
|
|
|
static inline struct kernfs_node *
|
|
|
|
kernfs_find_and_get(struct kernfs_node *kn, const char *name)
|
2013-11-28 23:54:30 +04:00
|
|
|
{
|
2013-12-11 23:11:53 +04:00
|
|
|
return kernfs_find_and_get_ns(kn, name, NULL);
|
2013-11-28 23:54:30 +04:00
|
|
|
}
|
|
|
|
|
2015-11-20 23:55:52 +03:00
|
|
|
static inline struct kernfs_node *
|
|
|
|
kernfs_walk_and_get(struct kernfs_node *kn, const char *path)
|
|
|
|
{
|
|
|
|
return kernfs_walk_and_get_ns(kn, path, NULL);
|
|
|
|
}
|
|
|
|
|
2013-12-11 23:11:53 +04:00
|
|
|
static inline struct kernfs_node *
|
2013-12-12 01:02:55 +04:00
|
|
|
kernfs_create_dir(struct kernfs_node *parent, const char *name, umode_t mode,
|
|
|
|
void *priv)
|
2013-11-28 23:54:15 +04:00
|
|
|
{
|
2018-07-21 00:56:47 +03:00
|
|
|
return kernfs_create_dir_ns(parent, name, mode,
|
|
|
|
GLOBAL_ROOT_UID, GLOBAL_ROOT_GID,
|
|
|
|
priv, NULL);
|
2013-11-28 23:54:15 +04:00
|
|
|
}
|
|
|
|
|
2013-12-11 23:11:53 +04:00
|
|
|
static inline struct kernfs_node *
|
|
|
|
kernfs_create_file_ns(struct kernfs_node *parent, const char *name,
|
2018-07-21 00:56:47 +03:00
|
|
|
umode_t mode, kuid_t uid, kgid_t gid,
|
|
|
|
loff_t size, const struct kernfs_ops *ops,
|
2013-11-28 23:54:29 +04:00
|
|
|
void *priv, const void *ns)
|
|
|
|
{
|
|
|
|
struct lock_class_key *key = NULL;
|
|
|
|
|
|
|
|
#ifdef CONFIG_DEBUG_LOCK_ALLOC
|
|
|
|
key = (struct lock_class_key *)&ops->lockdep_key;
|
|
|
|
#endif
|
2018-07-21 00:56:47 +03:00
|
|
|
return __kernfs_create_file(parent, name, mode, uid, gid,
|
|
|
|
size, ops, priv, ns, key);
|
2013-11-28 23:54:29 +04:00
|
|
|
}
|
|
|
|
|
2013-12-11 23:11:53 +04:00
|
|
|
static inline struct kernfs_node *
|
|
|
|
kernfs_create_file(struct kernfs_node *parent, const char *name, umode_t mode,
|
2013-11-28 23:54:24 +04:00
|
|
|
loff_t size, const struct kernfs_ops *ops, void *priv)
|
|
|
|
{
|
2018-07-21 00:56:47 +03:00
|
|
|
return kernfs_create_file_ns(parent, name, mode,
|
|
|
|
GLOBAL_ROOT_UID, GLOBAL_ROOT_GID,
|
|
|
|
size, ops, priv, NULL);
|
2013-11-28 23:54:24 +04:00
|
|
|
}
|
|
|
|
|
2013-12-11 23:11:53 +04:00
|
|
|
static inline int kernfs_remove_by_name(struct kernfs_node *parent,
|
2013-11-24 02:21:49 +04:00
|
|
|
const char *name)
|
|
|
|
{
|
|
|
|
return kernfs_remove_by_name_ns(parent, name, NULL);
|
|
|
|
}
|
|
|
|
|
2014-02-03 23:09:15 +04:00
|
|
|
static inline int kernfs_rename(struct kernfs_node *kn,
|
|
|
|
struct kernfs_node *new_parent,
|
|
|
|
const char *new_name)
|
|
|
|
{
|
|
|
|
return kernfs_rename_ns(kn, new_parent, new_name, NULL);
|
|
|
|
}
|
|
|
|
|
2013-11-24 18:54:58 +04:00
|
|
|
#endif /* __LINUX_KERNFS_H */
|