2005-04-17 02:20:36 +04:00
|
|
|
/*
|
|
|
|
* IP multicast routing support for mrouted 3.6/3.8
|
|
|
|
*
|
2008-10-14 06:01:08 +04:00
|
|
|
* (c) 1995 Alan Cox, <alan@lxorguk.ukuu.org.uk>
|
2005-04-17 02:20:36 +04:00
|
|
|
* Linux Consultancy and Custom Driver Development
|
|
|
|
*
|
|
|
|
* This program is free software; you can redistribute it and/or
|
|
|
|
* modify it under the terms of the GNU General Public License
|
|
|
|
* as published by the Free Software Foundation; either version
|
|
|
|
* 2 of the License, or (at your option) any later version.
|
|
|
|
*
|
|
|
|
* Fixes:
|
|
|
|
* Michael Chastain : Incorrect size of copying.
|
|
|
|
* Alan Cox : Added the cache manager code
|
|
|
|
* Alan Cox : Fixed the clone/copy bug and device race.
|
|
|
|
* Mike McLagan : Routing by source
|
|
|
|
* Malcolm Beattie : Buffer handling fixes.
|
|
|
|
* Alexey Kuznetsov : Double buffer free and other fixes.
|
|
|
|
* SVR Anand : Fixed several multicast bugs and problems.
|
|
|
|
* Alexey Kuznetsov : Status, optimisations and more.
|
|
|
|
* Brad Parker : Better behaviour on mrouted upcall
|
|
|
|
* overflow.
|
|
|
|
* Carlos Picoto : PIMv1 Support
|
|
|
|
* Pavlin Ivanov Radoslavov: PIMv2 Registers must checksum only PIM header
|
|
|
|
* Relax this requrement to work with older peers.
|
|
|
|
*
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <asm/system.h>
|
|
|
|
#include <asm/uaccess.h>
|
|
|
|
#include <linux/types.h>
|
2006-01-11 23:17:47 +03:00
|
|
|
#include <linux/capability.h>
|
2005-04-17 02:20:36 +04:00
|
|
|
#include <linux/errno.h>
|
|
|
|
#include <linux/timer.h>
|
|
|
|
#include <linux/mm.h>
|
|
|
|
#include <linux/kernel.h>
|
|
|
|
#include <linux/fcntl.h>
|
|
|
|
#include <linux/stat.h>
|
|
|
|
#include <linux/socket.h>
|
|
|
|
#include <linux/in.h>
|
|
|
|
#include <linux/inet.h>
|
|
|
|
#include <linux/netdevice.h>
|
|
|
|
#include <linux/inetdevice.h>
|
|
|
|
#include <linux/igmp.h>
|
|
|
|
#include <linux/proc_fs.h>
|
|
|
|
#include <linux/seq_file.h>
|
|
|
|
#include <linux/mroute.h>
|
|
|
|
#include <linux/init.h>
|
2006-01-06 03:35:42 +03:00
|
|
|
#include <linux/if_ether.h>
|
2007-09-12 14:01:34 +04:00
|
|
|
#include <net/net_namespace.h>
|
2005-04-17 02:20:36 +04:00
|
|
|
#include <net/ip.h>
|
|
|
|
#include <net/protocol.h>
|
|
|
|
#include <linux/skbuff.h>
|
2005-12-27 07:43:12 +03:00
|
|
|
#include <net/route.h>
|
2005-04-17 02:20:36 +04:00
|
|
|
#include <net/sock.h>
|
|
|
|
#include <net/icmp.h>
|
|
|
|
#include <net/udp.h>
|
|
|
|
#include <net/raw.h>
|
|
|
|
#include <linux/notifier.h>
|
|
|
|
#include <linux/if_arp.h>
|
|
|
|
#include <linux/netfilter_ipv4.h>
|
|
|
|
#include <net/ipip.h>
|
|
|
|
#include <net/checksum.h>
|
2007-03-26 10:06:12 +04:00
|
|
|
#include <net/netlink.h>
|
2005-04-17 02:20:36 +04:00
|
|
|
|
|
|
|
#if defined(CONFIG_IP_PIMSM_V1) || defined(CONFIG_IP_PIMSM_V2)
|
|
|
|
#define CONFIG_IP_PIMSM 1
|
|
|
|
#endif
|
|
|
|
|
|
|
|
static struct sock *mroute_socket;
|
|
|
|
|
|
|
|
|
|
|
|
/* Big lock, protecting vif table, mrt cache and mroute socket state.
|
|
|
|
Note that the changes are semaphored via rtnl_lock.
|
|
|
|
*/
|
|
|
|
|
|
|
|
static DEFINE_RWLOCK(mrt_lock);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Multicast router control variables
|
|
|
|
*/
|
|
|
|
|
|
|
|
static struct vif_device vif_table[MAXVIFS]; /* Devices */
|
|
|
|
static int maxvif;
|
|
|
|
|
|
|
|
#define VIF_EXISTS(idx) (vif_table[idx].dev != NULL)
|
|
|
|
|
|
|
|
static int mroute_do_assert; /* Set in PIM assert */
|
|
|
|
static int mroute_do_pim;
|
|
|
|
|
|
|
|
static struct mfc_cache *mfc_cache_array[MFC_LINES]; /* Forwarding cache */
|
|
|
|
|
|
|
|
static struct mfc_cache *mfc_unres_queue; /* Queue of unresolved entries */
|
|
|
|
static atomic_t cache_resolve_queue_len; /* Size of unresolved */
|
|
|
|
|
|
|
|
/* Special spinlock for queue of unresolved entries */
|
|
|
|
static DEFINE_SPINLOCK(mfc_unres_lock);
|
|
|
|
|
|
|
|
/* We return to original Alan's scheme. Hash table of resolved
|
|
|
|
entries is changed only in process context and protected
|
|
|
|
with weak lock mrt_lock. Queue of unresolved entries is protected
|
|
|
|
with strong spinlock mfc_unres_lock.
|
|
|
|
|
|
|
|
In this case data path is free of exclusive locks at all.
|
|
|
|
*/
|
|
|
|
|
2006-12-07 07:33:20 +03:00
|
|
|
static struct kmem_cache *mrt_cachep __read_mostly;
|
2005-04-17 02:20:36 +04:00
|
|
|
|
|
|
|
static int ip_mr_forward(struct sk_buff *skb, struct mfc_cache *cache, int local);
|
|
|
|
static int ipmr_cache_report(struct sk_buff *pkt, vifi_t vifi, int assert);
|
|
|
|
static int ipmr_fill_mroute(struct sk_buff *skb, struct mfc_cache *c, struct rtmsg *rtm);
|
|
|
|
|
|
|
|
#ifdef CONFIG_IP_PIMSM_V2
|
|
|
|
static struct net_protocol pim_protocol;
|
|
|
|
#endif
|
|
|
|
|
|
|
|
static struct timer_list ipmr_expire_timer;
|
|
|
|
|
|
|
|
/* Service routines creating virtual interfaces: DVMRP tunnels and PIMREG */
|
|
|
|
|
2008-07-15 07:55:26 +04:00
|
|
|
static void ipmr_del_tunnel(struct net_device *dev, struct vifctl *v)
|
|
|
|
{
|
|
|
|
dev_close(dev);
|
|
|
|
|
|
|
|
dev = __dev_get_by_name(&init_net, "tunl0");
|
|
|
|
if (dev) {
|
2008-11-20 08:52:05 +03:00
|
|
|
const struct net_device_ops *ops = dev->netdev_ops;
|
2008-07-15 07:55:26 +04:00
|
|
|
struct ifreq ifr;
|
|
|
|
struct ip_tunnel_parm p;
|
|
|
|
|
|
|
|
memset(&p, 0, sizeof(p));
|
|
|
|
p.iph.daddr = v->vifc_rmt_addr.s_addr;
|
|
|
|
p.iph.saddr = v->vifc_lcl_addr.s_addr;
|
|
|
|
p.iph.version = 4;
|
|
|
|
p.iph.ihl = 5;
|
|
|
|
p.iph.protocol = IPPROTO_IPIP;
|
|
|
|
sprintf(p.name, "dvmrp%d", v->vifc_vifi);
|
|
|
|
ifr.ifr_ifru.ifru_data = (__force void __user *)&p;
|
|
|
|
|
2008-11-20 08:52:05 +03:00
|
|
|
if (ops->ndo_do_ioctl) {
|
|
|
|
mm_segment_t oldfs = get_fs();
|
|
|
|
|
|
|
|
set_fs(KERNEL_DS);
|
|
|
|
ops->ndo_do_ioctl(dev, &ifr, SIOCDELTUNNEL);
|
|
|
|
set_fs(oldfs);
|
|
|
|
}
|
2008-07-15 07:55:26 +04:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2005-04-17 02:20:36 +04:00
|
|
|
static
|
|
|
|
struct net_device *ipmr_new_tunnel(struct vifctl *v)
|
|
|
|
{
|
|
|
|
struct net_device *dev;
|
|
|
|
|
2007-09-17 22:56:21 +04:00
|
|
|
dev = __dev_get_by_name(&init_net, "tunl0");
|
2005-04-17 02:20:36 +04:00
|
|
|
|
|
|
|
if (dev) {
|
2008-11-20 08:52:05 +03:00
|
|
|
const struct net_device_ops *ops = dev->netdev_ops;
|
2005-04-17 02:20:36 +04:00
|
|
|
int err;
|
|
|
|
struct ifreq ifr;
|
|
|
|
struct ip_tunnel_parm p;
|
|
|
|
struct in_device *in_dev;
|
|
|
|
|
|
|
|
memset(&p, 0, sizeof(p));
|
|
|
|
p.iph.daddr = v->vifc_rmt_addr.s_addr;
|
|
|
|
p.iph.saddr = v->vifc_lcl_addr.s_addr;
|
|
|
|
p.iph.version = 4;
|
|
|
|
p.iph.ihl = 5;
|
|
|
|
p.iph.protocol = IPPROTO_IPIP;
|
|
|
|
sprintf(p.name, "dvmrp%d", v->vifc_vifi);
|
2008-01-22 04:28:59 +03:00
|
|
|
ifr.ifr_ifru.ifru_data = (__force void __user *)&p;
|
2005-04-17 02:20:36 +04:00
|
|
|
|
2008-11-20 08:52:05 +03:00
|
|
|
if (ops->ndo_do_ioctl) {
|
|
|
|
mm_segment_t oldfs = get_fs();
|
|
|
|
|
|
|
|
set_fs(KERNEL_DS);
|
|
|
|
err = ops->ndo_do_ioctl(dev, &ifr, SIOCADDTUNNEL);
|
|
|
|
set_fs(oldfs);
|
|
|
|
} else
|
|
|
|
err = -EOPNOTSUPP;
|
2005-04-17 02:20:36 +04:00
|
|
|
|
|
|
|
dev = NULL;
|
|
|
|
|
2007-09-17 22:56:21 +04:00
|
|
|
if (err == 0 && (dev = __dev_get_by_name(&init_net, p.name)) != NULL) {
|
2005-04-17 02:20:36 +04:00
|
|
|
dev->flags |= IFF_MULTICAST;
|
|
|
|
|
2005-10-04 01:35:55 +04:00
|
|
|
in_dev = __in_dev_get_rtnl(dev);
|
2007-06-05 10:36:06 +04:00
|
|
|
if (in_dev == NULL)
|
2005-04-17 02:20:36 +04:00
|
|
|
goto failure;
|
2007-06-05 10:36:06 +04:00
|
|
|
|
|
|
|
ipv4_devconf_setall(in_dev);
|
|
|
|
IPV4_DEVCONF(in_dev->cnf, RP_FILTER) = 0;
|
2005-04-17 02:20:36 +04:00
|
|
|
|
|
|
|
if (dev_open(dev))
|
|
|
|
goto failure;
|
ipv4: Fix ipmr unregister device oops
An oops happens during device unregister.
The following oops happened when I add two tunnels, which
use a same device, and then delete one tunnel.
Obviously deleting tunnel "A" causes device unregister, which
send a notification, and after receiving notification, ipmr do
unregister again for tunnel "B" which also use same device.
That is wrong.
After receiving notification, ipmr only needs to decrease reference
count and don't do duplicated unregister.
Fortunately, IPv6 side doesn't add tunnel in ip6mr, so it's clean.
This patch fixs:
- unregister device oops
- using after dev_put()
Here is the oops:
===
Jul 11 15:39:29 wangchen kernel: ------------[ cut here ]------------
Jul 11 15:39:29 wangchen kernel: kernel BUG at net/core/dev.c:3651!
Jul 11 15:39:29 wangchen kernel: invalid opcode: 0000 [#1]
Jul 11 15:39:29 wangchen kernel: Modules linked in: ipip tunnel4 nfsd lockd nfs_acl auth_rpcgss sunrpc exportfs ipv6 snd_pcm_oss snd_mixer_oss snd_seq snd_seq_device af_packet binfmt_misc button battery ac loop dm_mod usbhid ff_memless pcmcia firmware_class ohci1394 8139too mii ieee1394 yenta_socket rsrc_nonstatic pcmcia_core ide_cd_mod cdrom snd_intel8x0 snd_ac97_codec ac97_bus snd_pcm i2c_i801 snd_timer snd i2c_core soundcore snd_page_alloc rng_core shpchp ehci_hcd uhci_hcd pci_hotplug intel_agp agpgart usbcore ext3 jbd ata_piix ahci libata dock edd fan thermal processor thermal_sys piix sd_mod scsi_mod ide_disk ide_core [last unloaded: freq_table]
Jul 11 15:39:29 wangchen kernel:
Jul 11 15:39:29 wangchen kernel: Pid: 4102, comm: mroute Not tainted (2.6.26-rc9-default #69)
Jul 11 15:39:29 wangchen kernel: EIP: 0060:[<c024636b>] EFLAGS: 00010202 CPU: 0
Jul 11 15:39:29 wangchen kernel: EIP is at rollback_registered+0x61/0xe3
Jul 11 15:39:29 wangchen kernel: EAX: 00000001 EBX: ecba6000 ECX: 00000000 EDX: ffffffff
Jul 11 15:39:29 wangchen kernel: ESI: 00000001 EDI: ecba6000 EBP: c03de2e8 ESP: ed8e7c3c
Jul 11 15:39:29 wangchen kernel: DS: 007b ES: 007b FS: 0000 GS: 0033 SS: 0068
Jul 11 15:39:29 wangchen kernel: Process mroute (pid: 4102, ti=ed8e6000 task=ed41e830 task.ti=ed8e6000)
Jul 11 15:39:29 wangchen kernel: Stack: ecba6000 c024641c 00000028 c0284e1a 00000001 c03de2e8 ecba6000 eecff360
Jul 11 15:39:29 wangchen kernel: c0284e4c c03536f4 fffffff8 00000000 c029a819 ecba6000 00000006 ecba6000
Jul 11 15:39:29 wangchen kernel: 00000000 ecba6000 c03de2c0 c012841b ffffffff 00000000 c024639f ecba6000
Jul 11 15:39:29 wangchen kernel: Call Trace:
Jul 11 15:39:29 wangchen kernel: [<c024641c>] unregister_netdevice+0x2f/0x51
Jul 11 15:39:29 wangchen kernel: [<c0284e1a>] vif_delete+0xaf/0xc3
Jul 11 15:39:29 wangchen kernel: [<c0284e4c>] ipmr_device_event+0x1e/0x30
Jul 11 15:39:29 wangchen kernel: [<c029a819>] notifier_call_chain+0x2a/0x47
Jul 11 15:39:29 wangchen kernel: [<c012841b>] raw_notifier_call_chain+0x9/0xc
Jul 11 15:39:29 wangchen kernel: [<c024639f>] rollback_registered+0x95/0xe3
Jul 11 15:39:29 wangchen kernel: [<c024641c>] unregister_netdevice+0x2f/0x51
Jul 11 15:39:29 wangchen kernel: [<c0284e1a>] vif_delete+0xaf/0xc3
Jul 11 15:39:29 wangchen kernel: [<c0285eee>] ip_mroute_setsockopt+0x47a/0x801
Jul 11 15:39:29 wangchen kernel: [<eea5a70c>] do_get_write_access+0x2df/0x313 [jbd]
Jul 11 15:39:29 wangchen kernel: [<c01727c4>] __find_get_block_slow+0xda/0xe4
Jul 11 15:39:29 wangchen kernel: [<c0172a7f>] __find_get_block+0xf8/0x122
Jul 11 15:39:29 wangchen kernel: [<c0172a7f>] __find_get_block+0xf8/0x122
Jul 11 15:39:29 wangchen kernel: [<eea5d563>] journal_cancel_revoke+0xda/0x110 [jbd]
Jul 11 15:39:29 wangchen kernel: [<c0263501>] ip_setsockopt+0xa9/0x9ee
Jul 11 15:39:29 wangchen kernel: [<eea5d563>] journal_cancel_revoke+0xda/0x110 [jbd]
Jul 11 15:39:29 wangchen kernel: [<eea5a70c>] do_get_write_access+0x2df/0x313 [jbd]
Jul 11 15:39:29 wangchen kernel: [<eea69287>] __ext3_get_inode_loc+0xcf/0x271 [ext3]
Jul 11 15:39:29 wangchen kernel: [<eea743c7>] __ext3_journal_dirty_metadata+0x13/0x32 [ext3]
Jul 11 15:39:29 wangchen kernel: [<c0116434>] __wake_up+0xf/0x15
Jul 11 15:39:29 wangchen kernel: [<eea5a424>] journal_stop+0x1bd/0x1c6 [jbd]
Jul 11 15:39:29 wangchen kernel: [<eea703a7>] __ext3_journal_stop+0x19/0x34 [ext3]
Jul 11 15:39:29 wangchen kernel: [<c014291e>] get_page_from_freelist+0x94/0x369
Jul 11 15:39:29 wangchen kernel: [<c01408f2>] filemap_fault+0x1ac/0x2fe
Jul 11 15:39:29 wangchen kernel: [<c01a605e>] security_sk_alloc+0xd/0xf
Jul 11 15:39:29 wangchen kernel: [<c023edea>] sk_prot_alloc+0x36/0x78
Jul 11 15:39:29 wangchen kernel: [<c0240037>] sk_alloc+0x3a/0x40
Jul 11 15:39:29 wangchen kernel: [<c0276062>] raw_hash_sk+0x46/0x4e
Jul 11 15:39:29 wangchen kernel: [<c0166aff>] d_alloc+0x1b/0x157
Jul 11 15:39:29 wangchen kernel: [<c023e4d1>] sock_common_setsockopt+0x12/0x16
Jul 11 15:39:29 wangchen kernel: [<c023cb1e>] sys_setsockopt+0x6f/0x8e
Jul 11 15:39:29 wangchen kernel: [<c023e105>] sys_socketcall+0x15c/0x19e
Jul 11 15:39:29 wangchen kernel: [<c0103611>] sysenter_past_esp+0x6a/0x99
Jul 11 15:39:29 wangchen kernel: [<c0290000>] unix_poll+0x69/0x78
Jul 11 15:39:29 wangchen kernel: =======================
Jul 11 15:39:29 wangchen kernel: Code: 83 e0 01 00 00 85 c0 75 1f 53 53 68 12 81 31 c0 e8 3c 30 ed ff ba 3f 0e 00 00 b8 b9 7f 31 c0 83 c4 0c 5b e9 f5 26 ed ff 48 74 04 <0f> 0b eb fe 89 d8 e8 21 ff ff ff 89 d8 e8 62 ea ff ff c7 83 e0
Jul 11 15:39:29 wangchen kernel: EIP: [<c024636b>] rollback_registered+0x61/0xe3 SS:ESP 0068:ed8e7c3c
Jul 11 15:39:29 wangchen kernel: ---[ end trace c311acf85d169786 ]---
===
Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2008-07-15 07:56:34 +04:00
|
|
|
dev_hold(dev);
|
2005-04-17 02:20:36 +04:00
|
|
|
}
|
|
|
|
}
|
|
|
|
return dev;
|
|
|
|
|
|
|
|
failure:
|
|
|
|
/* allow the register to be completed before unregistering. */
|
|
|
|
rtnl_unlock();
|
|
|
|
rtnl_lock();
|
|
|
|
|
|
|
|
unregister_netdevice(dev);
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
#ifdef CONFIG_IP_PIMSM
|
|
|
|
|
|
|
|
static int reg_vif_num = -1;
|
|
|
|
|
|
|
|
static int reg_vif_xmit(struct sk_buff *skb, struct net_device *dev)
|
|
|
|
{
|
|
|
|
read_lock(&mrt_lock);
|
2008-05-22 01:17:33 +04:00
|
|
|
dev->stats.tx_bytes += skb->len;
|
|
|
|
dev->stats.tx_packets++;
|
2005-04-17 02:20:36 +04:00
|
|
|
ipmr_cache_report(skb, reg_vif_num, IGMPMSG_WHOLEPKT);
|
|
|
|
read_unlock(&mrt_lock);
|
|
|
|
kfree_skb(skb);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2008-11-21 07:28:35 +03:00
|
|
|
static const struct net_device_ops reg_vif_netdev_ops = {
|
|
|
|
.ndo_start_xmit = reg_vif_xmit,
|
|
|
|
};
|
|
|
|
|
2005-04-17 02:20:36 +04:00
|
|
|
static void reg_vif_setup(struct net_device *dev)
|
|
|
|
{
|
|
|
|
dev->type = ARPHRD_PIMREG;
|
2006-01-06 03:35:42 +03:00
|
|
|
dev->mtu = ETH_DATA_LEN - sizeof(struct iphdr) - 8;
|
2005-04-17 02:20:36 +04:00
|
|
|
dev->flags = IFF_NOARP;
|
2008-11-21 07:28:35 +03:00
|
|
|
dev->netdev_ops = ®_vif_netdev_ops,
|
2005-04-17 02:20:36 +04:00
|
|
|
dev->destructor = free_netdev;
|
|
|
|
}
|
|
|
|
|
|
|
|
static struct net_device *ipmr_reg_vif(void)
|
|
|
|
{
|
|
|
|
struct net_device *dev;
|
|
|
|
struct in_device *in_dev;
|
|
|
|
|
2008-05-22 01:17:33 +04:00
|
|
|
dev = alloc_netdev(0, "pimreg", reg_vif_setup);
|
2005-04-17 02:20:36 +04:00
|
|
|
|
|
|
|
if (dev == NULL)
|
|
|
|
return NULL;
|
|
|
|
|
|
|
|
if (register_netdevice(dev)) {
|
|
|
|
free_netdev(dev);
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
dev->iflink = 0;
|
|
|
|
|
2007-06-05 10:36:06 +04:00
|
|
|
rcu_read_lock();
|
|
|
|
if ((in_dev = __in_dev_get_rcu(dev)) == NULL) {
|
|
|
|
rcu_read_unlock();
|
2005-04-17 02:20:36 +04:00
|
|
|
goto failure;
|
2007-06-05 10:36:06 +04:00
|
|
|
}
|
2005-04-17 02:20:36 +04:00
|
|
|
|
2007-06-05 10:36:06 +04:00
|
|
|
ipv4_devconf_setall(in_dev);
|
|
|
|
IPV4_DEVCONF(in_dev->cnf, RP_FILTER) = 0;
|
|
|
|
rcu_read_unlock();
|
2005-04-17 02:20:36 +04:00
|
|
|
|
|
|
|
if (dev_open(dev))
|
|
|
|
goto failure;
|
|
|
|
|
ipv4: Fix ipmr unregister device oops
An oops happens during device unregister.
The following oops happened when I add two tunnels, which
use a same device, and then delete one tunnel.
Obviously deleting tunnel "A" causes device unregister, which
send a notification, and after receiving notification, ipmr do
unregister again for tunnel "B" which also use same device.
That is wrong.
After receiving notification, ipmr only needs to decrease reference
count and don't do duplicated unregister.
Fortunately, IPv6 side doesn't add tunnel in ip6mr, so it's clean.
This patch fixs:
- unregister device oops
- using after dev_put()
Here is the oops:
===
Jul 11 15:39:29 wangchen kernel: ------------[ cut here ]------------
Jul 11 15:39:29 wangchen kernel: kernel BUG at net/core/dev.c:3651!
Jul 11 15:39:29 wangchen kernel: invalid opcode: 0000 [#1]
Jul 11 15:39:29 wangchen kernel: Modules linked in: ipip tunnel4 nfsd lockd nfs_acl auth_rpcgss sunrpc exportfs ipv6 snd_pcm_oss snd_mixer_oss snd_seq snd_seq_device af_packet binfmt_misc button battery ac loop dm_mod usbhid ff_memless pcmcia firmware_class ohci1394 8139too mii ieee1394 yenta_socket rsrc_nonstatic pcmcia_core ide_cd_mod cdrom snd_intel8x0 snd_ac97_codec ac97_bus snd_pcm i2c_i801 snd_timer snd i2c_core soundcore snd_page_alloc rng_core shpchp ehci_hcd uhci_hcd pci_hotplug intel_agp agpgart usbcore ext3 jbd ata_piix ahci libata dock edd fan thermal processor thermal_sys piix sd_mod scsi_mod ide_disk ide_core [last unloaded: freq_table]
Jul 11 15:39:29 wangchen kernel:
Jul 11 15:39:29 wangchen kernel: Pid: 4102, comm: mroute Not tainted (2.6.26-rc9-default #69)
Jul 11 15:39:29 wangchen kernel: EIP: 0060:[<c024636b>] EFLAGS: 00010202 CPU: 0
Jul 11 15:39:29 wangchen kernel: EIP is at rollback_registered+0x61/0xe3
Jul 11 15:39:29 wangchen kernel: EAX: 00000001 EBX: ecba6000 ECX: 00000000 EDX: ffffffff
Jul 11 15:39:29 wangchen kernel: ESI: 00000001 EDI: ecba6000 EBP: c03de2e8 ESP: ed8e7c3c
Jul 11 15:39:29 wangchen kernel: DS: 007b ES: 007b FS: 0000 GS: 0033 SS: 0068
Jul 11 15:39:29 wangchen kernel: Process mroute (pid: 4102, ti=ed8e6000 task=ed41e830 task.ti=ed8e6000)
Jul 11 15:39:29 wangchen kernel: Stack: ecba6000 c024641c 00000028 c0284e1a 00000001 c03de2e8 ecba6000 eecff360
Jul 11 15:39:29 wangchen kernel: c0284e4c c03536f4 fffffff8 00000000 c029a819 ecba6000 00000006 ecba6000
Jul 11 15:39:29 wangchen kernel: 00000000 ecba6000 c03de2c0 c012841b ffffffff 00000000 c024639f ecba6000
Jul 11 15:39:29 wangchen kernel: Call Trace:
Jul 11 15:39:29 wangchen kernel: [<c024641c>] unregister_netdevice+0x2f/0x51
Jul 11 15:39:29 wangchen kernel: [<c0284e1a>] vif_delete+0xaf/0xc3
Jul 11 15:39:29 wangchen kernel: [<c0284e4c>] ipmr_device_event+0x1e/0x30
Jul 11 15:39:29 wangchen kernel: [<c029a819>] notifier_call_chain+0x2a/0x47
Jul 11 15:39:29 wangchen kernel: [<c012841b>] raw_notifier_call_chain+0x9/0xc
Jul 11 15:39:29 wangchen kernel: [<c024639f>] rollback_registered+0x95/0xe3
Jul 11 15:39:29 wangchen kernel: [<c024641c>] unregister_netdevice+0x2f/0x51
Jul 11 15:39:29 wangchen kernel: [<c0284e1a>] vif_delete+0xaf/0xc3
Jul 11 15:39:29 wangchen kernel: [<c0285eee>] ip_mroute_setsockopt+0x47a/0x801
Jul 11 15:39:29 wangchen kernel: [<eea5a70c>] do_get_write_access+0x2df/0x313 [jbd]
Jul 11 15:39:29 wangchen kernel: [<c01727c4>] __find_get_block_slow+0xda/0xe4
Jul 11 15:39:29 wangchen kernel: [<c0172a7f>] __find_get_block+0xf8/0x122
Jul 11 15:39:29 wangchen kernel: [<c0172a7f>] __find_get_block+0xf8/0x122
Jul 11 15:39:29 wangchen kernel: [<eea5d563>] journal_cancel_revoke+0xda/0x110 [jbd]
Jul 11 15:39:29 wangchen kernel: [<c0263501>] ip_setsockopt+0xa9/0x9ee
Jul 11 15:39:29 wangchen kernel: [<eea5d563>] journal_cancel_revoke+0xda/0x110 [jbd]
Jul 11 15:39:29 wangchen kernel: [<eea5a70c>] do_get_write_access+0x2df/0x313 [jbd]
Jul 11 15:39:29 wangchen kernel: [<eea69287>] __ext3_get_inode_loc+0xcf/0x271 [ext3]
Jul 11 15:39:29 wangchen kernel: [<eea743c7>] __ext3_journal_dirty_metadata+0x13/0x32 [ext3]
Jul 11 15:39:29 wangchen kernel: [<c0116434>] __wake_up+0xf/0x15
Jul 11 15:39:29 wangchen kernel: [<eea5a424>] journal_stop+0x1bd/0x1c6 [jbd]
Jul 11 15:39:29 wangchen kernel: [<eea703a7>] __ext3_journal_stop+0x19/0x34 [ext3]
Jul 11 15:39:29 wangchen kernel: [<c014291e>] get_page_from_freelist+0x94/0x369
Jul 11 15:39:29 wangchen kernel: [<c01408f2>] filemap_fault+0x1ac/0x2fe
Jul 11 15:39:29 wangchen kernel: [<c01a605e>] security_sk_alloc+0xd/0xf
Jul 11 15:39:29 wangchen kernel: [<c023edea>] sk_prot_alloc+0x36/0x78
Jul 11 15:39:29 wangchen kernel: [<c0240037>] sk_alloc+0x3a/0x40
Jul 11 15:39:29 wangchen kernel: [<c0276062>] raw_hash_sk+0x46/0x4e
Jul 11 15:39:29 wangchen kernel: [<c0166aff>] d_alloc+0x1b/0x157
Jul 11 15:39:29 wangchen kernel: [<c023e4d1>] sock_common_setsockopt+0x12/0x16
Jul 11 15:39:29 wangchen kernel: [<c023cb1e>] sys_setsockopt+0x6f/0x8e
Jul 11 15:39:29 wangchen kernel: [<c023e105>] sys_socketcall+0x15c/0x19e
Jul 11 15:39:29 wangchen kernel: [<c0103611>] sysenter_past_esp+0x6a/0x99
Jul 11 15:39:29 wangchen kernel: [<c0290000>] unix_poll+0x69/0x78
Jul 11 15:39:29 wangchen kernel: =======================
Jul 11 15:39:29 wangchen kernel: Code: 83 e0 01 00 00 85 c0 75 1f 53 53 68 12 81 31 c0 e8 3c 30 ed ff ba 3f 0e 00 00 b8 b9 7f 31 c0 83 c4 0c 5b e9 f5 26 ed ff 48 74 04 <0f> 0b eb fe 89 d8 e8 21 ff ff ff 89 d8 e8 62 ea ff ff c7 83 e0
Jul 11 15:39:29 wangchen kernel: EIP: [<c024636b>] rollback_registered+0x61/0xe3 SS:ESP 0068:ed8e7c3c
Jul 11 15:39:29 wangchen kernel: ---[ end trace c311acf85d169786 ]---
===
Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2008-07-15 07:56:34 +04:00
|
|
|
dev_hold(dev);
|
|
|
|
|
2005-04-17 02:20:36 +04:00
|
|
|
return dev;
|
|
|
|
|
|
|
|
failure:
|
|
|
|
/* allow the register to be completed before unregistering. */
|
|
|
|
rtnl_unlock();
|
|
|
|
rtnl_lock();
|
|
|
|
|
|
|
|
unregister_netdevice(dev);
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Delete a VIF entry
|
ipv4: Fix ipmr unregister device oops
An oops happens during device unregister.
The following oops happened when I add two tunnels, which
use a same device, and then delete one tunnel.
Obviously deleting tunnel "A" causes device unregister, which
send a notification, and after receiving notification, ipmr do
unregister again for tunnel "B" which also use same device.
That is wrong.
After receiving notification, ipmr only needs to decrease reference
count and don't do duplicated unregister.
Fortunately, IPv6 side doesn't add tunnel in ip6mr, so it's clean.
This patch fixs:
- unregister device oops
- using after dev_put()
Here is the oops:
===
Jul 11 15:39:29 wangchen kernel: ------------[ cut here ]------------
Jul 11 15:39:29 wangchen kernel: kernel BUG at net/core/dev.c:3651!
Jul 11 15:39:29 wangchen kernel: invalid opcode: 0000 [#1]
Jul 11 15:39:29 wangchen kernel: Modules linked in: ipip tunnel4 nfsd lockd nfs_acl auth_rpcgss sunrpc exportfs ipv6 snd_pcm_oss snd_mixer_oss snd_seq snd_seq_device af_packet binfmt_misc button battery ac loop dm_mod usbhid ff_memless pcmcia firmware_class ohci1394 8139too mii ieee1394 yenta_socket rsrc_nonstatic pcmcia_core ide_cd_mod cdrom snd_intel8x0 snd_ac97_codec ac97_bus snd_pcm i2c_i801 snd_timer snd i2c_core soundcore snd_page_alloc rng_core shpchp ehci_hcd uhci_hcd pci_hotplug intel_agp agpgart usbcore ext3 jbd ata_piix ahci libata dock edd fan thermal processor thermal_sys piix sd_mod scsi_mod ide_disk ide_core [last unloaded: freq_table]
Jul 11 15:39:29 wangchen kernel:
Jul 11 15:39:29 wangchen kernel: Pid: 4102, comm: mroute Not tainted (2.6.26-rc9-default #69)
Jul 11 15:39:29 wangchen kernel: EIP: 0060:[<c024636b>] EFLAGS: 00010202 CPU: 0
Jul 11 15:39:29 wangchen kernel: EIP is at rollback_registered+0x61/0xe3
Jul 11 15:39:29 wangchen kernel: EAX: 00000001 EBX: ecba6000 ECX: 00000000 EDX: ffffffff
Jul 11 15:39:29 wangchen kernel: ESI: 00000001 EDI: ecba6000 EBP: c03de2e8 ESP: ed8e7c3c
Jul 11 15:39:29 wangchen kernel: DS: 007b ES: 007b FS: 0000 GS: 0033 SS: 0068
Jul 11 15:39:29 wangchen kernel: Process mroute (pid: 4102, ti=ed8e6000 task=ed41e830 task.ti=ed8e6000)
Jul 11 15:39:29 wangchen kernel: Stack: ecba6000 c024641c 00000028 c0284e1a 00000001 c03de2e8 ecba6000 eecff360
Jul 11 15:39:29 wangchen kernel: c0284e4c c03536f4 fffffff8 00000000 c029a819 ecba6000 00000006 ecba6000
Jul 11 15:39:29 wangchen kernel: 00000000 ecba6000 c03de2c0 c012841b ffffffff 00000000 c024639f ecba6000
Jul 11 15:39:29 wangchen kernel: Call Trace:
Jul 11 15:39:29 wangchen kernel: [<c024641c>] unregister_netdevice+0x2f/0x51
Jul 11 15:39:29 wangchen kernel: [<c0284e1a>] vif_delete+0xaf/0xc3
Jul 11 15:39:29 wangchen kernel: [<c0284e4c>] ipmr_device_event+0x1e/0x30
Jul 11 15:39:29 wangchen kernel: [<c029a819>] notifier_call_chain+0x2a/0x47
Jul 11 15:39:29 wangchen kernel: [<c012841b>] raw_notifier_call_chain+0x9/0xc
Jul 11 15:39:29 wangchen kernel: [<c024639f>] rollback_registered+0x95/0xe3
Jul 11 15:39:29 wangchen kernel: [<c024641c>] unregister_netdevice+0x2f/0x51
Jul 11 15:39:29 wangchen kernel: [<c0284e1a>] vif_delete+0xaf/0xc3
Jul 11 15:39:29 wangchen kernel: [<c0285eee>] ip_mroute_setsockopt+0x47a/0x801
Jul 11 15:39:29 wangchen kernel: [<eea5a70c>] do_get_write_access+0x2df/0x313 [jbd]
Jul 11 15:39:29 wangchen kernel: [<c01727c4>] __find_get_block_slow+0xda/0xe4
Jul 11 15:39:29 wangchen kernel: [<c0172a7f>] __find_get_block+0xf8/0x122
Jul 11 15:39:29 wangchen kernel: [<c0172a7f>] __find_get_block+0xf8/0x122
Jul 11 15:39:29 wangchen kernel: [<eea5d563>] journal_cancel_revoke+0xda/0x110 [jbd]
Jul 11 15:39:29 wangchen kernel: [<c0263501>] ip_setsockopt+0xa9/0x9ee
Jul 11 15:39:29 wangchen kernel: [<eea5d563>] journal_cancel_revoke+0xda/0x110 [jbd]
Jul 11 15:39:29 wangchen kernel: [<eea5a70c>] do_get_write_access+0x2df/0x313 [jbd]
Jul 11 15:39:29 wangchen kernel: [<eea69287>] __ext3_get_inode_loc+0xcf/0x271 [ext3]
Jul 11 15:39:29 wangchen kernel: [<eea743c7>] __ext3_journal_dirty_metadata+0x13/0x32 [ext3]
Jul 11 15:39:29 wangchen kernel: [<c0116434>] __wake_up+0xf/0x15
Jul 11 15:39:29 wangchen kernel: [<eea5a424>] journal_stop+0x1bd/0x1c6 [jbd]
Jul 11 15:39:29 wangchen kernel: [<eea703a7>] __ext3_journal_stop+0x19/0x34 [ext3]
Jul 11 15:39:29 wangchen kernel: [<c014291e>] get_page_from_freelist+0x94/0x369
Jul 11 15:39:29 wangchen kernel: [<c01408f2>] filemap_fault+0x1ac/0x2fe
Jul 11 15:39:29 wangchen kernel: [<c01a605e>] security_sk_alloc+0xd/0xf
Jul 11 15:39:29 wangchen kernel: [<c023edea>] sk_prot_alloc+0x36/0x78
Jul 11 15:39:29 wangchen kernel: [<c0240037>] sk_alloc+0x3a/0x40
Jul 11 15:39:29 wangchen kernel: [<c0276062>] raw_hash_sk+0x46/0x4e
Jul 11 15:39:29 wangchen kernel: [<c0166aff>] d_alloc+0x1b/0x157
Jul 11 15:39:29 wangchen kernel: [<c023e4d1>] sock_common_setsockopt+0x12/0x16
Jul 11 15:39:29 wangchen kernel: [<c023cb1e>] sys_setsockopt+0x6f/0x8e
Jul 11 15:39:29 wangchen kernel: [<c023e105>] sys_socketcall+0x15c/0x19e
Jul 11 15:39:29 wangchen kernel: [<c0103611>] sysenter_past_esp+0x6a/0x99
Jul 11 15:39:29 wangchen kernel: [<c0290000>] unix_poll+0x69/0x78
Jul 11 15:39:29 wangchen kernel: =======================
Jul 11 15:39:29 wangchen kernel: Code: 83 e0 01 00 00 85 c0 75 1f 53 53 68 12 81 31 c0 e8 3c 30 ed ff ba 3f 0e 00 00 b8 b9 7f 31 c0 83 c4 0c 5b e9 f5 26 ed ff 48 74 04 <0f> 0b eb fe 89 d8 e8 21 ff ff ff 89 d8 e8 62 ea ff ff c7 83 e0
Jul 11 15:39:29 wangchen kernel: EIP: [<c024636b>] rollback_registered+0x61/0xe3 SS:ESP 0068:ed8e7c3c
Jul 11 15:39:29 wangchen kernel: ---[ end trace c311acf85d169786 ]---
===
Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2008-07-15 07:56:34 +04:00
|
|
|
* @notify: Set to 1, if the caller is a notifier_call
|
2005-04-17 02:20:36 +04:00
|
|
|
*/
|
2007-02-09 17:24:47 +03:00
|
|
|
|
ipv4: Fix ipmr unregister device oops
An oops happens during device unregister.
The following oops happened when I add two tunnels, which
use a same device, and then delete one tunnel.
Obviously deleting tunnel "A" causes device unregister, which
send a notification, and after receiving notification, ipmr do
unregister again for tunnel "B" which also use same device.
That is wrong.
After receiving notification, ipmr only needs to decrease reference
count and don't do duplicated unregister.
Fortunately, IPv6 side doesn't add tunnel in ip6mr, so it's clean.
This patch fixs:
- unregister device oops
- using after dev_put()
Here is the oops:
===
Jul 11 15:39:29 wangchen kernel: ------------[ cut here ]------------
Jul 11 15:39:29 wangchen kernel: kernel BUG at net/core/dev.c:3651!
Jul 11 15:39:29 wangchen kernel: invalid opcode: 0000 [#1]
Jul 11 15:39:29 wangchen kernel: Modules linked in: ipip tunnel4 nfsd lockd nfs_acl auth_rpcgss sunrpc exportfs ipv6 snd_pcm_oss snd_mixer_oss snd_seq snd_seq_device af_packet binfmt_misc button battery ac loop dm_mod usbhid ff_memless pcmcia firmware_class ohci1394 8139too mii ieee1394 yenta_socket rsrc_nonstatic pcmcia_core ide_cd_mod cdrom snd_intel8x0 snd_ac97_codec ac97_bus snd_pcm i2c_i801 snd_timer snd i2c_core soundcore snd_page_alloc rng_core shpchp ehci_hcd uhci_hcd pci_hotplug intel_agp agpgart usbcore ext3 jbd ata_piix ahci libata dock edd fan thermal processor thermal_sys piix sd_mod scsi_mod ide_disk ide_core [last unloaded: freq_table]
Jul 11 15:39:29 wangchen kernel:
Jul 11 15:39:29 wangchen kernel: Pid: 4102, comm: mroute Not tainted (2.6.26-rc9-default #69)
Jul 11 15:39:29 wangchen kernel: EIP: 0060:[<c024636b>] EFLAGS: 00010202 CPU: 0
Jul 11 15:39:29 wangchen kernel: EIP is at rollback_registered+0x61/0xe3
Jul 11 15:39:29 wangchen kernel: EAX: 00000001 EBX: ecba6000 ECX: 00000000 EDX: ffffffff
Jul 11 15:39:29 wangchen kernel: ESI: 00000001 EDI: ecba6000 EBP: c03de2e8 ESP: ed8e7c3c
Jul 11 15:39:29 wangchen kernel: DS: 007b ES: 007b FS: 0000 GS: 0033 SS: 0068
Jul 11 15:39:29 wangchen kernel: Process mroute (pid: 4102, ti=ed8e6000 task=ed41e830 task.ti=ed8e6000)
Jul 11 15:39:29 wangchen kernel: Stack: ecba6000 c024641c 00000028 c0284e1a 00000001 c03de2e8 ecba6000 eecff360
Jul 11 15:39:29 wangchen kernel: c0284e4c c03536f4 fffffff8 00000000 c029a819 ecba6000 00000006 ecba6000
Jul 11 15:39:29 wangchen kernel: 00000000 ecba6000 c03de2c0 c012841b ffffffff 00000000 c024639f ecba6000
Jul 11 15:39:29 wangchen kernel: Call Trace:
Jul 11 15:39:29 wangchen kernel: [<c024641c>] unregister_netdevice+0x2f/0x51
Jul 11 15:39:29 wangchen kernel: [<c0284e1a>] vif_delete+0xaf/0xc3
Jul 11 15:39:29 wangchen kernel: [<c0284e4c>] ipmr_device_event+0x1e/0x30
Jul 11 15:39:29 wangchen kernel: [<c029a819>] notifier_call_chain+0x2a/0x47
Jul 11 15:39:29 wangchen kernel: [<c012841b>] raw_notifier_call_chain+0x9/0xc
Jul 11 15:39:29 wangchen kernel: [<c024639f>] rollback_registered+0x95/0xe3
Jul 11 15:39:29 wangchen kernel: [<c024641c>] unregister_netdevice+0x2f/0x51
Jul 11 15:39:29 wangchen kernel: [<c0284e1a>] vif_delete+0xaf/0xc3
Jul 11 15:39:29 wangchen kernel: [<c0285eee>] ip_mroute_setsockopt+0x47a/0x801
Jul 11 15:39:29 wangchen kernel: [<eea5a70c>] do_get_write_access+0x2df/0x313 [jbd]
Jul 11 15:39:29 wangchen kernel: [<c01727c4>] __find_get_block_slow+0xda/0xe4
Jul 11 15:39:29 wangchen kernel: [<c0172a7f>] __find_get_block+0xf8/0x122
Jul 11 15:39:29 wangchen kernel: [<c0172a7f>] __find_get_block+0xf8/0x122
Jul 11 15:39:29 wangchen kernel: [<eea5d563>] journal_cancel_revoke+0xda/0x110 [jbd]
Jul 11 15:39:29 wangchen kernel: [<c0263501>] ip_setsockopt+0xa9/0x9ee
Jul 11 15:39:29 wangchen kernel: [<eea5d563>] journal_cancel_revoke+0xda/0x110 [jbd]
Jul 11 15:39:29 wangchen kernel: [<eea5a70c>] do_get_write_access+0x2df/0x313 [jbd]
Jul 11 15:39:29 wangchen kernel: [<eea69287>] __ext3_get_inode_loc+0xcf/0x271 [ext3]
Jul 11 15:39:29 wangchen kernel: [<eea743c7>] __ext3_journal_dirty_metadata+0x13/0x32 [ext3]
Jul 11 15:39:29 wangchen kernel: [<c0116434>] __wake_up+0xf/0x15
Jul 11 15:39:29 wangchen kernel: [<eea5a424>] journal_stop+0x1bd/0x1c6 [jbd]
Jul 11 15:39:29 wangchen kernel: [<eea703a7>] __ext3_journal_stop+0x19/0x34 [ext3]
Jul 11 15:39:29 wangchen kernel: [<c014291e>] get_page_from_freelist+0x94/0x369
Jul 11 15:39:29 wangchen kernel: [<c01408f2>] filemap_fault+0x1ac/0x2fe
Jul 11 15:39:29 wangchen kernel: [<c01a605e>] security_sk_alloc+0xd/0xf
Jul 11 15:39:29 wangchen kernel: [<c023edea>] sk_prot_alloc+0x36/0x78
Jul 11 15:39:29 wangchen kernel: [<c0240037>] sk_alloc+0x3a/0x40
Jul 11 15:39:29 wangchen kernel: [<c0276062>] raw_hash_sk+0x46/0x4e
Jul 11 15:39:29 wangchen kernel: [<c0166aff>] d_alloc+0x1b/0x157
Jul 11 15:39:29 wangchen kernel: [<c023e4d1>] sock_common_setsockopt+0x12/0x16
Jul 11 15:39:29 wangchen kernel: [<c023cb1e>] sys_setsockopt+0x6f/0x8e
Jul 11 15:39:29 wangchen kernel: [<c023e105>] sys_socketcall+0x15c/0x19e
Jul 11 15:39:29 wangchen kernel: [<c0103611>] sysenter_past_esp+0x6a/0x99
Jul 11 15:39:29 wangchen kernel: [<c0290000>] unix_poll+0x69/0x78
Jul 11 15:39:29 wangchen kernel: =======================
Jul 11 15:39:29 wangchen kernel: Code: 83 e0 01 00 00 85 c0 75 1f 53 53 68 12 81 31 c0 e8 3c 30 ed ff ba 3f 0e 00 00 b8 b9 7f 31 c0 83 c4 0c 5b e9 f5 26 ed ff 48 74 04 <0f> 0b eb fe 89 d8 e8 21 ff ff ff 89 d8 e8 62 ea ff ff c7 83 e0
Jul 11 15:39:29 wangchen kernel: EIP: [<c024636b>] rollback_registered+0x61/0xe3 SS:ESP 0068:ed8e7c3c
Jul 11 15:39:29 wangchen kernel: ---[ end trace c311acf85d169786 ]---
===
Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2008-07-15 07:56:34 +04:00
|
|
|
static int vif_delete(int vifi, int notify)
|
2005-04-17 02:20:36 +04:00
|
|
|
{
|
|
|
|
struct vif_device *v;
|
|
|
|
struct net_device *dev;
|
|
|
|
struct in_device *in_dev;
|
|
|
|
|
|
|
|
if (vifi < 0 || vifi >= maxvif)
|
|
|
|
return -EADDRNOTAVAIL;
|
|
|
|
|
|
|
|
v = &vif_table[vifi];
|
|
|
|
|
|
|
|
write_lock_bh(&mrt_lock);
|
|
|
|
dev = v->dev;
|
|
|
|
v->dev = NULL;
|
|
|
|
|
|
|
|
if (!dev) {
|
|
|
|
write_unlock_bh(&mrt_lock);
|
|
|
|
return -EADDRNOTAVAIL;
|
|
|
|
}
|
|
|
|
|
|
|
|
#ifdef CONFIG_IP_PIMSM
|
|
|
|
if (vifi == reg_vif_num)
|
|
|
|
reg_vif_num = -1;
|
|
|
|
#endif
|
|
|
|
|
|
|
|
if (vifi+1 == maxvif) {
|
|
|
|
int tmp;
|
|
|
|
for (tmp=vifi-1; tmp>=0; tmp--) {
|
|
|
|
if (VIF_EXISTS(tmp))
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
maxvif = tmp+1;
|
|
|
|
}
|
|
|
|
|
|
|
|
write_unlock_bh(&mrt_lock);
|
|
|
|
|
|
|
|
dev_set_allmulti(dev, -1);
|
|
|
|
|
2005-10-04 01:35:55 +04:00
|
|
|
if ((in_dev = __in_dev_get_rtnl(dev)) != NULL) {
|
2007-06-05 10:34:44 +04:00
|
|
|
IPV4_DEVCONF(in_dev->cnf, MC_FORWARDING)--;
|
2005-04-17 02:20:36 +04:00
|
|
|
ip_rt_multicast_event(in_dev);
|
|
|
|
}
|
|
|
|
|
ipv4: Fix ipmr unregister device oops
An oops happens during device unregister.
The following oops happened when I add two tunnels, which
use a same device, and then delete one tunnel.
Obviously deleting tunnel "A" causes device unregister, which
send a notification, and after receiving notification, ipmr do
unregister again for tunnel "B" which also use same device.
That is wrong.
After receiving notification, ipmr only needs to decrease reference
count and don't do duplicated unregister.
Fortunately, IPv6 side doesn't add tunnel in ip6mr, so it's clean.
This patch fixs:
- unregister device oops
- using after dev_put()
Here is the oops:
===
Jul 11 15:39:29 wangchen kernel: ------------[ cut here ]------------
Jul 11 15:39:29 wangchen kernel: kernel BUG at net/core/dev.c:3651!
Jul 11 15:39:29 wangchen kernel: invalid opcode: 0000 [#1]
Jul 11 15:39:29 wangchen kernel: Modules linked in: ipip tunnel4 nfsd lockd nfs_acl auth_rpcgss sunrpc exportfs ipv6 snd_pcm_oss snd_mixer_oss snd_seq snd_seq_device af_packet binfmt_misc button battery ac loop dm_mod usbhid ff_memless pcmcia firmware_class ohci1394 8139too mii ieee1394 yenta_socket rsrc_nonstatic pcmcia_core ide_cd_mod cdrom snd_intel8x0 snd_ac97_codec ac97_bus snd_pcm i2c_i801 snd_timer snd i2c_core soundcore snd_page_alloc rng_core shpchp ehci_hcd uhci_hcd pci_hotplug intel_agp agpgart usbcore ext3 jbd ata_piix ahci libata dock edd fan thermal processor thermal_sys piix sd_mod scsi_mod ide_disk ide_core [last unloaded: freq_table]
Jul 11 15:39:29 wangchen kernel:
Jul 11 15:39:29 wangchen kernel: Pid: 4102, comm: mroute Not tainted (2.6.26-rc9-default #69)
Jul 11 15:39:29 wangchen kernel: EIP: 0060:[<c024636b>] EFLAGS: 00010202 CPU: 0
Jul 11 15:39:29 wangchen kernel: EIP is at rollback_registered+0x61/0xe3
Jul 11 15:39:29 wangchen kernel: EAX: 00000001 EBX: ecba6000 ECX: 00000000 EDX: ffffffff
Jul 11 15:39:29 wangchen kernel: ESI: 00000001 EDI: ecba6000 EBP: c03de2e8 ESP: ed8e7c3c
Jul 11 15:39:29 wangchen kernel: DS: 007b ES: 007b FS: 0000 GS: 0033 SS: 0068
Jul 11 15:39:29 wangchen kernel: Process mroute (pid: 4102, ti=ed8e6000 task=ed41e830 task.ti=ed8e6000)
Jul 11 15:39:29 wangchen kernel: Stack: ecba6000 c024641c 00000028 c0284e1a 00000001 c03de2e8 ecba6000 eecff360
Jul 11 15:39:29 wangchen kernel: c0284e4c c03536f4 fffffff8 00000000 c029a819 ecba6000 00000006 ecba6000
Jul 11 15:39:29 wangchen kernel: 00000000 ecba6000 c03de2c0 c012841b ffffffff 00000000 c024639f ecba6000
Jul 11 15:39:29 wangchen kernel: Call Trace:
Jul 11 15:39:29 wangchen kernel: [<c024641c>] unregister_netdevice+0x2f/0x51
Jul 11 15:39:29 wangchen kernel: [<c0284e1a>] vif_delete+0xaf/0xc3
Jul 11 15:39:29 wangchen kernel: [<c0284e4c>] ipmr_device_event+0x1e/0x30
Jul 11 15:39:29 wangchen kernel: [<c029a819>] notifier_call_chain+0x2a/0x47
Jul 11 15:39:29 wangchen kernel: [<c012841b>] raw_notifier_call_chain+0x9/0xc
Jul 11 15:39:29 wangchen kernel: [<c024639f>] rollback_registered+0x95/0xe3
Jul 11 15:39:29 wangchen kernel: [<c024641c>] unregister_netdevice+0x2f/0x51
Jul 11 15:39:29 wangchen kernel: [<c0284e1a>] vif_delete+0xaf/0xc3
Jul 11 15:39:29 wangchen kernel: [<c0285eee>] ip_mroute_setsockopt+0x47a/0x801
Jul 11 15:39:29 wangchen kernel: [<eea5a70c>] do_get_write_access+0x2df/0x313 [jbd]
Jul 11 15:39:29 wangchen kernel: [<c01727c4>] __find_get_block_slow+0xda/0xe4
Jul 11 15:39:29 wangchen kernel: [<c0172a7f>] __find_get_block+0xf8/0x122
Jul 11 15:39:29 wangchen kernel: [<c0172a7f>] __find_get_block+0xf8/0x122
Jul 11 15:39:29 wangchen kernel: [<eea5d563>] journal_cancel_revoke+0xda/0x110 [jbd]
Jul 11 15:39:29 wangchen kernel: [<c0263501>] ip_setsockopt+0xa9/0x9ee
Jul 11 15:39:29 wangchen kernel: [<eea5d563>] journal_cancel_revoke+0xda/0x110 [jbd]
Jul 11 15:39:29 wangchen kernel: [<eea5a70c>] do_get_write_access+0x2df/0x313 [jbd]
Jul 11 15:39:29 wangchen kernel: [<eea69287>] __ext3_get_inode_loc+0xcf/0x271 [ext3]
Jul 11 15:39:29 wangchen kernel: [<eea743c7>] __ext3_journal_dirty_metadata+0x13/0x32 [ext3]
Jul 11 15:39:29 wangchen kernel: [<c0116434>] __wake_up+0xf/0x15
Jul 11 15:39:29 wangchen kernel: [<eea5a424>] journal_stop+0x1bd/0x1c6 [jbd]
Jul 11 15:39:29 wangchen kernel: [<eea703a7>] __ext3_journal_stop+0x19/0x34 [ext3]
Jul 11 15:39:29 wangchen kernel: [<c014291e>] get_page_from_freelist+0x94/0x369
Jul 11 15:39:29 wangchen kernel: [<c01408f2>] filemap_fault+0x1ac/0x2fe
Jul 11 15:39:29 wangchen kernel: [<c01a605e>] security_sk_alloc+0xd/0xf
Jul 11 15:39:29 wangchen kernel: [<c023edea>] sk_prot_alloc+0x36/0x78
Jul 11 15:39:29 wangchen kernel: [<c0240037>] sk_alloc+0x3a/0x40
Jul 11 15:39:29 wangchen kernel: [<c0276062>] raw_hash_sk+0x46/0x4e
Jul 11 15:39:29 wangchen kernel: [<c0166aff>] d_alloc+0x1b/0x157
Jul 11 15:39:29 wangchen kernel: [<c023e4d1>] sock_common_setsockopt+0x12/0x16
Jul 11 15:39:29 wangchen kernel: [<c023cb1e>] sys_setsockopt+0x6f/0x8e
Jul 11 15:39:29 wangchen kernel: [<c023e105>] sys_socketcall+0x15c/0x19e
Jul 11 15:39:29 wangchen kernel: [<c0103611>] sysenter_past_esp+0x6a/0x99
Jul 11 15:39:29 wangchen kernel: [<c0290000>] unix_poll+0x69/0x78
Jul 11 15:39:29 wangchen kernel: =======================
Jul 11 15:39:29 wangchen kernel: Code: 83 e0 01 00 00 85 c0 75 1f 53 53 68 12 81 31 c0 e8 3c 30 ed ff ba 3f 0e 00 00 b8 b9 7f 31 c0 83 c4 0c 5b e9 f5 26 ed ff 48 74 04 <0f> 0b eb fe 89 d8 e8 21 ff ff ff 89 d8 e8 62 ea ff ff c7 83 e0
Jul 11 15:39:29 wangchen kernel: EIP: [<c024636b>] rollback_registered+0x61/0xe3 SS:ESP 0068:ed8e7c3c
Jul 11 15:39:29 wangchen kernel: ---[ end trace c311acf85d169786 ]---
===
Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2008-07-15 07:56:34 +04:00
|
|
|
if (v->flags&(VIFF_TUNNEL|VIFF_REGISTER) && !notify)
|
2005-04-17 02:20:36 +04:00
|
|
|
unregister_netdevice(dev);
|
|
|
|
|
|
|
|
dev_put(dev);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Destroy an unresolved cache entry, killing queued skbs
|
|
|
|
and reporting error to netlink readers.
|
|
|
|
*/
|
|
|
|
|
|
|
|
static void ipmr_destroy_unres(struct mfc_cache *c)
|
|
|
|
{
|
|
|
|
struct sk_buff *skb;
|
2005-06-28 23:55:30 +04:00
|
|
|
struct nlmsgerr *e;
|
2005-04-17 02:20:36 +04:00
|
|
|
|
|
|
|
atomic_dec(&cache_resolve_queue_len);
|
|
|
|
|
2008-11-03 11:28:02 +03:00
|
|
|
while ((skb = skb_dequeue(&c->mfc_un.unres.unresolved))) {
|
2007-04-21 09:47:35 +04:00
|
|
|
if (ip_hdr(skb)->version == 0) {
|
2005-04-17 02:20:36 +04:00
|
|
|
struct nlmsghdr *nlh = (struct nlmsghdr *)skb_pull(skb, sizeof(struct iphdr));
|
|
|
|
nlh->nlmsg_type = NLMSG_ERROR;
|
|
|
|
nlh->nlmsg_len = NLMSG_LENGTH(sizeof(struct nlmsgerr));
|
|
|
|
skb_trim(skb, nlh->nlmsg_len);
|
2005-06-28 23:55:30 +04:00
|
|
|
e = NLMSG_DATA(nlh);
|
|
|
|
e->error = -ETIMEDOUT;
|
|
|
|
memset(&e->msg, 0, sizeof(e->msg));
|
2006-08-15 11:30:25 +04:00
|
|
|
|
2007-11-20 09:26:51 +03:00
|
|
|
rtnl_unicast(skb, &init_net, NETLINK_CB(skb).pid);
|
2005-04-17 02:20:36 +04:00
|
|
|
} else
|
|
|
|
kfree_skb(skb);
|
|
|
|
}
|
|
|
|
|
|
|
|
kmem_cache_free(mrt_cachep, c);
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
/* Single timer process for all the unresolved queue. */
|
|
|
|
|
|
|
|
static void ipmr_expire_process(unsigned long dummy)
|
|
|
|
{
|
|
|
|
unsigned long now;
|
|
|
|
unsigned long expires;
|
|
|
|
struct mfc_cache *c, **cp;
|
|
|
|
|
|
|
|
if (!spin_trylock(&mfc_unres_lock)) {
|
|
|
|
mod_timer(&ipmr_expire_timer, jiffies+HZ/10);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (atomic_read(&cache_resolve_queue_len) == 0)
|
|
|
|
goto out;
|
|
|
|
|
|
|
|
now = jiffies;
|
|
|
|
expires = 10*HZ;
|
|
|
|
cp = &mfc_unres_queue;
|
|
|
|
|
|
|
|
while ((c=*cp) != NULL) {
|
|
|
|
if (time_after(c->mfc_un.unres.expires, now)) {
|
|
|
|
unsigned long interval = c->mfc_un.unres.expires - now;
|
|
|
|
if (interval < expires)
|
|
|
|
expires = interval;
|
|
|
|
cp = &c->next;
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
*cp = c->next;
|
|
|
|
|
|
|
|
ipmr_destroy_unres(c);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (atomic_read(&cache_resolve_queue_len))
|
|
|
|
mod_timer(&ipmr_expire_timer, jiffies + expires);
|
|
|
|
|
|
|
|
out:
|
|
|
|
spin_unlock(&mfc_unres_lock);
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Fill oifs list. It is called under write locked mrt_lock. */
|
|
|
|
|
2005-07-31 04:41:59 +04:00
|
|
|
static void ipmr_update_thresholds(struct mfc_cache *cache, unsigned char *ttls)
|
2005-04-17 02:20:36 +04:00
|
|
|
{
|
|
|
|
int vifi;
|
|
|
|
|
|
|
|
cache->mfc_un.res.minvif = MAXVIFS;
|
|
|
|
cache->mfc_un.res.maxvif = 0;
|
|
|
|
memset(cache->mfc_un.res.ttls, 255, MAXVIFS);
|
|
|
|
|
|
|
|
for (vifi=0; vifi<maxvif; vifi++) {
|
|
|
|
if (VIF_EXISTS(vifi) && ttls[vifi] && ttls[vifi] < 255) {
|
|
|
|
cache->mfc_un.res.ttls[vifi] = ttls[vifi];
|
|
|
|
if (cache->mfc_un.res.minvif > vifi)
|
|
|
|
cache->mfc_un.res.minvif = vifi;
|
|
|
|
if (cache->mfc_un.res.maxvif <= vifi)
|
|
|
|
cache->mfc_un.res.maxvif = vifi + 1;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static int vif_add(struct vifctl *vifc, int mrtsock)
|
|
|
|
{
|
|
|
|
int vifi = vifc->vifc_vifi;
|
|
|
|
struct vif_device *v = &vif_table[vifi];
|
|
|
|
struct net_device *dev;
|
|
|
|
struct in_device *in_dev;
|
2008-07-15 07:55:26 +04:00
|
|
|
int err;
|
2005-04-17 02:20:36 +04:00
|
|
|
|
|
|
|
/* Is vif busy ? */
|
|
|
|
if (VIF_EXISTS(vifi))
|
|
|
|
return -EADDRINUSE;
|
|
|
|
|
|
|
|
switch (vifc->vifc_flags) {
|
|
|
|
#ifdef CONFIG_IP_PIMSM
|
|
|
|
case VIFF_REGISTER:
|
|
|
|
/*
|
|
|
|
* Special Purpose VIF in PIM
|
|
|
|
* All the packets will be sent to the daemon
|
|
|
|
*/
|
|
|
|
if (reg_vif_num >= 0)
|
|
|
|
return -EADDRINUSE;
|
|
|
|
dev = ipmr_reg_vif();
|
|
|
|
if (!dev)
|
|
|
|
return -ENOBUFS;
|
2008-07-15 07:55:26 +04:00
|
|
|
err = dev_set_allmulti(dev, 1);
|
|
|
|
if (err) {
|
|
|
|
unregister_netdevice(dev);
|
ipv4: Fix ipmr unregister device oops
An oops happens during device unregister.
The following oops happened when I add two tunnels, which
use a same device, and then delete one tunnel.
Obviously deleting tunnel "A" causes device unregister, which
send a notification, and after receiving notification, ipmr do
unregister again for tunnel "B" which also use same device.
That is wrong.
After receiving notification, ipmr only needs to decrease reference
count and don't do duplicated unregister.
Fortunately, IPv6 side doesn't add tunnel in ip6mr, so it's clean.
This patch fixs:
- unregister device oops
- using after dev_put()
Here is the oops:
===
Jul 11 15:39:29 wangchen kernel: ------------[ cut here ]------------
Jul 11 15:39:29 wangchen kernel: kernel BUG at net/core/dev.c:3651!
Jul 11 15:39:29 wangchen kernel: invalid opcode: 0000 [#1]
Jul 11 15:39:29 wangchen kernel: Modules linked in: ipip tunnel4 nfsd lockd nfs_acl auth_rpcgss sunrpc exportfs ipv6 snd_pcm_oss snd_mixer_oss snd_seq snd_seq_device af_packet binfmt_misc button battery ac loop dm_mod usbhid ff_memless pcmcia firmware_class ohci1394 8139too mii ieee1394 yenta_socket rsrc_nonstatic pcmcia_core ide_cd_mod cdrom snd_intel8x0 snd_ac97_codec ac97_bus snd_pcm i2c_i801 snd_timer snd i2c_core soundcore snd_page_alloc rng_core shpchp ehci_hcd uhci_hcd pci_hotplug intel_agp agpgart usbcore ext3 jbd ata_piix ahci libata dock edd fan thermal processor thermal_sys piix sd_mod scsi_mod ide_disk ide_core [last unloaded: freq_table]
Jul 11 15:39:29 wangchen kernel:
Jul 11 15:39:29 wangchen kernel: Pid: 4102, comm: mroute Not tainted (2.6.26-rc9-default #69)
Jul 11 15:39:29 wangchen kernel: EIP: 0060:[<c024636b>] EFLAGS: 00010202 CPU: 0
Jul 11 15:39:29 wangchen kernel: EIP is at rollback_registered+0x61/0xe3
Jul 11 15:39:29 wangchen kernel: EAX: 00000001 EBX: ecba6000 ECX: 00000000 EDX: ffffffff
Jul 11 15:39:29 wangchen kernel: ESI: 00000001 EDI: ecba6000 EBP: c03de2e8 ESP: ed8e7c3c
Jul 11 15:39:29 wangchen kernel: DS: 007b ES: 007b FS: 0000 GS: 0033 SS: 0068
Jul 11 15:39:29 wangchen kernel: Process mroute (pid: 4102, ti=ed8e6000 task=ed41e830 task.ti=ed8e6000)
Jul 11 15:39:29 wangchen kernel: Stack: ecba6000 c024641c 00000028 c0284e1a 00000001 c03de2e8 ecba6000 eecff360
Jul 11 15:39:29 wangchen kernel: c0284e4c c03536f4 fffffff8 00000000 c029a819 ecba6000 00000006 ecba6000
Jul 11 15:39:29 wangchen kernel: 00000000 ecba6000 c03de2c0 c012841b ffffffff 00000000 c024639f ecba6000
Jul 11 15:39:29 wangchen kernel: Call Trace:
Jul 11 15:39:29 wangchen kernel: [<c024641c>] unregister_netdevice+0x2f/0x51
Jul 11 15:39:29 wangchen kernel: [<c0284e1a>] vif_delete+0xaf/0xc3
Jul 11 15:39:29 wangchen kernel: [<c0284e4c>] ipmr_device_event+0x1e/0x30
Jul 11 15:39:29 wangchen kernel: [<c029a819>] notifier_call_chain+0x2a/0x47
Jul 11 15:39:29 wangchen kernel: [<c012841b>] raw_notifier_call_chain+0x9/0xc
Jul 11 15:39:29 wangchen kernel: [<c024639f>] rollback_registered+0x95/0xe3
Jul 11 15:39:29 wangchen kernel: [<c024641c>] unregister_netdevice+0x2f/0x51
Jul 11 15:39:29 wangchen kernel: [<c0284e1a>] vif_delete+0xaf/0xc3
Jul 11 15:39:29 wangchen kernel: [<c0285eee>] ip_mroute_setsockopt+0x47a/0x801
Jul 11 15:39:29 wangchen kernel: [<eea5a70c>] do_get_write_access+0x2df/0x313 [jbd]
Jul 11 15:39:29 wangchen kernel: [<c01727c4>] __find_get_block_slow+0xda/0xe4
Jul 11 15:39:29 wangchen kernel: [<c0172a7f>] __find_get_block+0xf8/0x122
Jul 11 15:39:29 wangchen kernel: [<c0172a7f>] __find_get_block+0xf8/0x122
Jul 11 15:39:29 wangchen kernel: [<eea5d563>] journal_cancel_revoke+0xda/0x110 [jbd]
Jul 11 15:39:29 wangchen kernel: [<c0263501>] ip_setsockopt+0xa9/0x9ee
Jul 11 15:39:29 wangchen kernel: [<eea5d563>] journal_cancel_revoke+0xda/0x110 [jbd]
Jul 11 15:39:29 wangchen kernel: [<eea5a70c>] do_get_write_access+0x2df/0x313 [jbd]
Jul 11 15:39:29 wangchen kernel: [<eea69287>] __ext3_get_inode_loc+0xcf/0x271 [ext3]
Jul 11 15:39:29 wangchen kernel: [<eea743c7>] __ext3_journal_dirty_metadata+0x13/0x32 [ext3]
Jul 11 15:39:29 wangchen kernel: [<c0116434>] __wake_up+0xf/0x15
Jul 11 15:39:29 wangchen kernel: [<eea5a424>] journal_stop+0x1bd/0x1c6 [jbd]
Jul 11 15:39:29 wangchen kernel: [<eea703a7>] __ext3_journal_stop+0x19/0x34 [ext3]
Jul 11 15:39:29 wangchen kernel: [<c014291e>] get_page_from_freelist+0x94/0x369
Jul 11 15:39:29 wangchen kernel: [<c01408f2>] filemap_fault+0x1ac/0x2fe
Jul 11 15:39:29 wangchen kernel: [<c01a605e>] security_sk_alloc+0xd/0xf
Jul 11 15:39:29 wangchen kernel: [<c023edea>] sk_prot_alloc+0x36/0x78
Jul 11 15:39:29 wangchen kernel: [<c0240037>] sk_alloc+0x3a/0x40
Jul 11 15:39:29 wangchen kernel: [<c0276062>] raw_hash_sk+0x46/0x4e
Jul 11 15:39:29 wangchen kernel: [<c0166aff>] d_alloc+0x1b/0x157
Jul 11 15:39:29 wangchen kernel: [<c023e4d1>] sock_common_setsockopt+0x12/0x16
Jul 11 15:39:29 wangchen kernel: [<c023cb1e>] sys_setsockopt+0x6f/0x8e
Jul 11 15:39:29 wangchen kernel: [<c023e105>] sys_socketcall+0x15c/0x19e
Jul 11 15:39:29 wangchen kernel: [<c0103611>] sysenter_past_esp+0x6a/0x99
Jul 11 15:39:29 wangchen kernel: [<c0290000>] unix_poll+0x69/0x78
Jul 11 15:39:29 wangchen kernel: =======================
Jul 11 15:39:29 wangchen kernel: Code: 83 e0 01 00 00 85 c0 75 1f 53 53 68 12 81 31 c0 e8 3c 30 ed ff ba 3f 0e 00 00 b8 b9 7f 31 c0 83 c4 0c 5b e9 f5 26 ed ff 48 74 04 <0f> 0b eb fe 89 d8 e8 21 ff ff ff 89 d8 e8 62 ea ff ff c7 83 e0
Jul 11 15:39:29 wangchen kernel: EIP: [<c024636b>] rollback_registered+0x61/0xe3 SS:ESP 0068:ed8e7c3c
Jul 11 15:39:29 wangchen kernel: ---[ end trace c311acf85d169786 ]---
===
Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2008-07-15 07:56:34 +04:00
|
|
|
dev_put(dev);
|
2008-07-15 07:55:26 +04:00
|
|
|
return err;
|
|
|
|
}
|
2005-04-17 02:20:36 +04:00
|
|
|
break;
|
|
|
|
#endif
|
2007-02-09 17:24:47 +03:00
|
|
|
case VIFF_TUNNEL:
|
2005-04-17 02:20:36 +04:00
|
|
|
dev = ipmr_new_tunnel(vifc);
|
|
|
|
if (!dev)
|
|
|
|
return -ENOBUFS;
|
2008-07-15 07:55:26 +04:00
|
|
|
err = dev_set_allmulti(dev, 1);
|
|
|
|
if (err) {
|
|
|
|
ipmr_del_tunnel(dev, vifc);
|
ipv4: Fix ipmr unregister device oops
An oops happens during device unregister.
The following oops happened when I add two tunnels, which
use a same device, and then delete one tunnel.
Obviously deleting tunnel "A" causes device unregister, which
send a notification, and after receiving notification, ipmr do
unregister again for tunnel "B" which also use same device.
That is wrong.
After receiving notification, ipmr only needs to decrease reference
count and don't do duplicated unregister.
Fortunately, IPv6 side doesn't add tunnel in ip6mr, so it's clean.
This patch fixs:
- unregister device oops
- using after dev_put()
Here is the oops:
===
Jul 11 15:39:29 wangchen kernel: ------------[ cut here ]------------
Jul 11 15:39:29 wangchen kernel: kernel BUG at net/core/dev.c:3651!
Jul 11 15:39:29 wangchen kernel: invalid opcode: 0000 [#1]
Jul 11 15:39:29 wangchen kernel: Modules linked in: ipip tunnel4 nfsd lockd nfs_acl auth_rpcgss sunrpc exportfs ipv6 snd_pcm_oss snd_mixer_oss snd_seq snd_seq_device af_packet binfmt_misc button battery ac loop dm_mod usbhid ff_memless pcmcia firmware_class ohci1394 8139too mii ieee1394 yenta_socket rsrc_nonstatic pcmcia_core ide_cd_mod cdrom snd_intel8x0 snd_ac97_codec ac97_bus snd_pcm i2c_i801 snd_timer snd i2c_core soundcore snd_page_alloc rng_core shpchp ehci_hcd uhci_hcd pci_hotplug intel_agp agpgart usbcore ext3 jbd ata_piix ahci libata dock edd fan thermal processor thermal_sys piix sd_mod scsi_mod ide_disk ide_core [last unloaded: freq_table]
Jul 11 15:39:29 wangchen kernel:
Jul 11 15:39:29 wangchen kernel: Pid: 4102, comm: mroute Not tainted (2.6.26-rc9-default #69)
Jul 11 15:39:29 wangchen kernel: EIP: 0060:[<c024636b>] EFLAGS: 00010202 CPU: 0
Jul 11 15:39:29 wangchen kernel: EIP is at rollback_registered+0x61/0xe3
Jul 11 15:39:29 wangchen kernel: EAX: 00000001 EBX: ecba6000 ECX: 00000000 EDX: ffffffff
Jul 11 15:39:29 wangchen kernel: ESI: 00000001 EDI: ecba6000 EBP: c03de2e8 ESP: ed8e7c3c
Jul 11 15:39:29 wangchen kernel: DS: 007b ES: 007b FS: 0000 GS: 0033 SS: 0068
Jul 11 15:39:29 wangchen kernel: Process mroute (pid: 4102, ti=ed8e6000 task=ed41e830 task.ti=ed8e6000)
Jul 11 15:39:29 wangchen kernel: Stack: ecba6000 c024641c 00000028 c0284e1a 00000001 c03de2e8 ecba6000 eecff360
Jul 11 15:39:29 wangchen kernel: c0284e4c c03536f4 fffffff8 00000000 c029a819 ecba6000 00000006 ecba6000
Jul 11 15:39:29 wangchen kernel: 00000000 ecba6000 c03de2c0 c012841b ffffffff 00000000 c024639f ecba6000
Jul 11 15:39:29 wangchen kernel: Call Trace:
Jul 11 15:39:29 wangchen kernel: [<c024641c>] unregister_netdevice+0x2f/0x51
Jul 11 15:39:29 wangchen kernel: [<c0284e1a>] vif_delete+0xaf/0xc3
Jul 11 15:39:29 wangchen kernel: [<c0284e4c>] ipmr_device_event+0x1e/0x30
Jul 11 15:39:29 wangchen kernel: [<c029a819>] notifier_call_chain+0x2a/0x47
Jul 11 15:39:29 wangchen kernel: [<c012841b>] raw_notifier_call_chain+0x9/0xc
Jul 11 15:39:29 wangchen kernel: [<c024639f>] rollback_registered+0x95/0xe3
Jul 11 15:39:29 wangchen kernel: [<c024641c>] unregister_netdevice+0x2f/0x51
Jul 11 15:39:29 wangchen kernel: [<c0284e1a>] vif_delete+0xaf/0xc3
Jul 11 15:39:29 wangchen kernel: [<c0285eee>] ip_mroute_setsockopt+0x47a/0x801
Jul 11 15:39:29 wangchen kernel: [<eea5a70c>] do_get_write_access+0x2df/0x313 [jbd]
Jul 11 15:39:29 wangchen kernel: [<c01727c4>] __find_get_block_slow+0xda/0xe4
Jul 11 15:39:29 wangchen kernel: [<c0172a7f>] __find_get_block+0xf8/0x122
Jul 11 15:39:29 wangchen kernel: [<c0172a7f>] __find_get_block+0xf8/0x122
Jul 11 15:39:29 wangchen kernel: [<eea5d563>] journal_cancel_revoke+0xda/0x110 [jbd]
Jul 11 15:39:29 wangchen kernel: [<c0263501>] ip_setsockopt+0xa9/0x9ee
Jul 11 15:39:29 wangchen kernel: [<eea5d563>] journal_cancel_revoke+0xda/0x110 [jbd]
Jul 11 15:39:29 wangchen kernel: [<eea5a70c>] do_get_write_access+0x2df/0x313 [jbd]
Jul 11 15:39:29 wangchen kernel: [<eea69287>] __ext3_get_inode_loc+0xcf/0x271 [ext3]
Jul 11 15:39:29 wangchen kernel: [<eea743c7>] __ext3_journal_dirty_metadata+0x13/0x32 [ext3]
Jul 11 15:39:29 wangchen kernel: [<c0116434>] __wake_up+0xf/0x15
Jul 11 15:39:29 wangchen kernel: [<eea5a424>] journal_stop+0x1bd/0x1c6 [jbd]
Jul 11 15:39:29 wangchen kernel: [<eea703a7>] __ext3_journal_stop+0x19/0x34 [ext3]
Jul 11 15:39:29 wangchen kernel: [<c014291e>] get_page_from_freelist+0x94/0x369
Jul 11 15:39:29 wangchen kernel: [<c01408f2>] filemap_fault+0x1ac/0x2fe
Jul 11 15:39:29 wangchen kernel: [<c01a605e>] security_sk_alloc+0xd/0xf
Jul 11 15:39:29 wangchen kernel: [<c023edea>] sk_prot_alloc+0x36/0x78
Jul 11 15:39:29 wangchen kernel: [<c0240037>] sk_alloc+0x3a/0x40
Jul 11 15:39:29 wangchen kernel: [<c0276062>] raw_hash_sk+0x46/0x4e
Jul 11 15:39:29 wangchen kernel: [<c0166aff>] d_alloc+0x1b/0x157
Jul 11 15:39:29 wangchen kernel: [<c023e4d1>] sock_common_setsockopt+0x12/0x16
Jul 11 15:39:29 wangchen kernel: [<c023cb1e>] sys_setsockopt+0x6f/0x8e
Jul 11 15:39:29 wangchen kernel: [<c023e105>] sys_socketcall+0x15c/0x19e
Jul 11 15:39:29 wangchen kernel: [<c0103611>] sysenter_past_esp+0x6a/0x99
Jul 11 15:39:29 wangchen kernel: [<c0290000>] unix_poll+0x69/0x78
Jul 11 15:39:29 wangchen kernel: =======================
Jul 11 15:39:29 wangchen kernel: Code: 83 e0 01 00 00 85 c0 75 1f 53 53 68 12 81 31 c0 e8 3c 30 ed ff ba 3f 0e 00 00 b8 b9 7f 31 c0 83 c4 0c 5b e9 f5 26 ed ff 48 74 04 <0f> 0b eb fe 89 d8 e8 21 ff ff ff 89 d8 e8 62 ea ff ff c7 83 e0
Jul 11 15:39:29 wangchen kernel: EIP: [<c024636b>] rollback_registered+0x61/0xe3 SS:ESP 0068:ed8e7c3c
Jul 11 15:39:29 wangchen kernel: ---[ end trace c311acf85d169786 ]---
===
Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2008-07-15 07:56:34 +04:00
|
|
|
dev_put(dev);
|
2008-07-15 07:55:26 +04:00
|
|
|
return err;
|
|
|
|
}
|
2005-04-17 02:20:36 +04:00
|
|
|
break;
|
|
|
|
case 0:
|
2008-01-23 09:04:30 +03:00
|
|
|
dev = ip_dev_find(&init_net, vifc->vifc_lcl_addr.s_addr);
|
2005-04-17 02:20:36 +04:00
|
|
|
if (!dev)
|
|
|
|
return -EADDRNOTAVAIL;
|
2008-07-15 07:55:26 +04:00
|
|
|
err = dev_set_allmulti(dev, 1);
|
ipv4: Fix ipmr unregister device oops
An oops happens during device unregister.
The following oops happened when I add two tunnels, which
use a same device, and then delete one tunnel.
Obviously deleting tunnel "A" causes device unregister, which
send a notification, and after receiving notification, ipmr do
unregister again for tunnel "B" which also use same device.
That is wrong.
After receiving notification, ipmr only needs to decrease reference
count and don't do duplicated unregister.
Fortunately, IPv6 side doesn't add tunnel in ip6mr, so it's clean.
This patch fixs:
- unregister device oops
- using after dev_put()
Here is the oops:
===
Jul 11 15:39:29 wangchen kernel: ------------[ cut here ]------------
Jul 11 15:39:29 wangchen kernel: kernel BUG at net/core/dev.c:3651!
Jul 11 15:39:29 wangchen kernel: invalid opcode: 0000 [#1]
Jul 11 15:39:29 wangchen kernel: Modules linked in: ipip tunnel4 nfsd lockd nfs_acl auth_rpcgss sunrpc exportfs ipv6 snd_pcm_oss snd_mixer_oss snd_seq snd_seq_device af_packet binfmt_misc button battery ac loop dm_mod usbhid ff_memless pcmcia firmware_class ohci1394 8139too mii ieee1394 yenta_socket rsrc_nonstatic pcmcia_core ide_cd_mod cdrom snd_intel8x0 snd_ac97_codec ac97_bus snd_pcm i2c_i801 snd_timer snd i2c_core soundcore snd_page_alloc rng_core shpchp ehci_hcd uhci_hcd pci_hotplug intel_agp agpgart usbcore ext3 jbd ata_piix ahci libata dock edd fan thermal processor thermal_sys piix sd_mod scsi_mod ide_disk ide_core [last unloaded: freq_table]
Jul 11 15:39:29 wangchen kernel:
Jul 11 15:39:29 wangchen kernel: Pid: 4102, comm: mroute Not tainted (2.6.26-rc9-default #69)
Jul 11 15:39:29 wangchen kernel: EIP: 0060:[<c024636b>] EFLAGS: 00010202 CPU: 0
Jul 11 15:39:29 wangchen kernel: EIP is at rollback_registered+0x61/0xe3
Jul 11 15:39:29 wangchen kernel: EAX: 00000001 EBX: ecba6000 ECX: 00000000 EDX: ffffffff
Jul 11 15:39:29 wangchen kernel: ESI: 00000001 EDI: ecba6000 EBP: c03de2e8 ESP: ed8e7c3c
Jul 11 15:39:29 wangchen kernel: DS: 007b ES: 007b FS: 0000 GS: 0033 SS: 0068
Jul 11 15:39:29 wangchen kernel: Process mroute (pid: 4102, ti=ed8e6000 task=ed41e830 task.ti=ed8e6000)
Jul 11 15:39:29 wangchen kernel: Stack: ecba6000 c024641c 00000028 c0284e1a 00000001 c03de2e8 ecba6000 eecff360
Jul 11 15:39:29 wangchen kernel: c0284e4c c03536f4 fffffff8 00000000 c029a819 ecba6000 00000006 ecba6000
Jul 11 15:39:29 wangchen kernel: 00000000 ecba6000 c03de2c0 c012841b ffffffff 00000000 c024639f ecba6000
Jul 11 15:39:29 wangchen kernel: Call Trace:
Jul 11 15:39:29 wangchen kernel: [<c024641c>] unregister_netdevice+0x2f/0x51
Jul 11 15:39:29 wangchen kernel: [<c0284e1a>] vif_delete+0xaf/0xc3
Jul 11 15:39:29 wangchen kernel: [<c0284e4c>] ipmr_device_event+0x1e/0x30
Jul 11 15:39:29 wangchen kernel: [<c029a819>] notifier_call_chain+0x2a/0x47
Jul 11 15:39:29 wangchen kernel: [<c012841b>] raw_notifier_call_chain+0x9/0xc
Jul 11 15:39:29 wangchen kernel: [<c024639f>] rollback_registered+0x95/0xe3
Jul 11 15:39:29 wangchen kernel: [<c024641c>] unregister_netdevice+0x2f/0x51
Jul 11 15:39:29 wangchen kernel: [<c0284e1a>] vif_delete+0xaf/0xc3
Jul 11 15:39:29 wangchen kernel: [<c0285eee>] ip_mroute_setsockopt+0x47a/0x801
Jul 11 15:39:29 wangchen kernel: [<eea5a70c>] do_get_write_access+0x2df/0x313 [jbd]
Jul 11 15:39:29 wangchen kernel: [<c01727c4>] __find_get_block_slow+0xda/0xe4
Jul 11 15:39:29 wangchen kernel: [<c0172a7f>] __find_get_block+0xf8/0x122
Jul 11 15:39:29 wangchen kernel: [<c0172a7f>] __find_get_block+0xf8/0x122
Jul 11 15:39:29 wangchen kernel: [<eea5d563>] journal_cancel_revoke+0xda/0x110 [jbd]
Jul 11 15:39:29 wangchen kernel: [<c0263501>] ip_setsockopt+0xa9/0x9ee
Jul 11 15:39:29 wangchen kernel: [<eea5d563>] journal_cancel_revoke+0xda/0x110 [jbd]
Jul 11 15:39:29 wangchen kernel: [<eea5a70c>] do_get_write_access+0x2df/0x313 [jbd]
Jul 11 15:39:29 wangchen kernel: [<eea69287>] __ext3_get_inode_loc+0xcf/0x271 [ext3]
Jul 11 15:39:29 wangchen kernel: [<eea743c7>] __ext3_journal_dirty_metadata+0x13/0x32 [ext3]
Jul 11 15:39:29 wangchen kernel: [<c0116434>] __wake_up+0xf/0x15
Jul 11 15:39:29 wangchen kernel: [<eea5a424>] journal_stop+0x1bd/0x1c6 [jbd]
Jul 11 15:39:29 wangchen kernel: [<eea703a7>] __ext3_journal_stop+0x19/0x34 [ext3]
Jul 11 15:39:29 wangchen kernel: [<c014291e>] get_page_from_freelist+0x94/0x369
Jul 11 15:39:29 wangchen kernel: [<c01408f2>] filemap_fault+0x1ac/0x2fe
Jul 11 15:39:29 wangchen kernel: [<c01a605e>] security_sk_alloc+0xd/0xf
Jul 11 15:39:29 wangchen kernel: [<c023edea>] sk_prot_alloc+0x36/0x78
Jul 11 15:39:29 wangchen kernel: [<c0240037>] sk_alloc+0x3a/0x40
Jul 11 15:39:29 wangchen kernel: [<c0276062>] raw_hash_sk+0x46/0x4e
Jul 11 15:39:29 wangchen kernel: [<c0166aff>] d_alloc+0x1b/0x157
Jul 11 15:39:29 wangchen kernel: [<c023e4d1>] sock_common_setsockopt+0x12/0x16
Jul 11 15:39:29 wangchen kernel: [<c023cb1e>] sys_setsockopt+0x6f/0x8e
Jul 11 15:39:29 wangchen kernel: [<c023e105>] sys_socketcall+0x15c/0x19e
Jul 11 15:39:29 wangchen kernel: [<c0103611>] sysenter_past_esp+0x6a/0x99
Jul 11 15:39:29 wangchen kernel: [<c0290000>] unix_poll+0x69/0x78
Jul 11 15:39:29 wangchen kernel: =======================
Jul 11 15:39:29 wangchen kernel: Code: 83 e0 01 00 00 85 c0 75 1f 53 53 68 12 81 31 c0 e8 3c 30 ed ff ba 3f 0e 00 00 b8 b9 7f 31 c0 83 c4 0c 5b e9 f5 26 ed ff 48 74 04 <0f> 0b eb fe 89 d8 e8 21 ff ff ff 89 d8 e8 62 ea ff ff c7 83 e0
Jul 11 15:39:29 wangchen kernel: EIP: [<c024636b>] rollback_registered+0x61/0xe3 SS:ESP 0068:ed8e7c3c
Jul 11 15:39:29 wangchen kernel: ---[ end trace c311acf85d169786 ]---
===
Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2008-07-15 07:56:34 +04:00
|
|
|
if (err) {
|
|
|
|
dev_put(dev);
|
2008-07-15 07:55:26 +04:00
|
|
|
return err;
|
ipv4: Fix ipmr unregister device oops
An oops happens during device unregister.
The following oops happened when I add two tunnels, which
use a same device, and then delete one tunnel.
Obviously deleting tunnel "A" causes device unregister, which
send a notification, and after receiving notification, ipmr do
unregister again for tunnel "B" which also use same device.
That is wrong.
After receiving notification, ipmr only needs to decrease reference
count and don't do duplicated unregister.
Fortunately, IPv6 side doesn't add tunnel in ip6mr, so it's clean.
This patch fixs:
- unregister device oops
- using after dev_put()
Here is the oops:
===
Jul 11 15:39:29 wangchen kernel: ------------[ cut here ]------------
Jul 11 15:39:29 wangchen kernel: kernel BUG at net/core/dev.c:3651!
Jul 11 15:39:29 wangchen kernel: invalid opcode: 0000 [#1]
Jul 11 15:39:29 wangchen kernel: Modules linked in: ipip tunnel4 nfsd lockd nfs_acl auth_rpcgss sunrpc exportfs ipv6 snd_pcm_oss snd_mixer_oss snd_seq snd_seq_device af_packet binfmt_misc button battery ac loop dm_mod usbhid ff_memless pcmcia firmware_class ohci1394 8139too mii ieee1394 yenta_socket rsrc_nonstatic pcmcia_core ide_cd_mod cdrom snd_intel8x0 snd_ac97_codec ac97_bus snd_pcm i2c_i801 snd_timer snd i2c_core soundcore snd_page_alloc rng_core shpchp ehci_hcd uhci_hcd pci_hotplug intel_agp agpgart usbcore ext3 jbd ata_piix ahci libata dock edd fan thermal processor thermal_sys piix sd_mod scsi_mod ide_disk ide_core [last unloaded: freq_table]
Jul 11 15:39:29 wangchen kernel:
Jul 11 15:39:29 wangchen kernel: Pid: 4102, comm: mroute Not tainted (2.6.26-rc9-default #69)
Jul 11 15:39:29 wangchen kernel: EIP: 0060:[<c024636b>] EFLAGS: 00010202 CPU: 0
Jul 11 15:39:29 wangchen kernel: EIP is at rollback_registered+0x61/0xe3
Jul 11 15:39:29 wangchen kernel: EAX: 00000001 EBX: ecba6000 ECX: 00000000 EDX: ffffffff
Jul 11 15:39:29 wangchen kernel: ESI: 00000001 EDI: ecba6000 EBP: c03de2e8 ESP: ed8e7c3c
Jul 11 15:39:29 wangchen kernel: DS: 007b ES: 007b FS: 0000 GS: 0033 SS: 0068
Jul 11 15:39:29 wangchen kernel: Process mroute (pid: 4102, ti=ed8e6000 task=ed41e830 task.ti=ed8e6000)
Jul 11 15:39:29 wangchen kernel: Stack: ecba6000 c024641c 00000028 c0284e1a 00000001 c03de2e8 ecba6000 eecff360
Jul 11 15:39:29 wangchen kernel: c0284e4c c03536f4 fffffff8 00000000 c029a819 ecba6000 00000006 ecba6000
Jul 11 15:39:29 wangchen kernel: 00000000 ecba6000 c03de2c0 c012841b ffffffff 00000000 c024639f ecba6000
Jul 11 15:39:29 wangchen kernel: Call Trace:
Jul 11 15:39:29 wangchen kernel: [<c024641c>] unregister_netdevice+0x2f/0x51
Jul 11 15:39:29 wangchen kernel: [<c0284e1a>] vif_delete+0xaf/0xc3
Jul 11 15:39:29 wangchen kernel: [<c0284e4c>] ipmr_device_event+0x1e/0x30
Jul 11 15:39:29 wangchen kernel: [<c029a819>] notifier_call_chain+0x2a/0x47
Jul 11 15:39:29 wangchen kernel: [<c012841b>] raw_notifier_call_chain+0x9/0xc
Jul 11 15:39:29 wangchen kernel: [<c024639f>] rollback_registered+0x95/0xe3
Jul 11 15:39:29 wangchen kernel: [<c024641c>] unregister_netdevice+0x2f/0x51
Jul 11 15:39:29 wangchen kernel: [<c0284e1a>] vif_delete+0xaf/0xc3
Jul 11 15:39:29 wangchen kernel: [<c0285eee>] ip_mroute_setsockopt+0x47a/0x801
Jul 11 15:39:29 wangchen kernel: [<eea5a70c>] do_get_write_access+0x2df/0x313 [jbd]
Jul 11 15:39:29 wangchen kernel: [<c01727c4>] __find_get_block_slow+0xda/0xe4
Jul 11 15:39:29 wangchen kernel: [<c0172a7f>] __find_get_block+0xf8/0x122
Jul 11 15:39:29 wangchen kernel: [<c0172a7f>] __find_get_block+0xf8/0x122
Jul 11 15:39:29 wangchen kernel: [<eea5d563>] journal_cancel_revoke+0xda/0x110 [jbd]
Jul 11 15:39:29 wangchen kernel: [<c0263501>] ip_setsockopt+0xa9/0x9ee
Jul 11 15:39:29 wangchen kernel: [<eea5d563>] journal_cancel_revoke+0xda/0x110 [jbd]
Jul 11 15:39:29 wangchen kernel: [<eea5a70c>] do_get_write_access+0x2df/0x313 [jbd]
Jul 11 15:39:29 wangchen kernel: [<eea69287>] __ext3_get_inode_loc+0xcf/0x271 [ext3]
Jul 11 15:39:29 wangchen kernel: [<eea743c7>] __ext3_journal_dirty_metadata+0x13/0x32 [ext3]
Jul 11 15:39:29 wangchen kernel: [<c0116434>] __wake_up+0xf/0x15
Jul 11 15:39:29 wangchen kernel: [<eea5a424>] journal_stop+0x1bd/0x1c6 [jbd]
Jul 11 15:39:29 wangchen kernel: [<eea703a7>] __ext3_journal_stop+0x19/0x34 [ext3]
Jul 11 15:39:29 wangchen kernel: [<c014291e>] get_page_from_freelist+0x94/0x369
Jul 11 15:39:29 wangchen kernel: [<c01408f2>] filemap_fault+0x1ac/0x2fe
Jul 11 15:39:29 wangchen kernel: [<c01a605e>] security_sk_alloc+0xd/0xf
Jul 11 15:39:29 wangchen kernel: [<c023edea>] sk_prot_alloc+0x36/0x78
Jul 11 15:39:29 wangchen kernel: [<c0240037>] sk_alloc+0x3a/0x40
Jul 11 15:39:29 wangchen kernel: [<c0276062>] raw_hash_sk+0x46/0x4e
Jul 11 15:39:29 wangchen kernel: [<c0166aff>] d_alloc+0x1b/0x157
Jul 11 15:39:29 wangchen kernel: [<c023e4d1>] sock_common_setsockopt+0x12/0x16
Jul 11 15:39:29 wangchen kernel: [<c023cb1e>] sys_setsockopt+0x6f/0x8e
Jul 11 15:39:29 wangchen kernel: [<c023e105>] sys_socketcall+0x15c/0x19e
Jul 11 15:39:29 wangchen kernel: [<c0103611>] sysenter_past_esp+0x6a/0x99
Jul 11 15:39:29 wangchen kernel: [<c0290000>] unix_poll+0x69/0x78
Jul 11 15:39:29 wangchen kernel: =======================
Jul 11 15:39:29 wangchen kernel: Code: 83 e0 01 00 00 85 c0 75 1f 53 53 68 12 81 31 c0 e8 3c 30 ed ff ba 3f 0e 00 00 b8 b9 7f 31 c0 83 c4 0c 5b e9 f5 26 ed ff 48 74 04 <0f> 0b eb fe 89 d8 e8 21 ff ff ff 89 d8 e8 62 ea ff ff c7 83 e0
Jul 11 15:39:29 wangchen kernel: EIP: [<c024636b>] rollback_registered+0x61/0xe3 SS:ESP 0068:ed8e7c3c
Jul 11 15:39:29 wangchen kernel: ---[ end trace c311acf85d169786 ]---
===
Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2008-07-15 07:56:34 +04:00
|
|
|
}
|
2005-04-17 02:20:36 +04:00
|
|
|
break;
|
|
|
|
default:
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
2005-10-04 01:35:55 +04:00
|
|
|
if ((in_dev = __in_dev_get_rtnl(dev)) == NULL)
|
2005-04-17 02:20:36 +04:00
|
|
|
return -EADDRNOTAVAIL;
|
2007-06-05 10:34:44 +04:00
|
|
|
IPV4_DEVCONF(in_dev->cnf, MC_FORWARDING)++;
|
2005-04-17 02:20:36 +04:00
|
|
|
ip_rt_multicast_event(in_dev);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Fill in the VIF structures
|
|
|
|
*/
|
2008-11-03 11:28:02 +03:00
|
|
|
v->rate_limit = vifc->vifc_rate_limit;
|
|
|
|
v->local = vifc->vifc_lcl_addr.s_addr;
|
|
|
|
v->remote = vifc->vifc_rmt_addr.s_addr;
|
|
|
|
v->flags = vifc->vifc_flags;
|
2005-04-17 02:20:36 +04:00
|
|
|
if (!mrtsock)
|
|
|
|
v->flags |= VIFF_STATIC;
|
2008-11-03 11:28:02 +03:00
|
|
|
v->threshold = vifc->vifc_threshold;
|
2005-04-17 02:20:36 +04:00
|
|
|
v->bytes_in = 0;
|
|
|
|
v->bytes_out = 0;
|
|
|
|
v->pkt_in = 0;
|
|
|
|
v->pkt_out = 0;
|
|
|
|
v->link = dev->ifindex;
|
|
|
|
if (v->flags&(VIFF_TUNNEL|VIFF_REGISTER))
|
|
|
|
v->link = dev->iflink;
|
|
|
|
|
|
|
|
/* And finish update writing critical data */
|
|
|
|
write_lock_bh(&mrt_lock);
|
2008-11-03 11:28:02 +03:00
|
|
|
v->dev = dev;
|
2005-04-17 02:20:36 +04:00
|
|
|
#ifdef CONFIG_IP_PIMSM
|
|
|
|
if (v->flags&VIFF_REGISTER)
|
|
|
|
reg_vif_num = vifi;
|
|
|
|
#endif
|
|
|
|
if (vifi+1 > maxvif)
|
|
|
|
maxvif = vifi+1;
|
|
|
|
write_unlock_bh(&mrt_lock);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2006-09-28 05:39:29 +04:00
|
|
|
static struct mfc_cache *ipmr_cache_find(__be32 origin, __be32 mcastgrp)
|
2005-04-17 02:20:36 +04:00
|
|
|
{
|
2008-11-03 11:28:02 +03:00
|
|
|
int line = MFC_HASH(mcastgrp, origin);
|
2005-04-17 02:20:36 +04:00
|
|
|
struct mfc_cache *c;
|
|
|
|
|
|
|
|
for (c=mfc_cache_array[line]; c; c = c->next) {
|
|
|
|
if (c->mfc_origin==origin && c->mfc_mcastgrp==mcastgrp)
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
return c;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Allocate a multicast cache entry
|
|
|
|
*/
|
|
|
|
static struct mfc_cache *ipmr_cache_alloc(void)
|
|
|
|
{
|
2008-11-03 11:28:02 +03:00
|
|
|
struct mfc_cache *c = kmem_cache_zalloc(mrt_cachep, GFP_KERNEL);
|
|
|
|
if (c == NULL)
|
2005-04-17 02:20:36 +04:00
|
|
|
return NULL;
|
|
|
|
c->mfc_un.res.minvif = MAXVIFS;
|
|
|
|
return c;
|
|
|
|
}
|
|
|
|
|
|
|
|
static struct mfc_cache *ipmr_cache_alloc_unres(void)
|
|
|
|
{
|
2008-11-03 11:28:02 +03:00
|
|
|
struct mfc_cache *c = kmem_cache_zalloc(mrt_cachep, GFP_ATOMIC);
|
|
|
|
if (c == NULL)
|
2005-04-17 02:20:36 +04:00
|
|
|
return NULL;
|
|
|
|
skb_queue_head_init(&c->mfc_un.unres.unresolved);
|
|
|
|
c->mfc_un.unres.expires = jiffies + 10*HZ;
|
|
|
|
return c;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* A cache entry has gone into a resolved state from queued
|
|
|
|
*/
|
2007-02-09 17:24:47 +03:00
|
|
|
|
2005-04-17 02:20:36 +04:00
|
|
|
static void ipmr_cache_resolve(struct mfc_cache *uc, struct mfc_cache *c)
|
|
|
|
{
|
|
|
|
struct sk_buff *skb;
|
2005-06-28 23:55:30 +04:00
|
|
|
struct nlmsgerr *e;
|
2005-04-17 02:20:36 +04:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Play the pending entries through our router
|
|
|
|
*/
|
|
|
|
|
2008-11-03 11:28:02 +03:00
|
|
|
while ((skb = __skb_dequeue(&uc->mfc_un.unres.unresolved))) {
|
2007-04-21 09:47:35 +04:00
|
|
|
if (ip_hdr(skb)->version == 0) {
|
2005-04-17 02:20:36 +04:00
|
|
|
struct nlmsghdr *nlh = (struct nlmsghdr *)skb_pull(skb, sizeof(struct iphdr));
|
|
|
|
|
|
|
|
if (ipmr_fill_mroute(skb, c, NLMSG_DATA(nlh)) > 0) {
|
2007-04-20 07:29:13 +04:00
|
|
|
nlh->nlmsg_len = (skb_tail_pointer(skb) -
|
|
|
|
(u8 *)nlh);
|
2005-04-17 02:20:36 +04:00
|
|
|
} else {
|
|
|
|
nlh->nlmsg_type = NLMSG_ERROR;
|
|
|
|
nlh->nlmsg_len = NLMSG_LENGTH(sizeof(struct nlmsgerr));
|
|
|
|
skb_trim(skb, nlh->nlmsg_len);
|
2005-06-28 23:55:30 +04:00
|
|
|
e = NLMSG_DATA(nlh);
|
|
|
|
e->error = -EMSGSIZE;
|
|
|
|
memset(&e->msg, 0, sizeof(e->msg));
|
2005-04-17 02:20:36 +04:00
|
|
|
}
|
2006-08-15 11:30:25 +04:00
|
|
|
|
2007-11-20 09:26:51 +03:00
|
|
|
rtnl_unicast(skb, &init_net, NETLINK_CB(skb).pid);
|
2005-04-17 02:20:36 +04:00
|
|
|
} else
|
|
|
|
ip_mr_forward(skb, c, 0);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Bounce a cache query up to mrouted. We could use netlink for this but mrouted
|
|
|
|
* expects the following bizarre scheme.
|
|
|
|
*
|
|
|
|
* Called under mrt_lock.
|
|
|
|
*/
|
2007-02-09 17:24:47 +03:00
|
|
|
|
2005-04-17 02:20:36 +04:00
|
|
|
static int ipmr_cache_report(struct sk_buff *pkt, vifi_t vifi, int assert)
|
|
|
|
{
|
|
|
|
struct sk_buff *skb;
|
2007-03-13 02:09:15 +03:00
|
|
|
const int ihl = ip_hdrlen(pkt);
|
2005-04-17 02:20:36 +04:00
|
|
|
struct igmphdr *igmp;
|
|
|
|
struct igmpmsg *msg;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
#ifdef CONFIG_IP_PIMSM
|
|
|
|
if (assert == IGMPMSG_WHOLEPKT)
|
|
|
|
skb = skb_realloc_headroom(pkt, sizeof(struct iphdr));
|
|
|
|
else
|
|
|
|
#endif
|
|
|
|
skb = alloc_skb(128, GFP_ATOMIC);
|
|
|
|
|
2007-03-09 07:44:43 +03:00
|
|
|
if (!skb)
|
2005-04-17 02:20:36 +04:00
|
|
|
return -ENOBUFS;
|
|
|
|
|
|
|
|
#ifdef CONFIG_IP_PIMSM
|
|
|
|
if (assert == IGMPMSG_WHOLEPKT) {
|
|
|
|
/* Ugly, but we have no choice with this interface.
|
|
|
|
Duplicate old header, fix ihl, length etc.
|
|
|
|
And all this only to mangle msg->im_msgtype and
|
|
|
|
to set msg->im_mbz to "mbz" :-)
|
|
|
|
*/
|
2007-03-12 04:38:29 +03:00
|
|
|
skb_push(skb, sizeof(struct iphdr));
|
|
|
|
skb_reset_network_header(skb);
|
2007-03-13 19:06:52 +03:00
|
|
|
skb_reset_transport_header(skb);
|
2007-03-13 02:05:39 +03:00
|
|
|
msg = (struct igmpmsg *)skb_network_header(skb);
|
2007-04-11 07:50:43 +04:00
|
|
|
memcpy(msg, skb_network_header(pkt), sizeof(struct iphdr));
|
2005-04-17 02:20:36 +04:00
|
|
|
msg->im_msgtype = IGMPMSG_WHOLEPKT;
|
|
|
|
msg->im_mbz = 0;
|
2007-02-09 17:24:47 +03:00
|
|
|
msg->im_vif = reg_vif_num;
|
2007-04-21 09:47:35 +04:00
|
|
|
ip_hdr(skb)->ihl = sizeof(struct iphdr) >> 2;
|
|
|
|
ip_hdr(skb)->tot_len = htons(ntohs(ip_hdr(pkt)->tot_len) +
|
|
|
|
sizeof(struct iphdr));
|
2007-02-09 17:24:47 +03:00
|
|
|
} else
|
2005-04-17 02:20:36 +04:00
|
|
|
#endif
|
2007-02-09 17:24:47 +03:00
|
|
|
{
|
|
|
|
|
2005-04-17 02:20:36 +04:00
|
|
|
/*
|
|
|
|
* Copy the IP header
|
|
|
|
*/
|
|
|
|
|
2007-04-20 07:29:13 +04:00
|
|
|
skb->network_header = skb->tail;
|
2007-03-16 03:42:27 +03:00
|
|
|
skb_put(skb, ihl);
|
2007-03-31 18:55:19 +04:00
|
|
|
skb_copy_to_linear_data(skb, pkt->data, ihl);
|
2007-04-21 09:47:35 +04:00
|
|
|
ip_hdr(skb)->protocol = 0; /* Flag to the kernel this is a route add */
|
|
|
|
msg = (struct igmpmsg *)skb_network_header(skb);
|
2005-04-17 02:20:36 +04:00
|
|
|
msg->im_vif = vifi;
|
|
|
|
skb->dst = dst_clone(pkt->dst);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Add our header
|
|
|
|
*/
|
|
|
|
|
2008-11-03 11:28:02 +03:00
|
|
|
igmp=(struct igmphdr *)skb_put(skb, sizeof(struct igmphdr));
|
2005-04-17 02:20:36 +04:00
|
|
|
igmp->type =
|
|
|
|
msg->im_msgtype = assert;
|
|
|
|
igmp->code = 0;
|
2007-04-21 09:47:35 +04:00
|
|
|
ip_hdr(skb)->tot_len = htons(skb->len); /* Fix the length */
|
2007-04-11 08:21:55 +04:00
|
|
|
skb->transport_header = skb->network_header;
|
2007-02-09 17:24:47 +03:00
|
|
|
}
|
2005-04-17 02:20:36 +04:00
|
|
|
|
|
|
|
if (mroute_socket == NULL) {
|
|
|
|
kfree_skb(skb);
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Deliver to mrouted
|
|
|
|
*/
|
2008-11-03 11:28:02 +03:00
|
|
|
if ((ret = sock_queue_rcv_skb(mroute_socket, skb))<0) {
|
2005-04-17 02:20:36 +04:00
|
|
|
if (net_ratelimit())
|
|
|
|
printk(KERN_WARNING "mroute: pending queue full, dropping entries.\n");
|
|
|
|
kfree_skb(skb);
|
|
|
|
}
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Queue a packet for resolution. It gets locked cache entry!
|
|
|
|
*/
|
2007-02-09 17:24:47 +03:00
|
|
|
|
2005-04-17 02:20:36 +04:00
|
|
|
static int
|
|
|
|
ipmr_cache_unresolved(vifi_t vifi, struct sk_buff *skb)
|
|
|
|
{
|
|
|
|
int err;
|
|
|
|
struct mfc_cache *c;
|
2007-04-21 09:47:35 +04:00
|
|
|
const struct iphdr *iph = ip_hdr(skb);
|
2005-04-17 02:20:36 +04:00
|
|
|
|
|
|
|
spin_lock_bh(&mfc_unres_lock);
|
|
|
|
for (c=mfc_unres_queue; c; c=c->next) {
|
2007-04-21 09:47:35 +04:00
|
|
|
if (c->mfc_mcastgrp == iph->daddr &&
|
|
|
|
c->mfc_origin == iph->saddr)
|
2005-04-17 02:20:36 +04:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (c == NULL) {
|
|
|
|
/*
|
|
|
|
* Create a new entry if allowable
|
|
|
|
*/
|
|
|
|
|
2008-11-03 11:28:02 +03:00
|
|
|
if (atomic_read(&cache_resolve_queue_len) >= 10 ||
|
2005-04-17 02:20:36 +04:00
|
|
|
(c=ipmr_cache_alloc_unres())==NULL) {
|
|
|
|
spin_unlock_bh(&mfc_unres_lock);
|
|
|
|
|
|
|
|
kfree_skb(skb);
|
|
|
|
return -ENOBUFS;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Fill in the new cache entry
|
|
|
|
*/
|
2007-04-21 09:47:35 +04:00
|
|
|
c->mfc_parent = -1;
|
|
|
|
c->mfc_origin = iph->saddr;
|
|
|
|
c->mfc_mcastgrp = iph->daddr;
|
2005-04-17 02:20:36 +04:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Reflect first query at mrouted.
|
|
|
|
*/
|
|
|
|
if ((err = ipmr_cache_report(skb, vifi, IGMPMSG_NOCACHE))<0) {
|
2007-02-09 17:24:47 +03:00
|
|
|
/* If the report failed throw the cache entry
|
2005-04-17 02:20:36 +04:00
|
|
|
out - Brad Parker
|
|
|
|
*/
|
|
|
|
spin_unlock_bh(&mfc_unres_lock);
|
|
|
|
|
|
|
|
kmem_cache_free(mrt_cachep, c);
|
|
|
|
kfree_skb(skb);
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
atomic_inc(&cache_resolve_queue_len);
|
|
|
|
c->next = mfc_unres_queue;
|
|
|
|
mfc_unres_queue = c;
|
|
|
|
|
|
|
|
mod_timer(&ipmr_expire_timer, c->mfc_un.unres.expires);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* See if we can append the packet
|
|
|
|
*/
|
|
|
|
if (c->mfc_un.unres.unresolved.qlen>3) {
|
|
|
|
kfree_skb(skb);
|
|
|
|
err = -ENOBUFS;
|
|
|
|
} else {
|
2008-11-03 11:28:02 +03:00
|
|
|
skb_queue_tail(&c->mfc_un.unres.unresolved, skb);
|
2005-04-17 02:20:36 +04:00
|
|
|
err = 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
spin_unlock_bh(&mfc_unres_lock);
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* MFC cache manipulation by user space mroute daemon
|
|
|
|
*/
|
|
|
|
|
|
|
|
static int ipmr_mfc_delete(struct mfcctl *mfc)
|
|
|
|
{
|
|
|
|
int line;
|
|
|
|
struct mfc_cache *c, **cp;
|
|
|
|
|
2008-11-03 11:28:02 +03:00
|
|
|
line = MFC_HASH(mfc->mfcc_mcastgrp.s_addr, mfc->mfcc_origin.s_addr);
|
2005-04-17 02:20:36 +04:00
|
|
|
|
|
|
|
for (cp=&mfc_cache_array[line]; (c=*cp) != NULL; cp = &c->next) {
|
|
|
|
if (c->mfc_origin == mfc->mfcc_origin.s_addr &&
|
|
|
|
c->mfc_mcastgrp == mfc->mfcc_mcastgrp.s_addr) {
|
|
|
|
write_lock_bh(&mrt_lock);
|
|
|
|
*cp = c->next;
|
|
|
|
write_unlock_bh(&mrt_lock);
|
|
|
|
|
|
|
|
kmem_cache_free(mrt_cachep, c);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return -ENOENT;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int ipmr_mfc_add(struct mfcctl *mfc, int mrtsock)
|
|
|
|
{
|
|
|
|
int line;
|
|
|
|
struct mfc_cache *uc, *c, **cp;
|
|
|
|
|
2008-11-03 11:28:02 +03:00
|
|
|
line = MFC_HASH(mfc->mfcc_mcastgrp.s_addr, mfc->mfcc_origin.s_addr);
|
2005-04-17 02:20:36 +04:00
|
|
|
|
|
|
|
for (cp=&mfc_cache_array[line]; (c=*cp) != NULL; cp = &c->next) {
|
|
|
|
if (c->mfc_origin == mfc->mfcc_origin.s_addr &&
|
|
|
|
c->mfc_mcastgrp == mfc->mfcc_mcastgrp.s_addr)
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (c != NULL) {
|
|
|
|
write_lock_bh(&mrt_lock);
|
|
|
|
c->mfc_parent = mfc->mfcc_parent;
|
2005-07-31 04:41:59 +04:00
|
|
|
ipmr_update_thresholds(c, mfc->mfcc_ttls);
|
2005-04-17 02:20:36 +04:00
|
|
|
if (!mrtsock)
|
|
|
|
c->mfc_flags |= MFC_STATIC;
|
|
|
|
write_unlock_bh(&mrt_lock);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2007-12-17 00:45:43 +03:00
|
|
|
if (!ipv4_is_multicast(mfc->mfcc_mcastgrp.s_addr))
|
2005-04-17 02:20:36 +04:00
|
|
|
return -EINVAL;
|
|
|
|
|
2008-11-03 11:28:02 +03:00
|
|
|
c = ipmr_cache_alloc();
|
|
|
|
if (c == NULL)
|
2005-04-17 02:20:36 +04:00
|
|
|
return -ENOMEM;
|
|
|
|
|
2008-11-03 11:28:02 +03:00
|
|
|
c->mfc_origin = mfc->mfcc_origin.s_addr;
|
|
|
|
c->mfc_mcastgrp = mfc->mfcc_mcastgrp.s_addr;
|
|
|
|
c->mfc_parent = mfc->mfcc_parent;
|
2005-07-31 04:41:59 +04:00
|
|
|
ipmr_update_thresholds(c, mfc->mfcc_ttls);
|
2005-04-17 02:20:36 +04:00
|
|
|
if (!mrtsock)
|
|
|
|
c->mfc_flags |= MFC_STATIC;
|
|
|
|
|
|
|
|
write_lock_bh(&mrt_lock);
|
|
|
|
c->next = mfc_cache_array[line];
|
|
|
|
mfc_cache_array[line] = c;
|
|
|
|
write_unlock_bh(&mrt_lock);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Check to see if we resolved a queued list. If so we
|
|
|
|
* need to send on the frames and tidy up.
|
|
|
|
*/
|
|
|
|
spin_lock_bh(&mfc_unres_lock);
|
|
|
|
for (cp = &mfc_unres_queue; (uc=*cp) != NULL;
|
|
|
|
cp = &uc->next) {
|
|
|
|
if (uc->mfc_origin == c->mfc_origin &&
|
|
|
|
uc->mfc_mcastgrp == c->mfc_mcastgrp) {
|
|
|
|
*cp = uc->next;
|
|
|
|
if (atomic_dec_and_test(&cache_resolve_queue_len))
|
|
|
|
del_timer(&ipmr_expire_timer);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
spin_unlock_bh(&mfc_unres_lock);
|
|
|
|
|
|
|
|
if (uc) {
|
|
|
|
ipmr_cache_resolve(uc, c);
|
|
|
|
kmem_cache_free(mrt_cachep, uc);
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Close the multicast socket, and clear the vif tables etc
|
|
|
|
*/
|
2007-02-09 17:24:47 +03:00
|
|
|
|
2005-04-17 02:20:36 +04:00
|
|
|
static void mroute_clean_tables(struct sock *sk)
|
|
|
|
{
|
|
|
|
int i;
|
2007-02-09 17:24:47 +03:00
|
|
|
|
2005-04-17 02:20:36 +04:00
|
|
|
/*
|
|
|
|
* Shut down all active vif entries
|
|
|
|
*/
|
2007-03-09 07:44:43 +03:00
|
|
|
for (i=0; i<maxvif; i++) {
|
2005-04-17 02:20:36 +04:00
|
|
|
if (!(vif_table[i].flags&VIFF_STATIC))
|
ipv4: Fix ipmr unregister device oops
An oops happens during device unregister.
The following oops happened when I add two tunnels, which
use a same device, and then delete one tunnel.
Obviously deleting tunnel "A" causes device unregister, which
send a notification, and after receiving notification, ipmr do
unregister again for tunnel "B" which also use same device.
That is wrong.
After receiving notification, ipmr only needs to decrease reference
count and don't do duplicated unregister.
Fortunately, IPv6 side doesn't add tunnel in ip6mr, so it's clean.
This patch fixs:
- unregister device oops
- using after dev_put()
Here is the oops:
===
Jul 11 15:39:29 wangchen kernel: ------------[ cut here ]------------
Jul 11 15:39:29 wangchen kernel: kernel BUG at net/core/dev.c:3651!
Jul 11 15:39:29 wangchen kernel: invalid opcode: 0000 [#1]
Jul 11 15:39:29 wangchen kernel: Modules linked in: ipip tunnel4 nfsd lockd nfs_acl auth_rpcgss sunrpc exportfs ipv6 snd_pcm_oss snd_mixer_oss snd_seq snd_seq_device af_packet binfmt_misc button battery ac loop dm_mod usbhid ff_memless pcmcia firmware_class ohci1394 8139too mii ieee1394 yenta_socket rsrc_nonstatic pcmcia_core ide_cd_mod cdrom snd_intel8x0 snd_ac97_codec ac97_bus snd_pcm i2c_i801 snd_timer snd i2c_core soundcore snd_page_alloc rng_core shpchp ehci_hcd uhci_hcd pci_hotplug intel_agp agpgart usbcore ext3 jbd ata_piix ahci libata dock edd fan thermal processor thermal_sys piix sd_mod scsi_mod ide_disk ide_core [last unloaded: freq_table]
Jul 11 15:39:29 wangchen kernel:
Jul 11 15:39:29 wangchen kernel: Pid: 4102, comm: mroute Not tainted (2.6.26-rc9-default #69)
Jul 11 15:39:29 wangchen kernel: EIP: 0060:[<c024636b>] EFLAGS: 00010202 CPU: 0
Jul 11 15:39:29 wangchen kernel: EIP is at rollback_registered+0x61/0xe3
Jul 11 15:39:29 wangchen kernel: EAX: 00000001 EBX: ecba6000 ECX: 00000000 EDX: ffffffff
Jul 11 15:39:29 wangchen kernel: ESI: 00000001 EDI: ecba6000 EBP: c03de2e8 ESP: ed8e7c3c
Jul 11 15:39:29 wangchen kernel: DS: 007b ES: 007b FS: 0000 GS: 0033 SS: 0068
Jul 11 15:39:29 wangchen kernel: Process mroute (pid: 4102, ti=ed8e6000 task=ed41e830 task.ti=ed8e6000)
Jul 11 15:39:29 wangchen kernel: Stack: ecba6000 c024641c 00000028 c0284e1a 00000001 c03de2e8 ecba6000 eecff360
Jul 11 15:39:29 wangchen kernel: c0284e4c c03536f4 fffffff8 00000000 c029a819 ecba6000 00000006 ecba6000
Jul 11 15:39:29 wangchen kernel: 00000000 ecba6000 c03de2c0 c012841b ffffffff 00000000 c024639f ecba6000
Jul 11 15:39:29 wangchen kernel: Call Trace:
Jul 11 15:39:29 wangchen kernel: [<c024641c>] unregister_netdevice+0x2f/0x51
Jul 11 15:39:29 wangchen kernel: [<c0284e1a>] vif_delete+0xaf/0xc3
Jul 11 15:39:29 wangchen kernel: [<c0284e4c>] ipmr_device_event+0x1e/0x30
Jul 11 15:39:29 wangchen kernel: [<c029a819>] notifier_call_chain+0x2a/0x47
Jul 11 15:39:29 wangchen kernel: [<c012841b>] raw_notifier_call_chain+0x9/0xc
Jul 11 15:39:29 wangchen kernel: [<c024639f>] rollback_registered+0x95/0xe3
Jul 11 15:39:29 wangchen kernel: [<c024641c>] unregister_netdevice+0x2f/0x51
Jul 11 15:39:29 wangchen kernel: [<c0284e1a>] vif_delete+0xaf/0xc3
Jul 11 15:39:29 wangchen kernel: [<c0285eee>] ip_mroute_setsockopt+0x47a/0x801
Jul 11 15:39:29 wangchen kernel: [<eea5a70c>] do_get_write_access+0x2df/0x313 [jbd]
Jul 11 15:39:29 wangchen kernel: [<c01727c4>] __find_get_block_slow+0xda/0xe4
Jul 11 15:39:29 wangchen kernel: [<c0172a7f>] __find_get_block+0xf8/0x122
Jul 11 15:39:29 wangchen kernel: [<c0172a7f>] __find_get_block+0xf8/0x122
Jul 11 15:39:29 wangchen kernel: [<eea5d563>] journal_cancel_revoke+0xda/0x110 [jbd]
Jul 11 15:39:29 wangchen kernel: [<c0263501>] ip_setsockopt+0xa9/0x9ee
Jul 11 15:39:29 wangchen kernel: [<eea5d563>] journal_cancel_revoke+0xda/0x110 [jbd]
Jul 11 15:39:29 wangchen kernel: [<eea5a70c>] do_get_write_access+0x2df/0x313 [jbd]
Jul 11 15:39:29 wangchen kernel: [<eea69287>] __ext3_get_inode_loc+0xcf/0x271 [ext3]
Jul 11 15:39:29 wangchen kernel: [<eea743c7>] __ext3_journal_dirty_metadata+0x13/0x32 [ext3]
Jul 11 15:39:29 wangchen kernel: [<c0116434>] __wake_up+0xf/0x15
Jul 11 15:39:29 wangchen kernel: [<eea5a424>] journal_stop+0x1bd/0x1c6 [jbd]
Jul 11 15:39:29 wangchen kernel: [<eea703a7>] __ext3_journal_stop+0x19/0x34 [ext3]
Jul 11 15:39:29 wangchen kernel: [<c014291e>] get_page_from_freelist+0x94/0x369
Jul 11 15:39:29 wangchen kernel: [<c01408f2>] filemap_fault+0x1ac/0x2fe
Jul 11 15:39:29 wangchen kernel: [<c01a605e>] security_sk_alloc+0xd/0xf
Jul 11 15:39:29 wangchen kernel: [<c023edea>] sk_prot_alloc+0x36/0x78
Jul 11 15:39:29 wangchen kernel: [<c0240037>] sk_alloc+0x3a/0x40
Jul 11 15:39:29 wangchen kernel: [<c0276062>] raw_hash_sk+0x46/0x4e
Jul 11 15:39:29 wangchen kernel: [<c0166aff>] d_alloc+0x1b/0x157
Jul 11 15:39:29 wangchen kernel: [<c023e4d1>] sock_common_setsockopt+0x12/0x16
Jul 11 15:39:29 wangchen kernel: [<c023cb1e>] sys_setsockopt+0x6f/0x8e
Jul 11 15:39:29 wangchen kernel: [<c023e105>] sys_socketcall+0x15c/0x19e
Jul 11 15:39:29 wangchen kernel: [<c0103611>] sysenter_past_esp+0x6a/0x99
Jul 11 15:39:29 wangchen kernel: [<c0290000>] unix_poll+0x69/0x78
Jul 11 15:39:29 wangchen kernel: =======================
Jul 11 15:39:29 wangchen kernel: Code: 83 e0 01 00 00 85 c0 75 1f 53 53 68 12 81 31 c0 e8 3c 30 ed ff ba 3f 0e 00 00 b8 b9 7f 31 c0 83 c4 0c 5b e9 f5 26 ed ff 48 74 04 <0f> 0b eb fe 89 d8 e8 21 ff ff ff 89 d8 e8 62 ea ff ff c7 83 e0
Jul 11 15:39:29 wangchen kernel: EIP: [<c024636b>] rollback_registered+0x61/0xe3 SS:ESP 0068:ed8e7c3c
Jul 11 15:39:29 wangchen kernel: ---[ end trace c311acf85d169786 ]---
===
Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2008-07-15 07:56:34 +04:00
|
|
|
vif_delete(i, 0);
|
2005-04-17 02:20:36 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Wipe the cache
|
|
|
|
*/
|
2008-11-03 11:28:02 +03:00
|
|
|
for (i=0; i<MFC_LINES; i++) {
|
2005-04-17 02:20:36 +04:00
|
|
|
struct mfc_cache *c, **cp;
|
|
|
|
|
|
|
|
cp = &mfc_cache_array[i];
|
|
|
|
while ((c = *cp) != NULL) {
|
|
|
|
if (c->mfc_flags&MFC_STATIC) {
|
|
|
|
cp = &c->next;
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
write_lock_bh(&mrt_lock);
|
|
|
|
*cp = c->next;
|
|
|
|
write_unlock_bh(&mrt_lock);
|
|
|
|
|
|
|
|
kmem_cache_free(mrt_cachep, c);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (atomic_read(&cache_resolve_queue_len) != 0) {
|
|
|
|
struct mfc_cache *c;
|
|
|
|
|
|
|
|
spin_lock_bh(&mfc_unres_lock);
|
|
|
|
while (mfc_unres_queue != NULL) {
|
|
|
|
c = mfc_unres_queue;
|
|
|
|
mfc_unres_queue = c->next;
|
|
|
|
spin_unlock_bh(&mfc_unres_lock);
|
|
|
|
|
|
|
|
ipmr_destroy_unres(c);
|
|
|
|
|
|
|
|
spin_lock_bh(&mfc_unres_lock);
|
|
|
|
}
|
|
|
|
spin_unlock_bh(&mfc_unres_lock);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static void mrtsock_destruct(struct sock *sk)
|
|
|
|
{
|
|
|
|
rtnl_lock();
|
|
|
|
if (sk == mroute_socket) {
|
2008-03-25 20:26:21 +03:00
|
|
|
IPV4_DEVCONF_ALL(sock_net(sk), MC_FORWARDING)--;
|
2005-04-17 02:20:36 +04:00
|
|
|
|
|
|
|
write_lock_bh(&mrt_lock);
|
2008-11-03 11:28:02 +03:00
|
|
|
mroute_socket = NULL;
|
2005-04-17 02:20:36 +04:00
|
|
|
write_unlock_bh(&mrt_lock);
|
|
|
|
|
|
|
|
mroute_clean_tables(sk);
|
|
|
|
}
|
|
|
|
rtnl_unlock();
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Socket options and virtual interface manipulation. The whole
|
|
|
|
* virtual interface system is a complete heap, but unfortunately
|
|
|
|
* that's how BSD mrouted happens to think. Maybe one day with a proper
|
|
|
|
* MOSPF/PIM router set up we can clean this up.
|
|
|
|
*/
|
2007-02-09 17:24:47 +03:00
|
|
|
|
2008-11-03 11:28:02 +03:00
|
|
|
int ip_mroute_setsockopt(struct sock *sk, int optname, char __user *optval, int optlen)
|
2005-04-17 02:20:36 +04:00
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
struct vifctl vif;
|
|
|
|
struct mfcctl mfc;
|
2007-02-09 17:24:47 +03:00
|
|
|
|
2007-03-09 07:44:43 +03:00
|
|
|
if (optname != MRT_INIT) {
|
|
|
|
if (sk != mroute_socket && !capable(CAP_NET_ADMIN))
|
2005-04-17 02:20:36 +04:00
|
|
|
return -EACCES;
|
|
|
|
}
|
|
|
|
|
2007-03-09 07:44:43 +03:00
|
|
|
switch (optname) {
|
|
|
|
case MRT_INIT:
|
|
|
|
if (sk->sk_type != SOCK_RAW ||
|
|
|
|
inet_sk(sk)->num != IPPROTO_IGMP)
|
|
|
|
return -EOPNOTSUPP;
|
2008-11-03 11:28:02 +03:00
|
|
|
if (optlen != sizeof(int))
|
2007-03-09 07:44:43 +03:00
|
|
|
return -ENOPROTOOPT;
|
2005-04-17 02:20:36 +04:00
|
|
|
|
2007-03-09 07:44:43 +03:00
|
|
|
rtnl_lock();
|
|
|
|
if (mroute_socket) {
|
2005-04-17 02:20:36 +04:00
|
|
|
rtnl_unlock();
|
2007-03-09 07:44:43 +03:00
|
|
|
return -EADDRINUSE;
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = ip_ra_control(sk, 1, mrtsock_destruct);
|
|
|
|
if (ret == 0) {
|
|
|
|
write_lock_bh(&mrt_lock);
|
2008-11-03 11:28:02 +03:00
|
|
|
mroute_socket = sk;
|
2007-03-09 07:44:43 +03:00
|
|
|
write_unlock_bh(&mrt_lock);
|
|
|
|
|
2008-03-25 20:26:21 +03:00
|
|
|
IPV4_DEVCONF_ALL(sock_net(sk), MC_FORWARDING)++;
|
2007-03-09 07:44:43 +03:00
|
|
|
}
|
|
|
|
rtnl_unlock();
|
|
|
|
return ret;
|
|
|
|
case MRT_DONE:
|
2008-11-03 11:28:02 +03:00
|
|
|
if (sk != mroute_socket)
|
2007-03-09 07:44:43 +03:00
|
|
|
return -EACCES;
|
|
|
|
return ip_ra_control(sk, 0, NULL);
|
|
|
|
case MRT_ADD_VIF:
|
|
|
|
case MRT_DEL_VIF:
|
2008-11-03 11:28:02 +03:00
|
|
|
if (optlen != sizeof(vif))
|
2007-03-09 07:44:43 +03:00
|
|
|
return -EINVAL;
|
2008-11-03 11:28:02 +03:00
|
|
|
if (copy_from_user(&vif, optval, sizeof(vif)))
|
2007-03-09 07:44:43 +03:00
|
|
|
return -EFAULT;
|
|
|
|
if (vif.vifc_vifi >= MAXVIFS)
|
|
|
|
return -ENFILE;
|
|
|
|
rtnl_lock();
|
2008-11-03 11:28:02 +03:00
|
|
|
if (optname == MRT_ADD_VIF) {
|
2007-03-09 07:44:43 +03:00
|
|
|
ret = vif_add(&vif, sk==mroute_socket);
|
|
|
|
} else {
|
ipv4: Fix ipmr unregister device oops
An oops happens during device unregister.
The following oops happened when I add two tunnels, which
use a same device, and then delete one tunnel.
Obviously deleting tunnel "A" causes device unregister, which
send a notification, and after receiving notification, ipmr do
unregister again for tunnel "B" which also use same device.
That is wrong.
After receiving notification, ipmr only needs to decrease reference
count and don't do duplicated unregister.
Fortunately, IPv6 side doesn't add tunnel in ip6mr, so it's clean.
This patch fixs:
- unregister device oops
- using after dev_put()
Here is the oops:
===
Jul 11 15:39:29 wangchen kernel: ------------[ cut here ]------------
Jul 11 15:39:29 wangchen kernel: kernel BUG at net/core/dev.c:3651!
Jul 11 15:39:29 wangchen kernel: invalid opcode: 0000 [#1]
Jul 11 15:39:29 wangchen kernel: Modules linked in: ipip tunnel4 nfsd lockd nfs_acl auth_rpcgss sunrpc exportfs ipv6 snd_pcm_oss snd_mixer_oss snd_seq snd_seq_device af_packet binfmt_misc button battery ac loop dm_mod usbhid ff_memless pcmcia firmware_class ohci1394 8139too mii ieee1394 yenta_socket rsrc_nonstatic pcmcia_core ide_cd_mod cdrom snd_intel8x0 snd_ac97_codec ac97_bus snd_pcm i2c_i801 snd_timer snd i2c_core soundcore snd_page_alloc rng_core shpchp ehci_hcd uhci_hcd pci_hotplug intel_agp agpgart usbcore ext3 jbd ata_piix ahci libata dock edd fan thermal processor thermal_sys piix sd_mod scsi_mod ide_disk ide_core [last unloaded: freq_table]
Jul 11 15:39:29 wangchen kernel:
Jul 11 15:39:29 wangchen kernel: Pid: 4102, comm: mroute Not tainted (2.6.26-rc9-default #69)
Jul 11 15:39:29 wangchen kernel: EIP: 0060:[<c024636b>] EFLAGS: 00010202 CPU: 0
Jul 11 15:39:29 wangchen kernel: EIP is at rollback_registered+0x61/0xe3
Jul 11 15:39:29 wangchen kernel: EAX: 00000001 EBX: ecba6000 ECX: 00000000 EDX: ffffffff
Jul 11 15:39:29 wangchen kernel: ESI: 00000001 EDI: ecba6000 EBP: c03de2e8 ESP: ed8e7c3c
Jul 11 15:39:29 wangchen kernel: DS: 007b ES: 007b FS: 0000 GS: 0033 SS: 0068
Jul 11 15:39:29 wangchen kernel: Process mroute (pid: 4102, ti=ed8e6000 task=ed41e830 task.ti=ed8e6000)
Jul 11 15:39:29 wangchen kernel: Stack: ecba6000 c024641c 00000028 c0284e1a 00000001 c03de2e8 ecba6000 eecff360
Jul 11 15:39:29 wangchen kernel: c0284e4c c03536f4 fffffff8 00000000 c029a819 ecba6000 00000006 ecba6000
Jul 11 15:39:29 wangchen kernel: 00000000 ecba6000 c03de2c0 c012841b ffffffff 00000000 c024639f ecba6000
Jul 11 15:39:29 wangchen kernel: Call Trace:
Jul 11 15:39:29 wangchen kernel: [<c024641c>] unregister_netdevice+0x2f/0x51
Jul 11 15:39:29 wangchen kernel: [<c0284e1a>] vif_delete+0xaf/0xc3
Jul 11 15:39:29 wangchen kernel: [<c0284e4c>] ipmr_device_event+0x1e/0x30
Jul 11 15:39:29 wangchen kernel: [<c029a819>] notifier_call_chain+0x2a/0x47
Jul 11 15:39:29 wangchen kernel: [<c012841b>] raw_notifier_call_chain+0x9/0xc
Jul 11 15:39:29 wangchen kernel: [<c024639f>] rollback_registered+0x95/0xe3
Jul 11 15:39:29 wangchen kernel: [<c024641c>] unregister_netdevice+0x2f/0x51
Jul 11 15:39:29 wangchen kernel: [<c0284e1a>] vif_delete+0xaf/0xc3
Jul 11 15:39:29 wangchen kernel: [<c0285eee>] ip_mroute_setsockopt+0x47a/0x801
Jul 11 15:39:29 wangchen kernel: [<eea5a70c>] do_get_write_access+0x2df/0x313 [jbd]
Jul 11 15:39:29 wangchen kernel: [<c01727c4>] __find_get_block_slow+0xda/0xe4
Jul 11 15:39:29 wangchen kernel: [<c0172a7f>] __find_get_block+0xf8/0x122
Jul 11 15:39:29 wangchen kernel: [<c0172a7f>] __find_get_block+0xf8/0x122
Jul 11 15:39:29 wangchen kernel: [<eea5d563>] journal_cancel_revoke+0xda/0x110 [jbd]
Jul 11 15:39:29 wangchen kernel: [<c0263501>] ip_setsockopt+0xa9/0x9ee
Jul 11 15:39:29 wangchen kernel: [<eea5d563>] journal_cancel_revoke+0xda/0x110 [jbd]
Jul 11 15:39:29 wangchen kernel: [<eea5a70c>] do_get_write_access+0x2df/0x313 [jbd]
Jul 11 15:39:29 wangchen kernel: [<eea69287>] __ext3_get_inode_loc+0xcf/0x271 [ext3]
Jul 11 15:39:29 wangchen kernel: [<eea743c7>] __ext3_journal_dirty_metadata+0x13/0x32 [ext3]
Jul 11 15:39:29 wangchen kernel: [<c0116434>] __wake_up+0xf/0x15
Jul 11 15:39:29 wangchen kernel: [<eea5a424>] journal_stop+0x1bd/0x1c6 [jbd]
Jul 11 15:39:29 wangchen kernel: [<eea703a7>] __ext3_journal_stop+0x19/0x34 [ext3]
Jul 11 15:39:29 wangchen kernel: [<c014291e>] get_page_from_freelist+0x94/0x369
Jul 11 15:39:29 wangchen kernel: [<c01408f2>] filemap_fault+0x1ac/0x2fe
Jul 11 15:39:29 wangchen kernel: [<c01a605e>] security_sk_alloc+0xd/0xf
Jul 11 15:39:29 wangchen kernel: [<c023edea>] sk_prot_alloc+0x36/0x78
Jul 11 15:39:29 wangchen kernel: [<c0240037>] sk_alloc+0x3a/0x40
Jul 11 15:39:29 wangchen kernel: [<c0276062>] raw_hash_sk+0x46/0x4e
Jul 11 15:39:29 wangchen kernel: [<c0166aff>] d_alloc+0x1b/0x157
Jul 11 15:39:29 wangchen kernel: [<c023e4d1>] sock_common_setsockopt+0x12/0x16
Jul 11 15:39:29 wangchen kernel: [<c023cb1e>] sys_setsockopt+0x6f/0x8e
Jul 11 15:39:29 wangchen kernel: [<c023e105>] sys_socketcall+0x15c/0x19e
Jul 11 15:39:29 wangchen kernel: [<c0103611>] sysenter_past_esp+0x6a/0x99
Jul 11 15:39:29 wangchen kernel: [<c0290000>] unix_poll+0x69/0x78
Jul 11 15:39:29 wangchen kernel: =======================
Jul 11 15:39:29 wangchen kernel: Code: 83 e0 01 00 00 85 c0 75 1f 53 53 68 12 81 31 c0 e8 3c 30 ed ff ba 3f 0e 00 00 b8 b9 7f 31 c0 83 c4 0c 5b e9 f5 26 ed ff 48 74 04 <0f> 0b eb fe 89 d8 e8 21 ff ff ff 89 d8 e8 62 ea ff ff c7 83 e0
Jul 11 15:39:29 wangchen kernel: EIP: [<c024636b>] rollback_registered+0x61/0xe3 SS:ESP 0068:ed8e7c3c
Jul 11 15:39:29 wangchen kernel: ---[ end trace c311acf85d169786 ]---
===
Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2008-07-15 07:56:34 +04:00
|
|
|
ret = vif_delete(vif.vifc_vifi, 0);
|
2007-03-09 07:44:43 +03:00
|
|
|
}
|
|
|
|
rtnl_unlock();
|
|
|
|
return ret;
|
2005-04-17 02:20:36 +04:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Manipulate the forwarding caches. These live
|
|
|
|
* in a sort of kernel/user symbiosis.
|
|
|
|
*/
|
2007-03-09 07:44:43 +03:00
|
|
|
case MRT_ADD_MFC:
|
|
|
|
case MRT_DEL_MFC:
|
2008-11-03 11:28:02 +03:00
|
|
|
if (optlen != sizeof(mfc))
|
2007-03-09 07:44:43 +03:00
|
|
|
return -EINVAL;
|
2008-11-03 11:28:02 +03:00
|
|
|
if (copy_from_user(&mfc, optval, sizeof(mfc)))
|
2007-03-09 07:44:43 +03:00
|
|
|
return -EFAULT;
|
|
|
|
rtnl_lock();
|
2008-11-03 11:28:02 +03:00
|
|
|
if (optname == MRT_DEL_MFC)
|
2007-03-09 07:44:43 +03:00
|
|
|
ret = ipmr_mfc_delete(&mfc);
|
|
|
|
else
|
|
|
|
ret = ipmr_mfc_add(&mfc, sk==mroute_socket);
|
|
|
|
rtnl_unlock();
|
|
|
|
return ret;
|
2005-04-17 02:20:36 +04:00
|
|
|
/*
|
|
|
|
* Control PIM assert.
|
|
|
|
*/
|
2007-03-09 07:44:43 +03:00
|
|
|
case MRT_ASSERT:
|
|
|
|
{
|
|
|
|
int v;
|
|
|
|
if (get_user(v,(int __user *)optval))
|
|
|
|
return -EFAULT;
|
|
|
|
mroute_do_assert=(v)?1:0;
|
|
|
|
return 0;
|
|
|
|
}
|
2005-04-17 02:20:36 +04:00
|
|
|
#ifdef CONFIG_IP_PIMSM
|
2007-03-09 07:44:43 +03:00
|
|
|
case MRT_PIM:
|
|
|
|
{
|
2008-01-22 04:28:59 +03:00
|
|
|
int v;
|
|
|
|
|
2007-03-09 07:44:43 +03:00
|
|
|
if (get_user(v,(int __user *)optval))
|
|
|
|
return -EFAULT;
|
2008-01-22 04:28:59 +03:00
|
|
|
v = (v) ? 1 : 0;
|
|
|
|
|
2007-03-09 07:44:43 +03:00
|
|
|
rtnl_lock();
|
|
|
|
ret = 0;
|
|
|
|
if (v != mroute_do_pim) {
|
|
|
|
mroute_do_pim = v;
|
|
|
|
mroute_do_assert = v;
|
2005-04-17 02:20:36 +04:00
|
|
|
#ifdef CONFIG_IP_PIMSM_V2
|
2007-03-09 07:44:43 +03:00
|
|
|
if (mroute_do_pim)
|
|
|
|
ret = inet_add_protocol(&pim_protocol,
|
|
|
|
IPPROTO_PIM);
|
|
|
|
else
|
|
|
|
ret = inet_del_protocol(&pim_protocol,
|
|
|
|
IPPROTO_PIM);
|
|
|
|
if (ret < 0)
|
|
|
|
ret = -EAGAIN;
|
2005-04-17 02:20:36 +04:00
|
|
|
#endif
|
|
|
|
}
|
2007-03-09 07:44:43 +03:00
|
|
|
rtnl_unlock();
|
|
|
|
return ret;
|
|
|
|
}
|
2005-04-17 02:20:36 +04:00
|
|
|
#endif
|
2007-03-09 07:44:43 +03:00
|
|
|
/*
|
|
|
|
* Spurious command, or MRT_VERSION which you cannot
|
|
|
|
* set.
|
|
|
|
*/
|
|
|
|
default:
|
|
|
|
return -ENOPROTOOPT;
|
2005-04-17 02:20:36 +04:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Getsock opt support for the multicast routing system.
|
|
|
|
*/
|
2007-02-09 17:24:47 +03:00
|
|
|
|
2008-11-03 11:28:02 +03:00
|
|
|
int ip_mroute_getsockopt(struct sock *sk, int optname, char __user *optval, int __user *optlen)
|
2005-04-17 02:20:36 +04:00
|
|
|
{
|
|
|
|
int olr;
|
|
|
|
int val;
|
|
|
|
|
2008-11-03 11:28:02 +03:00
|
|
|
if (optname != MRT_VERSION &&
|
2005-04-17 02:20:36 +04:00
|
|
|
#ifdef CONFIG_IP_PIMSM
|
|
|
|
optname!=MRT_PIM &&
|
|
|
|
#endif
|
|
|
|
optname!=MRT_ASSERT)
|
|
|
|
return -ENOPROTOOPT;
|
|
|
|
|
|
|
|
if (get_user(olr, optlen))
|
|
|
|
return -EFAULT;
|
|
|
|
|
|
|
|
olr = min_t(unsigned int, olr, sizeof(int));
|
|
|
|
if (olr < 0)
|
|
|
|
return -EINVAL;
|
2007-02-09 17:24:47 +03:00
|
|
|
|
2008-11-03 11:28:02 +03:00
|
|
|
if (put_user(olr, optlen))
|
2005-04-17 02:20:36 +04:00
|
|
|
return -EFAULT;
|
2008-11-03 11:28:02 +03:00
|
|
|
if (optname == MRT_VERSION)
|
|
|
|
val = 0x0305;
|
2005-04-17 02:20:36 +04:00
|
|
|
#ifdef CONFIG_IP_PIMSM
|
2008-11-03 11:28:02 +03:00
|
|
|
else if (optname == MRT_PIM)
|
|
|
|
val = mroute_do_pim;
|
2005-04-17 02:20:36 +04:00
|
|
|
#endif
|
|
|
|
else
|
2008-11-03 11:28:02 +03:00
|
|
|
val = mroute_do_assert;
|
|
|
|
if (copy_to_user(optval, &val, olr))
|
2005-04-17 02:20:36 +04:00
|
|
|
return -EFAULT;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* The IP multicast ioctl support routines.
|
|
|
|
*/
|
2007-02-09 17:24:47 +03:00
|
|
|
|
2005-04-17 02:20:36 +04:00
|
|
|
int ipmr_ioctl(struct sock *sk, int cmd, void __user *arg)
|
|
|
|
{
|
|
|
|
struct sioc_sg_req sr;
|
|
|
|
struct sioc_vif_req vr;
|
|
|
|
struct vif_device *vif;
|
|
|
|
struct mfc_cache *c;
|
2007-02-09 17:24:47 +03:00
|
|
|
|
2007-03-09 07:44:43 +03:00
|
|
|
switch (cmd) {
|
|
|
|
case SIOCGETVIFCNT:
|
2008-11-03 11:28:02 +03:00
|
|
|
if (copy_from_user(&vr, arg, sizeof(vr)))
|
2007-03-09 07:44:43 +03:00
|
|
|
return -EFAULT;
|
2008-11-03 11:28:02 +03:00
|
|
|
if (vr.vifi >= maxvif)
|
2007-03-09 07:44:43 +03:00
|
|
|
return -EINVAL;
|
|
|
|
read_lock(&mrt_lock);
|
|
|
|
vif=&vif_table[vr.vifi];
|
|
|
|
if (VIF_EXISTS(vr.vifi)) {
|
2008-11-03 11:28:02 +03:00
|
|
|
vr.icount = vif->pkt_in;
|
|
|
|
vr.ocount = vif->pkt_out;
|
|
|
|
vr.ibytes = vif->bytes_in;
|
|
|
|
vr.obytes = vif->bytes_out;
|
2005-04-17 02:20:36 +04:00
|
|
|
read_unlock(&mrt_lock);
|
|
|
|
|
2008-11-03 11:28:02 +03:00
|
|
|
if (copy_to_user(arg, &vr, sizeof(vr)))
|
2007-03-09 07:44:43 +03:00
|
|
|
return -EFAULT;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
read_unlock(&mrt_lock);
|
|
|
|
return -EADDRNOTAVAIL;
|
|
|
|
case SIOCGETSGCNT:
|
2008-11-03 11:28:02 +03:00
|
|
|
if (copy_from_user(&sr, arg, sizeof(sr)))
|
2007-03-09 07:44:43 +03:00
|
|
|
return -EFAULT;
|
|
|
|
|
|
|
|
read_lock(&mrt_lock);
|
|
|
|
c = ipmr_cache_find(sr.src.s_addr, sr.grp.s_addr);
|
|
|
|
if (c) {
|
|
|
|
sr.pktcnt = c->mfc_un.res.pkt;
|
|
|
|
sr.bytecnt = c->mfc_un.res.bytes;
|
|
|
|
sr.wrong_if = c->mfc_un.res.wrong_if;
|
2005-04-17 02:20:36 +04:00
|
|
|
read_unlock(&mrt_lock);
|
2007-03-09 07:44:43 +03:00
|
|
|
|
2008-11-03 11:28:02 +03:00
|
|
|
if (copy_to_user(arg, &sr, sizeof(sr)))
|
2007-03-09 07:44:43 +03:00
|
|
|
return -EFAULT;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
read_unlock(&mrt_lock);
|
|
|
|
return -EADDRNOTAVAIL;
|
|
|
|
default:
|
|
|
|
return -ENOIOCTLCMD;
|
2005-04-17 02:20:36 +04:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
static int ipmr_device_event(struct notifier_block *this, unsigned long event, void *ptr)
|
|
|
|
{
|
2007-09-12 15:02:17 +04:00
|
|
|
struct net_device *dev = ptr;
|
2005-04-17 02:20:36 +04:00
|
|
|
struct vif_device *v;
|
|
|
|
int ct;
|
2007-09-12 15:02:17 +04:00
|
|
|
|
2008-07-20 09:34:43 +04:00
|
|
|
if (!net_eq(dev_net(dev), &init_net))
|
2007-09-12 15:02:17 +04:00
|
|
|
return NOTIFY_DONE;
|
|
|
|
|
2005-04-17 02:20:36 +04:00
|
|
|
if (event != NETDEV_UNREGISTER)
|
|
|
|
return NOTIFY_DONE;
|
|
|
|
v=&vif_table[0];
|
2008-11-03 11:28:02 +03:00
|
|
|
for (ct=0; ct<maxvif; ct++,v++) {
|
|
|
|
if (v->dev == dev)
|
ipv4: Fix ipmr unregister device oops
An oops happens during device unregister.
The following oops happened when I add two tunnels, which
use a same device, and then delete one tunnel.
Obviously deleting tunnel "A" causes device unregister, which
send a notification, and after receiving notification, ipmr do
unregister again for tunnel "B" which also use same device.
That is wrong.
After receiving notification, ipmr only needs to decrease reference
count and don't do duplicated unregister.
Fortunately, IPv6 side doesn't add tunnel in ip6mr, so it's clean.
This patch fixs:
- unregister device oops
- using after dev_put()
Here is the oops:
===
Jul 11 15:39:29 wangchen kernel: ------------[ cut here ]------------
Jul 11 15:39:29 wangchen kernel: kernel BUG at net/core/dev.c:3651!
Jul 11 15:39:29 wangchen kernel: invalid opcode: 0000 [#1]
Jul 11 15:39:29 wangchen kernel: Modules linked in: ipip tunnel4 nfsd lockd nfs_acl auth_rpcgss sunrpc exportfs ipv6 snd_pcm_oss snd_mixer_oss snd_seq snd_seq_device af_packet binfmt_misc button battery ac loop dm_mod usbhid ff_memless pcmcia firmware_class ohci1394 8139too mii ieee1394 yenta_socket rsrc_nonstatic pcmcia_core ide_cd_mod cdrom snd_intel8x0 snd_ac97_codec ac97_bus snd_pcm i2c_i801 snd_timer snd i2c_core soundcore snd_page_alloc rng_core shpchp ehci_hcd uhci_hcd pci_hotplug intel_agp agpgart usbcore ext3 jbd ata_piix ahci libata dock edd fan thermal processor thermal_sys piix sd_mod scsi_mod ide_disk ide_core [last unloaded: freq_table]
Jul 11 15:39:29 wangchen kernel:
Jul 11 15:39:29 wangchen kernel: Pid: 4102, comm: mroute Not tainted (2.6.26-rc9-default #69)
Jul 11 15:39:29 wangchen kernel: EIP: 0060:[<c024636b>] EFLAGS: 00010202 CPU: 0
Jul 11 15:39:29 wangchen kernel: EIP is at rollback_registered+0x61/0xe3
Jul 11 15:39:29 wangchen kernel: EAX: 00000001 EBX: ecba6000 ECX: 00000000 EDX: ffffffff
Jul 11 15:39:29 wangchen kernel: ESI: 00000001 EDI: ecba6000 EBP: c03de2e8 ESP: ed8e7c3c
Jul 11 15:39:29 wangchen kernel: DS: 007b ES: 007b FS: 0000 GS: 0033 SS: 0068
Jul 11 15:39:29 wangchen kernel: Process mroute (pid: 4102, ti=ed8e6000 task=ed41e830 task.ti=ed8e6000)
Jul 11 15:39:29 wangchen kernel: Stack: ecba6000 c024641c 00000028 c0284e1a 00000001 c03de2e8 ecba6000 eecff360
Jul 11 15:39:29 wangchen kernel: c0284e4c c03536f4 fffffff8 00000000 c029a819 ecba6000 00000006 ecba6000
Jul 11 15:39:29 wangchen kernel: 00000000 ecba6000 c03de2c0 c012841b ffffffff 00000000 c024639f ecba6000
Jul 11 15:39:29 wangchen kernel: Call Trace:
Jul 11 15:39:29 wangchen kernel: [<c024641c>] unregister_netdevice+0x2f/0x51
Jul 11 15:39:29 wangchen kernel: [<c0284e1a>] vif_delete+0xaf/0xc3
Jul 11 15:39:29 wangchen kernel: [<c0284e4c>] ipmr_device_event+0x1e/0x30
Jul 11 15:39:29 wangchen kernel: [<c029a819>] notifier_call_chain+0x2a/0x47
Jul 11 15:39:29 wangchen kernel: [<c012841b>] raw_notifier_call_chain+0x9/0xc
Jul 11 15:39:29 wangchen kernel: [<c024639f>] rollback_registered+0x95/0xe3
Jul 11 15:39:29 wangchen kernel: [<c024641c>] unregister_netdevice+0x2f/0x51
Jul 11 15:39:29 wangchen kernel: [<c0284e1a>] vif_delete+0xaf/0xc3
Jul 11 15:39:29 wangchen kernel: [<c0285eee>] ip_mroute_setsockopt+0x47a/0x801
Jul 11 15:39:29 wangchen kernel: [<eea5a70c>] do_get_write_access+0x2df/0x313 [jbd]
Jul 11 15:39:29 wangchen kernel: [<c01727c4>] __find_get_block_slow+0xda/0xe4
Jul 11 15:39:29 wangchen kernel: [<c0172a7f>] __find_get_block+0xf8/0x122
Jul 11 15:39:29 wangchen kernel: [<c0172a7f>] __find_get_block+0xf8/0x122
Jul 11 15:39:29 wangchen kernel: [<eea5d563>] journal_cancel_revoke+0xda/0x110 [jbd]
Jul 11 15:39:29 wangchen kernel: [<c0263501>] ip_setsockopt+0xa9/0x9ee
Jul 11 15:39:29 wangchen kernel: [<eea5d563>] journal_cancel_revoke+0xda/0x110 [jbd]
Jul 11 15:39:29 wangchen kernel: [<eea5a70c>] do_get_write_access+0x2df/0x313 [jbd]
Jul 11 15:39:29 wangchen kernel: [<eea69287>] __ext3_get_inode_loc+0xcf/0x271 [ext3]
Jul 11 15:39:29 wangchen kernel: [<eea743c7>] __ext3_journal_dirty_metadata+0x13/0x32 [ext3]
Jul 11 15:39:29 wangchen kernel: [<c0116434>] __wake_up+0xf/0x15
Jul 11 15:39:29 wangchen kernel: [<eea5a424>] journal_stop+0x1bd/0x1c6 [jbd]
Jul 11 15:39:29 wangchen kernel: [<eea703a7>] __ext3_journal_stop+0x19/0x34 [ext3]
Jul 11 15:39:29 wangchen kernel: [<c014291e>] get_page_from_freelist+0x94/0x369
Jul 11 15:39:29 wangchen kernel: [<c01408f2>] filemap_fault+0x1ac/0x2fe
Jul 11 15:39:29 wangchen kernel: [<c01a605e>] security_sk_alloc+0xd/0xf
Jul 11 15:39:29 wangchen kernel: [<c023edea>] sk_prot_alloc+0x36/0x78
Jul 11 15:39:29 wangchen kernel: [<c0240037>] sk_alloc+0x3a/0x40
Jul 11 15:39:29 wangchen kernel: [<c0276062>] raw_hash_sk+0x46/0x4e
Jul 11 15:39:29 wangchen kernel: [<c0166aff>] d_alloc+0x1b/0x157
Jul 11 15:39:29 wangchen kernel: [<c023e4d1>] sock_common_setsockopt+0x12/0x16
Jul 11 15:39:29 wangchen kernel: [<c023cb1e>] sys_setsockopt+0x6f/0x8e
Jul 11 15:39:29 wangchen kernel: [<c023e105>] sys_socketcall+0x15c/0x19e
Jul 11 15:39:29 wangchen kernel: [<c0103611>] sysenter_past_esp+0x6a/0x99
Jul 11 15:39:29 wangchen kernel: [<c0290000>] unix_poll+0x69/0x78
Jul 11 15:39:29 wangchen kernel: =======================
Jul 11 15:39:29 wangchen kernel: Code: 83 e0 01 00 00 85 c0 75 1f 53 53 68 12 81 31 c0 e8 3c 30 ed ff ba 3f 0e 00 00 b8 b9 7f 31 c0 83 c4 0c 5b e9 f5 26 ed ff 48 74 04 <0f> 0b eb fe 89 d8 e8 21 ff ff ff 89 d8 e8 62 ea ff ff c7 83 e0
Jul 11 15:39:29 wangchen kernel: EIP: [<c024636b>] rollback_registered+0x61/0xe3 SS:ESP 0068:ed8e7c3c
Jul 11 15:39:29 wangchen kernel: ---[ end trace c311acf85d169786 ]---
===
Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2008-07-15 07:56:34 +04:00
|
|
|
vif_delete(ct, 1);
|
2005-04-17 02:20:36 +04:00
|
|
|
}
|
|
|
|
return NOTIFY_DONE;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2008-11-03 11:28:02 +03:00
|
|
|
static struct notifier_block ip_mr_notifier = {
|
2005-04-17 02:20:36 +04:00
|
|
|
.notifier_call = ipmr_device_event,
|
|
|
|
};
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Encapsulate a packet by attaching a valid IPIP header to it.
|
|
|
|
* This avoids tunnel drivers and other mess and gives us the speed so
|
|
|
|
* important for multicast video.
|
|
|
|
*/
|
2007-02-09 17:24:47 +03:00
|
|
|
|
2006-09-28 05:39:29 +04:00
|
|
|
static void ip_encap(struct sk_buff *skb, __be32 saddr, __be32 daddr)
|
2005-04-17 02:20:36 +04:00
|
|
|
{
|
2007-03-11 01:40:39 +03:00
|
|
|
struct iphdr *iph;
|
2007-04-21 09:47:35 +04:00
|
|
|
struct iphdr *old_iph = ip_hdr(skb);
|
2007-03-11 01:40:39 +03:00
|
|
|
|
|
|
|
skb_push(skb, sizeof(struct iphdr));
|
2007-04-11 08:21:55 +04:00
|
|
|
skb->transport_header = skb->network_header;
|
2007-03-11 01:40:39 +03:00
|
|
|
skb_reset_network_header(skb);
|
2007-04-21 09:47:35 +04:00
|
|
|
iph = ip_hdr(skb);
|
2005-04-17 02:20:36 +04:00
|
|
|
|
|
|
|
iph->version = 4;
|
2007-03-13 02:09:36 +03:00
|
|
|
iph->tos = old_iph->tos;
|
|
|
|
iph->ttl = old_iph->ttl;
|
2005-04-17 02:20:36 +04:00
|
|
|
iph->frag_off = 0;
|
|
|
|
iph->daddr = daddr;
|
|
|
|
iph->saddr = saddr;
|
|
|
|
iph->protocol = IPPROTO_IPIP;
|
|
|
|
iph->ihl = 5;
|
|
|
|
iph->tot_len = htons(skb->len);
|
|
|
|
ip_select_ident(iph, skb->dst, NULL);
|
|
|
|
ip_send_check(iph);
|
|
|
|
|
|
|
|
memset(&(IPCB(skb)->opt), 0, sizeof(IPCB(skb)->opt));
|
|
|
|
nf_reset(skb);
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline int ipmr_forward_finish(struct sk_buff *skb)
|
|
|
|
{
|
|
|
|
struct ip_options * opt = &(IPCB(skb)->opt);
|
|
|
|
|
2008-07-17 07:20:11 +04:00
|
|
|
IP_INC_STATS_BH(dev_net(skb->dst->dev), IPSTATS_MIB_OUTFORWDATAGRAMS);
|
2005-04-17 02:20:36 +04:00
|
|
|
|
|
|
|
if (unlikely(opt->optlen))
|
|
|
|
ip_forward_options(skb);
|
|
|
|
|
|
|
|
return dst_output(skb);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Processing handlers for ipmr_forward
|
|
|
|
*/
|
|
|
|
|
|
|
|
static void ipmr_queue_xmit(struct sk_buff *skb, struct mfc_cache *c, int vifi)
|
|
|
|
{
|
2007-04-21 09:47:35 +04:00
|
|
|
const struct iphdr *iph = ip_hdr(skb);
|
2005-04-17 02:20:36 +04:00
|
|
|
struct vif_device *vif = &vif_table[vifi];
|
|
|
|
struct net_device *dev;
|
|
|
|
struct rtable *rt;
|
|
|
|
int encap = 0;
|
|
|
|
|
|
|
|
if (vif->dev == NULL)
|
|
|
|
goto out_free;
|
|
|
|
|
|
|
|
#ifdef CONFIG_IP_PIMSM
|
|
|
|
if (vif->flags & VIFF_REGISTER) {
|
|
|
|
vif->pkt_out++;
|
2008-11-03 11:28:02 +03:00
|
|
|
vif->bytes_out += skb->len;
|
2008-05-22 01:17:33 +04:00
|
|
|
vif->dev->stats.tx_bytes += skb->len;
|
|
|
|
vif->dev->stats.tx_packets++;
|
2005-04-17 02:20:36 +04:00
|
|
|
ipmr_cache_report(skb, vifi, IGMPMSG_WHOLEPKT);
|
|
|
|
kfree_skb(skb);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
|
|
|
|
if (vif->flags&VIFF_TUNNEL) {
|
|
|
|
struct flowi fl = { .oif = vif->link,
|
|
|
|
.nl_u = { .ip4_u =
|
|
|
|
{ .daddr = vif->remote,
|
|
|
|
.saddr = vif->local,
|
|
|
|
.tos = RT_TOS(iph->tos) } },
|
|
|
|
.proto = IPPROTO_IPIP };
|
2008-01-23 09:07:34 +03:00
|
|
|
if (ip_route_output_key(&init_net, &rt, &fl))
|
2005-04-17 02:20:36 +04:00
|
|
|
goto out_free;
|
|
|
|
encap = sizeof(struct iphdr);
|
|
|
|
} else {
|
|
|
|
struct flowi fl = { .oif = vif->link,
|
|
|
|
.nl_u = { .ip4_u =
|
|
|
|
{ .daddr = iph->daddr,
|
|
|
|
.tos = RT_TOS(iph->tos) } },
|
|
|
|
.proto = IPPROTO_IPIP };
|
2008-01-23 09:07:34 +03:00
|
|
|
if (ip_route_output_key(&init_net, &rt, &fl))
|
2005-04-17 02:20:36 +04:00
|
|
|
goto out_free;
|
|
|
|
}
|
|
|
|
|
|
|
|
dev = rt->u.dst.dev;
|
|
|
|
|
|
|
|
if (skb->len+encap > dst_mtu(&rt->u.dst) && (ntohs(iph->frag_off) & IP_DF)) {
|
|
|
|
/* Do not fragment multicasts. Alas, IPv4 does not
|
|
|
|
allow to send ICMP, so that packets will disappear
|
|
|
|
to blackhole.
|
|
|
|
*/
|
|
|
|
|
2008-07-17 07:20:11 +04:00
|
|
|
IP_INC_STATS_BH(dev_net(dev), IPSTATS_MIB_FRAGFAILS);
|
2005-04-17 02:20:36 +04:00
|
|
|
ip_rt_put(rt);
|
|
|
|
goto out_free;
|
|
|
|
}
|
|
|
|
|
|
|
|
encap += LL_RESERVED_SPACE(dev) + rt->u.dst.header_len;
|
|
|
|
|
|
|
|
if (skb_cow(skb, encap)) {
|
2007-02-09 17:24:47 +03:00
|
|
|
ip_rt_put(rt);
|
2005-04-17 02:20:36 +04:00
|
|
|
goto out_free;
|
|
|
|
}
|
|
|
|
|
|
|
|
vif->pkt_out++;
|
2008-11-03 11:28:02 +03:00
|
|
|
vif->bytes_out += skb->len;
|
2005-04-17 02:20:36 +04:00
|
|
|
|
|
|
|
dst_release(skb->dst);
|
|
|
|
skb->dst = &rt->u.dst;
|
2007-04-21 09:47:35 +04:00
|
|
|
ip_decrease_ttl(ip_hdr(skb));
|
2005-04-17 02:20:36 +04:00
|
|
|
|
|
|
|
/* FIXME: forward and output firewalls used to be called here.
|
|
|
|
* What do we do with netfilter? -- RR */
|
|
|
|
if (vif->flags & VIFF_TUNNEL) {
|
|
|
|
ip_encap(skb, vif->local, vif->remote);
|
|
|
|
/* FIXME: extra output firewall step used to be here. --RR */
|
2008-05-22 01:16:14 +04:00
|
|
|
vif->dev->stats.tx_packets++;
|
|
|
|
vif->dev->stats.tx_bytes += skb->len;
|
2005-04-17 02:20:36 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
IPCB(skb)->flags |= IPSKB_FORWARDED;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* RFC1584 teaches, that DVMRP/PIM router must deliver packets locally
|
|
|
|
* not only before forwarding, but after forwarding on all output
|
|
|
|
* interfaces. It is clear, if mrouter runs a multicasting
|
|
|
|
* program, it should receive packets not depending to what interface
|
|
|
|
* program is joined.
|
|
|
|
* If we will not make it, the program will have to join on all
|
|
|
|
* interfaces. On the other hand, multihoming host (or router, but
|
|
|
|
* not mrouter) cannot join to more than one interface - it will
|
|
|
|
* result in receiving multiple packets.
|
|
|
|
*/
|
2007-11-20 05:53:30 +03:00
|
|
|
NF_HOOK(PF_INET, NF_INET_FORWARD, skb, skb->dev, dev,
|
2005-04-17 02:20:36 +04:00
|
|
|
ipmr_forward_finish);
|
|
|
|
return;
|
|
|
|
|
|
|
|
out_free:
|
|
|
|
kfree_skb(skb);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int ipmr_find_vif(struct net_device *dev)
|
|
|
|
{
|
|
|
|
int ct;
|
|
|
|
for (ct=maxvif-1; ct>=0; ct--) {
|
|
|
|
if (vif_table[ct].dev == dev)
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
return ct;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* "local" means that we should preserve one skb (for local delivery) */
|
|
|
|
|
|
|
|
static int ip_mr_forward(struct sk_buff *skb, struct mfc_cache *cache, int local)
|
|
|
|
{
|
|
|
|
int psend = -1;
|
|
|
|
int vif, ct;
|
|
|
|
|
|
|
|
vif = cache->mfc_parent;
|
|
|
|
cache->mfc_un.res.pkt++;
|
|
|
|
cache->mfc_un.res.bytes += skb->len;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Wrong interface: drop packet and (maybe) send PIM assert.
|
|
|
|
*/
|
|
|
|
if (vif_table[vif].dev != skb->dev) {
|
|
|
|
int true_vifi;
|
|
|
|
|
2008-03-06 05:30:47 +03:00
|
|
|
if (skb->rtable->fl.iif == 0) {
|
2005-04-17 02:20:36 +04:00
|
|
|
/* It is our own packet, looped back.
|
|
|
|
Very complicated situation...
|
|
|
|
|
|
|
|
The best workaround until routing daemons will be
|
|
|
|
fixed is not to redistribute packet, if it was
|
|
|
|
send through wrong interface. It means, that
|
|
|
|
multicast applications WILL NOT work for
|
|
|
|
(S,G), which have default multicast route pointing
|
|
|
|
to wrong oif. In any case, it is not a good
|
|
|
|
idea to use multicasting applications on router.
|
|
|
|
*/
|
|
|
|
goto dont_forward;
|
|
|
|
}
|
|
|
|
|
|
|
|
cache->mfc_un.res.wrong_if++;
|
|
|
|
true_vifi = ipmr_find_vif(skb->dev);
|
|
|
|
|
|
|
|
if (true_vifi >= 0 && mroute_do_assert &&
|
|
|
|
/* pimsm uses asserts, when switching from RPT to SPT,
|
|
|
|
so that we cannot check that packet arrived on an oif.
|
|
|
|
It is bad, but otherwise we would need to move pretty
|
|
|
|
large chunk of pimd to kernel. Ough... --ANK
|
|
|
|
*/
|
|
|
|
(mroute_do_pim || cache->mfc_un.res.ttls[true_vifi] < 255) &&
|
2007-02-09 17:24:47 +03:00
|
|
|
time_after(jiffies,
|
2005-04-17 02:20:36 +04:00
|
|
|
cache->mfc_un.res.last_assert + MFC_ASSERT_THRESH)) {
|
|
|
|
cache->mfc_un.res.last_assert = jiffies;
|
|
|
|
ipmr_cache_report(skb, true_vifi, IGMPMSG_WRONGVIF);
|
|
|
|
}
|
|
|
|
goto dont_forward;
|
|
|
|
}
|
|
|
|
|
|
|
|
vif_table[vif].pkt_in++;
|
2008-11-03 11:28:02 +03:00
|
|
|
vif_table[vif].bytes_in += skb->len;
|
2005-04-17 02:20:36 +04:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Forward the frame
|
|
|
|
*/
|
|
|
|
for (ct = cache->mfc_un.res.maxvif-1; ct >= cache->mfc_un.res.minvif; ct--) {
|
2007-04-21 09:47:35 +04:00
|
|
|
if (ip_hdr(skb)->ttl > cache->mfc_un.res.ttls[ct]) {
|
2005-04-17 02:20:36 +04:00
|
|
|
if (psend != -1) {
|
|
|
|
struct sk_buff *skb2 = skb_clone(skb, GFP_ATOMIC);
|
|
|
|
if (skb2)
|
|
|
|
ipmr_queue_xmit(skb2, cache, psend);
|
|
|
|
}
|
2008-11-03 11:28:02 +03:00
|
|
|
psend = ct;
|
2005-04-17 02:20:36 +04:00
|
|
|
}
|
|
|
|
}
|
|
|
|
if (psend != -1) {
|
|
|
|
if (local) {
|
|
|
|
struct sk_buff *skb2 = skb_clone(skb, GFP_ATOMIC);
|
|
|
|
if (skb2)
|
|
|
|
ipmr_queue_xmit(skb2, cache, psend);
|
|
|
|
} else {
|
|
|
|
ipmr_queue_xmit(skb, cache, psend);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
dont_forward:
|
|
|
|
if (!local)
|
|
|
|
kfree_skb(skb);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Multicast packets for forwarding arrive here
|
|
|
|
*/
|
|
|
|
|
|
|
|
int ip_mr_input(struct sk_buff *skb)
|
|
|
|
{
|
|
|
|
struct mfc_cache *cache;
|
2008-03-06 05:30:47 +03:00
|
|
|
int local = skb->rtable->rt_flags&RTCF_LOCAL;
|
2005-04-17 02:20:36 +04:00
|
|
|
|
|
|
|
/* Packet is looped back after forward, it should not be
|
|
|
|
forwarded second time, but still can be delivered locally.
|
|
|
|
*/
|
|
|
|
if (IPCB(skb)->flags&IPSKB_FORWARDED)
|
|
|
|
goto dont_forward;
|
|
|
|
|
|
|
|
if (!local) {
|
|
|
|
if (IPCB(skb)->opt.router_alert) {
|
|
|
|
if (ip_call_ra_chain(skb))
|
|
|
|
return 0;
|
2007-04-21 09:47:35 +04:00
|
|
|
} else if (ip_hdr(skb)->protocol == IPPROTO_IGMP){
|
2005-04-17 02:20:36 +04:00
|
|
|
/* IGMPv1 (and broken IGMPv2 implementations sort of
|
|
|
|
Cisco IOS <= 11.2(8)) do not put router alert
|
|
|
|
option to IGMP packets destined to routable
|
|
|
|
groups. It is very bad, because it means
|
|
|
|
that we can forward NO IGMP messages.
|
|
|
|
*/
|
|
|
|
read_lock(&mrt_lock);
|
|
|
|
if (mroute_socket) {
|
2005-06-22 01:06:24 +04:00
|
|
|
nf_reset(skb);
|
2005-04-17 02:20:36 +04:00
|
|
|
raw_rcv(mroute_socket, skb);
|
|
|
|
read_unlock(&mrt_lock);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
read_unlock(&mrt_lock);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
read_lock(&mrt_lock);
|
2007-04-21 09:47:35 +04:00
|
|
|
cache = ipmr_cache_find(ip_hdr(skb)->saddr, ip_hdr(skb)->daddr);
|
2005-04-17 02:20:36 +04:00
|
|
|
|
|
|
|
/*
|
|
|
|
* No usable cache entry
|
|
|
|
*/
|
2008-11-03 11:28:02 +03:00
|
|
|
if (cache == NULL) {
|
2005-04-17 02:20:36 +04:00
|
|
|
int vif;
|
|
|
|
|
|
|
|
if (local) {
|
|
|
|
struct sk_buff *skb2 = skb_clone(skb, GFP_ATOMIC);
|
|
|
|
ip_local_deliver(skb);
|
|
|
|
if (skb2 == NULL) {
|
|
|
|
read_unlock(&mrt_lock);
|
|
|
|
return -ENOBUFS;
|
|
|
|
}
|
|
|
|
skb = skb2;
|
|
|
|
}
|
|
|
|
|
|
|
|
vif = ipmr_find_vif(skb->dev);
|
|
|
|
if (vif >= 0) {
|
|
|
|
int err = ipmr_cache_unresolved(vif, skb);
|
|
|
|
read_unlock(&mrt_lock);
|
|
|
|
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
read_unlock(&mrt_lock);
|
|
|
|
kfree_skb(skb);
|
|
|
|
return -ENODEV;
|
|
|
|
}
|
|
|
|
|
|
|
|
ip_mr_forward(skb, cache, local);
|
|
|
|
|
|
|
|
read_unlock(&mrt_lock);
|
|
|
|
|
|
|
|
if (local)
|
|
|
|
return ip_local_deliver(skb);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
dont_forward:
|
|
|
|
if (local)
|
|
|
|
return ip_local_deliver(skb);
|
|
|
|
kfree_skb(skb);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
ipmr: merge common code
Also removes redundant skb->len < x check which can't
be true once pskb_may_pull(skb, x) succeeded.
$ diff-funcs pim_rcv ipmr.c ipmr.c pim_rcv_v1
--- ipmr.c:pim_rcv()
+++ ipmr.c:pim_rcv_v1()
@@ -1,22 +1,27 @@
-static int pim_rcv(struct sk_buff * skb)
+int pim_rcv_v1(struct sk_buff * skb)
{
- struct pimreghdr *pim;
+ struct igmphdr *pim;
struct iphdr *encap;
struct net_device *reg_dev = NULL;
if (!pskb_may_pull(skb, sizeof(*pim) + sizeof(*encap)))
goto drop;
- pim = (struct pimreghdr *)skb_transport_header(skb);
- if (pim->type != ((PIM_VERSION<<4)|(PIM_REGISTER)) ||
- (pim->flags&PIM_NULL_REGISTER) ||
- (ip_compute_csum((void *)pim, sizeof(*pim)) != 0 &&
- csum_fold(skb_checksum(skb, 0, skb->len, 0))))
+ pim = igmp_hdr(skb);
+
+ if (!mroute_do_pim ||
+ skb->len < sizeof(*pim) + sizeof(*encap) ||
+ pim->group != PIM_V1_VERSION || pim->code != PIM_V1_REGISTER)
goto drop;
- /* check if the inner packet is destined to mcast group */
encap = (struct iphdr *)(skb_transport_header(skb) +
- sizeof(struct pimreghdr));
+ sizeof(struct igmphdr));
+ /*
+ Check that:
+ a. packet is really destinted to a multicast group
+ b. packet is not a NULL-REGISTER
+ c. packet is not truncated
+ */
if (!ipv4_is_multicast(encap->daddr) ||
encap->tot_len == 0 ||
ntohs(encap->tot_len) + sizeof(*pim) > skb->len)
@@ -40,9 +45,9 @@
skb->ip_summed = 0;
skb->pkt_type = PACKET_HOST;
dst_release(skb->dst);
+ skb->dst = NULL;
reg_dev->stats.rx_bytes += skb->len;
reg_dev->stats.rx_packets++;
- skb->dst = NULL;
nf_reset(skb);
netif_rx(skb);
dev_put(reg_dev);
$ codiff net/ipv4/ipmr.o.old net/ipv4/ipmr.o.new
net/ipv4/ipmr.c:
pim_rcv_v1 | -283
pim_rcv | -284
2 functions changed, 567 bytes removed
net/ipv4/ipmr.c:
__pim_rcv | +307
1 function changed, 307 bytes added
net/ipv4/ipmr.o.new:
3 functions changed, 307 bytes added, 567 bytes removed, diff: -260
(Tested on x86_64).
It seems that pimlen arg could be left out as well and
eq-sizedness of structs trapped with BUILD_BUG_ON but
I don't think that's more than a cosmetic flaw since there
aren't that many args anyway.
Compile tested.
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Signed-off-by: David S. Miller <davem@davemloft.net>
2008-12-16 12:15:11 +03:00
|
|
|
#ifdef CONFIG_IP_PIMSM
|
|
|
|
static int __pim_rcv(struct sk_buff *skb, unsigned int pimlen)
|
2005-04-17 02:20:36 +04:00
|
|
|
{
|
ipmr: merge common code
Also removes redundant skb->len < x check which can't
be true once pskb_may_pull(skb, x) succeeded.
$ diff-funcs pim_rcv ipmr.c ipmr.c pim_rcv_v1
--- ipmr.c:pim_rcv()
+++ ipmr.c:pim_rcv_v1()
@@ -1,22 +1,27 @@
-static int pim_rcv(struct sk_buff * skb)
+int pim_rcv_v1(struct sk_buff * skb)
{
- struct pimreghdr *pim;
+ struct igmphdr *pim;
struct iphdr *encap;
struct net_device *reg_dev = NULL;
if (!pskb_may_pull(skb, sizeof(*pim) + sizeof(*encap)))
goto drop;
- pim = (struct pimreghdr *)skb_transport_header(skb);
- if (pim->type != ((PIM_VERSION<<4)|(PIM_REGISTER)) ||
- (pim->flags&PIM_NULL_REGISTER) ||
- (ip_compute_csum((void *)pim, sizeof(*pim)) != 0 &&
- csum_fold(skb_checksum(skb, 0, skb->len, 0))))
+ pim = igmp_hdr(skb);
+
+ if (!mroute_do_pim ||
+ skb->len < sizeof(*pim) + sizeof(*encap) ||
+ pim->group != PIM_V1_VERSION || pim->code != PIM_V1_REGISTER)
goto drop;
- /* check if the inner packet is destined to mcast group */
encap = (struct iphdr *)(skb_transport_header(skb) +
- sizeof(struct pimreghdr));
+ sizeof(struct igmphdr));
+ /*
+ Check that:
+ a. packet is really destinted to a multicast group
+ b. packet is not a NULL-REGISTER
+ c. packet is not truncated
+ */
if (!ipv4_is_multicast(encap->daddr) ||
encap->tot_len == 0 ||
ntohs(encap->tot_len) + sizeof(*pim) > skb->len)
@@ -40,9 +45,9 @@
skb->ip_summed = 0;
skb->pkt_type = PACKET_HOST;
dst_release(skb->dst);
+ skb->dst = NULL;
reg_dev->stats.rx_bytes += skb->len;
reg_dev->stats.rx_packets++;
- skb->dst = NULL;
nf_reset(skb);
netif_rx(skb);
dev_put(reg_dev);
$ codiff net/ipv4/ipmr.o.old net/ipv4/ipmr.o.new
net/ipv4/ipmr.c:
pim_rcv_v1 | -283
pim_rcv | -284
2 functions changed, 567 bytes removed
net/ipv4/ipmr.c:
__pim_rcv | +307
1 function changed, 307 bytes added
net/ipv4/ipmr.o.new:
3 functions changed, 307 bytes added, 567 bytes removed, diff: -260
(Tested on x86_64).
It seems that pimlen arg could be left out as well and
eq-sizedness of structs trapped with BUILD_BUG_ON but
I don't think that's more than a cosmetic flaw since there
aren't that many args anyway.
Compile tested.
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Signed-off-by: David S. Miller <davem@davemloft.net>
2008-12-16 12:15:11 +03:00
|
|
|
struct net_device *reg_dev = NULL;
|
|
|
|
struct iphdr *encap;
|
2005-04-17 02:20:36 +04:00
|
|
|
|
ipmr: merge common code
Also removes redundant skb->len < x check which can't
be true once pskb_may_pull(skb, x) succeeded.
$ diff-funcs pim_rcv ipmr.c ipmr.c pim_rcv_v1
--- ipmr.c:pim_rcv()
+++ ipmr.c:pim_rcv_v1()
@@ -1,22 +1,27 @@
-static int pim_rcv(struct sk_buff * skb)
+int pim_rcv_v1(struct sk_buff * skb)
{
- struct pimreghdr *pim;
+ struct igmphdr *pim;
struct iphdr *encap;
struct net_device *reg_dev = NULL;
if (!pskb_may_pull(skb, sizeof(*pim) + sizeof(*encap)))
goto drop;
- pim = (struct pimreghdr *)skb_transport_header(skb);
- if (pim->type != ((PIM_VERSION<<4)|(PIM_REGISTER)) ||
- (pim->flags&PIM_NULL_REGISTER) ||
- (ip_compute_csum((void *)pim, sizeof(*pim)) != 0 &&
- csum_fold(skb_checksum(skb, 0, skb->len, 0))))
+ pim = igmp_hdr(skb);
+
+ if (!mroute_do_pim ||
+ skb->len < sizeof(*pim) + sizeof(*encap) ||
+ pim->group != PIM_V1_VERSION || pim->code != PIM_V1_REGISTER)
goto drop;
- /* check if the inner packet is destined to mcast group */
encap = (struct iphdr *)(skb_transport_header(skb) +
- sizeof(struct pimreghdr));
+ sizeof(struct igmphdr));
+ /*
+ Check that:
+ a. packet is really destinted to a multicast group
+ b. packet is not a NULL-REGISTER
+ c. packet is not truncated
+ */
if (!ipv4_is_multicast(encap->daddr) ||
encap->tot_len == 0 ||
ntohs(encap->tot_len) + sizeof(*pim) > skb->len)
@@ -40,9 +45,9 @@
skb->ip_summed = 0;
skb->pkt_type = PACKET_HOST;
dst_release(skb->dst);
+ skb->dst = NULL;
reg_dev->stats.rx_bytes += skb->len;
reg_dev->stats.rx_packets++;
- skb->dst = NULL;
nf_reset(skb);
netif_rx(skb);
dev_put(reg_dev);
$ codiff net/ipv4/ipmr.o.old net/ipv4/ipmr.o.new
net/ipv4/ipmr.c:
pim_rcv_v1 | -283
pim_rcv | -284
2 functions changed, 567 bytes removed
net/ipv4/ipmr.c:
__pim_rcv | +307
1 function changed, 307 bytes added
net/ipv4/ipmr.o.new:
3 functions changed, 307 bytes added, 567 bytes removed, diff: -260
(Tested on x86_64).
It seems that pimlen arg could be left out as well and
eq-sizedness of structs trapped with BUILD_BUG_ON but
I don't think that's more than a cosmetic flaw since there
aren't that many args anyway.
Compile tested.
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Signed-off-by: David S. Miller <davem@davemloft.net>
2008-12-16 12:15:11 +03:00
|
|
|
encap = (struct iphdr *)(skb_transport_header(skb) + pimlen);
|
2005-04-17 02:20:36 +04:00
|
|
|
/*
|
|
|
|
Check that:
|
|
|
|
a. packet is really destinted to a multicast group
|
|
|
|
b. packet is not a NULL-REGISTER
|
|
|
|
c. packet is not truncated
|
|
|
|
*/
|
2007-12-17 00:45:43 +03:00
|
|
|
if (!ipv4_is_multicast(encap->daddr) ||
|
2005-04-17 02:20:36 +04:00
|
|
|
encap->tot_len == 0 ||
|
ipmr: merge common code
Also removes redundant skb->len < x check which can't
be true once pskb_may_pull(skb, x) succeeded.
$ diff-funcs pim_rcv ipmr.c ipmr.c pim_rcv_v1
--- ipmr.c:pim_rcv()
+++ ipmr.c:pim_rcv_v1()
@@ -1,22 +1,27 @@
-static int pim_rcv(struct sk_buff * skb)
+int pim_rcv_v1(struct sk_buff * skb)
{
- struct pimreghdr *pim;
+ struct igmphdr *pim;
struct iphdr *encap;
struct net_device *reg_dev = NULL;
if (!pskb_may_pull(skb, sizeof(*pim) + sizeof(*encap)))
goto drop;
- pim = (struct pimreghdr *)skb_transport_header(skb);
- if (pim->type != ((PIM_VERSION<<4)|(PIM_REGISTER)) ||
- (pim->flags&PIM_NULL_REGISTER) ||
- (ip_compute_csum((void *)pim, sizeof(*pim)) != 0 &&
- csum_fold(skb_checksum(skb, 0, skb->len, 0))))
+ pim = igmp_hdr(skb);
+
+ if (!mroute_do_pim ||
+ skb->len < sizeof(*pim) + sizeof(*encap) ||
+ pim->group != PIM_V1_VERSION || pim->code != PIM_V1_REGISTER)
goto drop;
- /* check if the inner packet is destined to mcast group */
encap = (struct iphdr *)(skb_transport_header(skb) +
- sizeof(struct pimreghdr));
+ sizeof(struct igmphdr));
+ /*
+ Check that:
+ a. packet is really destinted to a multicast group
+ b. packet is not a NULL-REGISTER
+ c. packet is not truncated
+ */
if (!ipv4_is_multicast(encap->daddr) ||
encap->tot_len == 0 ||
ntohs(encap->tot_len) + sizeof(*pim) > skb->len)
@@ -40,9 +45,9 @@
skb->ip_summed = 0;
skb->pkt_type = PACKET_HOST;
dst_release(skb->dst);
+ skb->dst = NULL;
reg_dev->stats.rx_bytes += skb->len;
reg_dev->stats.rx_packets++;
- skb->dst = NULL;
nf_reset(skb);
netif_rx(skb);
dev_put(reg_dev);
$ codiff net/ipv4/ipmr.o.old net/ipv4/ipmr.o.new
net/ipv4/ipmr.c:
pim_rcv_v1 | -283
pim_rcv | -284
2 functions changed, 567 bytes removed
net/ipv4/ipmr.c:
__pim_rcv | +307
1 function changed, 307 bytes added
net/ipv4/ipmr.o.new:
3 functions changed, 307 bytes added, 567 bytes removed, diff: -260
(Tested on x86_64).
It seems that pimlen arg could be left out as well and
eq-sizedness of structs trapped with BUILD_BUG_ON but
I don't think that's more than a cosmetic flaw since there
aren't that many args anyway.
Compile tested.
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Signed-off-by: David S. Miller <davem@davemloft.net>
2008-12-16 12:15:11 +03:00
|
|
|
ntohs(encap->tot_len) + pimlen > skb->len)
|
|
|
|
return 1;
|
2005-04-17 02:20:36 +04:00
|
|
|
|
|
|
|
read_lock(&mrt_lock);
|
|
|
|
if (reg_vif_num >= 0)
|
|
|
|
reg_dev = vif_table[reg_vif_num].dev;
|
|
|
|
if (reg_dev)
|
|
|
|
dev_hold(reg_dev);
|
|
|
|
read_unlock(&mrt_lock);
|
|
|
|
|
2007-02-09 17:24:47 +03:00
|
|
|
if (reg_dev == NULL)
|
ipmr: merge common code
Also removes redundant skb->len < x check which can't
be true once pskb_may_pull(skb, x) succeeded.
$ diff-funcs pim_rcv ipmr.c ipmr.c pim_rcv_v1
--- ipmr.c:pim_rcv()
+++ ipmr.c:pim_rcv_v1()
@@ -1,22 +1,27 @@
-static int pim_rcv(struct sk_buff * skb)
+int pim_rcv_v1(struct sk_buff * skb)
{
- struct pimreghdr *pim;
+ struct igmphdr *pim;
struct iphdr *encap;
struct net_device *reg_dev = NULL;
if (!pskb_may_pull(skb, sizeof(*pim) + sizeof(*encap)))
goto drop;
- pim = (struct pimreghdr *)skb_transport_header(skb);
- if (pim->type != ((PIM_VERSION<<4)|(PIM_REGISTER)) ||
- (pim->flags&PIM_NULL_REGISTER) ||
- (ip_compute_csum((void *)pim, sizeof(*pim)) != 0 &&
- csum_fold(skb_checksum(skb, 0, skb->len, 0))))
+ pim = igmp_hdr(skb);
+
+ if (!mroute_do_pim ||
+ skb->len < sizeof(*pim) + sizeof(*encap) ||
+ pim->group != PIM_V1_VERSION || pim->code != PIM_V1_REGISTER)
goto drop;
- /* check if the inner packet is destined to mcast group */
encap = (struct iphdr *)(skb_transport_header(skb) +
- sizeof(struct pimreghdr));
+ sizeof(struct igmphdr));
+ /*
+ Check that:
+ a. packet is really destinted to a multicast group
+ b. packet is not a NULL-REGISTER
+ c. packet is not truncated
+ */
if (!ipv4_is_multicast(encap->daddr) ||
encap->tot_len == 0 ||
ntohs(encap->tot_len) + sizeof(*pim) > skb->len)
@@ -40,9 +45,9 @@
skb->ip_summed = 0;
skb->pkt_type = PACKET_HOST;
dst_release(skb->dst);
+ skb->dst = NULL;
reg_dev->stats.rx_bytes += skb->len;
reg_dev->stats.rx_packets++;
- skb->dst = NULL;
nf_reset(skb);
netif_rx(skb);
dev_put(reg_dev);
$ codiff net/ipv4/ipmr.o.old net/ipv4/ipmr.o.new
net/ipv4/ipmr.c:
pim_rcv_v1 | -283
pim_rcv | -284
2 functions changed, 567 bytes removed
net/ipv4/ipmr.c:
__pim_rcv | +307
1 function changed, 307 bytes added
net/ipv4/ipmr.o.new:
3 functions changed, 307 bytes added, 567 bytes removed, diff: -260
(Tested on x86_64).
It seems that pimlen arg could be left out as well and
eq-sizedness of structs trapped with BUILD_BUG_ON but
I don't think that's more than a cosmetic flaw since there
aren't that many args anyway.
Compile tested.
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Signed-off-by: David S. Miller <davem@davemloft.net>
2008-12-16 12:15:11 +03:00
|
|
|
return 1;
|
2005-04-17 02:20:36 +04:00
|
|
|
|
2007-04-11 08:21:55 +04:00
|
|
|
skb->mac_header = skb->network_header;
|
2005-04-17 02:20:36 +04:00
|
|
|
skb_pull(skb, (u8*)encap - skb->data);
|
2007-03-11 01:04:55 +03:00
|
|
|
skb_reset_network_header(skb);
|
2005-04-17 02:20:36 +04:00
|
|
|
skb->dev = reg_dev;
|
|
|
|
skb->protocol = htons(ETH_P_IP);
|
|
|
|
skb->ip_summed = 0;
|
|
|
|
skb->pkt_type = PACKET_HOST;
|
|
|
|
dst_release(skb->dst);
|
|
|
|
skb->dst = NULL;
|
2008-05-22 01:17:33 +04:00
|
|
|
reg_dev->stats.rx_bytes += skb->len;
|
|
|
|
reg_dev->stats.rx_packets++;
|
2005-04-17 02:20:36 +04:00
|
|
|
nf_reset(skb);
|
|
|
|
netif_rx(skb);
|
|
|
|
dev_put(reg_dev);
|
ipmr: merge common code
Also removes redundant skb->len < x check which can't
be true once pskb_may_pull(skb, x) succeeded.
$ diff-funcs pim_rcv ipmr.c ipmr.c pim_rcv_v1
--- ipmr.c:pim_rcv()
+++ ipmr.c:pim_rcv_v1()
@@ -1,22 +1,27 @@
-static int pim_rcv(struct sk_buff * skb)
+int pim_rcv_v1(struct sk_buff * skb)
{
- struct pimreghdr *pim;
+ struct igmphdr *pim;
struct iphdr *encap;
struct net_device *reg_dev = NULL;
if (!pskb_may_pull(skb, sizeof(*pim) + sizeof(*encap)))
goto drop;
- pim = (struct pimreghdr *)skb_transport_header(skb);
- if (pim->type != ((PIM_VERSION<<4)|(PIM_REGISTER)) ||
- (pim->flags&PIM_NULL_REGISTER) ||
- (ip_compute_csum((void *)pim, sizeof(*pim)) != 0 &&
- csum_fold(skb_checksum(skb, 0, skb->len, 0))))
+ pim = igmp_hdr(skb);
+
+ if (!mroute_do_pim ||
+ skb->len < sizeof(*pim) + sizeof(*encap) ||
+ pim->group != PIM_V1_VERSION || pim->code != PIM_V1_REGISTER)
goto drop;
- /* check if the inner packet is destined to mcast group */
encap = (struct iphdr *)(skb_transport_header(skb) +
- sizeof(struct pimreghdr));
+ sizeof(struct igmphdr));
+ /*
+ Check that:
+ a. packet is really destinted to a multicast group
+ b. packet is not a NULL-REGISTER
+ c. packet is not truncated
+ */
if (!ipv4_is_multicast(encap->daddr) ||
encap->tot_len == 0 ||
ntohs(encap->tot_len) + sizeof(*pim) > skb->len)
@@ -40,9 +45,9 @@
skb->ip_summed = 0;
skb->pkt_type = PACKET_HOST;
dst_release(skb->dst);
+ skb->dst = NULL;
reg_dev->stats.rx_bytes += skb->len;
reg_dev->stats.rx_packets++;
- skb->dst = NULL;
nf_reset(skb);
netif_rx(skb);
dev_put(reg_dev);
$ codiff net/ipv4/ipmr.o.old net/ipv4/ipmr.o.new
net/ipv4/ipmr.c:
pim_rcv_v1 | -283
pim_rcv | -284
2 functions changed, 567 bytes removed
net/ipv4/ipmr.c:
__pim_rcv | +307
1 function changed, 307 bytes added
net/ipv4/ipmr.o.new:
3 functions changed, 307 bytes added, 567 bytes removed, diff: -260
(Tested on x86_64).
It seems that pimlen arg could be left out as well and
eq-sizedness of structs trapped with BUILD_BUG_ON but
I don't think that's more than a cosmetic flaw since there
aren't that many args anyway.
Compile tested.
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Signed-off-by: David S. Miller <davem@davemloft.net>
2008-12-16 12:15:11 +03:00
|
|
|
|
2005-04-17 02:20:36 +04:00
|
|
|
return 0;
|
ipmr: merge common code
Also removes redundant skb->len < x check which can't
be true once pskb_may_pull(skb, x) succeeded.
$ diff-funcs pim_rcv ipmr.c ipmr.c pim_rcv_v1
--- ipmr.c:pim_rcv()
+++ ipmr.c:pim_rcv_v1()
@@ -1,22 +1,27 @@
-static int pim_rcv(struct sk_buff * skb)
+int pim_rcv_v1(struct sk_buff * skb)
{
- struct pimreghdr *pim;
+ struct igmphdr *pim;
struct iphdr *encap;
struct net_device *reg_dev = NULL;
if (!pskb_may_pull(skb, sizeof(*pim) + sizeof(*encap)))
goto drop;
- pim = (struct pimreghdr *)skb_transport_header(skb);
- if (pim->type != ((PIM_VERSION<<4)|(PIM_REGISTER)) ||
- (pim->flags&PIM_NULL_REGISTER) ||
- (ip_compute_csum((void *)pim, sizeof(*pim)) != 0 &&
- csum_fold(skb_checksum(skb, 0, skb->len, 0))))
+ pim = igmp_hdr(skb);
+
+ if (!mroute_do_pim ||
+ skb->len < sizeof(*pim) + sizeof(*encap) ||
+ pim->group != PIM_V1_VERSION || pim->code != PIM_V1_REGISTER)
goto drop;
- /* check if the inner packet is destined to mcast group */
encap = (struct iphdr *)(skb_transport_header(skb) +
- sizeof(struct pimreghdr));
+ sizeof(struct igmphdr));
+ /*
+ Check that:
+ a. packet is really destinted to a multicast group
+ b. packet is not a NULL-REGISTER
+ c. packet is not truncated
+ */
if (!ipv4_is_multicast(encap->daddr) ||
encap->tot_len == 0 ||
ntohs(encap->tot_len) + sizeof(*pim) > skb->len)
@@ -40,9 +45,9 @@
skb->ip_summed = 0;
skb->pkt_type = PACKET_HOST;
dst_release(skb->dst);
+ skb->dst = NULL;
reg_dev->stats.rx_bytes += skb->len;
reg_dev->stats.rx_packets++;
- skb->dst = NULL;
nf_reset(skb);
netif_rx(skb);
dev_put(reg_dev);
$ codiff net/ipv4/ipmr.o.old net/ipv4/ipmr.o.new
net/ipv4/ipmr.c:
pim_rcv_v1 | -283
pim_rcv | -284
2 functions changed, 567 bytes removed
net/ipv4/ipmr.c:
__pim_rcv | +307
1 function changed, 307 bytes added
net/ipv4/ipmr.o.new:
3 functions changed, 307 bytes added, 567 bytes removed, diff: -260
(Tested on x86_64).
It seems that pimlen arg could be left out as well and
eq-sizedness of structs trapped with BUILD_BUG_ON but
I don't think that's more than a cosmetic flaw since there
aren't that many args anyway.
Compile tested.
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Signed-off-by: David S. Miller <davem@davemloft.net>
2008-12-16 12:15:11 +03:00
|
|
|
}
|
|
|
|
#endif
|
|
|
|
|
|
|
|
#ifdef CONFIG_IP_PIMSM_V1
|
|
|
|
/*
|
|
|
|
* Handle IGMP messages of PIMv1
|
|
|
|
*/
|
|
|
|
|
|
|
|
int pim_rcv_v1(struct sk_buff * skb)
|
|
|
|
{
|
|
|
|
struct igmphdr *pim;
|
|
|
|
|
|
|
|
if (!pskb_may_pull(skb, sizeof(*pim) + sizeof(struct iphdr)))
|
|
|
|
goto drop;
|
|
|
|
|
|
|
|
pim = igmp_hdr(skb);
|
|
|
|
|
|
|
|
if (!mroute_do_pim ||
|
|
|
|
pim->group != PIM_V1_VERSION || pim->code != PIM_V1_REGISTER)
|
|
|
|
goto drop;
|
|
|
|
|
|
|
|
if (__pim_rcv(skb, sizeof(*pim))) {
|
|
|
|
drop:
|
|
|
|
kfree_skb(skb);
|
|
|
|
}
|
2005-04-17 02:20:36 +04:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
|
|
|
|
#ifdef CONFIG_IP_PIMSM_V2
|
|
|
|
static int pim_rcv(struct sk_buff * skb)
|
|
|
|
{
|
|
|
|
struct pimreghdr *pim;
|
|
|
|
|
ipmr: merge common code
Also removes redundant skb->len < x check which can't
be true once pskb_may_pull(skb, x) succeeded.
$ diff-funcs pim_rcv ipmr.c ipmr.c pim_rcv_v1
--- ipmr.c:pim_rcv()
+++ ipmr.c:pim_rcv_v1()
@@ -1,22 +1,27 @@
-static int pim_rcv(struct sk_buff * skb)
+int pim_rcv_v1(struct sk_buff * skb)
{
- struct pimreghdr *pim;
+ struct igmphdr *pim;
struct iphdr *encap;
struct net_device *reg_dev = NULL;
if (!pskb_may_pull(skb, sizeof(*pim) + sizeof(*encap)))
goto drop;
- pim = (struct pimreghdr *)skb_transport_header(skb);
- if (pim->type != ((PIM_VERSION<<4)|(PIM_REGISTER)) ||
- (pim->flags&PIM_NULL_REGISTER) ||
- (ip_compute_csum((void *)pim, sizeof(*pim)) != 0 &&
- csum_fold(skb_checksum(skb, 0, skb->len, 0))))
+ pim = igmp_hdr(skb);
+
+ if (!mroute_do_pim ||
+ skb->len < sizeof(*pim) + sizeof(*encap) ||
+ pim->group != PIM_V1_VERSION || pim->code != PIM_V1_REGISTER)
goto drop;
- /* check if the inner packet is destined to mcast group */
encap = (struct iphdr *)(skb_transport_header(skb) +
- sizeof(struct pimreghdr));
+ sizeof(struct igmphdr));
+ /*
+ Check that:
+ a. packet is really destinted to a multicast group
+ b. packet is not a NULL-REGISTER
+ c. packet is not truncated
+ */
if (!ipv4_is_multicast(encap->daddr) ||
encap->tot_len == 0 ||
ntohs(encap->tot_len) + sizeof(*pim) > skb->len)
@@ -40,9 +45,9 @@
skb->ip_summed = 0;
skb->pkt_type = PACKET_HOST;
dst_release(skb->dst);
+ skb->dst = NULL;
reg_dev->stats.rx_bytes += skb->len;
reg_dev->stats.rx_packets++;
- skb->dst = NULL;
nf_reset(skb);
netif_rx(skb);
dev_put(reg_dev);
$ codiff net/ipv4/ipmr.o.old net/ipv4/ipmr.o.new
net/ipv4/ipmr.c:
pim_rcv_v1 | -283
pim_rcv | -284
2 functions changed, 567 bytes removed
net/ipv4/ipmr.c:
__pim_rcv | +307
1 function changed, 307 bytes added
net/ipv4/ipmr.o.new:
3 functions changed, 307 bytes added, 567 bytes removed, diff: -260
(Tested on x86_64).
It seems that pimlen arg could be left out as well and
eq-sizedness of structs trapped with BUILD_BUG_ON but
I don't think that's more than a cosmetic flaw since there
aren't that many args anyway.
Compile tested.
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Signed-off-by: David S. Miller <davem@davemloft.net>
2008-12-16 12:15:11 +03:00
|
|
|
if (!pskb_may_pull(skb, sizeof(*pim) + sizeof(struct iphdr)))
|
2005-04-17 02:20:36 +04:00
|
|
|
goto drop;
|
|
|
|
|
2007-04-26 05:04:18 +04:00
|
|
|
pim = (struct pimreghdr *)skb_transport_header(skb);
|
2007-02-09 17:24:47 +03:00
|
|
|
if (pim->type != ((PIM_VERSION<<4)|(PIM_REGISTER)) ||
|
2005-04-17 02:20:36 +04:00
|
|
|
(pim->flags&PIM_NULL_REGISTER) ||
|
2007-02-09 17:24:47 +03:00
|
|
|
(ip_compute_csum((void *)pim, sizeof(*pim)) != 0 &&
|
2006-11-15 08:24:49 +03:00
|
|
|
csum_fold(skb_checksum(skb, 0, skb->len, 0))))
|
2005-04-17 02:20:36 +04:00
|
|
|
goto drop;
|
|
|
|
|
ipmr: merge common code
Also removes redundant skb->len < x check which can't
be true once pskb_may_pull(skb, x) succeeded.
$ diff-funcs pim_rcv ipmr.c ipmr.c pim_rcv_v1
--- ipmr.c:pim_rcv()
+++ ipmr.c:pim_rcv_v1()
@@ -1,22 +1,27 @@
-static int pim_rcv(struct sk_buff * skb)
+int pim_rcv_v1(struct sk_buff * skb)
{
- struct pimreghdr *pim;
+ struct igmphdr *pim;
struct iphdr *encap;
struct net_device *reg_dev = NULL;
if (!pskb_may_pull(skb, sizeof(*pim) + sizeof(*encap)))
goto drop;
- pim = (struct pimreghdr *)skb_transport_header(skb);
- if (pim->type != ((PIM_VERSION<<4)|(PIM_REGISTER)) ||
- (pim->flags&PIM_NULL_REGISTER) ||
- (ip_compute_csum((void *)pim, sizeof(*pim)) != 0 &&
- csum_fold(skb_checksum(skb, 0, skb->len, 0))))
+ pim = igmp_hdr(skb);
+
+ if (!mroute_do_pim ||
+ skb->len < sizeof(*pim) + sizeof(*encap) ||
+ pim->group != PIM_V1_VERSION || pim->code != PIM_V1_REGISTER)
goto drop;
- /* check if the inner packet is destined to mcast group */
encap = (struct iphdr *)(skb_transport_header(skb) +
- sizeof(struct pimreghdr));
+ sizeof(struct igmphdr));
+ /*
+ Check that:
+ a. packet is really destinted to a multicast group
+ b. packet is not a NULL-REGISTER
+ c. packet is not truncated
+ */
if (!ipv4_is_multicast(encap->daddr) ||
encap->tot_len == 0 ||
ntohs(encap->tot_len) + sizeof(*pim) > skb->len)
@@ -40,9 +45,9 @@
skb->ip_summed = 0;
skb->pkt_type = PACKET_HOST;
dst_release(skb->dst);
+ skb->dst = NULL;
reg_dev->stats.rx_bytes += skb->len;
reg_dev->stats.rx_packets++;
- skb->dst = NULL;
nf_reset(skb);
netif_rx(skb);
dev_put(reg_dev);
$ codiff net/ipv4/ipmr.o.old net/ipv4/ipmr.o.new
net/ipv4/ipmr.c:
pim_rcv_v1 | -283
pim_rcv | -284
2 functions changed, 567 bytes removed
net/ipv4/ipmr.c:
__pim_rcv | +307
1 function changed, 307 bytes added
net/ipv4/ipmr.o.new:
3 functions changed, 307 bytes added, 567 bytes removed, diff: -260
(Tested on x86_64).
It seems that pimlen arg could be left out as well and
eq-sizedness of structs trapped with BUILD_BUG_ON but
I don't think that's more than a cosmetic flaw since there
aren't that many args anyway.
Compile tested.
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Signed-off-by: David S. Miller <davem@davemloft.net>
2008-12-16 12:15:11 +03:00
|
|
|
if (__pim_rcv(skb, sizeof(*pim))) {
|
|
|
|
drop:
|
|
|
|
kfree_skb(skb);
|
|
|
|
}
|
2005-04-17 02:20:36 +04:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
|
|
|
|
static int
|
|
|
|
ipmr_fill_mroute(struct sk_buff *skb, struct mfc_cache *c, struct rtmsg *rtm)
|
|
|
|
{
|
|
|
|
int ct;
|
|
|
|
struct rtnexthop *nhp;
|
|
|
|
struct net_device *dev = vif_table[c->mfc_parent].dev;
|
2007-04-20 07:29:13 +04:00
|
|
|
u8 *b = skb_tail_pointer(skb);
|
2005-04-17 02:20:36 +04:00
|
|
|
struct rtattr *mp_head;
|
|
|
|
|
|
|
|
if (dev)
|
|
|
|
RTA_PUT(skb, RTA_IIF, 4, &dev->ifindex);
|
|
|
|
|
2008-11-03 11:28:02 +03:00
|
|
|
mp_head = (struct rtattr *)skb_put(skb, RTA_LENGTH(0));
|
2005-04-17 02:20:36 +04:00
|
|
|
|
|
|
|
for (ct = c->mfc_un.res.minvif; ct < c->mfc_un.res.maxvif; ct++) {
|
|
|
|
if (c->mfc_un.res.ttls[ct] < 255) {
|
|
|
|
if (skb_tailroom(skb) < RTA_ALIGN(RTA_ALIGN(sizeof(*nhp)) + 4))
|
|
|
|
goto rtattr_failure;
|
2008-11-03 11:28:02 +03:00
|
|
|
nhp = (struct rtnexthop *)skb_put(skb, RTA_ALIGN(sizeof(*nhp)));
|
2005-04-17 02:20:36 +04:00
|
|
|
nhp->rtnh_flags = 0;
|
|
|
|
nhp->rtnh_hops = c->mfc_un.res.ttls[ct];
|
|
|
|
nhp->rtnh_ifindex = vif_table[ct].dev->ifindex;
|
|
|
|
nhp->rtnh_len = sizeof(*nhp);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
mp_head->rta_type = RTA_MULTIPATH;
|
2007-04-20 07:29:13 +04:00
|
|
|
mp_head->rta_len = skb_tail_pointer(skb) - (u8 *)mp_head;
|
2005-04-17 02:20:36 +04:00
|
|
|
rtm->rtm_type = RTN_MULTICAST;
|
|
|
|
return 1;
|
|
|
|
|
|
|
|
rtattr_failure:
|
2007-03-26 10:06:12 +04:00
|
|
|
nlmsg_trim(skb, b);
|
2005-04-17 02:20:36 +04:00
|
|
|
return -EMSGSIZE;
|
|
|
|
}
|
|
|
|
|
|
|
|
int ipmr_get_route(struct sk_buff *skb, struct rtmsg *rtm, int nowait)
|
|
|
|
{
|
|
|
|
int err;
|
|
|
|
struct mfc_cache *cache;
|
2008-03-06 05:30:47 +03:00
|
|
|
struct rtable *rt = skb->rtable;
|
2005-04-17 02:20:36 +04:00
|
|
|
|
|
|
|
read_lock(&mrt_lock);
|
|
|
|
cache = ipmr_cache_find(rt->rt_src, rt->rt_dst);
|
|
|
|
|
2008-11-03 11:28:02 +03:00
|
|
|
if (cache == NULL) {
|
2006-07-26 03:45:12 +04:00
|
|
|
struct sk_buff *skb2;
|
2007-04-21 09:47:35 +04:00
|
|
|
struct iphdr *iph;
|
2005-04-17 02:20:36 +04:00
|
|
|
struct net_device *dev;
|
|
|
|
int vif;
|
|
|
|
|
|
|
|
if (nowait) {
|
|
|
|
read_unlock(&mrt_lock);
|
|
|
|
return -EAGAIN;
|
|
|
|
}
|
|
|
|
|
|
|
|
dev = skb->dev;
|
|
|
|
if (dev == NULL || (vif = ipmr_find_vif(dev)) < 0) {
|
|
|
|
read_unlock(&mrt_lock);
|
|
|
|
return -ENODEV;
|
|
|
|
}
|
2006-07-26 03:45:12 +04:00
|
|
|
skb2 = skb_clone(skb, GFP_ATOMIC);
|
|
|
|
if (!skb2) {
|
|
|
|
read_unlock(&mrt_lock);
|
|
|
|
return -ENOMEM;
|
|
|
|
}
|
|
|
|
|
2007-04-11 07:46:21 +04:00
|
|
|
skb_push(skb2, sizeof(struct iphdr));
|
|
|
|
skb_reset_network_header(skb2);
|
2007-04-21 09:47:35 +04:00
|
|
|
iph = ip_hdr(skb2);
|
|
|
|
iph->ihl = sizeof(struct iphdr) >> 2;
|
|
|
|
iph->saddr = rt->rt_src;
|
|
|
|
iph->daddr = rt->rt_dst;
|
|
|
|
iph->version = 0;
|
2006-07-26 03:45:12 +04:00
|
|
|
err = ipmr_cache_unresolved(vif, skb2);
|
2005-04-17 02:20:36 +04:00
|
|
|
read_unlock(&mrt_lock);
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!nowait && (rtm->rtm_flags&RTM_F_NOTIFY))
|
|
|
|
cache->mfc_flags |= MFC_NOTIFY;
|
|
|
|
err = ipmr_fill_mroute(skb, cache, rtm);
|
|
|
|
read_unlock(&mrt_lock);
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
2007-02-09 17:24:47 +03:00
|
|
|
#ifdef CONFIG_PROC_FS
|
2005-04-17 02:20:36 +04:00
|
|
|
/*
|
|
|
|
* The /proc interfaces to multicast routing /proc/ip_mr_cache /proc/ip_mr_vif
|
|
|
|
*/
|
|
|
|
struct ipmr_vif_iter {
|
|
|
|
int ct;
|
|
|
|
};
|
|
|
|
|
|
|
|
static struct vif_device *ipmr_vif_seq_idx(struct ipmr_vif_iter *iter,
|
|
|
|
loff_t pos)
|
|
|
|
{
|
|
|
|
for (iter->ct = 0; iter->ct < maxvif; ++iter->ct) {
|
2007-03-09 07:44:43 +03:00
|
|
|
if (!VIF_EXISTS(iter->ct))
|
2005-04-17 02:20:36 +04:00
|
|
|
continue;
|
2007-02-09 17:24:47 +03:00
|
|
|
if (pos-- == 0)
|
2005-04-17 02:20:36 +04:00
|
|
|
return &vif_table[iter->ct];
|
|
|
|
}
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void *ipmr_vif_seq_start(struct seq_file *seq, loff_t *pos)
|
2008-01-22 04:28:59 +03:00
|
|
|
__acquires(mrt_lock)
|
2005-04-17 02:20:36 +04:00
|
|
|
{
|
|
|
|
read_lock(&mrt_lock);
|
2007-02-09 17:24:47 +03:00
|
|
|
return *pos ? ipmr_vif_seq_idx(seq->private, *pos - 1)
|
2005-04-17 02:20:36 +04:00
|
|
|
: SEQ_START_TOKEN;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void *ipmr_vif_seq_next(struct seq_file *seq, void *v, loff_t *pos)
|
|
|
|
{
|
|
|
|
struct ipmr_vif_iter *iter = seq->private;
|
|
|
|
|
|
|
|
++*pos;
|
|
|
|
if (v == SEQ_START_TOKEN)
|
|
|
|
return ipmr_vif_seq_idx(iter, 0);
|
2007-02-09 17:24:47 +03:00
|
|
|
|
2005-04-17 02:20:36 +04:00
|
|
|
while (++iter->ct < maxvif) {
|
2007-03-09 07:44:43 +03:00
|
|
|
if (!VIF_EXISTS(iter->ct))
|
2005-04-17 02:20:36 +04:00
|
|
|
continue;
|
|
|
|
return &vif_table[iter->ct];
|
|
|
|
}
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void ipmr_vif_seq_stop(struct seq_file *seq, void *v)
|
2008-01-22 04:28:59 +03:00
|
|
|
__releases(mrt_lock)
|
2005-04-17 02:20:36 +04:00
|
|
|
{
|
|
|
|
read_unlock(&mrt_lock);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int ipmr_vif_seq_show(struct seq_file *seq, void *v)
|
|
|
|
{
|
|
|
|
if (v == SEQ_START_TOKEN) {
|
2007-02-09 17:24:47 +03:00
|
|
|
seq_puts(seq,
|
2005-04-17 02:20:36 +04:00
|
|
|
"Interface BytesIn PktsIn BytesOut PktsOut Flags Local Remote\n");
|
|
|
|
} else {
|
|
|
|
const struct vif_device *vif = v;
|
|
|
|
const char *name = vif->dev ? vif->dev->name : "none";
|
|
|
|
|
|
|
|
seq_printf(seq,
|
|
|
|
"%2Zd %-10s %8ld %7ld %8ld %7ld %05X %08X %08X\n",
|
|
|
|
vif - vif_table,
|
2007-02-09 17:24:47 +03:00
|
|
|
name, vif->bytes_in, vif->pkt_in,
|
2005-04-17 02:20:36 +04:00
|
|
|
vif->bytes_out, vif->pkt_out,
|
|
|
|
vif->flags, vif->local, vif->remote);
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2007-03-13 00:34:29 +03:00
|
|
|
static const struct seq_operations ipmr_vif_seq_ops = {
|
2005-04-17 02:20:36 +04:00
|
|
|
.start = ipmr_vif_seq_start,
|
|
|
|
.next = ipmr_vif_seq_next,
|
|
|
|
.stop = ipmr_vif_seq_stop,
|
|
|
|
.show = ipmr_vif_seq_show,
|
|
|
|
};
|
|
|
|
|
|
|
|
static int ipmr_vif_open(struct inode *inode, struct file *file)
|
|
|
|
{
|
2007-10-10 13:29:29 +04:00
|
|
|
return seq_open_private(file, &ipmr_vif_seq_ops,
|
|
|
|
sizeof(struct ipmr_vif_iter));
|
2005-04-17 02:20:36 +04:00
|
|
|
}
|
|
|
|
|
2007-02-12 11:55:35 +03:00
|
|
|
static const struct file_operations ipmr_vif_fops = {
|
2005-04-17 02:20:36 +04:00
|
|
|
.owner = THIS_MODULE,
|
|
|
|
.open = ipmr_vif_open,
|
|
|
|
.read = seq_read,
|
|
|
|
.llseek = seq_lseek,
|
|
|
|
.release = seq_release_private,
|
|
|
|
};
|
|
|
|
|
|
|
|
struct ipmr_mfc_iter {
|
|
|
|
struct mfc_cache **cache;
|
|
|
|
int ct;
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
|
|
static struct mfc_cache *ipmr_mfc_seq_idx(struct ipmr_mfc_iter *it, loff_t pos)
|
|
|
|
{
|
|
|
|
struct mfc_cache *mfc;
|
|
|
|
|
|
|
|
it->cache = mfc_cache_array;
|
|
|
|
read_lock(&mrt_lock);
|
2007-02-09 17:24:47 +03:00
|
|
|
for (it->ct = 0; it->ct < MFC_LINES; it->ct++)
|
2007-03-09 07:44:43 +03:00
|
|
|
for (mfc = mfc_cache_array[it->ct]; mfc; mfc = mfc->next)
|
2007-02-09 17:24:47 +03:00
|
|
|
if (pos-- == 0)
|
2005-04-17 02:20:36 +04:00
|
|
|
return mfc;
|
|
|
|
read_unlock(&mrt_lock);
|
|
|
|
|
|
|
|
it->cache = &mfc_unres_queue;
|
|
|
|
spin_lock_bh(&mfc_unres_lock);
|
2007-03-09 07:44:43 +03:00
|
|
|
for (mfc = mfc_unres_queue; mfc; mfc = mfc->next)
|
2005-04-17 02:20:36 +04:00
|
|
|
if (pos-- == 0)
|
|
|
|
return mfc;
|
|
|
|
spin_unlock_bh(&mfc_unres_lock);
|
|
|
|
|
|
|
|
it->cache = NULL;
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
static void *ipmr_mfc_seq_start(struct seq_file *seq, loff_t *pos)
|
|
|
|
{
|
|
|
|
struct ipmr_mfc_iter *it = seq->private;
|
|
|
|
it->cache = NULL;
|
|
|
|
it->ct = 0;
|
2007-02-09 17:24:47 +03:00
|
|
|
return *pos ? ipmr_mfc_seq_idx(seq->private, *pos - 1)
|
2005-04-17 02:20:36 +04:00
|
|
|
: SEQ_START_TOKEN;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void *ipmr_mfc_seq_next(struct seq_file *seq, void *v, loff_t *pos)
|
|
|
|
{
|
|
|
|
struct mfc_cache *mfc = v;
|
|
|
|
struct ipmr_mfc_iter *it = seq->private;
|
|
|
|
|
|
|
|
++*pos;
|
|
|
|
|
|
|
|
if (v == SEQ_START_TOKEN)
|
|
|
|
return ipmr_mfc_seq_idx(seq->private, 0);
|
|
|
|
|
|
|
|
if (mfc->next)
|
|
|
|
return mfc->next;
|
2007-02-09 17:24:47 +03:00
|
|
|
|
|
|
|
if (it->cache == &mfc_unres_queue)
|
2005-04-17 02:20:36 +04:00
|
|
|
goto end_of_list;
|
|
|
|
|
|
|
|
BUG_ON(it->cache != mfc_cache_array);
|
|
|
|
|
|
|
|
while (++it->ct < MFC_LINES) {
|
|
|
|
mfc = mfc_cache_array[it->ct];
|
|
|
|
if (mfc)
|
|
|
|
return mfc;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* exhausted cache_array, show unresolved */
|
|
|
|
read_unlock(&mrt_lock);
|
|
|
|
it->cache = &mfc_unres_queue;
|
|
|
|
it->ct = 0;
|
2007-02-09 17:24:47 +03:00
|
|
|
|
2005-04-17 02:20:36 +04:00
|
|
|
spin_lock_bh(&mfc_unres_lock);
|
|
|
|
mfc = mfc_unres_queue;
|
2007-02-09 17:24:47 +03:00
|
|
|
if (mfc)
|
2005-04-17 02:20:36 +04:00
|
|
|
return mfc;
|
|
|
|
|
|
|
|
end_of_list:
|
|
|
|
spin_unlock_bh(&mfc_unres_lock);
|
|
|
|
it->cache = NULL;
|
|
|
|
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void ipmr_mfc_seq_stop(struct seq_file *seq, void *v)
|
|
|
|
{
|
|
|
|
struct ipmr_mfc_iter *it = seq->private;
|
|
|
|
|
|
|
|
if (it->cache == &mfc_unres_queue)
|
|
|
|
spin_unlock_bh(&mfc_unres_lock);
|
|
|
|
else if (it->cache == mfc_cache_array)
|
|
|
|
read_unlock(&mrt_lock);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int ipmr_mfc_seq_show(struct seq_file *seq, void *v)
|
|
|
|
{
|
|
|
|
int n;
|
|
|
|
|
|
|
|
if (v == SEQ_START_TOKEN) {
|
2007-02-09 17:24:47 +03:00
|
|
|
seq_puts(seq,
|
2005-04-17 02:20:36 +04:00
|
|
|
"Group Origin Iif Pkts Bytes Wrong Oifs\n");
|
|
|
|
} else {
|
|
|
|
const struct mfc_cache *mfc = v;
|
|
|
|
const struct ipmr_mfc_iter *it = seq->private;
|
2007-02-09 17:24:47 +03:00
|
|
|
|
2008-12-04 09:22:16 +03:00
|
|
|
seq_printf(seq, "%08lX %08lX %-3hd",
|
2005-04-17 02:20:36 +04:00
|
|
|
(unsigned long) mfc->mfc_mcastgrp,
|
|
|
|
(unsigned long) mfc->mfc_origin,
|
2008-12-04 09:21:47 +03:00
|
|
|
mfc->mfc_parent);
|
2005-04-17 02:20:36 +04:00
|
|
|
|
|
|
|
if (it->cache != &mfc_unres_queue) {
|
2008-12-04 09:21:47 +03:00
|
|
|
seq_printf(seq, " %8lu %8lu %8lu",
|
|
|
|
mfc->mfc_un.res.pkt,
|
|
|
|
mfc->mfc_un.res.bytes,
|
|
|
|
mfc->mfc_un.res.wrong_if);
|
2007-03-09 07:44:43 +03:00
|
|
|
for (n = mfc->mfc_un.res.minvif;
|
|
|
|
n < mfc->mfc_un.res.maxvif; n++ ) {
|
|
|
|
if (VIF_EXISTS(n)
|
2005-04-17 02:20:36 +04:00
|
|
|
&& mfc->mfc_un.res.ttls[n] < 255)
|
2007-02-09 17:24:47 +03:00
|
|
|
seq_printf(seq,
|
|
|
|
" %2d:%-3d",
|
2005-04-17 02:20:36 +04:00
|
|
|
n, mfc->mfc_un.res.ttls[n]);
|
|
|
|
}
|
2008-12-04 09:21:47 +03:00
|
|
|
} else {
|
|
|
|
/* unresolved mfc_caches don't contain
|
|
|
|
* pkt, bytes and wrong_if values
|
|
|
|
*/
|
|
|
|
seq_printf(seq, " %8lu %8lu %8lu", 0ul, 0ul, 0ul);
|
2005-04-17 02:20:36 +04:00
|
|
|
}
|
|
|
|
seq_putc(seq, '\n');
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2007-03-13 00:34:29 +03:00
|
|
|
static const struct seq_operations ipmr_mfc_seq_ops = {
|
2005-04-17 02:20:36 +04:00
|
|
|
.start = ipmr_mfc_seq_start,
|
|
|
|
.next = ipmr_mfc_seq_next,
|
|
|
|
.stop = ipmr_mfc_seq_stop,
|
|
|
|
.show = ipmr_mfc_seq_show,
|
|
|
|
};
|
|
|
|
|
|
|
|
static int ipmr_mfc_open(struct inode *inode, struct file *file)
|
|
|
|
{
|
2007-10-10 13:29:29 +04:00
|
|
|
return seq_open_private(file, &ipmr_mfc_seq_ops,
|
|
|
|
sizeof(struct ipmr_mfc_iter));
|
2005-04-17 02:20:36 +04:00
|
|
|
}
|
|
|
|
|
2007-02-12 11:55:35 +03:00
|
|
|
static const struct file_operations ipmr_mfc_fops = {
|
2005-04-17 02:20:36 +04:00
|
|
|
.owner = THIS_MODULE,
|
|
|
|
.open = ipmr_mfc_open,
|
|
|
|
.read = seq_read,
|
|
|
|
.llseek = seq_lseek,
|
|
|
|
.release = seq_release_private,
|
|
|
|
};
|
2007-02-09 17:24:47 +03:00
|
|
|
#endif
|
2005-04-17 02:20:36 +04:00
|
|
|
|
|
|
|
#ifdef CONFIG_IP_PIMSM_V2
|
|
|
|
static struct net_protocol pim_protocol = {
|
|
|
|
.handler = pim_rcv,
|
|
|
|
};
|
|
|
|
#endif
|
|
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Setup for IP multicast routing
|
|
|
|
*/
|
2007-02-09 17:24:47 +03:00
|
|
|
|
2008-07-03 08:13:36 +04:00
|
|
|
int __init ip_mr_init(void)
|
2005-04-17 02:20:36 +04:00
|
|
|
{
|
2008-07-03 08:13:36 +04:00
|
|
|
int err;
|
|
|
|
|
2005-04-17 02:20:36 +04:00
|
|
|
mrt_cachep = kmem_cache_create("ip_mrt_cache",
|
|
|
|
sizeof(struct mfc_cache),
|
2006-08-27 06:25:52 +04:00
|
|
|
0, SLAB_HWCACHE_ALIGN|SLAB_PANIC,
|
2007-07-20 05:11:58 +04:00
|
|
|
NULL);
|
2008-07-03 08:13:36 +04:00
|
|
|
if (!mrt_cachep)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
2008-01-24 08:20:07 +03:00
|
|
|
setup_timer(&ipmr_expire_timer, ipmr_expire_process, 0);
|
2008-07-03 08:13:36 +04:00
|
|
|
err = register_netdevice_notifier(&ip_mr_notifier);
|
|
|
|
if (err)
|
|
|
|
goto reg_notif_fail;
|
2007-02-09 17:24:47 +03:00
|
|
|
#ifdef CONFIG_PROC_FS
|
2008-07-03 08:13:36 +04:00
|
|
|
err = -ENOMEM;
|
|
|
|
if (!proc_net_fops_create(&init_net, "ip_mr_vif", 0, &ipmr_vif_fops))
|
|
|
|
goto proc_vif_fail;
|
|
|
|
if (!proc_net_fops_create(&init_net, "ip_mr_cache", 0, &ipmr_mfc_fops))
|
|
|
|
goto proc_cache_fail;
|
2007-02-09 17:24:47 +03:00
|
|
|
#endif
|
2008-07-03 08:13:36 +04:00
|
|
|
return 0;
|
|
|
|
#ifdef CONFIG_PROC_FS
|
|
|
|
proc_cache_fail:
|
|
|
|
proc_net_remove(&init_net, "ip_mr_vif");
|
2008-11-20 01:07:41 +03:00
|
|
|
proc_vif_fail:
|
|
|
|
unregister_netdevice_notifier(&ip_mr_notifier);
|
2008-07-03 08:13:36 +04:00
|
|
|
#endif
|
2008-11-20 01:07:41 +03:00
|
|
|
reg_notif_fail:
|
|
|
|
del_timer(&ipmr_expire_timer);
|
|
|
|
kmem_cache_destroy(mrt_cachep);
|
2008-07-03 08:13:36 +04:00
|
|
|
return err;
|
2005-04-17 02:20:36 +04:00
|
|
|
}
|