License cleanup: add SPDX GPL-2.0 license identifier to files with no license
Many source files in the tree are missing licensing information, which
makes it harder for compliance tools to determine the correct license.
By default all files without license information are under the default
license of the kernel, which is GPL version 2.
Update the files which contain no license information with the 'GPL-2.0'
SPDX license identifier. The SPDX identifier is a legally binding
shorthand, which can be used instead of the full boiler plate text.
This patch is based on work done by Thomas Gleixner and Kate Stewart and
Philippe Ombredanne.
How this work was done:
Patches were generated and checked against linux-4.14-rc6 for a subset of
the use cases:
- file had no licensing information it it.
- file was a */uapi/* one with no licensing information in it,
- file was a */uapi/* one with existing licensing information,
Further patches will be generated in subsequent months to fix up cases
where non-standard license headers were used, and references to license
had to be inferred by heuristics based on keywords.
The analysis to determine which SPDX License Identifier to be applied to
a file was done in a spreadsheet of side by side results from of the
output of two independent scanners (ScanCode & Windriver) producing SPDX
tag:value files created by Philippe Ombredanne. Philippe prepared the
base worksheet, and did an initial spot review of a few 1000 files.
The 4.13 kernel was the starting point of the analysis with 60,537 files
assessed. Kate Stewart did a file by file comparison of the scanner
results in the spreadsheet to determine which SPDX license identifier(s)
to be applied to the file. She confirmed any determination that was not
immediately clear with lawyers working with the Linux Foundation.
Criteria used to select files for SPDX license identifier tagging was:
- Files considered eligible had to be source code files.
- Make and config files were included as candidates if they contained >5
lines of source
- File already had some variant of a license header in it (even if <5
lines).
All documentation files were explicitly excluded.
The following heuristics were used to determine which SPDX license
identifiers to apply.
- when both scanners couldn't find any license traces, file was
considered to have no license information in it, and the top level
COPYING file license applied.
For non */uapi/* files that summary was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 11139
and resulted in the first patch in this series.
If that file was a */uapi/* path one, it was "GPL-2.0 WITH
Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 WITH Linux-syscall-note 930
and resulted in the second patch in this series.
- if a file had some form of licensing information in it, and was one
of the */uapi/* ones, it was denoted with the Linux-syscall-note if
any GPL family license was found in the file or had no licensing in
it (per prior point). Results summary:
SPDX license identifier # files
---------------------------------------------------|------
GPL-2.0 WITH Linux-syscall-note 270
GPL-2.0+ WITH Linux-syscall-note 169
((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21
((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17
LGPL-2.1+ WITH Linux-syscall-note 15
GPL-1.0+ WITH Linux-syscall-note 14
((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5
LGPL-2.0+ WITH Linux-syscall-note 4
LGPL-2.1 WITH Linux-syscall-note 3
((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3
((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1
and that resulted in the third patch in this series.
- when the two scanners agreed on the detected license(s), that became
the concluded license(s).
- when there was disagreement between the two scanners (one detected a
license but the other didn't, or they both detected different
licenses) a manual inspection of the file occurred.
- In most cases a manual inspection of the information in the file
resulted in a clear resolution of the license that should apply (and
which scanner probably needed to revisit its heuristics).
- When it was not immediately clear, the license identifier was
confirmed with lawyers working with the Linux Foundation.
- If there was any question as to the appropriate license identifier,
the file was flagged for further research and to be revisited later
in time.
In total, over 70 hours of logged manual review was done on the
spreadsheet to determine the SPDX license identifiers to apply to the
source files by Kate, Philippe, Thomas and, in some cases, confirmation
by lawyers working with the Linux Foundation.
Kate also obtained a third independent scan of the 4.13 code base from
FOSSology, and compared selected files where the other two scanners
disagreed against that SPDX file, to see if there was new insights. The
Windriver scanner is based on an older version of FOSSology in part, so
they are related.
Thomas did random spot checks in about 500 files from the spreadsheets
for the uapi headers and agreed with SPDX license identifier in the
files he inspected. For the non-uapi files Thomas did random spot checks
in about 15000 files.
In initial set of patches against 4.14-rc6, 3 files were found to have
copy/paste license identifier errors, and have been fixed to reflect the
correct identifier.
Additionally Philippe spent 10 hours this week doing a detailed manual
inspection and review of the 12,461 patched files from the initial patch
version early this week with:
- a full scancode scan run, collecting the matched texts, detected
license ids and scores
- reviewing anything where there was a license detected (about 500+
files) to ensure that the applied SPDX license was correct
- reviewing anything where there was no detection but the patch license
was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied
SPDX license was correct
This produced a worksheet with 20 files needing minor correction. This
worksheet was then exported into 3 different .csv files for the
different types of files to be modified.
These .csv files were then reviewed by Greg. Thomas wrote a script to
parse the csv files and add the proper SPDX tag to the file, in the
format that the file expected. This script was further refined by Greg
based on the output to detect more types of files automatically and to
distinguish between header and source .c files (which need different
comment types.) Finally Greg ran the script using the .csv files to
generate the patches.
Reviewed-by: Kate Stewart <kstewart@linuxfoundation.org>
Reviewed-by: Philippe Ombredanne <pombredanne@nexb.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-11-01 17:07:57 +03:00
|
|
|
/* SPDX-License-Identifier: GPL-2.0 */
|
2012-02-03 11:34:16 +04:00
|
|
|
#include <linux/prefetch.h>
|
|
|
|
|
2005-04-17 02:20:36 +04:00
|
|
|
/**
|
|
|
|
* iommu_fill_pdir - Insert coalesced scatter/gather chunks into the I/O Pdir.
|
|
|
|
* @ioc: The I/O Controller.
|
|
|
|
* @startsg: The scatter/gather list of coalesced chunks.
|
|
|
|
* @nents: The number of entries in the scatter/gather list.
|
|
|
|
* @hint: The DMA Hint.
|
|
|
|
*
|
|
|
|
* This function inserts the coalesced scatter/gather list chunks into the
|
|
|
|
* I/O Controller's I/O Pdir.
|
|
|
|
*/
|
|
|
|
static inline unsigned int
|
|
|
|
iommu_fill_pdir(struct ioc *ioc, struct scatterlist *startsg, int nents,
|
|
|
|
unsigned long hint,
|
|
|
|
void (*iommu_io_pdir_entry)(u64 *, space_t, unsigned long,
|
|
|
|
unsigned long))
|
|
|
|
{
|
|
|
|
struct scatterlist *dma_sg = startsg; /* pointer to current DMA */
|
|
|
|
unsigned int n_mappings = 0;
|
|
|
|
unsigned long dma_offset = 0, dma_len = 0;
|
|
|
|
u64 *pdirp = NULL;
|
|
|
|
|
|
|
|
/* Horrible hack. For efficiency's sake, dma_sg starts one
|
|
|
|
* entry below the true start (it is immediately incremented
|
|
|
|
* in the loop) */
|
|
|
|
dma_sg--;
|
|
|
|
|
|
|
|
while (nents-- > 0) {
|
|
|
|
unsigned long vaddr;
|
|
|
|
long size;
|
|
|
|
|
2015-03-20 20:37:59 +03:00
|
|
|
DBG_RUN_SG(" %d : %08lx/%05x %p/%05x\n", nents,
|
2005-04-17 02:20:36 +04:00
|
|
|
(unsigned long)sg_dma_address(startsg), cnt,
|
2015-03-20 20:37:59 +03:00
|
|
|
sg_virt(startsg), startsg->length
|
2005-04-17 02:20:36 +04:00
|
|
|
);
|
|
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
** Look for the start of a new DMA stream
|
|
|
|
*/
|
|
|
|
|
|
|
|
if (sg_dma_address(startsg) & PIDE_FLAG) {
|
|
|
|
u32 pide = sg_dma_address(startsg) & ~PIDE_FLAG;
|
|
|
|
|
|
|
|
BUG_ON(pdirp && (dma_len != sg_dma_len(dma_sg)));
|
|
|
|
|
|
|
|
dma_sg++;
|
|
|
|
|
|
|
|
dma_len = sg_dma_len(startsg);
|
|
|
|
sg_dma_len(startsg) = 0;
|
|
|
|
dma_offset = (unsigned long) pide & ~IOVP_MASK;
|
|
|
|
n_mappings++;
|
|
|
|
#if defined(ZX1_SUPPORT)
|
|
|
|
/* Pluto IOMMU IO Virt Address is not zero based */
|
|
|
|
sg_dma_address(dma_sg) = pide | ioc->ibase;
|
|
|
|
#else
|
|
|
|
/* SBA, ccio, and dino are zero based.
|
|
|
|
* Trying to save a few CPU cycles for most users.
|
|
|
|
*/
|
|
|
|
sg_dma_address(dma_sg) = pide;
|
|
|
|
#endif
|
|
|
|
pdirp = &(ioc->pdir_base[pide >> IOVP_SHIFT]);
|
|
|
|
prefetchw(pdirp);
|
|
|
|
}
|
|
|
|
|
|
|
|
BUG_ON(pdirp == NULL);
|
|
|
|
|
2015-03-20 20:37:59 +03:00
|
|
|
vaddr = (unsigned long)sg_virt(startsg);
|
2005-04-17 02:20:36 +04:00
|
|
|
sg_dma_len(dma_sg) += startsg->length;
|
|
|
|
size = startsg->length + dma_offset;
|
|
|
|
dma_offset = 0;
|
|
|
|
#ifdef IOMMU_MAP_STATS
|
|
|
|
ioc->msg_pages += startsg->length >> IOVP_SHIFT;
|
|
|
|
#endif
|
|
|
|
do {
|
|
|
|
iommu_io_pdir_entry(pdirp, KERNEL_SPACE,
|
|
|
|
vaddr, hint);
|
|
|
|
vaddr += IOVP_SIZE;
|
|
|
|
size -= IOVP_SIZE;
|
|
|
|
pdirp++;
|
|
|
|
} while(unlikely(size > 0));
|
|
|
|
startsg++;
|
|
|
|
}
|
|
|
|
return(n_mappings);
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
** First pass is to walk the SG list and determine where the breaks are
|
|
|
|
** in the DMA stream. Allocates PDIR entries but does not fill them.
|
|
|
|
** Returns the number of DMA chunks.
|
|
|
|
**
|
|
|
|
** Doing the fill separate from the coalescing/allocation keeps the
|
|
|
|
** code simpler. Future enhancement could make one pass through
|
|
|
|
** the sglist do both.
|
|
|
|
*/
|
|
|
|
|
|
|
|
static inline unsigned int
|
2008-02-05 09:28:03 +03:00
|
|
|
iommu_coalesce_chunks(struct ioc *ioc, struct device *dev,
|
2008-03-05 01:29:28 +03:00
|
|
|
struct scatterlist *startsg, int nents,
|
|
|
|
int (*iommu_alloc_range)(struct ioc *, struct device *, size_t))
|
2005-04-17 02:20:36 +04:00
|
|
|
{
|
|
|
|
struct scatterlist *contig_sg; /* contig chunk head */
|
|
|
|
unsigned long dma_offset, dma_len; /* start/len of DMA stream */
|
|
|
|
unsigned int n_mappings = 0;
|
parisc iommu: fix panic due to trying to allocate too large region
When using the Promise TX2+ SATA controller on PA-RISC, the system often
crashes with kernel panic, for example just writing data with the dd
utility will make it crash.
Kernel panic - not syncing: drivers/parisc/sba_iommu.c: I/O MMU @ 000000000000a000 is out of mapping resources
CPU: 0 PID: 18442 Comm: mkspadfs Not tainted 4.4.0-rc2 #2
Backtrace:
[<000000004021497c>] show_stack+0x14/0x20
[<0000000040410bf0>] dump_stack+0x88/0x100
[<000000004023978c>] panic+0x124/0x360
[<0000000040452c18>] sba_alloc_range+0x698/0x6a0
[<0000000040453150>] sba_map_sg+0x260/0x5b8
[<000000000c18dbb4>] ata_qc_issue+0x264/0x4a8 [libata]
[<000000000c19535c>] ata_scsi_translate+0xe4/0x220 [libata]
[<000000000c19a93c>] ata_scsi_queuecmd+0xbc/0x320 [libata]
[<0000000040499bbc>] scsi_dispatch_cmd+0xfc/0x130
[<000000004049da34>] scsi_request_fn+0x6e4/0x970
[<00000000403e95a8>] __blk_run_queue+0x40/0x60
[<00000000403e9d8c>] blk_run_queue+0x3c/0x68
[<000000004049a534>] scsi_run_queue+0x2a4/0x360
[<000000004049be68>] scsi_end_request+0x1a8/0x238
[<000000004049de84>] scsi_io_completion+0xfc/0x688
[<0000000040493c74>] scsi_finish_command+0x17c/0x1d0
The cause of the crash is not exhaustion of the IOMMU space, there is
plenty of free pages. The function sba_alloc_range is called with size
0x11000, thus the pages_needed variable is 0x11. The function
sba_search_bitmap is called with bits_wanted 0x11 and boundary size is
0x10 (because dma_get_seg_boundary(dev) returns 0xffff).
The function sba_search_bitmap attempts to allocate 17 pages that must not
cross 16-page boundary - it can't satisfy this requirement
(iommu_is_span_boundary always returns true) and fails even if there are
many free entries in the IOMMU space.
How did it happen that we try to allocate 17 pages that don't cross
16-page boundary? The cause is in the function iommu_coalesce_chunks. This
function tries to coalesce adjacent entries in the scatterlist. The
function does several checks if it may coalesce one entry with the next,
one of those checks is this:
if (startsg->length + dma_len > max_seg_size)
break;
When it finishes coalescing adjacent entries, it allocates the mapping:
sg_dma_len(contig_sg) = dma_len;
dma_len = ALIGN(dma_len + dma_offset, IOVP_SIZE);
sg_dma_address(contig_sg) =
PIDE_FLAG
| (iommu_alloc_range(ioc, dev, dma_len) << IOVP_SHIFT)
| dma_offset;
It is possible that (startsg->length + dma_len > max_seg_size) is false
(we are just near the 0x10000 max_seg_size boundary), so the funcion
decides to coalesce this entry with the next entry. When the coalescing
succeeds, the function performs
dma_len = ALIGN(dma_len + dma_offset, IOVP_SIZE);
And now, because of non-zero dma_offset, dma_len is greater than 0x10000.
iommu_alloc_range (a pointer to sba_alloc_range) is called and it attempts
to allocate 17 pages for a device that must not cross 16-page boundary.
To fix the bug, we must make sure that dma_len after addition of
dma_offset and alignment doesn't cross the segment boundary. I.e. change
if (startsg->length + dma_len > max_seg_size)
break;
to
if (ALIGN(dma_len + dma_offset + startsg->length, IOVP_SIZE) > max_seg_size)
break;
This patch makes this change (it precalculates max_seg_boundary at the
beginning of the function iommu_coalesce_chunks). I also added a check
that the mapping length doesn't exceed dma_get_seg_boundary(dev) (it is
not needed for Promise TX2+ SATA, but it may be needed for other devices
that have dma_get_seg_boundary lower than dma_get_max_seg_size).
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Cc: stable@vger.kernel.org
Signed-off-by: Helge Deller <deller@gmx.de>
2015-11-30 22:47:46 +03:00
|
|
|
unsigned int max_seg_size = min(dma_get_max_seg_size(dev),
|
|
|
|
(unsigned)DMA_CHUNK_SIZE);
|
|
|
|
unsigned int max_seg_boundary = dma_get_seg_boundary(dev) + 1;
|
|
|
|
if (max_seg_boundary) /* check if the addition above didn't overflow */
|
|
|
|
max_seg_size = min(max_seg_size, max_seg_boundary);
|
2005-04-17 02:20:36 +04:00
|
|
|
|
|
|
|
while (nents > 0) {
|
|
|
|
|
|
|
|
/*
|
|
|
|
** Prepare for first/next DMA stream
|
|
|
|
*/
|
|
|
|
contig_sg = startsg;
|
|
|
|
dma_len = startsg->length;
|
2015-03-20 20:37:59 +03:00
|
|
|
dma_offset = startsg->offset;
|
2005-04-17 02:20:36 +04:00
|
|
|
|
|
|
|
/* PARANOID: clear entries */
|
|
|
|
sg_dma_address(startsg) = 0;
|
|
|
|
sg_dma_len(startsg) = 0;
|
|
|
|
|
|
|
|
/*
|
|
|
|
** This loop terminates one iteration "early" since
|
|
|
|
** it's always looking one "ahead".
|
|
|
|
*/
|
|
|
|
while(--nents > 0) {
|
2015-03-20 20:37:59 +03:00
|
|
|
unsigned long prev_end, sg_start;
|
2005-04-17 02:20:36 +04:00
|
|
|
|
2015-03-20 20:37:59 +03:00
|
|
|
prev_end = (unsigned long)sg_virt(startsg) +
|
|
|
|
startsg->length;
|
2005-04-17 02:20:36 +04:00
|
|
|
|
|
|
|
startsg++;
|
2015-03-20 20:37:59 +03:00
|
|
|
sg_start = (unsigned long)sg_virt(startsg);
|
2005-04-17 02:20:36 +04:00
|
|
|
|
|
|
|
/* PARANOID: clear entries */
|
|
|
|
sg_dma_address(startsg) = 0;
|
|
|
|
sg_dma_len(startsg) = 0;
|
|
|
|
|
|
|
|
/*
|
|
|
|
** First make sure current dma stream won't
|
parisc iommu: fix panic due to trying to allocate too large region
When using the Promise TX2+ SATA controller on PA-RISC, the system often
crashes with kernel panic, for example just writing data with the dd
utility will make it crash.
Kernel panic - not syncing: drivers/parisc/sba_iommu.c: I/O MMU @ 000000000000a000 is out of mapping resources
CPU: 0 PID: 18442 Comm: mkspadfs Not tainted 4.4.0-rc2 #2
Backtrace:
[<000000004021497c>] show_stack+0x14/0x20
[<0000000040410bf0>] dump_stack+0x88/0x100
[<000000004023978c>] panic+0x124/0x360
[<0000000040452c18>] sba_alloc_range+0x698/0x6a0
[<0000000040453150>] sba_map_sg+0x260/0x5b8
[<000000000c18dbb4>] ata_qc_issue+0x264/0x4a8 [libata]
[<000000000c19535c>] ata_scsi_translate+0xe4/0x220 [libata]
[<000000000c19a93c>] ata_scsi_queuecmd+0xbc/0x320 [libata]
[<0000000040499bbc>] scsi_dispatch_cmd+0xfc/0x130
[<000000004049da34>] scsi_request_fn+0x6e4/0x970
[<00000000403e95a8>] __blk_run_queue+0x40/0x60
[<00000000403e9d8c>] blk_run_queue+0x3c/0x68
[<000000004049a534>] scsi_run_queue+0x2a4/0x360
[<000000004049be68>] scsi_end_request+0x1a8/0x238
[<000000004049de84>] scsi_io_completion+0xfc/0x688
[<0000000040493c74>] scsi_finish_command+0x17c/0x1d0
The cause of the crash is not exhaustion of the IOMMU space, there is
plenty of free pages. The function sba_alloc_range is called with size
0x11000, thus the pages_needed variable is 0x11. The function
sba_search_bitmap is called with bits_wanted 0x11 and boundary size is
0x10 (because dma_get_seg_boundary(dev) returns 0xffff).
The function sba_search_bitmap attempts to allocate 17 pages that must not
cross 16-page boundary - it can't satisfy this requirement
(iommu_is_span_boundary always returns true) and fails even if there are
many free entries in the IOMMU space.
How did it happen that we try to allocate 17 pages that don't cross
16-page boundary? The cause is in the function iommu_coalesce_chunks. This
function tries to coalesce adjacent entries in the scatterlist. The
function does several checks if it may coalesce one entry with the next,
one of those checks is this:
if (startsg->length + dma_len > max_seg_size)
break;
When it finishes coalescing adjacent entries, it allocates the mapping:
sg_dma_len(contig_sg) = dma_len;
dma_len = ALIGN(dma_len + dma_offset, IOVP_SIZE);
sg_dma_address(contig_sg) =
PIDE_FLAG
| (iommu_alloc_range(ioc, dev, dma_len) << IOVP_SHIFT)
| dma_offset;
It is possible that (startsg->length + dma_len > max_seg_size) is false
(we are just near the 0x10000 max_seg_size boundary), so the funcion
decides to coalesce this entry with the next entry. When the coalescing
succeeds, the function performs
dma_len = ALIGN(dma_len + dma_offset, IOVP_SIZE);
And now, because of non-zero dma_offset, dma_len is greater than 0x10000.
iommu_alloc_range (a pointer to sba_alloc_range) is called and it attempts
to allocate 17 pages for a device that must not cross 16-page boundary.
To fix the bug, we must make sure that dma_len after addition of
dma_offset and alignment doesn't cross the segment boundary. I.e. change
if (startsg->length + dma_len > max_seg_size)
break;
to
if (ALIGN(dma_len + dma_offset + startsg->length, IOVP_SIZE) > max_seg_size)
break;
This patch makes this change (it precalculates max_seg_boundary at the
beginning of the function iommu_coalesce_chunks). I also added a check
that the mapping length doesn't exceed dma_get_seg_boundary(dev) (it is
not needed for Promise TX2+ SATA, but it may be needed for other devices
that have dma_get_seg_boundary lower than dma_get_max_seg_size).
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Cc: stable@vger.kernel.org
Signed-off-by: Helge Deller <deller@gmx.de>
2015-11-30 22:47:46 +03:00
|
|
|
** exceed max_seg_size if we coalesce the
|
2005-04-17 02:20:36 +04:00
|
|
|
** next entry.
|
|
|
|
*/
|
parisc iommu: fix panic due to trying to allocate too large region
When using the Promise TX2+ SATA controller on PA-RISC, the system often
crashes with kernel panic, for example just writing data with the dd
utility will make it crash.
Kernel panic - not syncing: drivers/parisc/sba_iommu.c: I/O MMU @ 000000000000a000 is out of mapping resources
CPU: 0 PID: 18442 Comm: mkspadfs Not tainted 4.4.0-rc2 #2
Backtrace:
[<000000004021497c>] show_stack+0x14/0x20
[<0000000040410bf0>] dump_stack+0x88/0x100
[<000000004023978c>] panic+0x124/0x360
[<0000000040452c18>] sba_alloc_range+0x698/0x6a0
[<0000000040453150>] sba_map_sg+0x260/0x5b8
[<000000000c18dbb4>] ata_qc_issue+0x264/0x4a8 [libata]
[<000000000c19535c>] ata_scsi_translate+0xe4/0x220 [libata]
[<000000000c19a93c>] ata_scsi_queuecmd+0xbc/0x320 [libata]
[<0000000040499bbc>] scsi_dispatch_cmd+0xfc/0x130
[<000000004049da34>] scsi_request_fn+0x6e4/0x970
[<00000000403e95a8>] __blk_run_queue+0x40/0x60
[<00000000403e9d8c>] blk_run_queue+0x3c/0x68
[<000000004049a534>] scsi_run_queue+0x2a4/0x360
[<000000004049be68>] scsi_end_request+0x1a8/0x238
[<000000004049de84>] scsi_io_completion+0xfc/0x688
[<0000000040493c74>] scsi_finish_command+0x17c/0x1d0
The cause of the crash is not exhaustion of the IOMMU space, there is
plenty of free pages. The function sba_alloc_range is called with size
0x11000, thus the pages_needed variable is 0x11. The function
sba_search_bitmap is called with bits_wanted 0x11 and boundary size is
0x10 (because dma_get_seg_boundary(dev) returns 0xffff).
The function sba_search_bitmap attempts to allocate 17 pages that must not
cross 16-page boundary - it can't satisfy this requirement
(iommu_is_span_boundary always returns true) and fails even if there are
many free entries in the IOMMU space.
How did it happen that we try to allocate 17 pages that don't cross
16-page boundary? The cause is in the function iommu_coalesce_chunks. This
function tries to coalesce adjacent entries in the scatterlist. The
function does several checks if it may coalesce one entry with the next,
one of those checks is this:
if (startsg->length + dma_len > max_seg_size)
break;
When it finishes coalescing adjacent entries, it allocates the mapping:
sg_dma_len(contig_sg) = dma_len;
dma_len = ALIGN(dma_len + dma_offset, IOVP_SIZE);
sg_dma_address(contig_sg) =
PIDE_FLAG
| (iommu_alloc_range(ioc, dev, dma_len) << IOVP_SHIFT)
| dma_offset;
It is possible that (startsg->length + dma_len > max_seg_size) is false
(we are just near the 0x10000 max_seg_size boundary), so the funcion
decides to coalesce this entry with the next entry. When the coalescing
succeeds, the function performs
dma_len = ALIGN(dma_len + dma_offset, IOVP_SIZE);
And now, because of non-zero dma_offset, dma_len is greater than 0x10000.
iommu_alloc_range (a pointer to sba_alloc_range) is called and it attempts
to allocate 17 pages for a device that must not cross 16-page boundary.
To fix the bug, we must make sure that dma_len after addition of
dma_offset and alignment doesn't cross the segment boundary. I.e. change
if (startsg->length + dma_len > max_seg_size)
break;
to
if (ALIGN(dma_len + dma_offset + startsg->length, IOVP_SIZE) > max_seg_size)
break;
This patch makes this change (it precalculates max_seg_boundary at the
beginning of the function iommu_coalesce_chunks). I also added a check
that the mapping length doesn't exceed dma_get_seg_boundary(dev) (it is
not needed for Promise TX2+ SATA, but it may be needed for other devices
that have dma_get_seg_boundary lower than dma_get_max_seg_size).
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Cc: stable@vger.kernel.org
Signed-off-by: Helge Deller <deller@gmx.de>
2015-11-30 22:47:46 +03:00
|
|
|
if (unlikely(ALIGN(dma_len + dma_offset + startsg->length, IOVP_SIZE) >
|
|
|
|
max_seg_size))
|
2008-02-05 09:28:03 +03:00
|
|
|
break;
|
|
|
|
|
2005-04-17 02:20:36 +04:00
|
|
|
/*
|
2015-03-20 20:37:59 +03:00
|
|
|
* Next see if we can append the next chunk (i.e.
|
|
|
|
* it must end on one page and begin on another, or
|
|
|
|
* it must start on the same address as the previous
|
|
|
|
* entry ended.
|
2005-04-17 02:20:36 +04:00
|
|
|
*/
|
2015-03-20 20:37:59 +03:00
|
|
|
if (unlikely((prev_end != sg_start) ||
|
|
|
|
((prev_end | sg_start) & ~PAGE_MASK)))
|
2005-04-17 02:20:36 +04:00
|
|
|
break;
|
|
|
|
|
|
|
|
dma_len += startsg->length;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
** End of DMA Stream
|
|
|
|
** Terminate last VCONTIG block.
|
|
|
|
** Allocate space for DMA stream.
|
|
|
|
*/
|
|
|
|
sg_dma_len(contig_sg) = dma_len;
|
2007-03-06 13:44:13 +03:00
|
|
|
dma_len = ALIGN(dma_len + dma_offset, IOVP_SIZE);
|
2005-04-17 02:20:36 +04:00
|
|
|
sg_dma_address(contig_sg) =
|
|
|
|
PIDE_FLAG
|
2008-03-05 01:29:28 +03:00
|
|
|
| (iommu_alloc_range(ioc, dev, dma_len) << IOVP_SHIFT)
|
2005-04-17 02:20:36 +04:00
|
|
|
| dma_offset;
|
|
|
|
n_mappings++;
|
|
|
|
}
|
|
|
|
|
|
|
|
return n_mappings;
|
|
|
|
}
|
|
|
|
|