License cleanup: add SPDX GPL-2.0 license identifier to files with no license
Many source files in the tree are missing licensing information, which
makes it harder for compliance tools to determine the correct license.
By default all files without license information are under the default
license of the kernel, which is GPL version 2.
Update the files which contain no license information with the 'GPL-2.0'
SPDX license identifier. The SPDX identifier is a legally binding
shorthand, which can be used instead of the full boiler plate text.
This patch is based on work done by Thomas Gleixner and Kate Stewart and
Philippe Ombredanne.
How this work was done:
Patches were generated and checked against linux-4.14-rc6 for a subset of
the use cases:
- file had no licensing information it it.
- file was a */uapi/* one with no licensing information in it,
- file was a */uapi/* one with existing licensing information,
Further patches will be generated in subsequent months to fix up cases
where non-standard license headers were used, and references to license
had to be inferred by heuristics based on keywords.
The analysis to determine which SPDX License Identifier to be applied to
a file was done in a spreadsheet of side by side results from of the
output of two independent scanners (ScanCode & Windriver) producing SPDX
tag:value files created by Philippe Ombredanne. Philippe prepared the
base worksheet, and did an initial spot review of a few 1000 files.
The 4.13 kernel was the starting point of the analysis with 60,537 files
assessed. Kate Stewart did a file by file comparison of the scanner
results in the spreadsheet to determine which SPDX license identifier(s)
to be applied to the file. She confirmed any determination that was not
immediately clear with lawyers working with the Linux Foundation.
Criteria used to select files for SPDX license identifier tagging was:
- Files considered eligible had to be source code files.
- Make and config files were included as candidates if they contained >5
lines of source
- File already had some variant of a license header in it (even if <5
lines).
All documentation files were explicitly excluded.
The following heuristics were used to determine which SPDX license
identifiers to apply.
- when both scanners couldn't find any license traces, file was
considered to have no license information in it, and the top level
COPYING file license applied.
For non */uapi/* files that summary was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 11139
and resulted in the first patch in this series.
If that file was a */uapi/* path one, it was "GPL-2.0 WITH
Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 WITH Linux-syscall-note 930
and resulted in the second patch in this series.
- if a file had some form of licensing information in it, and was one
of the */uapi/* ones, it was denoted with the Linux-syscall-note if
any GPL family license was found in the file or had no licensing in
it (per prior point). Results summary:
SPDX license identifier # files
---------------------------------------------------|------
GPL-2.0 WITH Linux-syscall-note 270
GPL-2.0+ WITH Linux-syscall-note 169
((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21
((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17
LGPL-2.1+ WITH Linux-syscall-note 15
GPL-1.0+ WITH Linux-syscall-note 14
((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5
LGPL-2.0+ WITH Linux-syscall-note 4
LGPL-2.1 WITH Linux-syscall-note 3
((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3
((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1
and that resulted in the third patch in this series.
- when the two scanners agreed on the detected license(s), that became
the concluded license(s).
- when there was disagreement between the two scanners (one detected a
license but the other didn't, or they both detected different
licenses) a manual inspection of the file occurred.
- In most cases a manual inspection of the information in the file
resulted in a clear resolution of the license that should apply (and
which scanner probably needed to revisit its heuristics).
- When it was not immediately clear, the license identifier was
confirmed with lawyers working with the Linux Foundation.
- If there was any question as to the appropriate license identifier,
the file was flagged for further research and to be revisited later
in time.
In total, over 70 hours of logged manual review was done on the
spreadsheet to determine the SPDX license identifiers to apply to the
source files by Kate, Philippe, Thomas and, in some cases, confirmation
by lawyers working with the Linux Foundation.
Kate also obtained a third independent scan of the 4.13 code base from
FOSSology, and compared selected files where the other two scanners
disagreed against that SPDX file, to see if there was new insights. The
Windriver scanner is based on an older version of FOSSology in part, so
they are related.
Thomas did random spot checks in about 500 files from the spreadsheets
for the uapi headers and agreed with SPDX license identifier in the
files he inspected. For the non-uapi files Thomas did random spot checks
in about 15000 files.
In initial set of patches against 4.14-rc6, 3 files were found to have
copy/paste license identifier errors, and have been fixed to reflect the
correct identifier.
Additionally Philippe spent 10 hours this week doing a detailed manual
inspection and review of the 12,461 patched files from the initial patch
version early this week with:
- a full scancode scan run, collecting the matched texts, detected
license ids and scores
- reviewing anything where there was a license detected (about 500+
files) to ensure that the applied SPDX license was correct
- reviewing anything where there was no detection but the patch license
was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied
SPDX license was correct
This produced a worksheet with 20 files needing minor correction. This
worksheet was then exported into 3 different .csv files for the
different types of files to be modified.
These .csv files were then reviewed by Greg. Thomas wrote a script to
parse the csv files and add the proper SPDX tag to the file, in the
format that the file expected. This script was further refined by Greg
based on the output to detect more types of files automatically and to
distinguish between header and source .c files (which need different
comment types.) Finally Greg ran the script using the .csv files to
generate the patches.
Reviewed-by: Kate Stewart <kstewart@linuxfoundation.org>
Reviewed-by: Philippe Ombredanne <pombredanne@nexb.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-11-01 17:07:57 +03:00
|
|
|
/* SPDX-License-Identifier: GPL-2.0 */
|
2016-11-14 20:06:19 +03:00
|
|
|
#ifndef _LINUX_REFCOUNT_H
|
|
|
|
#define _LINUX_REFCOUNT_H
|
|
|
|
|
|
|
|
#include <linux/atomic.h>
|
2018-04-01 01:00:36 +03:00
|
|
|
#include <linux/compiler.h>
|
2019-11-21 14:58:53 +03:00
|
|
|
#include <linux/limits.h>
|
2018-04-01 01:00:36 +03:00
|
|
|
#include <linux/spinlock_types.h>
|
|
|
|
|
|
|
|
struct mutex;
|
2016-11-14 20:06:19 +03:00
|
|
|
|
2017-03-10 18:34:12 +03:00
|
|
|
/**
|
2017-12-05 13:46:35 +03:00
|
|
|
* struct refcount_t - variant of atomic_t specialized for reference counts
|
2017-03-10 18:34:12 +03:00
|
|
|
* @refs: atomic_t counter field
|
|
|
|
*
|
2019-11-21 14:58:53 +03:00
|
|
|
* The counter saturates at REFCOUNT_SATURATED and will not move once
|
2017-03-10 18:34:12 +03:00
|
|
|
* there. This avoids wrapping the counter and causing 'spurious'
|
|
|
|
* use-after-free bugs.
|
|
|
|
*/
|
2016-11-14 20:06:19 +03:00
|
|
|
typedef struct refcount_struct {
|
|
|
|
atomic_t refs;
|
|
|
|
} refcount_t;
|
|
|
|
|
|
|
|
#define REFCOUNT_INIT(n) { .refs = ATOMIC_INIT(n), }
|
2019-11-21 14:58:59 +03:00
|
|
|
#define REFCOUNT_MAX INT_MAX
|
|
|
|
#define REFCOUNT_SATURATED (INT_MIN / 2)
|
2016-11-14 20:06:19 +03:00
|
|
|
|
2019-11-21 14:58:58 +03:00
|
|
|
enum refcount_saturation_type {
|
|
|
|
REFCOUNT_ADD_NOT_ZERO_OVF,
|
|
|
|
REFCOUNT_ADD_OVF,
|
|
|
|
REFCOUNT_ADD_UAF,
|
|
|
|
REFCOUNT_SUB_UAF,
|
|
|
|
REFCOUNT_DEC_LEAK,
|
|
|
|
};
|
|
|
|
|
|
|
|
void refcount_warn_saturate(refcount_t *r, enum refcount_saturation_type t);
|
|
|
|
|
2017-03-10 18:34:12 +03:00
|
|
|
/**
|
|
|
|
* refcount_set - set a refcount's value
|
|
|
|
* @r: the refcount
|
|
|
|
* @n: value to which the refcount will be set
|
|
|
|
*/
|
2019-11-21 14:58:54 +03:00
|
|
|
static inline void refcount_set(refcount_t *r, int n)
|
2016-11-14 20:06:19 +03:00
|
|
|
{
|
|
|
|
atomic_set(&r->refs, n);
|
|
|
|
}
|
|
|
|
|
2017-03-10 18:34:12 +03:00
|
|
|
/**
|
|
|
|
* refcount_read - get a refcount's value
|
|
|
|
* @r: the refcount
|
|
|
|
*
|
|
|
|
* Return: the refcount's value
|
|
|
|
*/
|
2016-11-14 20:06:19 +03:00
|
|
|
static inline unsigned int refcount_read(const refcount_t *r)
|
|
|
|
{
|
|
|
|
return atomic_read(&r->refs);
|
|
|
|
}
|
|
|
|
|
2017-06-21 23:00:26 +03:00
|
|
|
#ifdef CONFIG_REFCOUNT_FULL
|
2019-11-21 14:58:56 +03:00
|
|
|
#include <linux/bug.h>
|
2016-11-14 20:06:19 +03:00
|
|
|
|
2019-11-21 14:58:56 +03:00
|
|
|
/*
|
|
|
|
* Variant of atomic_t specialized for reference counts.
|
|
|
|
*
|
|
|
|
* The interface matches the atomic_t interface (to aid in porting) but only
|
|
|
|
* provides the few functions one should use for reference counting.
|
|
|
|
*
|
2019-11-21 14:58:57 +03:00
|
|
|
* Saturation semantics
|
|
|
|
* ====================
|
|
|
|
*
|
|
|
|
* refcount_t differs from atomic_t in that the counter saturates at
|
|
|
|
* REFCOUNT_SATURATED and will not move once there. This avoids wrapping the
|
|
|
|
* counter and causing 'spurious' use-after-free issues. In order to avoid the
|
|
|
|
* cost associated with introducing cmpxchg() loops into all of the saturating
|
|
|
|
* operations, we temporarily allow the counter to take on an unchecked value
|
|
|
|
* and then explicitly set it to REFCOUNT_SATURATED on detecting that underflow
|
|
|
|
* or overflow has occurred. Although this is racy when multiple threads
|
|
|
|
* access the refcount concurrently, by placing REFCOUNT_SATURATED roughly
|
|
|
|
* equidistant from 0 and INT_MAX we minimise the scope for error:
|
|
|
|
*
|
|
|
|
* INT_MAX REFCOUNT_SATURATED UINT_MAX
|
|
|
|
* 0 (0x7fff_ffff) (0xc000_0000) (0xffff_ffff)
|
|
|
|
* +--------------------------------+----------------+----------------+
|
|
|
|
* <---------- bad value! ---------->
|
|
|
|
*
|
|
|
|
* (in a signed view of the world, the "bad value" range corresponds to
|
|
|
|
* a negative counter value).
|
|
|
|
*
|
|
|
|
* As an example, consider a refcount_inc() operation that causes the counter
|
|
|
|
* to overflow:
|
|
|
|
*
|
|
|
|
* int old = atomic_fetch_add_relaxed(r);
|
|
|
|
* // old is INT_MAX, refcount now INT_MIN (0x8000_0000)
|
|
|
|
* if (old < 0)
|
|
|
|
* atomic_set(r, REFCOUNT_SATURATED);
|
|
|
|
*
|
|
|
|
* If another thread also performs a refcount_inc() operation between the two
|
|
|
|
* atomic operations, then the count will continue to edge closer to 0. If it
|
|
|
|
* reaches a value of 1 before /any/ of the threads reset it to the saturated
|
|
|
|
* value, then a concurrent refcount_dec_and_test() may erroneously free the
|
|
|
|
* underlying object. Given the precise timing details involved with the
|
|
|
|
* round-robin scheduling of each thread manipulating the refcount and the need
|
|
|
|
* to hit the race multiple times in succession, there doesn't appear to be a
|
|
|
|
* practical avenue of attack even if using refcount_add() operations with
|
|
|
|
* larger increments.
|
|
|
|
*
|
|
|
|
* Memory ordering
|
|
|
|
* ===============
|
2019-11-21 14:58:56 +03:00
|
|
|
*
|
|
|
|
* Memory ordering rules are slightly relaxed wrt regular atomic_t functions
|
|
|
|
* and provide only what is strictly required for refcounts.
|
|
|
|
*
|
|
|
|
* The increments are fully relaxed; these will not provide ordering. The
|
|
|
|
* rationale is that whatever is used to obtain the object we're increasing the
|
|
|
|
* reference count on will provide the ordering. For locked data structures,
|
|
|
|
* its the lock acquire, for RCU/lockless data structures its the dependent
|
|
|
|
* load.
|
|
|
|
*
|
|
|
|
* Do note that inc_not_zero() provides a control dependency which will order
|
|
|
|
* future stores against the inc, this ensures we'll never modify the object
|
|
|
|
* if we did not in fact acquire a reference.
|
|
|
|
*
|
|
|
|
* The decrements will provide release order, such that all the prior loads and
|
|
|
|
* stores will be issued before, it also provides a control dependency, which
|
|
|
|
* will order us against the subsequent free().
|
|
|
|
*
|
|
|
|
* The control dependency is against the load of the cmpxchg (ll/sc) that
|
|
|
|
* succeeded. This means the stores aren't fully ordered, but this is fine
|
|
|
|
* because the 1->0 transition indicates no concurrency.
|
|
|
|
*
|
|
|
|
* Note that the allocator is responsible for ordering things between free()
|
|
|
|
* and alloc().
|
|
|
|
*
|
|
|
|
* The decrements dec_and_test() and sub_and_test() also provide acquire
|
|
|
|
* ordering on success.
|
|
|
|
*
|
|
|
|
*/
|
|
|
|
|
|
|
|
/**
|
|
|
|
* refcount_add_not_zero - add a value to a refcount unless it is 0
|
|
|
|
* @i: the value to add to the refcount
|
|
|
|
* @r: the refcount
|
|
|
|
*
|
|
|
|
* Will saturate at REFCOUNT_SATURATED and WARN.
|
|
|
|
*
|
|
|
|
* Provides no memory ordering, it is assumed the caller has guaranteed the
|
|
|
|
* object memory to be stable (RCU, etc.). It does provide a control dependency
|
|
|
|
* and thereby orders future stores. See the comment on top.
|
|
|
|
*
|
|
|
|
* Use of this function is not recommended for the normal reference counting
|
|
|
|
* use case in which references are taken and released one at a time. In these
|
|
|
|
* cases, refcount_inc(), or one of its variants, should instead be used to
|
|
|
|
* increment a reference count.
|
|
|
|
*
|
|
|
|
* Return: false if the passed refcount is 0, true otherwise
|
|
|
|
*/
|
|
|
|
static inline __must_check bool refcount_add_not_zero(int i, refcount_t *r)
|
|
|
|
{
|
2019-11-21 14:58:57 +03:00
|
|
|
int old = refcount_read(r);
|
2019-11-21 14:58:56 +03:00
|
|
|
|
|
|
|
do {
|
2019-11-21 14:58:57 +03:00
|
|
|
if (!old)
|
|
|
|
break;
|
|
|
|
} while (!atomic_try_cmpxchg_relaxed(&r->refs, &old, old + i));
|
2019-11-21 14:58:56 +03:00
|
|
|
|
2019-11-21 14:58:58 +03:00
|
|
|
if (unlikely(old < 0 || old + i < 0))
|
|
|
|
refcount_warn_saturate(r, REFCOUNT_ADD_NOT_ZERO_OVF);
|
2019-11-21 14:58:56 +03:00
|
|
|
|
2019-11-21 14:58:57 +03:00
|
|
|
return old;
|
2019-11-21 14:58:56 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* refcount_add - add a value to a refcount
|
|
|
|
* @i: the value to add to the refcount
|
|
|
|
* @r: the refcount
|
|
|
|
*
|
|
|
|
* Similar to atomic_add(), but will saturate at REFCOUNT_SATURATED and WARN.
|
|
|
|
*
|
|
|
|
* Provides no memory ordering, it is assumed the caller has guaranteed the
|
|
|
|
* object memory to be stable (RCU, etc.). It does provide a control dependency
|
|
|
|
* and thereby orders future stores. See the comment on top.
|
|
|
|
*
|
|
|
|
* Use of this function is not recommended for the normal reference counting
|
|
|
|
* use case in which references are taken and released one at a time. In these
|
|
|
|
* cases, refcount_inc(), or one of its variants, should instead be used to
|
|
|
|
* increment a reference count.
|
|
|
|
*/
|
|
|
|
static inline void refcount_add(int i, refcount_t *r)
|
|
|
|
{
|
2019-11-21 14:58:57 +03:00
|
|
|
int old = atomic_fetch_add_relaxed(i, &r->refs);
|
|
|
|
|
2019-11-21 14:58:58 +03:00
|
|
|
if (unlikely(!old))
|
|
|
|
refcount_warn_saturate(r, REFCOUNT_ADD_UAF);
|
|
|
|
else if (unlikely(old < 0 || old + i < 0))
|
|
|
|
refcount_warn_saturate(r, REFCOUNT_ADD_OVF);
|
2019-11-21 14:58:56 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* refcount_inc_not_zero - increment a refcount unless it is 0
|
|
|
|
* @r: the refcount to increment
|
|
|
|
*
|
|
|
|
* Similar to atomic_inc_not_zero(), but will saturate at REFCOUNT_SATURATED
|
|
|
|
* and WARN.
|
|
|
|
*
|
|
|
|
* Provides no memory ordering, it is assumed the caller has guaranteed the
|
|
|
|
* object memory to be stable (RCU, etc.). It does provide a control dependency
|
|
|
|
* and thereby orders future stores. See the comment on top.
|
|
|
|
*
|
|
|
|
* Return: true if the increment was successful, false otherwise
|
|
|
|
*/
|
|
|
|
static inline __must_check bool refcount_inc_not_zero(refcount_t *r)
|
|
|
|
{
|
2019-11-21 14:58:57 +03:00
|
|
|
return refcount_add_not_zero(1, r);
|
2019-11-21 14:58:56 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* refcount_inc - increment a refcount
|
|
|
|
* @r: the refcount to increment
|
|
|
|
*
|
|
|
|
* Similar to atomic_inc(), but will saturate at REFCOUNT_SATURATED and WARN.
|
|
|
|
*
|
|
|
|
* Provides no memory ordering, it is assumed the caller already has a
|
|
|
|
* reference on the object.
|
|
|
|
*
|
|
|
|
* Will WARN if the refcount is 0, as this represents a possible use-after-free
|
|
|
|
* condition.
|
|
|
|
*/
|
|
|
|
static inline void refcount_inc(refcount_t *r)
|
|
|
|
{
|
2019-11-21 14:58:57 +03:00
|
|
|
refcount_add(1, r);
|
2019-11-21 14:58:56 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* refcount_sub_and_test - subtract from a refcount and test if it is 0
|
|
|
|
* @i: amount to subtract from the refcount
|
|
|
|
* @r: the refcount
|
|
|
|
*
|
|
|
|
* Similar to atomic_dec_and_test(), but it will WARN, return false and
|
|
|
|
* ultimately leak on underflow and will fail to decrement when saturated
|
|
|
|
* at REFCOUNT_SATURATED.
|
|
|
|
*
|
|
|
|
* Provides release memory ordering, such that prior loads and stores are done
|
|
|
|
* before, and provides an acquire ordering on success such that free()
|
|
|
|
* must come after.
|
|
|
|
*
|
|
|
|
* Use of this function is not recommended for the normal reference counting
|
|
|
|
* use case in which references are taken and released one at a time. In these
|
|
|
|
* cases, refcount_dec(), or one of its variants, should instead be used to
|
|
|
|
* decrement a reference count.
|
|
|
|
*
|
|
|
|
* Return: true if the resulting refcount is 0, false otherwise
|
|
|
|
*/
|
|
|
|
static inline __must_check bool refcount_sub_and_test(int i, refcount_t *r)
|
|
|
|
{
|
2019-11-21 14:58:57 +03:00
|
|
|
int old = atomic_fetch_sub_release(i, &r->refs);
|
2019-11-21 14:58:56 +03:00
|
|
|
|
2019-11-21 14:58:57 +03:00
|
|
|
if (old == i) {
|
2019-11-21 14:58:56 +03:00
|
|
|
smp_acquire__after_ctrl_dep();
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2019-11-21 14:58:58 +03:00
|
|
|
if (unlikely(old < 0 || old - i < 0))
|
|
|
|
refcount_warn_saturate(r, REFCOUNT_SUB_UAF);
|
2019-11-21 14:58:57 +03:00
|
|
|
|
|
|
|
return false;
|
2019-11-21 14:58:56 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* refcount_dec_and_test - decrement a refcount and test if it is 0
|
|
|
|
* @r: the refcount
|
|
|
|
*
|
|
|
|
* Similar to atomic_dec_and_test(), it will WARN on underflow and fail to
|
|
|
|
* decrement when saturated at REFCOUNT_SATURATED.
|
|
|
|
*
|
|
|
|
* Provides release memory ordering, such that prior loads and stores are done
|
|
|
|
* before, and provides an acquire ordering on success such that free()
|
|
|
|
* must come after.
|
|
|
|
*
|
|
|
|
* Return: true if the resulting refcount is 0, false otherwise
|
|
|
|
*/
|
|
|
|
static inline __must_check bool refcount_dec_and_test(refcount_t *r)
|
|
|
|
{
|
|
|
|
return refcount_sub_and_test(1, r);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* refcount_dec - decrement a refcount
|
|
|
|
* @r: the refcount
|
|
|
|
*
|
|
|
|
* Similar to atomic_dec(), it will WARN on underflow and fail to decrement
|
|
|
|
* when saturated at REFCOUNT_SATURATED.
|
|
|
|
*
|
|
|
|
* Provides release memory ordering, such that prior loads and stores are done
|
|
|
|
* before.
|
|
|
|
*/
|
|
|
|
static inline void refcount_dec(refcount_t *r)
|
|
|
|
{
|
2019-11-21 14:58:58 +03:00
|
|
|
if (unlikely(atomic_fetch_sub_release(1, &r->refs) <= 1))
|
|
|
|
refcount_warn_saturate(r, REFCOUNT_DEC_LEAK);
|
2019-11-21 14:58:57 +03:00
|
|
|
}
|
2019-11-21 14:58:56 +03:00
|
|
|
#else /* CONFIG_REFCOUNT_FULL */
|
locking/refcounts, x86/asm: Implement fast refcount overflow protection
This implements refcount_t overflow protection on x86 without a noticeable
performance impact, though without the fuller checking of REFCOUNT_FULL.
This is done by duplicating the existing atomic_t refcount implementation
but with normally a single instruction added to detect if the refcount
has gone negative (e.g. wrapped past INT_MAX or below zero). When detected,
the handler saturates the refcount_t to INT_MIN / 2. With this overflow
protection, the erroneous reference release that would follow a wrap back
to zero is blocked from happening, avoiding the class of refcount-overflow
use-after-free vulnerabilities entirely.
Only the overflow case of refcounting can be perfectly protected, since
it can be detected and stopped before the reference is freed and left to
be abused by an attacker. There isn't a way to block early decrements,
and while REFCOUNT_FULL stops increment-from-zero cases (which would
be the state _after_ an early decrement and stops potential double-free
conditions), this fast implementation does not, since it would require
the more expensive cmpxchg loops. Since the overflow case is much more
common (e.g. missing a "put" during an error path), this protection
provides real-world protection. For example, the two public refcount
overflow use-after-free exploits published in 2016 would have been
rendered unexploitable:
http://perception-point.io/2016/01/14/analysis-and-exploitation-of-a-linux-kernel-vulnerability-cve-2016-0728/
http://cyseclabs.com/page?n=02012016
This implementation does, however, notice an unchecked decrement to zero
(i.e. caller used refcount_dec() instead of refcount_dec_and_test() and it
resulted in a zero). Decrements under zero are noticed (since they will
have resulted in a negative value), though this only indicates that a
use-after-free may have already happened. Such notifications are likely
avoidable by an attacker that has already exploited a use-after-free
vulnerability, but it's better to have them reported than allow such
conditions to remain universally silent.
On first overflow detection, the refcount value is reset to INT_MIN / 2
(which serves as a saturation value) and a report and stack trace are
produced. When operations detect only negative value results (such as
changing an already saturated value), saturation still happens but no
notification is performed (since the value was already saturated).
On the matter of races, since the entire range beyond INT_MAX but before
0 is negative, every operation at INT_MIN / 2 will trap, leaving no
overflow-only race condition.
As for performance, this implementation adds a single "js" instruction
to the regular execution flow of a copy of the standard atomic_t refcount
operations. (The non-"and_test" refcount_dec() function, which is uncommon
in regular refcount design patterns, has an additional "jz" instruction
to detect reaching exactly zero.) Since this is a forward jump, it is by
default the non-predicted path, which will be reinforced by dynamic branch
prediction. The result is this protection having virtually no measurable
change in performance over standard atomic_t operations. The error path,
located in .text.unlikely, saves the refcount location and then uses UD0
to fire a refcount exception handler, which resets the refcount, handles
reporting, and returns to regular execution. This keeps the changes to
.text size minimal, avoiding return jumps and open-coded calls to the
error reporting routine.
Example assembly comparison:
refcount_inc() before:
.text:
ffffffff81546149: f0 ff 45 f4 lock incl -0xc(%rbp)
refcount_inc() after:
.text:
ffffffff81546149: f0 ff 45 f4 lock incl -0xc(%rbp)
ffffffff8154614d: 0f 88 80 d5 17 00 js ffffffff816c36d3
...
.text.unlikely:
ffffffff816c36d3: 48 8d 4d f4 lea -0xc(%rbp),%rcx
ffffffff816c36d7: 0f ff (bad)
These are the cycle counts comparing a loop of refcount_inc() from 1
to INT_MAX and back down to 0 (via refcount_dec_and_test()), between
unprotected refcount_t (atomic_t), fully protected REFCOUNT_FULL
(refcount_t-full), and this overflow-protected refcount (refcount_t-fast):
2147483646 refcount_inc()s and 2147483647 refcount_dec_and_test()s:
cycles protections
atomic_t 82249267387 none
refcount_t-fast 82211446892 overflow, untested dec-to-zero
refcount_t-full 144814735193 overflow, untested dec-to-zero, inc-from-zero
This code is a modified version of the x86 PAX_REFCOUNT atomic_t
overflow defense from the last public patch of PaX/grsecurity, based
on my understanding of the code. Changes or omissions from the original
code are mine and don't reflect the original grsecurity/PaX code. Thanks
to PaX Team for various suggestions for improvement for repurposing this
code to be a refcount-only protection.
Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: David S. Miller <davem@davemloft.net>
Cc: Davidlohr Bueso <dave@stgolabs.net>
Cc: Elena Reshetova <elena.reshetova@intel.com>
Cc: Eric Biggers <ebiggers3@gmail.com>
Cc: Eric W. Biederman <ebiederm@xmission.com>
Cc: Greg KH <gregkh@linuxfoundation.org>
Cc: Hans Liljestrand <ishkamiel@gmail.com>
Cc: James Bottomley <James.Bottomley@hansenpartnership.com>
Cc: Jann Horn <jannh@google.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Manfred Spraul <manfred@colorfullife.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Rik van Riel <riel@redhat.com>
Cc: Serge E. Hallyn <serge@hallyn.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: arozansk@redhat.com
Cc: axboe@kernel.dk
Cc: kernel-hardening@lists.openwall.com
Cc: linux-arch <linux-arch@vger.kernel.org>
Link: http://lkml.kernel.org/r/20170815161924.GA133115@beast
Signed-off-by: Ingo Molnar <mingo@kernel.org>
2017-08-15 19:19:24 +03:00
|
|
|
# ifdef CONFIG_ARCH_HAS_REFCOUNT
|
|
|
|
# include <asm/refcount.h>
|
|
|
|
# else
|
2019-11-21 14:58:54 +03:00
|
|
|
static inline __must_check bool refcount_add_not_zero(int i, refcount_t *r)
|
2017-06-21 23:00:26 +03:00
|
|
|
{
|
|
|
|
return atomic_add_unless(&r->refs, i, 0);
|
|
|
|
}
|
|
|
|
|
2019-11-21 14:58:54 +03:00
|
|
|
static inline void refcount_add(int i, refcount_t *r)
|
2017-06-21 23:00:26 +03:00
|
|
|
{
|
|
|
|
atomic_add(i, &r->refs);
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline __must_check bool refcount_inc_not_zero(refcount_t *r)
|
|
|
|
{
|
|
|
|
return atomic_add_unless(&r->refs, 1, 0);
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline void refcount_inc(refcount_t *r)
|
|
|
|
{
|
|
|
|
atomic_inc(&r->refs);
|
|
|
|
}
|
|
|
|
|
2019-11-21 14:58:54 +03:00
|
|
|
static inline __must_check bool refcount_sub_and_test(int i, refcount_t *r)
|
2017-06-21 23:00:26 +03:00
|
|
|
{
|
|
|
|
return atomic_sub_and_test(i, &r->refs);
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline __must_check bool refcount_dec_and_test(refcount_t *r)
|
|
|
|
{
|
|
|
|
return atomic_dec_and_test(&r->refs);
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline void refcount_dec(refcount_t *r)
|
|
|
|
{
|
|
|
|
atomic_dec(&r->refs);
|
|
|
|
}
|
locking/refcounts, x86/asm: Implement fast refcount overflow protection
This implements refcount_t overflow protection on x86 without a noticeable
performance impact, though without the fuller checking of REFCOUNT_FULL.
This is done by duplicating the existing atomic_t refcount implementation
but with normally a single instruction added to detect if the refcount
has gone negative (e.g. wrapped past INT_MAX or below zero). When detected,
the handler saturates the refcount_t to INT_MIN / 2. With this overflow
protection, the erroneous reference release that would follow a wrap back
to zero is blocked from happening, avoiding the class of refcount-overflow
use-after-free vulnerabilities entirely.
Only the overflow case of refcounting can be perfectly protected, since
it can be detected and stopped before the reference is freed and left to
be abused by an attacker. There isn't a way to block early decrements,
and while REFCOUNT_FULL stops increment-from-zero cases (which would
be the state _after_ an early decrement and stops potential double-free
conditions), this fast implementation does not, since it would require
the more expensive cmpxchg loops. Since the overflow case is much more
common (e.g. missing a "put" during an error path), this protection
provides real-world protection. For example, the two public refcount
overflow use-after-free exploits published in 2016 would have been
rendered unexploitable:
http://perception-point.io/2016/01/14/analysis-and-exploitation-of-a-linux-kernel-vulnerability-cve-2016-0728/
http://cyseclabs.com/page?n=02012016
This implementation does, however, notice an unchecked decrement to zero
(i.e. caller used refcount_dec() instead of refcount_dec_and_test() and it
resulted in a zero). Decrements under zero are noticed (since they will
have resulted in a negative value), though this only indicates that a
use-after-free may have already happened. Such notifications are likely
avoidable by an attacker that has already exploited a use-after-free
vulnerability, but it's better to have them reported than allow such
conditions to remain universally silent.
On first overflow detection, the refcount value is reset to INT_MIN / 2
(which serves as a saturation value) and a report and stack trace are
produced. When operations detect only negative value results (such as
changing an already saturated value), saturation still happens but no
notification is performed (since the value was already saturated).
On the matter of races, since the entire range beyond INT_MAX but before
0 is negative, every operation at INT_MIN / 2 will trap, leaving no
overflow-only race condition.
As for performance, this implementation adds a single "js" instruction
to the regular execution flow of a copy of the standard atomic_t refcount
operations. (The non-"and_test" refcount_dec() function, which is uncommon
in regular refcount design patterns, has an additional "jz" instruction
to detect reaching exactly zero.) Since this is a forward jump, it is by
default the non-predicted path, which will be reinforced by dynamic branch
prediction. The result is this protection having virtually no measurable
change in performance over standard atomic_t operations. The error path,
located in .text.unlikely, saves the refcount location and then uses UD0
to fire a refcount exception handler, which resets the refcount, handles
reporting, and returns to regular execution. This keeps the changes to
.text size minimal, avoiding return jumps and open-coded calls to the
error reporting routine.
Example assembly comparison:
refcount_inc() before:
.text:
ffffffff81546149: f0 ff 45 f4 lock incl -0xc(%rbp)
refcount_inc() after:
.text:
ffffffff81546149: f0 ff 45 f4 lock incl -0xc(%rbp)
ffffffff8154614d: 0f 88 80 d5 17 00 js ffffffff816c36d3
...
.text.unlikely:
ffffffff816c36d3: 48 8d 4d f4 lea -0xc(%rbp),%rcx
ffffffff816c36d7: 0f ff (bad)
These are the cycle counts comparing a loop of refcount_inc() from 1
to INT_MAX and back down to 0 (via refcount_dec_and_test()), between
unprotected refcount_t (atomic_t), fully protected REFCOUNT_FULL
(refcount_t-full), and this overflow-protected refcount (refcount_t-fast):
2147483646 refcount_inc()s and 2147483647 refcount_dec_and_test()s:
cycles protections
atomic_t 82249267387 none
refcount_t-fast 82211446892 overflow, untested dec-to-zero
refcount_t-full 144814735193 overflow, untested dec-to-zero, inc-from-zero
This code is a modified version of the x86 PAX_REFCOUNT atomic_t
overflow defense from the last public patch of PaX/grsecurity, based
on my understanding of the code. Changes or omissions from the original
code are mine and don't reflect the original grsecurity/PaX code. Thanks
to PaX Team for various suggestions for improvement for repurposing this
code to be a refcount-only protection.
Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: David S. Miller <davem@davemloft.net>
Cc: Davidlohr Bueso <dave@stgolabs.net>
Cc: Elena Reshetova <elena.reshetova@intel.com>
Cc: Eric Biggers <ebiggers3@gmail.com>
Cc: Eric W. Biederman <ebiederm@xmission.com>
Cc: Greg KH <gregkh@linuxfoundation.org>
Cc: Hans Liljestrand <ishkamiel@gmail.com>
Cc: James Bottomley <James.Bottomley@hansenpartnership.com>
Cc: Jann Horn <jannh@google.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Manfred Spraul <manfred@colorfullife.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Rik van Riel <riel@redhat.com>
Cc: Serge E. Hallyn <serge@hallyn.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: arozansk@redhat.com
Cc: axboe@kernel.dk
Cc: kernel-hardening@lists.openwall.com
Cc: linux-arch <linux-arch@vger.kernel.org>
Link: http://lkml.kernel.org/r/20170815161924.GA133115@beast
Signed-off-by: Ingo Molnar <mingo@kernel.org>
2017-08-15 19:19:24 +03:00
|
|
|
# endif /* !CONFIG_ARCH_HAS_REFCOUNT */
|
2019-11-21 14:58:56 +03:00
|
|
|
#endif /* !CONFIG_REFCOUNT_FULL */
|
2016-11-14 20:06:19 +03:00
|
|
|
|
2017-02-10 18:27:52 +03:00
|
|
|
extern __must_check bool refcount_dec_if_one(refcount_t *r);
|
|
|
|
extern __must_check bool refcount_dec_not_one(refcount_t *r);
|
|
|
|
extern __must_check bool refcount_dec_and_mutex_lock(refcount_t *r, struct mutex *lock);
|
|
|
|
extern __must_check bool refcount_dec_and_lock(refcount_t *r, spinlock_t *lock);
|
2018-06-12 19:16:21 +03:00
|
|
|
extern __must_check bool refcount_dec_and_lock_irqsave(refcount_t *r,
|
|
|
|
spinlock_t *lock,
|
|
|
|
unsigned long *flags);
|
2016-11-14 20:06:19 +03:00
|
|
|
#endif /* _LINUX_REFCOUNT_H */
|