2019-05-19 15:08:55 +03:00
|
|
|
// SPDX-License-Identifier: GPL-2.0-only
|
2020-09-04 18:30:27 +03:00
|
|
|
#include <linux/objtool.h>
|
2017-07-25 02:36:57 +03:00
|
|
|
#include <linux/module.h>
|
|
|
|
#include <linux/sort.h>
|
|
|
|
#include <asm/ptrace.h>
|
|
|
|
#include <asm/stacktrace.h>
|
|
|
|
#include <asm/unwind.h>
|
|
|
|
#include <asm/orc_types.h>
|
|
|
|
#include <asm/orc_lookup.h>
|
|
|
|
|
|
|
|
#define orc_warn(fmt, ...) \
|
2020-04-25 13:03:06 +03:00
|
|
|
printk_deferred_once(KERN_WARNING "WARNING: " fmt, ##__VA_ARGS__)
|
|
|
|
|
|
|
|
#define orc_warn_current(args...) \
|
|
|
|
({ \
|
|
|
|
if (state->task == current) \
|
|
|
|
orc_warn(args); \
|
|
|
|
})
|
2017-07-25 02:36:57 +03:00
|
|
|
|
|
|
|
extern int __start_orc_unwind_ip[];
|
|
|
|
extern int __stop_orc_unwind_ip[];
|
|
|
|
extern struct orc_entry __start_orc_unwind[];
|
|
|
|
extern struct orc_entry __stop_orc_unwind[];
|
|
|
|
|
2020-04-25 13:03:05 +03:00
|
|
|
static bool orc_init __ro_after_init;
|
|
|
|
static unsigned int lookup_num_blocks __ro_after_init;
|
2017-07-25 02:36:57 +03:00
|
|
|
|
|
|
|
static inline unsigned long orc_ip(const int *ip)
|
|
|
|
{
|
|
|
|
return (unsigned long)ip + *ip;
|
|
|
|
}
|
|
|
|
|
|
|
|
static struct orc_entry *__orc_find(int *ip_table, struct orc_entry *u_table,
|
|
|
|
unsigned int num_entries, unsigned long ip)
|
|
|
|
{
|
|
|
|
int *first = ip_table;
|
|
|
|
int *last = ip_table + num_entries - 1;
|
|
|
|
int *mid = first, *found = first;
|
|
|
|
|
|
|
|
if (!num_entries)
|
|
|
|
return NULL;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Do a binary range search to find the rightmost duplicate of a given
|
|
|
|
* starting address. Some entries are section terminators which are
|
|
|
|
* "weak" entries for ensuring there are no gaps. They should be
|
|
|
|
* ignored when they conflict with a real entry.
|
|
|
|
*/
|
|
|
|
while (first <= last) {
|
|
|
|
mid = first + ((last - first) / 2);
|
|
|
|
|
|
|
|
if (orc_ip(mid) <= ip) {
|
|
|
|
found = mid;
|
|
|
|
first = mid + 1;
|
|
|
|
} else
|
|
|
|
last = mid - 1;
|
|
|
|
}
|
|
|
|
|
|
|
|
return u_table + (found - ip_table);
|
|
|
|
}
|
|
|
|
|
|
|
|
#ifdef CONFIG_MODULES
|
|
|
|
static struct orc_entry *orc_module_find(unsigned long ip)
|
|
|
|
{
|
|
|
|
struct module *mod;
|
|
|
|
|
|
|
|
mod = __module_address(ip);
|
|
|
|
if (!mod || !mod->arch.orc_unwind || !mod->arch.orc_unwind_ip)
|
|
|
|
return NULL;
|
|
|
|
return __orc_find(mod->arch.orc_unwind_ip, mod->arch.orc_unwind,
|
|
|
|
mod->arch.num_orcs, ip);
|
|
|
|
}
|
|
|
|
#else
|
|
|
|
static struct orc_entry *orc_module_find(unsigned long ip)
|
|
|
|
{
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
|
2018-01-23 06:32:51 +03:00
|
|
|
#ifdef CONFIG_DYNAMIC_FTRACE
|
|
|
|
static struct orc_entry *orc_find(unsigned long ip);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Ftrace dynamic trampolines do not have orc entries of their own.
|
|
|
|
* But they are copies of the ftrace entries that are static and
|
|
|
|
* defined in ftrace_*.S, which do have orc entries.
|
|
|
|
*
|
2019-06-27 03:33:55 +03:00
|
|
|
* If the unwinder comes across a ftrace trampoline, then find the
|
2018-01-23 06:32:51 +03:00
|
|
|
* ftrace function that was used to create it, and use that ftrace
|
2019-06-27 03:33:55 +03:00
|
|
|
* function's orc entry, as the placement of the return code in
|
2018-01-23 06:32:51 +03:00
|
|
|
* the stack will be identical.
|
|
|
|
*/
|
|
|
|
static struct orc_entry *orc_ftrace_find(unsigned long ip)
|
|
|
|
{
|
|
|
|
struct ftrace_ops *ops;
|
|
|
|
unsigned long caller;
|
|
|
|
|
|
|
|
ops = ftrace_ops_trampoline(ip);
|
|
|
|
if (!ops)
|
|
|
|
return NULL;
|
|
|
|
|
|
|
|
if (ops->flags & FTRACE_OPS_FL_SAVE_REGS)
|
|
|
|
caller = (unsigned long)ftrace_regs_call;
|
|
|
|
else
|
|
|
|
caller = (unsigned long)ftrace_call;
|
|
|
|
|
|
|
|
/* Prevent unlikely recursion */
|
|
|
|
if (ip == caller)
|
|
|
|
return NULL;
|
|
|
|
|
|
|
|
return orc_find(caller);
|
|
|
|
}
|
|
|
|
#else
|
|
|
|
static struct orc_entry *orc_ftrace_find(unsigned long ip)
|
|
|
|
{
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
|
2019-03-01 06:12:01 +03:00
|
|
|
/*
|
|
|
|
* If we crash with IP==0, the last successfully executed instruction
|
|
|
|
* was probably an indirect function call with a NULL function pointer,
|
|
|
|
* and we don't have unwind information for NULL.
|
|
|
|
* This hardcoded ORC entry for IP==0 allows us to unwind from a NULL function
|
|
|
|
* pointer into its parent and then continue normally from there.
|
|
|
|
*/
|
|
|
|
static struct orc_entry null_orc_entry = {
|
|
|
|
.sp_offset = sizeof(long),
|
|
|
|
.sp_reg = ORC_REG_SP,
|
|
|
|
.bp_reg = ORC_REG_UNDEFINED,
|
2020-09-04 18:30:27 +03:00
|
|
|
.type = UNWIND_HINT_TYPE_CALL
|
2019-03-01 06:12:01 +03:00
|
|
|
};
|
|
|
|
|
2019-06-27 03:33:55 +03:00
|
|
|
/* Fake frame pointer entry -- used as a fallback for generated code */
|
|
|
|
static struct orc_entry orc_fp_entry = {
|
2020-09-04 18:30:27 +03:00
|
|
|
.type = UNWIND_HINT_TYPE_CALL,
|
2019-06-27 03:33:55 +03:00
|
|
|
.sp_reg = ORC_REG_BP,
|
|
|
|
.sp_offset = 16,
|
|
|
|
.bp_reg = ORC_REG_PREV_SP,
|
|
|
|
.bp_offset = -16,
|
|
|
|
.end = 0,
|
|
|
|
};
|
|
|
|
|
2017-07-25 02:36:57 +03:00
|
|
|
static struct orc_entry *orc_find(unsigned long ip)
|
|
|
|
{
|
2018-01-23 06:32:51 +03:00
|
|
|
static struct orc_entry *orc;
|
|
|
|
|
2019-03-01 06:12:01 +03:00
|
|
|
if (ip == 0)
|
|
|
|
return &null_orc_entry;
|
|
|
|
|
2017-07-25 02:36:57 +03:00
|
|
|
/* For non-init vmlinux addresses, use the fast lookup table: */
|
|
|
|
if (ip >= LOOKUP_START_IP && ip < LOOKUP_STOP_IP) {
|
|
|
|
unsigned int idx, start, stop;
|
|
|
|
|
|
|
|
idx = (ip - LOOKUP_START_IP) / LOOKUP_BLOCK_SIZE;
|
|
|
|
|
|
|
|
if (unlikely((idx >= lookup_num_blocks-1))) {
|
2017-10-20 19:21:34 +03:00
|
|
|
orc_warn("WARNING: bad lookup idx: idx=%u num=%u ip=%pB\n",
|
|
|
|
idx, lookup_num_blocks, (void *)ip);
|
2017-07-25 02:36:57 +03:00
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
start = orc_lookup[idx];
|
|
|
|
stop = orc_lookup[idx + 1] + 1;
|
|
|
|
|
|
|
|
if (unlikely((__start_orc_unwind + start >= __stop_orc_unwind) ||
|
|
|
|
(__start_orc_unwind + stop > __stop_orc_unwind))) {
|
2017-10-20 19:21:34 +03:00
|
|
|
orc_warn("WARNING: bad lookup value: idx=%u num=%u start=%u stop=%u ip=%pB\n",
|
|
|
|
idx, lookup_num_blocks, start, stop, (void *)ip);
|
2017-07-25 02:36:57 +03:00
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
return __orc_find(__start_orc_unwind_ip + start,
|
|
|
|
__start_orc_unwind + start, stop - start, ip);
|
|
|
|
}
|
|
|
|
|
|
|
|
/* vmlinux .init slow lookup: */
|
2018-02-20 20:37:53 +03:00
|
|
|
if (init_kernel_text(ip))
|
2017-07-25 02:36:57 +03:00
|
|
|
return __orc_find(__start_orc_unwind_ip, __start_orc_unwind,
|
|
|
|
__stop_orc_unwind_ip - __start_orc_unwind_ip, ip);
|
|
|
|
|
|
|
|
/* Module lookup: */
|
2018-01-23 06:32:51 +03:00
|
|
|
orc = orc_module_find(ip);
|
|
|
|
if (orc)
|
|
|
|
return orc;
|
|
|
|
|
|
|
|
return orc_ftrace_find(ip);
|
2017-07-25 02:36:57 +03:00
|
|
|
}
|
|
|
|
|
2019-12-16 06:07:29 +03:00
|
|
|
#ifdef CONFIG_MODULES
|
|
|
|
|
2020-04-28 10:16:40 +03:00
|
|
|
static DEFINE_MUTEX(sort_mutex);
|
|
|
|
static int *cur_orc_ip_table = __start_orc_unwind_ip;
|
|
|
|
static struct orc_entry *cur_orc_table = __start_orc_unwind;
|
|
|
|
|
2017-07-25 02:36:57 +03:00
|
|
|
static void orc_sort_swap(void *_a, void *_b, int size)
|
|
|
|
{
|
|
|
|
struct orc_entry *orc_a, *orc_b;
|
|
|
|
struct orc_entry orc_tmp;
|
|
|
|
int *a = _a, *b = _b, tmp;
|
|
|
|
int delta = _b - _a;
|
|
|
|
|
|
|
|
/* Swap the .orc_unwind_ip entries: */
|
|
|
|
tmp = *a;
|
|
|
|
*a = *b + delta;
|
|
|
|
*b = tmp - delta;
|
|
|
|
|
|
|
|
/* Swap the corresponding .orc_unwind entries: */
|
|
|
|
orc_a = cur_orc_table + (a - cur_orc_ip_table);
|
|
|
|
orc_b = cur_orc_table + (b - cur_orc_ip_table);
|
|
|
|
orc_tmp = *orc_a;
|
|
|
|
*orc_a = *orc_b;
|
|
|
|
*orc_b = orc_tmp;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int orc_sort_cmp(const void *_a, const void *_b)
|
|
|
|
{
|
|
|
|
struct orc_entry *orc_a;
|
|
|
|
const int *a = _a, *b = _b;
|
|
|
|
unsigned long a_val = orc_ip(a);
|
|
|
|
unsigned long b_val = orc_ip(b);
|
|
|
|
|
|
|
|
if (a_val > b_val)
|
|
|
|
return 1;
|
|
|
|
if (a_val < b_val)
|
|
|
|
return -1;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* The "weak" section terminator entries need to always be on the left
|
|
|
|
* to ensure the lookup code skips them in favor of real entries.
|
|
|
|
* These terminator entries exist to handle any gaps created by
|
|
|
|
* whitelisted .o files which didn't get objtool generation.
|
|
|
|
*/
|
|
|
|
orc_a = cur_orc_table + (a - cur_orc_ip_table);
|
2018-05-18 09:47:12 +03:00
|
|
|
return orc_a->sp_reg == ORC_REG_UNDEFINED && !orc_a->end ? -1 : 1;
|
2017-07-25 02:36:57 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
void unwind_module_init(struct module *mod, void *_orc_ip, size_t orc_ip_size,
|
|
|
|
void *_orc, size_t orc_size)
|
|
|
|
{
|
|
|
|
int *orc_ip = _orc_ip;
|
|
|
|
struct orc_entry *orc = _orc;
|
|
|
|
unsigned int num_entries = orc_ip_size / sizeof(int);
|
|
|
|
|
|
|
|
WARN_ON_ONCE(orc_ip_size % sizeof(int) != 0 ||
|
|
|
|
orc_size % sizeof(*orc) != 0 ||
|
|
|
|
num_entries != orc_size / sizeof(*orc));
|
|
|
|
|
|
|
|
/*
|
|
|
|
* The 'cur_orc_*' globals allow the orc_sort_swap() callback to
|
|
|
|
* associate an .orc_unwind_ip table entry with its corresponding
|
|
|
|
* .orc_unwind entry so they can both be swapped.
|
|
|
|
*/
|
|
|
|
mutex_lock(&sort_mutex);
|
|
|
|
cur_orc_ip_table = orc_ip;
|
|
|
|
cur_orc_table = orc;
|
|
|
|
sort(orc_ip, num_entries, sizeof(int), orc_sort_cmp, orc_sort_swap);
|
|
|
|
mutex_unlock(&sort_mutex);
|
|
|
|
|
|
|
|
mod->arch.orc_unwind_ip = orc_ip;
|
|
|
|
mod->arch.orc_unwind = orc;
|
|
|
|
mod->arch.num_orcs = num_entries;
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
|
|
|
|
void __init unwind_init(void)
|
|
|
|
{
|
|
|
|
size_t orc_ip_size = (void *)__stop_orc_unwind_ip - (void *)__start_orc_unwind_ip;
|
|
|
|
size_t orc_size = (void *)__stop_orc_unwind - (void *)__start_orc_unwind;
|
|
|
|
size_t num_entries = orc_ip_size / sizeof(int);
|
|
|
|
struct orc_entry *orc;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
if (!num_entries || orc_ip_size % sizeof(int) != 0 ||
|
|
|
|
orc_size % sizeof(struct orc_entry) != 0 ||
|
|
|
|
num_entries != orc_size / sizeof(struct orc_entry)) {
|
|
|
|
orc_warn("WARNING: Bad or missing .orc_unwind table. Disabling unwinder.\n");
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2019-12-04 03:46:33 +03:00
|
|
|
/*
|
|
|
|
* Note, the orc_unwind and orc_unwind_ip tables were already
|
|
|
|
* sorted at build time via the 'sorttable' tool.
|
|
|
|
* It's ready for binary search straight away, no need to sort it.
|
|
|
|
*/
|
2017-07-25 02:36:57 +03:00
|
|
|
|
|
|
|
/* Initialize the fast lookup table: */
|
|
|
|
lookup_num_blocks = orc_lookup_end - orc_lookup;
|
|
|
|
for (i = 0; i < lookup_num_blocks-1; i++) {
|
|
|
|
orc = __orc_find(__start_orc_unwind_ip, __start_orc_unwind,
|
|
|
|
num_entries,
|
|
|
|
LOOKUP_START_IP + (LOOKUP_BLOCK_SIZE * i));
|
|
|
|
if (!orc) {
|
|
|
|
orc_warn("WARNING: Corrupt .orc_unwind table. Disabling unwinder.\n");
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
orc_lookup[i] = orc - __start_orc_unwind;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Initialize the ending block: */
|
|
|
|
orc = __orc_find(__start_orc_unwind_ip, __start_orc_unwind, num_entries,
|
|
|
|
LOOKUP_STOP_IP);
|
|
|
|
if (!orc) {
|
|
|
|
orc_warn("WARNING: Corrupt .orc_unwind table. Disabling unwinder.\n");
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
orc_lookup[lookup_num_blocks-1] = orc - __start_orc_unwind;
|
|
|
|
|
|
|
|
orc_init = true;
|
|
|
|
}
|
|
|
|
|
|
|
|
unsigned long unwind_get_return_address(struct unwind_state *state)
|
|
|
|
{
|
|
|
|
if (unwind_done(state))
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
return __kernel_text_address(state->ip) ? state->ip : 0;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(unwind_get_return_address);
|
|
|
|
|
|
|
|
unsigned long *unwind_get_return_address_ptr(struct unwind_state *state)
|
|
|
|
{
|
x86/unwind/orc: Fix unwind_get_return_address_ptr() for inactive tasks
Normally, show_trace_log_lvl() scans the stack, looking for text
addresses to print. In parallel, it unwinds the stack with
unwind_next_frame(). If the stack address matches the pointer returned
by unwind_get_return_address_ptr() for the current frame, the text
address is printed normally without a question mark. Otherwise it's
considered a breadcrumb (potentially from a previous call path) and it's
printed with a question mark to indicate that the address is unreliable
and typically can be ignored.
Since the following commit:
f1d9a2abff66 ("x86/unwind/orc: Don't skip the first frame for inactive tasks")
... for inactive tasks, show_trace_log_lvl() prints *only* unreliable
addresses (prepended with '?').
That happens because, for the first frame of an inactive task,
unwind_get_return_address_ptr() returns the wrong return address
pointer: one word *below* the task stack pointer. show_trace_log_lvl()
starts scanning at the stack pointer itself, so it never finds the first
'reliable' address, causing only guesses to being printed.
The first frame of an inactive task isn't a normal stack frame. It's
actually just an instance of 'struct inactive_task_frame' which is left
behind by __switch_to_asm(). Now that this inactive frame is actually
exposed to callers, fix unwind_get_return_address_ptr() to interpret it
properly.
Fixes: f1d9a2abff66 ("x86/unwind/orc: Don't skip the first frame for inactive tasks")
Reported-by: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20200522135435.vbxs7umku5pyrdbk@treble
2020-05-22 16:54:35 +03:00
|
|
|
struct task_struct *task = state->task;
|
|
|
|
|
2017-07-25 02:36:57 +03:00
|
|
|
if (unwind_done(state))
|
|
|
|
return NULL;
|
|
|
|
|
|
|
|
if (state->regs)
|
|
|
|
return &state->regs->ip;
|
|
|
|
|
x86/unwind/orc: Fix unwind_get_return_address_ptr() for inactive tasks
Normally, show_trace_log_lvl() scans the stack, looking for text
addresses to print. In parallel, it unwinds the stack with
unwind_next_frame(). If the stack address matches the pointer returned
by unwind_get_return_address_ptr() for the current frame, the text
address is printed normally without a question mark. Otherwise it's
considered a breadcrumb (potentially from a previous call path) and it's
printed with a question mark to indicate that the address is unreliable
and typically can be ignored.
Since the following commit:
f1d9a2abff66 ("x86/unwind/orc: Don't skip the first frame for inactive tasks")
... for inactive tasks, show_trace_log_lvl() prints *only* unreliable
addresses (prepended with '?').
That happens because, for the first frame of an inactive task,
unwind_get_return_address_ptr() returns the wrong return address
pointer: one word *below* the task stack pointer. show_trace_log_lvl()
starts scanning at the stack pointer itself, so it never finds the first
'reliable' address, causing only guesses to being printed.
The first frame of an inactive task isn't a normal stack frame. It's
actually just an instance of 'struct inactive_task_frame' which is left
behind by __switch_to_asm(). Now that this inactive frame is actually
exposed to callers, fix unwind_get_return_address_ptr() to interpret it
properly.
Fixes: f1d9a2abff66 ("x86/unwind/orc: Don't skip the first frame for inactive tasks")
Reported-by: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20200522135435.vbxs7umku5pyrdbk@treble
2020-05-22 16:54:35 +03:00
|
|
|
if (task != current && state->sp == task->thread.sp) {
|
|
|
|
struct inactive_task_frame *frame = (void *)task->thread.sp;
|
|
|
|
return &frame->ret_addr;
|
|
|
|
}
|
|
|
|
|
2017-07-25 02:36:57 +03:00
|
|
|
if (state->sp)
|
|
|
|
return (unsigned long *)state->sp - 1;
|
|
|
|
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2017-12-04 17:07:09 +03:00
|
|
|
static bool stack_access_ok(struct unwind_state *state, unsigned long _addr,
|
2017-07-25 02:36:57 +03:00
|
|
|
size_t len)
|
|
|
|
{
|
|
|
|
struct stack_info *info = &state->stack_info;
|
2017-12-04 17:07:09 +03:00
|
|
|
void *addr = (void *)_addr;
|
2017-07-25 02:36:57 +03:00
|
|
|
|
2017-12-04 17:07:09 +03:00
|
|
|
if (!on_stack(info, addr, len) &&
|
|
|
|
(get_stack_info(addr, state->task, info, &state->stack_mask)))
|
|
|
|
return false;
|
2017-07-25 02:36:57 +03:00
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
static bool deref_stack_reg(struct unwind_state *state, unsigned long addr,
|
|
|
|
unsigned long *val)
|
|
|
|
{
|
|
|
|
if (!stack_access_ok(state, addr, sizeof(long)))
|
|
|
|
return false;
|
|
|
|
|
2017-11-08 05:19:34 +03:00
|
|
|
*val = READ_ONCE_NOCHECK(*(unsigned long *)addr);
|
2017-07-25 02:36:57 +03:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
static bool deref_stack_regs(struct unwind_state *state, unsigned long addr,
|
2017-12-04 17:07:09 +03:00
|
|
|
unsigned long *ip, unsigned long *sp)
|
2017-07-25 02:36:57 +03:00
|
|
|
{
|
2017-12-04 17:07:09 +03:00
|
|
|
struct pt_regs *regs = (struct pt_regs *)addr;
|
2017-07-25 02:36:57 +03:00
|
|
|
|
2017-12-04 17:07:09 +03:00
|
|
|
/* x86-32 support will be more complicated due to the ®s->sp hack */
|
|
|
|
BUILD_BUG_ON(IS_ENABLED(CONFIG_X86_32));
|
2017-07-25 02:36:57 +03:00
|
|
|
|
2017-12-04 17:07:09 +03:00
|
|
|
if (!stack_access_ok(state, addr, sizeof(struct pt_regs)))
|
2017-07-25 02:36:57 +03:00
|
|
|
return false;
|
|
|
|
|
|
|
|
*ip = regs->ip;
|
2017-12-04 17:07:09 +03:00
|
|
|
*sp = regs->sp;
|
|
|
|
return true;
|
|
|
|
}
|
2017-07-25 02:36:57 +03:00
|
|
|
|
2017-12-04 17:07:09 +03:00
|
|
|
static bool deref_stack_iret_regs(struct unwind_state *state, unsigned long addr,
|
|
|
|
unsigned long *ip, unsigned long *sp)
|
|
|
|
{
|
|
|
|
struct pt_regs *regs = (void *)addr - IRET_FRAME_OFFSET;
|
2017-07-25 02:36:57 +03:00
|
|
|
|
2017-12-04 17:07:09 +03:00
|
|
|
if (!stack_access_ok(state, addr, IRET_FRAME_SIZE))
|
|
|
|
return false;
|
2017-07-25 02:36:57 +03:00
|
|
|
|
2017-12-04 17:07:09 +03:00
|
|
|
*ip = regs->ip;
|
|
|
|
*sp = regs->sp;
|
2017-07-25 02:36:57 +03:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
x86/unwind/orc: Fix premature unwind stoppage due to IRET frames
The following execution path is possible:
fsnotify()
[ realign the stack and store previous SP in R10 ]
<IRQ>
[ only IRET regs saved ]
common_interrupt()
interrupt_entry()
<NMI>
[ full pt_regs saved ]
...
[ unwind stack ]
When the unwinder goes through the NMI and the IRQ on the stack, and
then sees fsnotify(), it doesn't have access to the value of R10,
because it only has the five IRET registers. So the unwind stops
prematurely.
However, because the interrupt_entry() code is careful not to clobber
R10 before saving the full regs, the unwinder should be able to read R10
from the previously saved full pt_regs associated with the NMI.
Handle this case properly. When encountering an IRET regs frame
immediately after a full pt_regs frame, use the pt_regs as a backup
which can be used to get the C register values.
Also, note that a call frame resets the 'prev_regs' value, because a
function is free to clobber the registers. For this fix to work, the
IRET and full regs frames must be adjacent, with no FUNC frames in
between. So replace the FUNC hint in interrupt_entry() with an
IRET_REGS hint.
Fixes: ee9f8fce9964 ("x86/unwind: Add the ORC unwinder")
Reviewed-by: Miroslav Benes <mbenes@suse.cz>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Dave Jones <dsj@fb.com>
Cc: Jann Horn <jannh@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Vince Weaver <vincent.weaver@maine.edu>
Link: https://lore.kernel.org/r/97a408167cc09f1cfa0de31a7b70dd88868d743f.1587808742.git.jpoimboe@redhat.com
2020-04-25 13:06:14 +03:00
|
|
|
/*
|
|
|
|
* If state->regs is non-NULL, and points to a full pt_regs, just get the reg
|
|
|
|
* value from state->regs.
|
|
|
|
*
|
|
|
|
* Otherwise, if state->regs just points to IRET regs, and the previous frame
|
|
|
|
* had full regs, it's safe to get the value from the previous regs. This can
|
|
|
|
* happen when early/late IRQ entry code gets interrupted by an NMI.
|
|
|
|
*/
|
|
|
|
static bool get_reg(struct unwind_state *state, unsigned int reg_off,
|
|
|
|
unsigned long *val)
|
|
|
|
{
|
|
|
|
unsigned int reg = reg_off/8;
|
|
|
|
|
|
|
|
if (!state->regs)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
if (state->full_regs) {
|
|
|
|
*val = ((unsigned long *)state->regs)[reg];
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (state->prev_regs) {
|
|
|
|
*val = ((unsigned long *)state->prev_regs)[reg];
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2017-07-25 02:36:57 +03:00
|
|
|
bool unwind_next_frame(struct unwind_state *state)
|
|
|
|
{
|
x86/unwind/orc: Fix premature unwind stoppage due to IRET frames
The following execution path is possible:
fsnotify()
[ realign the stack and store previous SP in R10 ]
<IRQ>
[ only IRET regs saved ]
common_interrupt()
interrupt_entry()
<NMI>
[ full pt_regs saved ]
...
[ unwind stack ]
When the unwinder goes through the NMI and the IRQ on the stack, and
then sees fsnotify(), it doesn't have access to the value of R10,
because it only has the five IRET registers. So the unwind stops
prematurely.
However, because the interrupt_entry() code is careful not to clobber
R10 before saving the full regs, the unwinder should be able to read R10
from the previously saved full pt_regs associated with the NMI.
Handle this case properly. When encountering an IRET regs frame
immediately after a full pt_regs frame, use the pt_regs as a backup
which can be used to get the C register values.
Also, note that a call frame resets the 'prev_regs' value, because a
function is free to clobber the registers. For this fix to work, the
IRET and full regs frames must be adjacent, with no FUNC frames in
between. So replace the FUNC hint in interrupt_entry() with an
IRET_REGS hint.
Fixes: ee9f8fce9964 ("x86/unwind: Add the ORC unwinder")
Reviewed-by: Miroslav Benes <mbenes@suse.cz>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Dave Jones <dsj@fb.com>
Cc: Jann Horn <jannh@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Vince Weaver <vincent.weaver@maine.edu>
Link: https://lore.kernel.org/r/97a408167cc09f1cfa0de31a7b70dd88868d743f.1587808742.git.jpoimboe@redhat.com
2020-04-25 13:06:14 +03:00
|
|
|
unsigned long ip_p, sp, tmp, orig_ip = state->ip, prev_sp = state->sp;
|
2017-07-25 02:36:57 +03:00
|
|
|
enum stack_type prev_type = state->stack_info.type;
|
|
|
|
struct orc_entry *orc;
|
|
|
|
bool indirect = false;
|
|
|
|
|
|
|
|
if (unwind_done(state))
|
|
|
|
return false;
|
|
|
|
|
|
|
|
/* Don't let modules unload while we're reading their ORC data. */
|
|
|
|
preempt_disable();
|
|
|
|
|
2018-05-18 09:47:12 +03:00
|
|
|
/* End-of-stack check for user tasks: */
|
2017-07-25 02:36:57 +03:00
|
|
|
if (state->regs && user_mode(state->regs))
|
2018-05-18 09:47:12 +03:00
|
|
|
goto the_end;
|
2017-07-25 02:36:57 +03:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Find the orc_entry associated with the text address.
|
|
|
|
*
|
2020-07-17 17:04:25 +03:00
|
|
|
* For a call frame (as opposed to a signal frame), state->ip points to
|
|
|
|
* the instruction after the call. That instruction's stack layout
|
|
|
|
* could be different from the call instruction's layout, for example
|
|
|
|
* if the call was to a noreturn function. So get the ORC data for the
|
|
|
|
* call instruction itself.
|
2017-07-25 02:36:57 +03:00
|
|
|
*/
|
|
|
|
orc = orc_find(state->signal ? state->ip : state->ip - 1);
|
2019-06-27 03:33:55 +03:00
|
|
|
if (!orc) {
|
|
|
|
/*
|
|
|
|
* As a fallback, try to assume this code uses a frame pointer.
|
|
|
|
* This is useful for generated code, like BPF, which ORC
|
|
|
|
* doesn't know about. This is just a guess, so the rest of
|
|
|
|
* the unwind is no longer considered reliable.
|
|
|
|
*/
|
|
|
|
orc = &orc_fp_entry;
|
|
|
|
state->error = true;
|
|
|
|
}
|
2018-05-18 09:47:12 +03:00
|
|
|
|
|
|
|
/* End-of-stack check for kernel threads: */
|
|
|
|
if (orc->sp_reg == ORC_REG_UNDEFINED) {
|
|
|
|
if (!orc->end)
|
|
|
|
goto err;
|
|
|
|
|
|
|
|
goto the_end;
|
|
|
|
}
|
2017-07-25 02:36:57 +03:00
|
|
|
|
|
|
|
/* Find the previous frame's stack: */
|
|
|
|
switch (orc->sp_reg) {
|
|
|
|
case ORC_REG_SP:
|
|
|
|
sp = state->sp + orc->sp_offset;
|
|
|
|
break;
|
|
|
|
|
|
|
|
case ORC_REG_BP:
|
|
|
|
sp = state->bp + orc->sp_offset;
|
|
|
|
break;
|
|
|
|
|
|
|
|
case ORC_REG_SP_INDIRECT:
|
|
|
|
sp = state->sp + orc->sp_offset;
|
|
|
|
indirect = true;
|
|
|
|
break;
|
|
|
|
|
|
|
|
case ORC_REG_BP_INDIRECT:
|
|
|
|
sp = state->bp + orc->sp_offset;
|
|
|
|
indirect = true;
|
|
|
|
break;
|
|
|
|
|
|
|
|
case ORC_REG_R10:
|
x86/unwind/orc: Fix premature unwind stoppage due to IRET frames
The following execution path is possible:
fsnotify()
[ realign the stack and store previous SP in R10 ]
<IRQ>
[ only IRET regs saved ]
common_interrupt()
interrupt_entry()
<NMI>
[ full pt_regs saved ]
...
[ unwind stack ]
When the unwinder goes through the NMI and the IRQ on the stack, and
then sees fsnotify(), it doesn't have access to the value of R10,
because it only has the five IRET registers. So the unwind stops
prematurely.
However, because the interrupt_entry() code is careful not to clobber
R10 before saving the full regs, the unwinder should be able to read R10
from the previously saved full pt_regs associated with the NMI.
Handle this case properly. When encountering an IRET regs frame
immediately after a full pt_regs frame, use the pt_regs as a backup
which can be used to get the C register values.
Also, note that a call frame resets the 'prev_regs' value, because a
function is free to clobber the registers. For this fix to work, the
IRET and full regs frames must be adjacent, with no FUNC frames in
between. So replace the FUNC hint in interrupt_entry() with an
IRET_REGS hint.
Fixes: ee9f8fce9964 ("x86/unwind: Add the ORC unwinder")
Reviewed-by: Miroslav Benes <mbenes@suse.cz>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Dave Jones <dsj@fb.com>
Cc: Jann Horn <jannh@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Vince Weaver <vincent.weaver@maine.edu>
Link: https://lore.kernel.org/r/97a408167cc09f1cfa0de31a7b70dd88868d743f.1587808742.git.jpoimboe@redhat.com
2020-04-25 13:06:14 +03:00
|
|
|
if (!get_reg(state, offsetof(struct pt_regs, r10), &sp)) {
|
2020-04-25 13:03:06 +03:00
|
|
|
orc_warn_current("missing R10 value at %pB\n",
|
|
|
|
(void *)state->ip);
|
2018-05-18 09:47:12 +03:00
|
|
|
goto err;
|
2017-07-25 02:36:57 +03:00
|
|
|
}
|
|
|
|
break;
|
|
|
|
|
|
|
|
case ORC_REG_R13:
|
x86/unwind/orc: Fix premature unwind stoppage due to IRET frames
The following execution path is possible:
fsnotify()
[ realign the stack and store previous SP in R10 ]
<IRQ>
[ only IRET regs saved ]
common_interrupt()
interrupt_entry()
<NMI>
[ full pt_regs saved ]
...
[ unwind stack ]
When the unwinder goes through the NMI and the IRQ on the stack, and
then sees fsnotify(), it doesn't have access to the value of R10,
because it only has the five IRET registers. So the unwind stops
prematurely.
However, because the interrupt_entry() code is careful not to clobber
R10 before saving the full regs, the unwinder should be able to read R10
from the previously saved full pt_regs associated with the NMI.
Handle this case properly. When encountering an IRET regs frame
immediately after a full pt_regs frame, use the pt_regs as a backup
which can be used to get the C register values.
Also, note that a call frame resets the 'prev_regs' value, because a
function is free to clobber the registers. For this fix to work, the
IRET and full regs frames must be adjacent, with no FUNC frames in
between. So replace the FUNC hint in interrupt_entry() with an
IRET_REGS hint.
Fixes: ee9f8fce9964 ("x86/unwind: Add the ORC unwinder")
Reviewed-by: Miroslav Benes <mbenes@suse.cz>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Dave Jones <dsj@fb.com>
Cc: Jann Horn <jannh@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Vince Weaver <vincent.weaver@maine.edu>
Link: https://lore.kernel.org/r/97a408167cc09f1cfa0de31a7b70dd88868d743f.1587808742.git.jpoimboe@redhat.com
2020-04-25 13:06:14 +03:00
|
|
|
if (!get_reg(state, offsetof(struct pt_regs, r13), &sp)) {
|
2020-04-25 13:03:06 +03:00
|
|
|
orc_warn_current("missing R13 value at %pB\n",
|
|
|
|
(void *)state->ip);
|
2018-05-18 09:47:12 +03:00
|
|
|
goto err;
|
2017-07-25 02:36:57 +03:00
|
|
|
}
|
|
|
|
break;
|
|
|
|
|
|
|
|
case ORC_REG_DI:
|
x86/unwind/orc: Fix premature unwind stoppage due to IRET frames
The following execution path is possible:
fsnotify()
[ realign the stack and store previous SP in R10 ]
<IRQ>
[ only IRET regs saved ]
common_interrupt()
interrupt_entry()
<NMI>
[ full pt_regs saved ]
...
[ unwind stack ]
When the unwinder goes through the NMI and the IRQ on the stack, and
then sees fsnotify(), it doesn't have access to the value of R10,
because it only has the five IRET registers. So the unwind stops
prematurely.
However, because the interrupt_entry() code is careful not to clobber
R10 before saving the full regs, the unwinder should be able to read R10
from the previously saved full pt_regs associated with the NMI.
Handle this case properly. When encountering an IRET regs frame
immediately after a full pt_regs frame, use the pt_regs as a backup
which can be used to get the C register values.
Also, note that a call frame resets the 'prev_regs' value, because a
function is free to clobber the registers. For this fix to work, the
IRET and full regs frames must be adjacent, with no FUNC frames in
between. So replace the FUNC hint in interrupt_entry() with an
IRET_REGS hint.
Fixes: ee9f8fce9964 ("x86/unwind: Add the ORC unwinder")
Reviewed-by: Miroslav Benes <mbenes@suse.cz>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Dave Jones <dsj@fb.com>
Cc: Jann Horn <jannh@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Vince Weaver <vincent.weaver@maine.edu>
Link: https://lore.kernel.org/r/97a408167cc09f1cfa0de31a7b70dd88868d743f.1587808742.git.jpoimboe@redhat.com
2020-04-25 13:06:14 +03:00
|
|
|
if (!get_reg(state, offsetof(struct pt_regs, di), &sp)) {
|
2020-04-25 13:03:06 +03:00
|
|
|
orc_warn_current("missing RDI value at %pB\n",
|
|
|
|
(void *)state->ip);
|
2018-05-18 09:47:12 +03:00
|
|
|
goto err;
|
2017-07-25 02:36:57 +03:00
|
|
|
}
|
|
|
|
break;
|
|
|
|
|
|
|
|
case ORC_REG_DX:
|
x86/unwind/orc: Fix premature unwind stoppage due to IRET frames
The following execution path is possible:
fsnotify()
[ realign the stack and store previous SP in R10 ]
<IRQ>
[ only IRET regs saved ]
common_interrupt()
interrupt_entry()
<NMI>
[ full pt_regs saved ]
...
[ unwind stack ]
When the unwinder goes through the NMI and the IRQ on the stack, and
then sees fsnotify(), it doesn't have access to the value of R10,
because it only has the five IRET registers. So the unwind stops
prematurely.
However, because the interrupt_entry() code is careful not to clobber
R10 before saving the full regs, the unwinder should be able to read R10
from the previously saved full pt_regs associated with the NMI.
Handle this case properly. When encountering an IRET regs frame
immediately after a full pt_regs frame, use the pt_regs as a backup
which can be used to get the C register values.
Also, note that a call frame resets the 'prev_regs' value, because a
function is free to clobber the registers. For this fix to work, the
IRET and full regs frames must be adjacent, with no FUNC frames in
between. So replace the FUNC hint in interrupt_entry() with an
IRET_REGS hint.
Fixes: ee9f8fce9964 ("x86/unwind: Add the ORC unwinder")
Reviewed-by: Miroslav Benes <mbenes@suse.cz>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Dave Jones <dsj@fb.com>
Cc: Jann Horn <jannh@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Vince Weaver <vincent.weaver@maine.edu>
Link: https://lore.kernel.org/r/97a408167cc09f1cfa0de31a7b70dd88868d743f.1587808742.git.jpoimboe@redhat.com
2020-04-25 13:06:14 +03:00
|
|
|
if (!get_reg(state, offsetof(struct pt_regs, dx), &sp)) {
|
2020-04-25 13:03:06 +03:00
|
|
|
orc_warn_current("missing DX value at %pB\n",
|
|
|
|
(void *)state->ip);
|
2018-05-18 09:47:12 +03:00
|
|
|
goto err;
|
2017-07-25 02:36:57 +03:00
|
|
|
}
|
|
|
|
break;
|
|
|
|
|
|
|
|
default:
|
2020-04-25 13:03:06 +03:00
|
|
|
orc_warn("unknown SP base reg %d at %pB\n",
|
2017-07-25 02:36:57 +03:00
|
|
|
orc->sp_reg, (void *)state->ip);
|
2018-05-18 09:47:12 +03:00
|
|
|
goto err;
|
2017-07-25 02:36:57 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
if (indirect) {
|
|
|
|
if (!deref_stack_reg(state, sp, &sp))
|
2018-05-18 09:47:12 +03:00
|
|
|
goto err;
|
2017-07-25 02:36:57 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
/* Find IP, SP and possibly regs: */
|
|
|
|
switch (orc->type) {
|
2020-09-04 18:30:27 +03:00
|
|
|
case UNWIND_HINT_TYPE_CALL:
|
2017-07-25 02:36:57 +03:00
|
|
|
ip_p = sp - sizeof(long);
|
|
|
|
|
|
|
|
if (!deref_stack_reg(state, ip_p, &state->ip))
|
2018-05-18 09:47:12 +03:00
|
|
|
goto err;
|
2017-07-25 02:36:57 +03:00
|
|
|
|
|
|
|
state->ip = ftrace_graph_ret_addr(state->task, &state->graph_idx,
|
|
|
|
state->ip, (void *)ip_p);
|
|
|
|
|
|
|
|
state->sp = sp;
|
|
|
|
state->regs = NULL;
|
x86/unwind/orc: Fix premature unwind stoppage due to IRET frames
The following execution path is possible:
fsnotify()
[ realign the stack and store previous SP in R10 ]
<IRQ>
[ only IRET regs saved ]
common_interrupt()
interrupt_entry()
<NMI>
[ full pt_regs saved ]
...
[ unwind stack ]
When the unwinder goes through the NMI and the IRQ on the stack, and
then sees fsnotify(), it doesn't have access to the value of R10,
because it only has the five IRET registers. So the unwind stops
prematurely.
However, because the interrupt_entry() code is careful not to clobber
R10 before saving the full regs, the unwinder should be able to read R10
from the previously saved full pt_regs associated with the NMI.
Handle this case properly. When encountering an IRET regs frame
immediately after a full pt_regs frame, use the pt_regs as a backup
which can be used to get the C register values.
Also, note that a call frame resets the 'prev_regs' value, because a
function is free to clobber the registers. For this fix to work, the
IRET and full regs frames must be adjacent, with no FUNC frames in
between. So replace the FUNC hint in interrupt_entry() with an
IRET_REGS hint.
Fixes: ee9f8fce9964 ("x86/unwind: Add the ORC unwinder")
Reviewed-by: Miroslav Benes <mbenes@suse.cz>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Dave Jones <dsj@fb.com>
Cc: Jann Horn <jannh@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Vince Weaver <vincent.weaver@maine.edu>
Link: https://lore.kernel.org/r/97a408167cc09f1cfa0de31a7b70dd88868d743f.1587808742.git.jpoimboe@redhat.com
2020-04-25 13:06:14 +03:00
|
|
|
state->prev_regs = NULL;
|
2017-07-25 02:36:57 +03:00
|
|
|
state->signal = false;
|
|
|
|
break;
|
|
|
|
|
2020-09-04 18:30:27 +03:00
|
|
|
case UNWIND_HINT_TYPE_REGS:
|
2017-12-04 17:07:09 +03:00
|
|
|
if (!deref_stack_regs(state, sp, &state->ip, &state->sp)) {
|
2020-04-25 13:03:06 +03:00
|
|
|
orc_warn_current("can't access registers at %pB\n",
|
|
|
|
(void *)orig_ip);
|
2018-05-18 09:47:12 +03:00
|
|
|
goto err;
|
2017-07-25 02:36:57 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
state->regs = (struct pt_regs *)sp;
|
x86/unwind/orc: Fix premature unwind stoppage due to IRET frames
The following execution path is possible:
fsnotify()
[ realign the stack and store previous SP in R10 ]
<IRQ>
[ only IRET regs saved ]
common_interrupt()
interrupt_entry()
<NMI>
[ full pt_regs saved ]
...
[ unwind stack ]
When the unwinder goes through the NMI and the IRQ on the stack, and
then sees fsnotify(), it doesn't have access to the value of R10,
because it only has the five IRET registers. So the unwind stops
prematurely.
However, because the interrupt_entry() code is careful not to clobber
R10 before saving the full regs, the unwinder should be able to read R10
from the previously saved full pt_regs associated with the NMI.
Handle this case properly. When encountering an IRET regs frame
immediately after a full pt_regs frame, use the pt_regs as a backup
which can be used to get the C register values.
Also, note that a call frame resets the 'prev_regs' value, because a
function is free to clobber the registers. For this fix to work, the
IRET and full regs frames must be adjacent, with no FUNC frames in
between. So replace the FUNC hint in interrupt_entry() with an
IRET_REGS hint.
Fixes: ee9f8fce9964 ("x86/unwind: Add the ORC unwinder")
Reviewed-by: Miroslav Benes <mbenes@suse.cz>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Dave Jones <dsj@fb.com>
Cc: Jann Horn <jannh@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Vince Weaver <vincent.weaver@maine.edu>
Link: https://lore.kernel.org/r/97a408167cc09f1cfa0de31a7b70dd88868d743f.1587808742.git.jpoimboe@redhat.com
2020-04-25 13:06:14 +03:00
|
|
|
state->prev_regs = NULL;
|
2017-07-25 02:36:57 +03:00
|
|
|
state->full_regs = true;
|
|
|
|
state->signal = true;
|
|
|
|
break;
|
|
|
|
|
2020-09-04 18:30:27 +03:00
|
|
|
case UNWIND_HINT_TYPE_REGS_PARTIAL:
|
2017-12-04 17:07:09 +03:00
|
|
|
if (!deref_stack_iret_regs(state, sp, &state->ip, &state->sp)) {
|
2020-04-25 13:03:06 +03:00
|
|
|
orc_warn_current("can't access iret registers at %pB\n",
|
|
|
|
(void *)orig_ip);
|
2018-05-18 09:47:12 +03:00
|
|
|
goto err;
|
2017-07-25 02:36:57 +03:00
|
|
|
}
|
|
|
|
|
x86/unwind/orc: Fix premature unwind stoppage due to IRET frames
The following execution path is possible:
fsnotify()
[ realign the stack and store previous SP in R10 ]
<IRQ>
[ only IRET regs saved ]
common_interrupt()
interrupt_entry()
<NMI>
[ full pt_regs saved ]
...
[ unwind stack ]
When the unwinder goes through the NMI and the IRQ on the stack, and
then sees fsnotify(), it doesn't have access to the value of R10,
because it only has the five IRET registers. So the unwind stops
prematurely.
However, because the interrupt_entry() code is careful not to clobber
R10 before saving the full regs, the unwinder should be able to read R10
from the previously saved full pt_regs associated with the NMI.
Handle this case properly. When encountering an IRET regs frame
immediately after a full pt_regs frame, use the pt_regs as a backup
which can be used to get the C register values.
Also, note that a call frame resets the 'prev_regs' value, because a
function is free to clobber the registers. For this fix to work, the
IRET and full regs frames must be adjacent, with no FUNC frames in
between. So replace the FUNC hint in interrupt_entry() with an
IRET_REGS hint.
Fixes: ee9f8fce9964 ("x86/unwind: Add the ORC unwinder")
Reviewed-by: Miroslav Benes <mbenes@suse.cz>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Dave Jones <dsj@fb.com>
Cc: Jann Horn <jannh@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Vince Weaver <vincent.weaver@maine.edu>
Link: https://lore.kernel.org/r/97a408167cc09f1cfa0de31a7b70dd88868d743f.1587808742.git.jpoimboe@redhat.com
2020-04-25 13:06:14 +03:00
|
|
|
if (state->full_regs)
|
|
|
|
state->prev_regs = state->regs;
|
2017-12-04 17:07:09 +03:00
|
|
|
state->regs = (void *)sp - IRET_FRAME_OFFSET;
|
|
|
|
state->full_regs = false;
|
2017-07-25 02:36:57 +03:00
|
|
|
state->signal = true;
|
|
|
|
break;
|
|
|
|
|
|
|
|
default:
|
2020-04-25 13:03:06 +03:00
|
|
|
orc_warn("unknown .orc_unwind entry type %d at %pB\n",
|
2017-10-20 19:21:34 +03:00
|
|
|
orc->type, (void *)orig_ip);
|
2020-04-25 13:06:13 +03:00
|
|
|
goto err;
|
2017-07-25 02:36:57 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
/* Find BP: */
|
|
|
|
switch (orc->bp_reg) {
|
|
|
|
case ORC_REG_UNDEFINED:
|
x86/unwind/orc: Fix premature unwind stoppage due to IRET frames
The following execution path is possible:
fsnotify()
[ realign the stack and store previous SP in R10 ]
<IRQ>
[ only IRET regs saved ]
common_interrupt()
interrupt_entry()
<NMI>
[ full pt_regs saved ]
...
[ unwind stack ]
When the unwinder goes through the NMI and the IRQ on the stack, and
then sees fsnotify(), it doesn't have access to the value of R10,
because it only has the five IRET registers. So the unwind stops
prematurely.
However, because the interrupt_entry() code is careful not to clobber
R10 before saving the full regs, the unwinder should be able to read R10
from the previously saved full pt_regs associated with the NMI.
Handle this case properly. When encountering an IRET regs frame
immediately after a full pt_regs frame, use the pt_regs as a backup
which can be used to get the C register values.
Also, note that a call frame resets the 'prev_regs' value, because a
function is free to clobber the registers. For this fix to work, the
IRET and full regs frames must be adjacent, with no FUNC frames in
between. So replace the FUNC hint in interrupt_entry() with an
IRET_REGS hint.
Fixes: ee9f8fce9964 ("x86/unwind: Add the ORC unwinder")
Reviewed-by: Miroslav Benes <mbenes@suse.cz>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Dave Jones <dsj@fb.com>
Cc: Jann Horn <jannh@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Vince Weaver <vincent.weaver@maine.edu>
Link: https://lore.kernel.org/r/97a408167cc09f1cfa0de31a7b70dd88868d743f.1587808742.git.jpoimboe@redhat.com
2020-04-25 13:06:14 +03:00
|
|
|
if (get_reg(state, offsetof(struct pt_regs, bp), &tmp))
|
|
|
|
state->bp = tmp;
|
2017-07-25 02:36:57 +03:00
|
|
|
break;
|
|
|
|
|
|
|
|
case ORC_REG_PREV_SP:
|
|
|
|
if (!deref_stack_reg(state, sp + orc->bp_offset, &state->bp))
|
2018-05-18 09:47:12 +03:00
|
|
|
goto err;
|
2017-07-25 02:36:57 +03:00
|
|
|
break;
|
|
|
|
|
|
|
|
case ORC_REG_BP:
|
|
|
|
if (!deref_stack_reg(state, state->bp + orc->bp_offset, &state->bp))
|
2018-05-18 09:47:12 +03:00
|
|
|
goto err;
|
2017-07-25 02:36:57 +03:00
|
|
|
break;
|
|
|
|
|
|
|
|
default:
|
2017-10-20 19:21:34 +03:00
|
|
|
orc_warn("unknown BP base reg %d for ip %pB\n",
|
2017-07-25 02:36:57 +03:00
|
|
|
orc->bp_reg, (void *)orig_ip);
|
2018-05-18 09:47:12 +03:00
|
|
|
goto err;
|
2017-07-25 02:36:57 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
/* Prevent a recursive loop due to bad ORC data: */
|
|
|
|
if (state->stack_info.type == prev_type &&
|
|
|
|
on_stack(&state->stack_info, (void *)state->sp, sizeof(long)) &&
|
|
|
|
state->sp <= prev_sp) {
|
2020-04-25 13:03:06 +03:00
|
|
|
orc_warn_current("stack going in the wrong direction? at %pB\n",
|
|
|
|
(void *)orig_ip);
|
2018-05-18 09:47:12 +03:00
|
|
|
goto err;
|
2017-07-25 02:36:57 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
preempt_enable();
|
|
|
|
return true;
|
|
|
|
|
2018-05-18 09:47:12 +03:00
|
|
|
err:
|
|
|
|
state->error = true;
|
|
|
|
|
|
|
|
the_end:
|
2017-07-25 02:36:57 +03:00
|
|
|
preempt_enable();
|
|
|
|
state->stack_info.type = STACK_TYPE_UNKNOWN;
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(unwind_next_frame);
|
|
|
|
|
|
|
|
void __unwind_start(struct unwind_state *state, struct task_struct *task,
|
|
|
|
struct pt_regs *regs, unsigned long *first_frame)
|
|
|
|
{
|
|
|
|
memset(state, 0, sizeof(*state));
|
|
|
|
state->task = task;
|
|
|
|
|
2020-05-14 23:31:10 +03:00
|
|
|
if (!orc_init)
|
|
|
|
goto err;
|
|
|
|
|
2017-07-25 02:36:57 +03:00
|
|
|
/*
|
|
|
|
* Refuse to unwind the stack of a task while it's executing on another
|
|
|
|
* CPU. This check is racy, but that's ok: the unwinder has other
|
|
|
|
* checks to prevent it from going off the rails.
|
|
|
|
*/
|
|
|
|
if (task_on_another_cpu(task))
|
2020-05-14 23:31:10 +03:00
|
|
|
goto err;
|
2017-07-25 02:36:57 +03:00
|
|
|
|
|
|
|
if (regs) {
|
|
|
|
if (user_mode(regs))
|
2020-05-14 23:31:10 +03:00
|
|
|
goto the_end;
|
2017-07-25 02:36:57 +03:00
|
|
|
|
|
|
|
state->ip = regs->ip;
|
2019-05-08 00:25:54 +03:00
|
|
|
state->sp = regs->sp;
|
2017-07-25 02:36:57 +03:00
|
|
|
state->bp = regs->bp;
|
|
|
|
state->regs = regs;
|
|
|
|
state->full_regs = true;
|
|
|
|
state->signal = true;
|
|
|
|
|
|
|
|
} else if (task == current) {
|
|
|
|
asm volatile("lea (%%rip), %0\n\t"
|
|
|
|
"mov %%rsp, %1\n\t"
|
|
|
|
"mov %%rbp, %2\n\t"
|
|
|
|
: "=r" (state->ip), "=r" (state->sp),
|
|
|
|
"=r" (state->bp));
|
|
|
|
|
|
|
|
} else {
|
|
|
|
struct inactive_task_frame *frame = (void *)task->thread.sp;
|
|
|
|
|
|
|
|
state->sp = task->thread.sp;
|
|
|
|
state->bp = READ_ONCE_NOCHECK(frame->bp);
|
|
|
|
state->ip = READ_ONCE_NOCHECK(frame->ret_addr);
|
2020-07-17 17:04:25 +03:00
|
|
|
state->signal = (void *)state->ip == ret_from_fork;
|
2017-07-25 02:36:57 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
if (get_stack_info((unsigned long *)state->sp, state->task,
|
2017-12-04 17:07:08 +03:00
|
|
|
&state->stack_info, &state->stack_mask)) {
|
|
|
|
/*
|
|
|
|
* We weren't on a valid stack. It's possible that
|
|
|
|
* we overflowed a valid stack into a guard page.
|
|
|
|
* See if the next page up is valid so that we can
|
|
|
|
* generate some kind of backtrace if this happens.
|
|
|
|
*/
|
|
|
|
void *next_page = (void *)PAGE_ALIGN((unsigned long)state->sp);
|
2020-05-14 23:31:10 +03:00
|
|
|
state->error = true;
|
2017-12-04 17:07:08 +03:00
|
|
|
if (get_stack_info(next_page, state->task, &state->stack_info,
|
|
|
|
&state->stack_mask))
|
|
|
|
return;
|
|
|
|
}
|
2017-07-25 02:36:57 +03:00
|
|
|
|
|
|
|
/*
|
|
|
|
* The caller can provide the address of the first frame directly
|
|
|
|
* (first_frame) or indirectly (regs->sp) to indicate which stack frame
|
|
|
|
* to start unwinding at. Skip ahead until we reach it.
|
|
|
|
*/
|
|
|
|
|
|
|
|
/* When starting from regs, skip the regs frame: */
|
|
|
|
if (regs) {
|
|
|
|
unwind_next_frame(state);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Otherwise, skip ahead to the user-specified starting frame: */
|
|
|
|
while (!unwind_done(state) &&
|
|
|
|
(!on_stack(&state->stack_info, first_frame, sizeof(long)) ||
|
2020-04-25 13:03:07 +03:00
|
|
|
state->sp < (unsigned long)first_frame))
|
2017-07-25 02:36:57 +03:00
|
|
|
unwind_next_frame(state);
|
|
|
|
|
|
|
|
return;
|
|
|
|
|
2020-05-14 23:31:10 +03:00
|
|
|
err:
|
|
|
|
state->error = true;
|
|
|
|
the_end:
|
2017-07-25 02:36:57 +03:00
|
|
|
state->stack_info.type = STACK_TYPE_UNKNOWN;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(__unwind_start);
|