kbuild: compile-test exported headers to ensure they are self-contained
Multiple people have suggested compile-testing UAPI headers to ensure
they can be really included from user-space. "make headers_check" is
obviously not enough to catch bugs, and we often leak unresolved
references to user-space.
Use the new header-test-y syntax to implement it. Please note exported
headers are compile-tested with a completely different set of compiler
flags. The header search path is set to $(objtree)/usr/include since
exported headers should not include unexported ones.
We use -std=gnu89 for the kernel space since the kernel code highly
depends on GNU extensions. On the other hand, UAPI headers should be
written in more standardized C, so they are compiled with -std=c90.
This will emit errors if C++ style comments, the keyword 'inline', etc.
are used. Please use C style comments (/* ... */), '__inline__', etc.
in UAPI headers.
There is additional compiler requirement to enable this test because
many of UAPI headers include <stdlib.h>, <sys/ioctl.h>, <sys/time.h>,
etc. directly or indirectly. You cannot use kernel.org pre-built
toolchains [1] since they lack <stdlib.h>.
I reused CONFIG_CC_CAN_LINK to check the system header availability.
The intention is slightly different, but a compiler that can link
userspace programs provide system headers.
For now, a lot of headers need to be excluded because they cannot
be compiled standalone, but this is a good start point.
[1] https://mirrors.edge.kernel.org/pub/tools/crosstool/index.html
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
2019-07-01 03:58:40 +03:00
|
|
|
# SPDX-License-Identifier: GPL-2.0-only
|
|
|
|
|
|
|
|
|
|
# Unlike the kernel space, exported headers are written in standard C.
|
|
|
|
|
# - Forbid C++ style comments
|
|
|
|
|
# - Use '__inline__', '__asm__' instead of 'inline', 'asm'
|
|
|
|
|
#
|
|
|
|
|
# -std=c90 (equivalent to -ansi) catches the violation of those.
|
|
|
|
|
# We cannot go as far as adding -Wpedantic since it emits too many warnings.
|
|
|
|
|
UAPI_CFLAGS := -std=c90 -Wall -Werror=implicit-function-declaration
|
|
|
|
|
|
|
|
|
|
override c_flags = $(UAPI_CFLAGS) -Wp,-MD,$(depfile) -I$(objtree)/usr/include
|
|
|
|
|
|
|
|
|
|
# The following are excluded for now because they fail to build.
|
|
|
|
|
#
|
|
|
|
|
# Do not add a new header to the blacklist without legitimate reason.
|
|
|
|
|
# Please consider to fix the header first.
|
|
|
|
|
#
|
|
|
|
|
# Sorted alphabetically.
|
2019-12-18 18:34:22 +03:00
|
|
|
no-header-test += asm/shmbuf.h
|
|
|
|
|
no-header-test += asm/signal.h
|
|
|
|
|
no-header-test += asm/ucontext.h
|
|
|
|
|
no-header-test += drm/vmwgfx_drm.h
|
|
|
|
|
no-header-test += linux/am437x-vpfe.h
|
|
|
|
|
no-header-test += linux/android/binder.h
|
|
|
|
|
no-header-test += linux/android/binderfs.h
|
|
|
|
|
no-header-test += linux/coda.h
|
|
|
|
|
no-header-test += linux/elfcore.h
|
|
|
|
|
no-header-test += linux/errqueue.h
|
|
|
|
|
no-header-test += linux/fsmap.h
|
|
|
|
|
no-header-test += linux/hdlc/ioctl.h
|
|
|
|
|
no-header-test += linux/ivtv.h
|
|
|
|
|
no-header-test += linux/kexec.h
|
|
|
|
|
no-header-test += linux/matroxfb.h
|
|
|
|
|
no-header-test += linux/nfc.h
|
|
|
|
|
no-header-test += linux/omap3isp.h
|
|
|
|
|
no-header-test += linux/omapfb.h
|
|
|
|
|
no-header-test += linux/patchkey.h
|
|
|
|
|
no-header-test += linux/phonet.h
|
|
|
|
|
no-header-test += linux/reiserfs_xattr.h
|
|
|
|
|
no-header-test += linux/sctp.h
|
|
|
|
|
no-header-test += linux/signal.h
|
|
|
|
|
no-header-test += linux/sysctl.h
|
|
|
|
|
no-header-test += linux/usb/audio.h
|
|
|
|
|
no-header-test += linux/v4l2-mediabus.h
|
|
|
|
|
no-header-test += linux/v4l2-subdev.h
|
|
|
|
|
no-header-test += linux/videodev2.h
|
|
|
|
|
no-header-test += linux/vm_sockets.h
|
|
|
|
|
no-header-test += sound/asequencer.h
|
|
|
|
|
no-header-test += sound/asoc.h
|
|
|
|
|
no-header-test += sound/asound.h
|
|
|
|
|
no-header-test += sound/compress_offload.h
|
|
|
|
|
no-header-test += sound/emu10k1.h
|
|
|
|
|
no-header-test += sound/sfnt_info.h
|
|
|
|
|
no-header-test += xen/evtchn.h
|
|
|
|
|
no-header-test += xen/gntdev.h
|
|
|
|
|
no-header-test += xen/privcmd.h
|
kbuild: compile-test exported headers to ensure they are self-contained
Multiple people have suggested compile-testing UAPI headers to ensure
they can be really included from user-space. "make headers_check" is
obviously not enough to catch bugs, and we often leak unresolved
references to user-space.
Use the new header-test-y syntax to implement it. Please note exported
headers are compile-tested with a completely different set of compiler
flags. The header search path is set to $(objtree)/usr/include since
exported headers should not include unexported ones.
We use -std=gnu89 for the kernel space since the kernel code highly
depends on GNU extensions. On the other hand, UAPI headers should be
written in more standardized C, so they are compiled with -std=c90.
This will emit errors if C++ style comments, the keyword 'inline', etc.
are used. Please use C style comments (/* ... */), '__inline__', etc.
in UAPI headers.
There is additional compiler requirement to enable this test because
many of UAPI headers include <stdlib.h>, <sys/ioctl.h>, <sys/time.h>,
etc. directly or indirectly. You cannot use kernel.org pre-built
toolchains [1] since they lack <stdlib.h>.
I reused CONFIG_CC_CAN_LINK to check the system header availability.
The intention is slightly different, but a compiler that can link
userspace programs provide system headers.
For now, a lot of headers need to be excluded because they cannot
be compiled standalone, but this is a good start point.
[1] https://mirrors.edge.kernel.org/pub/tools/crosstool/index.html
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
2019-07-01 03:58:40 +03:00
|
|
|
|
|
|
|
|
# More headers are broken in some architectures
|
|
|
|
|
|
|
|
|
|
ifeq ($(SRCARCH),arc)
|
2019-12-18 18:34:22 +03:00
|
|
|
no-header-test += linux/bpf_perf_event.h
|
kbuild: compile-test exported headers to ensure they are self-contained
Multiple people have suggested compile-testing UAPI headers to ensure
they can be really included from user-space. "make headers_check" is
obviously not enough to catch bugs, and we often leak unresolved
references to user-space.
Use the new header-test-y syntax to implement it. Please note exported
headers are compile-tested with a completely different set of compiler
flags. The header search path is set to $(objtree)/usr/include since
exported headers should not include unexported ones.
We use -std=gnu89 for the kernel space since the kernel code highly
depends on GNU extensions. On the other hand, UAPI headers should be
written in more standardized C, so they are compiled with -std=c90.
This will emit errors if C++ style comments, the keyword 'inline', etc.
are used. Please use C style comments (/* ... */), '__inline__', etc.
in UAPI headers.
There is additional compiler requirement to enable this test because
many of UAPI headers include <stdlib.h>, <sys/ioctl.h>, <sys/time.h>,
etc. directly or indirectly. You cannot use kernel.org pre-built
toolchains [1] since they lack <stdlib.h>.
I reused CONFIG_CC_CAN_LINK to check the system header availability.
The intention is slightly different, but a compiler that can link
userspace programs provide system headers.
For now, a lot of headers need to be excluded because they cannot
be compiled standalone, but this is a good start point.
[1] https://mirrors.edge.kernel.org/pub/tools/crosstool/index.html
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
2019-07-01 03:58:40 +03:00
|
|
|
endif
|
|
|
|
|
|
|
|
|
|
ifeq ($(SRCARCH),ia64)
|
2019-12-18 18:34:22 +03:00
|
|
|
no-header-test += asm/setup.h
|
|
|
|
|
no-header-test += asm/sigcontext.h
|
|
|
|
|
no-header-test += asm/perfmon.h
|
|
|
|
|
no-header-test += asm/perfmon_default_smpl.h
|
|
|
|
|
no-header-test += linux/if_bonding.h
|
kbuild: compile-test exported headers to ensure they are self-contained
Multiple people have suggested compile-testing UAPI headers to ensure
they can be really included from user-space. "make headers_check" is
obviously not enough to catch bugs, and we often leak unresolved
references to user-space.
Use the new header-test-y syntax to implement it. Please note exported
headers are compile-tested with a completely different set of compiler
flags. The header search path is set to $(objtree)/usr/include since
exported headers should not include unexported ones.
We use -std=gnu89 for the kernel space since the kernel code highly
depends on GNU extensions. On the other hand, UAPI headers should be
written in more standardized C, so they are compiled with -std=c90.
This will emit errors if C++ style comments, the keyword 'inline', etc.
are used. Please use C style comments (/* ... */), '__inline__', etc.
in UAPI headers.
There is additional compiler requirement to enable this test because
many of UAPI headers include <stdlib.h>, <sys/ioctl.h>, <sys/time.h>,
etc. directly or indirectly. You cannot use kernel.org pre-built
toolchains [1] since they lack <stdlib.h>.
I reused CONFIG_CC_CAN_LINK to check the system header availability.
The intention is slightly different, but a compiler that can link
userspace programs provide system headers.
For now, a lot of headers need to be excluded because they cannot
be compiled standalone, but this is a good start point.
[1] https://mirrors.edge.kernel.org/pub/tools/crosstool/index.html
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
2019-07-01 03:58:40 +03:00
|
|
|
endif
|
|
|
|
|
|
|
|
|
|
ifeq ($(SRCARCH),mips)
|
2019-12-18 18:34:22 +03:00
|
|
|
no-header-test += asm/stat.h
|
kbuild: compile-test exported headers to ensure they are self-contained
Multiple people have suggested compile-testing UAPI headers to ensure
they can be really included from user-space. "make headers_check" is
obviously not enough to catch bugs, and we often leak unresolved
references to user-space.
Use the new header-test-y syntax to implement it. Please note exported
headers are compile-tested with a completely different set of compiler
flags. The header search path is set to $(objtree)/usr/include since
exported headers should not include unexported ones.
We use -std=gnu89 for the kernel space since the kernel code highly
depends on GNU extensions. On the other hand, UAPI headers should be
written in more standardized C, so they are compiled with -std=c90.
This will emit errors if C++ style comments, the keyword 'inline', etc.
are used. Please use C style comments (/* ... */), '__inline__', etc.
in UAPI headers.
There is additional compiler requirement to enable this test because
many of UAPI headers include <stdlib.h>, <sys/ioctl.h>, <sys/time.h>,
etc. directly or indirectly. You cannot use kernel.org pre-built
toolchains [1] since they lack <stdlib.h>.
I reused CONFIG_CC_CAN_LINK to check the system header availability.
The intention is slightly different, but a compiler that can link
userspace programs provide system headers.
For now, a lot of headers need to be excluded because they cannot
be compiled standalone, but this is a good start point.
[1] https://mirrors.edge.kernel.org/pub/tools/crosstool/index.html
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
2019-07-01 03:58:40 +03:00
|
|
|
endif
|
|
|
|
|
|
|
|
|
|
ifeq ($(SRCARCH),powerpc)
|
2019-12-18 18:34:22 +03:00
|
|
|
no-header-test += asm/stat.h
|
|
|
|
|
no-header-test += linux/bpf_perf_event.h
|
kbuild: compile-test exported headers to ensure they are self-contained
Multiple people have suggested compile-testing UAPI headers to ensure
they can be really included from user-space. "make headers_check" is
obviously not enough to catch bugs, and we often leak unresolved
references to user-space.
Use the new header-test-y syntax to implement it. Please note exported
headers are compile-tested with a completely different set of compiler
flags. The header search path is set to $(objtree)/usr/include since
exported headers should not include unexported ones.
We use -std=gnu89 for the kernel space since the kernel code highly
depends on GNU extensions. On the other hand, UAPI headers should be
written in more standardized C, so they are compiled with -std=c90.
This will emit errors if C++ style comments, the keyword 'inline', etc.
are used. Please use C style comments (/* ... */), '__inline__', etc.
in UAPI headers.
There is additional compiler requirement to enable this test because
many of UAPI headers include <stdlib.h>, <sys/ioctl.h>, <sys/time.h>,
etc. directly or indirectly. You cannot use kernel.org pre-built
toolchains [1] since they lack <stdlib.h>.
I reused CONFIG_CC_CAN_LINK to check the system header availability.
The intention is slightly different, but a compiler that can link
userspace programs provide system headers.
For now, a lot of headers need to be excluded because they cannot
be compiled standalone, but this is a good start point.
[1] https://mirrors.edge.kernel.org/pub/tools/crosstool/index.html
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
2019-07-01 03:58:40 +03:00
|
|
|
endif
|
|
|
|
|
|
|
|
|
|
ifeq ($(SRCARCH),riscv)
|
2019-12-18 18:34:22 +03:00
|
|
|
no-header-test += linux/bpf_perf_event.h
|
kbuild: compile-test exported headers to ensure they are self-contained
Multiple people have suggested compile-testing UAPI headers to ensure
they can be really included from user-space. "make headers_check" is
obviously not enough to catch bugs, and we often leak unresolved
references to user-space.
Use the new header-test-y syntax to implement it. Please note exported
headers are compile-tested with a completely different set of compiler
flags. The header search path is set to $(objtree)/usr/include since
exported headers should not include unexported ones.
We use -std=gnu89 for the kernel space since the kernel code highly
depends on GNU extensions. On the other hand, UAPI headers should be
written in more standardized C, so they are compiled with -std=c90.
This will emit errors if C++ style comments, the keyword 'inline', etc.
are used. Please use C style comments (/* ... */), '__inline__', etc.
in UAPI headers.
There is additional compiler requirement to enable this test because
many of UAPI headers include <stdlib.h>, <sys/ioctl.h>, <sys/time.h>,
etc. directly or indirectly. You cannot use kernel.org pre-built
toolchains [1] since they lack <stdlib.h>.
I reused CONFIG_CC_CAN_LINK to check the system header availability.
The intention is slightly different, but a compiler that can link
userspace programs provide system headers.
For now, a lot of headers need to be excluded because they cannot
be compiled standalone, but this is a good start point.
[1] https://mirrors.edge.kernel.org/pub/tools/crosstool/index.html
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
2019-07-01 03:58:40 +03:00
|
|
|
endif
|
|
|
|
|
|
|
|
|
|
ifeq ($(SRCARCH),sparc)
|
2019-12-18 18:34:22 +03:00
|
|
|
no-header-test += asm/stat.h
|
|
|
|
|
no-header-test += asm/uctx.h
|
|
|
|
|
no-header-test += asm/fbio.h
|
kbuild: compile-test exported headers to ensure they are self-contained
Multiple people have suggested compile-testing UAPI headers to ensure
they can be really included from user-space. "make headers_check" is
obviously not enough to catch bugs, and we often leak unresolved
references to user-space.
Use the new header-test-y syntax to implement it. Please note exported
headers are compile-tested with a completely different set of compiler
flags. The header search path is set to $(objtree)/usr/include since
exported headers should not include unexported ones.
We use -std=gnu89 for the kernel space since the kernel code highly
depends on GNU extensions. On the other hand, UAPI headers should be
written in more standardized C, so they are compiled with -std=c90.
This will emit errors if C++ style comments, the keyword 'inline', etc.
are used. Please use C style comments (/* ... */), '__inline__', etc.
in UAPI headers.
There is additional compiler requirement to enable this test because
many of UAPI headers include <stdlib.h>, <sys/ioctl.h>, <sys/time.h>,
etc. directly or indirectly. You cannot use kernel.org pre-built
toolchains [1] since they lack <stdlib.h>.
I reused CONFIG_CC_CAN_LINK to check the system header availability.
The intention is slightly different, but a compiler that can link
userspace programs provide system headers.
For now, a lot of headers need to be excluded because they cannot
be compiled standalone, but this is a good start point.
[1] https://mirrors.edge.kernel.org/pub/tools/crosstool/index.html
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
2019-07-01 03:58:40 +03:00
|
|
|
endif
|
|
|
|
|
|
|
|
|
|
# asm-generic/*.h is used by asm/*.h, and should not be included directly
|
2019-12-18 18:34:22 +03:00
|
|
|
no-header-test += asm-generic/%
|
kbuild: compile-test exported headers to ensure they are self-contained
Multiple people have suggested compile-testing UAPI headers to ensure
they can be really included from user-space. "make headers_check" is
obviously not enough to catch bugs, and we often leak unresolved
references to user-space.
Use the new header-test-y syntax to implement it. Please note exported
headers are compile-tested with a completely different set of compiler
flags. The header search path is set to $(objtree)/usr/include since
exported headers should not include unexported ones.
We use -std=gnu89 for the kernel space since the kernel code highly
depends on GNU extensions. On the other hand, UAPI headers should be
written in more standardized C, so they are compiled with -std=c90.
This will emit errors if C++ style comments, the keyword 'inline', etc.
are used. Please use C style comments (/* ... */), '__inline__', etc.
in UAPI headers.
There is additional compiler requirement to enable this test because
many of UAPI headers include <stdlib.h>, <sys/ioctl.h>, <sys/time.h>,
etc. directly or indirectly. You cannot use kernel.org pre-built
toolchains [1] since they lack <stdlib.h>.
I reused CONFIG_CC_CAN_LINK to check the system header availability.
The intention is slightly different, but a compiler that can link
userspace programs provide system headers.
For now, a lot of headers need to be excluded because they cannot
be compiled standalone, but this is a good start point.
[1] https://mirrors.edge.kernel.org/pub/tools/crosstool/index.html
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
2019-07-01 03:58:40 +03:00
|
|
|
|
2019-12-04 05:51:48 +03:00
|
|
|
extra-y := $(patsubst $(obj)/%.h,%.hdrtest, $(shell find $(obj) -name '*.h' 2>/dev/null))
|
2019-11-07 10:14:40 +03:00
|
|
|
|
2020-04-08 21:29:19 +03:00
|
|
|
# Include the header twice to detect missing include guard.
|
2019-11-07 10:14:40 +03:00
|
|
|
quiet_cmd_hdrtest = HDRTEST $<
|
2019-11-07 10:14:41 +03:00
|
|
|
cmd_hdrtest = \
|
|
|
|
|
$(CC) $(c_flags) -S -o /dev/null -x c /dev/null \
|
2019-12-18 18:34:22 +03:00
|
|
|
$(if $(filter-out $(no-header-test), $*.h), -include $< -include $<); \
|
2019-11-07 10:14:41 +03:00
|
|
|
$(PERL) $(srctree)/scripts/headers_check.pl $(obj) $(SRCARCH) $<; \
|
|
|
|
|
touch $@
|
2019-11-07 10:14:40 +03:00
|
|
|
|
|
|
|
|
$(obj)/%.hdrtest: $(obj)/%.h FORCE
|
|
|
|
|
$(call if_changed_dep,hdrtest)
|
kbuild: compile-test exported headers to ensure they are self-contained
Multiple people have suggested compile-testing UAPI headers to ensure
they can be really included from user-space. "make headers_check" is
obviously not enough to catch bugs, and we often leak unresolved
references to user-space.
Use the new header-test-y syntax to implement it. Please note exported
headers are compile-tested with a completely different set of compiler
flags. The header search path is set to $(objtree)/usr/include since
exported headers should not include unexported ones.
We use -std=gnu89 for the kernel space since the kernel code highly
depends on GNU extensions. On the other hand, UAPI headers should be
written in more standardized C, so they are compiled with -std=c90.
This will emit errors if C++ style comments, the keyword 'inline', etc.
are used. Please use C style comments (/* ... */), '__inline__', etc.
in UAPI headers.
There is additional compiler requirement to enable this test because
many of UAPI headers include <stdlib.h>, <sys/ioctl.h>, <sys/time.h>,
etc. directly or indirectly. You cannot use kernel.org pre-built
toolchains [1] since they lack <stdlib.h>.
I reused CONFIG_CC_CAN_LINK to check the system header availability.
The intention is slightly different, but a compiler that can link
userspace programs provide system headers.
For now, a lot of headers need to be excluded because they cannot
be compiled standalone, but this is a good start point.
[1] https://mirrors.edge.kernel.org/pub/tools/crosstool/index.html
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
2019-07-01 03:58:40 +03:00
|
|
|
|
2019-08-25 04:31:27 +03:00
|
|
|
clean-files += $(filter-out Makefile, $(notdir $(wildcard $(obj)/*)))
|
