2019-05-27 09:55:06 +03:00
|
|
|
// SPDX-License-Identifier: GPL-2.0-or-later
|
2011-04-15 02:25:47 +04:00
|
|
|
/* Xenbus code for blkif backend
|
|
|
|
Copyright (C) 2005 Rusty Russell <rusty@rustcorp.com.au>
|
|
|
|
Copyright (C) 2005 XenSource Ltd
|
|
|
|
|
|
|
|
|
|
|
|
*/
|
|
|
|
|
2015-04-01 18:04:22 +03:00
|
|
|
#define pr_fmt(fmt) "xen-blkback: " fmt
|
|
|
|
|
2011-04-15 02:25:47 +04:00
|
|
|
#include <stdarg.h>
|
|
|
|
#include <linux/module.h>
|
|
|
|
#include <linux/kthread.h>
|
2011-04-20 18:57:29 +04:00
|
|
|
#include <xen/events.h>
|
|
|
|
#include <xen/grant_table.h>
|
2011-04-15 02:25:47 +04:00
|
|
|
#include "common.h"
|
|
|
|
|
2016-02-04 00:40:05 +03:00
|
|
|
/* On the XenBus the max length of 'ring-ref%u'. */
|
2015-06-03 08:40:03 +03:00
|
|
|
#define RINGREF_NAME_LEN (20)
|
2015-03-27 16:15:54 +03:00
|
|
|
|
2011-04-15 01:33:30 +04:00
|
|
|
struct backend_info {
|
2011-05-11 23:57:09 +04:00
|
|
|
struct xenbus_device *dev;
|
2011-05-13 02:02:28 +04:00
|
|
|
struct xen_blkif *blkif;
|
2011-05-11 23:57:09 +04:00
|
|
|
struct xenbus_watch backend_watch;
|
|
|
|
unsigned major;
|
|
|
|
unsigned minor;
|
|
|
|
char *mode;
|
2011-04-15 02:25:47 +04:00
|
|
|
};
|
|
|
|
|
2011-04-20 19:50:43 +04:00
|
|
|
static struct kmem_cache *xen_blkif_cachep;
|
2011-04-15 02:25:47 +04:00
|
|
|
static void connect(struct backend_info *);
|
|
|
|
static int connect_ring(struct backend_info *);
|
2017-02-09 16:39:57 +03:00
|
|
|
static void backend_changed(struct xenbus_watch *, const char *,
|
|
|
|
const char *);
|
2014-05-21 00:28:50 +04:00
|
|
|
static void xen_blkif_free(struct xen_blkif *blkif);
|
|
|
|
static void xen_vbd_free(struct xen_vbd *vbd);
|
2011-04-15 02:25:47 +04:00
|
|
|
|
2011-04-20 19:50:43 +04:00
|
|
|
struct xenbus_device *xen_blkbk_xenbus(struct backend_info *be)
|
2010-03-19 01:35:05 +03:00
|
|
|
{
|
|
|
|
return be->dev;
|
|
|
|
}
|
|
|
|
|
2014-05-21 00:28:50 +04:00
|
|
|
/*
|
|
|
|
* The last request could free the device from softirq context and
|
|
|
|
* xen_blkif_free() can sleep.
|
|
|
|
*/
|
|
|
|
static void xen_blkif_deferred_free(struct work_struct *work)
|
|
|
|
{
|
|
|
|
struct xen_blkif *blkif;
|
|
|
|
|
|
|
|
blkif = container_of(work, struct xen_blkif, free_work);
|
|
|
|
xen_blkif_free(blkif);
|
|
|
|
}
|
|
|
|
|
2011-05-13 00:47:48 +04:00
|
|
|
static int blkback_name(struct xen_blkif *blkif, char *buf)
|
2011-04-15 02:25:47 +04:00
|
|
|
{
|
|
|
|
char *devpath, *devname;
|
|
|
|
struct xenbus_device *dev = blkif->be->dev;
|
|
|
|
|
|
|
|
devpath = xenbus_read(XBT_NIL, dev->nodename, "dev", NULL);
|
|
|
|
if (IS_ERR(devpath))
|
|
|
|
return PTR_ERR(devpath);
|
|
|
|
|
2011-04-15 01:33:30 +04:00
|
|
|
devname = strstr(devpath, "/dev/");
|
|
|
|
if (devname != NULL)
|
2011-04-15 02:25:47 +04:00
|
|
|
devname += strlen("/dev/");
|
|
|
|
else
|
|
|
|
devname = devpath;
|
|
|
|
|
2016-02-04 00:40:05 +03:00
|
|
|
snprintf(buf, TASK_COMM_LEN, "%d.%s", blkif->domid, devname);
|
2011-04-15 02:25:47 +04:00
|
|
|
kfree(devpath);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2011-05-13 00:47:48 +04:00
|
|
|
static void xen_update_blkif_status(struct xen_blkif *blkif)
|
2011-04-15 02:25:47 +04:00
|
|
|
{
|
|
|
|
int err;
|
2016-02-04 00:40:05 +03:00
|
|
|
char name[TASK_COMM_LEN];
|
2015-12-11 20:08:48 +03:00
|
|
|
struct xen_blkif_ring *ring;
|
|
|
|
int i;
|
2011-04-15 02:25:47 +04:00
|
|
|
|
|
|
|
/* Not ready to connect? */
|
2015-12-11 20:08:48 +03:00
|
|
|
if (!blkif->rings || !blkif->rings[0].irq || !blkif->vbd.bdev)
|
2011-04-15 02:25:47 +04:00
|
|
|
return;
|
|
|
|
|
|
|
|
/* Already connected? */
|
|
|
|
if (blkif->be->dev->state == XenbusStateConnected)
|
|
|
|
return;
|
|
|
|
|
|
|
|
/* Attempt to connect: exit if we fail to. */
|
|
|
|
connect(blkif->be);
|
|
|
|
if (blkif->be->dev->state != XenbusStateConnected)
|
|
|
|
return;
|
|
|
|
|
|
|
|
err = blkback_name(blkif, name);
|
|
|
|
if (err) {
|
|
|
|
xenbus_dev_error(blkif->be->dev, err, "get blkback dev name");
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2010-07-21 23:41:45 +04:00
|
|
|
err = filemap_write_and_wait(blkif->vbd.bdev->bd_inode->i_mapping);
|
|
|
|
if (err) {
|
|
|
|
xenbus_dev_error(blkif->be->dev, err, "block flush");
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
invalidate_inode_pages2(blkif->vbd.bdev->bd_inode->i_mapping);
|
|
|
|
|
2015-12-11 20:08:48 +03:00
|
|
|
for (i = 0; i < blkif->nr_rings; i++) {
|
|
|
|
ring = &blkif->rings[i];
|
|
|
|
ring->xenblkd = kthread_run(xen_blkif_schedule, ring, "%s-%d", name, i);
|
|
|
|
if (IS_ERR(ring->xenblkd)) {
|
|
|
|
err = PTR_ERR(ring->xenblkd);
|
|
|
|
ring->xenblkd = NULL;
|
|
|
|
xenbus_dev_fatal(blkif->be->dev, err,
|
|
|
|
"start %s-%d xenblkd", name, i);
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return;
|
|
|
|
|
|
|
|
out:
|
|
|
|
while (--i >= 0) {
|
|
|
|
ring = &blkif->rings[i];
|
|
|
|
kthread_stop(ring->xenblkd);
|
2011-04-15 02:25:47 +04:00
|
|
|
}
|
2015-12-11 20:08:48 +03:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int xen_blkif_alloc_rings(struct xen_blkif *blkif)
|
|
|
|
{
|
|
|
|
unsigned int r;
|
|
|
|
|
treewide: kzalloc() -> kcalloc()
The kzalloc() function has a 2-factor argument form, kcalloc(). This
patch replaces cases of:
kzalloc(a * b, gfp)
with:
kcalloc(a * b, gfp)
as well as handling cases of:
kzalloc(a * b * c, gfp)
with:
kzalloc(array3_size(a, b, c), gfp)
as it's slightly less ugly than:
kzalloc_array(array_size(a, b), c, gfp)
This does, however, attempt to ignore constant size factors like:
kzalloc(4 * 1024, gfp)
though any constants defined via macros get caught up in the conversion.
Any factors with a sizeof() of "unsigned char", "char", and "u8" were
dropped, since they're redundant.
The Coccinelle script used for this was:
// Fix redundant parens around sizeof().
@@
type TYPE;
expression THING, E;
@@
(
kzalloc(
- (sizeof(TYPE)) * E
+ sizeof(TYPE) * E
, ...)
|
kzalloc(
- (sizeof(THING)) * E
+ sizeof(THING) * E
, ...)
)
// Drop single-byte sizes and redundant parens.
@@
expression COUNT;
typedef u8;
typedef __u8;
@@
(
kzalloc(
- sizeof(u8) * (COUNT)
+ COUNT
, ...)
|
kzalloc(
- sizeof(__u8) * (COUNT)
+ COUNT
, ...)
|
kzalloc(
- sizeof(char) * (COUNT)
+ COUNT
, ...)
|
kzalloc(
- sizeof(unsigned char) * (COUNT)
+ COUNT
, ...)
|
kzalloc(
- sizeof(u8) * COUNT
+ COUNT
, ...)
|
kzalloc(
- sizeof(__u8) * COUNT
+ COUNT
, ...)
|
kzalloc(
- sizeof(char) * COUNT
+ COUNT
, ...)
|
kzalloc(
- sizeof(unsigned char) * COUNT
+ COUNT
, ...)
)
// 2-factor product with sizeof(type/expression) and identifier or constant.
@@
type TYPE;
expression THING;
identifier COUNT_ID;
constant COUNT_CONST;
@@
(
- kzalloc
+ kcalloc
(
- sizeof(TYPE) * (COUNT_ID)
+ COUNT_ID, sizeof(TYPE)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(TYPE) * COUNT_ID
+ COUNT_ID, sizeof(TYPE)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(TYPE) * (COUNT_CONST)
+ COUNT_CONST, sizeof(TYPE)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(TYPE) * COUNT_CONST
+ COUNT_CONST, sizeof(TYPE)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(THING) * (COUNT_ID)
+ COUNT_ID, sizeof(THING)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(THING) * COUNT_ID
+ COUNT_ID, sizeof(THING)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(THING) * (COUNT_CONST)
+ COUNT_CONST, sizeof(THING)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(THING) * COUNT_CONST
+ COUNT_CONST, sizeof(THING)
, ...)
)
// 2-factor product, only identifiers.
@@
identifier SIZE, COUNT;
@@
- kzalloc
+ kcalloc
(
- SIZE * COUNT
+ COUNT, SIZE
, ...)
// 3-factor product with 1 sizeof(type) or sizeof(expression), with
// redundant parens removed.
@@
expression THING;
identifier STRIDE, COUNT;
type TYPE;
@@
(
kzalloc(
- sizeof(TYPE) * (COUNT) * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
kzalloc(
- sizeof(TYPE) * (COUNT) * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
kzalloc(
- sizeof(TYPE) * COUNT * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
kzalloc(
- sizeof(TYPE) * COUNT * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
kzalloc(
- sizeof(THING) * (COUNT) * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
kzalloc(
- sizeof(THING) * (COUNT) * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
kzalloc(
- sizeof(THING) * COUNT * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
kzalloc(
- sizeof(THING) * COUNT * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
)
// 3-factor product with 2 sizeof(variable), with redundant parens removed.
@@
expression THING1, THING2;
identifier COUNT;
type TYPE1, TYPE2;
@@
(
kzalloc(
- sizeof(TYPE1) * sizeof(TYPE2) * COUNT
+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
, ...)
|
kzalloc(
- sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
, ...)
|
kzalloc(
- sizeof(THING1) * sizeof(THING2) * COUNT
+ array3_size(COUNT, sizeof(THING1), sizeof(THING2))
, ...)
|
kzalloc(
- sizeof(THING1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(THING1), sizeof(THING2))
, ...)
|
kzalloc(
- sizeof(TYPE1) * sizeof(THING2) * COUNT
+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
, ...)
|
kzalloc(
- sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
, ...)
)
// 3-factor product, only identifiers, with redundant parens removed.
@@
identifier STRIDE, SIZE, COUNT;
@@
(
kzalloc(
- (COUNT) * STRIDE * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- COUNT * (STRIDE) * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- COUNT * STRIDE * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- (COUNT) * (STRIDE) * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- COUNT * (STRIDE) * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- (COUNT) * STRIDE * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- (COUNT) * (STRIDE) * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- COUNT * STRIDE * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
)
// Any remaining multi-factor products, first at least 3-factor products,
// when they're not all constants...
@@
expression E1, E2, E3;
constant C1, C2, C3;
@@
(
kzalloc(C1 * C2 * C3, ...)
|
kzalloc(
- (E1) * E2 * E3
+ array3_size(E1, E2, E3)
, ...)
|
kzalloc(
- (E1) * (E2) * E3
+ array3_size(E1, E2, E3)
, ...)
|
kzalloc(
- (E1) * (E2) * (E3)
+ array3_size(E1, E2, E3)
, ...)
|
kzalloc(
- E1 * E2 * E3
+ array3_size(E1, E2, E3)
, ...)
)
// And then all remaining 2 factors products when they're not all constants,
// keeping sizeof() as the second factor argument.
@@
expression THING, E1, E2;
type TYPE;
constant C1, C2, C3;
@@
(
kzalloc(sizeof(THING) * C2, ...)
|
kzalloc(sizeof(TYPE) * C2, ...)
|
kzalloc(C1 * C2 * C3, ...)
|
kzalloc(C1 * C2, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(TYPE) * (E2)
+ E2, sizeof(TYPE)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(TYPE) * E2
+ E2, sizeof(TYPE)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(THING) * (E2)
+ E2, sizeof(THING)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(THING) * E2
+ E2, sizeof(THING)
, ...)
|
- kzalloc
+ kcalloc
(
- (E1) * E2
+ E1, E2
, ...)
|
- kzalloc
+ kcalloc
(
- (E1) * (E2)
+ E1, E2
, ...)
|
- kzalloc
+ kcalloc
(
- E1 * E2
+ E1, E2
, ...)
)
Signed-off-by: Kees Cook <keescook@chromium.org>
2018-06-13 00:03:40 +03:00
|
|
|
blkif->rings = kcalloc(blkif->nr_rings, sizeof(struct xen_blkif_ring),
|
|
|
|
GFP_KERNEL);
|
2015-12-11 20:08:48 +03:00
|
|
|
if (!blkif->rings)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
for (r = 0; r < blkif->nr_rings; r++) {
|
|
|
|
struct xen_blkif_ring *ring = &blkif->rings[r];
|
|
|
|
|
|
|
|
spin_lock_init(&ring->blk_ring_lock);
|
|
|
|
init_waitqueue_head(&ring->wq);
|
|
|
|
INIT_LIST_HEAD(&ring->pending_free);
|
2015-11-14 06:12:19 +03:00
|
|
|
INIT_LIST_HEAD(&ring->persistent_purge_list);
|
|
|
|
INIT_WORK(&ring->persistent_purge_work, xen_blkbk_unmap_purged_grants);
|
|
|
|
spin_lock_init(&ring->free_pages_lock);
|
|
|
|
INIT_LIST_HEAD(&ring->free_pages);
|
2015-12-11 20:08:48 +03:00
|
|
|
|
|
|
|
spin_lock_init(&ring->pending_free_lock);
|
|
|
|
init_waitqueue_head(&ring->pending_free_wq);
|
|
|
|
init_waitqueue_head(&ring->shutdown_wq);
|
|
|
|
ring->blkif = blkif;
|
2015-12-09 02:44:02 +03:00
|
|
|
ring->st_print = jiffies;
|
2017-05-18 18:28:47 +03:00
|
|
|
ring->active = true;
|
2015-12-11 20:08:48 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
2011-04-15 02:25:47 +04:00
|
|
|
}
|
|
|
|
|
2011-05-13 00:47:48 +04:00
|
|
|
static struct xen_blkif *xen_blkif_alloc(domid_t domid)
|
2011-04-20 18:57:29 +04:00
|
|
|
{
|
2011-05-13 00:47:48 +04:00
|
|
|
struct xen_blkif *blkif;
|
2011-04-20 18:57:29 +04:00
|
|
|
|
2013-04-18 18:06:54 +04:00
|
|
|
BUILD_BUG_ON(MAX_INDIRECT_PAGES > BLKIF_MAX_INDIRECT_PAGES_PER_REQUEST);
|
2011-04-20 18:57:29 +04:00
|
|
|
|
2012-08-27 08:28:57 +04:00
|
|
|
blkif = kmem_cache_zalloc(xen_blkif_cachep, GFP_KERNEL);
|
2011-04-20 18:57:29 +04:00
|
|
|
if (!blkif)
|
|
|
|
return ERR_PTR(-ENOMEM);
|
|
|
|
|
|
|
|
blkif->domid = domid;
|
|
|
|
atomic_set(&blkif->refcnt, 1);
|
2011-10-10 08:42:22 +04:00
|
|
|
init_completion(&blkif->drain_complete);
|
2019-12-10 17:53:05 +03:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Because freeing back to the cache may be deferred, it is not
|
|
|
|
* safe to unload the module (and hence destroy the cache) until
|
|
|
|
* this has completed. To prevent premature unloading, take an
|
|
|
|
* extra module reference here and release only when the object
|
|
|
|
* has been freed back to the cache.
|
|
|
|
*/
|
|
|
|
__module_get(THIS_MODULE);
|
2015-11-14 06:12:15 +03:00
|
|
|
INIT_WORK(&blkif->free_work, xen_blkif_deferred_free);
|
2011-04-20 18:57:29 +04:00
|
|
|
|
|
|
|
return blkif;
|
|
|
|
}
|
|
|
|
|
2015-11-14 06:12:15 +03:00
|
|
|
static int xen_blkif_map(struct xen_blkif_ring *ring, grant_ref_t *gref,
|
2015-06-03 08:40:03 +03:00
|
|
|
unsigned int nr_grefs, unsigned int evtchn)
|
2011-04-20 18:57:29 +04:00
|
|
|
{
|
|
|
|
int err;
|
2015-11-14 06:12:15 +03:00
|
|
|
struct xen_blkif *blkif = ring->blkif;
|
2019-12-11 18:29:56 +03:00
|
|
|
const struct blkif_common_sring *sring_common;
|
|
|
|
RING_IDX rsp_prod, req_prod;
|
|
|
|
unsigned int size;
|
2011-04-20 18:57:29 +04:00
|
|
|
|
|
|
|
/* Already connected through? */
|
2015-11-14 06:12:15 +03:00
|
|
|
if (ring->irq)
|
2011-04-20 18:57:29 +04:00
|
|
|
return 0;
|
|
|
|
|
2015-06-03 08:40:03 +03:00
|
|
|
err = xenbus_map_ring_valloc(blkif->be->dev, gref, nr_grefs,
|
2015-11-14 06:12:15 +03:00
|
|
|
&ring->blk_ring);
|
2011-09-29 19:53:30 +04:00
|
|
|
if (err < 0)
|
2011-04-20 18:57:29 +04:00
|
|
|
return err;
|
|
|
|
|
2019-12-11 18:29:56 +03:00
|
|
|
sring_common = (struct blkif_common_sring *)ring->blk_ring;
|
|
|
|
rsp_prod = READ_ONCE(sring_common->rsp_prod);
|
|
|
|
req_prod = READ_ONCE(sring_common->req_prod);
|
|
|
|
|
2011-04-20 18:57:29 +04:00
|
|
|
switch (blkif->blk_protocol) {
|
|
|
|
case BLKIF_PROTOCOL_NATIVE:
|
|
|
|
{
|
2019-12-11 18:29:56 +03:00
|
|
|
struct blkif_sring *sring_native =
|
|
|
|
(struct blkif_sring *)ring->blk_ring;
|
|
|
|
|
|
|
|
BACK_RING_ATTACH(&ring->blk_rings.native, sring_native,
|
|
|
|
rsp_prod, XEN_PAGE_SIZE * nr_grefs);
|
|
|
|
size = __RING_SIZE(sring_native, XEN_PAGE_SIZE * nr_grefs);
|
2011-04-20 18:57:29 +04:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
case BLKIF_PROTOCOL_X86_32:
|
|
|
|
{
|
2019-12-11 18:29:56 +03:00
|
|
|
struct blkif_x86_32_sring *sring_x86_32 =
|
|
|
|
(struct blkif_x86_32_sring *)ring->blk_ring;
|
|
|
|
|
|
|
|
BACK_RING_ATTACH(&ring->blk_rings.x86_32, sring_x86_32,
|
|
|
|
rsp_prod, XEN_PAGE_SIZE * nr_grefs);
|
|
|
|
size = __RING_SIZE(sring_x86_32, XEN_PAGE_SIZE * nr_grefs);
|
2011-04-20 18:57:29 +04:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
case BLKIF_PROTOCOL_X86_64:
|
|
|
|
{
|
2019-12-11 18:29:56 +03:00
|
|
|
struct blkif_x86_64_sring *sring_x86_64 =
|
|
|
|
(struct blkif_x86_64_sring *)ring->blk_ring;
|
|
|
|
|
|
|
|
BACK_RING_ATTACH(&ring->blk_rings.x86_64, sring_x86_64,
|
|
|
|
rsp_prod, XEN_PAGE_SIZE * nr_grefs);
|
|
|
|
size = __RING_SIZE(sring_x86_64, XEN_PAGE_SIZE * nr_grefs);
|
2011-04-20 18:57:29 +04:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
default:
|
|
|
|
BUG();
|
|
|
|
}
|
|
|
|
|
2019-12-11 18:29:56 +03:00
|
|
|
err = -EIO;
|
|
|
|
if (req_prod - rsp_prod > size)
|
|
|
|
goto fail;
|
|
|
|
|
2011-04-20 19:50:43 +04:00
|
|
|
err = bind_interdomain_evtchn_to_irqhandler(blkif->domid, evtchn,
|
|
|
|
xen_blkif_be_int, 0,
|
2015-11-14 06:12:15 +03:00
|
|
|
"blkif-backend", ring);
|
2019-12-11 18:29:56 +03:00
|
|
|
if (err < 0)
|
|
|
|
goto fail;
|
2015-11-14 06:12:15 +03:00
|
|
|
ring->irq = err;
|
2011-04-20 18:57:29 +04:00
|
|
|
|
|
|
|
return 0;
|
2019-12-11 18:29:56 +03:00
|
|
|
|
|
|
|
fail:
|
|
|
|
xenbus_unmap_ring_vfree(blkif->be->dev, ring->blk_ring);
|
|
|
|
ring->blk_rings.common.sring = NULL;
|
|
|
|
return err;
|
2011-04-20 18:57:29 +04:00
|
|
|
}
|
|
|
|
|
2014-05-21 00:28:50 +04:00
|
|
|
static int xen_blkif_disconnect(struct xen_blkif *blkif)
|
2011-04-20 18:57:29 +04:00
|
|
|
{
|
2015-09-04 13:08:07 +03:00
|
|
|
struct pending_req *req, *n;
|
2015-12-11 20:08:48 +03:00
|
|
|
unsigned int j, r;
|
xen-blkback: stop blkback thread of every queue in xen_blkif_disconnect
In xen_blkif_disconnect, before checking inflight I/O, following code
stops the blkback thread,
if (ring->xenblkd) {
kthread_stop(ring->xenblkd);
wake_up(&ring->shutdown_wq);
}
If there is inflight I/O in any non-last queue, blkback returns -EBUSY
directly, and above code would not be called to stop thread of remaining
queue and processs them. When removing vbd device with lots of disk I/O
load, some queues with inflight I/O still have blkback thread running even
though the corresponding vbd device or guest is gone.
And this could cause some problems, for example, if the backend device type
is file, some loop devices and blkback thread always lingers there forever
after guest is destroyed, and this causes failure of umounting repositories
unless rebooting the dom0.
This patch allows thread of every queue has the chance to get stopped.
Otherwise, only thread of queue previous to(including) first busy one get
stopped, blkthread of remaining queue will still run. So stop all threads
properly and return -EBUSY if any queue has inflight I/O.
Signed-off-by: Annie Li <annie.li@oracle.com>
Reviewed-by: Herbert van den Bergh <herbert.van.den.bergh@oracle.com>
Reviewed-by: Bhavesh Davda <bhavesh.davda@oracle.com>
Reviewed-by: Adnan Misherfi <adnan.misherfi@oracle.com>
Acked-by: Roger Pau Monné <roger.pau@citrix.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
2017-08-25 00:25:59 +03:00
|
|
|
bool busy = false;
|
2015-09-04 13:08:07 +03:00
|
|
|
|
2015-12-11 20:08:48 +03:00
|
|
|
for (r = 0; r < blkif->nr_rings; r++) {
|
|
|
|
struct xen_blkif_ring *ring = &blkif->rings[r];
|
|
|
|
unsigned int i = 0;
|
2011-04-20 18:57:29 +04:00
|
|
|
|
2017-05-18 18:28:47 +03:00
|
|
|
if (!ring->active)
|
|
|
|
continue;
|
|
|
|
|
2015-12-11 20:08:48 +03:00
|
|
|
if (ring->xenblkd) {
|
|
|
|
kthread_stop(ring->xenblkd);
|
|
|
|
wake_up(&ring->shutdown_wq);
|
|
|
|
}
|
2011-04-20 18:57:29 +04:00
|
|
|
|
2015-12-11 20:08:48 +03:00
|
|
|
/* The above kthread_stop() guarantees that at this point we
|
|
|
|
* don't have any discard_io or other_io requests. So, checking
|
|
|
|
* for inflight IO is enough.
|
|
|
|
*/
|
xen-blkback: stop blkback thread of every queue in xen_blkif_disconnect
In xen_blkif_disconnect, before checking inflight I/O, following code
stops the blkback thread,
if (ring->xenblkd) {
kthread_stop(ring->xenblkd);
wake_up(&ring->shutdown_wq);
}
If there is inflight I/O in any non-last queue, blkback returns -EBUSY
directly, and above code would not be called to stop thread of remaining
queue and processs them. When removing vbd device with lots of disk I/O
load, some queues with inflight I/O still have blkback thread running even
though the corresponding vbd device or guest is gone.
And this could cause some problems, for example, if the backend device type
is file, some loop devices and blkback thread always lingers there forever
after guest is destroyed, and this causes failure of umounting repositories
unless rebooting the dom0.
This patch allows thread of every queue has the chance to get stopped.
Otherwise, only thread of queue previous to(including) first busy one get
stopped, blkthread of remaining queue will still run. So stop all threads
properly and return -EBUSY if any queue has inflight I/O.
Signed-off-by: Annie Li <annie.li@oracle.com>
Reviewed-by: Herbert van den Bergh <herbert.van.den.bergh@oracle.com>
Reviewed-by: Bhavesh Davda <bhavesh.davda@oracle.com>
Reviewed-by: Adnan Misherfi <adnan.misherfi@oracle.com>
Acked-by: Roger Pau Monné <roger.pau@citrix.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
2017-08-25 00:25:59 +03:00
|
|
|
if (atomic_read(&ring->inflight) > 0) {
|
|
|
|
busy = true;
|
|
|
|
continue;
|
|
|
|
}
|
2011-04-20 18:57:29 +04:00
|
|
|
|
2015-12-11 20:08:48 +03:00
|
|
|
if (ring->irq) {
|
|
|
|
unbind_from_irqhandler(ring->irq, ring);
|
|
|
|
ring->irq = 0;
|
|
|
|
}
|
2014-05-21 00:28:50 +04:00
|
|
|
|
2015-12-11 20:08:48 +03:00
|
|
|
if (ring->blk_rings.common.sring) {
|
|
|
|
xenbus_unmap_ring_vfree(blkif->be->dev, ring->blk_ring);
|
|
|
|
ring->blk_rings.common.sring = NULL;
|
|
|
|
}
|
2014-09-08 17:21:33 +04:00
|
|
|
|
2015-12-11 20:08:48 +03:00
|
|
|
/* Remove all persistent grants and the cache of ballooned pages. */
|
|
|
|
xen_blkbk_free_caches(ring);
|
2015-09-04 13:08:07 +03:00
|
|
|
|
2015-12-11 20:08:48 +03:00
|
|
|
/* Check that there is no request in use */
|
|
|
|
list_for_each_entry_safe(req, n, &ring->pending_free, free_list) {
|
|
|
|
list_del(&req->free_list);
|
2015-09-04 13:08:07 +03:00
|
|
|
|
2015-12-11 20:08:48 +03:00
|
|
|
for (j = 0; j < MAX_INDIRECT_SEGMENTS; j++)
|
|
|
|
kfree(req->segments[j]);
|
2015-09-04 13:08:07 +03:00
|
|
|
|
2015-12-11 20:08:48 +03:00
|
|
|
for (j = 0; j < MAX_INDIRECT_PAGES; j++)
|
|
|
|
kfree(req->indirect_pages[j]);
|
2015-09-04 13:08:07 +03:00
|
|
|
|
2015-12-11 20:08:48 +03:00
|
|
|
kfree(req);
|
|
|
|
i++;
|
|
|
|
}
|
|
|
|
|
2015-11-14 06:12:19 +03:00
|
|
|
BUG_ON(atomic_read(&ring->persistent_gnt_in_use) != 0);
|
|
|
|
BUG_ON(!list_empty(&ring->persistent_purge_list));
|
|
|
|
BUG_ON(!RB_EMPTY_ROOT(&ring->persistent_gnts));
|
|
|
|
BUG_ON(!list_empty(&ring->free_pages));
|
|
|
|
BUG_ON(ring->free_pages_num != 0);
|
|
|
|
BUG_ON(ring->persistent_gnt_c != 0);
|
2015-12-11 20:08:48 +03:00
|
|
|
WARN_ON(i != (XEN_BLKIF_REQS_PER_PAGE * blkif->nr_ring_pages));
|
2017-05-18 18:28:47 +03:00
|
|
|
ring->active = false;
|
2015-12-11 20:08:48 +03:00
|
|
|
}
|
xen-blkback: stop blkback thread of every queue in xen_blkif_disconnect
In xen_blkif_disconnect, before checking inflight I/O, following code
stops the blkback thread,
if (ring->xenblkd) {
kthread_stop(ring->xenblkd);
wake_up(&ring->shutdown_wq);
}
If there is inflight I/O in any non-last queue, blkback returns -EBUSY
directly, and above code would not be called to stop thread of remaining
queue and processs them. When removing vbd device with lots of disk I/O
load, some queues with inflight I/O still have blkback thread running even
though the corresponding vbd device or guest is gone.
And this could cause some problems, for example, if the backend device type
is file, some loop devices and blkback thread always lingers there forever
after guest is destroyed, and this causes failure of umounting repositories
unless rebooting the dom0.
This patch allows thread of every queue has the chance to get stopped.
Otherwise, only thread of queue previous to(including) first busy one get
stopped, blkthread of remaining queue will still run. So stop all threads
properly and return -EBUSY if any queue has inflight I/O.
Signed-off-by: Annie Li <annie.li@oracle.com>
Reviewed-by: Herbert van den Bergh <herbert.van.den.bergh@oracle.com>
Reviewed-by: Bhavesh Davda <bhavesh.davda@oracle.com>
Reviewed-by: Adnan Misherfi <adnan.misherfi@oracle.com>
Acked-by: Roger Pau Monné <roger.pau@citrix.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
2017-08-25 00:25:59 +03:00
|
|
|
if (busy)
|
|
|
|
return -EBUSY;
|
|
|
|
|
2015-09-04 13:08:07 +03:00
|
|
|
blkif->nr_ring_pages = 0;
|
2015-12-10 04:16:48 +03:00
|
|
|
/*
|
|
|
|
* blkif->rings was allocated in connect_ring, so we should free it in
|
|
|
|
* here.
|
|
|
|
*/
|
|
|
|
kfree(blkif->rings);
|
|
|
|
blkif->rings = NULL;
|
|
|
|
blkif->nr_rings = 0;
|
2015-09-04 13:08:07 +03:00
|
|
|
|
2014-05-21 00:28:50 +04:00
|
|
|
return 0;
|
2011-04-20 18:57:29 +04:00
|
|
|
}
|
|
|
|
|
2012-08-13 18:53:17 +04:00
|
|
|
static void xen_blkif_free(struct xen_blkif *blkif)
|
2011-04-20 18:57:29 +04:00
|
|
|
{
|
2017-05-18 18:28:48 +03:00
|
|
|
WARN_ON(xen_blkif_disconnect(blkif));
|
2014-05-21 00:28:50 +04:00
|
|
|
xen_vbd_free(&blkif->vbd);
|
2017-05-18 18:28:48 +03:00
|
|
|
kfree(blkif->be->mode);
|
|
|
|
kfree(blkif->be);
|
2013-04-17 22:18:59 +04:00
|
|
|
|
2014-02-04 14:26:13 +04:00
|
|
|
/* Make sure everything is drained before shutting down */
|
2011-04-20 19:50:43 +04:00
|
|
|
kmem_cache_free(xen_blkif_cachep, blkif);
|
2019-12-10 17:53:05 +03:00
|
|
|
module_put(THIS_MODULE);
|
2011-04-20 18:57:29 +04:00
|
|
|
}
|
|
|
|
|
2011-04-20 19:50:43 +04:00
|
|
|
int __init xen_blkif_interface_init(void)
|
2011-04-20 18:57:29 +04:00
|
|
|
{
|
2011-04-20 19:50:43 +04:00
|
|
|
xen_blkif_cachep = kmem_cache_create("blkif_cache",
|
2011-05-13 00:47:48 +04:00
|
|
|
sizeof(struct xen_blkif),
|
2011-04-20 19:50:43 +04:00
|
|
|
0, 0, NULL);
|
|
|
|
if (!xen_blkif_cachep)
|
2011-04-20 18:57:29 +04:00
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
2011-04-15 02:25:47 +04:00
|
|
|
|
2019-12-02 14:41:17 +03:00
|
|
|
void xen_blkif_interface_fini(void)
|
|
|
|
{
|
|
|
|
kmem_cache_destroy(xen_blkif_cachep);
|
|
|
|
xen_blkif_cachep = NULL;
|
|
|
|
}
|
|
|
|
|
2011-04-15 01:05:23 +04:00
|
|
|
/*
|
2011-04-15 02:25:47 +04:00
|
|
|
* sysfs interface for VBD I/O requests
|
|
|
|
*/
|
|
|
|
|
2015-12-09 02:44:02 +03:00
|
|
|
#define VBD_SHOW_ALLRING(name, format) \
|
2011-04-15 02:25:47 +04:00
|
|
|
static ssize_t show_##name(struct device *_dev, \
|
|
|
|
struct device_attribute *attr, \
|
|
|
|
char *buf) \
|
|
|
|
{ \
|
|
|
|
struct xenbus_device *dev = to_xenbus_device(_dev); \
|
2010-02-12 03:07:31 +03:00
|
|
|
struct backend_info *be = dev_get_drvdata(&dev->dev); \
|
2015-12-09 02:44:02 +03:00
|
|
|
struct xen_blkif *blkif = be->blkif; \
|
|
|
|
unsigned int i; \
|
|
|
|
unsigned long long result = 0; \
|
2011-04-15 02:25:47 +04:00
|
|
|
\
|
2015-12-09 02:44:02 +03:00
|
|
|
if (!blkif->rings) \
|
|
|
|
goto out; \
|
|
|
|
\
|
|
|
|
for (i = 0; i < blkif->nr_rings; i++) { \
|
|
|
|
struct xen_blkif_ring *ring = &blkif->rings[i]; \
|
|
|
|
\
|
|
|
|
result += ring->st_##name; \
|
|
|
|
} \
|
|
|
|
\
|
|
|
|
out: \
|
|
|
|
return sprintf(buf, format, result); \
|
2011-04-15 02:25:47 +04:00
|
|
|
} \
|
2018-05-24 22:38:59 +03:00
|
|
|
static DEVICE_ATTR(name, 0444, show_##name, NULL)
|
2011-04-15 02:25:47 +04:00
|
|
|
|
2015-12-09 02:44:02 +03:00
|
|
|
VBD_SHOW_ALLRING(oo_req, "%llu\n");
|
|
|
|
VBD_SHOW_ALLRING(rd_req, "%llu\n");
|
|
|
|
VBD_SHOW_ALLRING(wr_req, "%llu\n");
|
|
|
|
VBD_SHOW_ALLRING(f_req, "%llu\n");
|
|
|
|
VBD_SHOW_ALLRING(ds_req, "%llu\n");
|
|
|
|
VBD_SHOW_ALLRING(rd_sect, "%llu\n");
|
|
|
|
VBD_SHOW_ALLRING(wr_sect, "%llu\n");
|
2011-04-15 02:25:47 +04:00
|
|
|
|
2011-05-13 00:53:56 +04:00
|
|
|
static struct attribute *xen_vbdstat_attrs[] = {
|
2011-04-15 02:25:47 +04:00
|
|
|
&dev_attr_oo_req.attr,
|
|
|
|
&dev_attr_rd_req.attr,
|
|
|
|
&dev_attr_wr_req.attr,
|
2011-05-05 01:07:27 +04:00
|
|
|
&dev_attr_f_req.attr,
|
2011-09-01 14:39:10 +04:00
|
|
|
&dev_attr_ds_req.attr,
|
2011-04-15 02:25:47 +04:00
|
|
|
&dev_attr_rd_sect.attr,
|
|
|
|
&dev_attr_wr_sect.attr,
|
|
|
|
NULL
|
|
|
|
};
|
|
|
|
|
2016-07-07 10:38:58 +03:00
|
|
|
static const struct attribute_group xen_vbdstat_group = {
|
2011-04-15 02:25:47 +04:00
|
|
|
.name = "statistics",
|
2011-05-13 00:53:56 +04:00
|
|
|
.attrs = xen_vbdstat_attrs,
|
2011-04-15 02:25:47 +04:00
|
|
|
};
|
|
|
|
|
2015-12-09 02:44:02 +03:00
|
|
|
#define VBD_SHOW(name, format, args...) \
|
|
|
|
static ssize_t show_##name(struct device *_dev, \
|
|
|
|
struct device_attribute *attr, \
|
|
|
|
char *buf) \
|
|
|
|
{ \
|
|
|
|
struct xenbus_device *dev = to_xenbus_device(_dev); \
|
|
|
|
struct backend_info *be = dev_get_drvdata(&dev->dev); \
|
|
|
|
\
|
|
|
|
return sprintf(buf, format, ##args); \
|
|
|
|
} \
|
2018-05-24 22:38:59 +03:00
|
|
|
static DEVICE_ATTR(name, 0444, show_##name, NULL)
|
2015-12-09 02:44:02 +03:00
|
|
|
|
2011-04-15 02:25:47 +04:00
|
|
|
VBD_SHOW(physical_device, "%x:%x\n", be->major, be->minor);
|
|
|
|
VBD_SHOW(mode, "%s\n", be->mode);
|
|
|
|
|
2012-08-13 18:53:17 +04:00
|
|
|
static int xenvbd_sysfs_addif(struct xenbus_device *dev)
|
2011-04-15 02:25:47 +04:00
|
|
|
{
|
|
|
|
int error;
|
|
|
|
|
|
|
|
error = device_create_file(&dev->dev, &dev_attr_physical_device);
|
2011-04-15 01:33:30 +04:00
|
|
|
if (error)
|
2011-04-15 02:25:47 +04:00
|
|
|
goto fail1;
|
|
|
|
|
|
|
|
error = device_create_file(&dev->dev, &dev_attr_mode);
|
|
|
|
if (error)
|
|
|
|
goto fail2;
|
|
|
|
|
2011-05-13 00:53:56 +04:00
|
|
|
error = sysfs_create_group(&dev->dev.kobj, &xen_vbdstat_group);
|
2011-04-15 02:25:47 +04:00
|
|
|
if (error)
|
|
|
|
goto fail3;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
2011-05-13 00:53:56 +04:00
|
|
|
fail3: sysfs_remove_group(&dev->dev.kobj, &xen_vbdstat_group);
|
2011-04-15 02:25:47 +04:00
|
|
|
fail2: device_remove_file(&dev->dev, &dev_attr_mode);
|
|
|
|
fail1: device_remove_file(&dev->dev, &dev_attr_physical_device);
|
|
|
|
return error;
|
|
|
|
}
|
|
|
|
|
2012-08-13 18:53:17 +04:00
|
|
|
static void xenvbd_sysfs_delif(struct xenbus_device *dev)
|
2011-04-15 02:25:47 +04:00
|
|
|
{
|
2011-05-13 00:53:56 +04:00
|
|
|
sysfs_remove_group(&dev->dev.kobj, &xen_vbdstat_group);
|
2011-04-15 02:25:47 +04:00
|
|
|
device_remove_file(&dev->dev, &dev_attr_mode);
|
|
|
|
device_remove_file(&dev->dev, &dev_attr_physical_device);
|
|
|
|
}
|
|
|
|
|
2011-05-13 00:53:56 +04:00
|
|
|
static void xen_vbd_free(struct xen_vbd *vbd)
|
2011-04-20 19:21:43 +04:00
|
|
|
{
|
|
|
|
if (vbd->bdev)
|
|
|
|
blkdev_put(vbd->bdev, vbd->readonly ? FMODE_READ : FMODE_WRITE);
|
|
|
|
vbd->bdev = NULL;
|
|
|
|
}
|
|
|
|
|
2011-05-13 00:53:56 +04:00
|
|
|
static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle,
|
|
|
|
unsigned major, unsigned minor, int readonly,
|
|
|
|
int cdrom)
|
2011-04-20 19:21:43 +04:00
|
|
|
{
|
2011-05-13 00:53:56 +04:00
|
|
|
struct xen_vbd *vbd;
|
2011-04-20 19:21:43 +04:00
|
|
|
struct block_device *bdev;
|
2011-05-05 01:07:27 +04:00
|
|
|
struct request_queue *q;
|
2011-04-20 19:21:43 +04:00
|
|
|
|
|
|
|
vbd = &blkif->vbd;
|
|
|
|
vbd->handle = handle;
|
|
|
|
vbd->readonly = readonly;
|
|
|
|
vbd->type = 0;
|
|
|
|
|
|
|
|
vbd->pdevice = MKDEV(major, minor);
|
|
|
|
|
|
|
|
bdev = blkdev_get_by_dev(vbd->pdevice, vbd->readonly ?
|
|
|
|
FMODE_READ : FMODE_WRITE, NULL);
|
|
|
|
|
|
|
|
if (IS_ERR(bdev)) {
|
2015-04-01 18:04:22 +03:00
|
|
|
pr_warn("xen_vbd_create: device %08x could not be opened\n",
|
2011-04-20 19:21:43 +04:00
|
|
|
vbd->pdevice);
|
|
|
|
return -ENOENT;
|
|
|
|
}
|
|
|
|
|
|
|
|
vbd->bdev = bdev;
|
|
|
|
if (vbd->bdev->bd_disk == NULL) {
|
2015-04-01 18:04:22 +03:00
|
|
|
pr_warn("xen_vbd_create: device %08x doesn't exist\n",
|
2011-04-20 19:21:43 +04:00
|
|
|
vbd->pdevice);
|
2011-05-13 00:53:56 +04:00
|
|
|
xen_vbd_free(vbd);
|
2011-04-20 19:21:43 +04:00
|
|
|
return -ENOENT;
|
|
|
|
}
|
2011-05-25 14:24:25 +04:00
|
|
|
vbd->size = vbd_sz(vbd);
|
2011-04-20 19:21:43 +04:00
|
|
|
|
|
|
|
if (vbd->bdev->bd_disk->flags & GENHD_FL_CD || cdrom)
|
|
|
|
vbd->type |= VDISK_CDROM;
|
|
|
|
if (vbd->bdev->bd_disk->flags & GENHD_FL_REMOVABLE)
|
|
|
|
vbd->type |= VDISK_REMOVABLE;
|
|
|
|
|
2011-05-05 01:07:27 +04:00
|
|
|
q = bdev_get_queue(bdev);
|
2016-04-13 22:33:19 +03:00
|
|
|
if (q && test_bit(QUEUE_FLAG_WC, &q->queue_flags))
|
2011-05-05 01:07:27 +04:00
|
|
|
vbd->flush_support = true;
|
|
|
|
|
2016-06-09 17:00:36 +03:00
|
|
|
if (q && blk_queue_secure_erase(q))
|
2011-10-13 00:23:30 +04:00
|
|
|
vbd->discard_secure = true;
|
|
|
|
|
2015-04-01 18:04:22 +03:00
|
|
|
pr_debug("Successful creation of handle=%04x (dom=%u)\n",
|
2011-04-20 19:21:43 +04:00
|
|
|
handle, blkif->domid);
|
|
|
|
return 0;
|
|
|
|
}
|
2020-01-27 11:19:57 +03:00
|
|
|
|
2011-04-20 19:50:43 +04:00
|
|
|
static int xen_blkbk_remove(struct xenbus_device *dev)
|
2011-04-15 02:25:47 +04:00
|
|
|
{
|
2010-02-12 03:07:31 +03:00
|
|
|
struct backend_info *be = dev_get_drvdata(&dev->dev);
|
2011-04-15 02:25:47 +04:00
|
|
|
|
2015-04-01 18:04:22 +03:00
|
|
|
pr_debug("%s %p %d\n", __func__, dev, dev->otherend_id);
|
2011-04-15 02:25:47 +04:00
|
|
|
|
|
|
|
if (be->major || be->minor)
|
|
|
|
xenvbd_sysfs_delif(dev);
|
|
|
|
|
|
|
|
if (be->backend_watch.node) {
|
|
|
|
unregister_xenbus_watch(&be->backend_watch);
|
|
|
|
kfree(be->backend_watch.node);
|
|
|
|
be->backend_watch.node = NULL;
|
|
|
|
}
|
|
|
|
|
2014-05-21 00:28:50 +04:00
|
|
|
dev_set_drvdata(&dev->dev, NULL);
|
|
|
|
|
2017-05-11 18:27:35 +03:00
|
|
|
if (be->blkif) {
|
2011-04-20 19:50:43 +04:00
|
|
|
xen_blkif_disconnect(be->blkif);
|
2011-04-15 02:25:47 +04:00
|
|
|
|
2017-05-11 18:27:35 +03:00
|
|
|
/* Put the reference we set in xen_blkif_alloc(). */
|
|
|
|
xen_blkif_put(be->blkif);
|
|
|
|
}
|
|
|
|
|
2011-04-15 02:25:47 +04:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2011-05-05 01:07:27 +04:00
|
|
|
int xen_blkbk_flush_diskcache(struct xenbus_transaction xbt,
|
|
|
|
struct backend_info *be, int state)
|
2011-04-15 02:25:47 +04:00
|
|
|
{
|
|
|
|
struct xenbus_device *dev = be->dev;
|
|
|
|
int err;
|
|
|
|
|
2011-05-05 01:07:27 +04:00
|
|
|
err = xenbus_printf(xbt, dev->nodename, "feature-flush-cache",
|
2011-04-15 02:25:47 +04:00
|
|
|
"%d", state);
|
|
|
|
if (err)
|
2012-03-14 21:04:00 +04:00
|
|
|
dev_warn(&dev->dev, "writing feature-flush-cache (%d)", err);
|
2011-04-15 02:25:47 +04:00
|
|
|
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
2012-03-14 21:04:00 +04:00
|
|
|
static void xen_blkbk_discard(struct xenbus_transaction xbt, struct backend_info *be)
|
2011-09-01 14:39:10 +04:00
|
|
|
{
|
|
|
|
struct xenbus_device *dev = be->dev;
|
|
|
|
struct xen_blkif *blkif = be->blkif;
|
|
|
|
int err;
|
2016-10-31 16:58:40 +03:00
|
|
|
int state = 0;
|
2012-03-14 02:43:23 +04:00
|
|
|
struct block_device *bdev = be->blkif->vbd.bdev;
|
|
|
|
struct request_queue *q = bdev_get_queue(bdev);
|
|
|
|
|
2016-10-31 16:58:40 +03:00
|
|
|
if (!xenbus_read_unsigned(dev->nodename, "discard-enable", 1))
|
2014-05-21 18:32:42 +04:00
|
|
|
return;
|
|
|
|
|
2012-03-14 02:43:23 +04:00
|
|
|
if (blk_queue_discard(q)) {
|
|
|
|
err = xenbus_printf(xbt, dev->nodename,
|
|
|
|
"discard-granularity", "%u",
|
|
|
|
q->limits.discard_granularity);
|
|
|
|
if (err) {
|
2012-03-14 21:04:00 +04:00
|
|
|
dev_warn(&dev->dev, "writing discard-granularity (%d)", err);
|
|
|
|
return;
|
2012-03-14 02:43:23 +04:00
|
|
|
}
|
|
|
|
err = xenbus_printf(xbt, dev->nodename,
|
|
|
|
"discard-alignment", "%u",
|
|
|
|
q->limits.discard_alignment);
|
|
|
|
if (err) {
|
2012-03-14 21:04:00 +04:00
|
|
|
dev_warn(&dev->dev, "writing discard-alignment (%d)", err);
|
|
|
|
return;
|
2011-09-01 14:39:10 +04:00
|
|
|
}
|
2012-03-14 02:43:23 +04:00
|
|
|
state = 1;
|
|
|
|
/* Optional. */
|
|
|
|
err = xenbus_printf(xbt, dev->nodename,
|
|
|
|
"discard-secure", "%d",
|
|
|
|
blkif->vbd.discard_secure);
|
|
|
|
if (err) {
|
2012-04-17 05:55:04 +04:00
|
|
|
dev_warn(&dev->dev, "writing discard-secure (%d)", err);
|
2012-03-14 21:04:00 +04:00
|
|
|
return;
|
2011-09-01 14:39:10 +04:00
|
|
|
}
|
|
|
|
}
|
|
|
|
err = xenbus_printf(xbt, dev->nodename, "feature-discard",
|
|
|
|
"%d", state);
|
|
|
|
if (err)
|
2012-03-14 21:04:00 +04:00
|
|
|
dev_warn(&dev->dev, "writing feature-discard (%d)", err);
|
2011-09-01 14:39:10 +04:00
|
|
|
}
|
2020-01-27 11:19:57 +03:00
|
|
|
|
2011-10-10 08:42:22 +04:00
|
|
|
int xen_blkbk_barrier(struct xenbus_transaction xbt,
|
|
|
|
struct backend_info *be, int state)
|
|
|
|
{
|
|
|
|
struct xenbus_device *dev = be->dev;
|
|
|
|
int err;
|
|
|
|
|
|
|
|
err = xenbus_printf(xbt, dev->nodename, "feature-barrier",
|
|
|
|
"%d", state);
|
|
|
|
if (err)
|
2012-03-14 21:04:00 +04:00
|
|
|
dev_warn(&dev->dev, "writing feature-barrier (%d)", err);
|
2011-10-10 08:42:22 +04:00
|
|
|
|
|
|
|
return err;
|
|
|
|
}
|
2011-09-01 14:39:10 +04:00
|
|
|
|
2011-05-11 23:57:09 +04:00
|
|
|
/*
|
2011-04-15 02:25:47 +04:00
|
|
|
* Entry point to this code when a new device is created. Allocate the basic
|
|
|
|
* structures, and watch the store waiting for the hotplug scripts to tell us
|
|
|
|
* the device's physical major and minor numbers. Switch to InitWait.
|
|
|
|
*/
|
2011-04-20 19:50:43 +04:00
|
|
|
static int xen_blkbk_probe(struct xenbus_device *dev,
|
|
|
|
const struct xenbus_device_id *id)
|
2011-04-15 02:25:47 +04:00
|
|
|
{
|
|
|
|
int err;
|
|
|
|
struct backend_info *be = kzalloc(sizeof(struct backend_info),
|
|
|
|
GFP_KERNEL);
|
2015-04-01 18:04:22 +03:00
|
|
|
|
|
|
|
/* match the pr_debug in xen_blkbk_remove */
|
|
|
|
pr_debug("%s %p %d\n", __func__, dev, dev->otherend_id);
|
|
|
|
|
2011-04-15 02:25:47 +04:00
|
|
|
if (!be) {
|
|
|
|
xenbus_dev_fatal(dev, -ENOMEM,
|
|
|
|
"allocating backend structure");
|
|
|
|
return -ENOMEM;
|
|
|
|
}
|
|
|
|
be->dev = dev;
|
2010-02-12 03:07:31 +03:00
|
|
|
dev_set_drvdata(&dev->dev, be);
|
2011-04-15 02:25:47 +04:00
|
|
|
|
2011-04-20 19:50:43 +04:00
|
|
|
be->blkif = xen_blkif_alloc(dev->otherend_id);
|
2011-04-15 02:25:47 +04:00
|
|
|
if (IS_ERR(be->blkif)) {
|
|
|
|
err = PTR_ERR(be->blkif);
|
|
|
|
be->blkif = NULL;
|
|
|
|
xenbus_dev_fatal(dev, err, "creating block interface");
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
|
2016-02-10 14:18:10 +03:00
|
|
|
err = xenbus_printf(XBT_NIL, dev->nodename,
|
|
|
|
"feature-max-indirect-segments", "%u",
|
|
|
|
MAX_INDIRECT_SEGMENTS);
|
|
|
|
if (err)
|
|
|
|
dev_warn(&dev->dev,
|
|
|
|
"writing %s/feature-max-indirect-segments (%d)",
|
|
|
|
dev->nodename, err);
|
|
|
|
|
2015-11-14 06:12:17 +03:00
|
|
|
/* Multi-queue: advertise how many queues are supported by us.*/
|
|
|
|
err = xenbus_printf(XBT_NIL, dev->nodename,
|
|
|
|
"multi-queue-max-queues", "%u", xenblk_max_queues);
|
|
|
|
if (err)
|
|
|
|
pr_warn("Error writing multi-queue-max-queues\n");
|
|
|
|
|
2011-04-15 02:25:47 +04:00
|
|
|
/* setup back pointer */
|
|
|
|
be->blkif->be = be;
|
|
|
|
|
2009-02-09 23:05:51 +03:00
|
|
|
err = xenbus_watch_pathfmt(dev, &be->backend_watch, backend_changed,
|
|
|
|
"%s/%s", dev->nodename, "physical-device");
|
2011-04-15 02:25:47 +04:00
|
|
|
if (err)
|
|
|
|
goto fail;
|
|
|
|
|
2015-06-03 08:40:03 +03:00
|
|
|
err = xenbus_printf(XBT_NIL, dev->nodename, "max-ring-page-order", "%u",
|
|
|
|
xen_blkif_max_ring_order);
|
|
|
|
if (err)
|
|
|
|
pr_warn("%s write out 'max-ring-page-order' failed\n", __func__);
|
|
|
|
|
2011-04-15 02:25:47 +04:00
|
|
|
err = xenbus_switch_state(dev, XenbusStateInitWait);
|
|
|
|
if (err)
|
|
|
|
goto fail;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
fail:
|
2015-04-01 18:04:22 +03:00
|
|
|
pr_warn("%s failed\n", __func__);
|
2011-04-20 19:50:43 +04:00
|
|
|
xen_blkbk_remove(dev);
|
2011-04-15 02:25:47 +04:00
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
2011-05-11 23:57:09 +04:00
|
|
|
/*
|
2011-04-15 02:25:47 +04:00
|
|
|
* Callback received when the hotplug scripts have placed the physical-device
|
|
|
|
* node. Read it and the mode node, and create a vbd. If the frontend is
|
|
|
|
* ready, connect.
|
|
|
|
*/
|
|
|
|
static void backend_changed(struct xenbus_watch *watch,
|
2017-02-09 16:39:57 +03:00
|
|
|
const char *path, const char *token)
|
2011-04-15 02:25:47 +04:00
|
|
|
{
|
|
|
|
int err;
|
|
|
|
unsigned major;
|
|
|
|
unsigned minor;
|
|
|
|
struct backend_info *be
|
|
|
|
= container_of(watch, struct backend_info, backend_watch);
|
|
|
|
struct xenbus_device *dev = be->dev;
|
|
|
|
int cdrom = 0;
|
2012-12-20 14:31:11 +04:00
|
|
|
unsigned long handle;
|
2011-04-15 02:25:47 +04:00
|
|
|
char *device_type;
|
|
|
|
|
2015-04-01 18:04:22 +03:00
|
|
|
pr_debug("%s %p %d\n", __func__, dev, dev->otherend_id);
|
2011-04-15 02:25:47 +04:00
|
|
|
|
|
|
|
err = xenbus_scanf(XBT_NIL, dev->nodename, "physical-device", "%x:%x",
|
|
|
|
&major, &minor);
|
|
|
|
if (XENBUS_EXIST_ERR(err)) {
|
2011-05-11 23:57:09 +04:00
|
|
|
/*
|
|
|
|
* Since this watch will fire once immediately after it is
|
|
|
|
* registered, we expect this. Ignore it, and wait for the
|
|
|
|
* hotplug scripts.
|
|
|
|
*/
|
2011-04-15 02:25:47 +04:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
if (err != 2) {
|
|
|
|
xenbus_dev_fatal(dev, err, "reading physical-device");
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2012-12-20 14:31:11 +04:00
|
|
|
if (be->major | be->minor) {
|
|
|
|
if (be->major != major || be->minor != minor)
|
2015-04-01 18:04:22 +03:00
|
|
|
pr_warn("changing physical device (from %x:%x to %x:%x) not supported.\n",
|
2012-12-20 14:31:11 +04:00
|
|
|
be->major, be->minor, major, minor);
|
2011-04-15 02:25:47 +04:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
be->mode = xenbus_read(XBT_NIL, dev->nodename, "mode", NULL);
|
|
|
|
if (IS_ERR(be->mode)) {
|
|
|
|
err = PTR_ERR(be->mode);
|
|
|
|
be->mode = NULL;
|
|
|
|
xenbus_dev_fatal(dev, err, "reading mode");
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
device_type = xenbus_read(XBT_NIL, dev->otherend, "device-type", NULL);
|
|
|
|
if (!IS_ERR(device_type)) {
|
|
|
|
cdrom = strcmp(device_type, "cdrom") == 0;
|
|
|
|
kfree(device_type);
|
|
|
|
}
|
|
|
|
|
2012-12-20 14:31:11 +04:00
|
|
|
/* Front end dir is a number, which is used as the handle. */
|
2013-09-12 01:20:07 +04:00
|
|
|
err = kstrtoul(strrchr(dev->otherend, '/') + 1, 0, &handle);
|
2016-07-07 10:38:13 +03:00
|
|
|
if (err) {
|
|
|
|
kfree(be->mode);
|
|
|
|
be->mode = NULL;
|
2012-12-20 14:31:11 +04:00
|
|
|
return;
|
2016-07-07 10:38:13 +03:00
|
|
|
}
|
2011-04-15 02:25:47 +04:00
|
|
|
|
2012-12-20 14:31:11 +04:00
|
|
|
be->major = major;
|
|
|
|
be->minor = minor;
|
2011-04-15 02:25:47 +04:00
|
|
|
|
2012-12-20 14:31:11 +04:00
|
|
|
err = xen_vbd_create(be->blkif, handle, major, minor,
|
|
|
|
!strchr(be->mode, 'w'), cdrom);
|
2011-04-15 02:25:47 +04:00
|
|
|
|
2012-12-20 14:31:11 +04:00
|
|
|
if (err)
|
|
|
|
xenbus_dev_fatal(dev, err, "creating vbd structure");
|
|
|
|
else {
|
2011-04-15 02:25:47 +04:00
|
|
|
err = xenvbd_sysfs_addif(dev);
|
|
|
|
if (err) {
|
2011-05-13 00:53:56 +04:00
|
|
|
xen_vbd_free(&be->blkif->vbd);
|
2011-04-15 02:25:47 +04:00
|
|
|
xenbus_dev_fatal(dev, err, "creating sysfs entries");
|
|
|
|
}
|
2012-12-20 14:31:11 +04:00
|
|
|
}
|
2011-04-15 02:25:47 +04:00
|
|
|
|
2012-12-20 14:31:11 +04:00
|
|
|
if (err) {
|
|
|
|
kfree(be->mode);
|
|
|
|
be->mode = NULL;
|
|
|
|
be->major = 0;
|
|
|
|
be->minor = 0;
|
|
|
|
} else {
|
2011-04-15 02:25:47 +04:00
|
|
|
/* We're potentially connected now */
|
2011-04-20 19:50:43 +04:00
|
|
|
xen_update_blkif_status(be->blkif);
|
2011-04-15 02:25:47 +04:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2011-05-11 23:57:09 +04:00
|
|
|
/*
|
2011-04-15 02:25:47 +04:00
|
|
|
* Callback received when the frontend's state changes.
|
|
|
|
*/
|
|
|
|
static void frontend_changed(struct xenbus_device *dev,
|
|
|
|
enum xenbus_state frontend_state)
|
|
|
|
{
|
2010-02-12 03:07:31 +03:00
|
|
|
struct backend_info *be = dev_get_drvdata(&dev->dev);
|
2011-04-15 02:25:47 +04:00
|
|
|
int err;
|
|
|
|
|
2015-04-01 18:04:22 +03:00
|
|
|
pr_debug("%s %p %s\n", __func__, dev, xenbus_strstate(frontend_state));
|
2011-04-15 02:25:47 +04:00
|
|
|
|
|
|
|
switch (frontend_state) {
|
|
|
|
case XenbusStateInitialising:
|
|
|
|
if (dev->state == XenbusStateClosed) {
|
2015-04-01 18:04:22 +03:00
|
|
|
pr_info("%s: prepare for reconnect\n", dev->nodename);
|
2011-04-15 02:25:47 +04:00
|
|
|
xenbus_switch_state(dev, XenbusStateInitWait);
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
|
|
|
|
case XenbusStateInitialised:
|
|
|
|
case XenbusStateConnected:
|
2011-05-11 23:57:09 +04:00
|
|
|
/*
|
|
|
|
* Ensure we connect even when two watches fire in
|
2011-11-29 08:31:00 +04:00
|
|
|
* close succession and we miss the intermediate value
|
2011-05-11 23:57:09 +04:00
|
|
|
* of frontend_state.
|
|
|
|
*/
|
2011-04-15 02:25:47 +04:00
|
|
|
if (dev->state == XenbusStateConnected)
|
|
|
|
break;
|
|
|
|
|
2011-05-11 23:57:09 +04:00
|
|
|
/*
|
|
|
|
* Enforce precondition before potential leak point.
|
2011-08-15 08:57:07 +04:00
|
|
|
* xen_blkif_disconnect() is idempotent.
|
2010-11-25 09:08:20 +03:00
|
|
|
*/
|
2014-05-21 00:28:50 +04:00
|
|
|
err = xen_blkif_disconnect(be->blkif);
|
|
|
|
if (err) {
|
|
|
|
xenbus_dev_fatal(dev, err, "pending I/O");
|
|
|
|
break;
|
|
|
|
}
|
2010-11-25 09:08:20 +03:00
|
|
|
|
2011-04-15 02:25:47 +04:00
|
|
|
err = connect_ring(be);
|
2015-11-25 21:20:14 +03:00
|
|
|
if (err) {
|
|
|
|
/*
|
|
|
|
* Clean up so that memory resources can be used by
|
|
|
|
* other devices. connect_ring reported already error.
|
|
|
|
*/
|
|
|
|
xen_blkif_disconnect(be->blkif);
|
2011-04-15 02:25:47 +04:00
|
|
|
break;
|
2015-11-25 21:20:14 +03:00
|
|
|
}
|
2011-04-20 19:50:43 +04:00
|
|
|
xen_update_blkif_status(be->blkif);
|
2011-04-15 02:25:47 +04:00
|
|
|
break;
|
|
|
|
|
|
|
|
case XenbusStateClosing:
|
|
|
|
xenbus_switch_state(dev, XenbusStateClosing);
|
|
|
|
break;
|
|
|
|
|
|
|
|
case XenbusStateClosed:
|
xen-blkback: Don't disconnect backend until state switched to XenbusStateClosed.
When do block-attach/block-detach test with below steps, umount hangs
in the guest. Furthermore shutdown ends up being stuck when umounting file-systems.
1. start guest.
2. attach new block device by xm block-attach in Dom0.
3. mount new disk in guest.
4. execute xm block-detach to detach the block device in dom0 until timeout
5. Any request to the disk will hung.
Root cause:
This issue is caused when setting backend device's state to
'XenbusStateClosing', which sends to the frontend the XenbusStateClosing
notification. When frontend receives the notification it tries to release
the disk in blkfront_closing(), but at that moment the disk is still in use
by guest, so frontend refuses to close. Specifically it sets the disk state to
XenbusStateClosing and sends the notification to backend - when backend receives the
event, it disconnects the vbd from real device, and sets the vbd device state to
XenbusStateClosing. The backend disconnects the real device/file, and any IO
requests to the disk in guest will end up in ether, leaving disk DEAD and set to
XenbusStateClosing. When the guest wants to disconnect the disk, umount will
hang on blkif_release()->xlvbd_release_gendisk() as it is unable to send any IO
to the disk, which prevents clean system shutdown.
Solution:
Don't disconnect backend until frontend state switched to XenbusStateClosed.
Signed-off-by: Joe Jin <joe.jin@oracle.com>
Cc: Daniel Stodden <daniel.stodden@citrix.com>
Cc: Jens Axboe <jaxboe@fusionio.com>
Cc: Annie Li <annie.li@oracle.com>
Cc: Ian Campbell <Ian.Campbell@eu.citrix.com>
[v1: Modified description a bit]
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
2011-08-15 08:51:31 +04:00
|
|
|
xen_blkif_disconnect(be->blkif);
|
2011-04-15 02:25:47 +04:00
|
|
|
xenbus_switch_state(dev, XenbusStateClosed);
|
|
|
|
if (xenbus_dev_is_online(dev))
|
|
|
|
break;
|
2017-08-18 02:23:10 +03:00
|
|
|
/* fall through */
|
|
|
|
/* if not online */
|
2011-04-15 02:25:47 +04:00
|
|
|
case XenbusStateUnknown:
|
2011-08-15 08:57:07 +04:00
|
|
|
/* implies xen_blkif_disconnect() via xen_blkbk_remove() */
|
2011-04-15 02:25:47 +04:00
|
|
|
device_unregister(&dev->dev);
|
|
|
|
break;
|
|
|
|
|
|
|
|
default:
|
|
|
|
xenbus_dev_fatal(dev, -EINVAL, "saw state %d at frontend",
|
|
|
|
frontend_state);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
xen/blkback: Squeeze page pools if a memory pressure is detected
Each `blkif` has a free pages pool for the grant mapping. The size of
the pool starts from zero and is increased on demand while processing
the I/O requests. If current I/O requests handling is finished or 100
milliseconds has passed since last I/O requests handling, it checks and
shrinks the pool to not exceed the size limit, `max_buffer_pages`.
Therefore, host administrators can cause memory pressure in blkback by
attaching a large number of block devices and inducing I/O. Such
problematic situations can be avoided by limiting the maximum number of
devices that can be attached, but finding the optimal limit is not so
easy. Improper set of the limit can results in memory pressure or a
resource underutilization. This commit avoids such problematic
situations by squeezing the pools (returns every free page in the pool
to the system) for a while (users can set this duration via a module
parameter) if memory pressure is detected.
Discussions
===========
The `blkback`'s original shrinking mechanism returns only pages in the
pool which are not currently be used by `blkback` to the system. In
other words, the pages that are not mapped with granted pages. Because
this commit is changing only the shrink limit but still uses the same
freeing mechanism it does not touch pages which are currently mapping
grants.
Once memory pressure is detected, this commit keeps the squeezing limit
for a user-specified time duration. The duration should be neither too
long nor too short. If it is too long, the squeezing incurring overhead
can reduce the I/O performance. If it is too short, `blkback` will not
free enough pages to reduce the memory pressure. This commit sets the
value as `10 milliseconds` by default because it is a short time in
terms of I/O while it is a long time in terms of memory operations.
Also, as the original shrinking mechanism works for at least every 100
milliseconds, this could be a somewhat reasonable choice. I also tested
other durations (refer to the below section for more details) and
confirmed that 10 milliseconds is the one that works best with the test.
That said, the proper duration depends on actual configurations and
workloads. That's why this commit allows users to set the duration as a
module parameter.
Memory Pressure Test
====================
To show how this commit fixes the memory pressure situation well, I
configured a test environment on a xen-running virtualization system.
On the `blkfront` running guest instances, I attach a large number of
network-backed volume devices and induce I/O to those. Meanwhile, I
measure the number of pages that swapped in (pswpin) and out (pswpout)
on the `blkback` running guest. The test ran twice, once for the
`blkback` before this commit and once for that after this commit. As
shown below, this commit has dramatically reduced the memory pressure:
pswpin pswpout
before 76,672 185,799
after 867 3,967
Optimal Aggressive Shrinking Duration
-------------------------------------
To find a best squeezing duration, I repeated the test with three
different durations (1ms, 10ms, and 100ms). The results are as below:
duration pswpin pswpout
1 707 5,095
10 867 3,967
100 362 3,348
As expected, the memory pressure decreases as the duration increases,
but the reduction become slow from the `10ms`. Based on this results, I
chose the default duration as 10ms.
Performance Overhead Test
=========================
This commit could incur I/O performance degradation under severe memory
pressure because the squeezing will require more page allocations per
I/O. To show the overhead, I artificially made a worst-case squeezing
situation and measured the I/O performance of a `blkfront` running
guest.
For the artificial squeezing, I set the `blkback.max_buffer_pages` using
the `/sys/module/xen_blkback/parameters/max_buffer_pages` file. In this
test, I set the value to `1024` and `0`. The `1024` is the default
value. Setting the value as `0` is same to a situation doing the
squeezing always (worst-case).
If the underlying block device is slow enough, the squeezing overhead
could be hidden. For the reason, I use a fast block device, namely the
rbd[1]:
# xl block-attach guest phy:/dev/ram0 xvdb w
For the I/O performance measurement, I run a simple `dd` command 5 times
directly to the device as below and collect the 'MB/s' results.
$ for i in {1..5}; do dd if=/dev/zero of=/dev/xvdb \
bs=4k count=$((256*512)); sync; done
The results are as below. 'max_pgs' represents the value of the
`blkback.max_buffer_pages` parameter.
max_pgs Min Max Median Avg Stddev
0 417 423 420 419.4 2.5099801
1024 414 425 416 417.8 4.4384682
No difference proven at 95.0% confidence
In short, even worst case squeezing on ramdisk based fast block device
makes no visible performance degradation. Please note that this is just
a very simple and minimal test. On systems using super-fast block
devices and a special I/O workload, the results might be different. If
you have any doubt, test on your machine with your workload to find the
optimal squeezing duration for you.
[1] https://www.kernel.org/doc/html/latest/admin-guide/blockdev/ramdisk.html
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
Signed-off-by: SeongJae Park <sjpark@amazon.de>
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
2020-01-27 11:18:10 +03:00
|
|
|
/* Once a memory pressure is detected, squeeze free page pools for a while. */
|
|
|
|
static unsigned int buffer_squeeze_duration_ms = 10;
|
|
|
|
module_param_named(buffer_squeeze_duration_ms,
|
|
|
|
buffer_squeeze_duration_ms, int, 0644);
|
|
|
|
MODULE_PARM_DESC(buffer_squeeze_duration_ms,
|
|
|
|
"Duration in ms to squeeze pages buffer when a memory pressure is detected");
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Callback received when the memory pressure is detected.
|
|
|
|
*/
|
|
|
|
static void reclaim_memory(struct xenbus_device *dev)
|
|
|
|
{
|
|
|
|
struct backend_info *be = dev_get_drvdata(&dev->dev);
|
|
|
|
|
|
|
|
if (!be)
|
|
|
|
return;
|
|
|
|
be->blkif->buffer_squeeze_end = jiffies +
|
|
|
|
msecs_to_jiffies(buffer_squeeze_duration_ms);
|
|
|
|
}
|
|
|
|
|
2011-04-15 02:25:47 +04:00
|
|
|
/* ** Connection ** */
|
|
|
|
|
2011-05-11 23:57:09 +04:00
|
|
|
/*
|
2011-04-15 02:25:47 +04:00
|
|
|
* Write the physical details regarding the block device to the store, and
|
|
|
|
* switch to Connected state.
|
|
|
|
*/
|
|
|
|
static void connect(struct backend_info *be)
|
|
|
|
{
|
|
|
|
struct xenbus_transaction xbt;
|
|
|
|
int err;
|
|
|
|
struct xenbus_device *dev = be->dev;
|
|
|
|
|
2015-04-01 18:04:22 +03:00
|
|
|
pr_debug("%s %s\n", __func__, dev->otherend);
|
2011-04-15 02:25:47 +04:00
|
|
|
|
|
|
|
/* Supply the information about the device the frontend needs */
|
|
|
|
again:
|
|
|
|
err = xenbus_transaction_start(&xbt);
|
|
|
|
if (err) {
|
|
|
|
xenbus_dev_fatal(dev, err, "starting transaction");
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2012-03-14 21:04:00 +04:00
|
|
|
/* If we can't advertise it is OK. */
|
|
|
|
xen_blkbk_flush_diskcache(xbt, be, be->blkif->vbd.flush_support);
|
2011-04-15 02:25:47 +04:00
|
|
|
|
2012-03-14 21:04:00 +04:00
|
|
|
xen_blkbk_discard(xbt, be);
|
2011-09-01 14:39:10 +04:00
|
|
|
|
2012-03-14 21:04:00 +04:00
|
|
|
xen_blkbk_barrier(xbt, be, be->blkif->vbd.flush_support);
|
2011-10-10 08:42:22 +04:00
|
|
|
|
xen/blkback: Persistent grant maps for xen blk drivers
This patch implements persistent grants for the xen-blk{front,back}
mechanism. The effect of this change is to reduce the number of unmap
operations performed, since they cause a (costly) TLB shootdown. This
allows the I/O performance to scale better when a large number of VMs
are performing I/O.
Previously, the blkfront driver was supplied a bvec[] from the request
queue. This was granted to dom0; dom0 performed the I/O and wrote
directly into the grant-mapped memory and unmapped it; blkfront then
removed foreign access for that grant. The cost of unmapping scales
badly with the number of CPUs in Dom0. An experiment showed that when
Dom0 has 24 VCPUs, and guests are performing parallel I/O to a
ramdisk, the IPIs from performing unmap's is a bottleneck at 5 guests
(at which point 650,000 IOPS are being performed in total). If more
than 5 guests are used, the performance declines. By 10 guests, only
400,000 IOPS are being performed.
This patch improves performance by only unmapping when the connection
between blkfront and back is broken.
On startup blkfront notifies blkback that it is using persistent
grants, and blkback will do the same. If blkback is not capable of
persistent mapping, blkfront will still use the same grants, since it
is compatible with the previous protocol, and simplifies the code
complexity in blkfront.
To perform a read, in persistent mode, blkfront uses a separate pool
of pages that it maps to dom0. When a request comes in, blkfront
transmutes the request so that blkback will write into one of these
free pages. Blkback keeps note of which grefs it has already
mapped. When a new ring request comes to blkback, it looks to see if
it has already mapped that page. If so, it will not map it again. If
the page hasn't been previously mapped, it is mapped now, and a record
is kept of this mapping. Blkback proceeds as usual. When blkfront is
notified that blkback has completed a request, it memcpy's from the
shared memory, into the bvec supplied. A record that the {gref, page}
tuple is mapped, and not inflight is kept.
Writes are similar, except that the memcpy is peformed from the
supplied bvecs, into the shared pages, before the request is put onto
the ring.
Blkback stores a mapping of grefs=>{page mapped to by gref} in
a red-black tree. As the grefs are not known apriori, and provide no
guarantees on their ordering, we have to perform a search
through this tree to find the page, for every gref we receive. This
operation takes O(log n) time in the worst case. In blkfront grants
are stored using a single linked list.
The maximum number of grants that blkback will persistenly map is
currently set to RING_SIZE * BLKIF_MAX_SEGMENTS_PER_REQUEST, to
prevent a malicios guest from attempting a DoS, by supplying fresh
grefs, causing the Dom0 kernel to map excessively. If a guest
is using persistent grants and exceeds the maximum number of grants to
map persistenly the newly passed grefs will be mapped and unmaped.
Using this approach, we can have requests that mix persistent and
non-persistent grants, and we need to handle them correctly.
This allows us to set the maximum number of persistent grants to a
lower value than RING_SIZE * BLKIF_MAX_SEGMENTS_PER_REQUEST, although
setting it will lead to unpredictable performance.
In writing this patch, the question arrises as to if the additional
cost of performing memcpys in the guest (to/from the pool of granted
pages) outweigh the gains of not performing TLB shootdowns. The answer
to that question is `no'. There appears to be very little, if any
additional cost to the guest of using persistent grants. There is
perhaps a small saving, from the reduced number of hypercalls
performed in granting, and ending foreign access.
Signed-off-by: Oliver Chick <oliver.chick@citrix.com>
Signed-off-by: Roger Pau Monne <roger.pau@citrix.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
[v1: Fixed up the misuse of bool as int]
2012-10-24 20:58:45 +04:00
|
|
|
err = xenbus_printf(xbt, dev->nodename, "feature-persistent", "%u", 1);
|
|
|
|
if (err) {
|
|
|
|
xenbus_dev_fatal(dev, err, "writing %s/feature-persistent",
|
|
|
|
dev->nodename);
|
|
|
|
goto abort;
|
|
|
|
}
|
|
|
|
|
2011-04-15 02:25:47 +04:00
|
|
|
err = xenbus_printf(xbt, dev->nodename, "sectors", "%llu",
|
2011-04-20 19:21:43 +04:00
|
|
|
(unsigned long long)vbd_sz(&be->blkif->vbd));
|
2011-04-15 02:25:47 +04:00
|
|
|
if (err) {
|
|
|
|
xenbus_dev_fatal(dev, err, "writing %s/sectors",
|
|
|
|
dev->nodename);
|
|
|
|
goto abort;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* FIXME: use a typename instead */
|
|
|
|
err = xenbus_printf(xbt, dev->nodename, "info", "%u",
|
2011-04-20 19:21:43 +04:00
|
|
|
be->blkif->vbd.type |
|
|
|
|
(be->blkif->vbd.readonly ? VDISK_READONLY : 0));
|
2011-04-15 02:25:47 +04:00
|
|
|
if (err) {
|
|
|
|
xenbus_dev_fatal(dev, err, "writing %s/info",
|
|
|
|
dev->nodename);
|
|
|
|
goto abort;
|
|
|
|
}
|
|
|
|
err = xenbus_printf(xbt, dev->nodename, "sector-size", "%lu",
|
2011-04-20 19:21:43 +04:00
|
|
|
(unsigned long)
|
|
|
|
bdev_logical_block_size(be->blkif->vbd.bdev));
|
2011-04-15 02:25:47 +04:00
|
|
|
if (err) {
|
|
|
|
xenbus_dev_fatal(dev, err, "writing %s/sector-size",
|
|
|
|
dev->nodename);
|
|
|
|
goto abort;
|
|
|
|
}
|
2013-05-13 18:28:15 +04:00
|
|
|
err = xenbus_printf(xbt, dev->nodename, "physical-sector-size", "%u",
|
|
|
|
bdev_physical_block_size(be->blkif->vbd.bdev));
|
|
|
|
if (err)
|
|
|
|
xenbus_dev_error(dev, err, "writing %s/physical-sector-size",
|
|
|
|
dev->nodename);
|
2011-04-15 02:25:47 +04:00
|
|
|
|
|
|
|
err = xenbus_transaction_end(xbt, 0);
|
|
|
|
if (err == -EAGAIN)
|
|
|
|
goto again;
|
|
|
|
if (err)
|
|
|
|
xenbus_dev_fatal(dev, err, "ending transaction");
|
|
|
|
|
|
|
|
err = xenbus_switch_state(dev, XenbusStateConnected);
|
|
|
|
if (err)
|
2011-06-12 20:21:13 +04:00
|
|
|
xenbus_dev_fatal(dev, err, "%s: switching to Connected state",
|
2011-04-15 02:25:47 +04:00
|
|
|
dev->nodename);
|
|
|
|
|
|
|
|
return;
|
|
|
|
abort:
|
|
|
|
xenbus_transaction_end(xbt, 1);
|
|
|
|
}
|
|
|
|
|
2015-12-11 20:08:48 +03:00
|
|
|
/*
|
|
|
|
* Each ring may have multi pages, depends on "ring-page-order".
|
|
|
|
*/
|
|
|
|
static int read_per_ring_refs(struct xen_blkif_ring *ring, const char *dir)
|
2011-04-15 02:25:47 +04:00
|
|
|
{
|
2015-10-13 19:50:11 +03:00
|
|
|
unsigned int ring_ref[XENBUS_MAX_RING_GRANTS];
|
2015-06-03 08:40:01 +03:00
|
|
|
struct pending_req *req, *n;
|
|
|
|
int err, i, j;
|
2015-12-11 20:08:48 +03:00
|
|
|
struct xen_blkif *blkif = ring->blkif;
|
|
|
|
struct xenbus_device *dev = blkif->be->dev;
|
2019-02-24 18:17:27 +03:00
|
|
|
unsigned int nr_grefs, evtchn;
|
2011-04-15 02:25:47 +04:00
|
|
|
|
2015-12-11 20:08:48 +03:00
|
|
|
err = xenbus_scanf(XBT_NIL, dir, "event-channel", "%u",
|
2015-06-03 08:40:03 +03:00
|
|
|
&evtchn);
|
|
|
|
if (err != 1) {
|
|
|
|
err = -EINVAL;
|
2015-12-11 20:08:48 +03:00
|
|
|
xenbus_dev_fatal(dev, err, "reading %s/event-channel", dir);
|
2011-04-15 02:25:47 +04:00
|
|
|
return err;
|
|
|
|
}
|
2015-06-03 08:40:03 +03:00
|
|
|
|
2019-02-24 18:17:27 +03:00
|
|
|
nr_grefs = blkif->nr_ring_pages;
|
|
|
|
|
|
|
|
if (unlikely(!nr_grefs)) {
|
|
|
|
WARN_ON(true);
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
for (i = 0; i < nr_grefs; i++) {
|
|
|
|
char ring_ref_name[RINGREF_NAME_LEN];
|
|
|
|
|
|
|
|
snprintf(ring_ref_name, RINGREF_NAME_LEN, "ring-ref%u", i);
|
|
|
|
err = xenbus_scanf(XBT_NIL, dir, ring_ref_name,
|
|
|
|
"%u", &ring_ref[i]);
|
|
|
|
|
2015-06-03 08:40:03 +03:00
|
|
|
if (err != 1) {
|
2019-02-24 18:17:27 +03:00
|
|
|
if (nr_grefs == 1)
|
|
|
|
break;
|
|
|
|
|
2015-06-03 08:40:03 +03:00
|
|
|
err = -EINVAL;
|
2019-02-24 18:17:27 +03:00
|
|
|
xenbus_dev_fatal(dev, err, "reading %s/%s",
|
|
|
|
dir, ring_ref_name);
|
2015-06-03 08:40:03 +03:00
|
|
|
return err;
|
|
|
|
}
|
2019-02-24 18:17:27 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
if (err != 1) {
|
|
|
|
WARN_ON(nr_grefs != 1);
|
2015-06-03 08:40:03 +03:00
|
|
|
|
2019-02-24 18:17:27 +03:00
|
|
|
err = xenbus_scanf(XBT_NIL, dir, "ring-ref", "%u",
|
|
|
|
&ring_ref[0]);
|
|
|
|
if (err != 1) {
|
2015-06-03 08:40:03 +03:00
|
|
|
err = -EINVAL;
|
2019-02-24 18:17:27 +03:00
|
|
|
xenbus_dev_fatal(dev, err, "reading %s/ring-ref", dir);
|
2015-06-03 08:40:03 +03:00
|
|
|
return err;
|
|
|
|
}
|
|
|
|
}
|
2011-04-15 02:25:47 +04:00
|
|
|
|
2019-08-11 20:23:22 +03:00
|
|
|
err = -ENOMEM;
|
2015-06-03 08:40:03 +03:00
|
|
|
for (i = 0; i < nr_grefs * XEN_BLKIF_REQS_PER_PAGE; i++) {
|
2015-06-03 08:40:01 +03:00
|
|
|
req = kzalloc(sizeof(*req), GFP_KERNEL);
|
|
|
|
if (!req)
|
|
|
|
goto fail;
|
2015-11-14 06:12:15 +03:00
|
|
|
list_add_tail(&req->free_list, &ring->pending_free);
|
2015-06-03 08:40:01 +03:00
|
|
|
for (j = 0; j < MAX_INDIRECT_SEGMENTS; j++) {
|
|
|
|
req->segments[j] = kzalloc(sizeof(*req->segments[0]), GFP_KERNEL);
|
|
|
|
if (!req->segments[j])
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
for (j = 0; j < MAX_INDIRECT_PAGES; j++) {
|
|
|
|
req->indirect_pages[j] = kzalloc(sizeof(*req->indirect_pages[0]),
|
|
|
|
GFP_KERNEL);
|
|
|
|
if (!req->indirect_pages[j])
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2011-04-15 02:25:47 +04:00
|
|
|
/* Map the shared frame, irq etc. */
|
2015-11-14 06:12:15 +03:00
|
|
|
err = xen_blkif_map(ring, ring_ref, nr_grefs, evtchn);
|
2011-04-15 02:25:47 +04:00
|
|
|
if (err) {
|
2015-06-03 08:40:03 +03:00
|
|
|
xenbus_dev_fatal(dev, err, "mapping ring-ref port %u", evtchn);
|
2019-08-11 20:23:22 +03:00
|
|
|
goto fail;
|
2011-04-15 02:25:47 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
2015-06-03 08:40:01 +03:00
|
|
|
|
|
|
|
fail:
|
2015-11-14 06:12:15 +03:00
|
|
|
list_for_each_entry_safe(req, n, &ring->pending_free, free_list) {
|
2015-06-03 08:40:01 +03:00
|
|
|
list_del(&req->free_list);
|
|
|
|
for (j = 0; j < MAX_INDIRECT_SEGMENTS; j++) {
|
|
|
|
if (!req->segments[j])
|
|
|
|
break;
|
|
|
|
kfree(req->segments[j]);
|
|
|
|
}
|
|
|
|
for (j = 0; j < MAX_INDIRECT_PAGES; j++) {
|
|
|
|
if (!req->indirect_pages[j])
|
|
|
|
break;
|
|
|
|
kfree(req->indirect_pages[j]);
|
|
|
|
}
|
|
|
|
kfree(req);
|
|
|
|
}
|
2019-08-11 20:23:22 +03:00
|
|
|
return err;
|
2015-12-11 20:08:48 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
static int connect_ring(struct backend_info *be)
|
|
|
|
{
|
|
|
|
struct xenbus_device *dev = be->dev;
|
2019-01-14 19:41:43 +03:00
|
|
|
struct xen_blkif *blkif = be->blkif;
|
2015-12-11 20:08:48 +03:00
|
|
|
unsigned int pers_grants;
|
|
|
|
char protocol[64] = "";
|
|
|
|
int err, i;
|
|
|
|
char *xspath;
|
|
|
|
size_t xspathsize;
|
|
|
|
const size_t xenstore_path_ext_size = 11; /* sufficient for "/queue-NNN" */
|
2015-11-14 06:12:17 +03:00
|
|
|
unsigned int requested_num_queues = 0;
|
2019-02-24 18:17:27 +03:00
|
|
|
unsigned int ring_page_order;
|
2015-12-11 20:08:48 +03:00
|
|
|
|
|
|
|
pr_debug("%s %s\n", __func__, dev->otherend);
|
|
|
|
|
2019-01-14 19:41:43 +03:00
|
|
|
blkif->blk_protocol = BLKIF_PROTOCOL_DEFAULT;
|
2016-07-07 11:05:21 +03:00
|
|
|
err = xenbus_scanf(XBT_NIL, dev->otherend, "protocol",
|
|
|
|
"%63s", protocol);
|
|
|
|
if (err <= 0)
|
2015-12-11 20:08:48 +03:00
|
|
|
strcpy(protocol, "unspecified, assuming default");
|
|
|
|
else if (0 == strcmp(protocol, XEN_IO_PROTO_ABI_NATIVE))
|
2019-01-14 19:41:43 +03:00
|
|
|
blkif->blk_protocol = BLKIF_PROTOCOL_NATIVE;
|
2015-12-11 20:08:48 +03:00
|
|
|
else if (0 == strcmp(protocol, XEN_IO_PROTO_ABI_X86_32))
|
2019-01-14 19:41:43 +03:00
|
|
|
blkif->blk_protocol = BLKIF_PROTOCOL_X86_32;
|
2015-12-11 20:08:48 +03:00
|
|
|
else if (0 == strcmp(protocol, XEN_IO_PROTO_ABI_X86_64))
|
2019-01-14 19:41:43 +03:00
|
|
|
blkif->blk_protocol = BLKIF_PROTOCOL_X86_64;
|
2015-12-11 20:08:48 +03:00
|
|
|
else {
|
|
|
|
xenbus_dev_fatal(dev, err, "unknown fe protocol %s", protocol);
|
2015-11-25 21:07:39 +03:00
|
|
|
return -ENOSYS;
|
2015-12-11 20:08:48 +03:00
|
|
|
}
|
2016-10-31 16:58:40 +03:00
|
|
|
pers_grants = xenbus_read_unsigned(dev->otherend, "feature-persistent",
|
|
|
|
0);
|
2019-01-14 19:41:43 +03:00
|
|
|
blkif->vbd.feature_gnt_persistent = pers_grants;
|
|
|
|
blkif->vbd.overflow_max_grants = 0;
|
2015-12-11 20:08:48 +03:00
|
|
|
|
2015-11-14 06:12:17 +03:00
|
|
|
/*
|
|
|
|
* Read the number of hardware queues from frontend.
|
|
|
|
*/
|
2016-10-31 16:58:40 +03:00
|
|
|
requested_num_queues = xenbus_read_unsigned(dev->otherend,
|
|
|
|
"multi-queue-num-queues",
|
|
|
|
1);
|
|
|
|
if (requested_num_queues > xenblk_max_queues
|
|
|
|
|| requested_num_queues == 0) {
|
|
|
|
/* Buggy or malicious guest. */
|
|
|
|
xenbus_dev_fatal(dev, err,
|
|
|
|
"guest requested %u queues, exceeding the maximum of %u.",
|
|
|
|
requested_num_queues, xenblk_max_queues);
|
|
|
|
return -ENOSYS;
|
2015-11-14 06:12:17 +03:00
|
|
|
}
|
2019-01-14 19:41:43 +03:00
|
|
|
blkif->nr_rings = requested_num_queues;
|
|
|
|
if (xen_blkif_alloc_rings(blkif))
|
2015-11-14 06:12:17 +03:00
|
|
|
return -ENOMEM;
|
|
|
|
|
2015-12-11 20:08:48 +03:00
|
|
|
pr_info("%s: using %d queues, protocol %d (%s) %s\n", dev->nodename,
|
2019-01-14 19:41:43 +03:00
|
|
|
blkif->nr_rings, blkif->blk_protocol, protocol,
|
2015-12-11 20:08:48 +03:00
|
|
|
pers_grants ? "persistent grants" : "");
|
|
|
|
|
2019-02-24 18:17:27 +03:00
|
|
|
ring_page_order = xenbus_read_unsigned(dev->otherend,
|
|
|
|
"ring-page-order", 0);
|
|
|
|
|
|
|
|
if (ring_page_order > xen_blkif_max_ring_order) {
|
|
|
|
err = -EINVAL;
|
|
|
|
xenbus_dev_fatal(dev, err,
|
|
|
|
"requested ring page order %d exceed max:%d",
|
|
|
|
ring_page_order,
|
|
|
|
xen_blkif_max_ring_order);
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
blkif->nr_ring_pages = 1 << ring_page_order;
|
|
|
|
|
2019-01-14 19:41:43 +03:00
|
|
|
if (blkif->nr_rings == 1)
|
|
|
|
return read_per_ring_refs(&blkif->rings[0], dev->otherend);
|
2015-12-11 20:08:48 +03:00
|
|
|
else {
|
|
|
|
xspathsize = strlen(dev->otherend) + xenstore_path_ext_size;
|
|
|
|
xspath = kmalloc(xspathsize, GFP_KERNEL);
|
|
|
|
if (!xspath) {
|
|
|
|
xenbus_dev_fatal(dev, -ENOMEM, "reading ring references");
|
|
|
|
return -ENOMEM;
|
|
|
|
}
|
|
|
|
|
2019-01-14 19:41:43 +03:00
|
|
|
for (i = 0; i < blkif->nr_rings; i++) {
|
2015-12-11 20:08:48 +03:00
|
|
|
memset(xspath, 0, xspathsize);
|
|
|
|
snprintf(xspath, xspathsize, "%s/queue-%u", dev->otherend, i);
|
2019-01-14 19:41:43 +03:00
|
|
|
err = read_per_ring_refs(&blkif->rings[i], xspath);
|
2015-12-11 20:08:48 +03:00
|
|
|
if (err) {
|
|
|
|
kfree(xspath);
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
kfree(xspath);
|
|
|
|
}
|
|
|
|
return 0;
|
2011-04-15 02:25:47 +04:00
|
|
|
}
|
|
|
|
|
2011-04-20 19:50:43 +04:00
|
|
|
static const struct xenbus_device_id xen_blkbk_ids[] = {
|
2011-04-15 02:25:47 +04:00
|
|
|
{ "vbd" },
|
|
|
|
{ "" }
|
|
|
|
};
|
|
|
|
|
2014-09-08 20:30:41 +04:00
|
|
|
static struct xenbus_driver xen_blkbk_driver = {
|
|
|
|
.ids = xen_blkbk_ids,
|
2011-04-20 19:50:43 +04:00
|
|
|
.probe = xen_blkbk_probe,
|
|
|
|
.remove = xen_blkbk_remove,
|
2019-12-11 18:29:56 +03:00
|
|
|
.otherend_changed = frontend_changed,
|
|
|
|
.allow_rebind = true,
|
xen/blkback: Squeeze page pools if a memory pressure is detected
Each `blkif` has a free pages pool for the grant mapping. The size of
the pool starts from zero and is increased on demand while processing
the I/O requests. If current I/O requests handling is finished or 100
milliseconds has passed since last I/O requests handling, it checks and
shrinks the pool to not exceed the size limit, `max_buffer_pages`.
Therefore, host administrators can cause memory pressure in blkback by
attaching a large number of block devices and inducing I/O. Such
problematic situations can be avoided by limiting the maximum number of
devices that can be attached, but finding the optimal limit is not so
easy. Improper set of the limit can results in memory pressure or a
resource underutilization. This commit avoids such problematic
situations by squeezing the pools (returns every free page in the pool
to the system) for a while (users can set this duration via a module
parameter) if memory pressure is detected.
Discussions
===========
The `blkback`'s original shrinking mechanism returns only pages in the
pool which are not currently be used by `blkback` to the system. In
other words, the pages that are not mapped with granted pages. Because
this commit is changing only the shrink limit but still uses the same
freeing mechanism it does not touch pages which are currently mapping
grants.
Once memory pressure is detected, this commit keeps the squeezing limit
for a user-specified time duration. The duration should be neither too
long nor too short. If it is too long, the squeezing incurring overhead
can reduce the I/O performance. If it is too short, `blkback` will not
free enough pages to reduce the memory pressure. This commit sets the
value as `10 milliseconds` by default because it is a short time in
terms of I/O while it is a long time in terms of memory operations.
Also, as the original shrinking mechanism works for at least every 100
milliseconds, this could be a somewhat reasonable choice. I also tested
other durations (refer to the below section for more details) and
confirmed that 10 milliseconds is the one that works best with the test.
That said, the proper duration depends on actual configurations and
workloads. That's why this commit allows users to set the duration as a
module parameter.
Memory Pressure Test
====================
To show how this commit fixes the memory pressure situation well, I
configured a test environment on a xen-running virtualization system.
On the `blkfront` running guest instances, I attach a large number of
network-backed volume devices and induce I/O to those. Meanwhile, I
measure the number of pages that swapped in (pswpin) and out (pswpout)
on the `blkback` running guest. The test ran twice, once for the
`blkback` before this commit and once for that after this commit. As
shown below, this commit has dramatically reduced the memory pressure:
pswpin pswpout
before 76,672 185,799
after 867 3,967
Optimal Aggressive Shrinking Duration
-------------------------------------
To find a best squeezing duration, I repeated the test with three
different durations (1ms, 10ms, and 100ms). The results are as below:
duration pswpin pswpout
1 707 5,095
10 867 3,967
100 362 3,348
As expected, the memory pressure decreases as the duration increases,
but the reduction become slow from the `10ms`. Based on this results, I
chose the default duration as 10ms.
Performance Overhead Test
=========================
This commit could incur I/O performance degradation under severe memory
pressure because the squeezing will require more page allocations per
I/O. To show the overhead, I artificially made a worst-case squeezing
situation and measured the I/O performance of a `blkfront` running
guest.
For the artificial squeezing, I set the `blkback.max_buffer_pages` using
the `/sys/module/xen_blkback/parameters/max_buffer_pages` file. In this
test, I set the value to `1024` and `0`. The `1024` is the default
value. Setting the value as `0` is same to a situation doing the
squeezing always (worst-case).
If the underlying block device is slow enough, the squeezing overhead
could be hidden. For the reason, I use a fast block device, namely the
rbd[1]:
# xl block-attach guest phy:/dev/ram0 xvdb w
For the I/O performance measurement, I run a simple `dd` command 5 times
directly to the device as below and collect the 'MB/s' results.
$ for i in {1..5}; do dd if=/dev/zero of=/dev/xvdb \
bs=4k count=$((256*512)); sync; done
The results are as below. 'max_pgs' represents the value of the
`blkback.max_buffer_pages` parameter.
max_pgs Min Max Median Avg Stddev
0 417 423 420 419.4 2.5099801
1024 414 425 416 417.8 4.4384682
No difference proven at 95.0% confidence
In short, even worst case squeezing on ramdisk based fast block device
makes no visible performance degradation. Please note that this is just
a very simple and minimal test. On systems using super-fast block
devices and a special I/O workload, the results might be different. If
you have any doubt, test on your machine with your workload to find the
optimal squeezing duration for you.
[1] https://www.kernel.org/doc/html/latest/admin-guide/blockdev/ramdisk.html
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
Signed-off-by: SeongJae Park <sjpark@amazon.de>
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
2020-01-27 11:18:10 +03:00
|
|
|
.reclaim_memory = reclaim_memory,
|
2014-09-08 20:30:41 +04:00
|
|
|
};
|
2011-04-15 02:25:47 +04:00
|
|
|
|
2011-04-20 19:50:43 +04:00
|
|
|
int xen_blkif_xenbus_init(void)
|
2011-04-15 02:25:47 +04:00
|
|
|
{
|
2011-12-22 13:08:13 +04:00
|
|
|
return xenbus_register_backend(&xen_blkbk_driver);
|
2011-04-15 02:25:47 +04:00
|
|
|
}
|
2019-12-02 14:41:17 +03:00
|
|
|
|
|
|
|
void xen_blkif_xenbus_fini(void)
|
|
|
|
{
|
|
|
|
xenbus_unregister_driver(&xen_blkbk_driver);
|
|
|
|
}
|