License cleanup: add SPDX GPL-2.0 license identifier to files with no license
Many source files in the tree are missing licensing information, which
makes it harder for compliance tools to determine the correct license.
By default all files without license information are under the default
license of the kernel, which is GPL version 2.
Update the files which contain no license information with the 'GPL-2.0'
SPDX license identifier. The SPDX identifier is a legally binding
shorthand, which can be used instead of the full boiler plate text.
This patch is based on work done by Thomas Gleixner and Kate Stewart and
Philippe Ombredanne.
How this work was done:
Patches were generated and checked against linux-4.14-rc6 for a subset of
the use cases:
- file had no licensing information it it.
- file was a */uapi/* one with no licensing information in it,
- file was a */uapi/* one with existing licensing information,
Further patches will be generated in subsequent months to fix up cases
where non-standard license headers were used, and references to license
had to be inferred by heuristics based on keywords.
The analysis to determine which SPDX License Identifier to be applied to
a file was done in a spreadsheet of side by side results from of the
output of two independent scanners (ScanCode & Windriver) producing SPDX
tag:value files created by Philippe Ombredanne. Philippe prepared the
base worksheet, and did an initial spot review of a few 1000 files.
The 4.13 kernel was the starting point of the analysis with 60,537 files
assessed. Kate Stewart did a file by file comparison of the scanner
results in the spreadsheet to determine which SPDX license identifier(s)
to be applied to the file. She confirmed any determination that was not
immediately clear with lawyers working with the Linux Foundation.
Criteria used to select files for SPDX license identifier tagging was:
- Files considered eligible had to be source code files.
- Make and config files were included as candidates if they contained >5
lines of source
- File already had some variant of a license header in it (even if <5
lines).
All documentation files were explicitly excluded.
The following heuristics were used to determine which SPDX license
identifiers to apply.
- when both scanners couldn't find any license traces, file was
considered to have no license information in it, and the top level
COPYING file license applied.
For non */uapi/* files that summary was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 11139
and resulted in the first patch in this series.
If that file was a */uapi/* path one, it was "GPL-2.0 WITH
Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 WITH Linux-syscall-note 930
and resulted in the second patch in this series.
- if a file had some form of licensing information in it, and was one
of the */uapi/* ones, it was denoted with the Linux-syscall-note if
any GPL family license was found in the file or had no licensing in
it (per prior point). Results summary:
SPDX license identifier # files
---------------------------------------------------|------
GPL-2.0 WITH Linux-syscall-note 270
GPL-2.0+ WITH Linux-syscall-note 169
((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21
((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17
LGPL-2.1+ WITH Linux-syscall-note 15
GPL-1.0+ WITH Linux-syscall-note 14
((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5
LGPL-2.0+ WITH Linux-syscall-note 4
LGPL-2.1 WITH Linux-syscall-note 3
((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3
((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1
and that resulted in the third patch in this series.
- when the two scanners agreed on the detected license(s), that became
the concluded license(s).
- when there was disagreement between the two scanners (one detected a
license but the other didn't, or they both detected different
licenses) a manual inspection of the file occurred.
- In most cases a manual inspection of the information in the file
resulted in a clear resolution of the license that should apply (and
which scanner probably needed to revisit its heuristics).
- When it was not immediately clear, the license identifier was
confirmed with lawyers working with the Linux Foundation.
- If there was any question as to the appropriate license identifier,
the file was flagged for further research and to be revisited later
in time.
In total, over 70 hours of logged manual review was done on the
spreadsheet to determine the SPDX license identifiers to apply to the
source files by Kate, Philippe, Thomas and, in some cases, confirmation
by lawyers working with the Linux Foundation.
Kate also obtained a third independent scan of the 4.13 code base from
FOSSology, and compared selected files where the other two scanners
disagreed against that SPDX file, to see if there was new insights. The
Windriver scanner is based on an older version of FOSSology in part, so
they are related.
Thomas did random spot checks in about 500 files from the spreadsheets
for the uapi headers and agreed with SPDX license identifier in the
files he inspected. For the non-uapi files Thomas did random spot checks
in about 15000 files.
In initial set of patches against 4.14-rc6, 3 files were found to have
copy/paste license identifier errors, and have been fixed to reflect the
correct identifier.
Additionally Philippe spent 10 hours this week doing a detailed manual
inspection and review of the 12,461 patched files from the initial patch
version early this week with:
- a full scancode scan run, collecting the matched texts, detected
license ids and scores
- reviewing anything where there was a license detected (about 500+
files) to ensure that the applied SPDX license was correct
- reviewing anything where there was no detection but the patch license
was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied
SPDX license was correct
This produced a worksheet with 20 files needing minor correction. This
worksheet was then exported into 3 different .csv files for the
different types of files to be modified.
These .csv files were then reviewed by Greg. Thomas wrote a script to
parse the csv files and add the proper SPDX tag to the file, in the
format that the file expected. This script was further refined by Greg
based on the output to detect more types of files automatically and to
distinguish between header and source .c files (which need different
comment types.) Finally Greg ran the script using the .csv files to
generate the patches.
Reviewed-by: Kate Stewart <kstewart@linuxfoundation.org>
Reviewed-by: Philippe Ombredanne <pombredanne@nexb.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-11-01 17:07:57 +03:00
|
|
|
/* SPDX-License-Identifier: GPL-2.0 */
|
2009-10-06 22:31:11 +04:00
|
|
|
#ifndef _FS_CEPH_MON_CLIENT_H
|
|
|
|
#define _FS_CEPH_MON_CLIENT_H
|
|
|
|
|
|
|
|
#include <linux/completion.h>
|
2010-03-25 07:43:33 +03:00
|
|
|
#include <linux/kref.h>
|
2010-02-16 01:47:28 +03:00
|
|
|
#include <linux/rbtree.h>
|
2009-10-06 22:31:11 +04:00
|
|
|
|
2012-10-02 21:01:25 +04:00
|
|
|
#include <linux/ceph/messenger.h>
|
2009-10-06 22:31:11 +04:00
|
|
|
|
|
|
|
struct ceph_client;
|
|
|
|
struct ceph_mount_args;
|
2009-11-19 03:19:57 +03:00
|
|
|
struct ceph_auth_client;
|
2009-10-06 22:31:11 +04:00
|
|
|
|
|
|
|
/*
|
|
|
|
* The monitor map enumerates the set of all monitors.
|
|
|
|
*/
|
|
|
|
struct ceph_monmap {
|
|
|
|
struct ceph_fsid fsid;
|
|
|
|
u32 epoch;
|
|
|
|
u32 num_mon;
|
libceph, rbd: replace zero-length array with flexible-array
The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:
struct foo {
int stuff;
struct boo array[];
};
By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.
Also, notice that, dynamic memory allocations won't be affected by
this change:
"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]
sizeof(flexible-array-member) triggers a warning because flexible array
members have incomplete type[1]. There are some instances of code in
which the sizeof operator is being incorrectly/erroneously applied to
zero-length arrays and the result is zero. Such instances may be hiding
some bugs. So, this work (flexible-array member conversions) will also
help to get completely rid of those sorts of issues.
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2020-05-07 21:51:38 +03:00
|
|
|
struct ceph_entity_inst mon_inst[];
|
2009-10-06 22:31:11 +04:00
|
|
|
};
|
|
|
|
|
|
|
|
struct ceph_mon_client;
|
2010-04-23 02:40:37 +04:00
|
|
|
struct ceph_mon_generic_request;
|
2009-10-06 22:31:11 +04:00
|
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Generic mechanism for resending monitor requests.
|
|
|
|
*/
|
|
|
|
typedef void (*ceph_monc_request_func_t)(struct ceph_mon_client *monc,
|
|
|
|
int newmon);
|
|
|
|
|
|
|
|
/* a pending monitor request */
|
|
|
|
struct ceph_mon_request {
|
|
|
|
struct ceph_mon_client *monc;
|
|
|
|
struct delayed_work delayed_work;
|
|
|
|
unsigned long delay;
|
|
|
|
ceph_monc_request_func_t do_request;
|
|
|
|
};
|
|
|
|
|
2016-04-28 17:07:27 +03:00
|
|
|
typedef void (*ceph_monc_callback_t)(struct ceph_mon_generic_request *);
|
|
|
|
|
2009-10-06 22:31:11 +04:00
|
|
|
/*
|
2014-12-22 19:14:26 +03:00
|
|
|
* ceph_mon_generic_request is being used for the statfs and
|
2014-05-13 11:19:26 +04:00
|
|
|
* mon_get_version requests which are being done a bit differently
|
|
|
|
* because we need to get data back to the caller
|
2009-10-06 22:31:11 +04:00
|
|
|
*/
|
2010-04-23 02:40:37 +04:00
|
|
|
struct ceph_mon_generic_request {
|
2016-04-28 17:07:27 +03:00
|
|
|
struct ceph_mon_client *monc;
|
2010-03-25 07:43:33 +03:00
|
|
|
struct kref kref;
|
2009-10-06 22:31:11 +04:00
|
|
|
u64 tid;
|
2010-02-16 01:47:28 +03:00
|
|
|
struct rb_node node;
|
2009-10-06 22:31:11 +04:00
|
|
|
int result;
|
2016-04-28 17:07:27 +03:00
|
|
|
|
2009-10-06 22:31:11 +04:00
|
|
|
struct completion completion;
|
2016-04-28 17:07:27 +03:00
|
|
|
ceph_monc_callback_t complete_cb;
|
|
|
|
u64 private_data; /* r_tid/linger_id */
|
|
|
|
|
2009-10-06 22:31:11 +04:00
|
|
|
struct ceph_msg *request; /* original request */
|
2010-03-25 07:43:33 +03:00
|
|
|
struct ceph_msg *reply; /* and reply */
|
2016-04-28 17:07:27 +03:00
|
|
|
|
|
|
|
union {
|
|
|
|
struct ceph_statfs *st;
|
|
|
|
u64 newest;
|
|
|
|
} u;
|
2009-10-06 22:31:11 +04:00
|
|
|
};
|
|
|
|
|
|
|
|
struct ceph_mon_client {
|
|
|
|
struct ceph_client *client;
|
|
|
|
struct ceph_monmap *monmap;
|
|
|
|
|
|
|
|
struct mutex mutex;
|
|
|
|
struct delayed_work delayed_work;
|
|
|
|
|
2009-11-19 03:19:57 +03:00
|
|
|
struct ceph_auth_client *auth;
|
2010-05-22 01:57:25 +04:00
|
|
|
struct ceph_msg *m_auth, *m_auth_reply, *m_subscribe, *m_subscribe_ack;
|
2010-02-03 03:21:06 +03:00
|
|
|
int pending_auth;
|
2009-11-19 03:19:57 +03:00
|
|
|
|
2009-10-06 22:31:11 +04:00
|
|
|
bool hunting;
|
|
|
|
int cur_mon; /* last monitor i contacted */
|
2016-01-19 18:19:06 +03:00
|
|
|
unsigned long sub_renew_after;
|
|
|
|
unsigned long sub_renew_sent;
|
2012-05-27 08:26:43 +04:00
|
|
|
struct ceph_connection con;
|
2009-10-06 22:31:11 +04:00
|
|
|
|
2016-01-21 18:33:19 +03:00
|
|
|
bool had_a_connection;
|
|
|
|
int hunt_mult; /* [1..CEPH_MONC_HUNT_MAX_MULT] */
|
|
|
|
|
2010-04-23 02:40:37 +04:00
|
|
|
/* pending generic requests */
|
|
|
|
struct rb_root generic_request_tree;
|
2009-10-06 22:31:11 +04:00
|
|
|
u64 last_tid;
|
|
|
|
|
2016-01-19 18:19:06 +03:00
|
|
|
/* subs, indexed with CEPH_SUB_* */
|
|
|
|
struct {
|
|
|
|
struct ceph_mon_subscribe_item item;
|
|
|
|
bool want;
|
|
|
|
u32 have; /* epoch */
|
2016-04-07 06:34:43 +03:00
|
|
|
} subs[4];
|
2016-05-26 01:05:01 +03:00
|
|
|
int fs_cluster_id; /* "mdsmap.<id>" sub */
|
2009-10-06 22:31:11 +04:00
|
|
|
|
2009-11-13 02:05:52 +03:00
|
|
|
#ifdef CONFIG_DEBUG_FS
|
2009-10-06 22:31:11 +04:00
|
|
|
struct dentry *debugfs_file;
|
2009-11-13 02:05:52 +03:00
|
|
|
#endif
|
2009-10-06 22:31:11 +04:00
|
|
|
};
|
|
|
|
|
|
|
|
extern int ceph_monmap_contains(struct ceph_monmap *m,
|
|
|
|
struct ceph_entity_addr *addr);
|
|
|
|
|
|
|
|
extern int ceph_monc_init(struct ceph_mon_client *monc, struct ceph_client *cl);
|
|
|
|
extern void ceph_monc_stop(struct ceph_mon_client *monc);
|
2019-07-25 15:16:39 +03:00
|
|
|
extern void ceph_monc_reopen_session(struct ceph_mon_client *monc);
|
2009-10-06 22:31:11 +04:00
|
|
|
|
2016-01-19 18:19:06 +03:00
|
|
|
enum {
|
2016-04-07 06:34:43 +03:00
|
|
|
CEPH_SUB_MONMAP = 0,
|
2016-01-19 18:19:06 +03:00
|
|
|
CEPH_SUB_OSDMAP,
|
2016-04-07 06:34:43 +03:00
|
|
|
CEPH_SUB_FSMAP,
|
|
|
|
CEPH_SUB_MDSMAP,
|
2016-01-19 18:19:06 +03:00
|
|
|
};
|
|
|
|
|
|
|
|
extern const char *ceph_sub_str[];
|
|
|
|
|
2009-10-06 22:31:11 +04:00
|
|
|
/*
|
|
|
|
* The model here is to indicate that we need a new map of at least
|
2016-01-19 18:19:06 +03:00
|
|
|
* epoch @epoch, and also call in when we receive a map. We will
|
2009-10-06 22:31:11 +04:00
|
|
|
* periodically rerequest the map from the monitor cluster until we
|
|
|
|
* get what we want.
|
|
|
|
*/
|
2016-01-19 18:19:06 +03:00
|
|
|
bool ceph_monc_want_map(struct ceph_mon_client *monc, int sub, u32 epoch,
|
|
|
|
bool continuous);
|
|
|
|
void ceph_monc_got_map(struct ceph_mon_client *monc, int sub, u32 epoch);
|
2016-04-28 17:07:25 +03:00
|
|
|
void ceph_monc_renew_subs(struct ceph_mon_client *monc);
|
2009-10-06 22:31:11 +04:00
|
|
|
|
2014-05-13 11:19:27 +04:00
|
|
|
extern int ceph_monc_wait_osdmap(struct ceph_mon_client *monc, u32 epoch,
|
|
|
|
unsigned long timeout);
|
2009-10-06 22:31:11 +04:00
|
|
|
|
2017-08-16 17:19:27 +03:00
|
|
|
int ceph_monc_do_statfs(struct ceph_mon_client *monc, u64 data_pool,
|
|
|
|
struct ceph_statfs *buf);
|
2009-10-06 22:31:11 +04:00
|
|
|
|
2016-04-28 17:07:27 +03:00
|
|
|
int ceph_monc_get_version(struct ceph_mon_client *monc, const char *what,
|
|
|
|
u64 *newest);
|
|
|
|
int ceph_monc_get_version_async(struct ceph_mon_client *monc, const char *what,
|
|
|
|
ceph_monc_callback_t cb, u64 private_data);
|
2014-05-13 11:19:26 +04:00
|
|
|
|
2015-07-23 03:59:52 +03:00
|
|
|
int ceph_monc_blacklist_add(struct ceph_mon_client *monc,
|
|
|
|
struct ceph_entity_addr *client_addr);
|
|
|
|
|
2009-11-19 03:19:57 +03:00
|
|
|
extern int ceph_monc_open_session(struct ceph_mon_client *monc);
|
|
|
|
|
2010-02-03 03:21:06 +03:00
|
|
|
extern int ceph_monc_validate_auth(struct ceph_mon_client *monc);
|
|
|
|
|
2009-10-06 22:31:11 +04:00
|
|
|
#endif
|