2019-05-27 09:55:01 +03:00
|
|
|
/* SPDX-License-Identifier: GPL-2.0-or-later */
|
2006-08-21 15:08:13 +04:00
|
|
|
/*
|
|
|
|
* Cryptographic API for algorithms (i.e., low-level API).
|
|
|
|
*
|
|
|
|
* Copyright (c) 2006 Herbert Xu <herbert@gondor.apana.org.au>
|
|
|
|
*/
|
|
|
|
#ifndef _CRYPTO_ALGAPI_H
|
|
|
|
#define _CRYPTO_ALGAPI_H
|
|
|
|
|
|
|
|
#include <linux/crypto.h>
|
2007-04-16 14:48:54 +04:00
|
|
|
#include <linux/list.h>
|
|
|
|
#include <linux/kernel.h>
|
2011-09-27 09:24:29 +04:00
|
|
|
#include <linux/skbuff.h>
|
2006-08-21 15:08:13 +04:00
|
|
|
|
2018-04-09 16:54:46 +03:00
|
|
|
/*
|
|
|
|
* Maximum values for blocksize and alignmask, used to allocate
|
|
|
|
* static buffers that are big enough for any combination of
|
2018-08-08 00:18:40 +03:00
|
|
|
* algs and architectures. Ciphers have a lower maximum size.
|
2018-04-09 16:54:46 +03:00
|
|
|
*/
|
2018-08-08 00:18:40 +03:00
|
|
|
#define MAX_ALGAPI_BLOCKSIZE 160
|
|
|
|
#define MAX_ALGAPI_ALIGNMASK 63
|
2018-04-09 16:54:46 +03:00
|
|
|
#define MAX_CIPHER_BLOCKSIZE 16
|
|
|
|
#define MAX_CIPHER_ALIGNMASK 15
|
|
|
|
|
2015-05-11 12:48:12 +03:00
|
|
|
struct crypto_aead;
|
2015-07-09 02:17:15 +03:00
|
|
|
struct crypto_instance;
|
2006-08-06 15:16:34 +04:00
|
|
|
struct module;
|
2007-01-01 10:37:02 +03:00
|
|
|
struct rtattr;
|
2006-08-21 18:06:54 +04:00
|
|
|
struct seq_file;
|
|
|
|
|
|
|
|
struct crypto_type {
|
2007-01-24 12:50:26 +03:00
|
|
|
unsigned int (*ctxsize)(struct crypto_alg *alg, u32 type, u32 mask);
|
2009-07-13 16:46:25 +04:00
|
|
|
unsigned int (*extsize)(struct crypto_alg *alg);
|
2007-01-24 12:50:26 +03:00
|
|
|
int (*init)(struct crypto_tfm *tfm, u32 type, u32 mask);
|
2009-07-13 16:46:25 +04:00
|
|
|
int (*init_tfm)(struct crypto_tfm *tfm);
|
2006-08-21 18:06:54 +04:00
|
|
|
void (*show)(struct seq_file *m, struct crypto_alg *alg);
|
2011-09-27 09:24:29 +04:00
|
|
|
int (*report)(struct sk_buff *skb, struct crypto_alg *alg);
|
2015-07-09 02:17:15 +03:00
|
|
|
void (*free)(struct crypto_instance *inst);
|
2008-09-21 01:52:53 +04:00
|
|
|
|
|
|
|
unsigned int type;
|
|
|
|
unsigned int maskclear;
|
|
|
|
unsigned int maskset;
|
|
|
|
unsigned int tfmsize;
|
2006-08-21 18:06:54 +04:00
|
|
|
};
|
2006-08-06 15:16:34 +04:00
|
|
|
|
|
|
|
struct crypto_instance {
|
|
|
|
struct crypto_alg alg;
|
|
|
|
|
|
|
|
struct crypto_template *tmpl;
|
2019-12-18 10:53:01 +03:00
|
|
|
|
|
|
|
union {
|
|
|
|
/* Node in list of instances after registration. */
|
|
|
|
struct hlist_node list;
|
|
|
|
/* List of attached spawns before registration. */
|
|
|
|
struct crypto_spawn *spawns;
|
|
|
|
};
|
2006-08-06 15:16:34 +04:00
|
|
|
|
|
|
|
void *__ctx[] CRYPTO_MINALIGN_ATTR;
|
|
|
|
};
|
|
|
|
|
|
|
|
struct crypto_template {
|
|
|
|
struct list_head list;
|
|
|
|
struct hlist_head instances;
|
|
|
|
struct module *module;
|
|
|
|
|
2009-07-07 08:30:33 +04:00
|
|
|
int (*create)(struct crypto_template *tmpl, struct rtattr **tb);
|
2006-08-06 15:16:34 +04:00
|
|
|
|
|
|
|
char name[CRYPTO_MAX_ALG_NAME];
|
|
|
|
};
|
|
|
|
|
2006-09-21 05:39:29 +04:00
|
|
|
struct crypto_spawn {
|
|
|
|
struct list_head list;
|
|
|
|
struct crypto_alg *alg;
|
2019-12-18 10:53:01 +03:00
|
|
|
union {
|
|
|
|
/* Back pointer to instance after registration.*/
|
|
|
|
struct crypto_instance *inst;
|
|
|
|
/* Spawn list pointer prior to registration. */
|
|
|
|
struct crypto_spawn *next;
|
|
|
|
};
|
2009-07-08 11:55:52 +04:00
|
|
|
const struct crypto_type *frontend;
|
2007-04-08 15:31:36 +04:00
|
|
|
u32 mask;
|
2019-12-07 17:15:17 +03:00
|
|
|
bool dead;
|
2019-12-18 10:53:01 +03:00
|
|
|
bool registered;
|
2006-09-21 05:39:29 +04:00
|
|
|
};
|
|
|
|
|
2007-04-16 14:48:54 +04:00
|
|
|
struct crypto_queue {
|
|
|
|
struct list_head list;
|
|
|
|
struct list_head *backlog;
|
|
|
|
|
|
|
|
unsigned int qlen;
|
|
|
|
unsigned int max_qlen;
|
|
|
|
};
|
|
|
|
|
2006-08-12 15:56:17 +04:00
|
|
|
struct scatter_walk {
|
|
|
|
struct scatterlist *sg;
|
|
|
|
unsigned int offset;
|
|
|
|
};
|
|
|
|
|
2006-09-21 05:44:08 +04:00
|
|
|
void crypto_mod_put(struct crypto_alg *alg);
|
|
|
|
|
2006-08-06 15:16:34 +04:00
|
|
|
int crypto_register_template(struct crypto_template *tmpl);
|
2019-01-18 08:58:11 +03:00
|
|
|
int crypto_register_templates(struct crypto_template *tmpls, int count);
|
2006-08-06 15:16:34 +04:00
|
|
|
void crypto_unregister_template(struct crypto_template *tmpl);
|
2019-01-18 08:58:11 +03:00
|
|
|
void crypto_unregister_templates(struct crypto_template *tmpls, int count);
|
2006-08-06 15:16:34 +04:00
|
|
|
struct crypto_template *crypto_lookup_template(const char *name);
|
|
|
|
|
2009-07-14 14:45:45 +04:00
|
|
|
int crypto_register_instance(struct crypto_template *tmpl,
|
|
|
|
struct crypto_instance *inst);
|
2019-12-16 02:51:19 +03:00
|
|
|
void crypto_unregister_instance(struct crypto_instance *inst);
|
2009-07-14 14:45:45 +04:00
|
|
|
|
2020-01-03 06:58:48 +03:00
|
|
|
int crypto_grab_spawn(struct crypto_spawn *spawn, struct crypto_instance *inst,
|
|
|
|
const char *name, u32 type, u32 mask);
|
2006-09-21 05:39:29 +04:00
|
|
|
void crypto_drop_spawn(struct crypto_spawn *spawn);
|
2006-12-17 02:05:58 +03:00
|
|
|
struct crypto_tfm *crypto_spawn_tfm(struct crypto_spawn *spawn, u32 type,
|
|
|
|
u32 mask);
|
2009-07-08 11:55:52 +04:00
|
|
|
void *crypto_spawn_tfm2(struct crypto_spawn *spawn);
|
2006-09-21 05:39:29 +04:00
|
|
|
|
2007-01-01 10:37:02 +03:00
|
|
|
struct crypto_attr_type *crypto_get_attr_type(struct rtattr **tb);
|
2020-07-10 09:20:38 +03:00
|
|
|
int crypto_check_attr_type(struct rtattr **tb, u32 type, u32 *mask_ret);
|
2007-12-07 15:18:17 +03:00
|
|
|
const char *crypto_attr_alg_name(struct rtattr *rta);
|
[CRYPTO] aead: Add authenc
This patch adds the authenc algorithm which constructs an AEAD algorithm
from an asynchronous block cipher and a hash. The construction is done
by concatenating the encrypted result from the cipher with the output
from the hash, as is used by the IPsec ESP protocol.
The authenc algorithm exists as a template with four parameters:
authenc(auth, authsize, enc, enckeylen).
The authentication algorithm, the authentication size (i.e., truncating
the output of the authentication algorithm), the encryption algorithm,
and the encryption key length. Both the size field and the key length
field are in bytes. For example, AES-128 with SHA1-HMAC would be
represented by
authenc(hmac(sha1), 12, cbc(aes), 16)
The key for the authenc algorithm is the concatenation of the keys for
the authentication algorithm with the encryption algorithm. For the
above example, if a key of length 36 bytes is given, then hmac(sha1)
would receive the first 20 bytes while the last 16 would be given to
cbc(aes).
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2007-08-30 12:24:15 +04:00
|
|
|
int crypto_attr_u32(struct rtattr *rta, u32 *num);
|
2016-06-29 13:04:13 +03:00
|
|
|
int crypto_inst_setname(struct crypto_instance *inst, const char *name,
|
|
|
|
struct crypto_alg *alg);
|
2006-08-06 17:10:45 +04:00
|
|
|
|
2007-04-16 14:48:54 +04:00
|
|
|
void crypto_init_queue(struct crypto_queue *queue, unsigned int max_qlen);
|
|
|
|
int crypto_enqueue_request(struct crypto_queue *queue,
|
|
|
|
struct crypto_async_request *request);
|
2020-04-28 18:49:03 +03:00
|
|
|
void crypto_enqueue_request_head(struct crypto_queue *queue,
|
|
|
|
struct crypto_async_request *request);
|
2007-04-16 14:48:54 +04:00
|
|
|
struct crypto_async_request *crypto_dequeue_request(struct crypto_queue *queue);
|
2016-01-26 15:25:38 +03:00
|
|
|
static inline unsigned int crypto_queue_len(struct crypto_queue *queue)
|
|
|
|
{
|
|
|
|
return queue->qlen;
|
|
|
|
}
|
2007-04-16 14:48:54 +04:00
|
|
|
|
2007-11-20 12:26:06 +03:00
|
|
|
void crypto_inc(u8 *a, unsigned int size);
|
2017-07-24 13:28:03 +03:00
|
|
|
void __crypto_xor(u8 *dst, const u8 *src1, const u8 *src2, unsigned int size);
|
crypto: algapi - make crypto_xor() and crypto_inc() alignment agnostic
Instead of unconditionally forcing 4 byte alignment for all generic
chaining modes that rely on crypto_xor() or crypto_inc() (which may
result in unnecessary copying of data when the underlying hardware
can perform unaligned accesses efficiently), make those functions
deal with unaligned input explicitly, but only if the Kconfig symbol
HAVE_EFFICIENT_UNALIGNED_ACCESS is set. This will allow us to drop
the alignmasks from the CBC, CMAC, CTR, CTS, PCBC and SEQIV drivers.
For crypto_inc(), this simply involves making the 4-byte stride
conditional on HAVE_EFFICIENT_UNALIGNED_ACCESS being set, given that
it typically operates on 16 byte buffers.
For crypto_xor(), an algorithm is implemented that simply runs through
the input using the largest strides possible if unaligned accesses are
allowed. If they are not, an optimal sequence of memory accesses is
emitted that takes the relative alignment of the input buffers into
account, e.g., if the relative misalignment of dst and src is 4 bytes,
the entire xor operation will be completed using 4 byte loads and stores
(modulo unaligned bits at the start and end). Note that all expressions
involving misalign are simply eliminated by the compiler when
HAVE_EFFICIENT_UNALIGNED_ACCESS is defined.
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2017-02-05 13:06:12 +03:00
|
|
|
|
|
|
|
static inline void crypto_xor(u8 *dst, const u8 *src, unsigned int size)
|
|
|
|
{
|
|
|
|
if (IS_ENABLED(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS) &&
|
|
|
|
__builtin_constant_p(size) &&
|
|
|
|
(size % sizeof(unsigned long)) == 0) {
|
|
|
|
unsigned long *d = (unsigned long *)dst;
|
|
|
|
unsigned long *s = (unsigned long *)src;
|
|
|
|
|
|
|
|
while (size > 0) {
|
|
|
|
*d++ ^= *s++;
|
|
|
|
size -= sizeof(unsigned long);
|
|
|
|
}
|
|
|
|
} else {
|
2017-07-24 13:28:03 +03:00
|
|
|
__crypto_xor(dst, dst, src, size);
|
crypto: algapi - make crypto_xor() and crypto_inc() alignment agnostic
Instead of unconditionally forcing 4 byte alignment for all generic
chaining modes that rely on crypto_xor() or crypto_inc() (which may
result in unnecessary copying of data when the underlying hardware
can perform unaligned accesses efficiently), make those functions
deal with unaligned input explicitly, but only if the Kconfig symbol
HAVE_EFFICIENT_UNALIGNED_ACCESS is set. This will allow us to drop
the alignmasks from the CBC, CMAC, CTR, CTS, PCBC and SEQIV drivers.
For crypto_inc(), this simply involves making the 4-byte stride
conditional on HAVE_EFFICIENT_UNALIGNED_ACCESS being set, given that
it typically operates on 16 byte buffers.
For crypto_xor(), an algorithm is implemented that simply runs through
the input using the largest strides possible if unaligned accesses are
allowed. If they are not, an optimal sequence of memory accesses is
emitted that takes the relative alignment of the input buffers into
account, e.g., if the relative misalignment of dst and src is 4 bytes,
the entire xor operation will be completed using 4 byte loads and stores
(modulo unaligned bits at the start and end). Note that all expressions
involving misalign are simply eliminated by the compiler when
HAVE_EFFICIENT_UNALIGNED_ACCESS is defined.
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2017-02-05 13:06:12 +03:00
|
|
|
}
|
|
|
|
}
|
2007-11-20 12:26:06 +03:00
|
|
|
|
crypto: algapi - make crypto_xor() take separate dst and src arguments
There are quite a number of occurrences in the kernel of the pattern
if (dst != src)
memcpy(dst, src, walk.total % AES_BLOCK_SIZE);
crypto_xor(dst, final, walk.total % AES_BLOCK_SIZE);
or
crypto_xor(keystream, src, nbytes);
memcpy(dst, keystream, nbytes);
where crypto_xor() is preceded or followed by a memcpy() invocation
that is only there because crypto_xor() uses its output parameter as
one of the inputs. To avoid having to add new instances of this pattern
in the arm64 code, which will be refactored to implement non-SIMD
fallbacks, add an alternative implementation called crypto_xor_cpy(),
taking separate input and output arguments. This removes the need for
the separate memcpy().
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2017-07-24 13:28:04 +03:00
|
|
|
static inline void crypto_xor_cpy(u8 *dst, const u8 *src1, const u8 *src2,
|
|
|
|
unsigned int size)
|
|
|
|
{
|
|
|
|
if (IS_ENABLED(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS) &&
|
|
|
|
__builtin_constant_p(size) &&
|
|
|
|
(size % sizeof(unsigned long)) == 0) {
|
|
|
|
unsigned long *d = (unsigned long *)dst;
|
|
|
|
unsigned long *s1 = (unsigned long *)src1;
|
|
|
|
unsigned long *s2 = (unsigned long *)src2;
|
|
|
|
|
|
|
|
while (size > 0) {
|
|
|
|
*d++ = *s1++ ^ *s2++;
|
|
|
|
size -= sizeof(unsigned long);
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
__crypto_xor(dst, src1, src2, size);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2006-08-21 18:07:53 +04:00
|
|
|
static inline void *crypto_tfm_ctx_aligned(struct crypto_tfm *tfm)
|
|
|
|
{
|
2009-07-24 11:26:15 +04:00
|
|
|
return PTR_ALIGN(crypto_tfm_ctx(tfm),
|
|
|
|
crypto_tfm_alg_alignmask(tfm) + 1);
|
2006-08-21 18:07:53 +04:00
|
|
|
}
|
|
|
|
|
2007-04-16 14:49:20 +04:00
|
|
|
static inline struct crypto_instance *crypto_tfm_alg_instance(
|
|
|
|
struct crypto_tfm *tfm)
|
|
|
|
{
|
|
|
|
return container_of(tfm->__crt_alg, struct crypto_instance, alg);
|
|
|
|
}
|
|
|
|
|
2006-08-06 15:16:34 +04:00
|
|
|
static inline void *crypto_instance_ctx(struct crypto_instance *inst)
|
|
|
|
{
|
|
|
|
return inst->__ctx;
|
|
|
|
}
|
|
|
|
|
crypto: cipher - introduce crypto_cipher_spawn and crypto_grab_cipher()
Currently, "cipher" (single-block cipher) spawns are usually initialized
by using crypto_get_attr_alg() to look up the algorithm, then calling
crypto_init_spawn(). In one case, crypto_grab_spawn() is used directly.
The former way is different from how skcipher, aead, and akcipher spawns
are initialized (they use crypto_grab_*()), and for no good reason.
This difference introduces unnecessary complexity.
The crypto_grab_*() functions used to have some problems, like not
holding a reference to the algorithm and requiring the caller to
initialize spawn->base.inst. But those problems are fixed now.
Also, the cipher spawns are not strongly typed; e.g., the API requires
that the user manually specify the flags CRYPTO_ALG_TYPE_CIPHER and
CRYPTO_ALG_TYPE_MASK. Though the "cipher" algorithm type itself isn't
yet strongly typed, we can start by making the spawns strongly typed.
So, let's introduce a new 'struct crypto_cipher_spawn', and functions
crypto_grab_cipher() and crypto_drop_cipher() to grab and drop them.
Later patches will convert all cipher spawns to use these, then make
crypto_spawn_cipher() take 'struct crypto_cipher_spawn' as well, instead
of a bare 'struct crypto_spawn' as it currently does.
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2020-01-03 06:58:51 +03:00
|
|
|
struct crypto_cipher_spawn {
|
|
|
|
struct crypto_spawn base;
|
|
|
|
};
|
|
|
|
|
|
|
|
static inline int crypto_grab_cipher(struct crypto_cipher_spawn *spawn,
|
|
|
|
struct crypto_instance *inst,
|
|
|
|
const char *name, u32 type, u32 mask)
|
|
|
|
{
|
|
|
|
type &= ~CRYPTO_ALG_TYPE_MASK;
|
|
|
|
type |= CRYPTO_ALG_TYPE_CIPHER;
|
|
|
|
mask |= CRYPTO_ALG_TYPE_MASK;
|
|
|
|
return crypto_grab_spawn(&spawn->base, inst, name, type, mask);
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline void crypto_drop_cipher(struct crypto_cipher_spawn *spawn)
|
|
|
|
{
|
|
|
|
crypto_drop_spawn(&spawn->base);
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline struct crypto_alg *crypto_spawn_cipher_alg(
|
|
|
|
struct crypto_cipher_spawn *spawn)
|
|
|
|
{
|
|
|
|
return spawn->base.alg;
|
|
|
|
}
|
|
|
|
|
2006-12-17 02:05:58 +03:00
|
|
|
static inline struct crypto_cipher *crypto_spawn_cipher(
|
2020-01-03 06:59:05 +03:00
|
|
|
struct crypto_cipher_spawn *spawn)
|
2006-12-17 02:05:58 +03:00
|
|
|
{
|
|
|
|
u32 type = CRYPTO_ALG_TYPE_CIPHER;
|
|
|
|
u32 mask = CRYPTO_ALG_TYPE_MASK;
|
|
|
|
|
2020-01-03 06:59:05 +03:00
|
|
|
return __crypto_cipher_cast(crypto_spawn_tfm(&spawn->base, type, mask));
|
2006-12-17 02:05:58 +03:00
|
|
|
}
|
|
|
|
|
2006-08-13 14:58:18 +04:00
|
|
|
static inline struct cipher_alg *crypto_cipher_alg(struct crypto_cipher *tfm)
|
|
|
|
{
|
|
|
|
return &crypto_cipher_tfm(tfm)->__crt_alg->cra_cipher;
|
|
|
|
}
|
|
|
|
|
2007-04-16 14:48:54 +04:00
|
|
|
static inline struct crypto_async_request *crypto_get_backlog(
|
|
|
|
struct crypto_queue *queue)
|
|
|
|
{
|
|
|
|
return queue->backlog == &queue->list ? NULL :
|
|
|
|
container_of(queue->backlog, struct crypto_async_request, list);
|
|
|
|
}
|
|
|
|
|
2020-07-10 09:20:38 +03:00
|
|
|
static inline u32 crypto_requires_off(struct crypto_attr_type *algt, u32 off)
|
2017-02-26 07:22:35 +03:00
|
|
|
{
|
2020-07-10 09:20:38 +03:00
|
|
|
return (algt->type ^ off) & algt->mask & off;
|
2017-02-26 07:22:35 +03:00
|
|
|
}
|
|
|
|
|
2007-12-17 15:07:31 +03:00
|
|
|
/*
|
2020-07-10 09:20:38 +03:00
|
|
|
* When an algorithm uses another algorithm (e.g., if it's an instance of a
|
|
|
|
* template), these are the flags that should always be set on the "outer"
|
|
|
|
* algorithm if any "inner" algorithm has them set.
|
2007-12-17 15:07:31 +03:00
|
|
|
*/
|
2020-07-10 09:20:39 +03:00
|
|
|
#define CRYPTO_ALG_INHERITED_FLAGS \
|
2020-07-10 09:20:40 +03:00
|
|
|
(CRYPTO_ALG_ASYNC | CRYPTO_ALG_NEED_FALLBACK | \
|
|
|
|
CRYPTO_ALG_ALLOCATES_MEMORY)
|
2020-07-10 09:20:38 +03:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Given the type and mask that specify the flags restrictions on a template
|
|
|
|
* instance being created, return the mask that should be passed to
|
|
|
|
* crypto_grab_*() (along with type=0) to honor any request the user made to
|
|
|
|
* have any of the CRYPTO_ALG_INHERITED_FLAGS clear.
|
|
|
|
*/
|
|
|
|
static inline u32 crypto_algt_inherited_mask(struct crypto_attr_type *algt)
|
2007-12-17 15:07:31 +03:00
|
|
|
{
|
2020-07-10 09:20:38 +03:00
|
|
|
return crypto_requires_off(algt, CRYPTO_ALG_INHERITED_FLAGS);
|
2007-12-17 15:07:31 +03:00
|
|
|
}
|
|
|
|
|
crypto: crypto_memneq - add equality testing of memory regions w/o timing leaks
When comparing MAC hashes, AEAD authentication tags, or other hash
values in the context of authentication or integrity checking, it
is important not to leak timing information to a potential attacker,
i.e. when communication happens over a network.
Bytewise memory comparisons (such as memcmp) are usually optimized so
that they return a nonzero value as soon as a mismatch is found. E.g,
on x86_64/i5 for 512 bytes this can be ~50 cyc for a full mismatch
and up to ~850 cyc for a full match (cold). This early-return behavior
can leak timing information as a side channel, allowing an attacker to
iteratively guess the correct result.
This patch adds a new method crypto_memneq ("memory not equal to each
other") to the crypto API that compares memory areas of the same length
in roughly "constant time" (cache misses could change the timing, but
since they don't reveal information about the content of the strings
being compared, they are effectively benign). Iow, best and worst case
behaviour take the same amount of time to complete (in contrast to
memcmp).
Note that crypto_memneq (unlike memcmp) can only be used to test for
equality or inequality, NOT for lexicographical order. This, however,
is not an issue for its use-cases within the crypto API.
We tried to locate all of the places in the crypto API where memcmp was
being used for authentication or integrity checking, and convert them
over to crypto_memneq.
crypto_memneq is declared noinline, placed in its own source file,
and compiled with optimizations that might increase code size disabled
("Os") because a smart compiler (or LTO) might notice that the return
value is always compared against zero/nonzero, and might then
reintroduce the same early-return optimization that we are trying to
avoid.
Using #pragma or __attribute__ optimization annotations of the code
for disabling optimization was avoided as it seems to be considered
broken or unmaintained for long time in GCC [1]. Therefore, we work
around that by specifying the compile flag for memneq.o directly in
the Makefile. We found that this seems to be most appropriate.
As we use ("Os"), this patch also provides a loop-free "fast-path" for
frequently used 16 byte digests. Similarly to kernel library string
functions, leave an option for future even further optimized architecture
specific assembler implementations.
This was a joint work of James Yonan and Daniel Borkmann. Also thanks
for feedback from Florian Weimer on this and earlier proposals [2].
[1] http://gcc.gnu.org/ml/gcc/2012-07/msg00211.html
[2] https://lkml.org/lkml/2013/2/10/131
Signed-off-by: James Yonan <james@openvpn.net>
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Cc: Florian Weimer <fw@deneb.enyo.de>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2013-09-26 12:20:39 +04:00
|
|
|
noinline unsigned long __crypto_memneq(const void *a, const void *b, size_t size);
|
|
|
|
|
|
|
|
/**
|
|
|
|
* crypto_memneq - Compare two areas of memory without leaking
|
|
|
|
* timing information.
|
|
|
|
*
|
|
|
|
* @a: One area of memory
|
|
|
|
* @b: Another area of memory
|
|
|
|
* @size: The size of the area.
|
|
|
|
*
|
|
|
|
* Returns 0 when data is equal, 1 otherwise.
|
|
|
|
*/
|
|
|
|
static inline int crypto_memneq(const void *a, const void *b, size_t size)
|
|
|
|
{
|
|
|
|
return __crypto_memneq(a, b, size) != 0UL ? 1 : 0;
|
|
|
|
}
|
2006-08-21 15:08:13 +04:00
|
|
|
|
2014-05-26 17:32:05 +04:00
|
|
|
static inline void crypto_yield(u32 flags)
|
|
|
|
{
|
|
|
|
if (flags & CRYPTO_TFM_REQ_MAY_SLEEP)
|
|
|
|
cond_resched();
|
|
|
|
}
|
|
|
|
|
2018-08-30 18:00:14 +03:00
|
|
|
int crypto_register_notifier(struct notifier_block *nb);
|
|
|
|
int crypto_unregister_notifier(struct notifier_block *nb);
|
|
|
|
|
|
|
|
/* Crypto notification events. */
|
|
|
|
enum {
|
|
|
|
CRYPTO_MSG_ALG_REQUEST,
|
|
|
|
CRYPTO_MSG_ALG_REGISTER,
|
|
|
|
CRYPTO_MSG_ALG_LOADED,
|
|
|
|
};
|
|
|
|
|
crypto: crypto_memneq - add equality testing of memory regions w/o timing leaks
When comparing MAC hashes, AEAD authentication tags, or other hash
values in the context of authentication or integrity checking, it
is important not to leak timing information to a potential attacker,
i.e. when communication happens over a network.
Bytewise memory comparisons (such as memcmp) are usually optimized so
that they return a nonzero value as soon as a mismatch is found. E.g,
on x86_64/i5 for 512 bytes this can be ~50 cyc for a full mismatch
and up to ~850 cyc for a full match (cold). This early-return behavior
can leak timing information as a side channel, allowing an attacker to
iteratively guess the correct result.
This patch adds a new method crypto_memneq ("memory not equal to each
other") to the crypto API that compares memory areas of the same length
in roughly "constant time" (cache misses could change the timing, but
since they don't reveal information about the content of the strings
being compared, they are effectively benign). Iow, best and worst case
behaviour take the same amount of time to complete (in contrast to
memcmp).
Note that crypto_memneq (unlike memcmp) can only be used to test for
equality or inequality, NOT for lexicographical order. This, however,
is not an issue for its use-cases within the crypto API.
We tried to locate all of the places in the crypto API where memcmp was
being used for authentication or integrity checking, and convert them
over to crypto_memneq.
crypto_memneq is declared noinline, placed in its own source file,
and compiled with optimizations that might increase code size disabled
("Os") because a smart compiler (or LTO) might notice that the return
value is always compared against zero/nonzero, and might then
reintroduce the same early-return optimization that we are trying to
avoid.
Using #pragma or __attribute__ optimization annotations of the code
for disabling optimization was avoided as it seems to be considered
broken or unmaintained for long time in GCC [1]. Therefore, we work
around that by specifying the compile flag for memneq.o directly in
the Makefile. We found that this seems to be most appropriate.
As we use ("Os"), this patch also provides a loop-free "fast-path" for
frequently used 16 byte digests. Similarly to kernel library string
functions, leave an option for future even further optimized architecture
specific assembler implementations.
This was a joint work of James Yonan and Daniel Borkmann. Also thanks
for feedback from Florian Weimer on this and earlier proposals [2].
[1] http://gcc.gnu.org/ml/gcc/2012-07/msg00211.html
[2] https://lkml.org/lkml/2013/2/10/131
Signed-off-by: James Yonan <james@openvpn.net>
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Cc: Florian Weimer <fw@deneb.enyo.de>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2013-09-26 12:20:39 +04:00
|
|
|
#endif /* _CRYPTO_ALGAPI_H */
|