2019-05-27 09:55:05 +03:00
|
|
|
// SPDX-License-Identifier: GPL-2.0-or-later
|
2021-03-30 19:44:57 +03:00
|
|
|
/*
|
2006-10-04 13:16:22 +04:00
|
|
|
* eCryptfs: Linux filesystem encryption layer
|
|
|
|
*
|
|
|
|
* Copyright (C) 1997-2004 Erez Zadok
|
|
|
|
* Copyright (C) 2001-2004 Stony Brook University
|
2007-02-12 11:53:46 +03:00
|
|
|
* Copyright (C) 2004-2007 International Business Machines Corp.
|
2006-10-04 13:16:22 +04:00
|
|
|
* Author(s): Michael A. Halcrow <mahalcro@us.ibm.com>
|
|
|
|
* Michael C. Thompsion <mcthomps@us.ibm.com>
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <linux/file.h>
|
|
|
|
#include <linux/vmalloc.h>
|
|
|
|
#include <linux/pagemap.h>
|
|
|
|
#include <linux/dcache.h>
|
|
|
|
#include <linux/namei.h>
|
|
|
|
#include <linux/mount.h>
|
2006-12-08 13:36:31 +03:00
|
|
|
#include <linux/fs_stack.h>
|
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files. percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.
percpu.h -> slab.h dependency is about to be removed. Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability. As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.
http://userweb.kernel.org/~tj/misc/slabh-sweep.py
The script does the followings.
* Scan files for gfp and slab usages and update includes such that
only the necessary includes are there. ie. if only gfp is used,
gfp.h, if slab is used, slab.h.
* When the script inserts a new include, it looks at the include
blocks and try to put the new include such that its order conforms
to its surrounding. It's put in the include block which contains
core kernel includes, in the same order that the rest are ordered -
alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
doesn't seem to be any matching order.
* If the script can't find a place to put a new include (mostly
because the file doesn't have fitting include block), it prints out
an error message indicating which .h file needs to be added to the
file.
The conversion was done in the following steps.
1. The initial automatic conversion of all .c files updated slightly
over 4000 files, deleting around 700 includes and adding ~480 gfp.h
and ~3000 slab.h inclusions. The script emitted errors for ~400
files.
2. Each error was manually checked. Some didn't need the inclusion,
some needed manual addition while adding it to implementation .h or
embedding .c file was more appropriate for others. This step added
inclusions to around 150 files.
3. The script was run again and the output was compared to the edits
from #2 to make sure no file was left behind.
4. Several build tests were done and a couple of problems were fixed.
e.g. lib/decompress_*.c used malloc/free() wrappers around slab
APIs requiring slab.h to be added manually.
5. The script was run on all .h files but without automatically
editing them as sprinkling gfp.h and slab.h inclusions around .h
files could easily lead to inclusion dependency hell. Most gfp.h
inclusion directives were ignored as stuff from gfp.h was usually
wildly available and often used in preprocessor macros. Each
slab.h inclusion directive was examined and added manually as
necessary.
6. percpu.h was updated not to include slab.h.
7. Build test were done on the following configurations and failures
were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
distributed build env didn't work with gcov compiles) and a few
more options had to be turned off depending on archs to make things
build (like ipr on powerpc/64 which failed due to missing writeq).
* x86 and x86_64 UP and SMP allmodconfig and a custom test config.
* powerpc and powerpc64 SMP allmodconfig
* sparc and sparc64 SMP allmodconfig
* ia64 SMP allmodconfig
* s390 SMP allmodconfig
* alpha SMP allmodconfig
* um on x86_64 SMP allmodconfig
8. percpu.h modifications were reverted so that it could be applied as
a separate patch and serve as bisection point.
Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.
Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
2010-03-24 11:04:11 +03:00
|
|
|
#include <linux/slab.h>
|
2010-10-05 20:53:45 +04:00
|
|
|
#include <linux/xattr.h>
|
2022-09-22 18:17:17 +03:00
|
|
|
#include <linux/posix_acl.h>
|
|
|
|
#include <linux/posix_acl_xattr.h>
|
2021-04-07 15:36:42 +03:00
|
|
|
#include <linux/fileattr.h>
|
2008-07-24 08:30:07 +04:00
|
|
|
#include <asm/unaligned.h>
|
2006-10-04 13:16:22 +04:00
|
|
|
#include "ecryptfs_kernel.h"
|
|
|
|
|
2021-01-30 01:35:43 +03:00
|
|
|
static int lock_parent(struct dentry *dentry,
|
|
|
|
struct dentry **lower_dentry,
|
|
|
|
struct inode **lower_dir)
|
2006-10-04 13:16:22 +04:00
|
|
|
{
|
2021-01-30 01:35:43 +03:00
|
|
|
struct dentry *lower_dir_dentry;
|
2006-10-04 13:16:22 +04:00
|
|
|
|
2021-01-30 01:35:43 +03:00
|
|
|
lower_dir_dentry = ecryptfs_dentry_to_lower(dentry->d_parent);
|
|
|
|
*lower_dir = d_inode(lower_dir_dentry);
|
|
|
|
*lower_dentry = ecryptfs_dentry_to_lower(dentry);
|
2006-10-04 13:16:22 +04:00
|
|
|
|
2021-01-30 01:35:43 +03:00
|
|
|
inode_lock_nested(*lower_dir, I_MUTEX_PARENT);
|
|
|
|
return (*lower_dentry)->d_parent == lower_dir_dentry ? 0 : -EINVAL;
|
2006-10-04 13:16:22 +04:00
|
|
|
}
|
|
|
|
|
2011-05-24 06:18:20 +04:00
|
|
|
static int ecryptfs_inode_test(struct inode *inode, void *lower_inode)
|
|
|
|
{
|
2014-06-26 23:41:59 +04:00
|
|
|
return ecryptfs_inode_to_lower(inode) == lower_inode;
|
2011-05-24 06:18:20 +04:00
|
|
|
}
|
|
|
|
|
2011-05-24 11:16:51 +04:00
|
|
|
static int ecryptfs_inode_set(struct inode *inode, void *opaque)
|
2011-05-24 06:18:20 +04:00
|
|
|
{
|
2011-05-24 11:16:51 +04:00
|
|
|
struct inode *lower_inode = opaque;
|
|
|
|
|
|
|
|
ecryptfs_set_inode_lower(inode, lower_inode);
|
|
|
|
fsstack_copy_attr_all(inode, lower_inode);
|
|
|
|
/* i_size will be overwritten for encrypted regular files */
|
|
|
|
fsstack_copy_inode_size(inode, lower_inode);
|
|
|
|
inode->i_ino = lower_inode->i_ino;
|
2011-05-24 06:18:20 +04:00
|
|
|
inode->i_mapping->a_ops = &ecryptfs_aops;
|
2011-05-24 11:16:51 +04:00
|
|
|
|
|
|
|
if (S_ISLNK(inode->i_mode))
|
|
|
|
inode->i_op = &ecryptfs_symlink_iops;
|
|
|
|
else if (S_ISDIR(inode->i_mode))
|
|
|
|
inode->i_op = &ecryptfs_dir_iops;
|
|
|
|
else
|
|
|
|
inode->i_op = &ecryptfs_main_iops;
|
|
|
|
|
|
|
|
if (S_ISDIR(inode->i_mode))
|
|
|
|
inode->i_fop = &ecryptfs_dir_fops;
|
|
|
|
else if (special_file(inode->i_mode))
|
|
|
|
init_special_inode(inode, inode->i_mode, inode->i_rdev);
|
|
|
|
else
|
|
|
|
inode->i_fop = &ecryptfs_main_fops;
|
|
|
|
|
2011-05-24 06:18:20 +04:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2011-05-24 11:16:51 +04:00
|
|
|
static struct inode *__ecryptfs_get_inode(struct inode *lower_inode,
|
|
|
|
struct super_block *sb)
|
2011-05-24 06:18:20 +04:00
|
|
|
{
|
|
|
|
struct inode *inode;
|
|
|
|
|
2011-05-24 11:16:51 +04:00
|
|
|
if (lower_inode->i_sb != ecryptfs_superblock_to_lower(sb))
|
|
|
|
return ERR_PTR(-EXDEV);
|
|
|
|
if (!igrab(lower_inode))
|
|
|
|
return ERR_PTR(-ESTALE);
|
2011-05-24 06:18:20 +04:00
|
|
|
inode = iget5_locked(sb, (unsigned long)lower_inode,
|
|
|
|
ecryptfs_inode_test, ecryptfs_inode_set,
|
|
|
|
lower_inode);
|
|
|
|
if (!inode) {
|
|
|
|
iput(lower_inode);
|
2011-05-24 11:16:51 +04:00
|
|
|
return ERR_PTR(-EACCES);
|
2011-05-24 06:18:20 +04:00
|
|
|
}
|
2011-05-24 11:16:51 +04:00
|
|
|
if (!(inode->i_state & I_NEW))
|
2011-05-24 06:18:20 +04:00
|
|
|
iput(lower_inode);
|
2011-05-24 11:16:51 +04:00
|
|
|
|
|
|
|
return inode;
|
|
|
|
}
|
|
|
|
|
|
|
|
struct inode *ecryptfs_get_inode(struct inode *lower_inode,
|
|
|
|
struct super_block *sb)
|
|
|
|
{
|
|
|
|
struct inode *inode = __ecryptfs_get_inode(lower_inode, sb);
|
|
|
|
|
|
|
|
if (!IS_ERR(inode) && (inode->i_state & I_NEW))
|
|
|
|
unlock_new_inode(inode);
|
|
|
|
|
2011-05-24 06:18:20 +04:00
|
|
|
return inode;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* ecryptfs_interpose
|
|
|
|
* @lower_dentry: Existing dentry in the lower filesystem
|
|
|
|
* @dentry: ecryptfs' dentry
|
|
|
|
* @sb: ecryptfs's super_block
|
|
|
|
*
|
|
|
|
* Interposes upper and lower dentries.
|
|
|
|
*
|
|
|
|
* Returns zero on success; non-zero otherwise
|
|
|
|
*/
|
|
|
|
static int ecryptfs_interpose(struct dentry *lower_dentry,
|
2011-05-24 11:16:51 +04:00
|
|
|
struct dentry *dentry, struct super_block *sb)
|
2011-05-24 06:18:20 +04:00
|
|
|
{
|
2015-03-18 01:25:59 +03:00
|
|
|
struct inode *inode = ecryptfs_get_inode(d_inode(lower_dentry), sb);
|
2011-05-24 11:16:51 +04:00
|
|
|
|
2011-05-24 06:18:20 +04:00
|
|
|
if (IS_ERR(inode))
|
|
|
|
return PTR_ERR(inode);
|
2011-05-24 11:16:51 +04:00
|
|
|
d_instantiate(dentry, inode);
|
|
|
|
|
2011-05-24 06:18:20 +04:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2012-05-23 00:09:50 +04:00
|
|
|
static int ecryptfs_do_unlink(struct inode *dir, struct dentry *dentry,
|
|
|
|
struct inode *inode)
|
|
|
|
{
|
2021-01-30 01:35:43 +03:00
|
|
|
struct dentry *lower_dentry;
|
|
|
|
struct inode *lower_dir;
|
2012-05-23 00:09:50 +04:00
|
|
|
int rc;
|
|
|
|
|
2021-01-30 01:35:43 +03:00
|
|
|
rc = lock_parent(dentry, &lower_dentry, &lower_dir);
|
ecryptfs: fix unlink and rmdir in face of underlying fs modifications
A problem similar to the one caught in commit 74dd7c97ea2a ("ecryptfs_rename():
verify that lower dentries are still OK after lock_rename()") exists for
unlink/rmdir as well.
Instead of playing with dget_parent() of underlying dentry of victim
and hoping it's the same as underlying dentry of our directory,
do the following:
* find the underlying dentry of victim
* find the underlying directory of victim's parent (stable
since the victim is ecryptfs dentry and inode of its parent is
held exclusive by the caller).
* lock the inode of dentry underlying the victim's parent
* check that underlying dentry of victim is still hashed and
has the right parent - it can be moved, but it can't be moved to/from
the directory we are holding exclusive. So while ->d_parent itself
might not be stable, the result of comparison is.
If the check passes, everything is fine - underlying directory is locked,
underlying victim is still a child of that directory and we can go ahead
and feed them to vfs_unlink(). As in the current mainline we need to
pin the underlying dentry of victim, so that it wouldn't go negative under
us, but that's the only temporary reference that needs to be grabbed there.
Underlying dentry of parent won't go away (it's pinned by the parent,
which is held by caller), so there's no need to grab it.
The same problem (with the same solution) exists for rmdir. Moreover,
rename gets simpler and more robust with the same "don't bother with
dget_parent()" approach.
Fixes: 74dd7c97ea2 "ecryptfs_rename(): verify that lower dentries are still OK after lock_rename()"
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2019-11-03 20:07:15 +03:00
|
|
|
dget(lower_dentry); // don't even try to make the lower negative
|
2021-01-30 01:35:43 +03:00
|
|
|
if (!rc) {
|
|
|
|
if (d_unhashed(lower_dentry))
|
|
|
|
rc = -EINVAL;
|
|
|
|
else
|
|
|
|
rc = vfs_unlink(&init_user_ns, lower_dir, lower_dentry,
|
|
|
|
NULL);
|
|
|
|
}
|
2012-05-23 00:09:50 +04:00
|
|
|
if (rc) {
|
|
|
|
printk(KERN_ERR "Error in vfs_unlink; rc = [%d]\n", rc);
|
|
|
|
goto out_unlock;
|
|
|
|
}
|
2021-01-30 01:35:43 +03:00
|
|
|
fsstack_copy_attr_times(dir, lower_dir);
|
2012-05-23 00:09:50 +04:00
|
|
|
set_nlink(inode, ecryptfs_inode_to_lower(inode)->i_nlink);
|
|
|
|
inode->i_ctime = dir->i_ctime;
|
|
|
|
out_unlock:
|
|
|
|
dput(lower_dentry);
|
2021-01-30 01:35:43 +03:00
|
|
|
inode_unlock(lower_dir);
|
ecryptfs: fix unlink and rmdir in face of underlying fs modifications
A problem similar to the one caught in commit 74dd7c97ea2a ("ecryptfs_rename():
verify that lower dentries are still OK after lock_rename()") exists for
unlink/rmdir as well.
Instead of playing with dget_parent() of underlying dentry of victim
and hoping it's the same as underlying dentry of our directory,
do the following:
* find the underlying dentry of victim
* find the underlying directory of victim's parent (stable
since the victim is ecryptfs dentry and inode of its parent is
held exclusive by the caller).
* lock the inode of dentry underlying the victim's parent
* check that underlying dentry of victim is still hashed and
has the right parent - it can be moved, but it can't be moved to/from
the directory we are holding exclusive. So while ->d_parent itself
might not be stable, the result of comparison is.
If the check passes, everything is fine - underlying directory is locked,
underlying victim is still a child of that directory and we can go ahead
and feed them to vfs_unlink(). As in the current mainline we need to
pin the underlying dentry of victim, so that it wouldn't go negative under
us, but that's the only temporary reference that needs to be grabbed there.
Underlying dentry of parent won't go away (it's pinned by the parent,
which is held by caller), so there's no need to grab it.
The same problem (with the same solution) exists for rmdir. Moreover,
rename gets simpler and more robust with the same "don't bother with
dget_parent()" approach.
Fixes: 74dd7c97ea2 "ecryptfs_rename(): verify that lower dentries are still OK after lock_rename()"
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2019-11-03 20:07:15 +03:00
|
|
|
if (!rc)
|
|
|
|
d_drop(dentry);
|
2012-05-23 00:09:50 +04:00
|
|
|
return rc;
|
|
|
|
}
|
|
|
|
|
2006-10-04 13:16:22 +04:00
|
|
|
/**
|
|
|
|
* ecryptfs_do_create
|
|
|
|
* @directory_inode: inode of the new file's dentry's parent in ecryptfs
|
|
|
|
* @ecryptfs_dentry: New file's dentry in ecryptfs
|
|
|
|
* @mode: The mode of the new file
|
|
|
|
*
|
|
|
|
* Creates the underlying file and the eCryptfs inode which will link to
|
|
|
|
* it. It will also update the eCryptfs directory inode to mimic the
|
|
|
|
* stat of the lower directory inode.
|
|
|
|
*
|
2011-11-22 03:31:02 +04:00
|
|
|
* Returns the new eCryptfs inode on success; an ERR_PTR on error condition
|
2006-10-04 13:16:22 +04:00
|
|
|
*/
|
2011-11-22 03:31:02 +04:00
|
|
|
static struct inode *
|
2006-10-04 13:16:22 +04:00
|
|
|
ecryptfs_do_create(struct inode *directory_inode,
|
2011-07-26 11:30:54 +04:00
|
|
|
struct dentry *ecryptfs_dentry, umode_t mode)
|
2006-10-04 13:16:22 +04:00
|
|
|
{
|
|
|
|
int rc;
|
|
|
|
struct dentry *lower_dentry;
|
2021-01-30 01:35:43 +03:00
|
|
|
struct inode *lower_dir;
|
2011-11-22 03:31:02 +04:00
|
|
|
struct inode *inode;
|
2006-10-04 13:16:22 +04:00
|
|
|
|
2021-01-30 01:35:43 +03:00
|
|
|
rc = lock_parent(ecryptfs_dentry, &lower_dentry, &lower_dir);
|
|
|
|
if (!rc)
|
|
|
|
rc = vfs_create(&init_user_ns, lower_dir,
|
|
|
|
lower_dentry, mode, true);
|
2007-10-16 12:28:09 +04:00
|
|
|
if (rc) {
|
2008-01-09 02:33:02 +03:00
|
|
|
printk(KERN_ERR "%s: Failure to create dentry in lower fs; "
|
2008-04-29 11:59:48 +04:00
|
|
|
"rc = [%d]\n", __func__, rc);
|
2011-11-22 03:31:02 +04:00
|
|
|
inode = ERR_PTR(rc);
|
2008-01-09 02:33:02 +03:00
|
|
|
goto out_lock;
|
2006-10-04 13:16:22 +04:00
|
|
|
}
|
2015-03-18 01:25:59 +03:00
|
|
|
inode = __ecryptfs_get_inode(d_inode(lower_dentry),
|
2011-11-22 03:31:02 +04:00
|
|
|
directory_inode->i_sb);
|
2012-05-23 00:09:50 +04:00
|
|
|
if (IS_ERR(inode)) {
|
2021-01-30 01:35:43 +03:00
|
|
|
vfs_unlink(&init_user_ns, lower_dir, lower_dentry, NULL);
|
2006-10-04 13:16:22 +04:00
|
|
|
goto out_lock;
|
2012-05-23 00:09:50 +04:00
|
|
|
}
|
2021-01-30 01:35:43 +03:00
|
|
|
fsstack_copy_attr_times(directory_inode, lower_dir);
|
|
|
|
fsstack_copy_inode_size(directory_inode, lower_dir);
|
2006-10-04 13:16:22 +04:00
|
|
|
out_lock:
|
2021-01-30 01:35:43 +03:00
|
|
|
inode_unlock(lower_dir);
|
2011-11-22 03:31:02 +04:00
|
|
|
return inode;
|
2006-10-04 13:16:22 +04:00
|
|
|
}
|
|
|
|
|
2021-03-30 19:44:57 +03:00
|
|
|
/*
|
2006-10-04 13:16:22 +04:00
|
|
|
* ecryptfs_initialize_file
|
|
|
|
*
|
|
|
|
* Cause the file to be changed from a basic empty file to an ecryptfs
|
|
|
|
* file with a header and first data page.
|
|
|
|
*
|
|
|
|
* Returns zero on success
|
|
|
|
*/
|
2012-06-21 10:50:59 +04:00
|
|
|
int ecryptfs_initialize_file(struct dentry *ecryptfs_dentry,
|
|
|
|
struct inode *ecryptfs_inode)
|
2006-10-04 13:16:22 +04:00
|
|
|
{
|
2007-10-16 12:28:10 +04:00
|
|
|
struct ecryptfs_crypt_stat *crypt_stat =
|
2011-11-22 03:31:02 +04:00
|
|
|
&ecryptfs_inode_to_private(ecryptfs_inode)->crypt_stat;
|
2006-10-04 13:16:22 +04:00
|
|
|
int rc = 0;
|
|
|
|
|
2011-11-22 03:31:02 +04:00
|
|
|
if (S_ISDIR(ecryptfs_inode->i_mode)) {
|
2006-10-04 13:16:22 +04:00
|
|
|
ecryptfs_printk(KERN_DEBUG, "This is a directory\n");
|
2007-02-12 11:53:49 +03:00
|
|
|
crypt_stat->flags &= ~(ECRYPTFS_ENCRYPTED);
|
2007-10-16 12:28:10 +04:00
|
|
|
goto out;
|
2006-10-04 13:16:22 +04:00
|
|
|
}
|
|
|
|
ecryptfs_printk(KERN_DEBUG, "Initializing crypto context\n");
|
2011-11-22 03:31:02 +04:00
|
|
|
rc = ecryptfs_new_file_context(ecryptfs_inode);
|
2006-10-04 13:16:22 +04:00
|
|
|
if (rc) {
|
2007-10-16 12:28:10 +04:00
|
|
|
ecryptfs_printk(KERN_ERR, "Error creating new file "
|
|
|
|
"context; rc = [%d]\n", rc);
|
|
|
|
goto out;
|
2006-10-04 13:16:22 +04:00
|
|
|
}
|
2011-11-22 03:31:02 +04:00
|
|
|
rc = ecryptfs_get_lower_file(ecryptfs_dentry, ecryptfs_inode);
|
2010-11-03 13:11:28 +03:00
|
|
|
if (rc) {
|
|
|
|
printk(KERN_ERR "%s: Error attempting to initialize "
|
eCryptfs: Add reference counting to lower files
For any given lower inode, eCryptfs keeps only one lower file open and
multiplexes all eCryptfs file operations through that lower file. The
lower file was considered "persistent" and stayed open from the first
lookup through the lifetime of the inode.
This patch keeps the notion of a single, per-inode lower file, but adds
reference counting around the lower file so that it is closed when not
currently in use. If the reference count is at 0 when an operation (such
as open, create, etc.) needs to use the lower file, a new lower file is
opened. Since the file is no longer persistent, all references to the
term persistent file are changed to lower file.
Locking is added around the sections of code that opens the lower file
and assign the pointer in the inode info, as well as the code the fputs
the lower file when all eCryptfs users are done with it.
This patch is needed to fix issues, when mounted on top of the NFSv3
client, where the lower file is left silly renamed until the eCryptfs
inode is destroyed.
Signed-off-by: Tyler Hicks <tyhicks@linux.vnet.ibm.com>
2011-04-15 00:35:11 +04:00
|
|
|
"the lower file for the dentry with name "
|
2013-12-10 19:26:48 +04:00
|
|
|
"[%pd]; rc = [%d]\n", __func__,
|
|
|
|
ecryptfs_dentry, rc);
|
2010-11-03 13:11:28 +03:00
|
|
|
goto out;
|
2008-07-24 08:30:08 +04:00
|
|
|
}
|
2011-11-22 03:31:02 +04:00
|
|
|
rc = ecryptfs_write_metadata(ecryptfs_dentry, ecryptfs_inode);
|
eCryptfs: Add reference counting to lower files
For any given lower inode, eCryptfs keeps only one lower file open and
multiplexes all eCryptfs file operations through that lower file. The
lower file was considered "persistent" and stayed open from the first
lookup through the lifetime of the inode.
This patch keeps the notion of a single, per-inode lower file, but adds
reference counting around the lower file so that it is closed when not
currently in use. If the reference count is at 0 when an operation (such
as open, create, etc.) needs to use the lower file, a new lower file is
opened. Since the file is no longer persistent, all references to the
term persistent file are changed to lower file.
Locking is added around the sections of code that opens the lower file
and assign the pointer in the inode info, as well as the code the fputs
the lower file when all eCryptfs users are done with it.
This patch is needed to fix issues, when mounted on top of the NFSv3
client, where the lower file is left silly renamed until the eCryptfs
inode is destroyed.
Signed-off-by: Tyler Hicks <tyhicks@linux.vnet.ibm.com>
2011-04-15 00:35:11 +04:00
|
|
|
if (rc)
|
2007-10-16 12:28:10 +04:00
|
|
|
printk(KERN_ERR "Error writing headers; rc = [%d]\n", rc);
|
2011-11-22 03:31:02 +04:00
|
|
|
ecryptfs_put_lower_file(ecryptfs_inode);
|
2006-10-04 13:16:22 +04:00
|
|
|
out:
|
|
|
|
return rc;
|
|
|
|
}
|
|
|
|
|
2021-03-30 19:44:57 +03:00
|
|
|
/*
|
2006-10-04 13:16:22 +04:00
|
|
|
* ecryptfs_create
|
|
|
|
* @mode: The mode of the new file.
|
|
|
|
*
|
|
|
|
* Creates a new file.
|
|
|
|
*
|
|
|
|
* Returns zero on success; non-zero on error condition
|
|
|
|
*/
|
|
|
|
static int
|
2021-01-21 16:19:43 +03:00
|
|
|
ecryptfs_create(struct user_namespace *mnt_userns,
|
|
|
|
struct inode *directory_inode, struct dentry *ecryptfs_dentry,
|
2012-06-11 02:05:36 +04:00
|
|
|
umode_t mode, bool excl)
|
2006-10-04 13:16:22 +04:00
|
|
|
{
|
2011-11-22 03:31:02 +04:00
|
|
|
struct inode *ecryptfs_inode;
|
2006-10-04 13:16:22 +04:00
|
|
|
int rc;
|
|
|
|
|
2011-11-22 03:31:02 +04:00
|
|
|
ecryptfs_inode = ecryptfs_do_create(directory_inode, ecryptfs_dentry,
|
|
|
|
mode);
|
2015-08-12 13:29:44 +03:00
|
|
|
if (IS_ERR(ecryptfs_inode)) {
|
2006-10-04 13:16:22 +04:00
|
|
|
ecryptfs_printk(KERN_WARNING, "Failed to create file in"
|
|
|
|
"lower filesystem\n");
|
2011-11-22 03:31:02 +04:00
|
|
|
rc = PTR_ERR(ecryptfs_inode);
|
2006-10-04 13:16:22 +04:00
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
/* At this point, a file exists on "disk"; we need to make sure
|
|
|
|
* that this on disk file is prepared to be an ecryptfs file */
|
2011-11-22 03:31:02 +04:00
|
|
|
rc = ecryptfs_initialize_file(ecryptfs_dentry, ecryptfs_inode);
|
|
|
|
if (rc) {
|
2012-05-23 00:09:50 +04:00
|
|
|
ecryptfs_do_unlink(directory_inode, ecryptfs_dentry,
|
|
|
|
ecryptfs_inode);
|
2015-12-06 02:23:48 +03:00
|
|
|
iget_failed(ecryptfs_inode);
|
2011-11-22 03:31:02 +04:00
|
|
|
goto out;
|
|
|
|
}
|
2018-05-04 15:23:01 +03:00
|
|
|
d_instantiate_new(ecryptfs_dentry, ecryptfs_inode);
|
2006-10-04 13:16:22 +04:00
|
|
|
out:
|
|
|
|
return rc;
|
|
|
|
}
|
|
|
|
|
2011-05-24 13:56:23 +04:00
|
|
|
static int ecryptfs_i_size_read(struct dentry *dentry, struct inode *inode)
|
|
|
|
{
|
|
|
|
struct ecryptfs_crypt_stat *crypt_stat;
|
|
|
|
int rc;
|
|
|
|
|
|
|
|
rc = ecryptfs_get_lower_file(dentry, inode);
|
|
|
|
if (rc) {
|
|
|
|
printk(KERN_ERR "%s: Error attempting to initialize "
|
|
|
|
"the lower file for the dentry with name "
|
2013-12-10 19:26:48 +04:00
|
|
|
"[%pd]; rc = [%d]\n", __func__,
|
|
|
|
dentry, rc);
|
2011-05-24 13:56:23 +04:00
|
|
|
return rc;
|
|
|
|
}
|
|
|
|
|
|
|
|
crypt_stat = &ecryptfs_inode_to_private(inode)->crypt_stat;
|
|
|
|
/* TODO: lock for crypt_stat comparison */
|
|
|
|
if (!(crypt_stat->flags & ECRYPTFS_POLICY_APPLIED))
|
|
|
|
ecryptfs_set_default_sizes(crypt_stat);
|
|
|
|
|
|
|
|
rc = ecryptfs_read_and_validate_header_region(inode);
|
|
|
|
ecryptfs_put_lower_file(inode);
|
|
|
|
if (rc) {
|
|
|
|
rc = ecryptfs_read_and_validate_xattr_region(dentry, inode);
|
|
|
|
if (!rc)
|
|
|
|
crypt_stat->flags |= ECRYPTFS_METADATA_IN_XATTR;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Must return 0 to allow non-eCryptfs files to be looked up, too */
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2021-03-30 19:44:57 +03:00
|
|
|
/*
|
2011-05-24 11:16:51 +04:00
|
|
|
* ecryptfs_lookup_interpose - Dentry interposition for a lookup
|
2006-10-04 13:16:22 +04:00
|
|
|
*/
|
2016-03-28 07:30:35 +03:00
|
|
|
static struct dentry *ecryptfs_lookup_interpose(struct dentry *dentry,
|
|
|
|
struct dentry *lower_dentry)
|
2006-10-04 13:16:22 +04:00
|
|
|
{
|
2022-08-04 20:24:00 +03:00
|
|
|
const struct path *path = ecryptfs_dentry_to_lower_path(dentry->d_parent);
|
2019-11-03 21:45:04 +03:00
|
|
|
struct inode *inode, *lower_inode;
|
2011-05-24 13:56:23 +04:00
|
|
|
struct ecryptfs_dentry_info *dentry_info;
|
|
|
|
int rc = 0;
|
|
|
|
|
|
|
|
dentry_info = kmem_cache_alloc(ecryptfs_dentry_info_cache, GFP_KERNEL);
|
|
|
|
if (!dentry_info) {
|
|
|
|
dput(lower_dentry);
|
2016-03-28 07:30:35 +03:00
|
|
|
return ERR_PTR(-ENOMEM);
|
2006-10-04 13:16:22 +04:00
|
|
|
}
|
2012-07-20 12:09:19 +04:00
|
|
|
|
2016-03-28 07:30:35 +03:00
|
|
|
fsstack_copy_attr_atime(d_inode(dentry->d_parent),
|
2019-11-03 21:55:43 +03:00
|
|
|
d_inode(path->dentry));
|
2013-07-05 18:59:33 +04:00
|
|
|
BUG_ON(!d_count(lower_dentry));
|
2012-07-20 12:09:19 +04:00
|
|
|
|
|
|
|
ecryptfs_set_dentry_private(dentry, dentry_info);
|
2019-11-03 21:55:43 +03:00
|
|
|
dentry_info->lower_path.mnt = mntget(path->mnt);
|
2013-09-16 04:50:13 +04:00
|
|
|
dentry_info->lower_path.dentry = lower_dentry;
|
2011-05-24 13:56:23 +04:00
|
|
|
|
2019-11-03 21:45:04 +03:00
|
|
|
/*
|
|
|
|
* negative dentry can go positive under us here - its parent is not
|
|
|
|
* locked. That's OK and that could happen just as we return from
|
|
|
|
* ecryptfs_lookup() anyway. Just need to be careful and fetch
|
|
|
|
* ->d_inode only once - it's not stable here.
|
|
|
|
*/
|
|
|
|
lower_inode = READ_ONCE(lower_dentry->d_inode);
|
|
|
|
|
|
|
|
if (!lower_inode) {
|
2006-10-04 13:16:22 +04:00
|
|
|
/* We want to add because we couldn't find in lower */
|
2011-05-24 13:56:23 +04:00
|
|
|
d_add(dentry, NULL);
|
2016-03-28 07:30:35 +03:00
|
|
|
return NULL;
|
2006-10-04 13:16:22 +04:00
|
|
|
}
|
2016-03-28 07:30:35 +03:00
|
|
|
inode = __ecryptfs_get_inode(lower_inode, dentry->d_sb);
|
2011-05-24 11:16:51 +04:00
|
|
|
if (IS_ERR(inode)) {
|
2011-05-24 13:56:23 +04:00
|
|
|
printk(KERN_ERR "%s: Error interposing; rc = [%ld]\n",
|
|
|
|
__func__, PTR_ERR(inode));
|
2016-03-28 07:30:35 +03:00
|
|
|
return ERR_CAST(inode);
|
2008-07-24 08:30:08 +04:00
|
|
|
}
|
2011-05-24 13:56:23 +04:00
|
|
|
if (S_ISREG(inode->i_mode)) {
|
|
|
|
rc = ecryptfs_i_size_read(dentry, inode);
|
2007-02-12 11:53:46 +03:00
|
|
|
if (rc) {
|
2011-05-24 13:56:23 +04:00
|
|
|
make_bad_inode(inode);
|
2016-03-28 07:30:35 +03:00
|
|
|
return ERR_PTR(rc);
|
2006-10-04 13:16:22 +04:00
|
|
|
}
|
|
|
|
}
|
2011-05-24 13:56:23 +04:00
|
|
|
|
2011-05-24 12:49:02 +04:00
|
|
|
if (inode->i_state & I_NEW)
|
|
|
|
unlock_new_inode(inode);
|
2016-03-28 07:30:35 +03:00
|
|
|
return d_splice_alias(inode, dentry);
|
2009-01-07 01:42:00 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* ecryptfs_lookup
|
|
|
|
* @ecryptfs_dir_inode: The eCryptfs directory inode
|
|
|
|
* @ecryptfs_dentry: The eCryptfs dentry that we are looking up
|
2015-05-12 15:29:38 +03:00
|
|
|
* @flags: lookup flags
|
2009-01-07 01:42:00 +03:00
|
|
|
*
|
|
|
|
* Find a file on disk. If the file does not exist, then we'll add it to the
|
|
|
|
* dentry cache and continue on to read it from the disk.
|
|
|
|
*/
|
|
|
|
static struct dentry *ecryptfs_lookup(struct inode *ecryptfs_dir_inode,
|
|
|
|
struct dentry *ecryptfs_dentry,
|
2012-06-11 01:13:09 +04:00
|
|
|
unsigned int flags)
|
2009-01-07 01:42:00 +03:00
|
|
|
{
|
|
|
|
char *encrypted_and_encoded_name = NULL;
|
2016-03-28 07:43:29 +03:00
|
|
|
struct ecryptfs_mount_crypt_stat *mount_crypt_stat;
|
2009-01-07 01:42:00 +03:00
|
|
|
struct dentry *lower_dir_dentry, *lower_dentry;
|
2016-03-28 07:43:29 +03:00
|
|
|
const char *name = ecryptfs_dentry->d_name.name;
|
|
|
|
size_t len = ecryptfs_dentry->d_name.len;
|
2016-03-28 07:30:35 +03:00
|
|
|
struct dentry *res;
|
2009-01-07 01:42:00 +03:00
|
|
|
int rc = 0;
|
|
|
|
|
|
|
|
lower_dir_dentry = ecryptfs_dentry_to_lower(ecryptfs_dentry->d_parent);
|
2016-03-28 07:43:29 +03:00
|
|
|
|
2009-03-20 10:23:57 +03:00
|
|
|
mount_crypt_stat = &ecryptfs_superblock_to_private(
|
|
|
|
ecryptfs_dentry->d_sb)->mount_crypt_stat;
|
2018-01-19 05:40:25 +03:00
|
|
|
if (mount_crypt_stat->flags & ECRYPTFS_GLOBAL_ENCRYPT_FILENAMES) {
|
2016-03-28 07:43:29 +03:00
|
|
|
rc = ecryptfs_encrypt_and_encode_filename(
|
|
|
|
&encrypted_and_encoded_name, &len,
|
|
|
|
mount_crypt_stat, name, len);
|
|
|
|
if (rc) {
|
|
|
|
printk(KERN_ERR "%s: Error attempting to encrypt and encode "
|
|
|
|
"filename; rc = [%d]\n", __func__, rc);
|
|
|
|
return ERR_PTR(rc);
|
|
|
|
}
|
|
|
|
name = encrypted_and_encoded_name;
|
2009-01-07 01:42:00 +03:00
|
|
|
}
|
2016-03-28 07:43:29 +03:00
|
|
|
|
|
|
|
lower_dentry = lookup_one_len_unlocked(name, lower_dir_dentry, len);
|
2009-01-07 01:42:00 +03:00
|
|
|
if (IS_ERR(lower_dentry)) {
|
2011-02-18 03:51:24 +03:00
|
|
|
ecryptfs_printk(KERN_DEBUG, "%s: lookup_one_len() returned "
|
2016-03-28 07:30:35 +03:00
|
|
|
"[%ld] on lower_dentry = [%s]\n", __func__,
|
|
|
|
PTR_ERR(lower_dentry),
|
2016-03-28 07:43:29 +03:00
|
|
|
name);
|
2016-03-28 07:30:35 +03:00
|
|
|
res = ERR_CAST(lower_dentry);
|
2016-03-28 07:43:29 +03:00
|
|
|
} else {
|
|
|
|
res = ecryptfs_lookup_interpose(ecryptfs_dentry, lower_dentry);
|
2009-01-07 01:42:00 +03:00
|
|
|
}
|
|
|
|
kfree(encrypted_and_encoded_name);
|
2016-03-28 07:30:35 +03:00
|
|
|
return res;
|
2006-10-04 13:16:22 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
static int ecryptfs_link(struct dentry *old_dentry, struct inode *dir,
|
|
|
|
struct dentry *new_dentry)
|
|
|
|
{
|
|
|
|
struct dentry *lower_old_dentry;
|
|
|
|
struct dentry *lower_new_dentry;
|
2021-01-30 01:35:43 +03:00
|
|
|
struct inode *lower_dir;
|
2006-10-04 13:16:22 +04:00
|
|
|
u64 file_size_save;
|
|
|
|
int rc;
|
|
|
|
|
2015-03-18 01:25:59 +03:00
|
|
|
file_size_save = i_size_read(d_inode(old_dentry));
|
2006-10-04 13:16:22 +04:00
|
|
|
lower_old_dentry = ecryptfs_dentry_to_lower(old_dentry);
|
2021-01-30 01:35:43 +03:00
|
|
|
rc = lock_parent(new_dentry, &lower_new_dentry, &lower_dir);
|
|
|
|
if (!rc)
|
|
|
|
rc = vfs_link(lower_old_dentry, &init_user_ns, lower_dir,
|
|
|
|
lower_new_dentry, NULL);
|
2015-03-18 01:25:59 +03:00
|
|
|
if (rc || d_really_is_negative(lower_new_dentry))
|
2006-10-04 13:16:22 +04:00
|
|
|
goto out_lock;
|
2011-05-24 11:16:51 +04:00
|
|
|
rc = ecryptfs_interpose(lower_new_dentry, new_dentry, dir->i_sb);
|
2006-10-04 13:16:22 +04:00
|
|
|
if (rc)
|
|
|
|
goto out_lock;
|
2021-01-30 01:35:43 +03:00
|
|
|
fsstack_copy_attr_times(dir, lower_dir);
|
|
|
|
fsstack_copy_inode_size(dir, lower_dir);
|
2015-03-18 01:25:59 +03:00
|
|
|
set_nlink(d_inode(old_dentry),
|
|
|
|
ecryptfs_inode_to_lower(d_inode(old_dentry))->i_nlink);
|
|
|
|
i_size_write(d_inode(new_dentry), file_size_save);
|
2006-10-04 13:16:22 +04:00
|
|
|
out_lock:
|
2021-01-30 01:35:43 +03:00
|
|
|
inode_unlock(lower_dir);
|
2006-10-04 13:16:22 +04:00
|
|
|
return rc;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int ecryptfs_unlink(struct inode *dir, struct dentry *dentry)
|
|
|
|
{
|
2015-03-18 01:25:59 +03:00
|
|
|
return ecryptfs_do_unlink(dir, dentry, d_inode(dentry));
|
2006-10-04 13:16:22 +04:00
|
|
|
}
|
|
|
|
|
2021-01-21 16:19:43 +03:00
|
|
|
static int ecryptfs_symlink(struct user_namespace *mnt_userns,
|
|
|
|
struct inode *dir, struct dentry *dentry,
|
2006-10-04 13:16:22 +04:00
|
|
|
const char *symname)
|
|
|
|
{
|
|
|
|
int rc;
|
|
|
|
struct dentry *lower_dentry;
|
2021-01-30 01:35:43 +03:00
|
|
|
struct inode *lower_dir;
|
2006-10-04 13:16:22 +04:00
|
|
|
char *encoded_symname;
|
2009-01-07 01:42:00 +03:00
|
|
|
size_t encoded_symlen;
|
|
|
|
struct ecryptfs_mount_crypt_stat *mount_crypt_stat = NULL;
|
2006-10-04 13:16:22 +04:00
|
|
|
|
2021-01-30 01:35:43 +03:00
|
|
|
rc = lock_parent(dentry, &lower_dentry, &lower_dir);
|
|
|
|
if (rc)
|
|
|
|
goto out_lock;
|
2009-01-07 01:42:00 +03:00
|
|
|
mount_crypt_stat = &ecryptfs_superblock_to_private(
|
|
|
|
dir->i_sb)->mount_crypt_stat;
|
|
|
|
rc = ecryptfs_encrypt_and_encode_filename(&encoded_symname,
|
|
|
|
&encoded_symlen,
|
|
|
|
mount_crypt_stat, symname,
|
|
|
|
strlen(symname));
|
|
|
|
if (rc)
|
2006-10-04 13:16:22 +04:00
|
|
|
goto out_lock;
|
2021-01-30 01:35:43 +03:00
|
|
|
rc = vfs_symlink(&init_user_ns, lower_dir, lower_dentry,
|
2008-06-24 18:50:16 +04:00
|
|
|
encoded_symname);
|
2006-10-04 13:16:22 +04:00
|
|
|
kfree(encoded_symname);
|
2015-03-18 01:25:59 +03:00
|
|
|
if (rc || d_really_is_negative(lower_dentry))
|
2006-10-04 13:16:22 +04:00
|
|
|
goto out_lock;
|
2011-05-24 11:16:51 +04:00
|
|
|
rc = ecryptfs_interpose(lower_dentry, dentry, dir->i_sb);
|
2006-10-04 13:16:22 +04:00
|
|
|
if (rc)
|
|
|
|
goto out_lock;
|
2021-01-30 01:35:43 +03:00
|
|
|
fsstack_copy_attr_times(dir, lower_dir);
|
|
|
|
fsstack_copy_inode_size(dir, lower_dir);
|
2006-10-04 13:16:22 +04:00
|
|
|
out_lock:
|
2021-01-30 01:35:43 +03:00
|
|
|
inode_unlock(lower_dir);
|
2015-03-18 01:25:59 +03:00
|
|
|
if (d_really_is_negative(dentry))
|
2006-10-04 13:16:22 +04:00
|
|
|
d_drop(dentry);
|
|
|
|
return rc;
|
|
|
|
}
|
|
|
|
|
2021-01-21 16:19:43 +03:00
|
|
|
static int ecryptfs_mkdir(struct user_namespace *mnt_userns, struct inode *dir,
|
|
|
|
struct dentry *dentry, umode_t mode)
|
2006-10-04 13:16:22 +04:00
|
|
|
{
|
|
|
|
int rc;
|
|
|
|
struct dentry *lower_dentry;
|
2021-01-30 01:35:43 +03:00
|
|
|
struct inode *lower_dir;
|
2006-10-04 13:16:22 +04:00
|
|
|
|
2021-01-30 01:35:43 +03:00
|
|
|
rc = lock_parent(dentry, &lower_dentry, &lower_dir);
|
|
|
|
if (!rc)
|
|
|
|
rc = vfs_mkdir(&init_user_ns, lower_dir,
|
|
|
|
lower_dentry, mode);
|
2015-03-18 01:25:59 +03:00
|
|
|
if (rc || d_really_is_negative(lower_dentry))
|
2006-10-04 13:16:22 +04:00
|
|
|
goto out;
|
2011-05-24 11:16:51 +04:00
|
|
|
rc = ecryptfs_interpose(lower_dentry, dentry, dir->i_sb);
|
2006-10-04 13:16:22 +04:00
|
|
|
if (rc)
|
|
|
|
goto out;
|
2021-01-30 01:35:43 +03:00
|
|
|
fsstack_copy_attr_times(dir, lower_dir);
|
|
|
|
fsstack_copy_inode_size(dir, lower_dir);
|
|
|
|
set_nlink(dir, lower_dir->i_nlink);
|
2006-10-04 13:16:22 +04:00
|
|
|
out:
|
2021-01-30 01:35:43 +03:00
|
|
|
inode_unlock(lower_dir);
|
2015-03-18 01:25:59 +03:00
|
|
|
if (d_really_is_negative(dentry))
|
2006-10-04 13:16:22 +04:00
|
|
|
d_drop(dentry);
|
|
|
|
return rc;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int ecryptfs_rmdir(struct inode *dir, struct dentry *dentry)
|
|
|
|
{
|
|
|
|
struct dentry *lower_dentry;
|
2021-01-30 01:35:43 +03:00
|
|
|
struct inode *lower_dir;
|
2006-10-31 09:07:20 +03:00
|
|
|
int rc;
|
2006-10-04 13:16:22 +04:00
|
|
|
|
2021-01-30 01:35:43 +03:00
|
|
|
rc = lock_parent(dentry, &lower_dentry, &lower_dir);
|
ecryptfs: fix unlink and rmdir in face of underlying fs modifications
A problem similar to the one caught in commit 74dd7c97ea2a ("ecryptfs_rename():
verify that lower dentries are still OK after lock_rename()") exists for
unlink/rmdir as well.
Instead of playing with dget_parent() of underlying dentry of victim
and hoping it's the same as underlying dentry of our directory,
do the following:
* find the underlying dentry of victim
* find the underlying directory of victim's parent (stable
since the victim is ecryptfs dentry and inode of its parent is
held exclusive by the caller).
* lock the inode of dentry underlying the victim's parent
* check that underlying dentry of victim is still hashed and
has the right parent - it can be moved, but it can't be moved to/from
the directory we are holding exclusive. So while ->d_parent itself
might not be stable, the result of comparison is.
If the check passes, everything is fine - underlying directory is locked,
underlying victim is still a child of that directory and we can go ahead
and feed them to vfs_unlink(). As in the current mainline we need to
pin the underlying dentry of victim, so that it wouldn't go negative under
us, but that's the only temporary reference that needs to be grabbed there.
Underlying dentry of parent won't go away (it's pinned by the parent,
which is held by caller), so there's no need to grab it.
The same problem (with the same solution) exists for rmdir. Moreover,
rename gets simpler and more robust with the same "don't bother with
dget_parent()" approach.
Fixes: 74dd7c97ea2 "ecryptfs_rename(): verify that lower dentries are still OK after lock_rename()"
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2019-11-03 20:07:15 +03:00
|
|
|
dget(lower_dentry); // don't even try to make the lower negative
|
2021-01-30 01:35:43 +03:00
|
|
|
if (!rc) {
|
|
|
|
if (d_unhashed(lower_dentry))
|
|
|
|
rc = -EINVAL;
|
|
|
|
else
|
|
|
|
rc = vfs_rmdir(&init_user_ns, lower_dir, lower_dentry);
|
|
|
|
}
|
ecryptfs: fix unlink and rmdir in face of underlying fs modifications
A problem similar to the one caught in commit 74dd7c97ea2a ("ecryptfs_rename():
verify that lower dentries are still OK after lock_rename()") exists for
unlink/rmdir as well.
Instead of playing with dget_parent() of underlying dentry of victim
and hoping it's the same as underlying dentry of our directory,
do the following:
* find the underlying dentry of victim
* find the underlying directory of victim's parent (stable
since the victim is ecryptfs dentry and inode of its parent is
held exclusive by the caller).
* lock the inode of dentry underlying the victim's parent
* check that underlying dentry of victim is still hashed and
has the right parent - it can be moved, but it can't be moved to/from
the directory we are holding exclusive. So while ->d_parent itself
might not be stable, the result of comparison is.
If the check passes, everything is fine - underlying directory is locked,
underlying victim is still a child of that directory and we can go ahead
and feed them to vfs_unlink(). As in the current mainline we need to
pin the underlying dentry of victim, so that it wouldn't go negative under
us, but that's the only temporary reference that needs to be grabbed there.
Underlying dentry of parent won't go away (it's pinned by the parent,
which is held by caller), so there's no need to grab it.
The same problem (with the same solution) exists for rmdir. Moreover,
rename gets simpler and more robust with the same "don't bother with
dget_parent()" approach.
Fixes: 74dd7c97ea2 "ecryptfs_rename(): verify that lower dentries are still OK after lock_rename()"
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2019-11-03 20:07:15 +03:00
|
|
|
if (!rc) {
|
2015-03-18 01:25:59 +03:00
|
|
|
clear_nlink(d_inode(dentry));
|
2021-01-30 01:35:43 +03:00
|
|
|
fsstack_copy_attr_times(dir, lower_dir);
|
|
|
|
set_nlink(dir, lower_dir->i_nlink);
|
ecryptfs: fix unlink and rmdir in face of underlying fs modifications
A problem similar to the one caught in commit 74dd7c97ea2a ("ecryptfs_rename():
verify that lower dentries are still OK after lock_rename()") exists for
unlink/rmdir as well.
Instead of playing with dget_parent() of underlying dentry of victim
and hoping it's the same as underlying dentry of our directory,
do the following:
* find the underlying dentry of victim
* find the underlying directory of victim's parent (stable
since the victim is ecryptfs dentry and inode of its parent is
held exclusive by the caller).
* lock the inode of dentry underlying the victim's parent
* check that underlying dentry of victim is still hashed and
has the right parent - it can be moved, but it can't be moved to/from
the directory we are holding exclusive. So while ->d_parent itself
might not be stable, the result of comparison is.
If the check passes, everything is fine - underlying directory is locked,
underlying victim is still a child of that directory and we can go ahead
and feed them to vfs_unlink(). As in the current mainline we need to
pin the underlying dentry of victim, so that it wouldn't go negative under
us, but that's the only temporary reference that needs to be grabbed there.
Underlying dentry of parent won't go away (it's pinned by the parent,
which is held by caller), so there's no need to grab it.
The same problem (with the same solution) exists for rmdir. Moreover,
rename gets simpler and more robust with the same "don't bother with
dget_parent()" approach.
Fixes: 74dd7c97ea2 "ecryptfs_rename(): verify that lower dentries are still OK after lock_rename()"
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2019-11-03 20:07:15 +03:00
|
|
|
}
|
|
|
|
dput(lower_dentry);
|
2021-01-30 01:35:43 +03:00
|
|
|
inode_unlock(lower_dir);
|
2006-10-04 13:16:22 +04:00
|
|
|
if (!rc)
|
|
|
|
d_drop(dentry);
|
|
|
|
return rc;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
2021-01-21 16:19:43 +03:00
|
|
|
ecryptfs_mknod(struct user_namespace *mnt_userns, struct inode *dir,
|
|
|
|
struct dentry *dentry, umode_t mode, dev_t dev)
|
2006-10-04 13:16:22 +04:00
|
|
|
{
|
|
|
|
int rc;
|
|
|
|
struct dentry *lower_dentry;
|
2021-01-30 01:35:43 +03:00
|
|
|
struct inode *lower_dir;
|
2006-10-04 13:16:22 +04:00
|
|
|
|
2021-01-30 01:35:43 +03:00
|
|
|
rc = lock_parent(dentry, &lower_dentry, &lower_dir);
|
|
|
|
if (!rc)
|
|
|
|
rc = vfs_mknod(&init_user_ns, lower_dir,
|
|
|
|
lower_dentry, mode, dev);
|
2015-03-18 01:25:59 +03:00
|
|
|
if (rc || d_really_is_negative(lower_dentry))
|
2006-10-04 13:16:22 +04:00
|
|
|
goto out;
|
2011-05-24 11:16:51 +04:00
|
|
|
rc = ecryptfs_interpose(lower_dentry, dentry, dir->i_sb);
|
2006-10-04 13:16:22 +04:00
|
|
|
if (rc)
|
|
|
|
goto out;
|
2021-01-30 01:35:43 +03:00
|
|
|
fsstack_copy_attr_times(dir, lower_dir);
|
|
|
|
fsstack_copy_inode_size(dir, lower_dir);
|
2006-10-04 13:16:22 +04:00
|
|
|
out:
|
2021-01-30 01:35:43 +03:00
|
|
|
inode_unlock(lower_dir);
|
2015-03-18 01:25:59 +03:00
|
|
|
if (d_really_is_negative(dentry))
|
2006-10-04 13:16:22 +04:00
|
|
|
d_drop(dentry);
|
|
|
|
return rc;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
2021-01-21 16:19:43 +03:00
|
|
|
ecryptfs_rename(struct user_namespace *mnt_userns, struct inode *old_dir,
|
|
|
|
struct dentry *old_dentry, struct inode *new_dir,
|
|
|
|
struct dentry *new_dentry, unsigned int flags)
|
2006-10-04 13:16:22 +04:00
|
|
|
{
|
|
|
|
int rc;
|
|
|
|
struct dentry *lower_old_dentry;
|
|
|
|
struct dentry *lower_new_dentry;
|
|
|
|
struct dentry *lower_old_dir_dentry;
|
|
|
|
struct dentry *lower_new_dir_dentry;
|
ecryptfs: fix unlink and rmdir in face of underlying fs modifications
A problem similar to the one caught in commit 74dd7c97ea2a ("ecryptfs_rename():
verify that lower dentries are still OK after lock_rename()") exists for
unlink/rmdir as well.
Instead of playing with dget_parent() of underlying dentry of victim
and hoping it's the same as underlying dentry of our directory,
do the following:
* find the underlying dentry of victim
* find the underlying directory of victim's parent (stable
since the victim is ecryptfs dentry and inode of its parent is
held exclusive by the caller).
* lock the inode of dentry underlying the victim's parent
* check that underlying dentry of victim is still hashed and
has the right parent - it can be moved, but it can't be moved to/from
the directory we are holding exclusive. So while ->d_parent itself
might not be stable, the result of comparison is.
If the check passes, everything is fine - underlying directory is locked,
underlying victim is still a child of that directory and we can go ahead
and feed them to vfs_unlink(). As in the current mainline we need to
pin the underlying dentry of victim, so that it wouldn't go negative under
us, but that's the only temporary reference that needs to be grabbed there.
Underlying dentry of parent won't go away (it's pinned by the parent,
which is held by caller), so there's no need to grab it.
The same problem (with the same solution) exists for rmdir. Moreover,
rename gets simpler and more robust with the same "don't bother with
dget_parent()" approach.
Fixes: 74dd7c97ea2 "ecryptfs_rename(): verify that lower dentries are still OK after lock_rename()"
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2019-11-03 20:07:15 +03:00
|
|
|
struct dentry *trap;
|
2012-09-13 23:00:56 +04:00
|
|
|
struct inode *target_inode;
|
2021-01-21 16:19:32 +03:00
|
|
|
struct renamedata rd = {};
|
2006-10-04 13:16:22 +04:00
|
|
|
|
fs: make remaining filesystems use .rename2
This is trivial to do:
- add flags argument to foo_rename()
- check if flags is zero
- assign foo_rename() to .rename2 instead of .rename
This doesn't mean it's impossible to support RENAME_NOREPLACE for these
filesystems, but it is not trivial, like for local filesystems.
RENAME_NOREPLACE must guarantee atomicity (i.e. it shouldn't be possible
for a file to be created on one host while it is overwritten by rename on
another host).
Filesystems converted:
9p, afs, ceph, coda, ecryptfs, kernfs, lustre, ncpfs, nfs, ocfs2, orangefs.
After this, we can get rid of the duplicate interfaces for rename.
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Acked-by: David Howells <dhowells@redhat.com> [AFS]
Acked-by: Mike Marshall <hubcap@omnibond.com>
Cc: Eric Van Hensbergen <ericvh@gmail.com>
Cc: Ilya Dryomov <idryomov@gmail.com>
Cc: Jan Harkes <jaharkes@cs.cmu.edu>
Cc: Tyler Hicks <tyhicks@canonical.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Cc: Trond Myklebust <trond.myklebust@primarydata.com>
Cc: Mark Fasheh <mfasheh@suse.com>
2016-09-27 12:03:58 +03:00
|
|
|
if (flags)
|
|
|
|
return -EINVAL;
|
|
|
|
|
ecryptfs: fix unlink and rmdir in face of underlying fs modifications
A problem similar to the one caught in commit 74dd7c97ea2a ("ecryptfs_rename():
verify that lower dentries are still OK after lock_rename()") exists for
unlink/rmdir as well.
Instead of playing with dget_parent() of underlying dentry of victim
and hoping it's the same as underlying dentry of our directory,
do the following:
* find the underlying dentry of victim
* find the underlying directory of victim's parent (stable
since the victim is ecryptfs dentry and inode of its parent is
held exclusive by the caller).
* lock the inode of dentry underlying the victim's parent
* check that underlying dentry of victim is still hashed and
has the right parent - it can be moved, but it can't be moved to/from
the directory we are holding exclusive. So while ->d_parent itself
might not be stable, the result of comparison is.
If the check passes, everything is fine - underlying directory is locked,
underlying victim is still a child of that directory and we can go ahead
and feed them to vfs_unlink(). As in the current mainline we need to
pin the underlying dentry of victim, so that it wouldn't go negative under
us, but that's the only temporary reference that needs to be grabbed there.
Underlying dentry of parent won't go away (it's pinned by the parent,
which is held by caller), so there's no need to grab it.
The same problem (with the same solution) exists for rmdir. Moreover,
rename gets simpler and more robust with the same "don't bother with
dget_parent()" approach.
Fixes: 74dd7c97ea2 "ecryptfs_rename(): verify that lower dentries are still OK after lock_rename()"
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2019-11-03 20:07:15 +03:00
|
|
|
lower_old_dir_dentry = ecryptfs_dentry_to_lower(old_dentry->d_parent);
|
|
|
|
lower_new_dir_dentry = ecryptfs_dentry_to_lower(new_dentry->d_parent);
|
|
|
|
|
2006-10-04 13:16:22 +04:00
|
|
|
lower_old_dentry = ecryptfs_dentry_to_lower(old_dentry);
|
|
|
|
lower_new_dentry = ecryptfs_dentry_to_lower(new_dentry);
|
ecryptfs: fix unlink and rmdir in face of underlying fs modifications
A problem similar to the one caught in commit 74dd7c97ea2a ("ecryptfs_rename():
verify that lower dentries are still OK after lock_rename()") exists for
unlink/rmdir as well.
Instead of playing with dget_parent() of underlying dentry of victim
and hoping it's the same as underlying dentry of our directory,
do the following:
* find the underlying dentry of victim
* find the underlying directory of victim's parent (stable
since the victim is ecryptfs dentry and inode of its parent is
held exclusive by the caller).
* lock the inode of dentry underlying the victim's parent
* check that underlying dentry of victim is still hashed and
has the right parent - it can be moved, but it can't be moved to/from
the directory we are holding exclusive. So while ->d_parent itself
might not be stable, the result of comparison is.
If the check passes, everything is fine - underlying directory is locked,
underlying victim is still a child of that directory and we can go ahead
and feed them to vfs_unlink(). As in the current mainline we need to
pin the underlying dentry of victim, so that it wouldn't go negative under
us, but that's the only temporary reference that needs to be grabbed there.
Underlying dentry of parent won't go away (it's pinned by the parent,
which is held by caller), so there's no need to grab it.
The same problem (with the same solution) exists for rmdir. Moreover,
rename gets simpler and more robust with the same "don't bother with
dget_parent()" approach.
Fixes: 74dd7c97ea2 "ecryptfs_rename(): verify that lower dentries are still OK after lock_rename()"
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2019-11-03 20:07:15 +03:00
|
|
|
|
2015-03-18 01:25:59 +03:00
|
|
|
target_inode = d_inode(new_dentry);
|
ecryptfs: fix unlink and rmdir in face of underlying fs modifications
A problem similar to the one caught in commit 74dd7c97ea2a ("ecryptfs_rename():
verify that lower dentries are still OK after lock_rename()") exists for
unlink/rmdir as well.
Instead of playing with dget_parent() of underlying dentry of victim
and hoping it's the same as underlying dentry of our directory,
do the following:
* find the underlying dentry of victim
* find the underlying directory of victim's parent (stable
since the victim is ecryptfs dentry and inode of its parent is
held exclusive by the caller).
* lock the inode of dentry underlying the victim's parent
* check that underlying dentry of victim is still hashed and
has the right parent - it can be moved, but it can't be moved to/from
the directory we are holding exclusive. So while ->d_parent itself
might not be stable, the result of comparison is.
If the check passes, everything is fine - underlying directory is locked,
underlying victim is still a child of that directory and we can go ahead
and feed them to vfs_unlink(). As in the current mainline we need to
pin the underlying dentry of victim, so that it wouldn't go negative under
us, but that's the only temporary reference that needs to be grabbed there.
Underlying dentry of parent won't go away (it's pinned by the parent,
which is held by caller), so there's no need to grab it.
The same problem (with the same solution) exists for rmdir. Moreover,
rename gets simpler and more robust with the same "don't bother with
dget_parent()" approach.
Fixes: 74dd7c97ea2 "ecryptfs_rename(): verify that lower dentries are still OK after lock_rename()"
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2019-11-03 20:07:15 +03:00
|
|
|
|
2009-12-06 05:17:09 +03:00
|
|
|
trap = lock_rename(lower_old_dir_dentry, lower_new_dir_dentry);
|
ecryptfs: fix unlink and rmdir in face of underlying fs modifications
A problem similar to the one caught in commit 74dd7c97ea2a ("ecryptfs_rename():
verify that lower dentries are still OK after lock_rename()") exists for
unlink/rmdir as well.
Instead of playing with dget_parent() of underlying dentry of victim
and hoping it's the same as underlying dentry of our directory,
do the following:
* find the underlying dentry of victim
* find the underlying directory of victim's parent (stable
since the victim is ecryptfs dentry and inode of its parent is
held exclusive by the caller).
* lock the inode of dentry underlying the victim's parent
* check that underlying dentry of victim is still hashed and
has the right parent - it can be moved, but it can't be moved to/from
the directory we are holding exclusive. So while ->d_parent itself
might not be stable, the result of comparison is.
If the check passes, everything is fine - underlying directory is locked,
underlying victim is still a child of that directory and we can go ahead
and feed them to vfs_unlink(). As in the current mainline we need to
pin the underlying dentry of victim, so that it wouldn't go negative under
us, but that's the only temporary reference that needs to be grabbed there.
Underlying dentry of parent won't go away (it's pinned by the parent,
which is held by caller), so there's no need to grab it.
The same problem (with the same solution) exists for rmdir. Moreover,
rename gets simpler and more robust with the same "don't bother with
dget_parent()" approach.
Fixes: 74dd7c97ea2 "ecryptfs_rename(): verify that lower dentries are still OK after lock_rename()"
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2019-11-03 20:07:15 +03:00
|
|
|
dget(lower_new_dentry);
|
2018-10-10 06:32:41 +03:00
|
|
|
rc = -EINVAL;
|
|
|
|
if (lower_old_dentry->d_parent != lower_old_dir_dentry)
|
|
|
|
goto out_lock;
|
|
|
|
if (lower_new_dentry->d_parent != lower_new_dir_dentry)
|
|
|
|
goto out_lock;
|
|
|
|
if (d_unhashed(lower_old_dentry) || d_unhashed(lower_new_dentry))
|
|
|
|
goto out_lock;
|
2009-12-06 05:17:09 +03:00
|
|
|
/* source should not be ancestor of target */
|
2018-10-10 06:32:41 +03:00
|
|
|
if (trap == lower_old_dentry)
|
2009-12-06 05:17:09 +03:00
|
|
|
goto out_lock;
|
|
|
|
/* target should not be ancestor of source */
|
|
|
|
if (trap == lower_new_dentry) {
|
|
|
|
rc = -ENOTEMPTY;
|
|
|
|
goto out_lock;
|
|
|
|
}
|
2021-01-21 16:19:32 +03:00
|
|
|
|
2021-01-21 16:19:33 +03:00
|
|
|
rd.old_mnt_userns = &init_user_ns;
|
|
|
|
rd.old_dir = d_inode(lower_old_dir_dentry);
|
|
|
|
rd.old_dentry = lower_old_dentry;
|
|
|
|
rd.new_mnt_userns = &init_user_ns;
|
|
|
|
rd.new_dir = d_inode(lower_new_dir_dentry);
|
|
|
|
rd.new_dentry = lower_new_dentry;
|
2021-01-21 16:19:32 +03:00
|
|
|
rc = vfs_rename(&rd);
|
2006-10-04 13:16:22 +04:00
|
|
|
if (rc)
|
|
|
|
goto out_lock;
|
2012-09-13 23:00:56 +04:00
|
|
|
if (target_inode)
|
|
|
|
fsstack_copy_attr_all(target_inode,
|
|
|
|
ecryptfs_inode_to_lower(target_inode));
|
2015-03-18 01:25:59 +03:00
|
|
|
fsstack_copy_attr_all(new_dir, d_inode(lower_new_dir_dentry));
|
2006-10-04 13:16:22 +04:00
|
|
|
if (new_dir != old_dir)
|
2015-03-18 01:25:59 +03:00
|
|
|
fsstack_copy_attr_all(old_dir, d_inode(lower_old_dir_dentry));
|
2006-10-04 13:16:22 +04:00
|
|
|
out_lock:
|
|
|
|
dput(lower_new_dentry);
|
ecryptfs: fix unlink and rmdir in face of underlying fs modifications
A problem similar to the one caught in commit 74dd7c97ea2a ("ecryptfs_rename():
verify that lower dentries are still OK after lock_rename()") exists for
unlink/rmdir as well.
Instead of playing with dget_parent() of underlying dentry of victim
and hoping it's the same as underlying dentry of our directory,
do the following:
* find the underlying dentry of victim
* find the underlying directory of victim's parent (stable
since the victim is ecryptfs dentry and inode of its parent is
held exclusive by the caller).
* lock the inode of dentry underlying the victim's parent
* check that underlying dentry of victim is still hashed and
has the right parent - it can be moved, but it can't be moved to/from
the directory we are holding exclusive. So while ->d_parent itself
might not be stable, the result of comparison is.
If the check passes, everything is fine - underlying directory is locked,
underlying victim is still a child of that directory and we can go ahead
and feed them to vfs_unlink(). As in the current mainline we need to
pin the underlying dentry of victim, so that it wouldn't go negative under
us, but that's the only temporary reference that needs to be grabbed there.
Underlying dentry of parent won't go away (it's pinned by the parent,
which is held by caller), so there's no need to grab it.
The same problem (with the same solution) exists for rmdir. Moreover,
rename gets simpler and more robust with the same "don't bother with
dget_parent()" approach.
Fixes: 74dd7c97ea2 "ecryptfs_rename(): verify that lower dentries are still OK after lock_rename()"
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2019-11-03 20:07:15 +03:00
|
|
|
unlock_rename(lower_old_dir_dentry, lower_new_dir_dentry);
|
2006-10-04 13:16:22 +04:00
|
|
|
return rc;
|
|
|
|
}
|
|
|
|
|
2013-11-30 07:51:47 +04:00
|
|
|
static char *ecryptfs_readlink_lower(struct dentry *dentry, size_t *bufsiz)
|
2006-10-04 13:16:22 +04:00
|
|
|
{
|
2016-12-09 18:45:03 +03:00
|
|
|
DEFINE_DELAYED_CALL(done);
|
2010-03-22 08:41:35 +03:00
|
|
|
struct dentry *lower_dentry = ecryptfs_dentry_to_lower(dentry);
|
2016-12-09 18:45:03 +03:00
|
|
|
const char *link;
|
2013-11-30 07:51:47 +04:00
|
|
|
char *buf;
|
2009-01-07 01:42:00 +03:00
|
|
|
int rc;
|
2006-10-04 13:16:22 +04:00
|
|
|
|
2016-12-09 18:45:03 +03:00
|
|
|
link = vfs_get_link(lower_dentry, &done);
|
|
|
|
if (IS_ERR(link))
|
|
|
|
return ERR_CAST(link);
|
|
|
|
|
2013-11-30 07:51:47 +04:00
|
|
|
rc = ecryptfs_decode_and_decrypt_filename(&buf, bufsiz, dentry->d_sb,
|
2016-12-09 18:45:03 +03:00
|
|
|
link, strlen(link));
|
|
|
|
do_delayed_call(&done);
|
|
|
|
if (rc)
|
|
|
|
return ERR_PTR(rc);
|
|
|
|
|
|
|
|
return buf;
|
2010-03-22 08:41:35 +03:00
|
|
|
}
|
|
|
|
|
2015-11-17 18:20:54 +03:00
|
|
|
static const char *ecryptfs_get_link(struct dentry *dentry,
|
2015-12-29 23:58:39 +03:00
|
|
|
struct inode *inode,
|
|
|
|
struct delayed_call *done)
|
2010-03-22 08:41:35 +03:00
|
|
|
{
|
2013-11-30 07:51:47 +04:00
|
|
|
size_t len;
|
2015-11-17 18:20:54 +03:00
|
|
|
char *buf;
|
|
|
|
|
|
|
|
if (!dentry)
|
|
|
|
return ERR_PTR(-ECHILD);
|
|
|
|
|
|
|
|
buf = ecryptfs_readlink_lower(dentry, &len);
|
2013-11-30 07:51:47 +04:00
|
|
|
if (IS_ERR(buf))
|
2015-05-02 20:32:22 +03:00
|
|
|
return buf;
|
2015-03-18 01:25:59 +03:00
|
|
|
fsstack_copy_attr_atime(d_inode(dentry),
|
|
|
|
d_inode(ecryptfs_dentry_to_lower(dentry)));
|
2012-05-03 17:34:20 +04:00
|
|
|
buf[len] = '\0';
|
2015-12-29 23:58:39 +03:00
|
|
|
set_delayed_call(done, kfree_link, buf);
|
|
|
|
return buf;
|
2006-10-04 13:16:22 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* upper_size_to_lower_size
|
|
|
|
* @crypt_stat: Crypt_stat associated with file
|
|
|
|
* @upper_size: Size of the upper file
|
|
|
|
*
|
2008-02-06 12:38:32 +03:00
|
|
|
* Calculate the required size of the lower file based on the
|
2006-10-04 13:16:22 +04:00
|
|
|
* specified size of the upper file. This calculation is based on the
|
|
|
|
* number of headers in the underlying file and the extent size.
|
|
|
|
*
|
|
|
|
* Returns Calculated size of the lower file.
|
|
|
|
*/
|
|
|
|
static loff_t
|
|
|
|
upper_size_to_lower_size(struct ecryptfs_crypt_stat *crypt_stat,
|
|
|
|
loff_t upper_size)
|
|
|
|
{
|
|
|
|
loff_t lower_size;
|
|
|
|
|
2010-02-11 16:10:38 +03:00
|
|
|
lower_size = ecryptfs_lower_header_size(crypt_stat);
|
2006-10-04 13:16:22 +04:00
|
|
|
if (upper_size != 0) {
|
|
|
|
loff_t num_extents;
|
|
|
|
|
|
|
|
num_extents = upper_size >> crypt_stat->extent_shift;
|
|
|
|
if (upper_size & ~crypt_stat->extent_mask)
|
|
|
|
num_extents++;
|
|
|
|
lower_size += (num_extents * crypt_stat->extent_size);
|
|
|
|
}
|
|
|
|
return lower_size;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2009-10-15 01:18:27 +04:00
|
|
|
* truncate_upper
|
2006-10-04 13:16:22 +04:00
|
|
|
* @dentry: The ecryptfs layer dentry
|
2009-10-15 01:18:27 +04:00
|
|
|
* @ia: Address of the ecryptfs inode's attributes
|
|
|
|
* @lower_ia: Address of the lower inode's attributes
|
2006-10-04 13:16:22 +04:00
|
|
|
*
|
|
|
|
* Function to handle truncations modifying the size of the file. Note
|
|
|
|
* that the file sizes are interpolated. When expanding, we are simply
|
2009-10-15 01:18:27 +04:00
|
|
|
* writing strings of 0's out. When truncating, we truncate the upper
|
|
|
|
* inode and update the lower_ia according to the page index
|
|
|
|
* interpolations. If ATTR_SIZE is set in lower_ia->ia_valid upon return,
|
|
|
|
* the caller must use lower_ia in a call to notify_change() to perform
|
|
|
|
* the truncation of the lower inode.
|
2006-10-04 13:16:22 +04:00
|
|
|
*
|
|
|
|
* Returns zero on success; non-zero otherwise
|
|
|
|
*/
|
2009-10-15 01:18:27 +04:00
|
|
|
static int truncate_upper(struct dentry *dentry, struct iattr *ia,
|
|
|
|
struct iattr *lower_ia)
|
2006-10-04 13:16:22 +04:00
|
|
|
{
|
|
|
|
int rc = 0;
|
2015-03-18 01:25:59 +03:00
|
|
|
struct inode *inode = d_inode(dentry);
|
2006-10-04 13:16:22 +04:00
|
|
|
struct ecryptfs_crypt_stat *crypt_stat;
|
|
|
|
loff_t i_size = i_size_read(inode);
|
|
|
|
loff_t lower_size_before_truncate;
|
|
|
|
loff_t lower_size_after_truncate;
|
|
|
|
|
2009-10-15 01:18:27 +04:00
|
|
|
if (unlikely((ia->ia_size == i_size))) {
|
|
|
|
lower_ia->ia_valid &= ~ATTR_SIZE;
|
eCryptfs: Add reference counting to lower files
For any given lower inode, eCryptfs keeps only one lower file open and
multiplexes all eCryptfs file operations through that lower file. The
lower file was considered "persistent" and stayed open from the first
lookup through the lifetime of the inode.
This patch keeps the notion of a single, per-inode lower file, but adds
reference counting around the lower file so that it is closed when not
currently in use. If the reference count is at 0 when an operation (such
as open, create, etc.) needs to use the lower file, a new lower file is
opened. Since the file is no longer persistent, all references to the
term persistent file are changed to lower file.
Locking is added around the sections of code that opens the lower file
and assign the pointer in the inode info, as well as the code the fputs
the lower file when all eCryptfs users are done with it.
This patch is needed to fix issues, when mounted on top of the NFSv3
client, where the lower file is left silly renamed until the eCryptfs
inode is destroyed.
Signed-off-by: Tyler Hicks <tyhicks@linux.vnet.ibm.com>
2011-04-15 00:35:11 +04:00
|
|
|
return 0;
|
2009-10-15 01:18:27 +04:00
|
|
|
}
|
2011-05-24 12:49:02 +04:00
|
|
|
rc = ecryptfs_get_lower_file(dentry, inode);
|
eCryptfs: Add reference counting to lower files
For any given lower inode, eCryptfs keeps only one lower file open and
multiplexes all eCryptfs file operations through that lower file. The
lower file was considered "persistent" and stayed open from the first
lookup through the lifetime of the inode.
This patch keeps the notion of a single, per-inode lower file, but adds
reference counting around the lower file so that it is closed when not
currently in use. If the reference count is at 0 when an operation (such
as open, create, etc.) needs to use the lower file, a new lower file is
opened. Since the file is no longer persistent, all references to the
term persistent file are changed to lower file.
Locking is added around the sections of code that opens the lower file
and assign the pointer in the inode info, as well as the code the fputs
the lower file when all eCryptfs users are done with it.
This patch is needed to fix issues, when mounted on top of the NFSv3
client, where the lower file is left silly renamed until the eCryptfs
inode is destroyed.
Signed-off-by: Tyler Hicks <tyhicks@linux.vnet.ibm.com>
2011-04-15 00:35:11 +04:00
|
|
|
if (rc)
|
|
|
|
return rc;
|
2015-03-18 01:25:59 +03:00
|
|
|
crypt_stat = &ecryptfs_inode_to_private(d_inode(dentry))->crypt_stat;
|
2006-10-04 13:16:22 +04:00
|
|
|
/* Switch on growing or shrinking file */
|
2009-10-15 01:18:27 +04:00
|
|
|
if (ia->ia_size > i_size) {
|
2007-10-16 12:28:10 +04:00
|
|
|
char zero[] = { 0x00 };
|
|
|
|
|
2009-10-15 01:18:27 +04:00
|
|
|
lower_ia->ia_valid &= ~ATTR_SIZE;
|
2007-10-16 12:28:10 +04:00
|
|
|
/* Write a single 0 at the last position of the file;
|
|
|
|
* this triggers code that will fill in 0's throughout
|
|
|
|
* the intermediate portion of the previous end of the
|
|
|
|
* file and the new and of the file */
|
2010-05-21 19:09:58 +04:00
|
|
|
rc = ecryptfs_write(inode, zero,
|
2009-10-15 01:18:27 +04:00
|
|
|
(ia->ia_size - 1), 1);
|
|
|
|
} else { /* ia->ia_size < i_size_read(inode) */
|
|
|
|
/* We're chopping off all the pages down to the page
|
|
|
|
* in which ia->ia_size is located. Fill in the end of
|
2016-04-01 15:29:48 +03:00
|
|
|
* that page from (ia->ia_size & ~PAGE_MASK) to
|
|
|
|
* PAGE_SIZE with zeros. */
|
mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros
PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} macros were introduced *long* time
ago with promise that one day it will be possible to implement page
cache with bigger chunks than PAGE_SIZE.
This promise never materialized. And unlikely will.
We have many places where PAGE_CACHE_SIZE assumed to be equal to
PAGE_SIZE. And it's constant source of confusion on whether
PAGE_CACHE_* or PAGE_* constant should be used in a particular case,
especially on the border between fs and mm.
Global switching to PAGE_CACHE_SIZE != PAGE_SIZE would cause to much
breakage to be doable.
Let's stop pretending that pages in page cache are special. They are
not.
The changes are pretty straight-forward:
- <foo> << (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> <foo>;
- <foo> >> (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> <foo>;
- PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} -> PAGE_{SIZE,SHIFT,MASK,ALIGN};
- page_cache_get() -> get_page();
- page_cache_release() -> put_page();
This patch contains automated changes generated with coccinelle using
script below. For some reason, coccinelle doesn't patch header files.
I've called spatch for them manually.
The only adjustment after coccinelle is revert of changes to
PAGE_CAHCE_ALIGN definition: we are going to drop it later.
There are few places in the code where coccinelle didn't reach. I'll
fix them manually in a separate patch. Comments and documentation also
will be addressed with the separate patch.
virtual patch
@@
expression E;
@@
- E << (PAGE_CACHE_SHIFT - PAGE_SHIFT)
+ E
@@
expression E;
@@
- E >> (PAGE_CACHE_SHIFT - PAGE_SHIFT)
+ E
@@
@@
- PAGE_CACHE_SHIFT
+ PAGE_SHIFT
@@
@@
- PAGE_CACHE_SIZE
+ PAGE_SIZE
@@
@@
- PAGE_CACHE_MASK
+ PAGE_MASK
@@
expression E;
@@
- PAGE_CACHE_ALIGN(E)
+ PAGE_ALIGN(E)
@@
expression E;
@@
- page_cache_get(E)
+ get_page(E)
@@
expression E;
@@
- page_cache_release(E)
+ put_page(E)
Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2016-04-01 15:29:47 +03:00
|
|
|
size_t num_zeros = (PAGE_SIZE
|
|
|
|
- (ia->ia_size & ~PAGE_MASK));
|
2007-10-16 12:28:10 +04:00
|
|
|
|
2009-04-14 00:29:27 +04:00
|
|
|
if (!(crypt_stat->flags & ECRYPTFS_ENCRYPTED)) {
|
2010-06-04 13:30:04 +04:00
|
|
|
truncate_setsize(inode, ia->ia_size);
|
2009-10-15 01:18:27 +04:00
|
|
|
lower_ia->ia_size = ia->ia_size;
|
|
|
|
lower_ia->ia_valid |= ATTR_SIZE;
|
2010-05-21 19:09:58 +04:00
|
|
|
goto out;
|
2009-04-14 00:29:27 +04:00
|
|
|
}
|
2007-10-16 12:28:10 +04:00
|
|
|
if (num_zeros) {
|
|
|
|
char *zeros_virt;
|
|
|
|
|
|
|
|
zeros_virt = kzalloc(num_zeros, GFP_KERNEL);
|
|
|
|
if (!zeros_virt) {
|
|
|
|
rc = -ENOMEM;
|
2010-05-21 19:09:58 +04:00
|
|
|
goto out;
|
2007-10-16 12:28:10 +04:00
|
|
|
}
|
2010-05-21 19:09:58 +04:00
|
|
|
rc = ecryptfs_write(inode, zeros_virt,
|
2009-10-15 01:18:27 +04:00
|
|
|
ia->ia_size, num_zeros);
|
2007-10-16 12:28:10 +04:00
|
|
|
kfree(zeros_virt);
|
2007-10-16 12:28:06 +04:00
|
|
|
if (rc) {
|
2007-06-28 01:09:44 +04:00
|
|
|
printk(KERN_ERR "Error attempting to zero out "
|
|
|
|
"the remainder of the end page on "
|
|
|
|
"reducing truncate; rc = [%d]\n", rc);
|
2010-05-21 19:09:58 +04:00
|
|
|
goto out;
|
2007-06-28 01:09:44 +04:00
|
|
|
}
|
|
|
|
}
|
2010-06-04 13:30:04 +04:00
|
|
|
truncate_setsize(inode, ia->ia_size);
|
2007-10-16 12:28:08 +04:00
|
|
|
rc = ecryptfs_write_inode_size_to_metadata(inode);
|
2007-02-12 11:53:46 +03:00
|
|
|
if (rc) {
|
|
|
|
printk(KERN_ERR "Problem with "
|
|
|
|
"ecryptfs_write_inode_size_to_metadata; "
|
|
|
|
"rc = [%d]\n", rc);
|
2010-05-21 19:09:58 +04:00
|
|
|
goto out;
|
2007-02-12 11:53:46 +03:00
|
|
|
}
|
2006-10-04 13:16:22 +04:00
|
|
|
/* We are reducing the size of the ecryptfs file, and need to
|
|
|
|
* know if we need to reduce the size of the lower file. */
|
|
|
|
lower_size_before_truncate =
|
|
|
|
upper_size_to_lower_size(crypt_stat, i_size);
|
|
|
|
lower_size_after_truncate =
|
2009-10-15 01:18:27 +04:00
|
|
|
upper_size_to_lower_size(crypt_stat, ia->ia_size);
|
|
|
|
if (lower_size_after_truncate < lower_size_before_truncate) {
|
|
|
|
lower_ia->ia_size = lower_size_after_truncate;
|
|
|
|
lower_ia->ia_valid |= ATTR_SIZE;
|
|
|
|
} else
|
|
|
|
lower_ia->ia_valid &= ~ATTR_SIZE;
|
2006-10-04 13:16:22 +04:00
|
|
|
}
|
|
|
|
out:
|
eCryptfs: Add reference counting to lower files
For any given lower inode, eCryptfs keeps only one lower file open and
multiplexes all eCryptfs file operations through that lower file. The
lower file was considered "persistent" and stayed open from the first
lookup through the lifetime of the inode.
This patch keeps the notion of a single, per-inode lower file, but adds
reference counting around the lower file so that it is closed when not
currently in use. If the reference count is at 0 when an operation (such
as open, create, etc.) needs to use the lower file, a new lower file is
opened. Since the file is no longer persistent, all references to the
term persistent file are changed to lower file.
Locking is added around the sections of code that opens the lower file
and assign the pointer in the inode info, as well as the code the fputs
the lower file when all eCryptfs users are done with it.
This patch is needed to fix issues, when mounted on top of the NFSv3
client, where the lower file is left silly renamed until the eCryptfs
inode is destroyed.
Signed-off-by: Tyler Hicks <tyhicks@linux.vnet.ibm.com>
2011-04-15 00:35:11 +04:00
|
|
|
ecryptfs_put_lower_file(inode);
|
2006-10-04 13:16:22 +04:00
|
|
|
return rc;
|
|
|
|
}
|
|
|
|
|
eCryptfs: Check inode changes in setattr
Most filesystems call inode_change_ok() very early in ->setattr(), but
eCryptfs didn't call it at all. It allowed the lower filesystem to make
the call in its ->setattr() function. Then, eCryptfs would copy the
appropriate inode attributes from the lower inode to the eCryptfs inode.
This patch changes that and actually calls inode_change_ok() on the
eCryptfs inode, fairly early in ecryptfs_setattr(). Ideally, the call
would happen earlier in ecryptfs_setattr(), but there are some possible
inode initialization steps that must happen first.
Since the call was already being made on the lower inode, the change in
functionality should be minimal, except for the case of a file extending
truncate call. In that case, inode_newsize_ok() was never being
called on the eCryptfs inode. Rather than inode_newsize_ok() catching
maximum file size errors early on, eCryptfs would encrypt zeroed pages
and write them to the lower filesystem until the lower filesystem's
write path caught the error in generic_write_checks(). This patch
introduces a new function, called ecryptfs_inode_newsize_ok(), which
checks if the new lower file size is within the appropriate limits when
the truncate operation will be growing the lower file.
In summary this change prevents eCryptfs truncate operations (and the
resulting page encryptions), which would exceed the lower filesystem
limits or FSIZE rlimits, from ever starting.
Signed-off-by: Tyler Hicks <tyhicks@canonical.com>
Reviewed-by: Li Wang <liwang@nudt.edu.cn>
Cc: <stable@vger.kernel.org>
2012-01-20 06:33:44 +04:00
|
|
|
static int ecryptfs_inode_newsize_ok(struct inode *inode, loff_t offset)
|
|
|
|
{
|
|
|
|
struct ecryptfs_crypt_stat *crypt_stat;
|
|
|
|
loff_t lower_oldsize, lower_newsize;
|
|
|
|
|
|
|
|
crypt_stat = &ecryptfs_inode_to_private(inode)->crypt_stat;
|
|
|
|
lower_oldsize = upper_size_to_lower_size(crypt_stat,
|
|
|
|
i_size_read(inode));
|
|
|
|
lower_newsize = upper_size_to_lower_size(crypt_stat, offset);
|
|
|
|
if (lower_newsize > lower_oldsize) {
|
|
|
|
/*
|
|
|
|
* The eCryptfs inode and the new *lower* size are mixed here
|
|
|
|
* because we may not have the lower i_mutex held and/or it may
|
|
|
|
* not be appropriate to call inode_newsize_ok() with inodes
|
|
|
|
* from other filesystems.
|
|
|
|
*/
|
|
|
|
return inode_newsize_ok(inode, lower_newsize);
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2009-10-15 01:18:27 +04:00
|
|
|
/**
|
|
|
|
* ecryptfs_truncate
|
|
|
|
* @dentry: The ecryptfs layer dentry
|
|
|
|
* @new_length: The length to expand the file to
|
|
|
|
*
|
|
|
|
* Simple function that handles the truncation of an eCryptfs inode and
|
|
|
|
* its corresponding lower inode.
|
|
|
|
*
|
|
|
|
* Returns zero on success; non-zero otherwise
|
|
|
|
*/
|
|
|
|
int ecryptfs_truncate(struct dentry *dentry, loff_t new_length)
|
|
|
|
{
|
|
|
|
struct iattr ia = { .ia_valid = ATTR_SIZE, .ia_size = new_length };
|
|
|
|
struct iattr lower_ia = { .ia_valid = 0 };
|
|
|
|
int rc;
|
|
|
|
|
2015-03-18 01:25:59 +03:00
|
|
|
rc = ecryptfs_inode_newsize_ok(d_inode(dentry), new_length);
|
eCryptfs: Check inode changes in setattr
Most filesystems call inode_change_ok() very early in ->setattr(), but
eCryptfs didn't call it at all. It allowed the lower filesystem to make
the call in its ->setattr() function. Then, eCryptfs would copy the
appropriate inode attributes from the lower inode to the eCryptfs inode.
This patch changes that and actually calls inode_change_ok() on the
eCryptfs inode, fairly early in ecryptfs_setattr(). Ideally, the call
would happen earlier in ecryptfs_setattr(), but there are some possible
inode initialization steps that must happen first.
Since the call was already being made on the lower inode, the change in
functionality should be minimal, except for the case of a file extending
truncate call. In that case, inode_newsize_ok() was never being
called on the eCryptfs inode. Rather than inode_newsize_ok() catching
maximum file size errors early on, eCryptfs would encrypt zeroed pages
and write them to the lower filesystem until the lower filesystem's
write path caught the error in generic_write_checks(). This patch
introduces a new function, called ecryptfs_inode_newsize_ok(), which
checks if the new lower file size is within the appropriate limits when
the truncate operation will be growing the lower file.
In summary this change prevents eCryptfs truncate operations (and the
resulting page encryptions), which would exceed the lower filesystem
limits or FSIZE rlimits, from ever starting.
Signed-off-by: Tyler Hicks <tyhicks@canonical.com>
Reviewed-by: Li Wang <liwang@nudt.edu.cn>
Cc: <stable@vger.kernel.org>
2012-01-20 06:33:44 +04:00
|
|
|
if (rc)
|
|
|
|
return rc;
|
|
|
|
|
2009-10-15 01:18:27 +04:00
|
|
|
rc = truncate_upper(dentry, &ia, &lower_ia);
|
|
|
|
if (!rc && lower_ia.ia_valid & ATTR_SIZE) {
|
|
|
|
struct dentry *lower_dentry = ecryptfs_dentry_to_lower(dentry);
|
|
|
|
|
2016-01-22 23:40:57 +03:00
|
|
|
inode_lock(d_inode(lower_dentry));
|
2021-01-21 16:19:26 +03:00
|
|
|
rc = notify_change(&init_user_ns, lower_dentry,
|
|
|
|
&lower_ia, NULL);
|
2016-01-22 23:40:57 +03:00
|
|
|
inode_unlock(d_inode(lower_dentry));
|
2009-10-15 01:18:27 +04:00
|
|
|
}
|
|
|
|
return rc;
|
|
|
|
}
|
|
|
|
|
2006-10-04 13:16:22 +04:00
|
|
|
static int
|
2021-01-21 16:19:43 +03:00
|
|
|
ecryptfs_permission(struct user_namespace *mnt_userns, struct inode *inode,
|
|
|
|
int mask)
|
2006-10-04 13:16:22 +04:00
|
|
|
{
|
2021-01-21 16:19:24 +03:00
|
|
|
return inode_permission(&init_user_ns,
|
|
|
|
ecryptfs_inode_to_lower(inode), mask);
|
2006-10-04 13:16:22 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* ecryptfs_setattr
|
2021-03-30 19:44:57 +03:00
|
|
|
* @mnt_userns: user namespace of the target mount
|
2006-10-04 13:16:22 +04:00
|
|
|
* @dentry: dentry handle to the inode to modify
|
|
|
|
* @ia: Structure with flags of what to change and values
|
|
|
|
*
|
|
|
|
* Updates the metadata of an inode. If the update is to the size
|
|
|
|
* i.e. truncation, then ecryptfs_truncate will handle the size modification
|
|
|
|
* of both the ecryptfs inode and the lower inode.
|
|
|
|
*
|
|
|
|
* All other metadata changes will be passed right to the lower filesystem,
|
|
|
|
* and we will just update our inode to look like the lower.
|
|
|
|
*/
|
2021-01-21 16:19:43 +03:00
|
|
|
static int ecryptfs_setattr(struct user_namespace *mnt_userns,
|
|
|
|
struct dentry *dentry, struct iattr *ia)
|
2006-10-04 13:16:22 +04:00
|
|
|
{
|
|
|
|
int rc = 0;
|
|
|
|
struct dentry *lower_dentry;
|
2009-10-15 01:18:27 +04:00
|
|
|
struct iattr lower_ia;
|
2006-10-04 13:16:22 +04:00
|
|
|
struct inode *inode;
|
|
|
|
struct inode *lower_inode;
|
|
|
|
struct ecryptfs_crypt_stat *crypt_stat;
|
|
|
|
|
2015-03-18 01:25:59 +03:00
|
|
|
crypt_stat = &ecryptfs_inode_to_private(d_inode(dentry))->crypt_stat;
|
2016-04-16 10:01:09 +03:00
|
|
|
if (!(crypt_stat->flags & ECRYPTFS_STRUCT_INITIALIZED)) {
|
|
|
|
rc = ecryptfs_init_crypt_stat(crypt_stat);
|
|
|
|
if (rc)
|
|
|
|
return rc;
|
|
|
|
}
|
2015-03-18 01:25:59 +03:00
|
|
|
inode = d_inode(dentry);
|
2006-10-04 13:16:22 +04:00
|
|
|
lower_inode = ecryptfs_inode_to_lower(inode);
|
2007-06-28 01:09:44 +04:00
|
|
|
lower_dentry = ecryptfs_dentry_to_lower(dentry);
|
|
|
|
mutex_lock(&crypt_stat->cs_mutex);
|
VFS: (Scripted) Convert S_ISLNK/DIR/REG(dentry->d_inode) to d_is_*(dentry)
Convert the following where appropriate:
(1) S_ISLNK(dentry->d_inode) to d_is_symlink(dentry).
(2) S_ISREG(dentry->d_inode) to d_is_reg(dentry).
(3) S_ISDIR(dentry->d_inode) to d_is_dir(dentry). This is actually more
complicated than it appears as some calls should be converted to
d_can_lookup() instead. The difference is whether the directory in
question is a real dir with a ->lookup op or whether it's a fake dir with
a ->d_automount op.
In some circumstances, we can subsume checks for dentry->d_inode not being
NULL into this, provided we the code isn't in a filesystem that expects
d_inode to be NULL if the dirent really *is* negative (ie. if we're going to
use d_inode() rather than d_backing_inode() to get the inode pointer).
Note that the dentry type field may be set to something other than
DCACHE_MISS_TYPE when d_inode is NULL in the case of unionmount, where the VFS
manages the fall-through from a negative dentry to a lower layer. In such a
case, the dentry type of the negative union dentry is set to the same as the
type of the lower dentry.
However, if you know d_inode is not NULL at the call site, then you can use
the d_is_xxx() functions even in a filesystem.
There is one further complication: a 0,0 chardev dentry may be labelled
DCACHE_WHITEOUT_TYPE rather than DCACHE_SPECIAL_TYPE. Strictly, this was
intended for special directory entry types that don't have attached inodes.
The following perl+coccinelle script was used:
use strict;
my @callers;
open($fd, 'git grep -l \'S_IS[A-Z].*->d_inode\' |') ||
die "Can't grep for S_ISDIR and co. callers";
@callers = <$fd>;
close($fd);
unless (@callers) {
print "No matches\n";
exit(0);
}
my @cocci = (
'@@',
'expression E;',
'@@',
'',
'- S_ISLNK(E->d_inode->i_mode)',
'+ d_is_symlink(E)',
'',
'@@',
'expression E;',
'@@',
'',
'- S_ISDIR(E->d_inode->i_mode)',
'+ d_is_dir(E)',
'',
'@@',
'expression E;',
'@@',
'',
'- S_ISREG(E->d_inode->i_mode)',
'+ d_is_reg(E)' );
my $coccifile = "tmp.sp.cocci";
open($fd, ">$coccifile") || die $coccifile;
print($fd "$_\n") || die $coccifile foreach (@cocci);
close($fd);
foreach my $file (@callers) {
chomp $file;
print "Processing ", $file, "\n";
system("spatch", "--sp-file", $coccifile, $file, "--in-place", "--no-show-diff") == 0 ||
die "spatch failed";
}
[AV: overlayfs parts skipped]
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2015-01-29 15:02:35 +03:00
|
|
|
if (d_is_dir(dentry))
|
2007-06-28 01:09:44 +04:00
|
|
|
crypt_stat->flags &= ~(ECRYPTFS_ENCRYPTED);
|
VFS: (Scripted) Convert S_ISLNK/DIR/REG(dentry->d_inode) to d_is_*(dentry)
Convert the following where appropriate:
(1) S_ISLNK(dentry->d_inode) to d_is_symlink(dentry).
(2) S_ISREG(dentry->d_inode) to d_is_reg(dentry).
(3) S_ISDIR(dentry->d_inode) to d_is_dir(dentry). This is actually more
complicated than it appears as some calls should be converted to
d_can_lookup() instead. The difference is whether the directory in
question is a real dir with a ->lookup op or whether it's a fake dir with
a ->d_automount op.
In some circumstances, we can subsume checks for dentry->d_inode not being
NULL into this, provided we the code isn't in a filesystem that expects
d_inode to be NULL if the dirent really *is* negative (ie. if we're going to
use d_inode() rather than d_backing_inode() to get the inode pointer).
Note that the dentry type field may be set to something other than
DCACHE_MISS_TYPE when d_inode is NULL in the case of unionmount, where the VFS
manages the fall-through from a negative dentry to a lower layer. In such a
case, the dentry type of the negative union dentry is set to the same as the
type of the lower dentry.
However, if you know d_inode is not NULL at the call site, then you can use
the d_is_xxx() functions even in a filesystem.
There is one further complication: a 0,0 chardev dentry may be labelled
DCACHE_WHITEOUT_TYPE rather than DCACHE_SPECIAL_TYPE. Strictly, this was
intended for special directory entry types that don't have attached inodes.
The following perl+coccinelle script was used:
use strict;
my @callers;
open($fd, 'git grep -l \'S_IS[A-Z].*->d_inode\' |') ||
die "Can't grep for S_ISDIR and co. callers";
@callers = <$fd>;
close($fd);
unless (@callers) {
print "No matches\n";
exit(0);
}
my @cocci = (
'@@',
'expression E;',
'@@',
'',
'- S_ISLNK(E->d_inode->i_mode)',
'+ d_is_symlink(E)',
'',
'@@',
'expression E;',
'@@',
'',
'- S_ISDIR(E->d_inode->i_mode)',
'+ d_is_dir(E)',
'',
'@@',
'expression E;',
'@@',
'',
'- S_ISREG(E->d_inode->i_mode)',
'+ d_is_reg(E)' );
my $coccifile = "tmp.sp.cocci";
open($fd, ">$coccifile") || die $coccifile;
print($fd "$_\n") || die $coccifile foreach (@cocci);
close($fd);
foreach my $file (@callers) {
chomp $file;
print "Processing ", $file, "\n";
system("spatch", "--sp-file", $coccifile, $file, "--in-place", "--no-show-diff") == 0 ||
die "spatch failed";
}
[AV: overlayfs parts skipped]
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2015-01-29 15:02:35 +03:00
|
|
|
else if (d_is_reg(dentry)
|
2007-07-19 12:47:54 +04:00
|
|
|
&& (!(crypt_stat->flags & ECRYPTFS_POLICY_APPLIED)
|
|
|
|
|| !(crypt_stat->flags & ECRYPTFS_KEY_VALID))) {
|
2007-06-28 01:09:44 +04:00
|
|
|
struct ecryptfs_mount_crypt_stat *mount_crypt_stat;
|
|
|
|
|
|
|
|
mount_crypt_stat = &ecryptfs_superblock_to_private(
|
|
|
|
dentry->d_sb)->mount_crypt_stat;
|
2011-05-24 12:49:02 +04:00
|
|
|
rc = ecryptfs_get_lower_file(dentry, inode);
|
eCryptfs: Add reference counting to lower files
For any given lower inode, eCryptfs keeps only one lower file open and
multiplexes all eCryptfs file operations through that lower file. The
lower file was considered "persistent" and stayed open from the first
lookup through the lifetime of the inode.
This patch keeps the notion of a single, per-inode lower file, but adds
reference counting around the lower file so that it is closed when not
currently in use. If the reference count is at 0 when an operation (such
as open, create, etc.) needs to use the lower file, a new lower file is
opened. Since the file is no longer persistent, all references to the
term persistent file are changed to lower file.
Locking is added around the sections of code that opens the lower file
and assign the pointer in the inode info, as well as the code the fputs
the lower file when all eCryptfs users are done with it.
This patch is needed to fix issues, when mounted on top of the NFSv3
client, where the lower file is left silly renamed until the eCryptfs
inode is destroyed.
Signed-off-by: Tyler Hicks <tyhicks@linux.vnet.ibm.com>
2011-04-15 00:35:11 +04:00
|
|
|
if (rc) {
|
|
|
|
mutex_unlock(&crypt_stat->cs_mutex);
|
|
|
|
goto out;
|
|
|
|
}
|
2007-10-16 12:28:10 +04:00
|
|
|
rc = ecryptfs_read_metadata(dentry);
|
eCryptfs: Add reference counting to lower files
For any given lower inode, eCryptfs keeps only one lower file open and
multiplexes all eCryptfs file operations through that lower file. The
lower file was considered "persistent" and stayed open from the first
lookup through the lifetime of the inode.
This patch keeps the notion of a single, per-inode lower file, but adds
reference counting around the lower file so that it is closed when not
currently in use. If the reference count is at 0 when an operation (such
as open, create, etc.) needs to use the lower file, a new lower file is
opened. Since the file is no longer persistent, all references to the
term persistent file are changed to lower file.
Locking is added around the sections of code that opens the lower file
and assign the pointer in the inode info, as well as the code the fputs
the lower file when all eCryptfs users are done with it.
This patch is needed to fix issues, when mounted on top of the NFSv3
client, where the lower file is left silly renamed until the eCryptfs
inode is destroyed.
Signed-off-by: Tyler Hicks <tyhicks@linux.vnet.ibm.com>
2011-04-15 00:35:11 +04:00
|
|
|
ecryptfs_put_lower_file(inode);
|
2007-10-16 12:28:06 +04:00
|
|
|
if (rc) {
|
2007-06-28 01:09:44 +04:00
|
|
|
if (!(mount_crypt_stat->flags
|
|
|
|
& ECRYPTFS_PLAINTEXT_PASSTHROUGH_ENABLED)) {
|
|
|
|
rc = -EIO;
|
2008-02-06 12:38:35 +03:00
|
|
|
printk(KERN_WARNING "Either the lower file "
|
2007-06-28 01:09:44 +04:00
|
|
|
"is not in a valid eCryptfs format, "
|
2008-02-06 12:38:35 +03:00
|
|
|
"or the key could not be retrieved. "
|
|
|
|
"Plaintext passthrough mode is not "
|
2007-06-28 01:09:44 +04:00
|
|
|
"enabled; returning -EIO\n");
|
|
|
|
mutex_unlock(&crypt_stat->cs_mutex);
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
rc = 0;
|
2011-03-15 22:54:00 +03:00
|
|
|
crypt_stat->flags &= ~(ECRYPTFS_I_SIZE_INITIALIZED
|
|
|
|
| ECRYPTFS_ENCRYPTED);
|
2007-06-28 01:09:44 +04:00
|
|
|
}
|
|
|
|
}
|
|
|
|
mutex_unlock(&crypt_stat->cs_mutex);
|
eCryptfs: Check inode changes in setattr
Most filesystems call inode_change_ok() very early in ->setattr(), but
eCryptfs didn't call it at all. It allowed the lower filesystem to make
the call in its ->setattr() function. Then, eCryptfs would copy the
appropriate inode attributes from the lower inode to the eCryptfs inode.
This patch changes that and actually calls inode_change_ok() on the
eCryptfs inode, fairly early in ecryptfs_setattr(). Ideally, the call
would happen earlier in ecryptfs_setattr(), but there are some possible
inode initialization steps that must happen first.
Since the call was already being made on the lower inode, the change in
functionality should be minimal, except for the case of a file extending
truncate call. In that case, inode_newsize_ok() was never being
called on the eCryptfs inode. Rather than inode_newsize_ok() catching
maximum file size errors early on, eCryptfs would encrypt zeroed pages
and write them to the lower filesystem until the lower filesystem's
write path caught the error in generic_write_checks(). This patch
introduces a new function, called ecryptfs_inode_newsize_ok(), which
checks if the new lower file size is within the appropriate limits when
the truncate operation will be growing the lower file.
In summary this change prevents eCryptfs truncate operations (and the
resulting page encryptions), which would exceed the lower filesystem
limits or FSIZE rlimits, from ever starting.
Signed-off-by: Tyler Hicks <tyhicks@canonical.com>
Reviewed-by: Li Wang <liwang@nudt.edu.cn>
Cc: <stable@vger.kernel.org>
2012-01-20 06:33:44 +04:00
|
|
|
|
2021-01-21 16:19:26 +03:00
|
|
|
rc = setattr_prepare(&init_user_ns, dentry, ia);
|
eCryptfs: Check inode changes in setattr
Most filesystems call inode_change_ok() very early in ->setattr(), but
eCryptfs didn't call it at all. It allowed the lower filesystem to make
the call in its ->setattr() function. Then, eCryptfs would copy the
appropriate inode attributes from the lower inode to the eCryptfs inode.
This patch changes that and actually calls inode_change_ok() on the
eCryptfs inode, fairly early in ecryptfs_setattr(). Ideally, the call
would happen earlier in ecryptfs_setattr(), but there are some possible
inode initialization steps that must happen first.
Since the call was already being made on the lower inode, the change in
functionality should be minimal, except for the case of a file extending
truncate call. In that case, inode_newsize_ok() was never being
called on the eCryptfs inode. Rather than inode_newsize_ok() catching
maximum file size errors early on, eCryptfs would encrypt zeroed pages
and write them to the lower filesystem until the lower filesystem's
write path caught the error in generic_write_checks(). This patch
introduces a new function, called ecryptfs_inode_newsize_ok(), which
checks if the new lower file size is within the appropriate limits when
the truncate operation will be growing the lower file.
In summary this change prevents eCryptfs truncate operations (and the
resulting page encryptions), which would exceed the lower filesystem
limits or FSIZE rlimits, from ever starting.
Signed-off-by: Tyler Hicks <tyhicks@canonical.com>
Reviewed-by: Li Wang <liwang@nudt.edu.cn>
Cc: <stable@vger.kernel.org>
2012-01-20 06:33:44 +04:00
|
|
|
if (rc)
|
|
|
|
goto out;
|
|
|
|
if (ia->ia_valid & ATTR_SIZE) {
|
|
|
|
rc = ecryptfs_inode_newsize_ok(inode, ia->ia_size);
|
|
|
|
if (rc)
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
2009-10-15 01:18:27 +04:00
|
|
|
memcpy(&lower_ia, ia, sizeof(lower_ia));
|
|
|
|
if (ia->ia_valid & ATTR_FILE)
|
|
|
|
lower_ia.ia_file = ecryptfs_file_to_lower(ia->ia_file);
|
2006-10-04 13:16:22 +04:00
|
|
|
if (ia->ia_valid & ATTR_SIZE) {
|
2009-10-15 01:18:27 +04:00
|
|
|
rc = truncate_upper(dentry, ia, &lower_ia);
|
2006-10-04 13:16:22 +04:00
|
|
|
if (rc < 0)
|
|
|
|
goto out;
|
|
|
|
}
|
2007-10-18 14:05:17 +04:00
|
|
|
|
|
|
|
/*
|
|
|
|
* mode change is for clearing setuid/setgid bits. Allow lower fs
|
|
|
|
* to interpret this in its own way.
|
|
|
|
*/
|
2009-10-15 01:18:27 +04:00
|
|
|
if (lower_ia.ia_valid & (ATTR_KILL_SUID | ATTR_KILL_SGID))
|
|
|
|
lower_ia.ia_valid &= ~ATTR_MODE;
|
2007-10-18 14:05:17 +04:00
|
|
|
|
2016-01-22 23:40:57 +03:00
|
|
|
inode_lock(d_inode(lower_dentry));
|
2021-01-21 16:19:26 +03:00
|
|
|
rc = notify_change(&init_user_ns, lower_dentry, &lower_ia, NULL);
|
2016-01-22 23:40:57 +03:00
|
|
|
inode_unlock(d_inode(lower_dentry));
|
2006-10-04 13:16:22 +04:00
|
|
|
out:
|
2009-12-03 03:51:54 +03:00
|
|
|
fsstack_copy_attr_all(inode, lower_inode);
|
2006-10-04 13:16:22 +04:00
|
|
|
return rc;
|
|
|
|
}
|
|
|
|
|
2021-01-21 16:19:43 +03:00
|
|
|
static int ecryptfs_getattr_link(struct user_namespace *mnt_userns,
|
|
|
|
const struct path *path, struct kstat *stat,
|
statx: Add a system call to make enhanced file info available
Add a system call to make extended file information available, including
file creation and some attribute flags where available through the
underlying filesystem.
The getattr inode operation is altered to take two additional arguments: a
u32 request_mask and an unsigned int flags that indicate the
synchronisation mode. This change is propagated to the vfs_getattr*()
function.
Functions like vfs_stat() are now inline wrappers around new functions
vfs_statx() and vfs_statx_fd() to reduce stack usage.
========
OVERVIEW
========
The idea was initially proposed as a set of xattrs that could be retrieved
with getxattr(), but the general preference proved to be for a new syscall
with an extended stat structure.
A number of requests were gathered for features to be included. The
following have been included:
(1) Make the fields a consistent size on all arches and make them large.
(2) Spare space, request flags and information flags are provided for
future expansion.
(3) Better support for the y2038 problem [Arnd Bergmann] (tv_sec is an
__s64).
(4) Creation time: The SMB protocol carries the creation time, which could
be exported by Samba, which will in turn help CIFS make use of
FS-Cache as that can be used for coherency data (stx_btime).
This is also specified in NFSv4 as a recommended attribute and could
be exported by NFSD [Steve French].
(5) Lightweight stat: Ask for just those details of interest, and allow a
netfs (such as NFS) to approximate anything not of interest, possibly
without going to the server [Trond Myklebust, Ulrich Drepper, Andreas
Dilger] (AT_STATX_DONT_SYNC).
(6) Heavyweight stat: Force a netfs to go to the server, even if it thinks
its cached attributes are up to date [Trond Myklebust]
(AT_STATX_FORCE_SYNC).
And the following have been left out for future extension:
(7) Data version number: Could be used by userspace NFS servers [Aneesh
Kumar].
Can also be used to modify fill_post_wcc() in NFSD which retrieves
i_version directly, but has just called vfs_getattr(). It could get
it from the kstat struct if it used vfs_xgetattr() instead.
(There's disagreement on the exact semantics of a single field, since
not all filesystems do this the same way).
(8) BSD stat compatibility: Including more fields from the BSD stat such
as creation time (st_btime) and inode generation number (st_gen)
[Jeremy Allison, Bernd Schubert].
(9) Inode generation number: Useful for FUSE and userspace NFS servers
[Bernd Schubert].
(This was asked for but later deemed unnecessary with the
open-by-handle capability available and caused disagreement as to
whether it's a security hole or not).
(10) Extra coherency data may be useful in making backups [Andreas Dilger].
(No particular data were offered, but things like last backup
timestamp, the data version number and the DOS archive bit would come
into this category).
(11) Allow the filesystem to indicate what it can/cannot provide: A
filesystem can now say it doesn't support a standard stat feature if
that isn't available, so if, for instance, inode numbers or UIDs don't
exist or are fabricated locally...
(This requires a separate system call - I have an fsinfo() call idea
for this).
(12) Store a 16-byte volume ID in the superblock that can be returned in
struct xstat [Steve French].
(Deferred to fsinfo).
(13) Include granularity fields in the time data to indicate the
granularity of each of the times (NFSv4 time_delta) [Steve French].
(Deferred to fsinfo).
(14) FS_IOC_GETFLAGS value. These could be translated to BSD's st_flags.
Note that the Linux IOC flags are a mess and filesystems such as Ext4
define flags that aren't in linux/fs.h, so translation in the kernel
may be a necessity (or, possibly, we provide the filesystem type too).
(Some attributes are made available in stx_attributes, but the general
feeling was that the IOC flags were to ext[234]-specific and shouldn't
be exposed through statx this way).
(15) Mask of features available on file (eg: ACLs, seclabel) [Brad Boyer,
Michael Kerrisk].
(Deferred, probably to fsinfo. Finding out if there's an ACL or
seclabal might require extra filesystem operations).
(16) Femtosecond-resolution timestamps [Dave Chinner].
(A __reserved field has been left in the statx_timestamp struct for
this - if there proves to be a need).
(17) A set multiple attributes syscall to go with this.
===============
NEW SYSTEM CALL
===============
The new system call is:
int ret = statx(int dfd,
const char *filename,
unsigned int flags,
unsigned int mask,
struct statx *buffer);
The dfd, filename and flags parameters indicate the file to query, in a
similar way to fstatat(). There is no equivalent of lstat() as that can be
emulated with statx() by passing AT_SYMLINK_NOFOLLOW in flags. There is
also no equivalent of fstat() as that can be emulated by passing a NULL
filename to statx() with the fd of interest in dfd.
Whether or not statx() synchronises the attributes with the backing store
can be controlled by OR'ing a value into the flags argument (this typically
only affects network filesystems):
(1) AT_STATX_SYNC_AS_STAT tells statx() to behave as stat() does in this
respect.
(2) AT_STATX_FORCE_SYNC will require a network filesystem to synchronise
its attributes with the server - which might require data writeback to
occur to get the timestamps correct.
(3) AT_STATX_DONT_SYNC will suppress synchronisation with the server in a
network filesystem. The resulting values should be considered
approximate.
mask is a bitmask indicating the fields in struct statx that are of
interest to the caller. The user should set this to STATX_BASIC_STATS to
get the basic set returned by stat(). It should be noted that asking for
more information may entail extra I/O operations.
buffer points to the destination for the data. This must be 256 bytes in
size.
======================
MAIN ATTRIBUTES RECORD
======================
The following structures are defined in which to return the main attribute
set:
struct statx_timestamp {
__s64 tv_sec;
__s32 tv_nsec;
__s32 __reserved;
};
struct statx {
__u32 stx_mask;
__u32 stx_blksize;
__u64 stx_attributes;
__u32 stx_nlink;
__u32 stx_uid;
__u32 stx_gid;
__u16 stx_mode;
__u16 __spare0[1];
__u64 stx_ino;
__u64 stx_size;
__u64 stx_blocks;
__u64 __spare1[1];
struct statx_timestamp stx_atime;
struct statx_timestamp stx_btime;
struct statx_timestamp stx_ctime;
struct statx_timestamp stx_mtime;
__u32 stx_rdev_major;
__u32 stx_rdev_minor;
__u32 stx_dev_major;
__u32 stx_dev_minor;
__u64 __spare2[14];
};
The defined bits in request_mask and stx_mask are:
STATX_TYPE Want/got stx_mode & S_IFMT
STATX_MODE Want/got stx_mode & ~S_IFMT
STATX_NLINK Want/got stx_nlink
STATX_UID Want/got stx_uid
STATX_GID Want/got stx_gid
STATX_ATIME Want/got stx_atime{,_ns}
STATX_MTIME Want/got stx_mtime{,_ns}
STATX_CTIME Want/got stx_ctime{,_ns}
STATX_INO Want/got stx_ino
STATX_SIZE Want/got stx_size
STATX_BLOCKS Want/got stx_blocks
STATX_BASIC_STATS [The stuff in the normal stat struct]
STATX_BTIME Want/got stx_btime{,_ns}
STATX_ALL [All currently available stuff]
stx_btime is the file creation time, stx_mask is a bitmask indicating the
data provided and __spares*[] are where as-yet undefined fields can be
placed.
Time fields are structures with separate seconds and nanoseconds fields
plus a reserved field in case we want to add even finer resolution. Note
that times will be negative if before 1970; in such a case, the nanosecond
fields will also be negative if not zero.
The bits defined in the stx_attributes field convey information about a
file, how it is accessed, where it is and what it does. The following
attributes map to FS_*_FL flags and are the same numerical value:
STATX_ATTR_COMPRESSED File is compressed by the fs
STATX_ATTR_IMMUTABLE File is marked immutable
STATX_ATTR_APPEND File is append-only
STATX_ATTR_NODUMP File is not to be dumped
STATX_ATTR_ENCRYPTED File requires key to decrypt in fs
Within the kernel, the supported flags are listed by:
KSTAT_ATTR_FS_IOC_FLAGS
[Are any other IOC flags of sufficient general interest to be exposed
through this interface?]
New flags include:
STATX_ATTR_AUTOMOUNT Object is an automount trigger
These are for the use of GUI tools that might want to mark files specially,
depending on what they are.
Fields in struct statx come in a number of classes:
(0) stx_dev_*, stx_blksize.
These are local system information and are always available.
(1) stx_mode, stx_nlinks, stx_uid, stx_gid, stx_[amc]time, stx_ino,
stx_size, stx_blocks.
These will be returned whether the caller asks for them or not. The
corresponding bits in stx_mask will be set to indicate whether they
actually have valid values.
If the caller didn't ask for them, then they may be approximated. For
example, NFS won't waste any time updating them from the server,
unless as a byproduct of updating something requested.
If the values don't actually exist for the underlying object (such as
UID or GID on a DOS file), then the bit won't be set in the stx_mask,
even if the caller asked for the value. In such a case, the returned
value will be a fabrication.
Note that there are instances where the type might not be valid, for
instance Windows reparse points.
(2) stx_rdev_*.
This will be set only if stx_mode indicates we're looking at a
blockdev or a chardev, otherwise will be 0.
(3) stx_btime.
Similar to (1), except this will be set to 0 if it doesn't exist.
=======
TESTING
=======
The following test program can be used to test the statx system call:
samples/statx/test-statx.c
Just compile and run, passing it paths to the files you want to examine.
The file is built automatically if CONFIG_SAMPLES is enabled.
Here's some example output. Firstly, an NFS directory that crosses to
another FSID. Note that the AUTOMOUNT attribute is set because transiting
this directory will cause d_automount to be invoked by the VFS.
[root@andromeda ~]# /tmp/test-statx -A /warthog/data
statx(/warthog/data) = 0
results=7ff
Size: 4096 Blocks: 8 IO Block: 1048576 directory
Device: 00:26 Inode: 1703937 Links: 125
Access: (3777/drwxrwxrwx) Uid: 0 Gid: 4041
Access: 2016-11-24 09:02:12.219699527+0000
Modify: 2016-11-17 10:44:36.225653653+0000
Change: 2016-11-17 10:44:36.225653653+0000
Attributes: 0000000000001000 (-------- -------- -------- -------- -------- -------- ---m---- --------)
Secondly, the result of automounting on that directory.
[root@andromeda ~]# /tmp/test-statx /warthog/data
statx(/warthog/data) = 0
results=7ff
Size: 4096 Blocks: 8 IO Block: 1048576 directory
Device: 00:27 Inode: 2 Links: 125
Access: (3777/drwxrwxrwx) Uid: 0 Gid: 4041
Access: 2016-11-24 09:02:12.219699527+0000
Modify: 2016-11-17 10:44:36.225653653+0000
Change: 2016-11-17 10:44:36.225653653+0000
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2017-01-31 19:46:22 +03:00
|
|
|
u32 request_mask, unsigned int flags)
|
2010-03-22 08:41:35 +03:00
|
|
|
{
|
statx: Add a system call to make enhanced file info available
Add a system call to make extended file information available, including
file creation and some attribute flags where available through the
underlying filesystem.
The getattr inode operation is altered to take two additional arguments: a
u32 request_mask and an unsigned int flags that indicate the
synchronisation mode. This change is propagated to the vfs_getattr*()
function.
Functions like vfs_stat() are now inline wrappers around new functions
vfs_statx() and vfs_statx_fd() to reduce stack usage.
========
OVERVIEW
========
The idea was initially proposed as a set of xattrs that could be retrieved
with getxattr(), but the general preference proved to be for a new syscall
with an extended stat structure.
A number of requests were gathered for features to be included. The
following have been included:
(1) Make the fields a consistent size on all arches and make them large.
(2) Spare space, request flags and information flags are provided for
future expansion.
(3) Better support for the y2038 problem [Arnd Bergmann] (tv_sec is an
__s64).
(4) Creation time: The SMB protocol carries the creation time, which could
be exported by Samba, which will in turn help CIFS make use of
FS-Cache as that can be used for coherency data (stx_btime).
This is also specified in NFSv4 as a recommended attribute and could
be exported by NFSD [Steve French].
(5) Lightweight stat: Ask for just those details of interest, and allow a
netfs (such as NFS) to approximate anything not of interest, possibly
without going to the server [Trond Myklebust, Ulrich Drepper, Andreas
Dilger] (AT_STATX_DONT_SYNC).
(6) Heavyweight stat: Force a netfs to go to the server, even if it thinks
its cached attributes are up to date [Trond Myklebust]
(AT_STATX_FORCE_SYNC).
And the following have been left out for future extension:
(7) Data version number: Could be used by userspace NFS servers [Aneesh
Kumar].
Can also be used to modify fill_post_wcc() in NFSD which retrieves
i_version directly, but has just called vfs_getattr(). It could get
it from the kstat struct if it used vfs_xgetattr() instead.
(There's disagreement on the exact semantics of a single field, since
not all filesystems do this the same way).
(8) BSD stat compatibility: Including more fields from the BSD stat such
as creation time (st_btime) and inode generation number (st_gen)
[Jeremy Allison, Bernd Schubert].
(9) Inode generation number: Useful for FUSE and userspace NFS servers
[Bernd Schubert].
(This was asked for but later deemed unnecessary with the
open-by-handle capability available and caused disagreement as to
whether it's a security hole or not).
(10) Extra coherency data may be useful in making backups [Andreas Dilger].
(No particular data were offered, but things like last backup
timestamp, the data version number and the DOS archive bit would come
into this category).
(11) Allow the filesystem to indicate what it can/cannot provide: A
filesystem can now say it doesn't support a standard stat feature if
that isn't available, so if, for instance, inode numbers or UIDs don't
exist or are fabricated locally...
(This requires a separate system call - I have an fsinfo() call idea
for this).
(12) Store a 16-byte volume ID in the superblock that can be returned in
struct xstat [Steve French].
(Deferred to fsinfo).
(13) Include granularity fields in the time data to indicate the
granularity of each of the times (NFSv4 time_delta) [Steve French].
(Deferred to fsinfo).
(14) FS_IOC_GETFLAGS value. These could be translated to BSD's st_flags.
Note that the Linux IOC flags are a mess and filesystems such as Ext4
define flags that aren't in linux/fs.h, so translation in the kernel
may be a necessity (or, possibly, we provide the filesystem type too).
(Some attributes are made available in stx_attributes, but the general
feeling was that the IOC flags were to ext[234]-specific and shouldn't
be exposed through statx this way).
(15) Mask of features available on file (eg: ACLs, seclabel) [Brad Boyer,
Michael Kerrisk].
(Deferred, probably to fsinfo. Finding out if there's an ACL or
seclabal might require extra filesystem operations).
(16) Femtosecond-resolution timestamps [Dave Chinner].
(A __reserved field has been left in the statx_timestamp struct for
this - if there proves to be a need).
(17) A set multiple attributes syscall to go with this.
===============
NEW SYSTEM CALL
===============
The new system call is:
int ret = statx(int dfd,
const char *filename,
unsigned int flags,
unsigned int mask,
struct statx *buffer);
The dfd, filename and flags parameters indicate the file to query, in a
similar way to fstatat(). There is no equivalent of lstat() as that can be
emulated with statx() by passing AT_SYMLINK_NOFOLLOW in flags. There is
also no equivalent of fstat() as that can be emulated by passing a NULL
filename to statx() with the fd of interest in dfd.
Whether or not statx() synchronises the attributes with the backing store
can be controlled by OR'ing a value into the flags argument (this typically
only affects network filesystems):
(1) AT_STATX_SYNC_AS_STAT tells statx() to behave as stat() does in this
respect.
(2) AT_STATX_FORCE_SYNC will require a network filesystem to synchronise
its attributes with the server - which might require data writeback to
occur to get the timestamps correct.
(3) AT_STATX_DONT_SYNC will suppress synchronisation with the server in a
network filesystem. The resulting values should be considered
approximate.
mask is a bitmask indicating the fields in struct statx that are of
interest to the caller. The user should set this to STATX_BASIC_STATS to
get the basic set returned by stat(). It should be noted that asking for
more information may entail extra I/O operations.
buffer points to the destination for the data. This must be 256 bytes in
size.
======================
MAIN ATTRIBUTES RECORD
======================
The following structures are defined in which to return the main attribute
set:
struct statx_timestamp {
__s64 tv_sec;
__s32 tv_nsec;
__s32 __reserved;
};
struct statx {
__u32 stx_mask;
__u32 stx_blksize;
__u64 stx_attributes;
__u32 stx_nlink;
__u32 stx_uid;
__u32 stx_gid;
__u16 stx_mode;
__u16 __spare0[1];
__u64 stx_ino;
__u64 stx_size;
__u64 stx_blocks;
__u64 __spare1[1];
struct statx_timestamp stx_atime;
struct statx_timestamp stx_btime;
struct statx_timestamp stx_ctime;
struct statx_timestamp stx_mtime;
__u32 stx_rdev_major;
__u32 stx_rdev_minor;
__u32 stx_dev_major;
__u32 stx_dev_minor;
__u64 __spare2[14];
};
The defined bits in request_mask and stx_mask are:
STATX_TYPE Want/got stx_mode & S_IFMT
STATX_MODE Want/got stx_mode & ~S_IFMT
STATX_NLINK Want/got stx_nlink
STATX_UID Want/got stx_uid
STATX_GID Want/got stx_gid
STATX_ATIME Want/got stx_atime{,_ns}
STATX_MTIME Want/got stx_mtime{,_ns}
STATX_CTIME Want/got stx_ctime{,_ns}
STATX_INO Want/got stx_ino
STATX_SIZE Want/got stx_size
STATX_BLOCKS Want/got stx_blocks
STATX_BASIC_STATS [The stuff in the normal stat struct]
STATX_BTIME Want/got stx_btime{,_ns}
STATX_ALL [All currently available stuff]
stx_btime is the file creation time, stx_mask is a bitmask indicating the
data provided and __spares*[] are where as-yet undefined fields can be
placed.
Time fields are structures with separate seconds and nanoseconds fields
plus a reserved field in case we want to add even finer resolution. Note
that times will be negative if before 1970; in such a case, the nanosecond
fields will also be negative if not zero.
The bits defined in the stx_attributes field convey information about a
file, how it is accessed, where it is and what it does. The following
attributes map to FS_*_FL flags and are the same numerical value:
STATX_ATTR_COMPRESSED File is compressed by the fs
STATX_ATTR_IMMUTABLE File is marked immutable
STATX_ATTR_APPEND File is append-only
STATX_ATTR_NODUMP File is not to be dumped
STATX_ATTR_ENCRYPTED File requires key to decrypt in fs
Within the kernel, the supported flags are listed by:
KSTAT_ATTR_FS_IOC_FLAGS
[Are any other IOC flags of sufficient general interest to be exposed
through this interface?]
New flags include:
STATX_ATTR_AUTOMOUNT Object is an automount trigger
These are for the use of GUI tools that might want to mark files specially,
depending on what they are.
Fields in struct statx come in a number of classes:
(0) stx_dev_*, stx_blksize.
These are local system information and are always available.
(1) stx_mode, stx_nlinks, stx_uid, stx_gid, stx_[amc]time, stx_ino,
stx_size, stx_blocks.
These will be returned whether the caller asks for them or not. The
corresponding bits in stx_mask will be set to indicate whether they
actually have valid values.
If the caller didn't ask for them, then they may be approximated. For
example, NFS won't waste any time updating them from the server,
unless as a byproduct of updating something requested.
If the values don't actually exist for the underlying object (such as
UID or GID on a DOS file), then the bit won't be set in the stx_mask,
even if the caller asked for the value. In such a case, the returned
value will be a fabrication.
Note that there are instances where the type might not be valid, for
instance Windows reparse points.
(2) stx_rdev_*.
This will be set only if stx_mode indicates we're looking at a
blockdev or a chardev, otherwise will be 0.
(3) stx_btime.
Similar to (1), except this will be set to 0 if it doesn't exist.
=======
TESTING
=======
The following test program can be used to test the statx system call:
samples/statx/test-statx.c
Just compile and run, passing it paths to the files you want to examine.
The file is built automatically if CONFIG_SAMPLES is enabled.
Here's some example output. Firstly, an NFS directory that crosses to
another FSID. Note that the AUTOMOUNT attribute is set because transiting
this directory will cause d_automount to be invoked by the VFS.
[root@andromeda ~]# /tmp/test-statx -A /warthog/data
statx(/warthog/data) = 0
results=7ff
Size: 4096 Blocks: 8 IO Block: 1048576 directory
Device: 00:26 Inode: 1703937 Links: 125
Access: (3777/drwxrwxrwx) Uid: 0 Gid: 4041
Access: 2016-11-24 09:02:12.219699527+0000
Modify: 2016-11-17 10:44:36.225653653+0000
Change: 2016-11-17 10:44:36.225653653+0000
Attributes: 0000000000001000 (-------- -------- -------- -------- -------- -------- ---m---- --------)
Secondly, the result of automounting on that directory.
[root@andromeda ~]# /tmp/test-statx /warthog/data
statx(/warthog/data) = 0
results=7ff
Size: 4096 Blocks: 8 IO Block: 1048576 directory
Device: 00:27 Inode: 2 Links: 125
Access: (3777/drwxrwxrwx) Uid: 0 Gid: 4041
Access: 2016-11-24 09:02:12.219699527+0000
Modify: 2016-11-17 10:44:36.225653653+0000
Change: 2016-11-17 10:44:36.225653653+0000
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2017-01-31 19:46:22 +03:00
|
|
|
struct dentry *dentry = path->dentry;
|
2010-03-22 08:41:35 +03:00
|
|
|
struct ecryptfs_mount_crypt_stat *mount_crypt_stat;
|
|
|
|
int rc = 0;
|
|
|
|
|
|
|
|
mount_crypt_stat = &ecryptfs_superblock_to_private(
|
|
|
|
dentry->d_sb)->mount_crypt_stat;
|
2021-01-21 16:19:30 +03:00
|
|
|
generic_fillattr(&init_user_ns, d_inode(dentry), stat);
|
2010-03-22 08:41:35 +03:00
|
|
|
if (mount_crypt_stat->flags & ECRYPTFS_GLOBAL_ENCRYPT_FILENAMES) {
|
|
|
|
char *target;
|
|
|
|
size_t targetsiz;
|
|
|
|
|
2013-11-30 07:51:47 +04:00
|
|
|
target = ecryptfs_readlink_lower(dentry, &targetsiz);
|
|
|
|
if (!IS_ERR(target)) {
|
2010-03-22 08:41:35 +03:00
|
|
|
kfree(target);
|
|
|
|
stat->size = targetsiz;
|
2013-11-30 07:51:47 +04:00
|
|
|
} else {
|
|
|
|
rc = PTR_ERR(target);
|
2010-03-22 08:41:35 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
return rc;
|
|
|
|
}
|
|
|
|
|
2021-01-21 16:19:43 +03:00
|
|
|
static int ecryptfs_getattr(struct user_namespace *mnt_userns,
|
|
|
|
const struct path *path, struct kstat *stat,
|
statx: Add a system call to make enhanced file info available
Add a system call to make extended file information available, including
file creation and some attribute flags where available through the
underlying filesystem.
The getattr inode operation is altered to take two additional arguments: a
u32 request_mask and an unsigned int flags that indicate the
synchronisation mode. This change is propagated to the vfs_getattr*()
function.
Functions like vfs_stat() are now inline wrappers around new functions
vfs_statx() and vfs_statx_fd() to reduce stack usage.
========
OVERVIEW
========
The idea was initially proposed as a set of xattrs that could be retrieved
with getxattr(), but the general preference proved to be for a new syscall
with an extended stat structure.
A number of requests were gathered for features to be included. The
following have been included:
(1) Make the fields a consistent size on all arches and make them large.
(2) Spare space, request flags and information flags are provided for
future expansion.
(3) Better support for the y2038 problem [Arnd Bergmann] (tv_sec is an
__s64).
(4) Creation time: The SMB protocol carries the creation time, which could
be exported by Samba, which will in turn help CIFS make use of
FS-Cache as that can be used for coherency data (stx_btime).
This is also specified in NFSv4 as a recommended attribute and could
be exported by NFSD [Steve French].
(5) Lightweight stat: Ask for just those details of interest, and allow a
netfs (such as NFS) to approximate anything not of interest, possibly
without going to the server [Trond Myklebust, Ulrich Drepper, Andreas
Dilger] (AT_STATX_DONT_SYNC).
(6) Heavyweight stat: Force a netfs to go to the server, even if it thinks
its cached attributes are up to date [Trond Myklebust]
(AT_STATX_FORCE_SYNC).
And the following have been left out for future extension:
(7) Data version number: Could be used by userspace NFS servers [Aneesh
Kumar].
Can also be used to modify fill_post_wcc() in NFSD which retrieves
i_version directly, but has just called vfs_getattr(). It could get
it from the kstat struct if it used vfs_xgetattr() instead.
(There's disagreement on the exact semantics of a single field, since
not all filesystems do this the same way).
(8) BSD stat compatibility: Including more fields from the BSD stat such
as creation time (st_btime) and inode generation number (st_gen)
[Jeremy Allison, Bernd Schubert].
(9) Inode generation number: Useful for FUSE and userspace NFS servers
[Bernd Schubert].
(This was asked for but later deemed unnecessary with the
open-by-handle capability available and caused disagreement as to
whether it's a security hole or not).
(10) Extra coherency data may be useful in making backups [Andreas Dilger].
(No particular data were offered, but things like last backup
timestamp, the data version number and the DOS archive bit would come
into this category).
(11) Allow the filesystem to indicate what it can/cannot provide: A
filesystem can now say it doesn't support a standard stat feature if
that isn't available, so if, for instance, inode numbers or UIDs don't
exist or are fabricated locally...
(This requires a separate system call - I have an fsinfo() call idea
for this).
(12) Store a 16-byte volume ID in the superblock that can be returned in
struct xstat [Steve French].
(Deferred to fsinfo).
(13) Include granularity fields in the time data to indicate the
granularity of each of the times (NFSv4 time_delta) [Steve French].
(Deferred to fsinfo).
(14) FS_IOC_GETFLAGS value. These could be translated to BSD's st_flags.
Note that the Linux IOC flags are a mess and filesystems such as Ext4
define flags that aren't in linux/fs.h, so translation in the kernel
may be a necessity (or, possibly, we provide the filesystem type too).
(Some attributes are made available in stx_attributes, but the general
feeling was that the IOC flags were to ext[234]-specific and shouldn't
be exposed through statx this way).
(15) Mask of features available on file (eg: ACLs, seclabel) [Brad Boyer,
Michael Kerrisk].
(Deferred, probably to fsinfo. Finding out if there's an ACL or
seclabal might require extra filesystem operations).
(16) Femtosecond-resolution timestamps [Dave Chinner].
(A __reserved field has been left in the statx_timestamp struct for
this - if there proves to be a need).
(17) A set multiple attributes syscall to go with this.
===============
NEW SYSTEM CALL
===============
The new system call is:
int ret = statx(int dfd,
const char *filename,
unsigned int flags,
unsigned int mask,
struct statx *buffer);
The dfd, filename and flags parameters indicate the file to query, in a
similar way to fstatat(). There is no equivalent of lstat() as that can be
emulated with statx() by passing AT_SYMLINK_NOFOLLOW in flags. There is
also no equivalent of fstat() as that can be emulated by passing a NULL
filename to statx() with the fd of interest in dfd.
Whether or not statx() synchronises the attributes with the backing store
can be controlled by OR'ing a value into the flags argument (this typically
only affects network filesystems):
(1) AT_STATX_SYNC_AS_STAT tells statx() to behave as stat() does in this
respect.
(2) AT_STATX_FORCE_SYNC will require a network filesystem to synchronise
its attributes with the server - which might require data writeback to
occur to get the timestamps correct.
(3) AT_STATX_DONT_SYNC will suppress synchronisation with the server in a
network filesystem. The resulting values should be considered
approximate.
mask is a bitmask indicating the fields in struct statx that are of
interest to the caller. The user should set this to STATX_BASIC_STATS to
get the basic set returned by stat(). It should be noted that asking for
more information may entail extra I/O operations.
buffer points to the destination for the data. This must be 256 bytes in
size.
======================
MAIN ATTRIBUTES RECORD
======================
The following structures are defined in which to return the main attribute
set:
struct statx_timestamp {
__s64 tv_sec;
__s32 tv_nsec;
__s32 __reserved;
};
struct statx {
__u32 stx_mask;
__u32 stx_blksize;
__u64 stx_attributes;
__u32 stx_nlink;
__u32 stx_uid;
__u32 stx_gid;
__u16 stx_mode;
__u16 __spare0[1];
__u64 stx_ino;
__u64 stx_size;
__u64 stx_blocks;
__u64 __spare1[1];
struct statx_timestamp stx_atime;
struct statx_timestamp stx_btime;
struct statx_timestamp stx_ctime;
struct statx_timestamp stx_mtime;
__u32 stx_rdev_major;
__u32 stx_rdev_minor;
__u32 stx_dev_major;
__u32 stx_dev_minor;
__u64 __spare2[14];
};
The defined bits in request_mask and stx_mask are:
STATX_TYPE Want/got stx_mode & S_IFMT
STATX_MODE Want/got stx_mode & ~S_IFMT
STATX_NLINK Want/got stx_nlink
STATX_UID Want/got stx_uid
STATX_GID Want/got stx_gid
STATX_ATIME Want/got stx_atime{,_ns}
STATX_MTIME Want/got stx_mtime{,_ns}
STATX_CTIME Want/got stx_ctime{,_ns}
STATX_INO Want/got stx_ino
STATX_SIZE Want/got stx_size
STATX_BLOCKS Want/got stx_blocks
STATX_BASIC_STATS [The stuff in the normal stat struct]
STATX_BTIME Want/got stx_btime{,_ns}
STATX_ALL [All currently available stuff]
stx_btime is the file creation time, stx_mask is a bitmask indicating the
data provided and __spares*[] are where as-yet undefined fields can be
placed.
Time fields are structures with separate seconds and nanoseconds fields
plus a reserved field in case we want to add even finer resolution. Note
that times will be negative if before 1970; in such a case, the nanosecond
fields will also be negative if not zero.
The bits defined in the stx_attributes field convey information about a
file, how it is accessed, where it is and what it does. The following
attributes map to FS_*_FL flags and are the same numerical value:
STATX_ATTR_COMPRESSED File is compressed by the fs
STATX_ATTR_IMMUTABLE File is marked immutable
STATX_ATTR_APPEND File is append-only
STATX_ATTR_NODUMP File is not to be dumped
STATX_ATTR_ENCRYPTED File requires key to decrypt in fs
Within the kernel, the supported flags are listed by:
KSTAT_ATTR_FS_IOC_FLAGS
[Are any other IOC flags of sufficient general interest to be exposed
through this interface?]
New flags include:
STATX_ATTR_AUTOMOUNT Object is an automount trigger
These are for the use of GUI tools that might want to mark files specially,
depending on what they are.
Fields in struct statx come in a number of classes:
(0) stx_dev_*, stx_blksize.
These are local system information and are always available.
(1) stx_mode, stx_nlinks, stx_uid, stx_gid, stx_[amc]time, stx_ino,
stx_size, stx_blocks.
These will be returned whether the caller asks for them or not. The
corresponding bits in stx_mask will be set to indicate whether they
actually have valid values.
If the caller didn't ask for them, then they may be approximated. For
example, NFS won't waste any time updating them from the server,
unless as a byproduct of updating something requested.
If the values don't actually exist for the underlying object (such as
UID or GID on a DOS file), then the bit won't be set in the stx_mask,
even if the caller asked for the value. In such a case, the returned
value will be a fabrication.
Note that there are instances where the type might not be valid, for
instance Windows reparse points.
(2) stx_rdev_*.
This will be set only if stx_mode indicates we're looking at a
blockdev or a chardev, otherwise will be 0.
(3) stx_btime.
Similar to (1), except this will be set to 0 if it doesn't exist.
=======
TESTING
=======
The following test program can be used to test the statx system call:
samples/statx/test-statx.c
Just compile and run, passing it paths to the files you want to examine.
The file is built automatically if CONFIG_SAMPLES is enabled.
Here's some example output. Firstly, an NFS directory that crosses to
another FSID. Note that the AUTOMOUNT attribute is set because transiting
this directory will cause d_automount to be invoked by the VFS.
[root@andromeda ~]# /tmp/test-statx -A /warthog/data
statx(/warthog/data) = 0
results=7ff
Size: 4096 Blocks: 8 IO Block: 1048576 directory
Device: 00:26 Inode: 1703937 Links: 125
Access: (3777/drwxrwxrwx) Uid: 0 Gid: 4041
Access: 2016-11-24 09:02:12.219699527+0000
Modify: 2016-11-17 10:44:36.225653653+0000
Change: 2016-11-17 10:44:36.225653653+0000
Attributes: 0000000000001000 (-------- -------- -------- -------- -------- -------- ---m---- --------)
Secondly, the result of automounting on that directory.
[root@andromeda ~]# /tmp/test-statx /warthog/data
statx(/warthog/data) = 0
results=7ff
Size: 4096 Blocks: 8 IO Block: 1048576 directory
Device: 00:27 Inode: 2 Links: 125
Access: (3777/drwxrwxrwx) Uid: 0 Gid: 4041
Access: 2016-11-24 09:02:12.219699527+0000
Modify: 2016-11-17 10:44:36.225653653+0000
Change: 2016-11-17 10:44:36.225653653+0000
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2017-01-31 19:46:22 +03:00
|
|
|
u32 request_mask, unsigned int flags)
|
2009-11-04 11:48:01 +03:00
|
|
|
{
|
statx: Add a system call to make enhanced file info available
Add a system call to make extended file information available, including
file creation and some attribute flags where available through the
underlying filesystem.
The getattr inode operation is altered to take two additional arguments: a
u32 request_mask and an unsigned int flags that indicate the
synchronisation mode. This change is propagated to the vfs_getattr*()
function.
Functions like vfs_stat() are now inline wrappers around new functions
vfs_statx() and vfs_statx_fd() to reduce stack usage.
========
OVERVIEW
========
The idea was initially proposed as a set of xattrs that could be retrieved
with getxattr(), but the general preference proved to be for a new syscall
with an extended stat structure.
A number of requests were gathered for features to be included. The
following have been included:
(1) Make the fields a consistent size on all arches and make them large.
(2) Spare space, request flags and information flags are provided for
future expansion.
(3) Better support for the y2038 problem [Arnd Bergmann] (tv_sec is an
__s64).
(4) Creation time: The SMB protocol carries the creation time, which could
be exported by Samba, which will in turn help CIFS make use of
FS-Cache as that can be used for coherency data (stx_btime).
This is also specified in NFSv4 as a recommended attribute and could
be exported by NFSD [Steve French].
(5) Lightweight stat: Ask for just those details of interest, and allow a
netfs (such as NFS) to approximate anything not of interest, possibly
without going to the server [Trond Myklebust, Ulrich Drepper, Andreas
Dilger] (AT_STATX_DONT_SYNC).
(6) Heavyweight stat: Force a netfs to go to the server, even if it thinks
its cached attributes are up to date [Trond Myklebust]
(AT_STATX_FORCE_SYNC).
And the following have been left out for future extension:
(7) Data version number: Could be used by userspace NFS servers [Aneesh
Kumar].
Can also be used to modify fill_post_wcc() in NFSD which retrieves
i_version directly, but has just called vfs_getattr(). It could get
it from the kstat struct if it used vfs_xgetattr() instead.
(There's disagreement on the exact semantics of a single field, since
not all filesystems do this the same way).
(8) BSD stat compatibility: Including more fields from the BSD stat such
as creation time (st_btime) and inode generation number (st_gen)
[Jeremy Allison, Bernd Schubert].
(9) Inode generation number: Useful for FUSE and userspace NFS servers
[Bernd Schubert].
(This was asked for but later deemed unnecessary with the
open-by-handle capability available and caused disagreement as to
whether it's a security hole or not).
(10) Extra coherency data may be useful in making backups [Andreas Dilger].
(No particular data were offered, but things like last backup
timestamp, the data version number and the DOS archive bit would come
into this category).
(11) Allow the filesystem to indicate what it can/cannot provide: A
filesystem can now say it doesn't support a standard stat feature if
that isn't available, so if, for instance, inode numbers or UIDs don't
exist or are fabricated locally...
(This requires a separate system call - I have an fsinfo() call idea
for this).
(12) Store a 16-byte volume ID in the superblock that can be returned in
struct xstat [Steve French].
(Deferred to fsinfo).
(13) Include granularity fields in the time data to indicate the
granularity of each of the times (NFSv4 time_delta) [Steve French].
(Deferred to fsinfo).
(14) FS_IOC_GETFLAGS value. These could be translated to BSD's st_flags.
Note that the Linux IOC flags are a mess and filesystems such as Ext4
define flags that aren't in linux/fs.h, so translation in the kernel
may be a necessity (or, possibly, we provide the filesystem type too).
(Some attributes are made available in stx_attributes, but the general
feeling was that the IOC flags were to ext[234]-specific and shouldn't
be exposed through statx this way).
(15) Mask of features available on file (eg: ACLs, seclabel) [Brad Boyer,
Michael Kerrisk].
(Deferred, probably to fsinfo. Finding out if there's an ACL or
seclabal might require extra filesystem operations).
(16) Femtosecond-resolution timestamps [Dave Chinner].
(A __reserved field has been left in the statx_timestamp struct for
this - if there proves to be a need).
(17) A set multiple attributes syscall to go with this.
===============
NEW SYSTEM CALL
===============
The new system call is:
int ret = statx(int dfd,
const char *filename,
unsigned int flags,
unsigned int mask,
struct statx *buffer);
The dfd, filename and flags parameters indicate the file to query, in a
similar way to fstatat(). There is no equivalent of lstat() as that can be
emulated with statx() by passing AT_SYMLINK_NOFOLLOW in flags. There is
also no equivalent of fstat() as that can be emulated by passing a NULL
filename to statx() with the fd of interest in dfd.
Whether or not statx() synchronises the attributes with the backing store
can be controlled by OR'ing a value into the flags argument (this typically
only affects network filesystems):
(1) AT_STATX_SYNC_AS_STAT tells statx() to behave as stat() does in this
respect.
(2) AT_STATX_FORCE_SYNC will require a network filesystem to synchronise
its attributes with the server - which might require data writeback to
occur to get the timestamps correct.
(3) AT_STATX_DONT_SYNC will suppress synchronisation with the server in a
network filesystem. The resulting values should be considered
approximate.
mask is a bitmask indicating the fields in struct statx that are of
interest to the caller. The user should set this to STATX_BASIC_STATS to
get the basic set returned by stat(). It should be noted that asking for
more information may entail extra I/O operations.
buffer points to the destination for the data. This must be 256 bytes in
size.
======================
MAIN ATTRIBUTES RECORD
======================
The following structures are defined in which to return the main attribute
set:
struct statx_timestamp {
__s64 tv_sec;
__s32 tv_nsec;
__s32 __reserved;
};
struct statx {
__u32 stx_mask;
__u32 stx_blksize;
__u64 stx_attributes;
__u32 stx_nlink;
__u32 stx_uid;
__u32 stx_gid;
__u16 stx_mode;
__u16 __spare0[1];
__u64 stx_ino;
__u64 stx_size;
__u64 stx_blocks;
__u64 __spare1[1];
struct statx_timestamp stx_atime;
struct statx_timestamp stx_btime;
struct statx_timestamp stx_ctime;
struct statx_timestamp stx_mtime;
__u32 stx_rdev_major;
__u32 stx_rdev_minor;
__u32 stx_dev_major;
__u32 stx_dev_minor;
__u64 __spare2[14];
};
The defined bits in request_mask and stx_mask are:
STATX_TYPE Want/got stx_mode & S_IFMT
STATX_MODE Want/got stx_mode & ~S_IFMT
STATX_NLINK Want/got stx_nlink
STATX_UID Want/got stx_uid
STATX_GID Want/got stx_gid
STATX_ATIME Want/got stx_atime{,_ns}
STATX_MTIME Want/got stx_mtime{,_ns}
STATX_CTIME Want/got stx_ctime{,_ns}
STATX_INO Want/got stx_ino
STATX_SIZE Want/got stx_size
STATX_BLOCKS Want/got stx_blocks
STATX_BASIC_STATS [The stuff in the normal stat struct]
STATX_BTIME Want/got stx_btime{,_ns}
STATX_ALL [All currently available stuff]
stx_btime is the file creation time, stx_mask is a bitmask indicating the
data provided and __spares*[] are where as-yet undefined fields can be
placed.
Time fields are structures with separate seconds and nanoseconds fields
plus a reserved field in case we want to add even finer resolution. Note
that times will be negative if before 1970; in such a case, the nanosecond
fields will also be negative if not zero.
The bits defined in the stx_attributes field convey information about a
file, how it is accessed, where it is and what it does. The following
attributes map to FS_*_FL flags and are the same numerical value:
STATX_ATTR_COMPRESSED File is compressed by the fs
STATX_ATTR_IMMUTABLE File is marked immutable
STATX_ATTR_APPEND File is append-only
STATX_ATTR_NODUMP File is not to be dumped
STATX_ATTR_ENCRYPTED File requires key to decrypt in fs
Within the kernel, the supported flags are listed by:
KSTAT_ATTR_FS_IOC_FLAGS
[Are any other IOC flags of sufficient general interest to be exposed
through this interface?]
New flags include:
STATX_ATTR_AUTOMOUNT Object is an automount trigger
These are for the use of GUI tools that might want to mark files specially,
depending on what they are.
Fields in struct statx come in a number of classes:
(0) stx_dev_*, stx_blksize.
These are local system information and are always available.
(1) stx_mode, stx_nlinks, stx_uid, stx_gid, stx_[amc]time, stx_ino,
stx_size, stx_blocks.
These will be returned whether the caller asks for them or not. The
corresponding bits in stx_mask will be set to indicate whether they
actually have valid values.
If the caller didn't ask for them, then they may be approximated. For
example, NFS won't waste any time updating them from the server,
unless as a byproduct of updating something requested.
If the values don't actually exist for the underlying object (such as
UID or GID on a DOS file), then the bit won't be set in the stx_mask,
even if the caller asked for the value. In such a case, the returned
value will be a fabrication.
Note that there are instances where the type might not be valid, for
instance Windows reparse points.
(2) stx_rdev_*.
This will be set only if stx_mode indicates we're looking at a
blockdev or a chardev, otherwise will be 0.
(3) stx_btime.
Similar to (1), except this will be set to 0 if it doesn't exist.
=======
TESTING
=======
The following test program can be used to test the statx system call:
samples/statx/test-statx.c
Just compile and run, passing it paths to the files you want to examine.
The file is built automatically if CONFIG_SAMPLES is enabled.
Here's some example output. Firstly, an NFS directory that crosses to
another FSID. Note that the AUTOMOUNT attribute is set because transiting
this directory will cause d_automount to be invoked by the VFS.
[root@andromeda ~]# /tmp/test-statx -A /warthog/data
statx(/warthog/data) = 0
results=7ff
Size: 4096 Blocks: 8 IO Block: 1048576 directory
Device: 00:26 Inode: 1703937 Links: 125
Access: (3777/drwxrwxrwx) Uid: 0 Gid: 4041
Access: 2016-11-24 09:02:12.219699527+0000
Modify: 2016-11-17 10:44:36.225653653+0000
Change: 2016-11-17 10:44:36.225653653+0000
Attributes: 0000000000001000 (-------- -------- -------- -------- -------- -------- ---m---- --------)
Secondly, the result of automounting on that directory.
[root@andromeda ~]# /tmp/test-statx /warthog/data
statx(/warthog/data) = 0
results=7ff
Size: 4096 Blocks: 8 IO Block: 1048576 directory
Device: 00:27 Inode: 2 Links: 125
Access: (3777/drwxrwxrwx) Uid: 0 Gid: 4041
Access: 2016-11-24 09:02:12.219699527+0000
Modify: 2016-11-17 10:44:36.225653653+0000
Change: 2016-11-17 10:44:36.225653653+0000
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2017-01-31 19:46:22 +03:00
|
|
|
struct dentry *dentry = path->dentry;
|
2009-11-04 11:48:01 +03:00
|
|
|
struct kstat lower_stat;
|
|
|
|
int rc;
|
|
|
|
|
statx: Add a system call to make enhanced file info available
Add a system call to make extended file information available, including
file creation and some attribute flags where available through the
underlying filesystem.
The getattr inode operation is altered to take two additional arguments: a
u32 request_mask and an unsigned int flags that indicate the
synchronisation mode. This change is propagated to the vfs_getattr*()
function.
Functions like vfs_stat() are now inline wrappers around new functions
vfs_statx() and vfs_statx_fd() to reduce stack usage.
========
OVERVIEW
========
The idea was initially proposed as a set of xattrs that could be retrieved
with getxattr(), but the general preference proved to be for a new syscall
with an extended stat structure.
A number of requests were gathered for features to be included. The
following have been included:
(1) Make the fields a consistent size on all arches and make them large.
(2) Spare space, request flags and information flags are provided for
future expansion.
(3) Better support for the y2038 problem [Arnd Bergmann] (tv_sec is an
__s64).
(4) Creation time: The SMB protocol carries the creation time, which could
be exported by Samba, which will in turn help CIFS make use of
FS-Cache as that can be used for coherency data (stx_btime).
This is also specified in NFSv4 as a recommended attribute and could
be exported by NFSD [Steve French].
(5) Lightweight stat: Ask for just those details of interest, and allow a
netfs (such as NFS) to approximate anything not of interest, possibly
without going to the server [Trond Myklebust, Ulrich Drepper, Andreas
Dilger] (AT_STATX_DONT_SYNC).
(6) Heavyweight stat: Force a netfs to go to the server, even if it thinks
its cached attributes are up to date [Trond Myklebust]
(AT_STATX_FORCE_SYNC).
And the following have been left out for future extension:
(7) Data version number: Could be used by userspace NFS servers [Aneesh
Kumar].
Can also be used to modify fill_post_wcc() in NFSD which retrieves
i_version directly, but has just called vfs_getattr(). It could get
it from the kstat struct if it used vfs_xgetattr() instead.
(There's disagreement on the exact semantics of a single field, since
not all filesystems do this the same way).
(8) BSD stat compatibility: Including more fields from the BSD stat such
as creation time (st_btime) and inode generation number (st_gen)
[Jeremy Allison, Bernd Schubert].
(9) Inode generation number: Useful for FUSE and userspace NFS servers
[Bernd Schubert].
(This was asked for but later deemed unnecessary with the
open-by-handle capability available and caused disagreement as to
whether it's a security hole or not).
(10) Extra coherency data may be useful in making backups [Andreas Dilger].
(No particular data were offered, but things like last backup
timestamp, the data version number and the DOS archive bit would come
into this category).
(11) Allow the filesystem to indicate what it can/cannot provide: A
filesystem can now say it doesn't support a standard stat feature if
that isn't available, so if, for instance, inode numbers or UIDs don't
exist or are fabricated locally...
(This requires a separate system call - I have an fsinfo() call idea
for this).
(12) Store a 16-byte volume ID in the superblock that can be returned in
struct xstat [Steve French].
(Deferred to fsinfo).
(13) Include granularity fields in the time data to indicate the
granularity of each of the times (NFSv4 time_delta) [Steve French].
(Deferred to fsinfo).
(14) FS_IOC_GETFLAGS value. These could be translated to BSD's st_flags.
Note that the Linux IOC flags are a mess and filesystems such as Ext4
define flags that aren't in linux/fs.h, so translation in the kernel
may be a necessity (or, possibly, we provide the filesystem type too).
(Some attributes are made available in stx_attributes, but the general
feeling was that the IOC flags were to ext[234]-specific and shouldn't
be exposed through statx this way).
(15) Mask of features available on file (eg: ACLs, seclabel) [Brad Boyer,
Michael Kerrisk].
(Deferred, probably to fsinfo. Finding out if there's an ACL or
seclabal might require extra filesystem operations).
(16) Femtosecond-resolution timestamps [Dave Chinner].
(A __reserved field has been left in the statx_timestamp struct for
this - if there proves to be a need).
(17) A set multiple attributes syscall to go with this.
===============
NEW SYSTEM CALL
===============
The new system call is:
int ret = statx(int dfd,
const char *filename,
unsigned int flags,
unsigned int mask,
struct statx *buffer);
The dfd, filename and flags parameters indicate the file to query, in a
similar way to fstatat(). There is no equivalent of lstat() as that can be
emulated with statx() by passing AT_SYMLINK_NOFOLLOW in flags. There is
also no equivalent of fstat() as that can be emulated by passing a NULL
filename to statx() with the fd of interest in dfd.
Whether or not statx() synchronises the attributes with the backing store
can be controlled by OR'ing a value into the flags argument (this typically
only affects network filesystems):
(1) AT_STATX_SYNC_AS_STAT tells statx() to behave as stat() does in this
respect.
(2) AT_STATX_FORCE_SYNC will require a network filesystem to synchronise
its attributes with the server - which might require data writeback to
occur to get the timestamps correct.
(3) AT_STATX_DONT_SYNC will suppress synchronisation with the server in a
network filesystem. The resulting values should be considered
approximate.
mask is a bitmask indicating the fields in struct statx that are of
interest to the caller. The user should set this to STATX_BASIC_STATS to
get the basic set returned by stat(). It should be noted that asking for
more information may entail extra I/O operations.
buffer points to the destination for the data. This must be 256 bytes in
size.
======================
MAIN ATTRIBUTES RECORD
======================
The following structures are defined in which to return the main attribute
set:
struct statx_timestamp {
__s64 tv_sec;
__s32 tv_nsec;
__s32 __reserved;
};
struct statx {
__u32 stx_mask;
__u32 stx_blksize;
__u64 stx_attributes;
__u32 stx_nlink;
__u32 stx_uid;
__u32 stx_gid;
__u16 stx_mode;
__u16 __spare0[1];
__u64 stx_ino;
__u64 stx_size;
__u64 stx_blocks;
__u64 __spare1[1];
struct statx_timestamp stx_atime;
struct statx_timestamp stx_btime;
struct statx_timestamp stx_ctime;
struct statx_timestamp stx_mtime;
__u32 stx_rdev_major;
__u32 stx_rdev_minor;
__u32 stx_dev_major;
__u32 stx_dev_minor;
__u64 __spare2[14];
};
The defined bits in request_mask and stx_mask are:
STATX_TYPE Want/got stx_mode & S_IFMT
STATX_MODE Want/got stx_mode & ~S_IFMT
STATX_NLINK Want/got stx_nlink
STATX_UID Want/got stx_uid
STATX_GID Want/got stx_gid
STATX_ATIME Want/got stx_atime{,_ns}
STATX_MTIME Want/got stx_mtime{,_ns}
STATX_CTIME Want/got stx_ctime{,_ns}
STATX_INO Want/got stx_ino
STATX_SIZE Want/got stx_size
STATX_BLOCKS Want/got stx_blocks
STATX_BASIC_STATS [The stuff in the normal stat struct]
STATX_BTIME Want/got stx_btime{,_ns}
STATX_ALL [All currently available stuff]
stx_btime is the file creation time, stx_mask is a bitmask indicating the
data provided and __spares*[] are where as-yet undefined fields can be
placed.
Time fields are structures with separate seconds and nanoseconds fields
plus a reserved field in case we want to add even finer resolution. Note
that times will be negative if before 1970; in such a case, the nanosecond
fields will also be negative if not zero.
The bits defined in the stx_attributes field convey information about a
file, how it is accessed, where it is and what it does. The following
attributes map to FS_*_FL flags and are the same numerical value:
STATX_ATTR_COMPRESSED File is compressed by the fs
STATX_ATTR_IMMUTABLE File is marked immutable
STATX_ATTR_APPEND File is append-only
STATX_ATTR_NODUMP File is not to be dumped
STATX_ATTR_ENCRYPTED File requires key to decrypt in fs
Within the kernel, the supported flags are listed by:
KSTAT_ATTR_FS_IOC_FLAGS
[Are any other IOC flags of sufficient general interest to be exposed
through this interface?]
New flags include:
STATX_ATTR_AUTOMOUNT Object is an automount trigger
These are for the use of GUI tools that might want to mark files specially,
depending on what they are.
Fields in struct statx come in a number of classes:
(0) stx_dev_*, stx_blksize.
These are local system information and are always available.
(1) stx_mode, stx_nlinks, stx_uid, stx_gid, stx_[amc]time, stx_ino,
stx_size, stx_blocks.
These will be returned whether the caller asks for them or not. The
corresponding bits in stx_mask will be set to indicate whether they
actually have valid values.
If the caller didn't ask for them, then they may be approximated. For
example, NFS won't waste any time updating them from the server,
unless as a byproduct of updating something requested.
If the values don't actually exist for the underlying object (such as
UID or GID on a DOS file), then the bit won't be set in the stx_mask,
even if the caller asked for the value. In such a case, the returned
value will be a fabrication.
Note that there are instances where the type might not be valid, for
instance Windows reparse points.
(2) stx_rdev_*.
This will be set only if stx_mode indicates we're looking at a
blockdev or a chardev, otherwise will be 0.
(3) stx_btime.
Similar to (1), except this will be set to 0 if it doesn't exist.
=======
TESTING
=======
The following test program can be used to test the statx system call:
samples/statx/test-statx.c
Just compile and run, passing it paths to the files you want to examine.
The file is built automatically if CONFIG_SAMPLES is enabled.
Here's some example output. Firstly, an NFS directory that crosses to
another FSID. Note that the AUTOMOUNT attribute is set because transiting
this directory will cause d_automount to be invoked by the VFS.
[root@andromeda ~]# /tmp/test-statx -A /warthog/data
statx(/warthog/data) = 0
results=7ff
Size: 4096 Blocks: 8 IO Block: 1048576 directory
Device: 00:26 Inode: 1703937 Links: 125
Access: (3777/drwxrwxrwx) Uid: 0 Gid: 4041
Access: 2016-11-24 09:02:12.219699527+0000
Modify: 2016-11-17 10:44:36.225653653+0000
Change: 2016-11-17 10:44:36.225653653+0000
Attributes: 0000000000001000 (-------- -------- -------- -------- -------- -------- ---m---- --------)
Secondly, the result of automounting on that directory.
[root@andromeda ~]# /tmp/test-statx /warthog/data
statx(/warthog/data) = 0
results=7ff
Size: 4096 Blocks: 8 IO Block: 1048576 directory
Device: 00:27 Inode: 2 Links: 125
Access: (3777/drwxrwxrwx) Uid: 0 Gid: 4041
Access: 2016-11-24 09:02:12.219699527+0000
Modify: 2016-11-17 10:44:36.225653653+0000
Change: 2016-11-17 10:44:36.225653653+0000
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2017-01-31 19:46:22 +03:00
|
|
|
rc = vfs_getattr(ecryptfs_dentry_to_lower_path(dentry), &lower_stat,
|
|
|
|
request_mask, flags);
|
2009-11-04 11:48:01 +03:00
|
|
|
if (!rc) {
|
2015-03-18 01:25:59 +03:00
|
|
|
fsstack_copy_attr_all(d_inode(dentry),
|
|
|
|
ecryptfs_inode_to_lower(d_inode(dentry)));
|
2021-01-21 16:19:30 +03:00
|
|
|
generic_fillattr(&init_user_ns, d_inode(dentry), stat);
|
2009-11-04 11:48:01 +03:00
|
|
|
stat->blocks = lower_stat.blocks;
|
|
|
|
}
|
|
|
|
return rc;
|
|
|
|
}
|
|
|
|
|
2007-02-12 11:53:46 +03:00
|
|
|
int
|
2016-05-27 18:06:05 +03:00
|
|
|
ecryptfs_setxattr(struct dentry *dentry, struct inode *inode,
|
|
|
|
const char *name, const void *value,
|
2006-10-04 13:16:22 +04:00
|
|
|
size_t size, int flags)
|
|
|
|
{
|
2016-09-29 18:48:42 +03:00
|
|
|
int rc;
|
2006-10-04 13:16:22 +04:00
|
|
|
struct dentry *lower_dentry;
|
2021-01-19 19:22:03 +03:00
|
|
|
struct inode *lower_inode;
|
2006-10-04 13:16:22 +04:00
|
|
|
|
|
|
|
lower_dentry = ecryptfs_dentry_to_lower(dentry);
|
2021-01-19 19:22:03 +03:00
|
|
|
lower_inode = d_inode(lower_dentry);
|
|
|
|
if (!(lower_inode->i_opflags & IOP_XATTR)) {
|
2010-03-23 19:51:38 +03:00
|
|
|
rc = -EOPNOTSUPP;
|
2006-10-04 13:16:22 +04:00
|
|
|
goto out;
|
|
|
|
}
|
2021-01-19 19:22:03 +03:00
|
|
|
inode_lock(lower_inode);
|
idmapped-mounts-v5.12
-----BEGIN PGP SIGNATURE-----
iHUEABYKAB0WIQRAhzRXHqcMeLMyaSiRxhvAZXjcogUCYCegywAKCRCRxhvAZXjc
ouJ6AQDlf+7jCQlQdeKKoN9QDFfMzG1ooemat36EpRRTONaGuAD8D9A4sUsG4+5f
4IU5Lj9oY4DEmF8HenbWK2ZHsesL2Qg=
=yPaw
-----END PGP SIGNATURE-----
Merge tag 'idmapped-mounts-v5.12' of git://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux
Pull idmapped mounts from Christian Brauner:
"This introduces idmapped mounts which has been in the making for some
time. Simply put, different mounts can expose the same file or
directory with different ownership. This initial implementation comes
with ports for fat, ext4 and with Christoph's port for xfs with more
filesystems being actively worked on by independent people and
maintainers.
Idmapping mounts handle a wide range of long standing use-cases. Here
are just a few:
- Idmapped mounts make it possible to easily share files between
multiple users or multiple machines especially in complex
scenarios. For example, idmapped mounts will be used in the
implementation of portable home directories in
systemd-homed.service(8) where they allow users to move their home
directory to an external storage device and use it on multiple
computers where they are assigned different uids and gids. This
effectively makes it possible to assign random uids and gids at
login time.
- It is possible to share files from the host with unprivileged
containers without having to change ownership permanently through
chown(2).
- It is possible to idmap a container's rootfs and without having to
mangle every file. For example, Chromebooks use it to share the
user's Download folder with their unprivileged containers in their
Linux subsystem.
- It is possible to share files between containers with
non-overlapping idmappings.
- Filesystem that lack a proper concept of ownership such as fat can
use idmapped mounts to implement discretionary access (DAC)
permission checking.
- They allow users to efficiently changing ownership on a per-mount
basis without having to (recursively) chown(2) all files. In
contrast to chown (2) changing ownership of large sets of files is
instantenous with idmapped mounts. This is especially useful when
ownership of a whole root filesystem of a virtual machine or
container is changed. With idmapped mounts a single syscall
mount_setattr syscall will be sufficient to change the ownership of
all files.
- Idmapped mounts always take the current ownership into account as
idmappings specify what a given uid or gid is supposed to be mapped
to. This contrasts with the chown(2) syscall which cannot by itself
take the current ownership of the files it changes into account. It
simply changes the ownership to the specified uid and gid. This is
especially problematic when recursively chown(2)ing a large set of
files which is commong with the aforementioned portable home
directory and container and vm scenario.
- Idmapped mounts allow to change ownership locally, restricting it
to specific mounts, and temporarily as the ownership changes only
apply as long as the mount exists.
Several userspace projects have either already put up patches and
pull-requests for this feature or will do so should you decide to pull
this:
- systemd: In a wide variety of scenarios but especially right away
in their implementation of portable home directories.
https://systemd.io/HOME_DIRECTORY/
- container runtimes: containerd, runC, LXD:To share data between
host and unprivileged containers, unprivileged and privileged
containers, etc. The pull request for idmapped mounts support in
containerd, the default Kubernetes runtime is already up for quite
a while now: https://github.com/containerd/containerd/pull/4734
- The virtio-fs developers and several users have expressed interest
in using this feature with virtual machines once virtio-fs is
ported.
- ChromeOS: Sharing host-directories with unprivileged containers.
I've tightly synced with all those projects and all of those listed
here have also expressed their need/desire for this feature on the
mailing list. For more info on how people use this there's a bunch of
talks about this too. Here's just two recent ones:
https://www.cncf.io/wp-content/uploads/2020/12/Rootless-Containers-in-Gitpod.pdf
https://fosdem.org/2021/schedule/event/containers_idmap/
This comes with an extensive xfstests suite covering both ext4 and
xfs:
https://git.kernel.org/brauner/xfstests-dev/h/idmapped_mounts
It covers truncation, creation, opening, xattrs, vfscaps, setid
execution, setgid inheritance and more both with idmapped and
non-idmapped mounts. It already helped to discover an unrelated xfs
setgid inheritance bug which has since been fixed in mainline. It will
be sent for inclusion with the xfstests project should you decide to
merge this.
In order to support per-mount idmappings vfsmounts are marked with
user namespaces. The idmapping of the user namespace will be used to
map the ids of vfs objects when they are accessed through that mount.
By default all vfsmounts are marked with the initial user namespace.
The initial user namespace is used to indicate that a mount is not
idmapped. All operations behave as before and this is verified in the
testsuite.
Based on prior discussions we want to attach the whole user namespace
and not just a dedicated idmapping struct. This allows us to reuse all
the helpers that already exist for dealing with idmappings instead of
introducing a whole new range of helpers. In addition, if we decide in
the future that we are confident enough to enable unprivileged users
to setup idmapped mounts the permission checking can take into account
whether the caller is privileged in the user namespace the mount is
currently marked with.
The user namespace the mount will be marked with can be specified by
passing a file descriptor refering to the user namespace as an
argument to the new mount_setattr() syscall together with the new
MOUNT_ATTR_IDMAP flag. The system call follows the openat2() pattern
of extensibility.
The following conditions must be met in order to create an idmapped
mount:
- The caller must currently have the CAP_SYS_ADMIN capability in the
user namespace the underlying filesystem has been mounted in.
- The underlying filesystem must support idmapped mounts.
- The mount must not already be idmapped. This also implies that the
idmapping of a mount cannot be altered once it has been idmapped.
- The mount must be a detached/anonymous mount, i.e. it must have
been created by calling open_tree() with the OPEN_TREE_CLONE flag
and it must not already have been visible in the filesystem.
The last two points guarantee easier semantics for userspace and the
kernel and make the implementation significantly simpler.
By default vfsmounts are marked with the initial user namespace and no
behavioral or performance changes are observed.
The manpage with a detailed description can be found here:
https://git.kernel.org/brauner/man-pages/c/1d7b902e2875a1ff342e036a9f866a995640aea8
In order to support idmapped mounts, filesystems need to be changed
and mark themselves with the FS_ALLOW_IDMAP flag in fs_flags. The
patches to convert individual filesystem are not very large or
complicated overall as can be seen from the included fat, ext4, and
xfs ports. Patches for other filesystems are actively worked on and
will be sent out separately. The xfstestsuite can be used to verify
that port has been done correctly.
The mount_setattr() syscall is motivated independent of the idmapped
mounts patches and it's been around since July 2019. One of the most
valuable features of the new mount api is the ability to perform
mounts based on file descriptors only.
Together with the lookup restrictions available in the openat2()
RESOLVE_* flag namespace which we added in v5.6 this is the first time
we are close to hardened and race-free (e.g. symlinks) mounting and
path resolution.
While userspace has started porting to the new mount api to mount
proper filesystems and create new bind-mounts it is currently not
possible to change mount options of an already existing bind mount in
the new mount api since the mount_setattr() syscall is missing.
With the addition of the mount_setattr() syscall we remove this last
restriction and userspace can now fully port to the new mount api,
covering every use-case the old mount api could. We also add the
crucial ability to recursively change mount options for a whole mount
tree, both removing and adding mount options at the same time. This
syscall has been requested multiple times by various people and
projects.
There is a simple tool available at
https://github.com/brauner/mount-idmapped
that allows to create idmapped mounts so people can play with this
patch series. I'll add support for the regular mount binary should you
decide to pull this in the following weeks:
Here's an example to a simple idmapped mount of another user's home
directory:
u1001@f2-vm:/$ sudo ./mount --idmap both:1000:1001:1 /home/ubuntu/ /mnt
u1001@f2-vm:/$ ls -al /home/ubuntu/
total 28
drwxr-xr-x 2 ubuntu ubuntu 4096 Oct 28 22:07 .
drwxr-xr-x 4 root root 4096 Oct 28 04:00 ..
-rw------- 1 ubuntu ubuntu 3154 Oct 28 22:12 .bash_history
-rw-r--r-- 1 ubuntu ubuntu 220 Feb 25 2020 .bash_logout
-rw-r--r-- 1 ubuntu ubuntu 3771 Feb 25 2020 .bashrc
-rw-r--r-- 1 ubuntu ubuntu 807 Feb 25 2020 .profile
-rw-r--r-- 1 ubuntu ubuntu 0 Oct 16 16:11 .sudo_as_admin_successful
-rw------- 1 ubuntu ubuntu 1144 Oct 28 00:43 .viminfo
u1001@f2-vm:/$ ls -al /mnt/
total 28
drwxr-xr-x 2 u1001 u1001 4096 Oct 28 22:07 .
drwxr-xr-x 29 root root 4096 Oct 28 22:01 ..
-rw------- 1 u1001 u1001 3154 Oct 28 22:12 .bash_history
-rw-r--r-- 1 u1001 u1001 220 Feb 25 2020 .bash_logout
-rw-r--r-- 1 u1001 u1001 3771 Feb 25 2020 .bashrc
-rw-r--r-- 1 u1001 u1001 807 Feb 25 2020 .profile
-rw-r--r-- 1 u1001 u1001 0 Oct 16 16:11 .sudo_as_admin_successful
-rw------- 1 u1001 u1001 1144 Oct 28 00:43 .viminfo
u1001@f2-vm:/$ touch /mnt/my-file
u1001@f2-vm:/$ setfacl -m u:1001:rwx /mnt/my-file
u1001@f2-vm:/$ sudo setcap -n 1001 cap_net_raw+ep /mnt/my-file
u1001@f2-vm:/$ ls -al /mnt/my-file
-rw-rwxr--+ 1 u1001 u1001 0 Oct 28 22:14 /mnt/my-file
u1001@f2-vm:/$ ls -al /home/ubuntu/my-file
-rw-rwxr--+ 1 ubuntu ubuntu 0 Oct 28 22:14 /home/ubuntu/my-file
u1001@f2-vm:/$ getfacl /mnt/my-file
getfacl: Removing leading '/' from absolute path names
# file: mnt/my-file
# owner: u1001
# group: u1001
user::rw-
user:u1001:rwx
group::rw-
mask::rwx
other::r--
u1001@f2-vm:/$ getfacl /home/ubuntu/my-file
getfacl: Removing leading '/' from absolute path names
# file: home/ubuntu/my-file
# owner: ubuntu
# group: ubuntu
user::rw-
user:ubuntu:rwx
group::rw-
mask::rwx
other::r--"
* tag 'idmapped-mounts-v5.12' of git://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux: (41 commits)
xfs: remove the possibly unused mp variable in xfs_file_compat_ioctl
xfs: support idmapped mounts
ext4: support idmapped mounts
fat: handle idmapped mounts
tests: add mount_setattr() selftests
fs: introduce MOUNT_ATTR_IDMAP
fs: add mount_setattr()
fs: add attr_flags_to_mnt_flags helper
fs: split out functions to hold writers
namespace: only take read lock in do_reconfigure_mnt()
mount: make {lock,unlock}_mount_hash() static
namespace: take lock_mount_hash() directly when changing flags
nfs: do not export idmapped mounts
overlayfs: do not mount on top of idmapped mounts
ecryptfs: do not mount on top of idmapped mounts
ima: handle idmapped mounts
apparmor: handle idmapped mounts
fs: make helpers idmap mount aware
exec: handle idmapped mounts
would_dump: handle idmapped mounts
...
2021-02-24 00:39:45 +03:00
|
|
|
rc = __vfs_setxattr_locked(&init_user_ns, lower_dentry, name, value, size, flags, NULL);
|
2021-01-19 19:22:03 +03:00
|
|
|
inode_unlock(lower_inode);
|
2016-05-27 18:06:05 +03:00
|
|
|
if (!rc && inode)
|
2021-01-19 19:22:03 +03:00
|
|
|
fsstack_copy_attr_all(inode, lower_inode);
|
2006-10-04 13:16:22 +04:00
|
|
|
out:
|
|
|
|
return rc;
|
|
|
|
}
|
|
|
|
|
2007-10-16 12:28:10 +04:00
|
|
|
ssize_t
|
2016-04-11 07:48:00 +03:00
|
|
|
ecryptfs_getxattr_lower(struct dentry *lower_dentry, struct inode *lower_inode,
|
|
|
|
const char *name, void *value, size_t size)
|
2007-10-16 12:28:10 +04:00
|
|
|
{
|
2016-09-29 18:48:42 +03:00
|
|
|
int rc;
|
2007-10-16 12:28:10 +04:00
|
|
|
|
2016-09-29 18:48:42 +03:00
|
|
|
if (!(lower_inode->i_opflags & IOP_XATTR)) {
|
2010-03-23 19:51:38 +03:00
|
|
|
rc = -EOPNOTSUPP;
|
2007-10-16 12:28:10 +04:00
|
|
|
goto out;
|
|
|
|
}
|
2016-04-11 07:48:00 +03:00
|
|
|
inode_lock(lower_inode);
|
2016-09-29 18:48:42 +03:00
|
|
|
rc = __vfs_getxattr(lower_dentry, lower_inode, name, value, size);
|
2016-04-11 07:48:00 +03:00
|
|
|
inode_unlock(lower_inode);
|
2007-10-16 12:28:10 +04:00
|
|
|
out:
|
|
|
|
return rc;
|
|
|
|
}
|
|
|
|
|
2008-02-06 12:38:32 +03:00
|
|
|
static ssize_t
|
2016-04-11 07:48:00 +03:00
|
|
|
ecryptfs_getxattr(struct dentry *dentry, struct inode *inode,
|
|
|
|
const char *name, void *value, size_t size)
|
2006-10-04 13:16:22 +04:00
|
|
|
{
|
2016-04-11 07:48:00 +03:00
|
|
|
return ecryptfs_getxattr_lower(ecryptfs_dentry_to_lower(dentry),
|
|
|
|
ecryptfs_inode_to_lower(inode),
|
|
|
|
name, value, size);
|
2006-10-04 13:16:22 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
static ssize_t
|
|
|
|
ecryptfs_listxattr(struct dentry *dentry, char *list, size_t size)
|
|
|
|
{
|
|
|
|
int rc = 0;
|
|
|
|
struct dentry *lower_dentry;
|
|
|
|
|
|
|
|
lower_dentry = ecryptfs_dentry_to_lower(dentry);
|
2015-03-18 01:25:59 +03:00
|
|
|
if (!d_inode(lower_dentry)->i_op->listxattr) {
|
2010-03-23 19:51:38 +03:00
|
|
|
rc = -EOPNOTSUPP;
|
2006-10-04 13:16:22 +04:00
|
|
|
goto out;
|
|
|
|
}
|
2016-01-22 23:40:57 +03:00
|
|
|
inode_lock(d_inode(lower_dentry));
|
2015-03-18 01:25:59 +03:00
|
|
|
rc = d_inode(lower_dentry)->i_op->listxattr(lower_dentry, list, size);
|
2016-01-22 23:40:57 +03:00
|
|
|
inode_unlock(d_inode(lower_dentry));
|
2006-10-04 13:16:22 +04:00
|
|
|
out:
|
|
|
|
return rc;
|
|
|
|
}
|
|
|
|
|
2016-09-29 18:48:36 +03:00
|
|
|
static int ecryptfs_removexattr(struct dentry *dentry, struct inode *inode,
|
|
|
|
const char *name)
|
2006-10-04 13:16:22 +04:00
|
|
|
{
|
2016-09-29 18:48:42 +03:00
|
|
|
int rc;
|
2006-10-04 13:16:22 +04:00
|
|
|
struct dentry *lower_dentry;
|
2016-09-29 18:48:36 +03:00
|
|
|
struct inode *lower_inode;
|
2006-10-04 13:16:22 +04:00
|
|
|
|
|
|
|
lower_dentry = ecryptfs_dentry_to_lower(dentry);
|
2016-09-29 18:48:36 +03:00
|
|
|
lower_inode = ecryptfs_inode_to_lower(inode);
|
2016-09-29 18:48:42 +03:00
|
|
|
if (!(lower_inode->i_opflags & IOP_XATTR)) {
|
2010-03-23 19:51:38 +03:00
|
|
|
rc = -EOPNOTSUPP;
|
2006-10-04 13:16:22 +04:00
|
|
|
goto out;
|
|
|
|
}
|
2016-09-29 18:48:36 +03:00
|
|
|
inode_lock(lower_inode);
|
2021-01-21 16:19:28 +03:00
|
|
|
rc = __vfs_removexattr(&init_user_ns, lower_dentry, name);
|
2016-09-29 18:48:36 +03:00
|
|
|
inode_unlock(lower_inode);
|
2006-10-04 13:16:22 +04:00
|
|
|
out:
|
|
|
|
return rc;
|
|
|
|
}
|
|
|
|
|
2021-04-07 15:36:42 +03:00
|
|
|
static int ecryptfs_fileattr_get(struct dentry *dentry, struct fileattr *fa)
|
|
|
|
{
|
|
|
|
return vfs_fileattr_get(ecryptfs_dentry_to_lower(dentry), fa);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int ecryptfs_fileattr_set(struct user_namespace *mnt_userns,
|
|
|
|
struct dentry *dentry, struct fileattr *fa)
|
|
|
|
{
|
|
|
|
struct dentry *lower_dentry = ecryptfs_dentry_to_lower(dentry);
|
|
|
|
int rc;
|
|
|
|
|
|
|
|
rc = vfs_fileattr_set(&init_user_ns, lower_dentry, fa);
|
|
|
|
fsstack_copy_attr_all(d_inode(dentry), d_inode(lower_dentry));
|
|
|
|
|
|
|
|
return rc;
|
|
|
|
}
|
|
|
|
|
2022-09-22 18:17:17 +03:00
|
|
|
static struct posix_acl *ecryptfs_get_acl(struct user_namespace *mnt_userns,
|
|
|
|
struct dentry *dentry, int type)
|
|
|
|
{
|
|
|
|
return vfs_get_acl(mnt_userns, ecryptfs_dentry_to_lower(dentry),
|
|
|
|
posix_acl_xattr_name(type));
|
|
|
|
}
|
|
|
|
|
2022-09-22 18:17:18 +03:00
|
|
|
static int ecryptfs_set_acl(struct user_namespace *mnt_userns,
|
|
|
|
struct dentry *dentry, struct posix_acl *acl,
|
|
|
|
int type)
|
|
|
|
{
|
|
|
|
int rc;
|
|
|
|
struct dentry *lower_dentry = ecryptfs_dentry_to_lower(dentry);
|
|
|
|
struct inode *lower_inode = d_inode(lower_dentry);
|
|
|
|
|
|
|
|
rc = vfs_set_acl(&init_user_ns, lower_dentry,
|
|
|
|
posix_acl_xattr_name(type), acl);
|
|
|
|
if (!rc)
|
|
|
|
fsstack_copy_attr_all(d_inode(dentry), lower_inode);
|
|
|
|
return rc;
|
|
|
|
}
|
|
|
|
|
2007-02-12 11:55:38 +03:00
|
|
|
const struct inode_operations ecryptfs_symlink_iops = {
|
2015-11-17 18:20:54 +03:00
|
|
|
.get_link = ecryptfs_get_link,
|
2006-10-04 13:16:22 +04:00
|
|
|
.permission = ecryptfs_permission,
|
|
|
|
.setattr = ecryptfs_setattr,
|
2010-03-22 08:41:35 +03:00
|
|
|
.getattr = ecryptfs_getattr_link,
|
2006-10-04 13:16:22 +04:00
|
|
|
.listxattr = ecryptfs_listxattr,
|
|
|
|
};
|
|
|
|
|
2007-02-12 11:55:38 +03:00
|
|
|
const struct inode_operations ecryptfs_dir_iops = {
|
2006-10-04 13:16:22 +04:00
|
|
|
.create = ecryptfs_create,
|
|
|
|
.lookup = ecryptfs_lookup,
|
|
|
|
.link = ecryptfs_link,
|
|
|
|
.unlink = ecryptfs_unlink,
|
|
|
|
.symlink = ecryptfs_symlink,
|
|
|
|
.mkdir = ecryptfs_mkdir,
|
|
|
|
.rmdir = ecryptfs_rmdir,
|
|
|
|
.mknod = ecryptfs_mknod,
|
|
|
|
.rename = ecryptfs_rename,
|
|
|
|
.permission = ecryptfs_permission,
|
|
|
|
.setattr = ecryptfs_setattr,
|
|
|
|
.listxattr = ecryptfs_listxattr,
|
2021-04-07 15:36:42 +03:00
|
|
|
.fileattr_get = ecryptfs_fileattr_get,
|
|
|
|
.fileattr_set = ecryptfs_fileattr_set,
|
2022-09-22 18:17:17 +03:00
|
|
|
.get_acl = ecryptfs_get_acl,
|
2022-09-22 18:17:18 +03:00
|
|
|
.set_acl = ecryptfs_set_acl,
|
2006-10-04 13:16:22 +04:00
|
|
|
};
|
|
|
|
|
2007-02-12 11:55:38 +03:00
|
|
|
const struct inode_operations ecryptfs_main_iops = {
|
2006-10-04 13:16:22 +04:00
|
|
|
.permission = ecryptfs_permission,
|
|
|
|
.setattr = ecryptfs_setattr,
|
2009-11-04 11:48:01 +03:00
|
|
|
.getattr = ecryptfs_getattr,
|
2006-10-04 13:16:22 +04:00
|
|
|
.listxattr = ecryptfs_listxattr,
|
2021-04-07 15:36:42 +03:00
|
|
|
.fileattr_get = ecryptfs_fileattr_get,
|
|
|
|
.fileattr_set = ecryptfs_fileattr_set,
|
2022-09-22 18:17:17 +03:00
|
|
|
.get_acl = ecryptfs_get_acl,
|
2022-09-22 18:17:18 +03:00
|
|
|
.set_acl = ecryptfs_set_acl,
|
2016-09-29 18:48:36 +03:00
|
|
|
};
|
|
|
|
|
|
|
|
static int ecryptfs_xattr_get(const struct xattr_handler *handler,
|
|
|
|
struct dentry *dentry, struct inode *inode,
|
|
|
|
const char *name, void *buffer, size_t size)
|
|
|
|
{
|
|
|
|
return ecryptfs_getxattr(dentry, inode, name, buffer, size);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int ecryptfs_xattr_set(const struct xattr_handler *handler,
|
2021-01-21 16:19:27 +03:00
|
|
|
struct user_namespace *mnt_userns,
|
2016-09-29 18:48:36 +03:00
|
|
|
struct dentry *dentry, struct inode *inode,
|
|
|
|
const char *name, const void *value, size_t size,
|
|
|
|
int flags)
|
|
|
|
{
|
|
|
|
if (value)
|
|
|
|
return ecryptfs_setxattr(dentry, inode, name, value, size, flags);
|
|
|
|
else {
|
|
|
|
BUG_ON(flags != XATTR_REPLACE);
|
|
|
|
return ecryptfs_removexattr(dentry, inode, name);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-06-14 18:51:17 +03:00
|
|
|
static const struct xattr_handler ecryptfs_xattr_handler = {
|
2016-09-29 18:48:36 +03:00
|
|
|
.prefix = "", /* match anything */
|
|
|
|
.get = ecryptfs_xattr_get,
|
|
|
|
.set = ecryptfs_xattr_set,
|
|
|
|
};
|
|
|
|
|
|
|
|
const struct xattr_handler *ecryptfs_xattr_handlers[] = {
|
2022-09-22 18:17:23 +03:00
|
|
|
#ifdef CONFIG_FS_POSIX_ACL
|
|
|
|
&posix_acl_access_xattr_handler,
|
|
|
|
&posix_acl_default_xattr_handler,
|
|
|
|
#endif
|
2016-09-29 18:48:36 +03:00
|
|
|
&ecryptfs_xattr_handler,
|
|
|
|
NULL
|
2006-10-04 13:16:22 +04:00
|
|
|
};
|