2005-11-14 03:07:55 +03:00
|
|
|
/*
|
|
|
|
v4l2 common internal API header
|
|
|
|
|
|
|
|
This header contains internal shared ioctl definitions for use by the
|
|
|
|
internal low-level v4l2 drivers.
|
|
|
|
Each ioctl begins with VIDIOC_INT_ to clearly mark that it is an internal
|
|
|
|
define,
|
|
|
|
|
|
|
|
Copyright (C) 2005 Hans Verkuil <hverkuil@xs4all.nl>
|
|
|
|
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
|
|
it under the terms of the GNU General Public License as published by
|
|
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
|
|
(at your option) any later version.
|
|
|
|
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
GNU General Public License for more details.
|
|
|
|
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
|
|
along with this program; if not, write to the Free Software
|
|
|
|
Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
|
|
|
|
*/
|
|
|
|
|
|
|
|
#ifndef V4L2_COMMON_H_
|
|
|
|
#define V4L2_COMMON_H_
|
|
|
|
|
2006-06-04 17:06:18 +04:00
|
|
|
#include <media/v4l2-dev.h>
|
|
|
|
|
2017-09-22 16:03:54 +03:00
|
|
|
/* Common printk constructs for v4l-i2c drivers. These macros create a unique
|
2006-01-09 20:32:40 +03:00
|
|
|
prefix consisting of the driver name, the adapter number and the i2c
|
|
|
|
address. */
|
|
|
|
#define v4l_printk(level, name, adapter, addr, fmt, arg...) \
|
|
|
|
printk(level "%s %d-%04x: " fmt, name, i2c_adapter_id(adapter), addr , ## arg)
|
|
|
|
|
2006-01-09 20:53:26 +03:00
|
|
|
#define v4l_client_printk(level, client, fmt, arg...) \
|
2013-09-29 12:51:01 +04:00
|
|
|
v4l_printk(level, (client)->dev.driver->name, (client)->adapter, \
|
2006-01-09 20:32:40 +03:00
|
|
|
(client)->addr, fmt , ## arg)
|
|
|
|
|
|
|
|
#define v4l_err(client, fmt, arg...) \
|
|
|
|
v4l_client_printk(KERN_ERR, client, fmt , ## arg)
|
|
|
|
|
|
|
|
#define v4l_warn(client, fmt, arg...) \
|
|
|
|
v4l_client_printk(KERN_WARNING, client, fmt , ## arg)
|
|
|
|
|
|
|
|
#define v4l_info(client, fmt, arg...) \
|
|
|
|
v4l_client_printk(KERN_INFO, client, fmt , ## arg)
|
|
|
|
|
|
|
|
/* These three macros assume that the debug level is set with a module
|
|
|
|
parameter called 'debug'. */
|
2006-01-12 00:41:49 +03:00
|
|
|
#define v4l_dbg(level, debug, client, fmt, arg...) \
|
2018-01-04 21:08:56 +03:00
|
|
|
do { \
|
2006-01-09 20:32:40 +03:00
|
|
|
if (debug >= (level)) \
|
|
|
|
v4l_client_printk(KERN_DEBUG, client, fmt , ## arg); \
|
|
|
|
} while (0)
|
|
|
|
|
[media] v4l2-common: add a debug macro to be used with dev_foo()
Currently, there's a mess at the V4L2 printk macros: some drivers
use their own macros, others use pr_foo() or v4l_foo() macros,
while more modern drivers use dev_foo() macros.
The best is to get rid of v4l_foo() macros, as they can be
replaced by either dev_foo() or pr_foo(). Yet, such change can
be disruptive, as dev_foo() cannot use KERN_CONT. So, the best
is to do such change driver by driver.
There are replacements for most v4l_foo() macros, but it lacks
a way to enable debug messages per level. So, add such macro,
in order to make the conversion easier.
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-16 13:35:08 +03:00
|
|
|
/* Add a version of v4l_dbg to be used on drivers using dev_foo() macros */
|
|
|
|
#define dev_dbg_lvl(__dev, __level, __debug, __fmt, __arg...) \
|
|
|
|
do { \
|
|
|
|
if (__debug >= (__level)) \
|
|
|
|
dev_printk(KERN_DEBUG, __dev, __fmt, ##__arg); \
|
|
|
|
} while (0)
|
|
|
|
|
2006-01-09 20:32:40 +03:00
|
|
|
/* ------------------------------------------------------------------------- */
|
|
|
|
|
2008-11-23 18:19:45 +03:00
|
|
|
/* These printk constructs can be used with v4l2_device and v4l2_subdev */
|
|
|
|
#define v4l2_printk(level, dev, fmt, arg...) \
|
|
|
|
printk(level "%s: " fmt, (dev)->name , ## arg)
|
|
|
|
|
|
|
|
#define v4l2_err(dev, fmt, arg...) \
|
|
|
|
v4l2_printk(KERN_ERR, dev, fmt , ## arg)
|
|
|
|
|
|
|
|
#define v4l2_warn(dev, fmt, arg...) \
|
|
|
|
v4l2_printk(KERN_WARNING, dev, fmt , ## arg)
|
|
|
|
|
|
|
|
#define v4l2_info(dev, fmt, arg...) \
|
|
|
|
v4l2_printk(KERN_INFO, dev, fmt , ## arg)
|
|
|
|
|
|
|
|
/* These three macros assume that the debug level is set with a module
|
|
|
|
parameter called 'debug'. */
|
|
|
|
#define v4l2_dbg(level, debug, dev, fmt, arg...) \
|
2018-01-04 21:08:56 +03:00
|
|
|
do { \
|
2008-11-23 18:19:45 +03:00
|
|
|
if (debug >= (level)) \
|
2018-01-04 21:08:56 +03:00
|
|
|
v4l2_printk(KERN_DEBUG, dev, fmt , ## arg); \
|
2008-11-23 18:19:45 +03:00
|
|
|
} while (0)
|
|
|
|
|
2016-07-21 18:26:04 +03:00
|
|
|
/**
|
|
|
|
* v4l2_ctrl_query_fill- Fill in a struct v4l2_queryctrl
|
|
|
|
*
|
|
|
|
* @qctrl: pointer to the &struct v4l2_queryctrl to be filled
|
|
|
|
* @min: minimum value for the control
|
|
|
|
* @max: maximum value for the control
|
|
|
|
* @step: control step
|
|
|
|
* @def: default value for the control
|
|
|
|
*
|
|
|
|
* Fills the &struct v4l2_queryctrl fields for the query control.
|
|
|
|
*
|
|
|
|
* .. note::
|
|
|
|
*
|
|
|
|
* This function assumes that the @qctrl->id field is filled.
|
|
|
|
*
|
|
|
|
* Returns -EINVAL if the control is not known by the V4L2 core, 0 on success.
|
|
|
|
*/
|
2008-11-23 18:19:45 +03:00
|
|
|
|
2016-07-21 18:26:04 +03:00
|
|
|
int v4l2_ctrl_query_fill(struct v4l2_queryctrl *qctrl,
|
|
|
|
s32 min, s32 max, s32 step, s32 def);
|
2006-06-18 21:11:08 +04:00
|
|
|
|
|
|
|
/* ------------------------------------------------------------------------- */
|
|
|
|
|
2009-04-01 10:41:09 +04:00
|
|
|
/* I2C Helper functions */
|
2007-09-12 15:32:50 +04:00
|
|
|
|
|
|
|
struct i2c_driver;
|
|
|
|
struct i2c_adapter;
|
|
|
|
struct i2c_client;
|
2008-04-30 01:11:39 +04:00
|
|
|
struct i2c_device_id;
|
2008-11-23 18:19:45 +03:00
|
|
|
struct v4l2_device;
|
|
|
|
struct v4l2_subdev;
|
|
|
|
struct v4l2_subdev_ops;
|
2007-09-12 15:32:50 +04:00
|
|
|
|
2016-07-21 16:08:31 +03:00
|
|
|
/**
|
|
|
|
* v4l2_i2c_new_subdev - Load an i2c module and return an initialized
|
|
|
|
* &struct v4l2_subdev.
|
|
|
|
*
|
|
|
|
* @v4l2_dev: pointer to &struct v4l2_device
|
|
|
|
* @adapter: pointer to struct i2c_adapter
|
|
|
|
* @client_type: name of the chip that's on the adapter.
|
|
|
|
* @addr: I2C address. If zero, it will use @probe_addrs
|
|
|
|
* @probe_addrs: array with a list of address. The last entry at such
|
2018-01-04 14:47:28 +03:00
|
|
|
* array should be %I2C_CLIENT_END.
|
2016-07-21 16:08:31 +03:00
|
|
|
*
|
|
|
|
* returns a &struct v4l2_subdev pointer.
|
|
|
|
*/
|
2011-01-08 13:08:02 +03:00
|
|
|
struct v4l2_subdev *v4l2_i2c_new_subdev(struct v4l2_device *v4l2_dev,
|
2010-09-24 17:16:44 +04:00
|
|
|
struct i2c_adapter *adapter, const char *client_type,
|
2009-08-10 09:49:08 +04:00
|
|
|
u8 addr, const unsigned short *probe_addrs);
|
2009-06-10 00:12:33 +04:00
|
|
|
|
|
|
|
struct i2c_board_info;
|
|
|
|
|
2016-07-21 16:08:31 +03:00
|
|
|
/**
|
|
|
|
* v4l2_i2c_new_subdev_board - Load an i2c module and return an initialized
|
|
|
|
* &struct v4l2_subdev.
|
|
|
|
*
|
|
|
|
* @v4l2_dev: pointer to &struct v4l2_device
|
|
|
|
* @adapter: pointer to struct i2c_adapter
|
|
|
|
* @info: pointer to struct i2c_board_info used to replace the irq,
|
|
|
|
* platform_data and addr arguments.
|
|
|
|
* @probe_addrs: array with a list of address. The last entry at such
|
2018-01-04 14:47:28 +03:00
|
|
|
* array should be %I2C_CLIENT_END.
|
2016-07-21 16:08:31 +03:00
|
|
|
*
|
|
|
|
* returns a &struct v4l2_subdev pointer.
|
|
|
|
*/
|
2009-06-10 00:12:33 +04:00
|
|
|
struct v4l2_subdev *v4l2_i2c_new_subdev_board(struct v4l2_device *v4l2_dev,
|
2010-09-24 17:16:44 +04:00
|
|
|
struct i2c_adapter *adapter, struct i2c_board_info *info,
|
|
|
|
const unsigned short *probe_addrs);
|
2009-06-10 00:12:33 +04:00
|
|
|
|
2016-07-21 16:08:31 +03:00
|
|
|
/**
|
|
|
|
* v4l2_i2c_subdev_init - Initializes a &struct v4l2_subdev with data from
|
|
|
|
* an i2c_client struct.
|
|
|
|
*
|
|
|
|
* @sd: pointer to &struct v4l2_subdev
|
|
|
|
* @client: pointer to struct i2c_client
|
|
|
|
* @ops: pointer to &struct v4l2_subdev_ops
|
|
|
|
*/
|
2008-11-23 18:19:45 +03:00
|
|
|
void v4l2_i2c_subdev_init(struct v4l2_subdev *sd, struct i2c_client *client,
|
|
|
|
const struct v4l2_subdev_ops *ops);
|
2016-07-21 16:08:31 +03:00
|
|
|
|
|
|
|
/**
|
|
|
|
* v4l2_i2c_subdev_addr - returns i2c client address of &struct v4l2_subdev.
|
|
|
|
*
|
|
|
|
* @sd: pointer to &struct v4l2_subdev
|
|
|
|
*
|
|
|
|
* Returns the address of an I2C sub-device
|
|
|
|
*/
|
2009-02-22 00:08:41 +03:00
|
|
|
unsigned short v4l2_i2c_subdev_addr(struct v4l2_subdev *sd);
|
2008-11-23 18:19:45 +03:00
|
|
|
|
2017-09-22 16:03:54 +03:00
|
|
|
/**
|
|
|
|
* enum v4l2_i2c_tuner_type - specifies the range of tuner address that
|
|
|
|
* should be used when seeking for I2C devices.
|
|
|
|
*
|
|
|
|
* @ADDRS_RADIO: Radio tuner addresses.
|
|
|
|
* Represent the following I2C addresses:
|
|
|
|
* 0x10 (if compiled with tea5761 support)
|
|
|
|
* and 0x60.
|
|
|
|
* @ADDRS_DEMOD: Demod tuner addresses.
|
|
|
|
* Represent the following I2C addresses:
|
|
|
|
* 0x42, 0x43, 0x4a and 0x4b.
|
|
|
|
* @ADDRS_TV: TV tuner addresses.
|
|
|
|
* Represent the following I2C addresses:
|
|
|
|
* 0x42, 0x43, 0x4a, 0x4b, 0x60, 0x61, 0x62,
|
|
|
|
* 0x63 and 0x64.
|
|
|
|
* @ADDRS_TV_WITH_DEMOD: TV tuner addresses if demod is present, this
|
|
|
|
* excludes addresses used by the demodulator
|
|
|
|
* from the list of candidates.
|
|
|
|
* Represent the following I2C addresses:
|
|
|
|
* 0x60, 0x61, 0x62, 0x63 and 0x64.
|
|
|
|
*
|
|
|
|
* NOTE: All I2C addresses above use the 7-bit notation.
|
|
|
|
*/
|
2009-01-19 01:37:59 +03:00
|
|
|
enum v4l2_i2c_tuner_type {
|
2017-09-22 16:03:54 +03:00
|
|
|
ADDRS_RADIO,
|
|
|
|
ADDRS_DEMOD,
|
|
|
|
ADDRS_TV,
|
2009-01-19 01:37:59 +03:00
|
|
|
ADDRS_TV_WITH_DEMOD,
|
|
|
|
};
|
2017-09-22 16:03:54 +03:00
|
|
|
/**
|
|
|
|
* v4l2_i2c_tuner_addrs - Return a list of I2C tuner addresses to probe.
|
|
|
|
*
|
|
|
|
* @type: type of the tuner to seek, as defined by
|
|
|
|
* &enum v4l2_i2c_tuner_type.
|
|
|
|
*
|
|
|
|
* NOTE: Use only if the tuner addresses are unknown.
|
|
|
|
*/
|
2009-01-19 01:37:59 +03:00
|
|
|
const unsigned short *v4l2_i2c_tuner_addrs(enum v4l2_i2c_tuner_type type);
|
|
|
|
|
2007-09-12 15:32:50 +04:00
|
|
|
/* ------------------------------------------------------------------------- */
|
2010-03-23 17:23:29 +03:00
|
|
|
|
|
|
|
/* SPI Helper functions */
|
|
|
|
#if defined(CONFIG_SPI)
|
|
|
|
|
|
|
|
#include <linux/spi/spi.h>
|
|
|
|
|
|
|
|
struct spi_device;
|
|
|
|
|
2016-07-21 18:26:04 +03:00
|
|
|
/**
|
|
|
|
* v4l2_spi_new_subdev - Load an spi module and return an initialized
|
|
|
|
* &struct v4l2_subdev.
|
|
|
|
*
|
|
|
|
*
|
|
|
|
* @v4l2_dev: pointer to &struct v4l2_device.
|
|
|
|
* @master: pointer to struct spi_master.
|
|
|
|
* @info: pointer to struct spi_board_info.
|
|
|
|
*
|
|
|
|
* returns a &struct v4l2_subdev pointer.
|
|
|
|
*/
|
2010-03-23 17:23:29 +03:00
|
|
|
struct v4l2_subdev *v4l2_spi_new_subdev(struct v4l2_device *v4l2_dev,
|
|
|
|
struct spi_master *master, struct spi_board_info *info);
|
|
|
|
|
2016-07-21 18:26:04 +03:00
|
|
|
/**
|
|
|
|
* v4l2_spi_subdev_init - Initialize a v4l2_subdev with data from an
|
|
|
|
* spi_device struct.
|
|
|
|
*
|
|
|
|
* @sd: pointer to &struct v4l2_subdev
|
|
|
|
* @spi: pointer to struct spi_device.
|
|
|
|
* @ops: pointer to &struct v4l2_subdev_ops
|
|
|
|
*/
|
2010-03-23 17:23:29 +03:00
|
|
|
void v4l2_spi_subdev_init(struct v4l2_subdev *sd, struct spi_device *spi,
|
|
|
|
const struct v4l2_subdev_ops *ops);
|
|
|
|
#endif
|
|
|
|
|
|
|
|
/* ------------------------------------------------------------------------- */
|
2007-09-12 15:32:50 +04:00
|
|
|
|
2017-09-21 17:04:30 +03:00
|
|
|
/*
|
|
|
|
* FIXME: these remaining ioctls/structs should be removed as well, but they
|
|
|
|
* are still used in tuner-simple.c (TUNER_SET_CONFIG) and cx18/ivtv (RESET).
|
|
|
|
* To remove these ioctls some more cleanup is needed in those modules.
|
2017-09-22 16:03:54 +03:00
|
|
|
*
|
|
|
|
* It doesn't make much sense on documenting them, as what we really want is
|
|
|
|
* to get rid of them.
|
2017-09-21 17:04:30 +03:00
|
|
|
*/
|
2005-11-14 03:07:55 +03:00
|
|
|
|
2009-04-01 10:41:09 +04:00
|
|
|
/* s_config */
|
2007-10-19 02:56:47 +04:00
|
|
|
struct v4l2_priv_tun_config {
|
|
|
|
int tuner;
|
|
|
|
void *priv;
|
|
|
|
};
|
|
|
|
#define TUNER_SET_CONFIG _IOW('d', 92, struct v4l2_priv_tun_config)
|
2006-01-23 22:11:10 +03:00
|
|
|
|
2018-01-04 21:08:56 +03:00
|
|
|
#define VIDIOC_INT_RESET _IOW ('d', 102, u32)
|
2009-04-02 18:37:41 +04:00
|
|
|
|
2009-05-31 04:45:46 +04:00
|
|
|
/* ------------------------------------------------------------------------- */
|
|
|
|
|
|
|
|
/* Miscellaneous helper functions */
|
|
|
|
|
2017-09-22 16:03:54 +03:00
|
|
|
/**
|
|
|
|
* v4l_bound_align_image - adjust video dimensions according to
|
|
|
|
* a given constraints.
|
|
|
|
*
|
|
|
|
* @width: pointer to width that will be adjusted if needed.
|
|
|
|
* @wmin: minimum width.
|
|
|
|
* @wmax: maximum width.
|
|
|
|
* @walign: least significant bit on width.
|
|
|
|
* @height: pointer to height that will be adjusted if needed.
|
|
|
|
* @hmin: minimum height.
|
|
|
|
* @hmax: maximum height.
|
|
|
|
* @halign: least significant bit on width.
|
|
|
|
* @salign: least significant bit for the image size (e. g.
|
|
|
|
* :math:`width * height`).
|
|
|
|
*
|
|
|
|
* Clip an image to have @width between @wmin and @wmax, and @height between
|
|
|
|
* @hmin and @hmax, inclusive.
|
|
|
|
*
|
|
|
|
* Additionally, the @width will be a multiple of :math:`2^{walign}`,
|
|
|
|
* the @height will be a multiple of :math:`2^{halign}`, and the overall
|
|
|
|
* size :math:`width * height` will be a multiple of :math:`2^{salign}`.
|
|
|
|
*
|
|
|
|
* .. note::
|
|
|
|
*
|
|
|
|
* #. The clipping rectangle may be shrunk or enlarged to fit the alignment
|
|
|
|
* constraints.
|
|
|
|
* #. @wmax must not be smaller than @wmin.
|
|
|
|
* #. @hmax must not be smaller than @hmin.
|
|
|
|
* #. The alignments must not be so high there are no possible image
|
|
|
|
* sizes within the allowed bounds.
|
|
|
|
* #. @wmin and @hmin must be at least 1 (don't use 0).
|
|
|
|
* #. For @walign, @halign and @salign, if you don't care about a certain
|
|
|
|
* alignment, specify ``0``, as :math:`2^0 = 1` and one byte alignment
|
|
|
|
* is equivalent to no alignment.
|
|
|
|
* #. If you only want to adjust downward, specify a maximum that's the
|
|
|
|
* same as the initial value.
|
|
|
|
*/
|
|
|
|
void v4l_bound_align_image(unsigned int *width, unsigned int wmin,
|
2009-05-31 04:45:46 +04:00
|
|
|
unsigned int wmax, unsigned int walign,
|
2017-09-22 16:03:54 +03:00
|
|
|
unsigned int *height, unsigned int hmin,
|
2009-05-31 04:45:46 +04:00
|
|
|
unsigned int hmax, unsigned int halign,
|
|
|
|
unsigned int salign);
|
2010-09-30 16:29:37 +04:00
|
|
|
|
2018-02-23 12:50:14 +03:00
|
|
|
/**
|
|
|
|
* v4l2_find_nearest_size - Find the nearest size among a discrete
|
|
|
|
* set of resolutions contained in an array of a driver specific struct.
|
|
|
|
*
|
|
|
|
* @array: a driver specific array of image sizes
|
|
|
|
* @width_field: the name of the width field in the driver specific struct
|
|
|
|
* @height_field: the name of the height field in the driver specific struct
|
|
|
|
* @width: desired width.
|
|
|
|
* @height: desired height.
|
|
|
|
*
|
|
|
|
* Finds the closest resolution to minimize the width and height differences
|
|
|
|
* between what requested and the supported resolutions. The size of the width
|
|
|
|
* and height fields in the driver specific must equal to that of u32, i.e. four
|
|
|
|
* bytes.
|
|
|
|
*
|
|
|
|
* Returns the best match or NULL if the length of the array is zero.
|
|
|
|
*/
|
media: v4l2-common: fix a compilation breakage
Clearly, changeset 95ce9c28601a ("media: v4l: common: Add a
function to obtain best size from a list") was never tested, as it
broke compilation with:
drivers/media/platform/vivid/vivid-vid-cap.c: In function ‘vivid_try_fmt_vid_cap’:
drivers/media/platform/vivid/vivid-vid-cap.c:565:34: error: macro "v4l2_find_nearest_size" requer 6 argumentos, mas apenas 5 foram fornecidos
mp->width, mp->height);
^
drivers/media/platform/vivid/vivid-vid-cap.c:564:4: error: ‘v4l2_find_nearest_size’ undeclared (first use in this function); did you mean ‘__v4l2_find_nearest_size’?
v4l2_find_nearest_size(webcam_sizes, width, height,
^~~~~~~~~~~~~~~~~~~~~~
__v4l2_find_nearest_size
drivers/media/platform/vivid/vivid-vid-cap.c:564:4: note: each undeclared identifier is reported only once for each function it appears in
drivers/media/i2c/ov5670.c: In function ‘ov5670_set_pad_format’:
drivers/media/i2c/ov5670.c:2233:48: error: macro "v4l2_find_nearest_size" requer 6 argumentos, mas apenas 5 foram fornecidos
fmt->format.width, fmt->format.height);
^
drivers/media/i2c/ov5670.c:2232:9: error: ‘v4l2_find_nearest_size’ undeclared (first use in this function); did you mean ‘__v4l2_find_nearest_size’?
mode = v4l2_find_nearest_size(supported_modes, width, height,
^~~~~~~~~~~~~~~~~~~~~~
__v4l2_find_nearest_size
drivers/media/i2c/ov13858.c: In function ‘ov13858_set_pad_format’:
drivers/media/i2c/ov13858.c:1379:48: error: macro "v4l2_find_nearest_size" requer 6 argumentos, mas apenas 5 foram fornecidos
fmt->format.width, fmt->format.height);
^
drivers/media/i2c/ov13858.c:1378:9: error: ‘v4l2_find_nearest_size’ undeclared (first use in this function); did you mean ‘__v4l2_find_nearest_size’?
mode = v4l2_find_nearest_size(supported_modes, width, height,
^~~~~~~~~~~~~~~~~~~~~~
__v4l2_find_nearest_size
drivers/media/i2c/ov13858.c:1378:9: note: each undeclared identifier is reported only once for each function it appears in
Basically, v4l2_find_nearest_size() callers pass 5 arguments,
while its definition require 6 args.
Unfortunately, my build process was also broken, as it was reporting me that
the compilation went fine:
$ make ARCH=i386 CF=-D__CHECK_ENDIAN__ CONFIG_DEBUG_SECTION_MISMATCH=y C=1 W=1 CHECK='compile_checks' M=drivers/staging/media
$ make ARCH=i386 CF=-D__CHECK_ENDIAN__ CONFIG_DEBUG_SECTION_MISMATCH=y C=1 W=1 CHECK='compile_checks' M=drivers/media
*** ERRORS ***
*** WARNINGS ***
compilation succeeded
That was due to a change here to use of linux-log-diff script that
provides a diffstat between the errors output. Somehow, the logic
was missing some fatal errors.
Fixes: 95ce9c28601a ("media: v4l: common: Add a function to obtain best size from a list")
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2018-03-21 22:48:11 +03:00
|
|
|
#define v4l2_find_nearest_size(array, width_field, height_field, \
|
2018-02-23 12:50:14 +03:00
|
|
|
width, height) \
|
|
|
|
({ \
|
|
|
|
BUILD_BUG_ON(sizeof((array)->width_field) != sizeof(u32) || \
|
|
|
|
sizeof((array)->height_field) != sizeof(u32)); \
|
|
|
|
(typeof(&(*(array))))__v4l2_find_nearest_size( \
|
media: v4l2-common: fix a compilation breakage
Clearly, changeset 95ce9c28601a ("media: v4l: common: Add a
function to obtain best size from a list") was never tested, as it
broke compilation with:
drivers/media/platform/vivid/vivid-vid-cap.c: In function ‘vivid_try_fmt_vid_cap’:
drivers/media/platform/vivid/vivid-vid-cap.c:565:34: error: macro "v4l2_find_nearest_size" requer 6 argumentos, mas apenas 5 foram fornecidos
mp->width, mp->height);
^
drivers/media/platform/vivid/vivid-vid-cap.c:564:4: error: ‘v4l2_find_nearest_size’ undeclared (first use in this function); did you mean ‘__v4l2_find_nearest_size’?
v4l2_find_nearest_size(webcam_sizes, width, height,
^~~~~~~~~~~~~~~~~~~~~~
__v4l2_find_nearest_size
drivers/media/platform/vivid/vivid-vid-cap.c:564:4: note: each undeclared identifier is reported only once for each function it appears in
drivers/media/i2c/ov5670.c: In function ‘ov5670_set_pad_format’:
drivers/media/i2c/ov5670.c:2233:48: error: macro "v4l2_find_nearest_size" requer 6 argumentos, mas apenas 5 foram fornecidos
fmt->format.width, fmt->format.height);
^
drivers/media/i2c/ov5670.c:2232:9: error: ‘v4l2_find_nearest_size’ undeclared (first use in this function); did you mean ‘__v4l2_find_nearest_size’?
mode = v4l2_find_nearest_size(supported_modes, width, height,
^~~~~~~~~~~~~~~~~~~~~~
__v4l2_find_nearest_size
drivers/media/i2c/ov13858.c: In function ‘ov13858_set_pad_format’:
drivers/media/i2c/ov13858.c:1379:48: error: macro "v4l2_find_nearest_size" requer 6 argumentos, mas apenas 5 foram fornecidos
fmt->format.width, fmt->format.height);
^
drivers/media/i2c/ov13858.c:1378:9: error: ‘v4l2_find_nearest_size’ undeclared (first use in this function); did you mean ‘__v4l2_find_nearest_size’?
mode = v4l2_find_nearest_size(supported_modes, width, height,
^~~~~~~~~~~~~~~~~~~~~~
__v4l2_find_nearest_size
drivers/media/i2c/ov13858.c:1378:9: note: each undeclared identifier is reported only once for each function it appears in
Basically, v4l2_find_nearest_size() callers pass 5 arguments,
while its definition require 6 args.
Unfortunately, my build process was also broken, as it was reporting me that
the compilation went fine:
$ make ARCH=i386 CF=-D__CHECK_ENDIAN__ CONFIG_DEBUG_SECTION_MISMATCH=y C=1 W=1 CHECK='compile_checks' M=drivers/staging/media
$ make ARCH=i386 CF=-D__CHECK_ENDIAN__ CONFIG_DEBUG_SECTION_MISMATCH=y C=1 W=1 CHECK='compile_checks' M=drivers/media
*** ERRORS ***
*** WARNINGS ***
compilation succeeded
That was due to a change here to use of linux-log-diff script that
provides a diffstat between the errors output. Somehow, the logic
was missing some fatal errors.
Fixes: 95ce9c28601a ("media: v4l: common: Add a function to obtain best size from a list")
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2018-03-21 22:48:11 +03:00
|
|
|
(array), ARRAY_SIZE(array), sizeof(*(array)), \
|
2018-02-23 12:50:14 +03:00
|
|
|
offsetof(typeof(*(array)), width_field), \
|
|
|
|
offsetof(typeof(*(array)), height_field), \
|
|
|
|
width, height); \
|
|
|
|
})
|
|
|
|
const void *
|
|
|
|
__v4l2_find_nearest_size(const void *array, size_t array_size,
|
|
|
|
size_t entry_size, size_t width_offset,
|
|
|
|
size_t height_offset, s32 width, s32 height);
|
|
|
|
|
2017-09-22 16:03:54 +03:00
|
|
|
/**
|
|
|
|
* v4l2_get_timestamp - helper routine to get a timestamp to be used when
|
|
|
|
* filling streaming metadata. Internally, it uses ktime_get_ts(),
|
|
|
|
* which is the recommended way to get it.
|
|
|
|
*
|
|
|
|
* @tv: pointer to &struct timeval to be filled.
|
|
|
|
*/
|
2012-09-15 14:51:47 +04:00
|
|
|
void v4l2_get_timestamp(struct timeval *tv);
|
|
|
|
|
2018-01-22 11:58:36 +03:00
|
|
|
/**
|
|
|
|
* v4l2_g_parm_cap - helper routine for vidioc_g_parm to fill this in by
|
|
|
|
* calling the g_frame_interval op of the given subdev. It only works
|
|
|
|
* for V4L2_BUF_TYPE_VIDEO_CAPTURE(_MPLANE), hence the _cap in the
|
|
|
|
* function name.
|
|
|
|
*
|
|
|
|
* @vdev: the struct video_device pointer. Used to determine the device caps.
|
|
|
|
* @sd: the sub-device pointer.
|
|
|
|
* @a: the VIDIOC_G_PARM argument.
|
|
|
|
*/
|
|
|
|
int v4l2_g_parm_cap(struct video_device *vdev,
|
|
|
|
struct v4l2_subdev *sd, struct v4l2_streamparm *a);
|
|
|
|
|
|
|
|
/**
|
|
|
|
* v4l2_s_parm_cap - helper routine for vidioc_s_parm to fill this in by
|
|
|
|
* calling the s_frame_interval op of the given subdev. It only works
|
|
|
|
* for V4L2_BUF_TYPE_VIDEO_CAPTURE(_MPLANE), hence the _cap in the
|
|
|
|
* function name.
|
|
|
|
*
|
|
|
|
* @vdev: the struct video_device pointer. Used to determine the device caps.
|
|
|
|
* @sd: the sub-device pointer.
|
|
|
|
* @a: the VIDIOC_S_PARM argument.
|
|
|
|
*/
|
|
|
|
int v4l2_s_parm_cap(struct video_device *vdev,
|
|
|
|
struct v4l2_subdev *sd, struct v4l2_streamparm *a);
|
|
|
|
|
2005-11-14 03:07:55 +03:00
|
|
|
#endif /* V4L2_COMMON_H_ */
|