2005-07-28 05:36:22 +04:00
|
|
|
/*
|
|
|
|
* sata_sil24.c - Driver for Silicon Image 3124/3132 SATA-2 controllers
|
|
|
|
*
|
|
|
|
* Copyright 2005 Tejun Heo
|
|
|
|
*
|
|
|
|
* Based on preview driver from Silicon Image.
|
|
|
|
*
|
|
|
|
* This program is free software; you can redistribute it and/or modify it
|
|
|
|
* under the terms of the GNU General Public License as published by the
|
|
|
|
* Free Software Foundation; either version 2, or (at your option) any
|
|
|
|
* later version.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope that it will be useful, but
|
|
|
|
* WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
|
|
* General Public License for more details.
|
|
|
|
*
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <linux/kernel.h>
|
|
|
|
#include <linux/module.h>
|
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files. percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.
percpu.h -> slab.h dependency is about to be removed. Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability. As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.
http://userweb.kernel.org/~tj/misc/slabh-sweep.py
The script does the followings.
* Scan files for gfp and slab usages and update includes such that
only the necessary includes are there. ie. if only gfp is used,
gfp.h, if slab is used, slab.h.
* When the script inserts a new include, it looks at the include
blocks and try to put the new include such that its order conforms
to its surrounding. It's put in the include block which contains
core kernel includes, in the same order that the rest are ordered -
alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
doesn't seem to be any matching order.
* If the script can't find a place to put a new include (mostly
because the file doesn't have fitting include block), it prints out
an error message indicating which .h file needs to be added to the
file.
The conversion was done in the following steps.
1. The initial automatic conversion of all .c files updated slightly
over 4000 files, deleting around 700 includes and adding ~480 gfp.h
and ~3000 slab.h inclusions. The script emitted errors for ~400
files.
2. Each error was manually checked. Some didn't need the inclusion,
some needed manual addition while adding it to implementation .h or
embedding .c file was more appropriate for others. This step added
inclusions to around 150 files.
3. The script was run again and the output was compared to the edits
from #2 to make sure no file was left behind.
4. Several build tests were done and a couple of problems were fixed.
e.g. lib/decompress_*.c used malloc/free() wrappers around slab
APIs requiring slab.h to be added manually.
5. The script was run on all .h files but without automatically
editing them as sprinkling gfp.h and slab.h inclusions around .h
files could easily lead to inclusion dependency hell. Most gfp.h
inclusion directives were ignored as stuff from gfp.h was usually
wildly available and often used in preprocessor macros. Each
slab.h inclusion directive was examined and added manually as
necessary.
6. percpu.h was updated not to include slab.h.
7. Build test were done on the following configurations and failures
were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
distributed build env didn't work with gcov compiles) and a few
more options had to be turned off depending on archs to make things
build (like ipr on powerpc/64 which failed due to missing writeq).
* x86 and x86_64 UP and SMP allmodconfig and a custom test config.
* powerpc and powerpc64 SMP allmodconfig
* sparc and sparc64 SMP allmodconfig
* ia64 SMP allmodconfig
* s390 SMP allmodconfig
* alpha SMP allmodconfig
* um on x86_64 SMP allmodconfig
8. percpu.h modifications were reverted so that it could be applied as
a separate patch and serve as bisection point.
Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.
Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
2010-03-24 11:04:11 +03:00
|
|
|
#include <linux/gfp.h>
|
2005-07-28 05:36:22 +04:00
|
|
|
#include <linux/pci.h>
|
|
|
|
#include <linux/blkdev.h>
|
|
|
|
#include <linux/delay.h>
|
|
|
|
#include <linux/interrupt.h>
|
|
|
|
#include <linux/dma-mapping.h>
|
2005-10-30 22:39:11 +03:00
|
|
|
#include <linux/device.h>
|
2005-07-28 05:36:22 +04:00
|
|
|
#include <scsi/scsi_host.h>
|
2005-11-07 08:59:37 +03:00
|
|
|
#include <scsi/scsi_cmnd.h>
|
2005-07-28 05:36:22 +04:00
|
|
|
#include <linux/libata.h>
|
|
|
|
|
|
|
|
#define DRV_NAME "sata_sil24"
|
2007-09-23 08:19:54 +04:00
|
|
|
#define DRV_VERSION "1.1"
|
2005-07-28 05:36:22 +04:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Port request block (PRB) 32 bytes
|
|
|
|
*/
|
|
|
|
struct sil24_prb {
|
2006-06-06 07:31:14 +04:00
|
|
|
__le16 ctrl;
|
|
|
|
__le16 prot;
|
|
|
|
__le32 rx_cnt;
|
2005-07-28 05:36:22 +04:00
|
|
|
u8 fis[6 * 4];
|
|
|
|
};
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Scatter gather entry (SGE) 16 bytes
|
|
|
|
*/
|
|
|
|
struct sil24_sge {
|
2006-06-06 07:31:14 +04:00
|
|
|
__le64 addr;
|
|
|
|
__le32 cnt;
|
|
|
|
__le32 flags;
|
2005-07-28 05:36:22 +04:00
|
|
|
};
|
|
|
|
|
|
|
|
|
|
|
|
enum {
|
2007-02-01 09:06:36 +03:00
|
|
|
SIL24_HOST_BAR = 0,
|
|
|
|
SIL24_PORT_BAR = 2,
|
|
|
|
|
2007-11-22 12:46:57 +03:00
|
|
|
/* sil24 fetches in chunks of 64bytes. The first block
|
|
|
|
* contains the PRB and two SGEs. From the second block, it's
|
|
|
|
* consisted of four SGEs and called SGT. Calculate the
|
|
|
|
* number of SGTs that fit into one page.
|
|
|
|
*/
|
|
|
|
SIL24_PRB_SZ = sizeof(struct sil24_prb)
|
|
|
|
+ 2 * sizeof(struct sil24_sge),
|
|
|
|
SIL24_MAX_SGT = (PAGE_SIZE - SIL24_PRB_SZ)
|
|
|
|
/ (4 * sizeof(struct sil24_sge)),
|
|
|
|
|
|
|
|
/* This will give us one unused SGEs for ATA. This extra SGE
|
|
|
|
* will be used to store CDB for ATAPI devices.
|
|
|
|
*/
|
|
|
|
SIL24_MAX_SGE = 4 * SIL24_MAX_SGT + 1,
|
|
|
|
|
2005-07-28 05:36:22 +04:00
|
|
|
/*
|
|
|
|
* Global controller registers (128 bytes @ BAR0)
|
|
|
|
*/
|
|
|
|
/* 32 bit regs */
|
|
|
|
HOST_SLOT_STAT = 0x00, /* 32 bit slot stat * 4 */
|
|
|
|
HOST_CTRL = 0x40,
|
|
|
|
HOST_IRQ_STAT = 0x44,
|
|
|
|
HOST_PHY_CFG = 0x48,
|
|
|
|
HOST_BIST_CTRL = 0x50,
|
|
|
|
HOST_BIST_PTRN = 0x54,
|
|
|
|
HOST_BIST_STAT = 0x58,
|
|
|
|
HOST_MEM_BIST_STAT = 0x5c,
|
|
|
|
HOST_FLASH_CMD = 0x70,
|
|
|
|
/* 8 bit regs */
|
|
|
|
HOST_FLASH_DATA = 0x74,
|
|
|
|
HOST_TRANSITION_DETECT = 0x75,
|
|
|
|
HOST_GPIO_CTRL = 0x76,
|
|
|
|
HOST_I2C_ADDR = 0x78, /* 32 bit */
|
|
|
|
HOST_I2C_DATA = 0x7c,
|
|
|
|
HOST_I2C_XFER_CNT = 0x7e,
|
|
|
|
HOST_I2C_CTRL = 0x7f,
|
|
|
|
|
|
|
|
/* HOST_SLOT_STAT bits */
|
|
|
|
HOST_SSTAT_ATTN = (1 << 31),
|
|
|
|
|
2006-04-11 17:32:18 +04:00
|
|
|
/* HOST_CTRL bits */
|
|
|
|
HOST_CTRL_M66EN = (1 << 16), /* M66EN PCI bus signal */
|
|
|
|
HOST_CTRL_TRDY = (1 << 17), /* latched PCI TRDY */
|
|
|
|
HOST_CTRL_STOP = (1 << 18), /* latched PCI STOP */
|
|
|
|
HOST_CTRL_DEVSEL = (1 << 19), /* latched PCI DEVSEL */
|
|
|
|
HOST_CTRL_REQ64 = (1 << 20), /* latched PCI REQ64 */
|
2006-07-03 11:07:27 +04:00
|
|
|
HOST_CTRL_GLOBAL_RST = (1 << 31), /* global reset */
|
2006-04-11 17:32:18 +04:00
|
|
|
|
2005-07-28 05:36:22 +04:00
|
|
|
/*
|
|
|
|
* Port registers
|
|
|
|
* (8192 bytes @ +0x0000, +0x2000, +0x4000 and +0x6000 @ BAR2)
|
|
|
|
*/
|
|
|
|
PORT_REGS_SIZE = 0x2000,
|
2006-05-31 13:27:57 +04:00
|
|
|
|
2006-10-16 03:47:18 +04:00
|
|
|
PORT_LRAM = 0x0000, /* 31 LRAM slots and PMP regs */
|
2006-05-31 13:27:57 +04:00
|
|
|
PORT_LRAM_SLOT_SZ = 0x0080, /* 32 bytes PRB + 2 SGE, ACT... */
|
2005-07-28 05:36:22 +04:00
|
|
|
|
2006-10-16 03:47:18 +04:00
|
|
|
PORT_PMP = 0x0f80, /* 8 bytes PMP * 16 (128 bytes) */
|
2006-10-16 03:47:18 +04:00
|
|
|
PORT_PMP_STATUS = 0x0000, /* port device status offset */
|
|
|
|
PORT_PMP_QACTIVE = 0x0004, /* port device QActive offset */
|
|
|
|
PORT_PMP_SIZE = 0x0008, /* 8 bytes per PMP */
|
|
|
|
|
2005-07-28 05:36:22 +04:00
|
|
|
/* 32 bit regs */
|
2005-08-17 08:09:18 +04:00
|
|
|
PORT_CTRL_STAT = 0x1000, /* write: ctrl-set, read: stat */
|
|
|
|
PORT_CTRL_CLR = 0x1004, /* write: ctrl-clear */
|
|
|
|
PORT_IRQ_STAT = 0x1008, /* high: status, low: interrupt */
|
|
|
|
PORT_IRQ_ENABLE_SET = 0x1010, /* write: enable-set */
|
|
|
|
PORT_IRQ_ENABLE_CLR = 0x1014, /* write: enable-clear */
|
2005-07-28 05:36:22 +04:00
|
|
|
PORT_ACTIVATE_UPPER_ADDR= 0x101c,
|
2005-08-17 08:09:18 +04:00
|
|
|
PORT_EXEC_FIFO = 0x1020, /* command execution fifo */
|
|
|
|
PORT_CMD_ERR = 0x1024, /* command error number */
|
2005-07-28 05:36:22 +04:00
|
|
|
PORT_FIS_CFG = 0x1028,
|
|
|
|
PORT_FIFO_THRES = 0x102c,
|
|
|
|
/* 16 bit regs */
|
|
|
|
PORT_DECODE_ERR_CNT = 0x1040,
|
|
|
|
PORT_DECODE_ERR_THRESH = 0x1042,
|
|
|
|
PORT_CRC_ERR_CNT = 0x1044,
|
|
|
|
PORT_CRC_ERR_THRESH = 0x1046,
|
|
|
|
PORT_HSHK_ERR_CNT = 0x1048,
|
|
|
|
PORT_HSHK_ERR_THRESH = 0x104a,
|
|
|
|
/* 32 bit regs */
|
|
|
|
PORT_PHY_CFG = 0x1050,
|
|
|
|
PORT_SLOT_STAT = 0x1800,
|
|
|
|
PORT_CMD_ACTIVATE = 0x1c00, /* 64 bit cmd activate * 31 (248 bytes) */
|
2006-10-16 03:47:18 +04:00
|
|
|
PORT_CONTEXT = 0x1e04,
|
2005-07-28 05:36:22 +04:00
|
|
|
PORT_EXEC_DIAG = 0x1e00, /* 32bit exec diag * 16 (64 bytes, 0-10 used on 3124) */
|
|
|
|
PORT_PSD_DIAG = 0x1e40, /* 32bit psd diag * 16 (64 bytes, 0-8 used on 3124) */
|
|
|
|
PORT_SCONTROL = 0x1f00,
|
|
|
|
PORT_SSTATUS = 0x1f04,
|
|
|
|
PORT_SERROR = 0x1f08,
|
|
|
|
PORT_SACTIVE = 0x1f0c,
|
|
|
|
|
|
|
|
/* PORT_CTRL_STAT bits */
|
|
|
|
PORT_CS_PORT_RST = (1 << 0), /* port reset */
|
|
|
|
PORT_CS_DEV_RST = (1 << 1), /* device reset */
|
|
|
|
PORT_CS_INIT = (1 << 2), /* port initialize */
|
|
|
|
PORT_CS_IRQ_WOC = (1 << 3), /* interrupt write one to clear */
|
2005-11-16 10:56:49 +03:00
|
|
|
PORT_CS_CDB16 = (1 << 5), /* 0=12b cdb, 1=16b cdb */
|
2006-10-16 03:47:18 +04:00
|
|
|
PORT_CS_PMP_RESUME = (1 << 6), /* PMP resume */
|
2005-08-17 08:09:13 +04:00
|
|
|
PORT_CS_32BIT_ACTV = (1 << 10), /* 32-bit activation */
|
2006-10-16 03:47:18 +04:00
|
|
|
PORT_CS_PMP_EN = (1 << 13), /* port multiplier enable */
|
2005-08-17 08:09:13 +04:00
|
|
|
PORT_CS_RDY = (1 << 31), /* port ready to accept commands */
|
2005-07-28 05:36:22 +04:00
|
|
|
|
|
|
|
/* PORT_IRQ_STAT/ENABLE_SET/CLR */
|
|
|
|
/* bits[11:0] are masked */
|
|
|
|
PORT_IRQ_COMPLETE = (1 << 0), /* command(s) completed */
|
|
|
|
PORT_IRQ_ERROR = (1 << 1), /* command execution error */
|
|
|
|
PORT_IRQ_PORTRDY_CHG = (1 << 2), /* port ready change */
|
|
|
|
PORT_IRQ_PWR_CHG = (1 << 3), /* power management change */
|
|
|
|
PORT_IRQ_PHYRDY_CHG = (1 << 4), /* PHY ready change */
|
|
|
|
PORT_IRQ_COMWAKE = (1 << 5), /* COMWAKE received */
|
2006-04-11 17:32:18 +04:00
|
|
|
PORT_IRQ_UNK_FIS = (1 << 6), /* unknown FIS received */
|
|
|
|
PORT_IRQ_DEV_XCHG = (1 << 7), /* device exchanged */
|
|
|
|
PORT_IRQ_8B10B = (1 << 8), /* 8b/10b decode error threshold */
|
|
|
|
PORT_IRQ_CRC = (1 << 9), /* CRC error threshold */
|
|
|
|
PORT_IRQ_HANDSHAKE = (1 << 10), /* handshake error threshold */
|
2006-04-11 17:32:18 +04:00
|
|
|
PORT_IRQ_SDB_NOTIFY = (1 << 11), /* SDB notify received */
|
2005-07-28 05:36:22 +04:00
|
|
|
|
2006-05-15 15:58:32 +04:00
|
|
|
DEF_PORT_IRQ = PORT_IRQ_COMPLETE | PORT_IRQ_ERROR |
|
2006-05-31 13:28:20 +04:00
|
|
|
PORT_IRQ_PHYRDY_CHG | PORT_IRQ_DEV_XCHG |
|
2007-09-23 08:14:11 +04:00
|
|
|
PORT_IRQ_UNK_FIS | PORT_IRQ_SDB_NOTIFY,
|
2006-05-15 15:58:32 +04:00
|
|
|
|
2005-07-28 05:36:22 +04:00
|
|
|
/* bits[27:16] are unmasked (raw) */
|
|
|
|
PORT_IRQ_RAW_SHIFT = 16,
|
|
|
|
PORT_IRQ_MASKED_MASK = 0x7ff,
|
|
|
|
PORT_IRQ_RAW_MASK = (0x7ff << PORT_IRQ_RAW_SHIFT),
|
|
|
|
|
|
|
|
/* ENABLE_SET/CLR specific, intr steering - 2 bit field */
|
|
|
|
PORT_IRQ_STEER_SHIFT = 30,
|
|
|
|
PORT_IRQ_STEER_MASK = (3 << PORT_IRQ_STEER_SHIFT),
|
|
|
|
|
|
|
|
/* PORT_CMD_ERR constants */
|
|
|
|
PORT_CERR_DEV = 1, /* Error bit in D2H Register FIS */
|
|
|
|
PORT_CERR_SDB = 2, /* Error bit in SDB FIS */
|
|
|
|
PORT_CERR_DATA = 3, /* Error in data FIS not detected by dev */
|
|
|
|
PORT_CERR_SEND = 4, /* Initial cmd FIS transmission failure */
|
|
|
|
PORT_CERR_INCONSISTENT = 5, /* Protocol mismatch */
|
|
|
|
PORT_CERR_DIRECTION = 6, /* Data direction mismatch */
|
|
|
|
PORT_CERR_UNDERRUN = 7, /* Ran out of SGEs while writing */
|
|
|
|
PORT_CERR_OVERRUN = 8, /* Ran out of SGEs while reading */
|
|
|
|
PORT_CERR_PKT_PROT = 11, /* DIR invalid in 1st PIO setup of ATAPI */
|
|
|
|
PORT_CERR_SGT_BOUNDARY = 16, /* PLD ecode 00 - SGT not on qword boundary */
|
|
|
|
PORT_CERR_SGT_TGTABRT = 17, /* PLD ecode 01 - target abort */
|
|
|
|
PORT_CERR_SGT_MSTABRT = 18, /* PLD ecode 10 - master abort */
|
|
|
|
PORT_CERR_SGT_PCIPERR = 19, /* PLD ecode 11 - PCI parity err while fetching SGT */
|
|
|
|
PORT_CERR_CMD_BOUNDARY = 24, /* ctrl[15:13] 001 - PRB not on qword boundary */
|
|
|
|
PORT_CERR_CMD_TGTABRT = 25, /* ctrl[15:13] 010 - target abort */
|
|
|
|
PORT_CERR_CMD_MSTABRT = 26, /* ctrl[15:13] 100 - master abort */
|
|
|
|
PORT_CERR_CMD_PCIPERR = 27, /* ctrl[15:13] 110 - PCI parity err while fetching PRB */
|
|
|
|
PORT_CERR_XFR_UNDEF = 32, /* PSD ecode 00 - undefined */
|
|
|
|
PORT_CERR_XFR_TGTABRT = 33, /* PSD ecode 01 - target abort */
|
2006-04-11 17:32:18 +04:00
|
|
|
PORT_CERR_XFR_MSTABRT = 34, /* PSD ecode 10 - master abort */
|
2005-07-28 05:36:22 +04:00
|
|
|
PORT_CERR_XFR_PCIPERR = 35, /* PSD ecode 11 - PCI prity err during transfer */
|
2005-08-17 08:09:18 +04:00
|
|
|
PORT_CERR_SENDSERVICE = 36, /* FIS received while sending service */
|
2005-07-28 05:36:22 +04:00
|
|
|
|
2005-11-16 10:56:49 +03:00
|
|
|
/* bits of PRB control field */
|
|
|
|
PRB_CTRL_PROTOCOL = (1 << 0), /* override def. ATA protocol */
|
|
|
|
PRB_CTRL_PACKET_READ = (1 << 4), /* PACKET cmd read */
|
|
|
|
PRB_CTRL_PACKET_WRITE = (1 << 5), /* PACKET cmd write */
|
|
|
|
PRB_CTRL_NIEN = (1 << 6), /* Mask completion irq */
|
|
|
|
PRB_CTRL_SRST = (1 << 7), /* Soft reset request (ign BSY?) */
|
|
|
|
|
|
|
|
/* PRB protocol field */
|
|
|
|
PRB_PROT_PACKET = (1 << 0),
|
|
|
|
PRB_PROT_TCQ = (1 << 1),
|
|
|
|
PRB_PROT_NCQ = (1 << 2),
|
|
|
|
PRB_PROT_READ = (1 << 3),
|
|
|
|
PRB_PROT_WRITE = (1 << 4),
|
|
|
|
PRB_PROT_TRANSPARENT = (1 << 5),
|
|
|
|
|
2005-07-28 05:36:22 +04:00
|
|
|
/*
|
|
|
|
* Other constants
|
|
|
|
*/
|
|
|
|
SGE_TRM = (1 << 31), /* Last SGE in chain */
|
2005-11-16 10:56:49 +03:00
|
|
|
SGE_LNK = (1 << 30), /* linked list
|
|
|
|
Points to SGT, not SGE */
|
|
|
|
SGE_DRD = (1 << 29), /* discard data read (/dev/null)
|
|
|
|
data address ignored */
|
2005-07-28 05:36:22 +04:00
|
|
|
|
2006-05-15 16:03:56 +04:00
|
|
|
SIL24_MAX_CMDS = 31,
|
|
|
|
|
2005-07-28 05:36:22 +04:00
|
|
|
/* board id */
|
|
|
|
BID_SIL3124 = 0,
|
|
|
|
BID_SIL3132 = 1,
|
2005-10-09 17:35:46 +04:00
|
|
|
BID_SIL3131 = 2,
|
2005-07-28 05:36:22 +04:00
|
|
|
|
2006-04-11 17:32:18 +04:00
|
|
|
/* host flags */
|
2011-02-04 22:05:48 +03:00
|
|
|
SIL24_COMMON_FLAGS = ATA_FLAG_SATA | ATA_FLAG_PIO_DMA |
|
|
|
|
ATA_FLAG_NCQ | ATA_FLAG_ACPI_SATA |
|
2015-03-24 21:14:18 +03:00
|
|
|
ATA_FLAG_AN | ATA_FLAG_PMP,
|
2006-04-11 17:32:19 +04:00
|
|
|
SIL24_FLAG_PCIX_IRQ_WOC = (1 << 24), /* IRQ loss errata on PCI-X */
|
2006-04-11 17:32:18 +04:00
|
|
|
|
2005-07-28 05:36:22 +04:00
|
|
|
IRQ_STAT_4PORTS = 0xf,
|
|
|
|
};
|
|
|
|
|
2005-11-18 08:16:45 +03:00
|
|
|
struct sil24_ata_block {
|
2005-07-28 05:36:22 +04:00
|
|
|
struct sil24_prb prb;
|
2007-11-22 12:46:57 +03:00
|
|
|
struct sil24_sge sge[SIL24_MAX_SGE];
|
2005-07-28 05:36:22 +04:00
|
|
|
};
|
|
|
|
|
2005-11-18 08:16:45 +03:00
|
|
|
struct sil24_atapi_block {
|
|
|
|
struct sil24_prb prb;
|
|
|
|
u8 cdb[16];
|
2007-11-22 12:46:57 +03:00
|
|
|
struct sil24_sge sge[SIL24_MAX_SGE];
|
2005-11-18 08:16:45 +03:00
|
|
|
};
|
|
|
|
|
|
|
|
union sil24_cmd_block {
|
|
|
|
struct sil24_ata_block ata;
|
|
|
|
struct sil24_atapi_block atapi;
|
|
|
|
};
|
|
|
|
|
2011-08-06 06:38:17 +04:00
|
|
|
static const struct sil24_cerr_info {
|
2006-05-15 15:58:32 +04:00
|
|
|
unsigned int err_mask, action;
|
|
|
|
const char *desc;
|
|
|
|
} sil24_cerr_db[] = {
|
2007-10-26 11:12:41 +04:00
|
|
|
[0] = { AC_ERR_DEV, 0,
|
2006-05-15 15:58:32 +04:00
|
|
|
"device error" },
|
2007-10-26 11:12:41 +04:00
|
|
|
[PORT_CERR_DEV] = { AC_ERR_DEV, 0,
|
2006-05-15 15:58:32 +04:00
|
|
|
"device error via D2H FIS" },
|
2007-10-26 11:12:41 +04:00
|
|
|
[PORT_CERR_SDB] = { AC_ERR_DEV, 0,
|
2006-05-15 15:58:32 +04:00
|
|
|
"device error via SDB FIS" },
|
libata: prefer hardreset
When both soft and hard resets are available, libata preferred
softreset till now. The logic behind it was to be softer to devices;
however, this doesn't really help much. Rationales for the change:
* BIOS may freeze lock certain things during boot and softreset can't
unlock those. This by itself is okay but during operation PHY event
or other error conditions can trigger hardreset and the device may
end up with different configuration.
For example, after a hardreset, previously unlockable HPA can be
unlocked resulting in different device size and thus revalidation
failure. Similar condition can occur during or after resume.
* Certain ATAPI devices require hardreset to recover after certain
error conditions. On PATA, this is done by issuing the DEVICE RESET
command. On SATA, COMRESET has equivalent effect. The problem is
that DEVICE RESET needs its own execution protocol.
For SFF controllers with bare TF access, it can be easily
implemented but more advanced controllers (e.g. ahci and sata_sil24)
require specialized implementations. Simply using hardreset solves
the problem nicely.
* COMRESET initialization sequence is the norm in SATA land and many
SATA devices don't work properly if only SRST is used. For example,
some PMPs behave this way and libata works around by always issuing
hardreset if the host supports PMP.
Like the above example, libata has developed a number of mechanisms
aiming to promote softreset to hardreset if softreset is not going
to work. This approach is time consuming and error prone.
Also, note that, dependingon how you read the specs, it could be
argued that PMP fan-out ports require COMRESET to start operation.
In fact, all the PMPs on the market except one don't work properly
if COMRESET is not issued to fan-out ports after PMP reset.
* COMRESET is an integral part of SATA connection and any working
device should be able to handle COMRESET properly. After all, it's
the way to signal hardreset during reboot. This is the most used
and recommended (at least by the ahci spec) method of resetting
devices.
So, this patch makes libata prefer hardreset over softreset by making
the following changes.
* Rename ATA_EH_RESET_MASK to ATA_EH_RESET and use it whereever
ATA_EH_{SOFT|HARD}RESET used to be used. ATA_EH_{SOFT|HARD}RESET is
now only used to tell prereset whether soft or hard reset will be
issued.
* Strip out now unneeded promote-to-hardreset logics from
ata_eh_reset(), ata_std_prereset(), sata_pmp_std_prereset() and
other places.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-01-23 18:05:14 +03:00
|
|
|
[PORT_CERR_DATA] = { AC_ERR_ATA_BUS, ATA_EH_RESET,
|
2006-05-15 15:58:32 +04:00
|
|
|
"error in data FIS" },
|
libata: prefer hardreset
When both soft and hard resets are available, libata preferred
softreset till now. The logic behind it was to be softer to devices;
however, this doesn't really help much. Rationales for the change:
* BIOS may freeze lock certain things during boot and softreset can't
unlock those. This by itself is okay but during operation PHY event
or other error conditions can trigger hardreset and the device may
end up with different configuration.
For example, after a hardreset, previously unlockable HPA can be
unlocked resulting in different device size and thus revalidation
failure. Similar condition can occur during or after resume.
* Certain ATAPI devices require hardreset to recover after certain
error conditions. On PATA, this is done by issuing the DEVICE RESET
command. On SATA, COMRESET has equivalent effect. The problem is
that DEVICE RESET needs its own execution protocol.
For SFF controllers with bare TF access, it can be easily
implemented but more advanced controllers (e.g. ahci and sata_sil24)
require specialized implementations. Simply using hardreset solves
the problem nicely.
* COMRESET initialization sequence is the norm in SATA land and many
SATA devices don't work properly if only SRST is used. For example,
some PMPs behave this way and libata works around by always issuing
hardreset if the host supports PMP.
Like the above example, libata has developed a number of mechanisms
aiming to promote softreset to hardreset if softreset is not going
to work. This approach is time consuming and error prone.
Also, note that, dependingon how you read the specs, it could be
argued that PMP fan-out ports require COMRESET to start operation.
In fact, all the PMPs on the market except one don't work properly
if COMRESET is not issued to fan-out ports after PMP reset.
* COMRESET is an integral part of SATA connection and any working
device should be able to handle COMRESET properly. After all, it's
the way to signal hardreset during reboot. This is the most used
and recommended (at least by the ahci spec) method of resetting
devices.
So, this patch makes libata prefer hardreset over softreset by making
the following changes.
* Rename ATA_EH_RESET_MASK to ATA_EH_RESET and use it whereever
ATA_EH_{SOFT|HARD}RESET used to be used. ATA_EH_{SOFT|HARD}RESET is
now only used to tell prereset whether soft or hard reset will be
issued.
* Strip out now unneeded promote-to-hardreset logics from
ata_eh_reset(), ata_std_prereset(), sata_pmp_std_prereset() and
other places.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-01-23 18:05:14 +03:00
|
|
|
[PORT_CERR_SEND] = { AC_ERR_ATA_BUS, ATA_EH_RESET,
|
2006-05-15 15:58:32 +04:00
|
|
|
"failed to transmit command FIS" },
|
libata: prefer hardreset
When both soft and hard resets are available, libata preferred
softreset till now. The logic behind it was to be softer to devices;
however, this doesn't really help much. Rationales for the change:
* BIOS may freeze lock certain things during boot and softreset can't
unlock those. This by itself is okay but during operation PHY event
or other error conditions can trigger hardreset and the device may
end up with different configuration.
For example, after a hardreset, previously unlockable HPA can be
unlocked resulting in different device size and thus revalidation
failure. Similar condition can occur during or after resume.
* Certain ATAPI devices require hardreset to recover after certain
error conditions. On PATA, this is done by issuing the DEVICE RESET
command. On SATA, COMRESET has equivalent effect. The problem is
that DEVICE RESET needs its own execution protocol.
For SFF controllers with bare TF access, it can be easily
implemented but more advanced controllers (e.g. ahci and sata_sil24)
require specialized implementations. Simply using hardreset solves
the problem nicely.
* COMRESET initialization sequence is the norm in SATA land and many
SATA devices don't work properly if only SRST is used. For example,
some PMPs behave this way and libata works around by always issuing
hardreset if the host supports PMP.
Like the above example, libata has developed a number of mechanisms
aiming to promote softreset to hardreset if softreset is not going
to work. This approach is time consuming and error prone.
Also, note that, dependingon how you read the specs, it could be
argued that PMP fan-out ports require COMRESET to start operation.
In fact, all the PMPs on the market except one don't work properly
if COMRESET is not issued to fan-out ports after PMP reset.
* COMRESET is an integral part of SATA connection and any working
device should be able to handle COMRESET properly. After all, it's
the way to signal hardreset during reboot. This is the most used
and recommended (at least by the ahci spec) method of resetting
devices.
So, this patch makes libata prefer hardreset over softreset by making
the following changes.
* Rename ATA_EH_RESET_MASK to ATA_EH_RESET and use it whereever
ATA_EH_{SOFT|HARD}RESET used to be used. ATA_EH_{SOFT|HARD}RESET is
now only used to tell prereset whether soft or hard reset will be
issued.
* Strip out now unneeded promote-to-hardreset logics from
ata_eh_reset(), ata_std_prereset(), sata_pmp_std_prereset() and
other places.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-01-23 18:05:14 +03:00
|
|
|
[PORT_CERR_INCONSISTENT] = { AC_ERR_HSM, ATA_EH_RESET,
|
2006-05-15 15:58:32 +04:00
|
|
|
"protocol mismatch" },
|
libata: prefer hardreset
When both soft and hard resets are available, libata preferred
softreset till now. The logic behind it was to be softer to devices;
however, this doesn't really help much. Rationales for the change:
* BIOS may freeze lock certain things during boot and softreset can't
unlock those. This by itself is okay but during operation PHY event
or other error conditions can trigger hardreset and the device may
end up with different configuration.
For example, after a hardreset, previously unlockable HPA can be
unlocked resulting in different device size and thus revalidation
failure. Similar condition can occur during or after resume.
* Certain ATAPI devices require hardreset to recover after certain
error conditions. On PATA, this is done by issuing the DEVICE RESET
command. On SATA, COMRESET has equivalent effect. The problem is
that DEVICE RESET needs its own execution protocol.
For SFF controllers with bare TF access, it can be easily
implemented but more advanced controllers (e.g. ahci and sata_sil24)
require specialized implementations. Simply using hardreset solves
the problem nicely.
* COMRESET initialization sequence is the norm in SATA land and many
SATA devices don't work properly if only SRST is used. For example,
some PMPs behave this way and libata works around by always issuing
hardreset if the host supports PMP.
Like the above example, libata has developed a number of mechanisms
aiming to promote softreset to hardreset if softreset is not going
to work. This approach is time consuming and error prone.
Also, note that, dependingon how you read the specs, it could be
argued that PMP fan-out ports require COMRESET to start operation.
In fact, all the PMPs on the market except one don't work properly
if COMRESET is not issued to fan-out ports after PMP reset.
* COMRESET is an integral part of SATA connection and any working
device should be able to handle COMRESET properly. After all, it's
the way to signal hardreset during reboot. This is the most used
and recommended (at least by the ahci spec) method of resetting
devices.
So, this patch makes libata prefer hardreset over softreset by making
the following changes.
* Rename ATA_EH_RESET_MASK to ATA_EH_RESET and use it whereever
ATA_EH_{SOFT|HARD}RESET used to be used. ATA_EH_{SOFT|HARD}RESET is
now only used to tell prereset whether soft or hard reset will be
issued.
* Strip out now unneeded promote-to-hardreset logics from
ata_eh_reset(), ata_std_prereset(), sata_pmp_std_prereset() and
other places.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-01-23 18:05:14 +03:00
|
|
|
[PORT_CERR_DIRECTION] = { AC_ERR_HSM, ATA_EH_RESET,
|
2006-05-15 15:58:32 +04:00
|
|
|
"data directon mismatch" },
|
libata: prefer hardreset
When both soft and hard resets are available, libata preferred
softreset till now. The logic behind it was to be softer to devices;
however, this doesn't really help much. Rationales for the change:
* BIOS may freeze lock certain things during boot and softreset can't
unlock those. This by itself is okay but during operation PHY event
or other error conditions can trigger hardreset and the device may
end up with different configuration.
For example, after a hardreset, previously unlockable HPA can be
unlocked resulting in different device size and thus revalidation
failure. Similar condition can occur during or after resume.
* Certain ATAPI devices require hardreset to recover after certain
error conditions. On PATA, this is done by issuing the DEVICE RESET
command. On SATA, COMRESET has equivalent effect. The problem is
that DEVICE RESET needs its own execution protocol.
For SFF controllers with bare TF access, it can be easily
implemented but more advanced controllers (e.g. ahci and sata_sil24)
require specialized implementations. Simply using hardreset solves
the problem nicely.
* COMRESET initialization sequence is the norm in SATA land and many
SATA devices don't work properly if only SRST is used. For example,
some PMPs behave this way and libata works around by always issuing
hardreset if the host supports PMP.
Like the above example, libata has developed a number of mechanisms
aiming to promote softreset to hardreset if softreset is not going
to work. This approach is time consuming and error prone.
Also, note that, dependingon how you read the specs, it could be
argued that PMP fan-out ports require COMRESET to start operation.
In fact, all the PMPs on the market except one don't work properly
if COMRESET is not issued to fan-out ports after PMP reset.
* COMRESET is an integral part of SATA connection and any working
device should be able to handle COMRESET properly. After all, it's
the way to signal hardreset during reboot. This is the most used
and recommended (at least by the ahci spec) method of resetting
devices.
So, this patch makes libata prefer hardreset over softreset by making
the following changes.
* Rename ATA_EH_RESET_MASK to ATA_EH_RESET and use it whereever
ATA_EH_{SOFT|HARD}RESET used to be used. ATA_EH_{SOFT|HARD}RESET is
now only used to tell prereset whether soft or hard reset will be
issued.
* Strip out now unneeded promote-to-hardreset logics from
ata_eh_reset(), ata_std_prereset(), sata_pmp_std_prereset() and
other places.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-01-23 18:05:14 +03:00
|
|
|
[PORT_CERR_UNDERRUN] = { AC_ERR_HSM, ATA_EH_RESET,
|
2006-05-15 15:58:32 +04:00
|
|
|
"ran out of SGEs while writing" },
|
libata: prefer hardreset
When both soft and hard resets are available, libata preferred
softreset till now. The logic behind it was to be softer to devices;
however, this doesn't really help much. Rationales for the change:
* BIOS may freeze lock certain things during boot and softreset can't
unlock those. This by itself is okay but during operation PHY event
or other error conditions can trigger hardreset and the device may
end up with different configuration.
For example, after a hardreset, previously unlockable HPA can be
unlocked resulting in different device size and thus revalidation
failure. Similar condition can occur during or after resume.
* Certain ATAPI devices require hardreset to recover after certain
error conditions. On PATA, this is done by issuing the DEVICE RESET
command. On SATA, COMRESET has equivalent effect. The problem is
that DEVICE RESET needs its own execution protocol.
For SFF controllers with bare TF access, it can be easily
implemented but more advanced controllers (e.g. ahci and sata_sil24)
require specialized implementations. Simply using hardreset solves
the problem nicely.
* COMRESET initialization sequence is the norm in SATA land and many
SATA devices don't work properly if only SRST is used. For example,
some PMPs behave this way and libata works around by always issuing
hardreset if the host supports PMP.
Like the above example, libata has developed a number of mechanisms
aiming to promote softreset to hardreset if softreset is not going
to work. This approach is time consuming and error prone.
Also, note that, dependingon how you read the specs, it could be
argued that PMP fan-out ports require COMRESET to start operation.
In fact, all the PMPs on the market except one don't work properly
if COMRESET is not issued to fan-out ports after PMP reset.
* COMRESET is an integral part of SATA connection and any working
device should be able to handle COMRESET properly. After all, it's
the way to signal hardreset during reboot. This is the most used
and recommended (at least by the ahci spec) method of resetting
devices.
So, this patch makes libata prefer hardreset over softreset by making
the following changes.
* Rename ATA_EH_RESET_MASK to ATA_EH_RESET and use it whereever
ATA_EH_{SOFT|HARD}RESET used to be used. ATA_EH_{SOFT|HARD}RESET is
now only used to tell prereset whether soft or hard reset will be
issued.
* Strip out now unneeded promote-to-hardreset logics from
ata_eh_reset(), ata_std_prereset(), sata_pmp_std_prereset() and
other places.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-01-23 18:05:14 +03:00
|
|
|
[PORT_CERR_OVERRUN] = { AC_ERR_HSM, ATA_EH_RESET,
|
2006-05-15 15:58:32 +04:00
|
|
|
"ran out of SGEs while reading" },
|
libata: prefer hardreset
When both soft and hard resets are available, libata preferred
softreset till now. The logic behind it was to be softer to devices;
however, this doesn't really help much. Rationales for the change:
* BIOS may freeze lock certain things during boot and softreset can't
unlock those. This by itself is okay but during operation PHY event
or other error conditions can trigger hardreset and the device may
end up with different configuration.
For example, after a hardreset, previously unlockable HPA can be
unlocked resulting in different device size and thus revalidation
failure. Similar condition can occur during or after resume.
* Certain ATAPI devices require hardreset to recover after certain
error conditions. On PATA, this is done by issuing the DEVICE RESET
command. On SATA, COMRESET has equivalent effect. The problem is
that DEVICE RESET needs its own execution protocol.
For SFF controllers with bare TF access, it can be easily
implemented but more advanced controllers (e.g. ahci and sata_sil24)
require specialized implementations. Simply using hardreset solves
the problem nicely.
* COMRESET initialization sequence is the norm in SATA land and many
SATA devices don't work properly if only SRST is used. For example,
some PMPs behave this way and libata works around by always issuing
hardreset if the host supports PMP.
Like the above example, libata has developed a number of mechanisms
aiming to promote softreset to hardreset if softreset is not going
to work. This approach is time consuming and error prone.
Also, note that, dependingon how you read the specs, it could be
argued that PMP fan-out ports require COMRESET to start operation.
In fact, all the PMPs on the market except one don't work properly
if COMRESET is not issued to fan-out ports after PMP reset.
* COMRESET is an integral part of SATA connection and any working
device should be able to handle COMRESET properly. After all, it's
the way to signal hardreset during reboot. This is the most used
and recommended (at least by the ahci spec) method of resetting
devices.
So, this patch makes libata prefer hardreset over softreset by making
the following changes.
* Rename ATA_EH_RESET_MASK to ATA_EH_RESET and use it whereever
ATA_EH_{SOFT|HARD}RESET used to be used. ATA_EH_{SOFT|HARD}RESET is
now only used to tell prereset whether soft or hard reset will be
issued.
* Strip out now unneeded promote-to-hardreset logics from
ata_eh_reset(), ata_std_prereset(), sata_pmp_std_prereset() and
other places.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-01-23 18:05:14 +03:00
|
|
|
[PORT_CERR_PKT_PROT] = { AC_ERR_HSM, ATA_EH_RESET,
|
2006-05-15 15:58:32 +04:00
|
|
|
"invalid data directon for ATAPI CDB" },
|
libata: prefer hardreset
When both soft and hard resets are available, libata preferred
softreset till now. The logic behind it was to be softer to devices;
however, this doesn't really help much. Rationales for the change:
* BIOS may freeze lock certain things during boot and softreset can't
unlock those. This by itself is okay but during operation PHY event
or other error conditions can trigger hardreset and the device may
end up with different configuration.
For example, after a hardreset, previously unlockable HPA can be
unlocked resulting in different device size and thus revalidation
failure. Similar condition can occur during or after resume.
* Certain ATAPI devices require hardreset to recover after certain
error conditions. On PATA, this is done by issuing the DEVICE RESET
command. On SATA, COMRESET has equivalent effect. The problem is
that DEVICE RESET needs its own execution protocol.
For SFF controllers with bare TF access, it can be easily
implemented but more advanced controllers (e.g. ahci and sata_sil24)
require specialized implementations. Simply using hardreset solves
the problem nicely.
* COMRESET initialization sequence is the norm in SATA land and many
SATA devices don't work properly if only SRST is used. For example,
some PMPs behave this way and libata works around by always issuing
hardreset if the host supports PMP.
Like the above example, libata has developed a number of mechanisms
aiming to promote softreset to hardreset if softreset is not going
to work. This approach is time consuming and error prone.
Also, note that, dependingon how you read the specs, it could be
argued that PMP fan-out ports require COMRESET to start operation.
In fact, all the PMPs on the market except one don't work properly
if COMRESET is not issued to fan-out ports after PMP reset.
* COMRESET is an integral part of SATA connection and any working
device should be able to handle COMRESET properly. After all, it's
the way to signal hardreset during reboot. This is the most used
and recommended (at least by the ahci spec) method of resetting
devices.
So, this patch makes libata prefer hardreset over softreset by making
the following changes.
* Rename ATA_EH_RESET_MASK to ATA_EH_RESET and use it whereever
ATA_EH_{SOFT|HARD}RESET used to be used. ATA_EH_{SOFT|HARD}RESET is
now only used to tell prereset whether soft or hard reset will be
issued.
* Strip out now unneeded promote-to-hardreset logics from
ata_eh_reset(), ata_std_prereset(), sata_pmp_std_prereset() and
other places.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-01-23 18:05:14 +03:00
|
|
|
[PORT_CERR_SGT_BOUNDARY] = { AC_ERR_SYSTEM, ATA_EH_RESET,
|
2008-01-13 07:49:22 +03:00
|
|
|
"SGT not on qword boundary" },
|
libata: prefer hardreset
When both soft and hard resets are available, libata preferred
softreset till now. The logic behind it was to be softer to devices;
however, this doesn't really help much. Rationales for the change:
* BIOS may freeze lock certain things during boot and softreset can't
unlock those. This by itself is okay but during operation PHY event
or other error conditions can trigger hardreset and the device may
end up with different configuration.
For example, after a hardreset, previously unlockable HPA can be
unlocked resulting in different device size and thus revalidation
failure. Similar condition can occur during or after resume.
* Certain ATAPI devices require hardreset to recover after certain
error conditions. On PATA, this is done by issuing the DEVICE RESET
command. On SATA, COMRESET has equivalent effect. The problem is
that DEVICE RESET needs its own execution protocol.
For SFF controllers with bare TF access, it can be easily
implemented but more advanced controllers (e.g. ahci and sata_sil24)
require specialized implementations. Simply using hardreset solves
the problem nicely.
* COMRESET initialization sequence is the norm in SATA land and many
SATA devices don't work properly if only SRST is used. For example,
some PMPs behave this way and libata works around by always issuing
hardreset if the host supports PMP.
Like the above example, libata has developed a number of mechanisms
aiming to promote softreset to hardreset if softreset is not going
to work. This approach is time consuming and error prone.
Also, note that, dependingon how you read the specs, it could be
argued that PMP fan-out ports require COMRESET to start operation.
In fact, all the PMPs on the market except one don't work properly
if COMRESET is not issued to fan-out ports after PMP reset.
* COMRESET is an integral part of SATA connection and any working
device should be able to handle COMRESET properly. After all, it's
the way to signal hardreset during reboot. This is the most used
and recommended (at least by the ahci spec) method of resetting
devices.
So, this patch makes libata prefer hardreset over softreset by making
the following changes.
* Rename ATA_EH_RESET_MASK to ATA_EH_RESET and use it whereever
ATA_EH_{SOFT|HARD}RESET used to be used. ATA_EH_{SOFT|HARD}RESET is
now only used to tell prereset whether soft or hard reset will be
issued.
* Strip out now unneeded promote-to-hardreset logics from
ata_eh_reset(), ata_std_prereset(), sata_pmp_std_prereset() and
other places.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-01-23 18:05:14 +03:00
|
|
|
[PORT_CERR_SGT_TGTABRT] = { AC_ERR_HOST_BUS, ATA_EH_RESET,
|
2006-05-15 15:58:32 +04:00
|
|
|
"PCI target abort while fetching SGT" },
|
libata: prefer hardreset
When both soft and hard resets are available, libata preferred
softreset till now. The logic behind it was to be softer to devices;
however, this doesn't really help much. Rationales for the change:
* BIOS may freeze lock certain things during boot and softreset can't
unlock those. This by itself is okay but during operation PHY event
or other error conditions can trigger hardreset and the device may
end up with different configuration.
For example, after a hardreset, previously unlockable HPA can be
unlocked resulting in different device size and thus revalidation
failure. Similar condition can occur during or after resume.
* Certain ATAPI devices require hardreset to recover after certain
error conditions. On PATA, this is done by issuing the DEVICE RESET
command. On SATA, COMRESET has equivalent effect. The problem is
that DEVICE RESET needs its own execution protocol.
For SFF controllers with bare TF access, it can be easily
implemented but more advanced controllers (e.g. ahci and sata_sil24)
require specialized implementations. Simply using hardreset solves
the problem nicely.
* COMRESET initialization sequence is the norm in SATA land and many
SATA devices don't work properly if only SRST is used. For example,
some PMPs behave this way and libata works around by always issuing
hardreset if the host supports PMP.
Like the above example, libata has developed a number of mechanisms
aiming to promote softreset to hardreset if softreset is not going
to work. This approach is time consuming and error prone.
Also, note that, dependingon how you read the specs, it could be
argued that PMP fan-out ports require COMRESET to start operation.
In fact, all the PMPs on the market except one don't work properly
if COMRESET is not issued to fan-out ports after PMP reset.
* COMRESET is an integral part of SATA connection and any working
device should be able to handle COMRESET properly. After all, it's
the way to signal hardreset during reboot. This is the most used
and recommended (at least by the ahci spec) method of resetting
devices.
So, this patch makes libata prefer hardreset over softreset by making
the following changes.
* Rename ATA_EH_RESET_MASK to ATA_EH_RESET and use it whereever
ATA_EH_{SOFT|HARD}RESET used to be used. ATA_EH_{SOFT|HARD}RESET is
now only used to tell prereset whether soft or hard reset will be
issued.
* Strip out now unneeded promote-to-hardreset logics from
ata_eh_reset(), ata_std_prereset(), sata_pmp_std_prereset() and
other places.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-01-23 18:05:14 +03:00
|
|
|
[PORT_CERR_SGT_MSTABRT] = { AC_ERR_HOST_BUS, ATA_EH_RESET,
|
2006-05-15 15:58:32 +04:00
|
|
|
"PCI master abort while fetching SGT" },
|
libata: prefer hardreset
When both soft and hard resets are available, libata preferred
softreset till now. The logic behind it was to be softer to devices;
however, this doesn't really help much. Rationales for the change:
* BIOS may freeze lock certain things during boot and softreset can't
unlock those. This by itself is okay but during operation PHY event
or other error conditions can trigger hardreset and the device may
end up with different configuration.
For example, after a hardreset, previously unlockable HPA can be
unlocked resulting in different device size and thus revalidation
failure. Similar condition can occur during or after resume.
* Certain ATAPI devices require hardreset to recover after certain
error conditions. On PATA, this is done by issuing the DEVICE RESET
command. On SATA, COMRESET has equivalent effect. The problem is
that DEVICE RESET needs its own execution protocol.
For SFF controllers with bare TF access, it can be easily
implemented but more advanced controllers (e.g. ahci and sata_sil24)
require specialized implementations. Simply using hardreset solves
the problem nicely.
* COMRESET initialization sequence is the norm in SATA land and many
SATA devices don't work properly if only SRST is used. For example,
some PMPs behave this way and libata works around by always issuing
hardreset if the host supports PMP.
Like the above example, libata has developed a number of mechanisms
aiming to promote softreset to hardreset if softreset is not going
to work. This approach is time consuming and error prone.
Also, note that, dependingon how you read the specs, it could be
argued that PMP fan-out ports require COMRESET to start operation.
In fact, all the PMPs on the market except one don't work properly
if COMRESET is not issued to fan-out ports after PMP reset.
* COMRESET is an integral part of SATA connection and any working
device should be able to handle COMRESET properly. After all, it's
the way to signal hardreset during reboot. This is the most used
and recommended (at least by the ahci spec) method of resetting
devices.
So, this patch makes libata prefer hardreset over softreset by making
the following changes.
* Rename ATA_EH_RESET_MASK to ATA_EH_RESET and use it whereever
ATA_EH_{SOFT|HARD}RESET used to be used. ATA_EH_{SOFT|HARD}RESET is
now only used to tell prereset whether soft or hard reset will be
issued.
* Strip out now unneeded promote-to-hardreset logics from
ata_eh_reset(), ata_std_prereset(), sata_pmp_std_prereset() and
other places.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-01-23 18:05:14 +03:00
|
|
|
[PORT_CERR_SGT_PCIPERR] = { AC_ERR_HOST_BUS, ATA_EH_RESET,
|
2006-05-15 15:58:32 +04:00
|
|
|
"PCI parity error while fetching SGT" },
|
libata: prefer hardreset
When both soft and hard resets are available, libata preferred
softreset till now. The logic behind it was to be softer to devices;
however, this doesn't really help much. Rationales for the change:
* BIOS may freeze lock certain things during boot and softreset can't
unlock those. This by itself is okay but during operation PHY event
or other error conditions can trigger hardreset and the device may
end up with different configuration.
For example, after a hardreset, previously unlockable HPA can be
unlocked resulting in different device size and thus revalidation
failure. Similar condition can occur during or after resume.
* Certain ATAPI devices require hardreset to recover after certain
error conditions. On PATA, this is done by issuing the DEVICE RESET
command. On SATA, COMRESET has equivalent effect. The problem is
that DEVICE RESET needs its own execution protocol.
For SFF controllers with bare TF access, it can be easily
implemented but more advanced controllers (e.g. ahci and sata_sil24)
require specialized implementations. Simply using hardreset solves
the problem nicely.
* COMRESET initialization sequence is the norm in SATA land and many
SATA devices don't work properly if only SRST is used. For example,
some PMPs behave this way and libata works around by always issuing
hardreset if the host supports PMP.
Like the above example, libata has developed a number of mechanisms
aiming to promote softreset to hardreset if softreset is not going
to work. This approach is time consuming and error prone.
Also, note that, dependingon how you read the specs, it could be
argued that PMP fan-out ports require COMRESET to start operation.
In fact, all the PMPs on the market except one don't work properly
if COMRESET is not issued to fan-out ports after PMP reset.
* COMRESET is an integral part of SATA connection and any working
device should be able to handle COMRESET properly. After all, it's
the way to signal hardreset during reboot. This is the most used
and recommended (at least by the ahci spec) method of resetting
devices.
So, this patch makes libata prefer hardreset over softreset by making
the following changes.
* Rename ATA_EH_RESET_MASK to ATA_EH_RESET and use it whereever
ATA_EH_{SOFT|HARD}RESET used to be used. ATA_EH_{SOFT|HARD}RESET is
now only used to tell prereset whether soft or hard reset will be
issued.
* Strip out now unneeded promote-to-hardreset logics from
ata_eh_reset(), ata_std_prereset(), sata_pmp_std_prereset() and
other places.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-01-23 18:05:14 +03:00
|
|
|
[PORT_CERR_CMD_BOUNDARY] = { AC_ERR_SYSTEM, ATA_EH_RESET,
|
2006-05-15 15:58:32 +04:00
|
|
|
"PRB not on qword boundary" },
|
libata: prefer hardreset
When both soft and hard resets are available, libata preferred
softreset till now. The logic behind it was to be softer to devices;
however, this doesn't really help much. Rationales for the change:
* BIOS may freeze lock certain things during boot and softreset can't
unlock those. This by itself is okay but during operation PHY event
or other error conditions can trigger hardreset and the device may
end up with different configuration.
For example, after a hardreset, previously unlockable HPA can be
unlocked resulting in different device size and thus revalidation
failure. Similar condition can occur during or after resume.
* Certain ATAPI devices require hardreset to recover after certain
error conditions. On PATA, this is done by issuing the DEVICE RESET
command. On SATA, COMRESET has equivalent effect. The problem is
that DEVICE RESET needs its own execution protocol.
For SFF controllers with bare TF access, it can be easily
implemented but more advanced controllers (e.g. ahci and sata_sil24)
require specialized implementations. Simply using hardreset solves
the problem nicely.
* COMRESET initialization sequence is the norm in SATA land and many
SATA devices don't work properly if only SRST is used. For example,
some PMPs behave this way and libata works around by always issuing
hardreset if the host supports PMP.
Like the above example, libata has developed a number of mechanisms
aiming to promote softreset to hardreset if softreset is not going
to work. This approach is time consuming and error prone.
Also, note that, dependingon how you read the specs, it could be
argued that PMP fan-out ports require COMRESET to start operation.
In fact, all the PMPs on the market except one don't work properly
if COMRESET is not issued to fan-out ports after PMP reset.
* COMRESET is an integral part of SATA connection and any working
device should be able to handle COMRESET properly. After all, it's
the way to signal hardreset during reboot. This is the most used
and recommended (at least by the ahci spec) method of resetting
devices.
So, this patch makes libata prefer hardreset over softreset by making
the following changes.
* Rename ATA_EH_RESET_MASK to ATA_EH_RESET and use it whereever
ATA_EH_{SOFT|HARD}RESET used to be used. ATA_EH_{SOFT|HARD}RESET is
now only used to tell prereset whether soft or hard reset will be
issued.
* Strip out now unneeded promote-to-hardreset logics from
ata_eh_reset(), ata_std_prereset(), sata_pmp_std_prereset() and
other places.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-01-23 18:05:14 +03:00
|
|
|
[PORT_CERR_CMD_TGTABRT] = { AC_ERR_HOST_BUS, ATA_EH_RESET,
|
2006-05-15 15:58:32 +04:00
|
|
|
"PCI target abort while fetching PRB" },
|
libata: prefer hardreset
When both soft and hard resets are available, libata preferred
softreset till now. The logic behind it was to be softer to devices;
however, this doesn't really help much. Rationales for the change:
* BIOS may freeze lock certain things during boot and softreset can't
unlock those. This by itself is okay but during operation PHY event
or other error conditions can trigger hardreset and the device may
end up with different configuration.
For example, after a hardreset, previously unlockable HPA can be
unlocked resulting in different device size and thus revalidation
failure. Similar condition can occur during or after resume.
* Certain ATAPI devices require hardreset to recover after certain
error conditions. On PATA, this is done by issuing the DEVICE RESET
command. On SATA, COMRESET has equivalent effect. The problem is
that DEVICE RESET needs its own execution protocol.
For SFF controllers with bare TF access, it can be easily
implemented but more advanced controllers (e.g. ahci and sata_sil24)
require specialized implementations. Simply using hardreset solves
the problem nicely.
* COMRESET initialization sequence is the norm in SATA land and many
SATA devices don't work properly if only SRST is used. For example,
some PMPs behave this way and libata works around by always issuing
hardreset if the host supports PMP.
Like the above example, libata has developed a number of mechanisms
aiming to promote softreset to hardreset if softreset is not going
to work. This approach is time consuming and error prone.
Also, note that, dependingon how you read the specs, it could be
argued that PMP fan-out ports require COMRESET to start operation.
In fact, all the PMPs on the market except one don't work properly
if COMRESET is not issued to fan-out ports after PMP reset.
* COMRESET is an integral part of SATA connection and any working
device should be able to handle COMRESET properly. After all, it's
the way to signal hardreset during reboot. This is the most used
and recommended (at least by the ahci spec) method of resetting
devices.
So, this patch makes libata prefer hardreset over softreset by making
the following changes.
* Rename ATA_EH_RESET_MASK to ATA_EH_RESET and use it whereever
ATA_EH_{SOFT|HARD}RESET used to be used. ATA_EH_{SOFT|HARD}RESET is
now only used to tell prereset whether soft or hard reset will be
issued.
* Strip out now unneeded promote-to-hardreset logics from
ata_eh_reset(), ata_std_prereset(), sata_pmp_std_prereset() and
other places.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-01-23 18:05:14 +03:00
|
|
|
[PORT_CERR_CMD_MSTABRT] = { AC_ERR_HOST_BUS, ATA_EH_RESET,
|
2006-05-15 15:58:32 +04:00
|
|
|
"PCI master abort while fetching PRB" },
|
libata: prefer hardreset
When both soft and hard resets are available, libata preferred
softreset till now. The logic behind it was to be softer to devices;
however, this doesn't really help much. Rationales for the change:
* BIOS may freeze lock certain things during boot and softreset can't
unlock those. This by itself is okay but during operation PHY event
or other error conditions can trigger hardreset and the device may
end up with different configuration.
For example, after a hardreset, previously unlockable HPA can be
unlocked resulting in different device size and thus revalidation
failure. Similar condition can occur during or after resume.
* Certain ATAPI devices require hardreset to recover after certain
error conditions. On PATA, this is done by issuing the DEVICE RESET
command. On SATA, COMRESET has equivalent effect. The problem is
that DEVICE RESET needs its own execution protocol.
For SFF controllers with bare TF access, it can be easily
implemented but more advanced controllers (e.g. ahci and sata_sil24)
require specialized implementations. Simply using hardreset solves
the problem nicely.
* COMRESET initialization sequence is the norm in SATA land and many
SATA devices don't work properly if only SRST is used. For example,
some PMPs behave this way and libata works around by always issuing
hardreset if the host supports PMP.
Like the above example, libata has developed a number of mechanisms
aiming to promote softreset to hardreset if softreset is not going
to work. This approach is time consuming and error prone.
Also, note that, dependingon how you read the specs, it could be
argued that PMP fan-out ports require COMRESET to start operation.
In fact, all the PMPs on the market except one don't work properly
if COMRESET is not issued to fan-out ports after PMP reset.
* COMRESET is an integral part of SATA connection and any working
device should be able to handle COMRESET properly. After all, it's
the way to signal hardreset during reboot. This is the most used
and recommended (at least by the ahci spec) method of resetting
devices.
So, this patch makes libata prefer hardreset over softreset by making
the following changes.
* Rename ATA_EH_RESET_MASK to ATA_EH_RESET and use it whereever
ATA_EH_{SOFT|HARD}RESET used to be used. ATA_EH_{SOFT|HARD}RESET is
now only used to tell prereset whether soft or hard reset will be
issued.
* Strip out now unneeded promote-to-hardreset logics from
ata_eh_reset(), ata_std_prereset(), sata_pmp_std_prereset() and
other places.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-01-23 18:05:14 +03:00
|
|
|
[PORT_CERR_CMD_PCIPERR] = { AC_ERR_HOST_BUS, ATA_EH_RESET,
|
2006-05-15 15:58:32 +04:00
|
|
|
"PCI parity error while fetching PRB" },
|
libata: prefer hardreset
When both soft and hard resets are available, libata preferred
softreset till now. The logic behind it was to be softer to devices;
however, this doesn't really help much. Rationales for the change:
* BIOS may freeze lock certain things during boot and softreset can't
unlock those. This by itself is okay but during operation PHY event
or other error conditions can trigger hardreset and the device may
end up with different configuration.
For example, after a hardreset, previously unlockable HPA can be
unlocked resulting in different device size and thus revalidation
failure. Similar condition can occur during or after resume.
* Certain ATAPI devices require hardreset to recover after certain
error conditions. On PATA, this is done by issuing the DEVICE RESET
command. On SATA, COMRESET has equivalent effect. The problem is
that DEVICE RESET needs its own execution protocol.
For SFF controllers with bare TF access, it can be easily
implemented but more advanced controllers (e.g. ahci and sata_sil24)
require specialized implementations. Simply using hardreset solves
the problem nicely.
* COMRESET initialization sequence is the norm in SATA land and many
SATA devices don't work properly if only SRST is used. For example,
some PMPs behave this way and libata works around by always issuing
hardreset if the host supports PMP.
Like the above example, libata has developed a number of mechanisms
aiming to promote softreset to hardreset if softreset is not going
to work. This approach is time consuming and error prone.
Also, note that, dependingon how you read the specs, it could be
argued that PMP fan-out ports require COMRESET to start operation.
In fact, all the PMPs on the market except one don't work properly
if COMRESET is not issued to fan-out ports after PMP reset.
* COMRESET is an integral part of SATA connection and any working
device should be able to handle COMRESET properly. After all, it's
the way to signal hardreset during reboot. This is the most used
and recommended (at least by the ahci spec) method of resetting
devices.
So, this patch makes libata prefer hardreset over softreset by making
the following changes.
* Rename ATA_EH_RESET_MASK to ATA_EH_RESET and use it whereever
ATA_EH_{SOFT|HARD}RESET used to be used. ATA_EH_{SOFT|HARD}RESET is
now only used to tell prereset whether soft or hard reset will be
issued.
* Strip out now unneeded promote-to-hardreset logics from
ata_eh_reset(), ata_std_prereset(), sata_pmp_std_prereset() and
other places.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-01-23 18:05:14 +03:00
|
|
|
[PORT_CERR_XFR_UNDEF] = { AC_ERR_HOST_BUS, ATA_EH_RESET,
|
2006-05-15 15:58:32 +04:00
|
|
|
"undefined error while transferring data" },
|
libata: prefer hardreset
When both soft and hard resets are available, libata preferred
softreset till now. The logic behind it was to be softer to devices;
however, this doesn't really help much. Rationales for the change:
* BIOS may freeze lock certain things during boot and softreset can't
unlock those. This by itself is okay but during operation PHY event
or other error conditions can trigger hardreset and the device may
end up with different configuration.
For example, after a hardreset, previously unlockable HPA can be
unlocked resulting in different device size and thus revalidation
failure. Similar condition can occur during or after resume.
* Certain ATAPI devices require hardreset to recover after certain
error conditions. On PATA, this is done by issuing the DEVICE RESET
command. On SATA, COMRESET has equivalent effect. The problem is
that DEVICE RESET needs its own execution protocol.
For SFF controllers with bare TF access, it can be easily
implemented but more advanced controllers (e.g. ahci and sata_sil24)
require specialized implementations. Simply using hardreset solves
the problem nicely.
* COMRESET initialization sequence is the norm in SATA land and many
SATA devices don't work properly if only SRST is used. For example,
some PMPs behave this way and libata works around by always issuing
hardreset if the host supports PMP.
Like the above example, libata has developed a number of mechanisms
aiming to promote softreset to hardreset if softreset is not going
to work. This approach is time consuming and error prone.
Also, note that, dependingon how you read the specs, it could be
argued that PMP fan-out ports require COMRESET to start operation.
In fact, all the PMPs on the market except one don't work properly
if COMRESET is not issued to fan-out ports after PMP reset.
* COMRESET is an integral part of SATA connection and any working
device should be able to handle COMRESET properly. After all, it's
the way to signal hardreset during reboot. This is the most used
and recommended (at least by the ahci spec) method of resetting
devices.
So, this patch makes libata prefer hardreset over softreset by making
the following changes.
* Rename ATA_EH_RESET_MASK to ATA_EH_RESET and use it whereever
ATA_EH_{SOFT|HARD}RESET used to be used. ATA_EH_{SOFT|HARD}RESET is
now only used to tell prereset whether soft or hard reset will be
issued.
* Strip out now unneeded promote-to-hardreset logics from
ata_eh_reset(), ata_std_prereset(), sata_pmp_std_prereset() and
other places.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-01-23 18:05:14 +03:00
|
|
|
[PORT_CERR_XFR_TGTABRT] = { AC_ERR_HOST_BUS, ATA_EH_RESET,
|
2006-05-15 15:58:32 +04:00
|
|
|
"PCI target abort while transferring data" },
|
libata: prefer hardreset
When both soft and hard resets are available, libata preferred
softreset till now. The logic behind it was to be softer to devices;
however, this doesn't really help much. Rationales for the change:
* BIOS may freeze lock certain things during boot and softreset can't
unlock those. This by itself is okay but during operation PHY event
or other error conditions can trigger hardreset and the device may
end up with different configuration.
For example, after a hardreset, previously unlockable HPA can be
unlocked resulting in different device size and thus revalidation
failure. Similar condition can occur during or after resume.
* Certain ATAPI devices require hardreset to recover after certain
error conditions. On PATA, this is done by issuing the DEVICE RESET
command. On SATA, COMRESET has equivalent effect. The problem is
that DEVICE RESET needs its own execution protocol.
For SFF controllers with bare TF access, it can be easily
implemented but more advanced controllers (e.g. ahci and sata_sil24)
require specialized implementations. Simply using hardreset solves
the problem nicely.
* COMRESET initialization sequence is the norm in SATA land and many
SATA devices don't work properly if only SRST is used. For example,
some PMPs behave this way and libata works around by always issuing
hardreset if the host supports PMP.
Like the above example, libata has developed a number of mechanisms
aiming to promote softreset to hardreset if softreset is not going
to work. This approach is time consuming and error prone.
Also, note that, dependingon how you read the specs, it could be
argued that PMP fan-out ports require COMRESET to start operation.
In fact, all the PMPs on the market except one don't work properly
if COMRESET is not issued to fan-out ports after PMP reset.
* COMRESET is an integral part of SATA connection and any working
device should be able to handle COMRESET properly. After all, it's
the way to signal hardreset during reboot. This is the most used
and recommended (at least by the ahci spec) method of resetting
devices.
So, this patch makes libata prefer hardreset over softreset by making
the following changes.
* Rename ATA_EH_RESET_MASK to ATA_EH_RESET and use it whereever
ATA_EH_{SOFT|HARD}RESET used to be used. ATA_EH_{SOFT|HARD}RESET is
now only used to tell prereset whether soft or hard reset will be
issued.
* Strip out now unneeded promote-to-hardreset logics from
ata_eh_reset(), ata_std_prereset(), sata_pmp_std_prereset() and
other places.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-01-23 18:05:14 +03:00
|
|
|
[PORT_CERR_XFR_MSTABRT] = { AC_ERR_HOST_BUS, ATA_EH_RESET,
|
2006-05-15 15:58:32 +04:00
|
|
|
"PCI master abort while transferring data" },
|
libata: prefer hardreset
When both soft and hard resets are available, libata preferred
softreset till now. The logic behind it was to be softer to devices;
however, this doesn't really help much. Rationales for the change:
* BIOS may freeze lock certain things during boot and softreset can't
unlock those. This by itself is okay but during operation PHY event
or other error conditions can trigger hardreset and the device may
end up with different configuration.
For example, after a hardreset, previously unlockable HPA can be
unlocked resulting in different device size and thus revalidation
failure. Similar condition can occur during or after resume.
* Certain ATAPI devices require hardreset to recover after certain
error conditions. On PATA, this is done by issuing the DEVICE RESET
command. On SATA, COMRESET has equivalent effect. The problem is
that DEVICE RESET needs its own execution protocol.
For SFF controllers with bare TF access, it can be easily
implemented but more advanced controllers (e.g. ahci and sata_sil24)
require specialized implementations. Simply using hardreset solves
the problem nicely.
* COMRESET initialization sequence is the norm in SATA land and many
SATA devices don't work properly if only SRST is used. For example,
some PMPs behave this way and libata works around by always issuing
hardreset if the host supports PMP.
Like the above example, libata has developed a number of mechanisms
aiming to promote softreset to hardreset if softreset is not going
to work. This approach is time consuming and error prone.
Also, note that, dependingon how you read the specs, it could be
argued that PMP fan-out ports require COMRESET to start operation.
In fact, all the PMPs on the market except one don't work properly
if COMRESET is not issued to fan-out ports after PMP reset.
* COMRESET is an integral part of SATA connection and any working
device should be able to handle COMRESET properly. After all, it's
the way to signal hardreset during reboot. This is the most used
and recommended (at least by the ahci spec) method of resetting
devices.
So, this patch makes libata prefer hardreset over softreset by making
the following changes.
* Rename ATA_EH_RESET_MASK to ATA_EH_RESET and use it whereever
ATA_EH_{SOFT|HARD}RESET used to be used. ATA_EH_{SOFT|HARD}RESET is
now only used to tell prereset whether soft or hard reset will be
issued.
* Strip out now unneeded promote-to-hardreset logics from
ata_eh_reset(), ata_std_prereset(), sata_pmp_std_prereset() and
other places.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-01-23 18:05:14 +03:00
|
|
|
[PORT_CERR_XFR_PCIPERR] = { AC_ERR_HOST_BUS, ATA_EH_RESET,
|
2006-05-15 15:58:32 +04:00
|
|
|
"PCI parity error while transferring data" },
|
libata: prefer hardreset
When both soft and hard resets are available, libata preferred
softreset till now. The logic behind it was to be softer to devices;
however, this doesn't really help much. Rationales for the change:
* BIOS may freeze lock certain things during boot and softreset can't
unlock those. This by itself is okay but during operation PHY event
or other error conditions can trigger hardreset and the device may
end up with different configuration.
For example, after a hardreset, previously unlockable HPA can be
unlocked resulting in different device size and thus revalidation
failure. Similar condition can occur during or after resume.
* Certain ATAPI devices require hardreset to recover after certain
error conditions. On PATA, this is done by issuing the DEVICE RESET
command. On SATA, COMRESET has equivalent effect. The problem is
that DEVICE RESET needs its own execution protocol.
For SFF controllers with bare TF access, it can be easily
implemented but more advanced controllers (e.g. ahci and sata_sil24)
require specialized implementations. Simply using hardreset solves
the problem nicely.
* COMRESET initialization sequence is the norm in SATA land and many
SATA devices don't work properly if only SRST is used. For example,
some PMPs behave this way and libata works around by always issuing
hardreset if the host supports PMP.
Like the above example, libata has developed a number of mechanisms
aiming to promote softreset to hardreset if softreset is not going
to work. This approach is time consuming and error prone.
Also, note that, dependingon how you read the specs, it could be
argued that PMP fan-out ports require COMRESET to start operation.
In fact, all the PMPs on the market except one don't work properly
if COMRESET is not issued to fan-out ports after PMP reset.
* COMRESET is an integral part of SATA connection and any working
device should be able to handle COMRESET properly. After all, it's
the way to signal hardreset during reboot. This is the most used
and recommended (at least by the ahci spec) method of resetting
devices.
So, this patch makes libata prefer hardreset over softreset by making
the following changes.
* Rename ATA_EH_RESET_MASK to ATA_EH_RESET and use it whereever
ATA_EH_{SOFT|HARD}RESET used to be used. ATA_EH_{SOFT|HARD}RESET is
now only used to tell prereset whether soft or hard reset will be
issued.
* Strip out now unneeded promote-to-hardreset logics from
ata_eh_reset(), ata_std_prereset(), sata_pmp_std_prereset() and
other places.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-01-23 18:05:14 +03:00
|
|
|
[PORT_CERR_SENDSERVICE] = { AC_ERR_HSM, ATA_EH_RESET,
|
2006-05-15 15:58:32 +04:00
|
|
|
"FIS received while sending service FIS" },
|
|
|
|
};
|
|
|
|
|
2005-07-28 05:36:22 +04:00
|
|
|
/*
|
|
|
|
* ap->private_data
|
|
|
|
*
|
|
|
|
* The preview driver always returned 0 for status. We emulate it
|
|
|
|
* here from the previous interrupt.
|
|
|
|
*/
|
|
|
|
struct sil24_port_priv {
|
2005-11-18 08:16:45 +03:00
|
|
|
union sil24_cmd_block *cmd_block; /* 32 cmd blocks */
|
2005-07-28 05:36:22 +04:00
|
|
|
dma_addr_t cmd_block_dma; /* DMA base addr for them */
|
2007-09-23 08:19:54 +04:00
|
|
|
int do_port_rst;
|
2005-07-28 05:36:22 +04:00
|
|
|
};
|
|
|
|
|
2007-03-02 03:56:15 +03:00
|
|
|
static void sil24_dev_config(struct ata_device *dev);
|
2008-07-31 12:02:40 +04:00
|
|
|
static int sil24_scr_read(struct ata_link *link, unsigned sc_reg, u32 *val);
|
|
|
|
static int sil24_scr_write(struct ata_link *link, unsigned sc_reg, u32 val);
|
2007-09-23 08:19:54 +04:00
|
|
|
static int sil24_qc_defer(struct ata_queued_cmd *qc);
|
2005-07-28 05:36:22 +04:00
|
|
|
static void sil24_qc_prep(struct ata_queued_cmd *qc);
|
2006-01-23 07:09:36 +03:00
|
|
|
static unsigned int sil24_qc_issue(struct ata_queued_cmd *qc);
|
2008-04-07 17:47:20 +04:00
|
|
|
static bool sil24_qc_fill_rtf(struct ata_queued_cmd *qc);
|
2007-09-23 08:19:54 +04:00
|
|
|
static void sil24_pmp_attach(struct ata_port *ap);
|
|
|
|
static void sil24_pmp_detach(struct ata_port *ap);
|
2006-05-15 15:58:32 +04:00
|
|
|
static void sil24_freeze(struct ata_port *ap);
|
|
|
|
static void sil24_thaw(struct ata_port *ap);
|
libata: make reset related methods proper port operations
Currently reset methods are not specified directly in the
ata_port_operations table. If a LLD wants to use custom reset
methods, it should construct and use a error_handler which uses those
reset methods. It's done this way for two reasons.
First, the ops table already contained too many methods and adding
four more of them would noticeably increase the amount of necessary
boilerplate code all over low level drivers.
Second, as ->error_handler uses those reset methods, it can get
confusing. ie. By overriding ->error_handler, those reset ops can be
made useless making layering a bit hazy.
Now that ops table uses inheritance, the first problem doesn't exist
anymore. The second isn't completely solved but is relieved by
providing default values - most drivers can just override what it has
implemented and don't have to concern itself about higher level
callbacks. In fact, there currently is no driver which actually
modifies error handling behavior. Drivers which override
->error_handler just wraps the standard error handler only to prepare
the controller for EH. I don't think making ops layering strict has
any noticeable benefit.
This patch makes ->prereset, ->softreset, ->hardreset, ->postreset and
their PMP counterparts propoer ops. Default ops are provided in the
base ops tables and drivers are converted to override individual reset
methods instead of creating custom error_handler.
* ata_std_error_handler() doesn't use sata_std_hardreset() if SCRs
aren't accessible. sata_promise doesn't need to use separate
error_handlers for PATA and SATA anymore.
* softreset is broken for sata_inic162x and sata_sx4. As libata now
always prefers hardreset, this doesn't really matter but the ops are
forced to NULL using ATA_OP_NULL for documentation purpose.
* pata_hpt374 needs to use different prereset for the first and second
PCI functions. This used to be done by branching from
hpt374_error_handler(). The proper way to do this is to use
separate ops and port_info tables for each function. Converted.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-03-25 06:22:50 +03:00
|
|
|
static int sil24_softreset(struct ata_link *link, unsigned int *class,
|
|
|
|
unsigned long deadline);
|
|
|
|
static int sil24_hardreset(struct ata_link *link, unsigned int *class,
|
|
|
|
unsigned long deadline);
|
|
|
|
static int sil24_pmp_hardreset(struct ata_link *link, unsigned int *class,
|
|
|
|
unsigned long deadline);
|
2006-05-15 15:58:32 +04:00
|
|
|
static void sil24_error_handler(struct ata_port *ap);
|
|
|
|
static void sil24_post_internal_cmd(struct ata_queued_cmd *qc);
|
2005-07-28 05:36:22 +04:00
|
|
|
static int sil24_port_start(struct ata_port *ap);
|
|
|
|
static int sil24_init_one(struct pci_dev *pdev, const struct pci_device_id *ent);
|
2014-05-07 19:17:44 +04:00
|
|
|
#ifdef CONFIG_PM_SLEEP
|
2006-07-03 11:07:27 +04:00
|
|
|
static int sil24_pci_device_resume(struct pci_dev *pdev);
|
2014-05-07 19:17:44 +04:00
|
|
|
#endif
|
|
|
|
#ifdef CONFIG_PM
|
2007-09-23 08:19:54 +04:00
|
|
|
static int sil24_port_resume(struct ata_port *ap);
|
2006-08-15 09:49:30 +04:00
|
|
|
#endif
|
2005-07-28 05:36:22 +04:00
|
|
|
|
2005-11-10 19:04:11 +03:00
|
|
|
static const struct pci_device_id sil24_pci_tbl[] = {
|
2006-09-28 06:20:11 +04:00
|
|
|
{ PCI_VDEVICE(CMD, 0x3124), BID_SIL3124 },
|
|
|
|
{ PCI_VDEVICE(INTEL, 0x3124), BID_SIL3124 },
|
|
|
|
{ PCI_VDEVICE(CMD, 0x3132), BID_SIL3132 },
|
2007-03-13 07:48:00 +03:00
|
|
|
{ PCI_VDEVICE(CMD, 0x0242), BID_SIL3132 },
|
2008-07-02 12:50:23 +04:00
|
|
|
{ PCI_VDEVICE(CMD, 0x0244), BID_SIL3132 },
|
2006-09-28 06:20:11 +04:00
|
|
|
{ PCI_VDEVICE(CMD, 0x3131), BID_SIL3131 },
|
|
|
|
{ PCI_VDEVICE(CMD, 0x3531), BID_SIL3131 },
|
|
|
|
|
2005-10-09 17:31:33 +04:00
|
|
|
{ } /* terminate list */
|
2005-07-28 05:36:22 +04:00
|
|
|
};
|
|
|
|
|
|
|
|
static struct pci_driver sil24_pci_driver = {
|
|
|
|
.name = DRV_NAME,
|
|
|
|
.id_table = sil24_pci_tbl,
|
|
|
|
.probe = sil24_init_one,
|
2007-01-20 10:00:28 +03:00
|
|
|
.remove = ata_pci_remove_one,
|
2014-05-07 19:17:44 +04:00
|
|
|
#ifdef CONFIG_PM_SLEEP
|
2006-07-03 11:07:27 +04:00
|
|
|
.suspend = ata_pci_device_suspend,
|
|
|
|
.resume = sil24_pci_device_resume,
|
2006-08-15 09:49:30 +04:00
|
|
|
#endif
|
2005-07-28 05:36:22 +04:00
|
|
|
};
|
|
|
|
|
2005-11-07 08:59:37 +03:00
|
|
|
static struct scsi_host_template sil24_sht = {
|
2008-03-25 06:22:49 +03:00
|
|
|
ATA_NCQ_SHT(DRV_NAME),
|
2006-05-15 16:03:56 +04:00
|
|
|
.can_queue = SIL24_MAX_CMDS,
|
2007-11-22 12:46:57 +03:00
|
|
|
.sg_tablesize = SIL24_MAX_SGE,
|
2005-07-28 05:36:22 +04:00
|
|
|
.dma_boundary = ATA_DMA_BOUNDARY,
|
2015-01-24 07:17:59 +03:00
|
|
|
.tag_alloc_policy = BLK_TAG_ALLOC_FIFO,
|
2005-07-28 05:36:22 +04:00
|
|
|
};
|
|
|
|
|
libata: implement and use ops inheritance
libata lets low level drivers build ata_port_operations table and
register it with libata core layer. This allows low level drivers
high level of flexibility but also burdens them with lots of
boilerplate entries.
This becomes worse for drivers which support related similar
controllers which differ slightly. They share most of the operations
except for a few. However, the driver still needs to list all
operations for each variant. This results in large number of
duplicate entries, which is not only inefficient but also error-prone
as it becomes very difficult to tell what the actual differences are.
This duplicate boilerplates all over the low level drivers also make
updating the core layer exteremely difficult and error-prone. When
compounded with multi-branched development model, it ends up
accumulating inconsistencies over time. Some of those inconsistencies
cause immediate problems and fixed. Others just remain there dormant
making maintenance increasingly difficult.
To rectify the problem, this patch implements ata_port_operations
inheritance. To allow LLDs to easily re-use their own ops tables
overriding only specific methods, this patch implements poor man's
class inheritance. An ops table has ->inherits field which can be set
to any ops table as long as it doesn't create a loop. When the host
is started, the inheritance chain is followed and any operation which
isn't specified is taken from the nearest ancestor which has it
specified. This operation is called finalization and done only once
per an ops table and the LLD doesn't have to do anything special about
it other than making the ops table non-const such that libata can
update it.
libata provides four base ops tables lower drivers can inherit from -
base, sata, pmp, sff and bmdma. To avoid overriding these ops
accidentaly, these ops are declared const and LLDs should always
inherit these instead of using them directly.
After finalization, all the ops table are identical before and after
the patch except for setting .irq_handler to ata_interrupt in drivers
which didn't use to. The .irq_handler doesn't have any actual effect
and the field will soon be removed by later patch.
* sata_sx4 is still using old style EH and currently doesn't take
advantage of ops inheritance.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-03-25 06:22:49 +03:00
|
|
|
static struct ata_port_operations sil24_ops = {
|
|
|
|
.inherits = &sata_pmp_port_ops,
|
2005-11-18 08:16:45 +03:00
|
|
|
|
2007-09-23 08:19:54 +04:00
|
|
|
.qc_defer = sil24_qc_defer,
|
2005-07-28 05:36:22 +04:00
|
|
|
.qc_prep = sil24_qc_prep,
|
|
|
|
.qc_issue = sil24_qc_issue,
|
2008-04-07 17:47:20 +04:00
|
|
|
.qc_fill_rtf = sil24_qc_fill_rtf,
|
2005-07-28 05:36:22 +04:00
|
|
|
|
libata: implement and use ops inheritance
libata lets low level drivers build ata_port_operations table and
register it with libata core layer. This allows low level drivers
high level of flexibility but also burdens them with lots of
boilerplate entries.
This becomes worse for drivers which support related similar
controllers which differ slightly. They share most of the operations
except for a few. However, the driver still needs to list all
operations for each variant. This results in large number of
duplicate entries, which is not only inefficient but also error-prone
as it becomes very difficult to tell what the actual differences are.
This duplicate boilerplates all over the low level drivers also make
updating the core layer exteremely difficult and error-prone. When
compounded with multi-branched development model, it ends up
accumulating inconsistencies over time. Some of those inconsistencies
cause immediate problems and fixed. Others just remain there dormant
making maintenance increasingly difficult.
To rectify the problem, this patch implements ata_port_operations
inheritance. To allow LLDs to easily re-use their own ops tables
overriding only specific methods, this patch implements poor man's
class inheritance. An ops table has ->inherits field which can be set
to any ops table as long as it doesn't create a loop. When the host
is started, the inheritance chain is followed and any operation which
isn't specified is taken from the nearest ancestor which has it
specified. This operation is called finalization and done only once
per an ops table and the LLD doesn't have to do anything special about
it other than making the ops table non-const such that libata can
update it.
libata provides four base ops tables lower drivers can inherit from -
base, sata, pmp, sff and bmdma. To avoid overriding these ops
accidentaly, these ops are declared const and LLDs should always
inherit these instead of using them directly.
After finalization, all the ops table are identical before and after
the patch except for setting .irq_handler to ata_interrupt in drivers
which didn't use to. The .irq_handler doesn't have any actual effect
and the field will soon be removed by later patch.
* sata_sx4 is still using old style EH and currently doesn't take
advantage of ops inheritance.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-03-25 06:22:49 +03:00
|
|
|
.freeze = sil24_freeze,
|
|
|
|
.thaw = sil24_thaw,
|
libata: make reset related methods proper port operations
Currently reset methods are not specified directly in the
ata_port_operations table. If a LLD wants to use custom reset
methods, it should construct and use a error_handler which uses those
reset methods. It's done this way for two reasons.
First, the ops table already contained too many methods and adding
four more of them would noticeably increase the amount of necessary
boilerplate code all over low level drivers.
Second, as ->error_handler uses those reset methods, it can get
confusing. ie. By overriding ->error_handler, those reset ops can be
made useless making layering a bit hazy.
Now that ops table uses inheritance, the first problem doesn't exist
anymore. The second isn't completely solved but is relieved by
providing default values - most drivers can just override what it has
implemented and don't have to concern itself about higher level
callbacks. In fact, there currently is no driver which actually
modifies error handling behavior. Drivers which override
->error_handler just wraps the standard error handler only to prepare
the controller for EH. I don't think making ops layering strict has
any noticeable benefit.
This patch makes ->prereset, ->softreset, ->hardreset, ->postreset and
their PMP counterparts propoer ops. Default ops are provided in the
base ops tables and drivers are converted to override individual reset
methods instead of creating custom error_handler.
* ata_std_error_handler() doesn't use sata_std_hardreset() if SCRs
aren't accessible. sata_promise doesn't need to use separate
error_handlers for PATA and SATA anymore.
* softreset is broken for sata_inic162x and sata_sx4. As libata now
always prefers hardreset, this doesn't really matter but the ops are
forced to NULL using ATA_OP_NULL for documentation purpose.
* pata_hpt374 needs to use different prereset for the first and second
PCI functions. This used to be done by branching from
hpt374_error_handler(). The proper way to do this is to use
separate ops and port_info tables for each function. Converted.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-03-25 06:22:50 +03:00
|
|
|
.softreset = sil24_softreset,
|
|
|
|
.hardreset = sil24_hardreset,
|
2008-04-07 17:47:22 +04:00
|
|
|
.pmp_softreset = sil24_softreset,
|
libata: make reset related methods proper port operations
Currently reset methods are not specified directly in the
ata_port_operations table. If a LLD wants to use custom reset
methods, it should construct and use a error_handler which uses those
reset methods. It's done this way for two reasons.
First, the ops table already contained too many methods and adding
four more of them would noticeably increase the amount of necessary
boilerplate code all over low level drivers.
Second, as ->error_handler uses those reset methods, it can get
confusing. ie. By overriding ->error_handler, those reset ops can be
made useless making layering a bit hazy.
Now that ops table uses inheritance, the first problem doesn't exist
anymore. The second isn't completely solved but is relieved by
providing default values - most drivers can just override what it has
implemented and don't have to concern itself about higher level
callbacks. In fact, there currently is no driver which actually
modifies error handling behavior. Drivers which override
->error_handler just wraps the standard error handler only to prepare
the controller for EH. I don't think making ops layering strict has
any noticeable benefit.
This patch makes ->prereset, ->softreset, ->hardreset, ->postreset and
their PMP counterparts propoer ops. Default ops are provided in the
base ops tables and drivers are converted to override individual reset
methods instead of creating custom error_handler.
* ata_std_error_handler() doesn't use sata_std_hardreset() if SCRs
aren't accessible. sata_promise doesn't need to use separate
error_handlers for PATA and SATA anymore.
* softreset is broken for sata_inic162x and sata_sx4. As libata now
always prefers hardreset, this doesn't really matter but the ops are
forced to NULL using ATA_OP_NULL for documentation purpose.
* pata_hpt374 needs to use different prereset for the first and second
PCI functions. This used to be done by branching from
hpt374_error_handler(). The proper way to do this is to use
separate ops and port_info tables for each function. Converted.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-03-25 06:22:50 +03:00
|
|
|
.pmp_hardreset = sil24_pmp_hardreset,
|
libata: implement and use ops inheritance
libata lets low level drivers build ata_port_operations table and
register it with libata core layer. This allows low level drivers
high level of flexibility but also burdens them with lots of
boilerplate entries.
This becomes worse for drivers which support related similar
controllers which differ slightly. They share most of the operations
except for a few. However, the driver still needs to list all
operations for each variant. This results in large number of
duplicate entries, which is not only inefficient but also error-prone
as it becomes very difficult to tell what the actual differences are.
This duplicate boilerplates all over the low level drivers also make
updating the core layer exteremely difficult and error-prone. When
compounded with multi-branched development model, it ends up
accumulating inconsistencies over time. Some of those inconsistencies
cause immediate problems and fixed. Others just remain there dormant
making maintenance increasingly difficult.
To rectify the problem, this patch implements ata_port_operations
inheritance. To allow LLDs to easily re-use their own ops tables
overriding only specific methods, this patch implements poor man's
class inheritance. An ops table has ->inherits field which can be set
to any ops table as long as it doesn't create a loop. When the host
is started, the inheritance chain is followed and any operation which
isn't specified is taken from the nearest ancestor which has it
specified. This operation is called finalization and done only once
per an ops table and the LLD doesn't have to do anything special about
it other than making the ops table non-const such that libata can
update it.
libata provides four base ops tables lower drivers can inherit from -
base, sata, pmp, sff and bmdma. To avoid overriding these ops
accidentaly, these ops are declared const and LLDs should always
inherit these instead of using them directly.
After finalization, all the ops table are identical before and after
the patch except for setting .irq_handler to ata_interrupt in drivers
which didn't use to. The .irq_handler doesn't have any actual effect
and the field will soon be removed by later patch.
* sata_sx4 is still using old style EH and currently doesn't take
advantage of ops inheritance.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-03-25 06:22:49 +03:00
|
|
|
.error_handler = sil24_error_handler,
|
|
|
|
.post_internal_cmd = sil24_post_internal_cmd,
|
|
|
|
.dev_config = sil24_dev_config,
|
2005-07-28 05:36:22 +04:00
|
|
|
|
|
|
|
.scr_read = sil24_scr_read,
|
|
|
|
.scr_write = sil24_scr_write,
|
2007-09-23 08:19:54 +04:00
|
|
|
.pmp_attach = sil24_pmp_attach,
|
|
|
|
.pmp_detach = sil24_pmp_detach,
|
|
|
|
|
2005-07-28 05:36:22 +04:00
|
|
|
.port_start = sil24_port_start,
|
2007-09-23 08:19:54 +04:00
|
|
|
#ifdef CONFIG_PM
|
|
|
|
.port_resume = sil24_port_resume,
|
|
|
|
#endif
|
2005-07-28 05:36:22 +04:00
|
|
|
};
|
|
|
|
|
2012-01-13 03:02:20 +04:00
|
|
|
static bool sata_sil24_msi; /* Disable MSI */
|
2009-11-16 09:19:22 +03:00
|
|
|
module_param_named(msi, sata_sil24_msi, bool, S_IRUGO);
|
|
|
|
MODULE_PARM_DESC(msi, "Enable MSI (Default: false)");
|
|
|
|
|
2005-10-09 17:35:46 +04:00
|
|
|
/*
|
2006-08-24 11:19:22 +04:00
|
|
|
* Use bits 30-31 of port_flags to encode available port numbers.
|
2005-10-09 17:35:46 +04:00
|
|
|
* Current maxium is 4.
|
|
|
|
*/
|
|
|
|
#define SIL24_NPORTS2FLAG(nports) ((((unsigned)(nports) - 1) & 0x3) << 30)
|
|
|
|
#define SIL24_FLAG2NPORTS(flag) ((((flag) >> 30) & 0x3) + 1)
|
|
|
|
|
libata: convert the remaining SATA drivers to new init model
Convert ahci, sata_sil, sata_sil24, sata_svw, sata_qstor, sata_mv,
sata_sx4, sata_vsc and sata_inic162x to new init model.
Now that host and ap are available during intialization, functions are
converted to take either host or ap instead of low level parameters
which were inevitable for functions shared between init and other
paths. This simplifies code quite a bit.
* init_one()'s now follow more consistent init order
* ahci_setup_port() and ahci_host_init() collapsed into
ahci_init_one() for init order consistency
* sata_vsc uses port_info instead of setting fields manually
* in sata_svw, k2_board_info converted to port_info (info is now in
port flags). port number is honored now.
Tested on ICH7/8 AHCI, jmb360, sil3112, 3114, 3124 and 3132.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
2007-04-17 18:44:08 +04:00
|
|
|
static const struct ata_port_info sil24_port_info[] = {
|
2005-07-28 05:36:22 +04:00
|
|
|
/* sil_3124 */
|
|
|
|
{
|
2006-08-24 11:19:22 +04:00
|
|
|
.flags = SIL24_COMMON_FLAGS | SIL24_NPORTS2FLAG(4) |
|
2006-04-11 17:32:19 +04:00
|
|
|
SIL24_FLAG_PCIX_IRQ_WOC,
|
2009-03-14 23:38:24 +03:00
|
|
|
.pio_mask = ATA_PIO4,
|
|
|
|
.mwdma_mask = ATA_MWDMA2,
|
|
|
|
.udma_mask = ATA_UDMA5,
|
2005-07-28 05:36:22 +04:00
|
|
|
.port_ops = &sil24_ops,
|
|
|
|
},
|
2006-03-24 17:56:57 +03:00
|
|
|
/* sil_3132 */
|
2005-07-28 05:36:22 +04:00
|
|
|
{
|
2006-08-24 11:19:22 +04:00
|
|
|
.flags = SIL24_COMMON_FLAGS | SIL24_NPORTS2FLAG(2),
|
2009-03-14 23:38:24 +03:00
|
|
|
.pio_mask = ATA_PIO4,
|
|
|
|
.mwdma_mask = ATA_MWDMA2,
|
|
|
|
.udma_mask = ATA_UDMA5,
|
2005-10-09 17:35:46 +04:00
|
|
|
.port_ops = &sil24_ops,
|
|
|
|
},
|
|
|
|
/* sil_3131/sil_3531 */
|
|
|
|
{
|
2006-08-24 11:19:22 +04:00
|
|
|
.flags = SIL24_COMMON_FLAGS | SIL24_NPORTS2FLAG(1),
|
2009-03-14 23:38:24 +03:00
|
|
|
.pio_mask = ATA_PIO4,
|
|
|
|
.mwdma_mask = ATA_MWDMA2,
|
|
|
|
.udma_mask = ATA_UDMA5,
|
2005-07-28 05:36:22 +04:00
|
|
|
.port_ops = &sil24_ops,
|
|
|
|
},
|
|
|
|
};
|
|
|
|
|
2006-05-15 16:03:56 +04:00
|
|
|
static int sil24_tag(int tag)
|
|
|
|
{
|
|
|
|
if (unlikely(ata_tag_internal(tag)))
|
|
|
|
return 0;
|
|
|
|
return tag;
|
|
|
|
}
|
|
|
|
|
2008-04-07 17:47:21 +04:00
|
|
|
static unsigned long sil24_port_offset(struct ata_port *ap)
|
|
|
|
{
|
|
|
|
return ap->port_no * PORT_REGS_SIZE;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void __iomem *sil24_port_base(struct ata_port *ap)
|
|
|
|
{
|
|
|
|
return ap->host->iomap[SIL24_PORT_BAR] + sil24_port_offset(ap);
|
|
|
|
}
|
|
|
|
|
2007-03-02 03:56:15 +03:00
|
|
|
static void sil24_dev_config(struct ata_device *dev)
|
2005-11-18 08:16:45 +03:00
|
|
|
{
|
2008-04-07 17:47:21 +04:00
|
|
|
void __iomem *port = sil24_port_base(dev->link->ap);
|
2005-11-18 08:16:45 +03:00
|
|
|
|
2006-02-12 17:32:58 +03:00
|
|
|
if (dev->cdb_len == 16)
|
2005-11-18 08:16:45 +03:00
|
|
|
writel(PORT_CS_CDB16, port + PORT_CTRL_STAT);
|
|
|
|
else
|
|
|
|
writel(PORT_CS_CDB16, port + PORT_CTRL_CLR);
|
|
|
|
}
|
|
|
|
|
2007-07-16 09:29:39 +04:00
|
|
|
static void sil24_read_tf(struct ata_port *ap, int tag, struct ata_taskfile *tf)
|
2005-10-06 06:43:39 +04:00
|
|
|
{
|
2008-04-07 17:47:21 +04:00
|
|
|
void __iomem *port = sil24_port_base(ap);
|
2007-07-16 09:29:39 +04:00
|
|
|
struct sil24_prb __iomem *prb;
|
2005-10-29 09:38:44 +04:00
|
|
|
u8 fis[6 * 4];
|
2005-10-06 06:43:39 +04:00
|
|
|
|
2007-07-16 09:29:39 +04:00
|
|
|
prb = port + PORT_LRAM + sil24_tag(tag) * PORT_LRAM_SLOT_SZ;
|
|
|
|
memcpy_fromio(fis, prb->fis, sizeof(fis));
|
|
|
|
ata_tf_from_fis(fis, tf);
|
2005-10-06 06:43:39 +04:00
|
|
|
}
|
|
|
|
|
2005-07-28 05:36:22 +04:00
|
|
|
static int sil24_scr_map[] = {
|
|
|
|
[SCR_CONTROL] = 0,
|
|
|
|
[SCR_STATUS] = 1,
|
|
|
|
[SCR_ERROR] = 2,
|
|
|
|
[SCR_ACTIVE] = 3,
|
|
|
|
};
|
|
|
|
|
2008-07-31 12:02:40 +04:00
|
|
|
static int sil24_scr_read(struct ata_link *link, unsigned sc_reg, u32 *val)
|
2005-07-28 05:36:22 +04:00
|
|
|
{
|
2008-07-31 12:02:40 +04:00
|
|
|
void __iomem *scr_addr = sil24_port_base(link->ap) + PORT_SCONTROL;
|
2007-07-16 09:29:40 +04:00
|
|
|
|
2005-07-28 05:36:22 +04:00
|
|
|
if (sc_reg < ARRAY_SIZE(sil24_scr_map)) {
|
2007-07-16 09:29:40 +04:00
|
|
|
*val = readl(scr_addr + sil24_scr_map[sc_reg] * 4);
|
|
|
|
return 0;
|
2005-07-28 05:36:22 +04:00
|
|
|
}
|
2007-07-16 09:29:40 +04:00
|
|
|
return -EINVAL;
|
2005-07-28 05:36:22 +04:00
|
|
|
}
|
|
|
|
|
2008-07-31 12:02:40 +04:00
|
|
|
static int sil24_scr_write(struct ata_link *link, unsigned sc_reg, u32 val)
|
2005-07-28 05:36:22 +04:00
|
|
|
{
|
2008-07-31 12:02:40 +04:00
|
|
|
void __iomem *scr_addr = sil24_port_base(link->ap) + PORT_SCONTROL;
|
2007-07-16 09:29:40 +04:00
|
|
|
|
2005-07-28 05:36:22 +04:00
|
|
|
if (sc_reg < ARRAY_SIZE(sil24_scr_map)) {
|
|
|
|
writel(val, scr_addr + sil24_scr_map[sc_reg] * 4);
|
2007-07-16 09:29:40 +04:00
|
|
|
return 0;
|
2005-07-28 05:36:22 +04:00
|
|
|
}
|
2007-07-16 09:29:40 +04:00
|
|
|
return -EINVAL;
|
2005-07-28 05:36:22 +04:00
|
|
|
}
|
|
|
|
|
2007-09-23 08:19:54 +04:00
|
|
|
static void sil24_config_port(struct ata_port *ap)
|
|
|
|
{
|
2008-04-07 17:47:21 +04:00
|
|
|
void __iomem *port = sil24_port_base(ap);
|
2007-09-23 08:19:54 +04:00
|
|
|
|
|
|
|
/* configure IRQ WoC */
|
|
|
|
if (ap->flags & SIL24_FLAG_PCIX_IRQ_WOC)
|
|
|
|
writel(PORT_CS_IRQ_WOC, port + PORT_CTRL_STAT);
|
|
|
|
else
|
|
|
|
writel(PORT_CS_IRQ_WOC, port + PORT_CTRL_CLR);
|
|
|
|
|
|
|
|
/* zero error counters. */
|
2010-06-04 18:19:51 +04:00
|
|
|
writew(0x8000, port + PORT_DECODE_ERR_THRESH);
|
|
|
|
writew(0x8000, port + PORT_CRC_ERR_THRESH);
|
|
|
|
writew(0x8000, port + PORT_HSHK_ERR_THRESH);
|
|
|
|
writew(0x0000, port + PORT_DECODE_ERR_CNT);
|
|
|
|
writew(0x0000, port + PORT_CRC_ERR_CNT);
|
|
|
|
writew(0x0000, port + PORT_HSHK_ERR_CNT);
|
2007-09-23 08:19:54 +04:00
|
|
|
|
|
|
|
/* always use 64bit activation */
|
|
|
|
writel(PORT_CS_32BIT_ACTV, port + PORT_CTRL_CLR);
|
|
|
|
|
|
|
|
/* clear port multiplier enable and resume bits */
|
|
|
|
writel(PORT_CS_PMP_EN | PORT_CS_PMP_RESUME, port + PORT_CTRL_CLR);
|
|
|
|
}
|
|
|
|
|
2007-09-23 08:19:54 +04:00
|
|
|
static void sil24_config_pmp(struct ata_port *ap, int attached)
|
|
|
|
{
|
2008-04-07 17:47:21 +04:00
|
|
|
void __iomem *port = sil24_port_base(ap);
|
2007-09-23 08:19:54 +04:00
|
|
|
|
|
|
|
if (attached)
|
|
|
|
writel(PORT_CS_PMP_EN, port + PORT_CTRL_STAT);
|
|
|
|
else
|
|
|
|
writel(PORT_CS_PMP_EN, port + PORT_CTRL_CLR);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void sil24_clear_pmp(struct ata_port *ap)
|
|
|
|
{
|
2008-04-07 17:47:21 +04:00
|
|
|
void __iomem *port = sil24_port_base(ap);
|
2007-09-23 08:19:54 +04:00
|
|
|
int i;
|
|
|
|
|
|
|
|
writel(PORT_CS_PMP_RESUME, port + PORT_CTRL_CLR);
|
|
|
|
|
|
|
|
for (i = 0; i < SATA_PMP_MAX_PORTS; i++) {
|
|
|
|
void __iomem *pmp_base = port + PORT_PMP + i * PORT_PMP_SIZE;
|
|
|
|
|
|
|
|
writel(0, pmp_base + PORT_PMP_STATUS);
|
|
|
|
writel(0, pmp_base + PORT_PMP_QACTIVE);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2006-04-11 17:32:19 +04:00
|
|
|
static int sil24_init_port(struct ata_port *ap)
|
|
|
|
{
|
2008-04-07 17:47:21 +04:00
|
|
|
void __iomem *port = sil24_port_base(ap);
|
2007-09-23 08:19:54 +04:00
|
|
|
struct sil24_port_priv *pp = ap->private_data;
|
2006-04-11 17:32:19 +04:00
|
|
|
u32 tmp;
|
|
|
|
|
2007-09-23 08:19:54 +04:00
|
|
|
/* clear PMP error status */
|
2008-04-07 17:47:22 +04:00
|
|
|
if (sata_pmp_attached(ap))
|
2007-09-23 08:19:54 +04:00
|
|
|
sil24_clear_pmp(ap);
|
|
|
|
|
2006-04-11 17:32:19 +04:00
|
|
|
writel(PORT_CS_INIT, port + PORT_CTRL_STAT);
|
2010-09-06 19:56:29 +04:00
|
|
|
ata_wait_register(ap, port + PORT_CTRL_STAT,
|
2006-04-11 17:32:19 +04:00
|
|
|
PORT_CS_INIT, PORT_CS_INIT, 10, 100);
|
2010-09-06 19:56:29 +04:00
|
|
|
tmp = ata_wait_register(ap, port + PORT_CTRL_STAT,
|
2006-04-11 17:32:19 +04:00
|
|
|
PORT_CS_RDY, 0, 10, 100);
|
|
|
|
|
2007-09-23 08:19:54 +04:00
|
|
|
if ((tmp & (PORT_CS_INIT | PORT_CS_RDY)) != PORT_CS_RDY) {
|
|
|
|
pp->do_port_rst = 1;
|
libata: prefer hardreset
When both soft and hard resets are available, libata preferred
softreset till now. The logic behind it was to be softer to devices;
however, this doesn't really help much. Rationales for the change:
* BIOS may freeze lock certain things during boot and softreset can't
unlock those. This by itself is okay but during operation PHY event
or other error conditions can trigger hardreset and the device may
end up with different configuration.
For example, after a hardreset, previously unlockable HPA can be
unlocked resulting in different device size and thus revalidation
failure. Similar condition can occur during or after resume.
* Certain ATAPI devices require hardreset to recover after certain
error conditions. On PATA, this is done by issuing the DEVICE RESET
command. On SATA, COMRESET has equivalent effect. The problem is
that DEVICE RESET needs its own execution protocol.
For SFF controllers with bare TF access, it can be easily
implemented but more advanced controllers (e.g. ahci and sata_sil24)
require specialized implementations. Simply using hardreset solves
the problem nicely.
* COMRESET initialization sequence is the norm in SATA land and many
SATA devices don't work properly if only SRST is used. For example,
some PMPs behave this way and libata works around by always issuing
hardreset if the host supports PMP.
Like the above example, libata has developed a number of mechanisms
aiming to promote softreset to hardreset if softreset is not going
to work. This approach is time consuming and error prone.
Also, note that, dependingon how you read the specs, it could be
argued that PMP fan-out ports require COMRESET to start operation.
In fact, all the PMPs on the market except one don't work properly
if COMRESET is not issued to fan-out ports after PMP reset.
* COMRESET is an integral part of SATA connection and any working
device should be able to handle COMRESET properly. After all, it's
the way to signal hardreset during reboot. This is the most used
and recommended (at least by the ahci spec) method of resetting
devices.
So, this patch makes libata prefer hardreset over softreset by making
the following changes.
* Rename ATA_EH_RESET_MASK to ATA_EH_RESET and use it whereever
ATA_EH_{SOFT|HARD}RESET used to be used. ATA_EH_{SOFT|HARD}RESET is
now only used to tell prereset whether soft or hard reset will be
issued.
* Strip out now unneeded promote-to-hardreset logics from
ata_eh_reset(), ata_std_prereset(), sata_pmp_std_prereset() and
other places.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-01-23 18:05:14 +03:00
|
|
|
ap->link.eh_context.i.action |= ATA_EH_RESET;
|
2006-04-11 17:32:19 +04:00
|
|
|
return -EIO;
|
2007-09-23 08:19:54 +04:00
|
|
|
}
|
|
|
|
|
2006-04-11 17:32:19 +04:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2007-07-16 09:29:39 +04:00
|
|
|
static int sil24_exec_polled_cmd(struct ata_port *ap, int pmp,
|
|
|
|
const struct ata_taskfile *tf,
|
|
|
|
int is_cmd, u32 ctrl,
|
|
|
|
unsigned long timeout_msec)
|
2005-07-28 05:36:22 +04:00
|
|
|
{
|
2008-04-07 17:47:21 +04:00
|
|
|
void __iomem *port = sil24_port_base(ap);
|
2005-11-18 08:14:01 +03:00
|
|
|
struct sil24_port_priv *pp = ap->private_data;
|
2005-11-18 08:16:45 +03:00
|
|
|
struct sil24_prb *prb = &pp->cmd_block[0].ata.prb;
|
2005-11-18 08:14:01 +03:00
|
|
|
dma_addr_t paddr = pp->cmd_block_dma;
|
2007-07-16 09:29:39 +04:00
|
|
|
u32 irq_enabled, irq_mask, irq_stat;
|
|
|
|
int rc;
|
|
|
|
|
|
|
|
prb->ctrl = cpu_to_le16(ctrl);
|
|
|
|
ata_tf_to_fis(tf, pmp, is_cmd, prb->fis);
|
|
|
|
|
|
|
|
/* temporarily plug completion and error interrupts */
|
|
|
|
irq_enabled = readl(port + PORT_IRQ_ENABLE_SET);
|
|
|
|
writel(PORT_IRQ_COMPLETE | PORT_IRQ_ERROR, port + PORT_IRQ_ENABLE_CLR);
|
|
|
|
|
2010-06-10 20:02:12 +04:00
|
|
|
/*
|
|
|
|
* The barrier is required to ensure that writes to cmd_block reach
|
|
|
|
* the memory before the write to PORT_CMD_ACTIVATE.
|
|
|
|
*/
|
|
|
|
wmb();
|
2007-07-16 09:29:39 +04:00
|
|
|
writel((u32)paddr, port + PORT_CMD_ACTIVATE);
|
|
|
|
writel((u64)paddr >> 32, port + PORT_CMD_ACTIVATE + 4);
|
|
|
|
|
|
|
|
irq_mask = (PORT_IRQ_COMPLETE | PORT_IRQ_ERROR) << PORT_IRQ_RAW_SHIFT;
|
2010-09-06 19:56:29 +04:00
|
|
|
irq_stat = ata_wait_register(ap, port + PORT_IRQ_STAT, irq_mask, 0x0,
|
2007-07-16 09:29:39 +04:00
|
|
|
10, timeout_msec);
|
|
|
|
|
|
|
|
writel(irq_mask, port + PORT_IRQ_STAT); /* clear IRQs */
|
|
|
|
irq_stat >>= PORT_IRQ_RAW_SHIFT;
|
|
|
|
|
|
|
|
if (irq_stat & PORT_IRQ_COMPLETE)
|
|
|
|
rc = 0;
|
|
|
|
else {
|
|
|
|
/* force port into known state */
|
|
|
|
sil24_init_port(ap);
|
|
|
|
|
|
|
|
if (irq_stat & PORT_IRQ_ERROR)
|
|
|
|
rc = -EIO;
|
|
|
|
else
|
|
|
|
rc = -EBUSY;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* restore IRQ enabled */
|
|
|
|
writel(irq_enabled, port + PORT_IRQ_ENABLE_SET);
|
|
|
|
|
|
|
|
return rc;
|
|
|
|
}
|
|
|
|
|
2008-04-07 17:47:22 +04:00
|
|
|
static int sil24_softreset(struct ata_link *link, unsigned int *class,
|
|
|
|
unsigned long deadline)
|
2007-07-16 09:29:39 +04:00
|
|
|
{
|
2007-08-06 13:36:23 +04:00
|
|
|
struct ata_port *ap = link->ap;
|
2008-04-07 17:47:22 +04:00
|
|
|
int pmp = sata_srst_pmp(link);
|
2007-07-16 09:29:39 +04:00
|
|
|
unsigned long timeout_msec = 0;
|
2007-07-16 09:29:39 +04:00
|
|
|
struct ata_taskfile tf;
|
2006-04-11 17:22:29 +04:00
|
|
|
const char *reason;
|
2007-07-16 09:29:39 +04:00
|
|
|
int rc;
|
2005-11-18 08:14:01 +03:00
|
|
|
|
2006-02-10 17:58:48 +03:00
|
|
|
DPRINTK("ENTER\n");
|
|
|
|
|
2006-04-11 17:32:19 +04:00
|
|
|
/* put the port into known state */
|
|
|
|
if (sil24_init_port(ap)) {
|
2007-10-26 08:03:37 +04:00
|
|
|
reason = "port not ready";
|
2006-04-11 17:32:19 +04:00
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
|
2006-04-11 17:32:19 +04:00
|
|
|
/* do SRST */
|
2007-07-16 09:29:39 +04:00
|
|
|
if (time_after(deadline, jiffies))
|
|
|
|
timeout_msec = jiffies_to_msecs(deadline - jiffies);
|
2005-11-18 08:14:01 +03:00
|
|
|
|
2007-08-06 13:36:23 +04:00
|
|
|
ata_tf_init(link->device, &tf); /* doesn't really matter */
|
2007-07-16 09:29:39 +04:00
|
|
|
rc = sil24_exec_polled_cmd(ap, pmp, &tf, 0, PRB_CTRL_SRST,
|
|
|
|
timeout_msec);
|
2007-07-16 09:29:39 +04:00
|
|
|
if (rc == -EBUSY) {
|
|
|
|
reason = "timeout";
|
|
|
|
goto err;
|
|
|
|
} else if (rc) {
|
|
|
|
reason = "SRST command error";
|
2006-04-11 17:22:29 +04:00
|
|
|
goto err;
|
2006-02-10 17:58:48 +03:00
|
|
|
}
|
2006-03-11 05:42:34 +03:00
|
|
|
|
2007-07-16 09:29:39 +04:00
|
|
|
sil24_read_tf(ap, 0, &tf);
|
|
|
|
*class = ata_dev_classify(&tf);
|
2006-03-11 05:42:34 +03:00
|
|
|
|
2006-02-10 17:58:48 +03:00
|
|
|
DPRINTK("EXIT, class=%u\n", *class);
|
2005-11-18 08:14:01 +03:00
|
|
|
return 0;
|
2006-04-11 17:22:29 +04:00
|
|
|
|
|
|
|
err:
|
ata: Convert ata_<foo>_printk(KERN_<LEVEL> to ata_<foo>_<level>
Saves text by removing nearly duplicated text format strings by
creating ata_<foo>_printk functions and printf extension %pV.
ata defconfig size shrinks ~5% (~8KB), allyesconfig ~2.5% (~13KB)
Format string duplication comes from:
#define ata_link_printk(link, lv, fmt, args...) do { \
if (sata_pmp_attached((link)->ap) || (link)->ap->slave_link) \
printk("%sata%u.%02u: "fmt, lv, (link)->ap->print_id, \
(link)->pmp , ##args); \
else \
printk("%sata%u: "fmt, lv, (link)->ap->print_id , ##args); \
} while(0)
Coalesce long formats.
$ size drivers/ata/built-in.*
text data bss dec hex filename
544969 73893 116584 735446 b38d6 drivers/ata/built-in.allyesconfig.ata.o
558429 73893 117864 750186 b726a drivers/ata/built-in.allyesconfig.dev_level.o
141328 14689 4220 160237 271ed drivers/ata/built-in.defconfig.ata.o
149567 14689 4220 168476 2921c drivers/ata/built-in.defconfig.dev_level.o
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
2011-04-16 02:51:59 +04:00
|
|
|
ata_link_err(link, "softreset failed (%s)\n", reason);
|
2006-04-11 17:22:29 +04:00
|
|
|
return -EIO;
|
2005-11-18 08:14:01 +03:00
|
|
|
}
|
|
|
|
|
2007-08-06 13:36:23 +04:00
|
|
|
static int sil24_hardreset(struct ata_link *link, unsigned int *class,
|
libata: add deadline support to prereset and reset methods
Add @deadline to prereset and reset methods and make them honor it.
ata_wait_ready() which directly takes @deadline is implemented to be
used as the wait function. This patch is in preparation for EH timing
improvements.
* ata_wait_ready() never does busy sleep. It's only used from EH and
no wait in EH is that urgent. This function also prints 'be
patient' message automatically after 5 secs of waiting if more than
3 secs is remaining till deadline.
* ata_bus_post_reset() now fails with error code if any of its wait
fails. This is important because earlier reset tries will have
shorter timeout than the spec requires. If a device fails to
respond before the short timeout, reset should be retried with
longer timeout rather than silently ignoring the device.
There are three behavior differences.
1. Timeout is applied to both devices at once, not separately. This
is more consistent with what the spec says.
2. When a device passes devchk but fails to become ready before
deadline. Previouly, post_reset would just succeed and let
device classification remove the device. New code fails the
reset thus causing reset retry. After a few times, EH will give
up disabling the port.
3. When slave device passes devchk but fails to become accessible
(TF-wise) after reset. Original code disables dev1 after 30s
timeout and continues as if the device doesn't exist, while the
patched code fails reset. When this happens, new code fails
reset on whole port rather than proceeding with only the primary
device.
If the failing device is suffering transient problems, new code
retries reset which is a better behavior. If the failing device is
actually broken, the net effect is identical to it, but not to the
other device sharing the channel. In the previous code, reset would
have succeeded after 30s thus detecting the working one. In the new
code, reset fails and whole port gets disabled. IMO, it's a
pathological case anyway (broken device sharing bus with working
one) and doesn't really matter.
* ata_bus_softreset() is changed to return error code from
ata_bus_post_reset(). It used to return 0 unconditionally.
* Spin up waiting is to be removed and not converted to honor
deadline.
* To be on the safe side, deadline is set to 40s for the time being.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
2007-02-02 10:50:52 +03:00
|
|
|
unsigned long deadline)
|
2006-02-10 17:58:48 +03:00
|
|
|
{
|
2007-08-06 13:36:23 +04:00
|
|
|
struct ata_port *ap = link->ap;
|
2008-04-07 17:47:21 +04:00
|
|
|
void __iomem *port = sil24_port_base(ap);
|
2007-09-23 08:19:54 +04:00
|
|
|
struct sil24_port_priv *pp = ap->private_data;
|
|
|
|
int did_port_rst = 0;
|
2006-04-11 17:32:19 +04:00
|
|
|
const char *reason;
|
2006-05-31 13:27:59 +04:00
|
|
|
int tout_msec, rc;
|
2006-04-11 17:32:19 +04:00
|
|
|
u32 tmp;
|
|
|
|
|
2007-09-23 08:19:54 +04:00
|
|
|
retry:
|
|
|
|
/* Sometimes, DEV_RST is not enough to recover the controller.
|
|
|
|
* This happens often after PM DMA CS errata.
|
|
|
|
*/
|
|
|
|
if (pp->do_port_rst) {
|
ata: Convert ata_<foo>_printk(KERN_<LEVEL> to ata_<foo>_<level>
Saves text by removing nearly duplicated text format strings by
creating ata_<foo>_printk functions and printf extension %pV.
ata defconfig size shrinks ~5% (~8KB), allyesconfig ~2.5% (~13KB)
Format string duplication comes from:
#define ata_link_printk(link, lv, fmt, args...) do { \
if (sata_pmp_attached((link)->ap) || (link)->ap->slave_link) \
printk("%sata%u.%02u: "fmt, lv, (link)->ap->print_id, \
(link)->pmp , ##args); \
else \
printk("%sata%u: "fmt, lv, (link)->ap->print_id , ##args); \
} while(0)
Coalesce long formats.
$ size drivers/ata/built-in.*
text data bss dec hex filename
544969 73893 116584 735446 b38d6 drivers/ata/built-in.allyesconfig.ata.o
558429 73893 117864 750186 b726a drivers/ata/built-in.allyesconfig.dev_level.o
141328 14689 4220 160237 271ed drivers/ata/built-in.defconfig.ata.o
149567 14689 4220 168476 2921c drivers/ata/built-in.defconfig.dev_level.o
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
2011-04-16 02:51:59 +04:00
|
|
|
ata_port_warn(ap,
|
|
|
|
"controller in dubious state, performing PORT_RST\n");
|
2007-09-23 08:19:54 +04:00
|
|
|
|
|
|
|
writel(PORT_CS_PORT_RST, port + PORT_CTRL_STAT);
|
2010-09-06 19:56:29 +04:00
|
|
|
ata_msleep(ap, 10);
|
2007-09-23 08:19:54 +04:00
|
|
|
writel(PORT_CS_PORT_RST, port + PORT_CTRL_CLR);
|
2010-09-06 19:56:29 +04:00
|
|
|
ata_wait_register(ap, port + PORT_CTRL_STAT, PORT_CS_RDY, 0,
|
2007-09-23 08:19:54 +04:00
|
|
|
10, 5000);
|
|
|
|
|
|
|
|
/* restore port configuration */
|
|
|
|
sil24_config_port(ap);
|
|
|
|
sil24_config_pmp(ap, ap->nr_pmp_links);
|
|
|
|
|
|
|
|
pp->do_port_rst = 0;
|
|
|
|
did_port_rst = 1;
|
|
|
|
}
|
|
|
|
|
2006-04-11 17:32:19 +04:00
|
|
|
/* sil24 does the right thing(tm) without any protection */
|
2007-08-06 13:36:23 +04:00
|
|
|
sata_set_spd(link);
|
2006-04-11 17:32:19 +04:00
|
|
|
|
|
|
|
tout_msec = 100;
|
2007-08-06 13:36:23 +04:00
|
|
|
if (ata_link_online(link))
|
2006-04-11 17:32:19 +04:00
|
|
|
tout_msec = 5000;
|
|
|
|
|
|
|
|
writel(PORT_CS_DEV_RST, port + PORT_CTRL_STAT);
|
2010-09-06 19:56:29 +04:00
|
|
|
tmp = ata_wait_register(ap, port + PORT_CTRL_STAT,
|
2007-10-26 08:03:37 +04:00
|
|
|
PORT_CS_DEV_RST, PORT_CS_DEV_RST, 10,
|
|
|
|
tout_msec);
|
2006-04-11 17:32:19 +04:00
|
|
|
|
2006-05-31 13:27:59 +04:00
|
|
|
/* SStatus oscillates between zero and valid status after
|
|
|
|
* DEV_RST, debounce it.
|
2006-04-11 17:32:19 +04:00
|
|
|
*/
|
2007-08-06 13:36:23 +04:00
|
|
|
rc = sata_link_debounce(link, sata_deb_timing_long, deadline);
|
2006-05-31 13:27:59 +04:00
|
|
|
if (rc) {
|
|
|
|
reason = "PHY debouncing failed";
|
|
|
|
goto err;
|
|
|
|
}
|
2006-04-11 17:32:19 +04:00
|
|
|
|
|
|
|
if (tmp & PORT_CS_DEV_RST) {
|
2007-08-06 13:36:23 +04:00
|
|
|
if (ata_link_offline(link))
|
2006-04-11 17:32:19 +04:00
|
|
|
return 0;
|
|
|
|
reason = "link not ready";
|
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
|
2006-05-31 13:27:59 +04:00
|
|
|
/* Sil24 doesn't store signature FIS after hardreset, so we
|
|
|
|
* can't wait for BSY to clear. Some devices take a long time
|
|
|
|
* to get ready and those devices will choke if we don't wait
|
|
|
|
* for BSY clearance here. Tell libata to perform follow-up
|
|
|
|
* softreset.
|
2006-04-11 17:32:19 +04:00
|
|
|
*/
|
2006-05-31 13:27:59 +04:00
|
|
|
return -EAGAIN;
|
2006-04-11 17:32:19 +04:00
|
|
|
|
|
|
|
err:
|
2007-09-23 08:19:54 +04:00
|
|
|
if (!did_port_rst) {
|
|
|
|
pp->do_port_rst = 1;
|
|
|
|
goto retry;
|
|
|
|
}
|
|
|
|
|
ata: Convert ata_<foo>_printk(KERN_<LEVEL> to ata_<foo>_<level>
Saves text by removing nearly duplicated text format strings by
creating ata_<foo>_printk functions and printf extension %pV.
ata defconfig size shrinks ~5% (~8KB), allyesconfig ~2.5% (~13KB)
Format string duplication comes from:
#define ata_link_printk(link, lv, fmt, args...) do { \
if (sata_pmp_attached((link)->ap) || (link)->ap->slave_link) \
printk("%sata%u.%02u: "fmt, lv, (link)->ap->print_id, \
(link)->pmp , ##args); \
else \
printk("%sata%u: "fmt, lv, (link)->ap->print_id , ##args); \
} while(0)
Coalesce long formats.
$ size drivers/ata/built-in.*
text data bss dec hex filename
544969 73893 116584 735446 b38d6 drivers/ata/built-in.allyesconfig.ata.o
558429 73893 117864 750186 b726a drivers/ata/built-in.allyesconfig.dev_level.o
141328 14689 4220 160237 271ed drivers/ata/built-in.defconfig.ata.o
149567 14689 4220 168476 2921c drivers/ata/built-in.defconfig.dev_level.o
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
2011-04-16 02:51:59 +04:00
|
|
|
ata_link_err(link, "hardreset failed (%s)\n", reason);
|
2006-04-11 17:32:19 +04:00
|
|
|
return -EIO;
|
2006-02-10 17:58:48 +03:00
|
|
|
}
|
|
|
|
|
2005-07-28 05:36:22 +04:00
|
|
|
static inline void sil24_fill_sg(struct ata_queued_cmd *qc,
|
2005-11-18 08:16:45 +03:00
|
|
|
struct sil24_sge *sge)
|
2005-07-28 05:36:22 +04:00
|
|
|
{
|
2005-10-19 06:14:54 +04:00
|
|
|
struct scatterlist *sg;
|
2007-10-19 00:21:18 +04:00
|
|
|
struct sil24_sge *last_sge = NULL;
|
2007-12-05 10:43:11 +03:00
|
|
|
unsigned int si;
|
2005-07-28 05:36:22 +04:00
|
|
|
|
2007-12-05 10:43:11 +03:00
|
|
|
for_each_sg(qc->sg, sg, qc->n_elem, si) {
|
2005-07-28 05:36:22 +04:00
|
|
|
sge->addr = cpu_to_le64(sg_dma_address(sg));
|
|
|
|
sge->cnt = cpu_to_le32(sg_dma_len(sg));
|
2007-10-19 00:21:18 +04:00
|
|
|
sge->flags = 0;
|
|
|
|
|
|
|
|
last_sge = sge;
|
2005-10-19 06:14:54 +04:00
|
|
|
sge++;
|
2005-07-28 05:36:22 +04:00
|
|
|
}
|
2007-10-19 00:21:18 +04:00
|
|
|
|
2007-12-05 10:43:11 +03:00
|
|
|
last_sge->flags = cpu_to_le32(SGE_TRM);
|
2005-07-28 05:36:22 +04:00
|
|
|
}
|
|
|
|
|
2007-09-23 08:19:54 +04:00
|
|
|
static int sil24_qc_defer(struct ata_queued_cmd *qc)
|
|
|
|
{
|
|
|
|
struct ata_link *link = qc->dev->link;
|
|
|
|
struct ata_port *ap = link->ap;
|
|
|
|
u8 prot = qc->tf.protocol;
|
2008-01-10 09:47:56 +03:00
|
|
|
|
|
|
|
/*
|
|
|
|
* There is a bug in the chip:
|
|
|
|
* Port LRAM Causes the PRB/SGT Data to be Corrupted
|
|
|
|
* If the host issues a read request for LRAM and SActive registers
|
|
|
|
* while active commands are available in the port, PRB/SGT data in
|
|
|
|
* the LRAM can become corrupted. This issue applies only when
|
|
|
|
* reading from, but not writing to, the LRAM.
|
|
|
|
*
|
|
|
|
* Therefore, reading LRAM when there is no particular error [and
|
|
|
|
* other commands may be outstanding] is prohibited.
|
|
|
|
*
|
|
|
|
* To avoid this bug there are two situations where a command must run
|
|
|
|
* exclusive of any other commands on the port:
|
|
|
|
*
|
|
|
|
* - ATAPI commands which check the sense data
|
|
|
|
* - Passthrough ATA commands which always have ATA_QCFLAG_RESULT_TF
|
|
|
|
* set.
|
|
|
|
*
|
|
|
|
*/
|
2007-11-27 13:28:53 +03:00
|
|
|
int is_excl = (ata_is_atapi(prot) ||
|
2008-01-10 09:47:56 +03:00
|
|
|
(qc->flags & ATA_QCFLAG_RESULT_TF));
|
|
|
|
|
2007-09-23 08:19:54 +04:00
|
|
|
if (unlikely(ap->excl_link)) {
|
|
|
|
if (link == ap->excl_link) {
|
|
|
|
if (ap->nr_active_links)
|
|
|
|
return ATA_DEFER_PORT;
|
|
|
|
qc->flags |= ATA_QCFLAG_CLEAR_EXCL;
|
|
|
|
} else
|
|
|
|
return ATA_DEFER_PORT;
|
2008-01-10 09:47:56 +03:00
|
|
|
} else if (unlikely(is_excl)) {
|
2007-09-23 08:19:54 +04:00
|
|
|
ap->excl_link = link;
|
|
|
|
if (ap->nr_active_links)
|
|
|
|
return ATA_DEFER_PORT;
|
|
|
|
qc->flags |= ATA_QCFLAG_CLEAR_EXCL;
|
|
|
|
}
|
|
|
|
|
|
|
|
return ata_std_qc_defer(qc);
|
|
|
|
}
|
|
|
|
|
2005-07-28 05:36:22 +04:00
|
|
|
static void sil24_qc_prep(struct ata_queued_cmd *qc)
|
|
|
|
{
|
|
|
|
struct ata_port *ap = qc->ap;
|
|
|
|
struct sil24_port_priv *pp = ap->private_data;
|
2006-05-15 16:03:56 +04:00
|
|
|
union sil24_cmd_block *cb;
|
2005-11-18 08:16:45 +03:00
|
|
|
struct sil24_prb *prb;
|
|
|
|
struct sil24_sge *sge;
|
2006-04-11 17:32:19 +04:00
|
|
|
u16 ctrl = 0;
|
2005-07-28 05:36:22 +04:00
|
|
|
|
2006-05-15 16:03:56 +04:00
|
|
|
cb = &pp->cmd_block[sil24_tag(qc->tag)];
|
|
|
|
|
2007-11-27 13:28:53 +03:00
|
|
|
if (!ata_is_atapi(qc->tf.protocol)) {
|
2005-11-18 08:16:45 +03:00
|
|
|
prb = &cb->ata.prb;
|
|
|
|
sge = cb->ata.sge;
|
2009-07-31 00:11:29 +04:00
|
|
|
if (ata_is_data(qc->tf.protocol)) {
|
|
|
|
u16 prot = 0;
|
|
|
|
ctrl = PRB_CTRL_PROTOCOL;
|
|
|
|
if (ata_is_ncq(qc->tf.protocol))
|
|
|
|
prot |= PRB_PROT_NCQ;
|
|
|
|
if (qc->tf.flags & ATA_TFLAG_WRITE)
|
|
|
|
prot |= PRB_PROT_WRITE;
|
|
|
|
else
|
|
|
|
prot |= PRB_PROT_READ;
|
|
|
|
prb->prot = cpu_to_le16(prot);
|
|
|
|
}
|
2007-11-27 13:28:53 +03:00
|
|
|
} else {
|
2005-11-18 08:16:45 +03:00
|
|
|
prb = &cb->atapi.prb;
|
|
|
|
sge = cb->atapi.sge;
|
2010-06-09 16:01:54 +04:00
|
|
|
memset(cb->atapi.cdb, 0, sizeof(cb->atapi.cdb));
|
2006-02-12 17:32:58 +03:00
|
|
|
memcpy(cb->atapi.cdb, qc->cdb, qc->dev->cdb_len);
|
2005-11-18 08:16:45 +03:00
|
|
|
|
2007-11-27 13:28:53 +03:00
|
|
|
if (ata_is_data(qc->tf.protocol)) {
|
2005-11-18 08:16:45 +03:00
|
|
|
if (qc->tf.flags & ATA_TFLAG_WRITE)
|
2006-04-11 17:32:19 +04:00
|
|
|
ctrl = PRB_CTRL_PACKET_WRITE;
|
2005-11-18 08:16:45 +03:00
|
|
|
else
|
2006-04-11 17:32:19 +04:00
|
|
|
ctrl = PRB_CTRL_PACKET_READ;
|
|
|
|
}
|
2005-07-28 05:36:22 +04:00
|
|
|
}
|
|
|
|
|
2006-04-11 17:32:19 +04:00
|
|
|
prb->ctrl = cpu_to_le16(ctrl);
|
2007-09-23 08:19:54 +04:00
|
|
|
ata_tf_to_fis(&qc->tf, qc->dev->link->pmp, 1, prb->fis);
|
2005-07-28 05:36:22 +04:00
|
|
|
|
|
|
|
if (qc->flags & ATA_QCFLAG_DMAMAP)
|
2005-11-18 08:16:45 +03:00
|
|
|
sil24_fill_sg(qc, sge);
|
2005-07-28 05:36:22 +04:00
|
|
|
}
|
|
|
|
|
2006-01-23 07:09:36 +03:00
|
|
|
static unsigned int sil24_qc_issue(struct ata_queued_cmd *qc)
|
2005-07-28 05:36:22 +04:00
|
|
|
{
|
|
|
|
struct ata_port *ap = qc->ap;
|
|
|
|
struct sil24_port_priv *pp = ap->private_data;
|
2008-04-07 17:47:21 +04:00
|
|
|
void __iomem *port = sil24_port_base(ap);
|
2006-05-15 16:03:56 +04:00
|
|
|
unsigned int tag = sil24_tag(qc->tag);
|
|
|
|
dma_addr_t paddr;
|
|
|
|
void __iomem *activate;
|
2005-07-28 05:36:22 +04:00
|
|
|
|
2006-05-15 16:03:56 +04:00
|
|
|
paddr = pp->cmd_block_dma + tag * sizeof(*pp->cmd_block);
|
|
|
|
activate = port + PORT_CMD_ACTIVATE + tag * 8;
|
|
|
|
|
2010-06-10 20:02:12 +04:00
|
|
|
/*
|
|
|
|
* The barrier is required to ensure that writes to cmd_block reach
|
|
|
|
* the memory before the write to PORT_CMD_ACTIVATE.
|
|
|
|
*/
|
|
|
|
wmb();
|
2006-05-15 16:03:56 +04:00
|
|
|
writel((u32)paddr, activate);
|
|
|
|
writel((u64)paddr >> 32, activate + 4);
|
2006-04-11 17:32:19 +04:00
|
|
|
|
2005-07-28 05:36:22 +04:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2008-04-07 17:47:20 +04:00
|
|
|
static bool sil24_qc_fill_rtf(struct ata_queued_cmd *qc)
|
|
|
|
{
|
|
|
|
sil24_read_tf(qc->ap, qc->tag, &qc->result_tf);
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2007-09-23 08:19:54 +04:00
|
|
|
static void sil24_pmp_attach(struct ata_port *ap)
|
|
|
|
{
|
2008-05-18 20:15:13 +04:00
|
|
|
u32 *gscr = ap->link.device->gscr;
|
|
|
|
|
2007-09-23 08:19:54 +04:00
|
|
|
sil24_config_pmp(ap, 1);
|
|
|
|
sil24_init_port(ap);
|
2008-05-18 20:15:13 +04:00
|
|
|
|
|
|
|
if (sata_pmp_gscr_vendor(gscr) == 0x11ab &&
|
|
|
|
sata_pmp_gscr_devid(gscr) == 0x4140) {
|
ata: Convert ata_<foo>_printk(KERN_<LEVEL> to ata_<foo>_<level>
Saves text by removing nearly duplicated text format strings by
creating ata_<foo>_printk functions and printf extension %pV.
ata defconfig size shrinks ~5% (~8KB), allyesconfig ~2.5% (~13KB)
Format string duplication comes from:
#define ata_link_printk(link, lv, fmt, args...) do { \
if (sata_pmp_attached((link)->ap) || (link)->ap->slave_link) \
printk("%sata%u.%02u: "fmt, lv, (link)->ap->print_id, \
(link)->pmp , ##args); \
else \
printk("%sata%u: "fmt, lv, (link)->ap->print_id , ##args); \
} while(0)
Coalesce long formats.
$ size drivers/ata/built-in.*
text data bss dec hex filename
544969 73893 116584 735446 b38d6 drivers/ata/built-in.allyesconfig.ata.o
558429 73893 117864 750186 b726a drivers/ata/built-in.allyesconfig.dev_level.o
141328 14689 4220 160237 271ed drivers/ata/built-in.defconfig.ata.o
149567 14689 4220 168476 2921c drivers/ata/built-in.defconfig.dev_level.o
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
2011-04-16 02:51:59 +04:00
|
|
|
ata_port_info(ap,
|
2008-05-18 20:15:13 +04:00
|
|
|
"disabling NCQ support due to sil24-mv4140 quirk\n");
|
|
|
|
ap->flags &= ~ATA_FLAG_NCQ;
|
|
|
|
}
|
2007-09-23 08:19:54 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
static void sil24_pmp_detach(struct ata_port *ap)
|
|
|
|
{
|
|
|
|
sil24_init_port(ap);
|
|
|
|
sil24_config_pmp(ap, 0);
|
2008-05-18 20:15:13 +04:00
|
|
|
|
|
|
|
ap->flags |= ATA_FLAG_NCQ;
|
2007-09-23 08:19:54 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
static int sil24_pmp_hardreset(struct ata_link *link, unsigned int *class,
|
|
|
|
unsigned long deadline)
|
|
|
|
{
|
|
|
|
int rc;
|
|
|
|
|
|
|
|
rc = sil24_init_port(link->ap);
|
|
|
|
if (rc) {
|
ata: Convert ata_<foo>_printk(KERN_<LEVEL> to ata_<foo>_<level>
Saves text by removing nearly duplicated text format strings by
creating ata_<foo>_printk functions and printf extension %pV.
ata defconfig size shrinks ~5% (~8KB), allyesconfig ~2.5% (~13KB)
Format string duplication comes from:
#define ata_link_printk(link, lv, fmt, args...) do { \
if (sata_pmp_attached((link)->ap) || (link)->ap->slave_link) \
printk("%sata%u.%02u: "fmt, lv, (link)->ap->print_id, \
(link)->pmp , ##args); \
else \
printk("%sata%u: "fmt, lv, (link)->ap->print_id , ##args); \
} while(0)
Coalesce long formats.
$ size drivers/ata/built-in.*
text data bss dec hex filename
544969 73893 116584 735446 b38d6 drivers/ata/built-in.allyesconfig.ata.o
558429 73893 117864 750186 b726a drivers/ata/built-in.allyesconfig.dev_level.o
141328 14689 4220 160237 271ed drivers/ata/built-in.defconfig.ata.o
149567 14689 4220 168476 2921c drivers/ata/built-in.defconfig.dev_level.o
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
2011-04-16 02:51:59 +04:00
|
|
|
ata_link_err(link, "hardreset failed (port not ready)\n");
|
2007-09-23 08:19:54 +04:00
|
|
|
return rc;
|
|
|
|
}
|
|
|
|
|
2008-04-07 17:47:20 +04:00
|
|
|
return sata_std_hardreset(link, class, deadline);
|
2007-09-23 08:19:54 +04:00
|
|
|
}
|
|
|
|
|
2006-05-15 15:58:32 +04:00
|
|
|
static void sil24_freeze(struct ata_port *ap)
|
2005-11-18 08:09:05 +03:00
|
|
|
{
|
2008-04-07 17:47:21 +04:00
|
|
|
void __iomem *port = sil24_port_base(ap);
|
2005-11-18 08:09:05 +03:00
|
|
|
|
2006-05-15 15:58:32 +04:00
|
|
|
/* Port-wide IRQ mask in HOST_CTRL doesn't really work, clear
|
|
|
|
* PORT_IRQ_ENABLE instead.
|
|
|
|
*/
|
|
|
|
writel(0xffff, port + PORT_IRQ_ENABLE_CLR);
|
2005-11-18 08:09:05 +03:00
|
|
|
}
|
|
|
|
|
2006-05-15 15:58:32 +04:00
|
|
|
static void sil24_thaw(struct ata_port *ap)
|
2005-07-28 05:36:22 +04:00
|
|
|
{
|
2008-04-07 17:47:21 +04:00
|
|
|
void __iomem *port = sil24_port_base(ap);
|
2005-07-28 05:36:22 +04:00
|
|
|
u32 tmp;
|
|
|
|
|
2006-05-15 15:58:32 +04:00
|
|
|
/* clear IRQ */
|
|
|
|
tmp = readl(port + PORT_IRQ_STAT);
|
|
|
|
writel(tmp, port + PORT_IRQ_STAT);
|
2005-07-28 05:36:22 +04:00
|
|
|
|
2006-05-15 15:58:32 +04:00
|
|
|
/* turn IRQ back on */
|
|
|
|
writel(DEF_PORT_IRQ, port + PORT_IRQ_ENABLE_SET);
|
2005-07-28 05:36:22 +04:00
|
|
|
}
|
|
|
|
|
2006-05-15 15:58:32 +04:00
|
|
|
static void sil24_error_intr(struct ata_port *ap)
|
2005-08-17 08:08:57 +04:00
|
|
|
{
|
2008-04-07 17:47:21 +04:00
|
|
|
void __iomem *port = sil24_port_base(ap);
|
2007-07-16 09:29:39 +04:00
|
|
|
struct sil24_port_priv *pp = ap->private_data;
|
2007-09-23 08:19:54 +04:00
|
|
|
struct ata_queued_cmd *qc = NULL;
|
|
|
|
struct ata_link *link;
|
|
|
|
struct ata_eh_info *ehi;
|
|
|
|
int abort = 0, freeze = 0;
|
2006-05-15 15:58:32 +04:00
|
|
|
u32 irq_stat;
|
2005-08-17 08:08:57 +04:00
|
|
|
|
2006-05-15 15:58:32 +04:00
|
|
|
/* on error, we need to clear IRQ explicitly */
|
2005-08-17 08:08:57 +04:00
|
|
|
irq_stat = readl(port + PORT_IRQ_STAT);
|
2006-05-15 15:58:32 +04:00
|
|
|
writel(irq_stat, port + PORT_IRQ_STAT);
|
2005-10-06 06:43:29 +04:00
|
|
|
|
2006-05-15 15:58:32 +04:00
|
|
|
/* first, analyze and record host port events */
|
2007-09-23 08:19:54 +04:00
|
|
|
link = &ap->link;
|
|
|
|
ehi = &link->eh_info;
|
2006-05-15 15:58:32 +04:00
|
|
|
ata_ehi_clear_desc(ehi);
|
2005-10-06 06:43:29 +04:00
|
|
|
|
2006-05-15 15:58:32 +04:00
|
|
|
ata_ehi_push_desc(ehi, "irq_stat 0x%08x", irq_stat);
|
2005-08-17 08:08:57 +04:00
|
|
|
|
2007-09-23 08:14:11 +04:00
|
|
|
if (irq_stat & PORT_IRQ_SDB_NOTIFY) {
|
|
|
|
ata_ehi_push_desc(ehi, "SDB notify");
|
2007-09-23 08:14:13 +04:00
|
|
|
sata_async_notification(ap);
|
2007-09-23 08:14:11 +04:00
|
|
|
}
|
|
|
|
|
2006-05-31 13:28:20 +04:00
|
|
|
if (irq_stat & (PORT_IRQ_PHYRDY_CHG | PORT_IRQ_DEV_XCHG)) {
|
|
|
|
ata_ehi_hotplugged(ehi);
|
2007-07-16 09:29:39 +04:00
|
|
|
ata_ehi_push_desc(ehi, "%s",
|
|
|
|
irq_stat & PORT_IRQ_PHYRDY_CHG ?
|
|
|
|
"PHY RDY changed" : "device exchanged");
|
2006-05-15 15:58:32 +04:00
|
|
|
freeze = 1;
|
2005-10-06 06:43:39 +04:00
|
|
|
}
|
|
|
|
|
2006-05-15 15:58:32 +04:00
|
|
|
if (irq_stat & PORT_IRQ_UNK_FIS) {
|
|
|
|
ehi->err_mask |= AC_ERR_HSM;
|
libata: prefer hardreset
When both soft and hard resets are available, libata preferred
softreset till now. The logic behind it was to be softer to devices;
however, this doesn't really help much. Rationales for the change:
* BIOS may freeze lock certain things during boot and softreset can't
unlock those. This by itself is okay but during operation PHY event
or other error conditions can trigger hardreset and the device may
end up with different configuration.
For example, after a hardreset, previously unlockable HPA can be
unlocked resulting in different device size and thus revalidation
failure. Similar condition can occur during or after resume.
* Certain ATAPI devices require hardreset to recover after certain
error conditions. On PATA, this is done by issuing the DEVICE RESET
command. On SATA, COMRESET has equivalent effect. The problem is
that DEVICE RESET needs its own execution protocol.
For SFF controllers with bare TF access, it can be easily
implemented but more advanced controllers (e.g. ahci and sata_sil24)
require specialized implementations. Simply using hardreset solves
the problem nicely.
* COMRESET initialization sequence is the norm in SATA land and many
SATA devices don't work properly if only SRST is used. For example,
some PMPs behave this way and libata works around by always issuing
hardreset if the host supports PMP.
Like the above example, libata has developed a number of mechanisms
aiming to promote softreset to hardreset if softreset is not going
to work. This approach is time consuming and error prone.
Also, note that, dependingon how you read the specs, it could be
argued that PMP fan-out ports require COMRESET to start operation.
In fact, all the PMPs on the market except one don't work properly
if COMRESET is not issued to fan-out ports after PMP reset.
* COMRESET is an integral part of SATA connection and any working
device should be able to handle COMRESET properly. After all, it's
the way to signal hardreset during reboot. This is the most used
and recommended (at least by the ahci spec) method of resetting
devices.
So, this patch makes libata prefer hardreset over softreset by making
the following changes.
* Rename ATA_EH_RESET_MASK to ATA_EH_RESET and use it whereever
ATA_EH_{SOFT|HARD}RESET used to be used. ATA_EH_{SOFT|HARD}RESET is
now only used to tell prereset whether soft or hard reset will be
issued.
* Strip out now unneeded promote-to-hardreset logics from
ata_eh_reset(), ata_std_prereset(), sata_pmp_std_prereset() and
other places.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-01-23 18:05:14 +03:00
|
|
|
ehi->action |= ATA_EH_RESET;
|
2007-07-16 09:29:39 +04:00
|
|
|
ata_ehi_push_desc(ehi, "unknown FIS");
|
2006-05-15 15:58:32 +04:00
|
|
|
freeze = 1;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* deal with command error */
|
|
|
|
if (irq_stat & PORT_IRQ_ERROR) {
|
2011-08-06 06:38:17 +04:00
|
|
|
const struct sil24_cerr_info *ci = NULL;
|
2006-05-15 15:58:32 +04:00
|
|
|
unsigned int err_mask = 0, action = 0;
|
2007-09-23 08:19:54 +04:00
|
|
|
u32 context, cerr;
|
|
|
|
int pmp;
|
|
|
|
|
|
|
|
abort = 1;
|
|
|
|
|
|
|
|
/* DMA Context Switch Failure in Port Multiplier Mode
|
|
|
|
* errata. If we have active commands to 3 or more
|
|
|
|
* devices, any error condition on active devices can
|
|
|
|
* corrupt DMA context switching.
|
|
|
|
*/
|
|
|
|
if (ap->nr_active_links >= 3) {
|
|
|
|
ehi->err_mask |= AC_ERR_OTHER;
|
libata: prefer hardreset
When both soft and hard resets are available, libata preferred
softreset till now. The logic behind it was to be softer to devices;
however, this doesn't really help much. Rationales for the change:
* BIOS may freeze lock certain things during boot and softreset can't
unlock those. This by itself is okay but during operation PHY event
or other error conditions can trigger hardreset and the device may
end up with different configuration.
For example, after a hardreset, previously unlockable HPA can be
unlocked resulting in different device size and thus revalidation
failure. Similar condition can occur during or after resume.
* Certain ATAPI devices require hardreset to recover after certain
error conditions. On PATA, this is done by issuing the DEVICE RESET
command. On SATA, COMRESET has equivalent effect. The problem is
that DEVICE RESET needs its own execution protocol.
For SFF controllers with bare TF access, it can be easily
implemented but more advanced controllers (e.g. ahci and sata_sil24)
require specialized implementations. Simply using hardreset solves
the problem nicely.
* COMRESET initialization sequence is the norm in SATA land and many
SATA devices don't work properly if only SRST is used. For example,
some PMPs behave this way and libata works around by always issuing
hardreset if the host supports PMP.
Like the above example, libata has developed a number of mechanisms
aiming to promote softreset to hardreset if softreset is not going
to work. This approach is time consuming and error prone.
Also, note that, dependingon how you read the specs, it could be
argued that PMP fan-out ports require COMRESET to start operation.
In fact, all the PMPs on the market except one don't work properly
if COMRESET is not issued to fan-out ports after PMP reset.
* COMRESET is an integral part of SATA connection and any working
device should be able to handle COMRESET properly. After all, it's
the way to signal hardreset during reboot. This is the most used
and recommended (at least by the ahci spec) method of resetting
devices.
So, this patch makes libata prefer hardreset over softreset by making
the following changes.
* Rename ATA_EH_RESET_MASK to ATA_EH_RESET and use it whereever
ATA_EH_{SOFT|HARD}RESET used to be used. ATA_EH_{SOFT|HARD}RESET is
now only used to tell prereset whether soft or hard reset will be
issued.
* Strip out now unneeded promote-to-hardreset logics from
ata_eh_reset(), ata_std_prereset(), sata_pmp_std_prereset() and
other places.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-01-23 18:05:14 +03:00
|
|
|
ehi->action |= ATA_EH_RESET;
|
2007-09-23 08:19:54 +04:00
|
|
|
ata_ehi_push_desc(ehi, "PMP DMA CS errata");
|
2007-09-23 08:19:54 +04:00
|
|
|
pp->do_port_rst = 1;
|
2007-09-23 08:19:54 +04:00
|
|
|
freeze = 1;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* find out the offending link and qc */
|
2008-04-07 17:47:22 +04:00
|
|
|
if (sata_pmp_attached(ap)) {
|
2007-09-23 08:19:54 +04:00
|
|
|
context = readl(port + PORT_CONTEXT);
|
|
|
|
pmp = (context >> 5) & 0xf;
|
|
|
|
|
|
|
|
if (pmp < ap->nr_pmp_links) {
|
|
|
|
link = &ap->pmp_link[pmp];
|
|
|
|
ehi = &link->eh_info;
|
|
|
|
qc = ata_qc_from_tag(ap, link->active_tag);
|
|
|
|
|
|
|
|
ata_ehi_clear_desc(ehi);
|
|
|
|
ata_ehi_push_desc(ehi, "irq_stat 0x%08x",
|
|
|
|
irq_stat);
|
|
|
|
} else {
|
|
|
|
err_mask |= AC_ERR_HSM;
|
libata: prefer hardreset
When both soft and hard resets are available, libata preferred
softreset till now. The logic behind it was to be softer to devices;
however, this doesn't really help much. Rationales for the change:
* BIOS may freeze lock certain things during boot and softreset can't
unlock those. This by itself is okay but during operation PHY event
or other error conditions can trigger hardreset and the device may
end up with different configuration.
For example, after a hardreset, previously unlockable HPA can be
unlocked resulting in different device size and thus revalidation
failure. Similar condition can occur during or after resume.
* Certain ATAPI devices require hardreset to recover after certain
error conditions. On PATA, this is done by issuing the DEVICE RESET
command. On SATA, COMRESET has equivalent effect. The problem is
that DEVICE RESET needs its own execution protocol.
For SFF controllers with bare TF access, it can be easily
implemented but more advanced controllers (e.g. ahci and sata_sil24)
require specialized implementations. Simply using hardreset solves
the problem nicely.
* COMRESET initialization sequence is the norm in SATA land and many
SATA devices don't work properly if only SRST is used. For example,
some PMPs behave this way and libata works around by always issuing
hardreset if the host supports PMP.
Like the above example, libata has developed a number of mechanisms
aiming to promote softreset to hardreset if softreset is not going
to work. This approach is time consuming and error prone.
Also, note that, dependingon how you read the specs, it could be
argued that PMP fan-out ports require COMRESET to start operation.
In fact, all the PMPs on the market except one don't work properly
if COMRESET is not issued to fan-out ports after PMP reset.
* COMRESET is an integral part of SATA connection and any working
device should be able to handle COMRESET properly. After all, it's
the way to signal hardreset during reboot. This is the most used
and recommended (at least by the ahci spec) method of resetting
devices.
So, this patch makes libata prefer hardreset over softreset by making
the following changes.
* Rename ATA_EH_RESET_MASK to ATA_EH_RESET and use it whereever
ATA_EH_{SOFT|HARD}RESET used to be used. ATA_EH_{SOFT|HARD}RESET is
now only used to tell prereset whether soft or hard reset will be
issued.
* Strip out now unneeded promote-to-hardreset logics from
ata_eh_reset(), ata_std_prereset(), sata_pmp_std_prereset() and
other places.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-01-23 18:05:14 +03:00
|
|
|
action |= ATA_EH_RESET;
|
2007-09-23 08:19:54 +04:00
|
|
|
freeze = 1;
|
|
|
|
}
|
|
|
|
} else
|
|
|
|
qc = ata_qc_from_tag(ap, link->active_tag);
|
2006-05-15 15:58:32 +04:00
|
|
|
|
|
|
|
/* analyze CMD_ERR */
|
|
|
|
cerr = readl(port + PORT_CMD_ERR);
|
|
|
|
if (cerr < ARRAY_SIZE(sil24_cerr_db))
|
|
|
|
ci = &sil24_cerr_db[cerr];
|
|
|
|
|
|
|
|
if (ci && ci->desc) {
|
|
|
|
err_mask |= ci->err_mask;
|
|
|
|
action |= ci->action;
|
libata: prefer hardreset
When both soft and hard resets are available, libata preferred
softreset till now. The logic behind it was to be softer to devices;
however, this doesn't really help much. Rationales for the change:
* BIOS may freeze lock certain things during boot and softreset can't
unlock those. This by itself is okay but during operation PHY event
or other error conditions can trigger hardreset and the device may
end up with different configuration.
For example, after a hardreset, previously unlockable HPA can be
unlocked resulting in different device size and thus revalidation
failure. Similar condition can occur during or after resume.
* Certain ATAPI devices require hardreset to recover after certain
error conditions. On PATA, this is done by issuing the DEVICE RESET
command. On SATA, COMRESET has equivalent effect. The problem is
that DEVICE RESET needs its own execution protocol.
For SFF controllers with bare TF access, it can be easily
implemented but more advanced controllers (e.g. ahci and sata_sil24)
require specialized implementations. Simply using hardreset solves
the problem nicely.
* COMRESET initialization sequence is the norm in SATA land and many
SATA devices don't work properly if only SRST is used. For example,
some PMPs behave this way and libata works around by always issuing
hardreset if the host supports PMP.
Like the above example, libata has developed a number of mechanisms
aiming to promote softreset to hardreset if softreset is not going
to work. This approach is time consuming and error prone.
Also, note that, dependingon how you read the specs, it could be
argued that PMP fan-out ports require COMRESET to start operation.
In fact, all the PMPs on the market except one don't work properly
if COMRESET is not issued to fan-out ports after PMP reset.
* COMRESET is an integral part of SATA connection and any working
device should be able to handle COMRESET properly. After all, it's
the way to signal hardreset during reboot. This is the most used
and recommended (at least by the ahci spec) method of resetting
devices.
So, this patch makes libata prefer hardreset over softreset by making
the following changes.
* Rename ATA_EH_RESET_MASK to ATA_EH_RESET and use it whereever
ATA_EH_{SOFT|HARD}RESET used to be used. ATA_EH_{SOFT|HARD}RESET is
now only used to tell prereset whether soft or hard reset will be
issued.
* Strip out now unneeded promote-to-hardreset logics from
ata_eh_reset(), ata_std_prereset(), sata_pmp_std_prereset() and
other places.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-01-23 18:05:14 +03:00
|
|
|
if (action & ATA_EH_RESET)
|
2008-01-13 08:04:16 +03:00
|
|
|
freeze = 1;
|
2007-07-16 09:29:39 +04:00
|
|
|
ata_ehi_push_desc(ehi, "%s", ci->desc);
|
2006-05-15 15:58:32 +04:00
|
|
|
} else {
|
|
|
|
err_mask |= AC_ERR_OTHER;
|
libata: prefer hardreset
When both soft and hard resets are available, libata preferred
softreset till now. The logic behind it was to be softer to devices;
however, this doesn't really help much. Rationales for the change:
* BIOS may freeze lock certain things during boot and softreset can't
unlock those. This by itself is okay but during operation PHY event
or other error conditions can trigger hardreset and the device may
end up with different configuration.
For example, after a hardreset, previously unlockable HPA can be
unlocked resulting in different device size and thus revalidation
failure. Similar condition can occur during or after resume.
* Certain ATAPI devices require hardreset to recover after certain
error conditions. On PATA, this is done by issuing the DEVICE RESET
command. On SATA, COMRESET has equivalent effect. The problem is
that DEVICE RESET needs its own execution protocol.
For SFF controllers with bare TF access, it can be easily
implemented but more advanced controllers (e.g. ahci and sata_sil24)
require specialized implementations. Simply using hardreset solves
the problem nicely.
* COMRESET initialization sequence is the norm in SATA land and many
SATA devices don't work properly if only SRST is used. For example,
some PMPs behave this way and libata works around by always issuing
hardreset if the host supports PMP.
Like the above example, libata has developed a number of mechanisms
aiming to promote softreset to hardreset if softreset is not going
to work. This approach is time consuming and error prone.
Also, note that, dependingon how you read the specs, it could be
argued that PMP fan-out ports require COMRESET to start operation.
In fact, all the PMPs on the market except one don't work properly
if COMRESET is not issued to fan-out ports after PMP reset.
* COMRESET is an integral part of SATA connection and any working
device should be able to handle COMRESET properly. After all, it's
the way to signal hardreset during reboot. This is the most used
and recommended (at least by the ahci spec) method of resetting
devices.
So, this patch makes libata prefer hardreset over softreset by making
the following changes.
* Rename ATA_EH_RESET_MASK to ATA_EH_RESET and use it whereever
ATA_EH_{SOFT|HARD}RESET used to be used. ATA_EH_{SOFT|HARD}RESET is
now only used to tell prereset whether soft or hard reset will be
issued.
* Strip out now unneeded promote-to-hardreset logics from
ata_eh_reset(), ata_std_prereset(), sata_pmp_std_prereset() and
other places.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-01-23 18:05:14 +03:00
|
|
|
action |= ATA_EH_RESET;
|
2008-01-13 08:04:16 +03:00
|
|
|
freeze = 1;
|
2007-07-16 09:29:39 +04:00
|
|
|
ata_ehi_push_desc(ehi, "unknown command error %d",
|
2006-05-15 15:58:32 +04:00
|
|
|
cerr);
|
|
|
|
}
|
|
|
|
|
|
|
|
/* record error info */
|
2008-04-07 17:47:21 +04:00
|
|
|
if (qc)
|
2006-05-15 15:58:32 +04:00
|
|
|
qc->err_mask |= err_mask;
|
2008-04-07 17:47:21 +04:00
|
|
|
else
|
2006-05-15 15:58:32 +04:00
|
|
|
ehi->err_mask |= err_mask;
|
|
|
|
|
|
|
|
ehi->action |= action;
|
2007-09-23 08:19:54 +04:00
|
|
|
|
|
|
|
/* if PMP, resume */
|
2008-04-07 17:47:22 +04:00
|
|
|
if (sata_pmp_attached(ap))
|
2007-09-23 08:19:54 +04:00
|
|
|
writel(PORT_CS_PMP_RESUME, port + PORT_CTRL_STAT);
|
2005-12-05 10:38:02 +03:00
|
|
|
}
|
2006-05-15 15:58:32 +04:00
|
|
|
|
|
|
|
/* freeze or abort */
|
|
|
|
if (freeze)
|
|
|
|
ata_port_freeze(ap);
|
2007-09-23 08:19:54 +04:00
|
|
|
else if (abort) {
|
|
|
|
if (qc)
|
|
|
|
ata_link_abort(qc->dev->link);
|
|
|
|
else
|
|
|
|
ata_port_abort(ap);
|
|
|
|
}
|
2005-08-17 08:08:57 +04:00
|
|
|
}
|
|
|
|
|
2005-07-28 05:36:22 +04:00
|
|
|
static inline void sil24_host_intr(struct ata_port *ap)
|
|
|
|
{
|
2008-04-07 17:47:21 +04:00
|
|
|
void __iomem *port = sil24_port_base(ap);
|
2006-05-15 16:03:56 +04:00
|
|
|
u32 slot_stat, qc_active;
|
|
|
|
int rc;
|
2005-07-28 05:36:22 +04:00
|
|
|
|
2007-09-23 07:37:05 +04:00
|
|
|
/* If PCIX_IRQ_WOC, there's an inherent race window between
|
|
|
|
* clearing IRQ pending status and reading PORT_SLOT_STAT
|
|
|
|
* which may cause spurious interrupts afterwards. This is
|
|
|
|
* unavoidable and much better than losing interrupts which
|
|
|
|
* happens if IRQ pending is cleared after reading
|
|
|
|
* PORT_SLOT_STAT.
|
|
|
|
*/
|
|
|
|
if (ap->flags & SIL24_FLAG_PCIX_IRQ_WOC)
|
|
|
|
writel(PORT_IRQ_COMPLETE, port + PORT_IRQ_STAT);
|
|
|
|
|
2005-07-28 05:36:22 +04:00
|
|
|
slot_stat = readl(port + PORT_SLOT_STAT);
|
2006-04-11 17:32:19 +04:00
|
|
|
|
2006-05-15 15:58:32 +04:00
|
|
|
if (unlikely(slot_stat & HOST_SSTAT_ATTN)) {
|
|
|
|
sil24_error_intr(ap);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2006-05-15 16:03:56 +04:00
|
|
|
qc_active = slot_stat & ~HOST_SSTAT_ATTN;
|
2008-04-07 17:47:20 +04:00
|
|
|
rc = ata_qc_complete_multiple(ap, qc_active);
|
2006-05-15 16:03:56 +04:00
|
|
|
if (rc > 0)
|
|
|
|
return;
|
|
|
|
if (rc < 0) {
|
2007-08-06 13:36:22 +04:00
|
|
|
struct ata_eh_info *ehi = &ap->link.eh_info;
|
2006-05-15 16:03:56 +04:00
|
|
|
ehi->err_mask |= AC_ERR_HSM;
|
libata: prefer hardreset
When both soft and hard resets are available, libata preferred
softreset till now. The logic behind it was to be softer to devices;
however, this doesn't really help much. Rationales for the change:
* BIOS may freeze lock certain things during boot and softreset can't
unlock those. This by itself is okay but during operation PHY event
or other error conditions can trigger hardreset and the device may
end up with different configuration.
For example, after a hardreset, previously unlockable HPA can be
unlocked resulting in different device size and thus revalidation
failure. Similar condition can occur during or after resume.
* Certain ATAPI devices require hardreset to recover after certain
error conditions. On PATA, this is done by issuing the DEVICE RESET
command. On SATA, COMRESET has equivalent effect. The problem is
that DEVICE RESET needs its own execution protocol.
For SFF controllers with bare TF access, it can be easily
implemented but more advanced controllers (e.g. ahci and sata_sil24)
require specialized implementations. Simply using hardreset solves
the problem nicely.
* COMRESET initialization sequence is the norm in SATA land and many
SATA devices don't work properly if only SRST is used. For example,
some PMPs behave this way and libata works around by always issuing
hardreset if the host supports PMP.
Like the above example, libata has developed a number of mechanisms
aiming to promote softreset to hardreset if softreset is not going
to work. This approach is time consuming and error prone.
Also, note that, dependingon how you read the specs, it could be
argued that PMP fan-out ports require COMRESET to start operation.
In fact, all the PMPs on the market except one don't work properly
if COMRESET is not issued to fan-out ports after PMP reset.
* COMRESET is an integral part of SATA connection and any working
device should be able to handle COMRESET properly. After all, it's
the way to signal hardreset during reboot. This is the most used
and recommended (at least by the ahci spec) method of resetting
devices.
So, this patch makes libata prefer hardreset over softreset by making
the following changes.
* Rename ATA_EH_RESET_MASK to ATA_EH_RESET and use it whereever
ATA_EH_{SOFT|HARD}RESET used to be used. ATA_EH_{SOFT|HARD}RESET is
now only used to tell prereset whether soft or hard reset will be
issued.
* Strip out now unneeded promote-to-hardreset logics from
ata_eh_reset(), ata_std_prereset(), sata_pmp_std_prereset() and
other places.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-01-23 18:05:14 +03:00
|
|
|
ehi->action |= ATA_EH_RESET;
|
2006-05-15 16:03:56 +04:00
|
|
|
ata_port_freeze(ap);
|
2006-05-15 15:58:32 +04:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2007-09-23 07:37:05 +04:00
|
|
|
/* spurious interrupts are expected if PCIX_IRQ_WOC */
|
|
|
|
if (!(ap->flags & SIL24_FLAG_PCIX_IRQ_WOC) && ata_ratelimit())
|
ata: Convert ata_<foo>_printk(KERN_<LEVEL> to ata_<foo>_<level>
Saves text by removing nearly duplicated text format strings by
creating ata_<foo>_printk functions and printf extension %pV.
ata defconfig size shrinks ~5% (~8KB), allyesconfig ~2.5% (~13KB)
Format string duplication comes from:
#define ata_link_printk(link, lv, fmt, args...) do { \
if (sata_pmp_attached((link)->ap) || (link)->ap->slave_link) \
printk("%sata%u.%02u: "fmt, lv, (link)->ap->print_id, \
(link)->pmp , ##args); \
else \
printk("%sata%u: "fmt, lv, (link)->ap->print_id , ##args); \
} while(0)
Coalesce long formats.
$ size drivers/ata/built-in.*
text data bss dec hex filename
544969 73893 116584 735446 b38d6 drivers/ata/built-in.allyesconfig.ata.o
558429 73893 117864 750186 b726a drivers/ata/built-in.allyesconfig.dev_level.o
141328 14689 4220 160237 271ed drivers/ata/built-in.defconfig.ata.o
149567 14689 4220 168476 2921c drivers/ata/built-in.defconfig.dev_level.o
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
2011-04-16 02:51:59 +04:00
|
|
|
ata_port_info(ap,
|
|
|
|
"spurious interrupt (slot_stat 0x%x active_tag %d sactive 0x%x)\n",
|
2007-08-06 13:36:22 +04:00
|
|
|
slot_stat, ap->link.active_tag, ap->link.sactive);
|
2005-07-28 05:36:22 +04:00
|
|
|
}
|
|
|
|
|
IRQ: Maintain regs pointer globally rather than passing to IRQ handlers
Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
of passing regs around manually through all ~1800 interrupt handlers in the
Linux kernel.
The regs pointer is used in few places, but it potentially costs both stack
space and code to pass it around. On the FRV arch, removing the regs parameter
from all the genirq function results in a 20% speed up of the IRQ exit path
(ie: from leaving timer_interrupt() to leaving do_IRQ()).
Where appropriate, an arch may override the generic storage facility and do
something different with the variable. On FRV, for instance, the address is
maintained in GR28 at all times inside the kernel as part of general exception
handling.
Having looked over the code, it appears that the parameter may be handed down
through up to twenty or so layers of functions. Consider a USB character
device attached to a USB hub, attached to a USB controller that posts its
interrupts through a cascaded auxiliary interrupt controller. A character
device driver may want to pass regs to the sysrq handler through the input
layer which adds another few layers of parameter passing.
I've build this code with allyesconfig for x86_64 and i386. I've runtested the
main part of the code on FRV and i386, though I can't test most of the drivers.
I've also done partial conversion for powerpc and MIPS - these at least compile
with minimal configurations.
This will affect all archs. Mostly the changes should be relatively easy.
Take do_IRQ(), store the regs pointer at the beginning, saving the old one:
struct pt_regs *old_regs = set_irq_regs(regs);
And put the old one back at the end:
set_irq_regs(old_regs);
Don't pass regs through to generic_handle_irq() or __do_IRQ().
In timer_interrupt(), this sort of change will be necessary:
- update_process_times(user_mode(regs));
- profile_tick(CPU_PROFILING, regs);
+ update_process_times(user_mode(get_irq_regs()));
+ profile_tick(CPU_PROFILING);
I'd like to move update_process_times()'s use of get_irq_regs() into itself,
except that i386, alone of the archs, uses something other than user_mode().
Some notes on the interrupt handling in the drivers:
(*) input_dev() is now gone entirely. The regs pointer is no longer stored in
the input_dev struct.
(*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking. It does
something different depending on whether it's been supplied with a regs
pointer or not.
(*) Various IRQ handler function pointers have been moved to type
irq_handler_t.
Signed-Off-By: David Howells <dhowells@redhat.com>
(cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)
2006-10-05 17:55:46 +04:00
|
|
|
static irqreturn_t sil24_interrupt(int irq, void *dev_instance)
|
2005-07-28 05:36:22 +04:00
|
|
|
{
|
2006-08-24 11:19:22 +04:00
|
|
|
struct ata_host *host = dev_instance;
|
2007-02-01 09:06:36 +03:00
|
|
|
void __iomem *host_base = host->iomap[SIL24_HOST_BAR];
|
2005-07-28 05:36:22 +04:00
|
|
|
unsigned handled = 0;
|
|
|
|
u32 status;
|
|
|
|
int i;
|
|
|
|
|
2007-02-01 09:06:36 +03:00
|
|
|
status = readl(host_base + HOST_IRQ_STAT);
|
2005-07-28 05:36:22 +04:00
|
|
|
|
2005-08-17 08:08:52 +04:00
|
|
|
if (status == 0xffffffff) {
|
2014-07-22 17:28:00 +04:00
|
|
|
dev_err(host->dev, "IRQ status == 0xffffffff, "
|
|
|
|
"PCI fault or device removal?\n");
|
2005-08-17 08:08:52 +04:00
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
2005-07-28 05:36:22 +04:00
|
|
|
if (!(status & IRQ_STAT_4PORTS))
|
|
|
|
goto out;
|
|
|
|
|
2006-08-24 11:19:22 +04:00
|
|
|
spin_lock(&host->lock);
|
2005-07-28 05:36:22 +04:00
|
|
|
|
2006-08-24 11:19:22 +04:00
|
|
|
for (i = 0; i < host->n_ports; i++)
|
2005-07-28 05:36:22 +04:00
|
|
|
if (status & (1 << i)) {
|
2010-05-10 23:41:30 +04:00
|
|
|
sil24_host_intr(host->ports[i]);
|
|
|
|
handled++;
|
2005-07-28 05:36:22 +04:00
|
|
|
}
|
|
|
|
|
2006-08-24 11:19:22 +04:00
|
|
|
spin_unlock(&host->lock);
|
2005-07-28 05:36:22 +04:00
|
|
|
out:
|
|
|
|
return IRQ_RETVAL(handled);
|
|
|
|
}
|
|
|
|
|
2006-05-15 15:58:32 +04:00
|
|
|
static void sil24_error_handler(struct ata_port *ap)
|
|
|
|
{
|
2007-09-23 08:19:54 +04:00
|
|
|
struct sil24_port_priv *pp = ap->private_data;
|
|
|
|
|
2007-09-23 08:19:54 +04:00
|
|
|
if (sil24_init_port(ap))
|
2006-05-15 15:58:32 +04:00
|
|
|
ata_eh_freeze_port(ap);
|
|
|
|
|
libata: make reset related methods proper port operations
Currently reset methods are not specified directly in the
ata_port_operations table. If a LLD wants to use custom reset
methods, it should construct and use a error_handler which uses those
reset methods. It's done this way for two reasons.
First, the ops table already contained too many methods and adding
four more of them would noticeably increase the amount of necessary
boilerplate code all over low level drivers.
Second, as ->error_handler uses those reset methods, it can get
confusing. ie. By overriding ->error_handler, those reset ops can be
made useless making layering a bit hazy.
Now that ops table uses inheritance, the first problem doesn't exist
anymore. The second isn't completely solved but is relieved by
providing default values - most drivers can just override what it has
implemented and don't have to concern itself about higher level
callbacks. In fact, there currently is no driver which actually
modifies error handling behavior. Drivers which override
->error_handler just wraps the standard error handler only to prepare
the controller for EH. I don't think making ops layering strict has
any noticeable benefit.
This patch makes ->prereset, ->softreset, ->hardreset, ->postreset and
their PMP counterparts propoer ops. Default ops are provided in the
base ops tables and drivers are converted to override individual reset
methods instead of creating custom error_handler.
* ata_std_error_handler() doesn't use sata_std_hardreset() if SCRs
aren't accessible. sata_promise doesn't need to use separate
error_handlers for PATA and SATA anymore.
* softreset is broken for sata_inic162x and sata_sx4. As libata now
always prefers hardreset, this doesn't really matter but the ops are
forced to NULL using ATA_OP_NULL for documentation purpose.
* pata_hpt374 needs to use different prereset for the first and second
PCI functions. This used to be done by branching from
hpt374_error_handler(). The proper way to do this is to use
separate ops and port_info tables for each function. Converted.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-03-25 06:22:50 +03:00
|
|
|
sata_pmp_error_handler(ap);
|
2007-09-23 08:19:54 +04:00
|
|
|
|
|
|
|
pp->do_port_rst = 0;
|
2006-05-15 15:58:32 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
static void sil24_post_internal_cmd(struct ata_queued_cmd *qc)
|
|
|
|
{
|
|
|
|
struct ata_port *ap = qc->ap;
|
|
|
|
|
|
|
|
/* make DMA engine forget about the failed command */
|
2007-09-23 08:19:54 +04:00
|
|
|
if ((qc->flags & ATA_QCFLAG_FAILED) && sil24_init_port(ap))
|
|
|
|
ata_eh_freeze_port(ap);
|
2006-05-15 15:58:32 +04:00
|
|
|
}
|
|
|
|
|
2005-07-28 05:36:22 +04:00
|
|
|
static int sil24_port_start(struct ata_port *ap)
|
|
|
|
{
|
2006-08-24 11:19:22 +04:00
|
|
|
struct device *dev = ap->host->dev;
|
2005-07-28 05:36:22 +04:00
|
|
|
struct sil24_port_priv *pp;
|
2005-11-18 08:16:45 +03:00
|
|
|
union sil24_cmd_block *cb;
|
2006-05-15 16:03:56 +04:00
|
|
|
size_t cb_size = sizeof(*cb) * SIL24_MAX_CMDS;
|
2005-07-28 05:36:22 +04:00
|
|
|
dma_addr_t cb_dma;
|
|
|
|
|
2007-01-20 10:00:28 +03:00
|
|
|
pp = devm_kzalloc(dev, sizeof(*pp), GFP_KERNEL);
|
2005-07-28 05:36:22 +04:00
|
|
|
if (!pp)
|
2007-01-20 10:00:28 +03:00
|
|
|
return -ENOMEM;
|
2005-07-28 05:36:22 +04:00
|
|
|
|
2007-01-20 10:00:28 +03:00
|
|
|
cb = dmam_alloc_coherent(dev, cb_size, &cb_dma, GFP_KERNEL);
|
2005-11-05 06:08:00 +03:00
|
|
|
if (!cb)
|
2007-01-20 10:00:28 +03:00
|
|
|
return -ENOMEM;
|
2005-07-28 05:36:22 +04:00
|
|
|
memset(cb, 0, cb_size);
|
|
|
|
|
|
|
|
pp->cmd_block = cb;
|
|
|
|
pp->cmd_block_dma = cb_dma;
|
|
|
|
|
|
|
|
ap->private_data = pp;
|
|
|
|
|
2008-04-07 17:47:21 +04:00
|
|
|
ata_port_pbar_desc(ap, SIL24_HOST_BAR, -1, "host");
|
|
|
|
ata_port_pbar_desc(ap, SIL24_PORT_BAR, sil24_port_offset(ap), "port");
|
|
|
|
|
2005-07-28 05:36:22 +04:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
libata: convert the remaining SATA drivers to new init model
Convert ahci, sata_sil, sata_sil24, sata_svw, sata_qstor, sata_mv,
sata_sx4, sata_vsc and sata_inic162x to new init model.
Now that host and ap are available during intialization, functions are
converted to take either host or ap instead of low level parameters
which were inevitable for functions shared between init and other
paths. This simplifies code quite a bit.
* init_one()'s now follow more consistent init order
* ahci_setup_port() and ahci_host_init() collapsed into
ahci_init_one() for init order consistency
* sata_vsc uses port_info instead of setting fields manually
* in sata_svw, k2_board_info converted to port_info (info is now in
port flags). port number is honored now.
Tested on ICH7/8 AHCI, jmb360, sil3112, 3114, 3124 and 3132.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
2007-04-17 18:44:08 +04:00
|
|
|
static void sil24_init_controller(struct ata_host *host)
|
2006-07-03 11:07:27 +04:00
|
|
|
{
|
libata: convert the remaining SATA drivers to new init model
Convert ahci, sata_sil, sata_sil24, sata_svw, sata_qstor, sata_mv,
sata_sx4, sata_vsc and sata_inic162x to new init model.
Now that host and ap are available during intialization, functions are
converted to take either host or ap instead of low level parameters
which were inevitable for functions shared between init and other
paths. This simplifies code quite a bit.
* init_one()'s now follow more consistent init order
* ahci_setup_port() and ahci_host_init() collapsed into
ahci_init_one() for init order consistency
* sata_vsc uses port_info instead of setting fields manually
* in sata_svw, k2_board_info converted to port_info (info is now in
port flags). port number is honored now.
Tested on ICH7/8 AHCI, jmb360, sil3112, 3114, 3124 and 3132.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
2007-04-17 18:44:08 +04:00
|
|
|
void __iomem *host_base = host->iomap[SIL24_HOST_BAR];
|
2006-07-03 11:07:27 +04:00
|
|
|
u32 tmp;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
/* GPIO off */
|
|
|
|
writel(0, host_base + HOST_FLASH_CMD);
|
|
|
|
|
|
|
|
/* clear global reset & mask interrupts during initialization */
|
|
|
|
writel(0, host_base + HOST_CTRL);
|
|
|
|
|
|
|
|
/* init ports */
|
libata: convert the remaining SATA drivers to new init model
Convert ahci, sata_sil, sata_sil24, sata_svw, sata_qstor, sata_mv,
sata_sx4, sata_vsc and sata_inic162x to new init model.
Now that host and ap are available during intialization, functions are
converted to take either host or ap instead of low level parameters
which were inevitable for functions shared between init and other
paths. This simplifies code quite a bit.
* init_one()'s now follow more consistent init order
* ahci_setup_port() and ahci_host_init() collapsed into
ahci_init_one() for init order consistency
* sata_vsc uses port_info instead of setting fields manually
* in sata_svw, k2_board_info converted to port_info (info is now in
port flags). port number is honored now.
Tested on ICH7/8 AHCI, jmb360, sil3112, 3114, 3124 and 3132.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
2007-04-17 18:44:08 +04:00
|
|
|
for (i = 0; i < host->n_ports; i++) {
|
2007-09-23 08:19:54 +04:00
|
|
|
struct ata_port *ap = host->ports[i];
|
2008-04-07 17:47:21 +04:00
|
|
|
void __iomem *port = sil24_port_base(ap);
|
|
|
|
|
2006-07-03 11:07:27 +04:00
|
|
|
|
|
|
|
/* Initial PHY setting */
|
|
|
|
writel(0x20c, port + PORT_PHY_CFG);
|
|
|
|
|
|
|
|
/* Clear port RST */
|
|
|
|
tmp = readl(port + PORT_CTRL_STAT);
|
|
|
|
if (tmp & PORT_CS_PORT_RST) {
|
|
|
|
writel(PORT_CS_PORT_RST, port + PORT_CTRL_CLR);
|
2010-09-06 19:56:29 +04:00
|
|
|
tmp = ata_wait_register(NULL, port + PORT_CTRL_STAT,
|
2006-07-03 11:07:27 +04:00
|
|
|
PORT_CS_PORT_RST,
|
|
|
|
PORT_CS_PORT_RST, 10, 100);
|
|
|
|
if (tmp & PORT_CS_PORT_RST)
|
2011-04-16 02:51:58 +04:00
|
|
|
dev_err(host->dev,
|
|
|
|
"failed to clear port RST\n");
|
2006-07-03 11:07:27 +04:00
|
|
|
}
|
|
|
|
|
2007-09-23 08:19:54 +04:00
|
|
|
/* configure port */
|
|
|
|
sil24_config_port(ap);
|
2006-07-03 11:07:27 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
/* Turn on interrupts */
|
|
|
|
writel(IRQ_STAT_4PORTS, host_base + HOST_CTRL);
|
|
|
|
}
|
|
|
|
|
2005-07-28 05:36:22 +04:00
|
|
|
static int sil24_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
|
|
|
|
{
|
2007-11-22 12:46:57 +03:00
|
|
|
extern int __MARKER__sil24_cmd_block_is_sized_wrongly;
|
libata: convert the remaining SATA drivers to new init model
Convert ahci, sata_sil, sata_sil24, sata_svw, sata_qstor, sata_mv,
sata_sx4, sata_vsc and sata_inic162x to new init model.
Now that host and ap are available during intialization, functions are
converted to take either host or ap instead of low level parameters
which were inevitable for functions shared between init and other
paths. This simplifies code quite a bit.
* init_one()'s now follow more consistent init order
* ahci_setup_port() and ahci_host_init() collapsed into
ahci_init_one() for init order consistency
* sata_vsc uses port_info instead of setting fields manually
* in sata_svw, k2_board_info converted to port_info (info is now in
port flags). port number is honored now.
Tested on ICH7/8 AHCI, jmb360, sil3112, 3114, 3124 and 3132.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
2007-04-17 18:44:08 +04:00
|
|
|
struct ata_port_info pi = sil24_port_info[ent->driver_data];
|
|
|
|
const struct ata_port_info *ppi[] = { &pi, NULL };
|
|
|
|
void __iomem * const *iomap;
|
|
|
|
struct ata_host *host;
|
2008-04-07 17:47:21 +04:00
|
|
|
int rc;
|
2006-04-11 17:32:19 +04:00
|
|
|
u32 tmp;
|
2005-07-28 05:36:22 +04:00
|
|
|
|
2007-11-22 12:46:57 +03:00
|
|
|
/* cause link error if sil24_cmd_block is sized wrongly */
|
|
|
|
if (sizeof(union sil24_cmd_block) != PAGE_SIZE)
|
|
|
|
__MARKER__sil24_cmd_block_is_sized_wrongly = 1;
|
|
|
|
|
2011-04-16 02:52:00 +04:00
|
|
|
ata_print_version_once(&pdev->dev, DRV_VERSION);
|
2005-07-28 05:36:22 +04:00
|
|
|
|
libata: convert the remaining SATA drivers to new init model
Convert ahci, sata_sil, sata_sil24, sata_svw, sata_qstor, sata_mv,
sata_sx4, sata_vsc and sata_inic162x to new init model.
Now that host and ap are available during intialization, functions are
converted to take either host or ap instead of low level parameters
which were inevitable for functions shared between init and other
paths. This simplifies code quite a bit.
* init_one()'s now follow more consistent init order
* ahci_setup_port() and ahci_host_init() collapsed into
ahci_init_one() for init order consistency
* sata_vsc uses port_info instead of setting fields manually
* in sata_svw, k2_board_info converted to port_info (info is now in
port flags). port number is honored now.
Tested on ICH7/8 AHCI, jmb360, sil3112, 3114, 3124 and 3132.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
2007-04-17 18:44:08 +04:00
|
|
|
/* acquire resources */
|
2007-01-20 10:00:28 +03:00
|
|
|
rc = pcim_enable_device(pdev);
|
2005-07-28 05:36:22 +04:00
|
|
|
if (rc)
|
|
|
|
return rc;
|
|
|
|
|
2007-02-01 09:06:36 +03:00
|
|
|
rc = pcim_iomap_regions(pdev,
|
|
|
|
(1 << SIL24_HOST_BAR) | (1 << SIL24_PORT_BAR),
|
|
|
|
DRV_NAME);
|
2005-07-28 05:36:22 +04:00
|
|
|
if (rc)
|
2007-01-20 10:00:28 +03:00
|
|
|
return rc;
|
libata: convert the remaining SATA drivers to new init model
Convert ahci, sata_sil, sata_sil24, sata_svw, sata_qstor, sata_mv,
sata_sx4, sata_vsc and sata_inic162x to new init model.
Now that host and ap are available during intialization, functions are
converted to take either host or ap instead of low level parameters
which were inevitable for functions shared between init and other
paths. This simplifies code quite a bit.
* init_one()'s now follow more consistent init order
* ahci_setup_port() and ahci_host_init() collapsed into
ahci_init_one() for init order consistency
* sata_vsc uses port_info instead of setting fields manually
* in sata_svw, k2_board_info converted to port_info (info is now in
port flags). port number is honored now.
Tested on ICH7/8 AHCI, jmb360, sil3112, 3114, 3124 and 3132.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
2007-04-17 18:44:08 +04:00
|
|
|
iomap = pcim_iomap_table(pdev);
|
2005-07-28 05:36:22 +04:00
|
|
|
|
libata: convert the remaining SATA drivers to new init model
Convert ahci, sata_sil, sata_sil24, sata_svw, sata_qstor, sata_mv,
sata_sx4, sata_vsc and sata_inic162x to new init model.
Now that host and ap are available during intialization, functions are
converted to take either host or ap instead of low level parameters
which were inevitable for functions shared between init and other
paths. This simplifies code quite a bit.
* init_one()'s now follow more consistent init order
* ahci_setup_port() and ahci_host_init() collapsed into
ahci_init_one() for init order consistency
* sata_vsc uses port_info instead of setting fields manually
* in sata_svw, k2_board_info converted to port_info (info is now in
port flags). port number is honored now.
Tested on ICH7/8 AHCI, jmb360, sil3112, 3114, 3124 and 3132.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
2007-04-17 18:44:08 +04:00
|
|
|
/* apply workaround for completion IRQ loss on PCI-X errata */
|
|
|
|
if (pi.flags & SIL24_FLAG_PCIX_IRQ_WOC) {
|
|
|
|
tmp = readl(iomap[SIL24_HOST_BAR] + HOST_CTRL);
|
|
|
|
if (tmp & (HOST_CTRL_TRDY | HOST_CTRL_STOP | HOST_CTRL_DEVSEL))
|
2011-04-16 02:51:58 +04:00
|
|
|
dev_info(&pdev->dev,
|
|
|
|
"Applying completion IRQ loss on PCI-X errata fix\n");
|
libata: convert the remaining SATA drivers to new init model
Convert ahci, sata_sil, sata_sil24, sata_svw, sata_qstor, sata_mv,
sata_sx4, sata_vsc and sata_inic162x to new init model.
Now that host and ap are available during intialization, functions are
converted to take either host or ap instead of low level parameters
which were inevitable for functions shared between init and other
paths. This simplifies code quite a bit.
* init_one()'s now follow more consistent init order
* ahci_setup_port() and ahci_host_init() collapsed into
ahci_init_one() for init order consistency
* sata_vsc uses port_info instead of setting fields manually
* in sata_svw, k2_board_info converted to port_info (info is now in
port flags). port number is honored now.
Tested on ICH7/8 AHCI, jmb360, sil3112, 3114, 3124 and 3132.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
2007-04-17 18:44:08 +04:00
|
|
|
else
|
|
|
|
pi.flags &= ~SIL24_FLAG_PCIX_IRQ_WOC;
|
|
|
|
}
|
2005-07-28 05:36:22 +04:00
|
|
|
|
libata: convert the remaining SATA drivers to new init model
Convert ahci, sata_sil, sata_sil24, sata_svw, sata_qstor, sata_mv,
sata_sx4, sata_vsc and sata_inic162x to new init model.
Now that host and ap are available during intialization, functions are
converted to take either host or ap instead of low level parameters
which were inevitable for functions shared between init and other
paths. This simplifies code quite a bit.
* init_one()'s now follow more consistent init order
* ahci_setup_port() and ahci_host_init() collapsed into
ahci_init_one() for init order consistency
* sata_vsc uses port_info instead of setting fields manually
* in sata_svw, k2_board_info converted to port_info (info is now in
port flags). port number is honored now.
Tested on ICH7/8 AHCI, jmb360, sil3112, 3114, 3124 and 3132.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
2007-04-17 18:44:08 +04:00
|
|
|
/* allocate and fill host */
|
|
|
|
host = ata_host_alloc_pinfo(&pdev->dev, ppi,
|
|
|
|
SIL24_FLAG2NPORTS(ppi[0]->flags));
|
|
|
|
if (!host)
|
|
|
|
return -ENOMEM;
|
|
|
|
host->iomap = iomap;
|
2005-07-28 05:36:22 +04:00
|
|
|
|
libata: convert the remaining SATA drivers to new init model
Convert ahci, sata_sil, sata_sil24, sata_svw, sata_qstor, sata_mv,
sata_sx4, sata_vsc and sata_inic162x to new init model.
Now that host and ap are available during intialization, functions are
converted to take either host or ap instead of low level parameters
which were inevitable for functions shared between init and other
paths. This simplifies code quite a bit.
* init_one()'s now follow more consistent init order
* ahci_setup_port() and ahci_host_init() collapsed into
ahci_init_one() for init order consistency
* sata_vsc uses port_info instead of setting fields manually
* in sata_svw, k2_board_info converted to port_info (info is now in
port flags). port number is honored now.
Tested on ICH7/8 AHCI, jmb360, sil3112, 3114, 3124 and 3132.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
2007-04-17 18:44:08 +04:00
|
|
|
/* configure and activate the device */
|
ata: remove deprecated use of pci api
Replace occurences of the pci api by appropriate call to the dma api.
A simplified version of the semantic patch that finds this problem is as
follows: (http://coccinelle.lip6.fr)
@deprecated@
idexpression id;
position p;
@@
(
pci_dma_supported@p ( id, ...)
|
pci_alloc_consistent@p ( id, ...)
)
@bad1@
idexpression id;
position deprecated.p;
@@
...when != &id->dev
when != pci_get_drvdata ( id )
when != pci_enable_device ( id )
(
pci_dma_supported@p ( id, ...)
|
pci_alloc_consistent@p ( id, ...)
)
@depends on !bad1@
idexpression id;
expression direction;
position deprecated.p;
@@
(
- pci_dma_supported@p ( id,
+ dma_supported ( &id->dev,
...
+ , GFP_ATOMIC
)
|
- pci_alloc_consistent@p ( id,
+ dma_alloc_coherent ( &id->dev,
...
+ , GFP_ATOMIC
)
)
Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
2015-04-08 15:34:10 +03:00
|
|
|
if (!dma_set_mask(&pdev->dev, DMA_BIT_MASK(64))) {
|
|
|
|
rc = dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(64));
|
2006-04-11 17:32:19 +04:00
|
|
|
if (rc) {
|
ata: remove deprecated use of pci api
Replace occurences of the pci api by appropriate call to the dma api.
A simplified version of the semantic patch that finds this problem is as
follows: (http://coccinelle.lip6.fr)
@deprecated@
idexpression id;
position p;
@@
(
pci_dma_supported@p ( id, ...)
|
pci_alloc_consistent@p ( id, ...)
)
@bad1@
idexpression id;
position deprecated.p;
@@
...when != &id->dev
when != pci_get_drvdata ( id )
when != pci_enable_device ( id )
(
pci_dma_supported@p ( id, ...)
|
pci_alloc_consistent@p ( id, ...)
)
@depends on !bad1@
idexpression id;
expression direction;
position deprecated.p;
@@
(
- pci_dma_supported@p ( id,
+ dma_supported ( &id->dev,
...
+ , GFP_ATOMIC
)
|
- pci_alloc_consistent@p ( id,
+ dma_alloc_coherent ( &id->dev,
...
+ , GFP_ATOMIC
)
)
Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
2015-04-08 15:34:10 +03:00
|
|
|
rc = dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(32));
|
2006-04-11 17:32:19 +04:00
|
|
|
if (rc) {
|
2011-04-16 02:51:58 +04:00
|
|
|
dev_err(&pdev->dev,
|
|
|
|
"64-bit DMA enable failed\n");
|
2007-01-20 10:00:28 +03:00
|
|
|
return rc;
|
2006-04-11 17:32:19 +04:00
|
|
|
}
|
|
|
|
}
|
|
|
|
} else {
|
ata: remove deprecated use of pci api
Replace occurences of the pci api by appropriate call to the dma api.
A simplified version of the semantic patch that finds this problem is as
follows: (http://coccinelle.lip6.fr)
@deprecated@
idexpression id;
position p;
@@
(
pci_dma_supported@p ( id, ...)
|
pci_alloc_consistent@p ( id, ...)
)
@bad1@
idexpression id;
position deprecated.p;
@@
...when != &id->dev
when != pci_get_drvdata ( id )
when != pci_enable_device ( id )
(
pci_dma_supported@p ( id, ...)
|
pci_alloc_consistent@p ( id, ...)
)
@depends on !bad1@
idexpression id;
expression direction;
position deprecated.p;
@@
(
- pci_dma_supported@p ( id,
+ dma_supported ( &id->dev,
...
+ , GFP_ATOMIC
)
|
- pci_alloc_consistent@p ( id,
+ dma_alloc_coherent ( &id->dev,
...
+ , GFP_ATOMIC
)
)
Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
2015-04-08 15:34:10 +03:00
|
|
|
rc = dma_set_mask(&pdev->dev, DMA_BIT_MASK(32));
|
2006-04-11 17:32:19 +04:00
|
|
|
if (rc) {
|
2011-04-16 02:51:58 +04:00
|
|
|
dev_err(&pdev->dev, "32-bit DMA enable failed\n");
|
2007-01-20 10:00:28 +03:00
|
|
|
return rc;
|
2006-04-11 17:32:19 +04:00
|
|
|
}
|
ata: remove deprecated use of pci api
Replace occurences of the pci api by appropriate call to the dma api.
A simplified version of the semantic patch that finds this problem is as
follows: (http://coccinelle.lip6.fr)
@deprecated@
idexpression id;
position p;
@@
(
pci_dma_supported@p ( id, ...)
|
pci_alloc_consistent@p ( id, ...)
)
@bad1@
idexpression id;
position deprecated.p;
@@
...when != &id->dev
when != pci_get_drvdata ( id )
when != pci_enable_device ( id )
(
pci_dma_supported@p ( id, ...)
|
pci_alloc_consistent@p ( id, ...)
)
@depends on !bad1@
idexpression id;
expression direction;
position deprecated.p;
@@
(
- pci_dma_supported@p ( id,
+ dma_supported ( &id->dev,
...
+ , GFP_ATOMIC
)
|
- pci_alloc_consistent@p ( id,
+ dma_alloc_coherent ( &id->dev,
...
+ , GFP_ATOMIC
)
)
Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
2015-04-08 15:34:10 +03:00
|
|
|
rc = dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(32));
|
2006-04-11 17:32:19 +04:00
|
|
|
if (rc) {
|
2011-04-16 02:51:58 +04:00
|
|
|
dev_err(&pdev->dev,
|
|
|
|
"32-bit consistent DMA enable failed\n");
|
2007-01-20 10:00:28 +03:00
|
|
|
return rc;
|
2006-04-11 17:32:19 +04:00
|
|
|
}
|
2005-07-28 05:36:22 +04:00
|
|
|
}
|
|
|
|
|
2008-10-25 09:26:54 +04:00
|
|
|
/* Set max read request size to 4096. This slightly increases
|
|
|
|
* write throughput for pci-e variants.
|
|
|
|
*/
|
|
|
|
pcie_set_readrq(pdev, 4096);
|
|
|
|
|
libata: convert the remaining SATA drivers to new init model
Convert ahci, sata_sil, sata_sil24, sata_svw, sata_qstor, sata_mv,
sata_sx4, sata_vsc and sata_inic162x to new init model.
Now that host and ap are available during intialization, functions are
converted to take either host or ap instead of low level parameters
which were inevitable for functions shared between init and other
paths. This simplifies code quite a bit.
* init_one()'s now follow more consistent init order
* ahci_setup_port() and ahci_host_init() collapsed into
ahci_init_one() for init order consistency
* sata_vsc uses port_info instead of setting fields manually
* in sata_svw, k2_board_info converted to port_info (info is now in
port flags). port number is honored now.
Tested on ICH7/8 AHCI, jmb360, sil3112, 3114, 3124 and 3132.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
2007-04-17 18:44:08 +04:00
|
|
|
sil24_init_controller(host);
|
2005-07-28 05:36:22 +04:00
|
|
|
|
2009-11-16 09:19:22 +03:00
|
|
|
if (sata_sil24_msi && !pci_enable_msi(pdev)) {
|
2011-04-16 02:51:58 +04:00
|
|
|
dev_info(&pdev->dev, "Using MSI\n");
|
2009-11-16 09:19:22 +03:00
|
|
|
pci_intx(pdev, 0);
|
|
|
|
}
|
|
|
|
|
2005-07-28 05:36:22 +04:00
|
|
|
pci_set_master(pdev);
|
libata: convert the remaining SATA drivers to new init model
Convert ahci, sata_sil, sata_sil24, sata_svw, sata_qstor, sata_mv,
sata_sx4, sata_vsc and sata_inic162x to new init model.
Now that host and ap are available during intialization, functions are
converted to take either host or ap instead of low level parameters
which were inevitable for functions shared between init and other
paths. This simplifies code quite a bit.
* init_one()'s now follow more consistent init order
* ahci_setup_port() and ahci_host_init() collapsed into
ahci_init_one() for init order consistency
* sata_vsc uses port_info instead of setting fields manually
* in sata_svw, k2_board_info converted to port_info (info is now in
port flags). port number is honored now.
Tested on ICH7/8 AHCI, jmb360, sil3112, 3114, 3124 and 3132.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
2007-04-17 18:44:08 +04:00
|
|
|
return ata_host_activate(host, pdev->irq, sil24_interrupt, IRQF_SHARED,
|
|
|
|
&sil24_sht);
|
2005-07-28 05:36:22 +04:00
|
|
|
}
|
|
|
|
|
2014-05-07 19:17:44 +04:00
|
|
|
#ifdef CONFIG_PM_SLEEP
|
2006-07-03 11:07:27 +04:00
|
|
|
static int sil24_pci_device_resume(struct pci_dev *pdev)
|
|
|
|
{
|
2013-06-03 09:05:36 +04:00
|
|
|
struct ata_host *host = pci_get_drvdata(pdev);
|
2007-02-01 09:06:36 +03:00
|
|
|
void __iomem *host_base = host->iomap[SIL24_HOST_BAR];
|
2006-12-26 13:39:50 +03:00
|
|
|
int rc;
|
2006-07-03 11:07:27 +04:00
|
|
|
|
2006-12-26 13:39:50 +03:00
|
|
|
rc = ata_pci_device_do_resume(pdev);
|
|
|
|
if (rc)
|
|
|
|
return rc;
|
2006-07-03 11:07:27 +04:00
|
|
|
|
|
|
|
if (pdev->dev.power.power_state.event == PM_EVENT_SUSPEND)
|
2007-02-01 09:06:36 +03:00
|
|
|
writel(HOST_CTRL_GLOBAL_RST, host_base + HOST_CTRL);
|
2006-07-03 11:07:27 +04:00
|
|
|
|
libata: convert the remaining SATA drivers to new init model
Convert ahci, sata_sil, sata_sil24, sata_svw, sata_qstor, sata_mv,
sata_sx4, sata_vsc and sata_inic162x to new init model.
Now that host and ap are available during intialization, functions are
converted to take either host or ap instead of low level parameters
which were inevitable for functions shared between init and other
paths. This simplifies code quite a bit.
* init_one()'s now follow more consistent init order
* ahci_setup_port() and ahci_host_init() collapsed into
ahci_init_one() for init order consistency
* sata_vsc uses port_info instead of setting fields manually
* in sata_svw, k2_board_info converted to port_info (info is now in
port flags). port number is honored now.
Tested on ICH7/8 AHCI, jmb360, sil3112, 3114, 3124 and 3132.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
2007-04-17 18:44:08 +04:00
|
|
|
sil24_init_controller(host);
|
2006-07-03 11:07:27 +04:00
|
|
|
|
2006-08-24 11:19:22 +04:00
|
|
|
ata_host_resume(host);
|
2006-07-03 11:07:27 +04:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
2014-05-07 19:17:44 +04:00
|
|
|
#endif
|
2007-09-23 08:19:54 +04:00
|
|
|
|
2014-05-07 19:17:44 +04:00
|
|
|
#ifdef CONFIG_PM
|
2007-09-23 08:19:54 +04:00
|
|
|
static int sil24_port_resume(struct ata_port *ap)
|
|
|
|
{
|
|
|
|
sil24_config_pmp(ap, ap->nr_pmp_links);
|
|
|
|
return 0;
|
|
|
|
}
|
2006-08-15 09:49:30 +04:00
|
|
|
#endif
|
2006-07-03 11:07:27 +04:00
|
|
|
|
2012-04-19 09:43:05 +04:00
|
|
|
module_pci_driver(sil24_pci_driver);
|
2005-07-28 05:36:22 +04:00
|
|
|
|
|
|
|
MODULE_AUTHOR("Tejun Heo");
|
|
|
|
MODULE_DESCRIPTION("Silicon Image 3124/3132 SATA low-level driver");
|
|
|
|
MODULE_LICENSE("GPL");
|
|
|
|
MODULE_DEVICE_TABLE(pci, sil24_pci_tbl);
|