2005-04-17 02:20:36 +04:00
|
|
|
/*
|
|
|
|
* linux/fs/block_dev.c
|
|
|
|
*
|
|
|
|
* Copyright (C) 1991, 1992 Linus Torvalds
|
|
|
|
* Copyright (C) 2001 Andrea Arcangeli <andrea@suse.de> SuSE
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <linux/init.h>
|
|
|
|
#include <linux/mm.h>
|
|
|
|
#include <linux/fcntl.h>
|
|
|
|
#include <linux/slab.h>
|
|
|
|
#include <linux/kmod.h>
|
|
|
|
#include <linux/major.h>
|
|
|
|
#include <linux/smp_lock.h>
|
|
|
|
#include <linux/highmem.h>
|
|
|
|
#include <linux/blkdev.h>
|
|
|
|
#include <linux/module.h>
|
|
|
|
#include <linux/blkpg.h>
|
|
|
|
#include <linux/buffer_head.h>
|
|
|
|
#include <linux/mpage.h>
|
|
|
|
#include <linux/mount.h>
|
|
|
|
#include <linux/uio.h>
|
|
|
|
#include <linux/namei.h>
|
|
|
|
#include <asm/uaccess.h>
|
|
|
|
|
|
|
|
struct bdev_inode {
|
|
|
|
struct block_device bdev;
|
|
|
|
struct inode vfs_inode;
|
|
|
|
};
|
|
|
|
|
|
|
|
static inline struct bdev_inode *BDEV_I(struct inode *inode)
|
|
|
|
{
|
|
|
|
return container_of(inode, struct bdev_inode, vfs_inode);
|
|
|
|
}
|
|
|
|
|
|
|
|
inline struct block_device *I_BDEV(struct inode *inode)
|
|
|
|
{
|
|
|
|
return &BDEV_I(inode)->bdev;
|
|
|
|
}
|
|
|
|
|
|
|
|
EXPORT_SYMBOL(I_BDEV);
|
|
|
|
|
|
|
|
static sector_t max_block(struct block_device *bdev)
|
|
|
|
{
|
|
|
|
sector_t retval = ~((sector_t)0);
|
|
|
|
loff_t sz = i_size_read(bdev->bd_inode);
|
|
|
|
|
|
|
|
if (sz) {
|
|
|
|
unsigned int size = block_size(bdev);
|
|
|
|
unsigned int sizebits = blksize_bits(size);
|
|
|
|
retval = (sz >> sizebits);
|
|
|
|
}
|
|
|
|
return retval;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Kill _all_ buffers, dirty or not.. */
|
|
|
|
static void kill_bdev(struct block_device *bdev)
|
|
|
|
{
|
|
|
|
invalidate_bdev(bdev, 1);
|
|
|
|
truncate_inode_pages(bdev->bd_inode->i_mapping, 0);
|
|
|
|
}
|
|
|
|
|
|
|
|
int set_blocksize(struct block_device *bdev, int size)
|
|
|
|
{
|
|
|
|
/* Size must be a power of two, and between 512 and PAGE_SIZE */
|
|
|
|
if (size > PAGE_SIZE || size < 512 || (size & (size-1)))
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
/* Size cannot be smaller than the size supported by the device */
|
|
|
|
if (size < bdev_hardsect_size(bdev))
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
/* Don't change the size if it is same as current */
|
|
|
|
if (bdev->bd_block_size != size) {
|
|
|
|
sync_blockdev(bdev);
|
|
|
|
bdev->bd_block_size = size;
|
|
|
|
bdev->bd_inode->i_blkbits = blksize_bits(size);
|
|
|
|
kill_bdev(bdev);
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
EXPORT_SYMBOL(set_blocksize);
|
|
|
|
|
|
|
|
int sb_set_blocksize(struct super_block *sb, int size)
|
|
|
|
{
|
|
|
|
if (set_blocksize(sb->s_bdev, size))
|
|
|
|
return 0;
|
|
|
|
/* If we get here, we know size is power of two
|
|
|
|
* and it's value is between 512 and PAGE_SIZE */
|
|
|
|
sb->s_blocksize = size;
|
2006-03-24 14:18:05 +03:00
|
|
|
sb->s_blocksize_bits = blksize_bits(size);
|
2005-04-17 02:20:36 +04:00
|
|
|
return sb->s_blocksize;
|
|
|
|
}
|
|
|
|
|
|
|
|
EXPORT_SYMBOL(sb_set_blocksize);
|
|
|
|
|
|
|
|
int sb_min_blocksize(struct super_block *sb, int size)
|
|
|
|
{
|
|
|
|
int minsize = bdev_hardsect_size(sb->s_bdev);
|
|
|
|
if (size < minsize)
|
|
|
|
size = minsize;
|
|
|
|
return sb_set_blocksize(sb, size);
|
|
|
|
}
|
|
|
|
|
|
|
|
EXPORT_SYMBOL(sb_min_blocksize);
|
|
|
|
|
|
|
|
static int
|
|
|
|
blkdev_get_block(struct inode *inode, sector_t iblock,
|
|
|
|
struct buffer_head *bh, int create)
|
|
|
|
{
|
|
|
|
if (iblock >= max_block(I_BDEV(inode))) {
|
|
|
|
if (create)
|
|
|
|
return -EIO;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* for reads, we're just trying to fill a partial page.
|
|
|
|
* return a hole, they will have to call get_block again
|
|
|
|
* before they can fill it, and they will get -EIO at that
|
|
|
|
* time
|
|
|
|
*/
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
bh->b_bdev = I_BDEV(inode);
|
|
|
|
bh->b_blocknr = iblock;
|
|
|
|
set_buffer_mapped(bh);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
|
|
|
blkdev_get_blocks(struct inode *inode, sector_t iblock,
|
2006-03-26 13:38:02 +04:00
|
|
|
struct buffer_head *bh, int create)
|
2005-04-17 02:20:36 +04:00
|
|
|
{
|
|
|
|
sector_t end_block = max_block(I_BDEV(inode));
|
2006-03-26 13:38:02 +04:00
|
|
|
unsigned long max_blocks = bh->b_size >> inode->i_blkbits;
|
2005-04-17 02:20:36 +04:00
|
|
|
|
|
|
|
if ((iblock + max_blocks) > end_block) {
|
|
|
|
max_blocks = end_block - iblock;
|
|
|
|
if ((long)max_blocks <= 0) {
|
|
|
|
if (create)
|
|
|
|
return -EIO; /* write fully beyond EOF */
|
|
|
|
/*
|
|
|
|
* It is a read which is fully beyond EOF. We return
|
|
|
|
* a !buffer_mapped buffer
|
|
|
|
*/
|
|
|
|
max_blocks = 0;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
bh->b_bdev = I_BDEV(inode);
|
|
|
|
bh->b_blocknr = iblock;
|
|
|
|
bh->b_size = max_blocks << inode->i_blkbits;
|
|
|
|
if (max_blocks)
|
|
|
|
set_buffer_mapped(bh);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static ssize_t
|
|
|
|
blkdev_direct_IO(int rw, struct kiocb *iocb, const struct iovec *iov,
|
|
|
|
loff_t offset, unsigned long nr_segs)
|
|
|
|
{
|
|
|
|
struct file *file = iocb->ki_filp;
|
|
|
|
struct inode *inode = file->f_mapping->host;
|
|
|
|
|
|
|
|
return blockdev_direct_IO_no_locking(rw, iocb, inode, I_BDEV(inode),
|
|
|
|
iov, offset, nr_segs, blkdev_get_blocks, NULL);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int blkdev_writepage(struct page *page, struct writeback_control *wbc)
|
|
|
|
{
|
|
|
|
return block_write_full_page(page, blkdev_get_block, wbc);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int blkdev_readpage(struct file * file, struct page * page)
|
|
|
|
{
|
|
|
|
return block_read_full_page(page, blkdev_get_block);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int blkdev_prepare_write(struct file *file, struct page *page, unsigned from, unsigned to)
|
|
|
|
{
|
|
|
|
return block_prepare_write(page, from, to, blkdev_get_block);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int blkdev_commit_write(struct file *file, struct page *page, unsigned from, unsigned to)
|
|
|
|
{
|
|
|
|
return block_commit_write(page, from, to);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* private llseek:
|
|
|
|
* for a block special file file->f_dentry->d_inode->i_size is zero
|
|
|
|
* so we compute the size by hand (just as in block_read/write above)
|
|
|
|
*/
|
|
|
|
static loff_t block_llseek(struct file *file, loff_t offset, int origin)
|
|
|
|
{
|
|
|
|
struct inode *bd_inode = file->f_mapping->host;
|
|
|
|
loff_t size;
|
|
|
|
loff_t retval;
|
|
|
|
|
2006-01-10 02:59:24 +03:00
|
|
|
mutex_lock(&bd_inode->i_mutex);
|
2005-04-17 02:20:36 +04:00
|
|
|
size = i_size_read(bd_inode);
|
|
|
|
|
|
|
|
switch (origin) {
|
|
|
|
case 2:
|
|
|
|
offset += size;
|
|
|
|
break;
|
|
|
|
case 1:
|
|
|
|
offset += file->f_pos;
|
|
|
|
}
|
|
|
|
retval = -EINVAL;
|
|
|
|
if (offset >= 0 && offset <= size) {
|
|
|
|
if (offset != file->f_pos) {
|
|
|
|
file->f_pos = offset;
|
|
|
|
}
|
|
|
|
retval = offset;
|
|
|
|
}
|
2006-01-10 02:59:24 +03:00
|
|
|
mutex_unlock(&bd_inode->i_mutex);
|
2005-04-17 02:20:36 +04:00
|
|
|
return retval;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Filp is never NULL; the only case when ->fsync() is called with
|
|
|
|
* NULL first argument is nfsd_sync_dir() and that's not a directory.
|
|
|
|
*/
|
|
|
|
|
|
|
|
static int block_fsync(struct file *filp, struct dentry *dentry, int datasync)
|
|
|
|
{
|
|
|
|
return sync_blockdev(I_BDEV(filp->f_mapping->host));
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* pseudo-fs
|
|
|
|
*/
|
|
|
|
|
|
|
|
static __cacheline_aligned_in_smp DEFINE_SPINLOCK(bdev_lock);
|
2006-03-26 13:37:24 +04:00
|
|
|
static kmem_cache_t * bdev_cachep __read_mostly;
|
2005-04-17 02:20:36 +04:00
|
|
|
|
|
|
|
static struct inode *bdev_alloc_inode(struct super_block *sb)
|
|
|
|
{
|
|
|
|
struct bdev_inode *ei = kmem_cache_alloc(bdev_cachep, SLAB_KERNEL);
|
|
|
|
if (!ei)
|
|
|
|
return NULL;
|
|
|
|
return &ei->vfs_inode;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void bdev_destroy_inode(struct inode *inode)
|
|
|
|
{
|
|
|
|
struct bdev_inode *bdi = BDEV_I(inode);
|
|
|
|
|
|
|
|
bdi->bdev.bd_inode_backing_dev_info = NULL;
|
|
|
|
kmem_cache_free(bdev_cachep, bdi);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void init_once(void * foo, kmem_cache_t * cachep, unsigned long flags)
|
|
|
|
{
|
|
|
|
struct bdev_inode *ei = (struct bdev_inode *) foo;
|
|
|
|
struct block_device *bdev = &ei->bdev;
|
|
|
|
|
|
|
|
if ((flags & (SLAB_CTOR_VERIFY|SLAB_CTOR_CONSTRUCTOR)) ==
|
|
|
|
SLAB_CTOR_CONSTRUCTOR)
|
|
|
|
{
|
|
|
|
memset(bdev, 0, sizeof(*bdev));
|
2006-03-23 14:00:28 +03:00
|
|
|
mutex_init(&bdev->bd_mutex);
|
|
|
|
mutex_init(&bdev->bd_mount_mutex);
|
2005-04-17 02:20:36 +04:00
|
|
|
INIT_LIST_HEAD(&bdev->bd_inodes);
|
|
|
|
INIT_LIST_HEAD(&bdev->bd_list);
|
2006-03-27 13:17:57 +04:00
|
|
|
#ifdef CONFIG_SYSFS
|
|
|
|
INIT_LIST_HEAD(&bdev->bd_holder_list);
|
|
|
|
#endif
|
2005-04-17 02:20:36 +04:00
|
|
|
inode_init_once(&ei->vfs_inode);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline void __bd_forget(struct inode *inode)
|
|
|
|
{
|
|
|
|
list_del_init(&inode->i_devices);
|
|
|
|
inode->i_bdev = NULL;
|
|
|
|
inode->i_mapping = &inode->i_data;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void bdev_clear_inode(struct inode *inode)
|
|
|
|
{
|
|
|
|
struct block_device *bdev = &BDEV_I(inode)->bdev;
|
|
|
|
struct list_head *p;
|
|
|
|
spin_lock(&bdev_lock);
|
|
|
|
while ( (p = bdev->bd_inodes.next) != &bdev->bd_inodes ) {
|
|
|
|
__bd_forget(list_entry(p, struct inode, i_devices));
|
|
|
|
}
|
|
|
|
list_del_init(&bdev->bd_list);
|
|
|
|
spin_unlock(&bdev_lock);
|
|
|
|
}
|
|
|
|
|
|
|
|
static struct super_operations bdev_sops = {
|
|
|
|
.statfs = simple_statfs,
|
|
|
|
.alloc_inode = bdev_alloc_inode,
|
|
|
|
.destroy_inode = bdev_destroy_inode,
|
|
|
|
.drop_inode = generic_delete_inode,
|
|
|
|
.clear_inode = bdev_clear_inode,
|
|
|
|
};
|
|
|
|
|
[PATCH] VFS: Permit filesystem to override root dentry on mount
Extend the get_sb() filesystem operation to take an extra argument that
permits the VFS to pass in the target vfsmount that defines the mountpoint.
The filesystem is then required to manually set the superblock and root dentry
pointers. For most filesystems, this should be done with simple_set_mnt()
which will set the superblock pointer and then set the root dentry to the
superblock's s_root (as per the old default behaviour).
The get_sb() op now returns an integer as there's now no need to return the
superblock pointer.
This patch permits a superblock to be implicitly shared amongst several mount
points, such as can be done with NFS to avoid potential inode aliasing. In
such a case, simple_set_mnt() would not be called, and instead the mnt_root
and mnt_sb would be set directly.
The patch also makes the following changes:
(*) the get_sb_*() convenience functions in the core kernel now take a vfsmount
pointer argument and return an integer, so most filesystems have to change
very little.
(*) If one of the convenience function is not used, then get_sb() should
normally call simple_set_mnt() to instantiate the vfsmount. This will
always return 0, and so can be tail-called from get_sb().
(*) generic_shutdown_super() now calls shrink_dcache_sb() to clean up the
dcache upon superblock destruction rather than shrink_dcache_anon().
This is required because the superblock may now have multiple trees that
aren't actually bound to s_root, but that still need to be cleaned up. The
currently called functions assume that the whole tree is rooted at s_root,
and that anonymous dentries are not the roots of trees which results in
dentries being left unculled.
However, with the way NFS superblock sharing are currently set to be
implemented, these assumptions are violated: the root of the filesystem is
simply a dummy dentry and inode (the real inode for '/' may well be
inaccessible), and all the vfsmounts are rooted on anonymous[*] dentries
with child trees.
[*] Anonymous until discovered from another tree.
(*) The documentation has been adjusted, including the additional bit of
changing ext2_* into foo_* in the documentation.
[akpm@osdl.org: convert ipath_fs, do other stuff]
Signed-off-by: David Howells <dhowells@redhat.com>
Acked-by: Al Viro <viro@zeniv.linux.org.uk>
Cc: Nathan Scott <nathans@sgi.com>
Cc: Roland Dreier <rolandd@cisco.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2006-06-23 13:02:57 +04:00
|
|
|
static int bd_get_sb(struct file_system_type *fs_type,
|
|
|
|
int flags, const char *dev_name, void *data, struct vfsmount *mnt)
|
2005-04-17 02:20:36 +04:00
|
|
|
{
|
[PATCH] VFS: Permit filesystem to override root dentry on mount
Extend the get_sb() filesystem operation to take an extra argument that
permits the VFS to pass in the target vfsmount that defines the mountpoint.
The filesystem is then required to manually set the superblock and root dentry
pointers. For most filesystems, this should be done with simple_set_mnt()
which will set the superblock pointer and then set the root dentry to the
superblock's s_root (as per the old default behaviour).
The get_sb() op now returns an integer as there's now no need to return the
superblock pointer.
This patch permits a superblock to be implicitly shared amongst several mount
points, such as can be done with NFS to avoid potential inode aliasing. In
such a case, simple_set_mnt() would not be called, and instead the mnt_root
and mnt_sb would be set directly.
The patch also makes the following changes:
(*) the get_sb_*() convenience functions in the core kernel now take a vfsmount
pointer argument and return an integer, so most filesystems have to change
very little.
(*) If one of the convenience function is not used, then get_sb() should
normally call simple_set_mnt() to instantiate the vfsmount. This will
always return 0, and so can be tail-called from get_sb().
(*) generic_shutdown_super() now calls shrink_dcache_sb() to clean up the
dcache upon superblock destruction rather than shrink_dcache_anon().
This is required because the superblock may now have multiple trees that
aren't actually bound to s_root, but that still need to be cleaned up. The
currently called functions assume that the whole tree is rooted at s_root,
and that anonymous dentries are not the roots of trees which results in
dentries being left unculled.
However, with the way NFS superblock sharing are currently set to be
implemented, these assumptions are violated: the root of the filesystem is
simply a dummy dentry and inode (the real inode for '/' may well be
inaccessible), and all the vfsmounts are rooted on anonymous[*] dentries
with child trees.
[*] Anonymous until discovered from another tree.
(*) The documentation has been adjusted, including the additional bit of
changing ext2_* into foo_* in the documentation.
[akpm@osdl.org: convert ipath_fs, do other stuff]
Signed-off-by: David Howells <dhowells@redhat.com>
Acked-by: Al Viro <viro@zeniv.linux.org.uk>
Cc: Nathan Scott <nathans@sgi.com>
Cc: Roland Dreier <rolandd@cisco.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2006-06-23 13:02:57 +04:00
|
|
|
return get_sb_pseudo(fs_type, "bdev:", &bdev_sops, 0x62646576, mnt);
|
2005-04-17 02:20:36 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
static struct file_system_type bd_type = {
|
|
|
|
.name = "bdev",
|
|
|
|
.get_sb = bd_get_sb,
|
|
|
|
.kill_sb = kill_anon_super,
|
|
|
|
};
|
|
|
|
|
2006-03-26 13:37:24 +04:00
|
|
|
static struct vfsmount *bd_mnt __read_mostly;
|
2005-04-17 02:20:36 +04:00
|
|
|
struct super_block *blockdev_superblock;
|
|
|
|
|
|
|
|
void __init bdev_cache_init(void)
|
|
|
|
{
|
|
|
|
int err;
|
|
|
|
bdev_cachep = kmem_cache_create("bdev_cache", sizeof(struct bdev_inode),
|
2006-03-24 14:16:06 +03:00
|
|
|
0, (SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT|
|
|
|
|
SLAB_MEM_SPREAD|SLAB_PANIC),
|
2005-04-17 02:20:36 +04:00
|
|
|
init_once, NULL);
|
|
|
|
err = register_filesystem(&bd_type);
|
|
|
|
if (err)
|
|
|
|
panic("Cannot register bdev pseudo-fs");
|
|
|
|
bd_mnt = kern_mount(&bd_type);
|
|
|
|
err = PTR_ERR(bd_mnt);
|
|
|
|
if (IS_ERR(bd_mnt))
|
|
|
|
panic("Cannot create bdev pseudo-fs");
|
|
|
|
blockdev_superblock = bd_mnt->mnt_sb; /* For writeback */
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Most likely _very_ bad one - but then it's hardly critical for small
|
|
|
|
* /dev and can be fixed when somebody will need really large one.
|
|
|
|
* Keep in mind that it will be fed through icache hash function too.
|
|
|
|
*/
|
|
|
|
static inline unsigned long hash(dev_t dev)
|
|
|
|
{
|
|
|
|
return MAJOR(dev)+MINOR(dev);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int bdev_test(struct inode *inode, void *data)
|
|
|
|
{
|
|
|
|
return BDEV_I(inode)->bdev.bd_dev == *(dev_t *)data;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int bdev_set(struct inode *inode, void *data)
|
|
|
|
{
|
|
|
|
BDEV_I(inode)->bdev.bd_dev = *(dev_t *)data;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static LIST_HEAD(all_bdevs);
|
|
|
|
|
|
|
|
struct block_device *bdget(dev_t dev)
|
|
|
|
{
|
|
|
|
struct block_device *bdev;
|
|
|
|
struct inode *inode;
|
|
|
|
|
|
|
|
inode = iget5_locked(bd_mnt->mnt_sb, hash(dev),
|
|
|
|
bdev_test, bdev_set, &dev);
|
|
|
|
|
|
|
|
if (!inode)
|
|
|
|
return NULL;
|
|
|
|
|
|
|
|
bdev = &BDEV_I(inode)->bdev;
|
|
|
|
|
|
|
|
if (inode->i_state & I_NEW) {
|
|
|
|
bdev->bd_contains = NULL;
|
|
|
|
bdev->bd_inode = inode;
|
|
|
|
bdev->bd_block_size = (1 << inode->i_blkbits);
|
|
|
|
bdev->bd_part_count = 0;
|
|
|
|
bdev->bd_invalidated = 0;
|
|
|
|
inode->i_mode = S_IFBLK;
|
|
|
|
inode->i_rdev = dev;
|
|
|
|
inode->i_bdev = bdev;
|
|
|
|
inode->i_data.a_ops = &def_blk_aops;
|
|
|
|
mapping_set_gfp_mask(&inode->i_data, GFP_USER);
|
|
|
|
inode->i_data.backing_dev_info = &default_backing_dev_info;
|
|
|
|
spin_lock(&bdev_lock);
|
|
|
|
list_add(&bdev->bd_list, &all_bdevs);
|
|
|
|
spin_unlock(&bdev_lock);
|
|
|
|
unlock_new_inode(inode);
|
|
|
|
}
|
|
|
|
return bdev;
|
|
|
|
}
|
|
|
|
|
|
|
|
EXPORT_SYMBOL(bdget);
|
|
|
|
|
|
|
|
long nr_blockdev_pages(void)
|
|
|
|
{
|
|
|
|
struct list_head *p;
|
|
|
|
long ret = 0;
|
|
|
|
spin_lock(&bdev_lock);
|
|
|
|
list_for_each(p, &all_bdevs) {
|
|
|
|
struct block_device *bdev;
|
|
|
|
bdev = list_entry(p, struct block_device, bd_list);
|
|
|
|
ret += bdev->bd_inode->i_mapping->nrpages;
|
|
|
|
}
|
|
|
|
spin_unlock(&bdev_lock);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
void bdput(struct block_device *bdev)
|
|
|
|
{
|
|
|
|
iput(bdev->bd_inode);
|
|
|
|
}
|
|
|
|
|
|
|
|
EXPORT_SYMBOL(bdput);
|
|
|
|
|
|
|
|
static struct block_device *bd_acquire(struct inode *inode)
|
|
|
|
{
|
|
|
|
struct block_device *bdev;
|
2006-06-23 01:47:21 +04:00
|
|
|
|
2005-04-17 02:20:36 +04:00
|
|
|
spin_lock(&bdev_lock);
|
|
|
|
bdev = inode->i_bdev;
|
2006-06-23 01:47:21 +04:00
|
|
|
if (bdev) {
|
|
|
|
atomic_inc(&bdev->bd_inode->i_count);
|
2005-04-17 02:20:36 +04:00
|
|
|
spin_unlock(&bdev_lock);
|
|
|
|
return bdev;
|
|
|
|
}
|
|
|
|
spin_unlock(&bdev_lock);
|
2006-06-23 01:47:21 +04:00
|
|
|
|
2005-04-17 02:20:36 +04:00
|
|
|
bdev = bdget(inode->i_rdev);
|
|
|
|
if (bdev) {
|
|
|
|
spin_lock(&bdev_lock);
|
2006-06-23 01:47:21 +04:00
|
|
|
if (!inode->i_bdev) {
|
|
|
|
/*
|
|
|
|
* We take an additional bd_inode->i_count for inode,
|
|
|
|
* and it's released in clear_inode() of inode.
|
|
|
|
* So, we can access it via ->i_mapping always
|
|
|
|
* without igrab().
|
|
|
|
*/
|
|
|
|
atomic_inc(&bdev->bd_inode->i_count);
|
|
|
|
inode->i_bdev = bdev;
|
|
|
|
inode->i_mapping = bdev->bd_inode->i_mapping;
|
|
|
|
list_add(&inode->i_devices, &bdev->bd_inodes);
|
|
|
|
}
|
2005-04-17 02:20:36 +04:00
|
|
|
spin_unlock(&bdev_lock);
|
|
|
|
}
|
|
|
|
return bdev;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Call when you free inode */
|
|
|
|
|
|
|
|
void bd_forget(struct inode *inode)
|
|
|
|
{
|
2006-06-23 01:47:21 +04:00
|
|
|
struct block_device *bdev = NULL;
|
|
|
|
|
2005-04-17 02:20:36 +04:00
|
|
|
spin_lock(&bdev_lock);
|
2006-06-23 01:47:21 +04:00
|
|
|
if (inode->i_bdev) {
|
|
|
|
if (inode->i_sb != blockdev_superblock)
|
|
|
|
bdev = inode->i_bdev;
|
2005-04-17 02:20:36 +04:00
|
|
|
__bd_forget(inode);
|
2006-06-23 01:47:21 +04:00
|
|
|
}
|
2005-04-17 02:20:36 +04:00
|
|
|
spin_unlock(&bdev_lock);
|
2006-06-23 01:47:21 +04:00
|
|
|
|
|
|
|
if (bdev)
|
|
|
|
iput(bdev->bd_inode);
|
2005-04-17 02:20:36 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
int bd_claim(struct block_device *bdev, void *holder)
|
|
|
|
{
|
|
|
|
int res;
|
|
|
|
spin_lock(&bdev_lock);
|
|
|
|
|
|
|
|
/* first decide result */
|
|
|
|
if (bdev->bd_holder == holder)
|
|
|
|
res = 0; /* already a holder */
|
|
|
|
else if (bdev->bd_holder != NULL)
|
|
|
|
res = -EBUSY; /* held by someone else */
|
|
|
|
else if (bdev->bd_contains == bdev)
|
|
|
|
res = 0; /* is a whole device which isn't held */
|
|
|
|
|
|
|
|
else if (bdev->bd_contains->bd_holder == bd_claim)
|
|
|
|
res = 0; /* is a partition of a device that is being partitioned */
|
|
|
|
else if (bdev->bd_contains->bd_holder != NULL)
|
|
|
|
res = -EBUSY; /* is a partition of a held device */
|
|
|
|
else
|
|
|
|
res = 0; /* is a partition of an un-held device */
|
|
|
|
|
|
|
|
/* now impose change */
|
|
|
|
if (res==0) {
|
|
|
|
/* note that for a whole device bd_holders
|
|
|
|
* will be incremented twice, and bd_holder will
|
|
|
|
* be set to bd_claim before being set to holder
|
|
|
|
*/
|
|
|
|
bdev->bd_contains->bd_holders ++;
|
|
|
|
bdev->bd_contains->bd_holder = bd_claim;
|
|
|
|
bdev->bd_holders++;
|
|
|
|
bdev->bd_holder = holder;
|
|
|
|
}
|
|
|
|
spin_unlock(&bdev_lock);
|
|
|
|
return res;
|
|
|
|
}
|
|
|
|
|
|
|
|
EXPORT_SYMBOL(bd_claim);
|
|
|
|
|
|
|
|
void bd_release(struct block_device *bdev)
|
|
|
|
{
|
|
|
|
spin_lock(&bdev_lock);
|
|
|
|
if (!--bdev->bd_contains->bd_holders)
|
|
|
|
bdev->bd_contains->bd_holder = NULL;
|
|
|
|
if (!--bdev->bd_holders)
|
|
|
|
bdev->bd_holder = NULL;
|
|
|
|
spin_unlock(&bdev_lock);
|
|
|
|
}
|
|
|
|
|
|
|
|
EXPORT_SYMBOL(bd_release);
|
|
|
|
|
2006-03-27 13:17:57 +04:00
|
|
|
#ifdef CONFIG_SYSFS
|
|
|
|
/*
|
|
|
|
* Functions for bd_claim_by_kobject / bd_release_from_kobject
|
|
|
|
*
|
|
|
|
* If a kobject is passed to bd_claim_by_kobject()
|
|
|
|
* and the kobject has a parent directory,
|
|
|
|
* following symlinks are created:
|
|
|
|
* o from the kobject to the claimed bdev
|
|
|
|
* o from "holders" directory of the bdev to the parent of the kobject
|
|
|
|
* bd_release_from_kobject() removes these symlinks.
|
|
|
|
*
|
|
|
|
* Example:
|
|
|
|
* If /dev/dm-0 maps to /dev/sda, kobject corresponding to
|
|
|
|
* /sys/block/dm-0/slaves is passed to bd_claim_by_kobject(), then:
|
|
|
|
* /sys/block/dm-0/slaves/sda --> /sys/block/sda
|
|
|
|
* /sys/block/sda/holders/dm-0 --> /sys/block/dm-0
|
|
|
|
*/
|
|
|
|
|
|
|
|
static struct kobject *bdev_get_kobj(struct block_device *bdev)
|
|
|
|
{
|
|
|
|
if (bdev->bd_contains != bdev)
|
|
|
|
return kobject_get(&bdev->bd_part->kobj);
|
|
|
|
else
|
|
|
|
return kobject_get(&bdev->bd_disk->kobj);
|
|
|
|
}
|
|
|
|
|
|
|
|
static struct kobject *bdev_get_holder(struct block_device *bdev)
|
|
|
|
{
|
|
|
|
if (bdev->bd_contains != bdev)
|
|
|
|
return kobject_get(bdev->bd_part->holder_dir);
|
|
|
|
else
|
|
|
|
return kobject_get(bdev->bd_disk->holder_dir);
|
|
|
|
}
|
|
|
|
|
[PATCH] blockdev.c: check driver layer errors
Check driver layer errors.
Fix from: "Jun'ichi Nomura" <j-nomura@ce.jp.nec.com>
In blockdevc-check-errors.patch, add_bd_holder() is modified to return error
values when some of its operation failed. Among them, it returns -EEXIST when
a given bd_holder object already exists in the list.
However, in this case, the function completed its work successfully and need
no action by its caller other than freeing unused bd_holder object. So I
think it's better to return success after freeing by itself.
Otherwise, bd_claim-ing with same claim pointer will fail.
Typically, lvresize will fails with following message:
device-mapper: reload ioctl failed: Invalid argument
and you'll see messages like below in kernel log:
device-mapper: table: 254:13: linear: dm-linear: Device lookup failed
device-mapper: ioctl: error adding target to table
Similarly, it should not add bd_holder to the list if either one of symlinking
fails. I don't have a test case for this to happen but it should cause
dereference of freed pointer.
If a matching bd_holder is found in bd_holder_list, add_bd_holder() completes
its job by just incrementing the reference count. In this case, it should be
considered as success but it used to return 'fail' to let the caller free
temporary bd_holder. Fixed it to return success and free given object by
itself.
Also, if either one of symlinking fails, the bd_holder should not be added to
the list so that it can be discarded later. Otherwise, the caller will free
bd_holder which is in the list.
Signed-off-by: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
Cc: "Randy.Dunlap" <rdunlap@xenotime.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2006-09-29 12:58:56 +04:00
|
|
|
static int add_symlink(struct kobject *from, struct kobject *to)
|
2006-03-27 13:17:57 +04:00
|
|
|
{
|
|
|
|
if (!from || !to)
|
[PATCH] blockdev.c: check driver layer errors
Check driver layer errors.
Fix from: "Jun'ichi Nomura" <j-nomura@ce.jp.nec.com>
In blockdevc-check-errors.patch, add_bd_holder() is modified to return error
values when some of its operation failed. Among them, it returns -EEXIST when
a given bd_holder object already exists in the list.
However, in this case, the function completed its work successfully and need
no action by its caller other than freeing unused bd_holder object. So I
think it's better to return success after freeing by itself.
Otherwise, bd_claim-ing with same claim pointer will fail.
Typically, lvresize will fails with following message:
device-mapper: reload ioctl failed: Invalid argument
and you'll see messages like below in kernel log:
device-mapper: table: 254:13: linear: dm-linear: Device lookup failed
device-mapper: ioctl: error adding target to table
Similarly, it should not add bd_holder to the list if either one of symlinking
fails. I don't have a test case for this to happen but it should cause
dereference of freed pointer.
If a matching bd_holder is found in bd_holder_list, add_bd_holder() completes
its job by just incrementing the reference count. In this case, it should be
considered as success but it used to return 'fail' to let the caller free
temporary bd_holder. Fixed it to return success and free given object by
itself.
Also, if either one of symlinking fails, the bd_holder should not be added to
the list so that it can be discarded later. Otherwise, the caller will free
bd_holder which is in the list.
Signed-off-by: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
Cc: "Randy.Dunlap" <rdunlap@xenotime.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2006-09-29 12:58:56 +04:00
|
|
|
return 0;
|
|
|
|
return sysfs_create_link(from, to, kobject_name(to));
|
2006-03-27 13:17:57 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
static void del_symlink(struct kobject *from, struct kobject *to)
|
|
|
|
{
|
|
|
|
if (!from || !to)
|
|
|
|
return;
|
|
|
|
sysfs_remove_link(from, kobject_name(to));
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* 'struct bd_holder' contains pointers to kobjects symlinked by
|
|
|
|
* bd_claim_by_kobject.
|
|
|
|
* It's connected to bd_holder_list which is protected by bdev->bd_sem.
|
|
|
|
*/
|
|
|
|
struct bd_holder {
|
|
|
|
struct list_head list; /* chain of holders of the bdev */
|
|
|
|
int count; /* references from the holder */
|
|
|
|
struct kobject *sdir; /* holder object, e.g. "/block/dm-0/slaves" */
|
|
|
|
struct kobject *hdev; /* e.g. "/block/dm-0" */
|
|
|
|
struct kobject *hdir; /* e.g. "/block/sda/holders" */
|
|
|
|
struct kobject *sdev; /* e.g. "/block/sda" */
|
|
|
|
};
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Get references of related kobjects at once.
|
|
|
|
* Returns 1 on success. 0 on failure.
|
|
|
|
*
|
|
|
|
* Should call bd_holder_release_dirs() after successful use.
|
|
|
|
*/
|
|
|
|
static int bd_holder_grab_dirs(struct block_device *bdev,
|
|
|
|
struct bd_holder *bo)
|
|
|
|
{
|
|
|
|
if (!bdev || !bo)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
bo->sdir = kobject_get(bo->sdir);
|
|
|
|
if (!bo->sdir)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
bo->hdev = kobject_get(bo->sdir->parent);
|
|
|
|
if (!bo->hdev)
|
|
|
|
goto fail_put_sdir;
|
|
|
|
|
|
|
|
bo->sdev = bdev_get_kobj(bdev);
|
|
|
|
if (!bo->sdev)
|
|
|
|
goto fail_put_hdev;
|
|
|
|
|
|
|
|
bo->hdir = bdev_get_holder(bdev);
|
|
|
|
if (!bo->hdir)
|
|
|
|
goto fail_put_sdev;
|
|
|
|
|
|
|
|
return 1;
|
|
|
|
|
|
|
|
fail_put_sdev:
|
|
|
|
kobject_put(bo->sdev);
|
|
|
|
fail_put_hdev:
|
|
|
|
kobject_put(bo->hdev);
|
|
|
|
fail_put_sdir:
|
|
|
|
kobject_put(bo->sdir);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Put references of related kobjects at once. */
|
|
|
|
static void bd_holder_release_dirs(struct bd_holder *bo)
|
|
|
|
{
|
|
|
|
kobject_put(bo->hdir);
|
|
|
|
kobject_put(bo->sdev);
|
|
|
|
kobject_put(bo->hdev);
|
|
|
|
kobject_put(bo->sdir);
|
|
|
|
}
|
|
|
|
|
|
|
|
static struct bd_holder *alloc_bd_holder(struct kobject *kobj)
|
|
|
|
{
|
|
|
|
struct bd_holder *bo;
|
|
|
|
|
|
|
|
bo = kzalloc(sizeof(*bo), GFP_KERNEL);
|
|
|
|
if (!bo)
|
|
|
|
return NULL;
|
|
|
|
|
|
|
|
bo->count = 1;
|
|
|
|
bo->sdir = kobj;
|
|
|
|
|
|
|
|
return bo;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void free_bd_holder(struct bd_holder *bo)
|
|
|
|
{
|
|
|
|
kfree(bo);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* add_bd_holder - create sysfs symlinks for bd_claim() relationship
|
|
|
|
*
|
|
|
|
* @bdev: block device to be bd_claimed
|
|
|
|
* @bo: preallocated and initialized by alloc_bd_holder()
|
|
|
|
*
|
|
|
|
* If there is no matching entry with @bo in @bdev->bd_holder_list,
|
|
|
|
* add @bo to the list, create symlinks.
|
|
|
|
*
|
[PATCH] blockdev.c: check driver layer errors
Check driver layer errors.
Fix from: "Jun'ichi Nomura" <j-nomura@ce.jp.nec.com>
In blockdevc-check-errors.patch, add_bd_holder() is modified to return error
values when some of its operation failed. Among them, it returns -EEXIST when
a given bd_holder object already exists in the list.
However, in this case, the function completed its work successfully and need
no action by its caller other than freeing unused bd_holder object. So I
think it's better to return success after freeing by itself.
Otherwise, bd_claim-ing with same claim pointer will fail.
Typically, lvresize will fails with following message:
device-mapper: reload ioctl failed: Invalid argument
and you'll see messages like below in kernel log:
device-mapper: table: 254:13: linear: dm-linear: Device lookup failed
device-mapper: ioctl: error adding target to table
Similarly, it should not add bd_holder to the list if either one of symlinking
fails. I don't have a test case for this to happen but it should cause
dereference of freed pointer.
If a matching bd_holder is found in bd_holder_list, add_bd_holder() completes
its job by just incrementing the reference count. In this case, it should be
considered as success but it used to return 'fail' to let the caller free
temporary bd_holder. Fixed it to return success and free given object by
itself.
Also, if either one of symlinking fails, the bd_holder should not be added to
the list so that it can be discarded later. Otherwise, the caller will free
bd_holder which is in the list.
Signed-off-by: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
Cc: "Randy.Dunlap" <rdunlap@xenotime.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2006-09-29 12:58:56 +04:00
|
|
|
* Returns 0 if symlinks are created or already there.
|
|
|
|
* Returns -ve if something fails and @bo can be freed.
|
2006-03-27 13:17:57 +04:00
|
|
|
*/
|
|
|
|
static int add_bd_holder(struct block_device *bdev, struct bd_holder *bo)
|
|
|
|
{
|
|
|
|
struct bd_holder *tmp;
|
[PATCH] blockdev.c: check driver layer errors
Check driver layer errors.
Fix from: "Jun'ichi Nomura" <j-nomura@ce.jp.nec.com>
In blockdevc-check-errors.patch, add_bd_holder() is modified to return error
values when some of its operation failed. Among them, it returns -EEXIST when
a given bd_holder object already exists in the list.
However, in this case, the function completed its work successfully and need
no action by its caller other than freeing unused bd_holder object. So I
think it's better to return success after freeing by itself.
Otherwise, bd_claim-ing with same claim pointer will fail.
Typically, lvresize will fails with following message:
device-mapper: reload ioctl failed: Invalid argument
and you'll see messages like below in kernel log:
device-mapper: table: 254:13: linear: dm-linear: Device lookup failed
device-mapper: ioctl: error adding target to table
Similarly, it should not add bd_holder to the list if either one of symlinking
fails. I don't have a test case for this to happen but it should cause
dereference of freed pointer.
If a matching bd_holder is found in bd_holder_list, add_bd_holder() completes
its job by just incrementing the reference count. In this case, it should be
considered as success but it used to return 'fail' to let the caller free
temporary bd_holder. Fixed it to return success and free given object by
itself.
Also, if either one of symlinking fails, the bd_holder should not be added to
the list so that it can be discarded later. Otherwise, the caller will free
bd_holder which is in the list.
Signed-off-by: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
Cc: "Randy.Dunlap" <rdunlap@xenotime.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2006-09-29 12:58:56 +04:00
|
|
|
int ret;
|
2006-03-27 13:17:57 +04:00
|
|
|
|
|
|
|
if (!bo)
|
[PATCH] blockdev.c: check driver layer errors
Check driver layer errors.
Fix from: "Jun'ichi Nomura" <j-nomura@ce.jp.nec.com>
In blockdevc-check-errors.patch, add_bd_holder() is modified to return error
values when some of its operation failed. Among them, it returns -EEXIST when
a given bd_holder object already exists in the list.
However, in this case, the function completed its work successfully and need
no action by its caller other than freeing unused bd_holder object. So I
think it's better to return success after freeing by itself.
Otherwise, bd_claim-ing with same claim pointer will fail.
Typically, lvresize will fails with following message:
device-mapper: reload ioctl failed: Invalid argument
and you'll see messages like below in kernel log:
device-mapper: table: 254:13: linear: dm-linear: Device lookup failed
device-mapper: ioctl: error adding target to table
Similarly, it should not add bd_holder to the list if either one of symlinking
fails. I don't have a test case for this to happen but it should cause
dereference of freed pointer.
If a matching bd_holder is found in bd_holder_list, add_bd_holder() completes
its job by just incrementing the reference count. In this case, it should be
considered as success but it used to return 'fail' to let the caller free
temporary bd_holder. Fixed it to return success and free given object by
itself.
Also, if either one of symlinking fails, the bd_holder should not be added to
the list so that it can be discarded later. Otherwise, the caller will free
bd_holder which is in the list.
Signed-off-by: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
Cc: "Randy.Dunlap" <rdunlap@xenotime.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2006-09-29 12:58:56 +04:00
|
|
|
return -EINVAL;
|
2006-03-27 13:17:57 +04:00
|
|
|
|
|
|
|
list_for_each_entry(tmp, &bdev->bd_holder_list, list) {
|
|
|
|
if (tmp->sdir == bo->sdir) {
|
|
|
|
tmp->count++;
|
[PATCH] blockdev.c: check driver layer errors
Check driver layer errors.
Fix from: "Jun'ichi Nomura" <j-nomura@ce.jp.nec.com>
In blockdevc-check-errors.patch, add_bd_holder() is modified to return error
values when some of its operation failed. Among them, it returns -EEXIST when
a given bd_holder object already exists in the list.
However, in this case, the function completed its work successfully and need
no action by its caller other than freeing unused bd_holder object. So I
think it's better to return success after freeing by itself.
Otherwise, bd_claim-ing with same claim pointer will fail.
Typically, lvresize will fails with following message:
device-mapper: reload ioctl failed: Invalid argument
and you'll see messages like below in kernel log:
device-mapper: table: 254:13: linear: dm-linear: Device lookup failed
device-mapper: ioctl: error adding target to table
Similarly, it should not add bd_holder to the list if either one of symlinking
fails. I don't have a test case for this to happen but it should cause
dereference of freed pointer.
If a matching bd_holder is found in bd_holder_list, add_bd_holder() completes
its job by just incrementing the reference count. In this case, it should be
considered as success but it used to return 'fail' to let the caller free
temporary bd_holder. Fixed it to return success and free given object by
itself.
Also, if either one of symlinking fails, the bd_holder should not be added to
the list so that it can be discarded later. Otherwise, the caller will free
bd_holder which is in the list.
Signed-off-by: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
Cc: "Randy.Dunlap" <rdunlap@xenotime.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2006-09-29 12:58:56 +04:00
|
|
|
/* We've already done what we need to do here. */
|
|
|
|
free_bd_holder(bo);
|
2006-03-27 13:17:57 +04:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!bd_holder_grab_dirs(bdev, bo))
|
[PATCH] blockdev.c: check driver layer errors
Check driver layer errors.
Fix from: "Jun'ichi Nomura" <j-nomura@ce.jp.nec.com>
In blockdevc-check-errors.patch, add_bd_holder() is modified to return error
values when some of its operation failed. Among them, it returns -EEXIST when
a given bd_holder object already exists in the list.
However, in this case, the function completed its work successfully and need
no action by its caller other than freeing unused bd_holder object. So I
think it's better to return success after freeing by itself.
Otherwise, bd_claim-ing with same claim pointer will fail.
Typically, lvresize will fails with following message:
device-mapper: reload ioctl failed: Invalid argument
and you'll see messages like below in kernel log:
device-mapper: table: 254:13: linear: dm-linear: Device lookup failed
device-mapper: ioctl: error adding target to table
Similarly, it should not add bd_holder to the list if either one of symlinking
fails. I don't have a test case for this to happen but it should cause
dereference of freed pointer.
If a matching bd_holder is found in bd_holder_list, add_bd_holder() completes
its job by just incrementing the reference count. In this case, it should be
considered as success but it used to return 'fail' to let the caller free
temporary bd_holder. Fixed it to return success and free given object by
itself.
Also, if either one of symlinking fails, the bd_holder should not be added to
the list so that it can be discarded later. Otherwise, the caller will free
bd_holder which is in the list.
Signed-off-by: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
Cc: "Randy.Dunlap" <rdunlap@xenotime.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2006-09-29 12:58:56 +04:00
|
|
|
return -EBUSY;
|
2006-03-27 13:17:57 +04:00
|
|
|
|
[PATCH] blockdev.c: check driver layer errors
Check driver layer errors.
Fix from: "Jun'ichi Nomura" <j-nomura@ce.jp.nec.com>
In blockdevc-check-errors.patch, add_bd_holder() is modified to return error
values when some of its operation failed. Among them, it returns -EEXIST when
a given bd_holder object already exists in the list.
However, in this case, the function completed its work successfully and need
no action by its caller other than freeing unused bd_holder object. So I
think it's better to return success after freeing by itself.
Otherwise, bd_claim-ing with same claim pointer will fail.
Typically, lvresize will fails with following message:
device-mapper: reload ioctl failed: Invalid argument
and you'll see messages like below in kernel log:
device-mapper: table: 254:13: linear: dm-linear: Device lookup failed
device-mapper: ioctl: error adding target to table
Similarly, it should not add bd_holder to the list if either one of symlinking
fails. I don't have a test case for this to happen but it should cause
dereference of freed pointer.
If a matching bd_holder is found in bd_holder_list, add_bd_holder() completes
its job by just incrementing the reference count. In this case, it should be
considered as success but it used to return 'fail' to let the caller free
temporary bd_holder. Fixed it to return success and free given object by
itself.
Also, if either one of symlinking fails, the bd_holder should not be added to
the list so that it can be discarded later. Otherwise, the caller will free
bd_holder which is in the list.
Signed-off-by: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
Cc: "Randy.Dunlap" <rdunlap@xenotime.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2006-09-29 12:58:56 +04:00
|
|
|
ret = add_symlink(bo->sdir, bo->sdev);
|
|
|
|
if (ret == 0) {
|
|
|
|
ret = add_symlink(bo->hdir, bo->hdev);
|
|
|
|
if (ret)
|
|
|
|
del_symlink(bo->sdir, bo->sdev);
|
|
|
|
}
|
|
|
|
if (ret == 0)
|
|
|
|
list_add_tail(&bo->list, &bdev->bd_holder_list);
|
|
|
|
return ret;
|
2006-03-27 13:17:57 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* del_bd_holder - delete sysfs symlinks for bd_claim() relationship
|
|
|
|
*
|
|
|
|
* @bdev: block device to be bd_claimed
|
|
|
|
* @kobj: holder's kobject
|
|
|
|
*
|
|
|
|
* If there is matching entry with @kobj in @bdev->bd_holder_list
|
|
|
|
* and no other bd_claim() from the same kobject,
|
|
|
|
* remove the struct bd_holder from the list, delete symlinks for it.
|
|
|
|
*
|
|
|
|
* Returns a pointer to the struct bd_holder when it's removed from the list
|
|
|
|
* and ready to be freed.
|
|
|
|
* Returns NULL if matching claim isn't found or there is other bd_claim()
|
|
|
|
* by the same kobject.
|
|
|
|
*/
|
|
|
|
static struct bd_holder *del_bd_holder(struct block_device *bdev,
|
|
|
|
struct kobject *kobj)
|
|
|
|
{
|
|
|
|
struct bd_holder *bo;
|
|
|
|
|
|
|
|
list_for_each_entry(bo, &bdev->bd_holder_list, list) {
|
|
|
|
if (bo->sdir == kobj) {
|
|
|
|
bo->count--;
|
|
|
|
BUG_ON(bo->count < 0);
|
|
|
|
if (!bo->count) {
|
|
|
|
list_del(&bo->list);
|
|
|
|
del_symlink(bo->sdir, bo->sdev);
|
|
|
|
del_symlink(bo->hdir, bo->hdev);
|
|
|
|
bd_holder_release_dirs(bo);
|
|
|
|
return bo;
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* bd_claim_by_kobject - bd_claim() with additional kobject signature
|
|
|
|
*
|
|
|
|
* @bdev: block device to be claimed
|
|
|
|
* @holder: holder's signature
|
|
|
|
* @kobj: holder's kobject
|
|
|
|
*
|
|
|
|
* Do bd_claim() and if it succeeds, create sysfs symlinks between
|
|
|
|
* the bdev and the holder's kobject.
|
|
|
|
* Use bd_release_from_kobject() when relesing the claimed bdev.
|
|
|
|
*
|
|
|
|
* Returns 0 on success. (same as bd_claim())
|
|
|
|
* Returns errno on failure.
|
|
|
|
*/
|
|
|
|
static int bd_claim_by_kobject(struct block_device *bdev, void *holder,
|
|
|
|
struct kobject *kobj)
|
|
|
|
{
|
|
|
|
int res;
|
|
|
|
struct bd_holder *bo;
|
|
|
|
|
|
|
|
if (!kobj)
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
bo = alloc_bd_holder(kobj);
|
|
|
|
if (!bo)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
2006-07-03 11:25:33 +04:00
|
|
|
mutex_lock_nested(&bdev->bd_mutex, BD_MUTEX_PARTITION);
|
2006-03-27 13:17:57 +04:00
|
|
|
res = bd_claim(bdev, holder);
|
[PATCH] blockdev.c: check driver layer errors
Check driver layer errors.
Fix from: "Jun'ichi Nomura" <j-nomura@ce.jp.nec.com>
In blockdevc-check-errors.patch, add_bd_holder() is modified to return error
values when some of its operation failed. Among them, it returns -EEXIST when
a given bd_holder object already exists in the list.
However, in this case, the function completed its work successfully and need
no action by its caller other than freeing unused bd_holder object. So I
think it's better to return success after freeing by itself.
Otherwise, bd_claim-ing with same claim pointer will fail.
Typically, lvresize will fails with following message:
device-mapper: reload ioctl failed: Invalid argument
and you'll see messages like below in kernel log:
device-mapper: table: 254:13: linear: dm-linear: Device lookup failed
device-mapper: ioctl: error adding target to table
Similarly, it should not add bd_holder to the list if either one of symlinking
fails. I don't have a test case for this to happen but it should cause
dereference of freed pointer.
If a matching bd_holder is found in bd_holder_list, add_bd_holder() completes
its job by just incrementing the reference count. In this case, it should be
considered as success but it used to return 'fail' to let the caller free
temporary bd_holder. Fixed it to return success and free given object by
itself.
Also, if either one of symlinking fails, the bd_holder should not be added to
the list so that it can be discarded later. Otherwise, the caller will free
bd_holder which is in the list.
Signed-off-by: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
Cc: "Randy.Dunlap" <rdunlap@xenotime.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2006-09-29 12:58:56 +04:00
|
|
|
if (res == 0)
|
|
|
|
res = add_bd_holder(bdev, bo);
|
|
|
|
if (res)
|
2006-03-27 13:17:57 +04:00
|
|
|
free_bd_holder(bo);
|
2006-03-27 13:18:00 +04:00
|
|
|
mutex_unlock(&bdev->bd_mutex);
|
2006-03-27 13:17:57 +04:00
|
|
|
|
|
|
|
return res;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* bd_release_from_kobject - bd_release() with additional kobject signature
|
|
|
|
*
|
|
|
|
* @bdev: block device to be released
|
|
|
|
* @kobj: holder's kobject
|
|
|
|
*
|
|
|
|
* Do bd_release() and remove sysfs symlinks created by bd_claim_by_kobject().
|
|
|
|
*/
|
|
|
|
static void bd_release_from_kobject(struct block_device *bdev,
|
|
|
|
struct kobject *kobj)
|
|
|
|
{
|
|
|
|
struct bd_holder *bo;
|
|
|
|
|
|
|
|
if (!kobj)
|
|
|
|
return;
|
|
|
|
|
2006-07-03 11:25:33 +04:00
|
|
|
mutex_lock_nested(&bdev->bd_mutex, BD_MUTEX_PARTITION);
|
2006-03-27 13:17:57 +04:00
|
|
|
bd_release(bdev);
|
|
|
|
if ((bo = del_bd_holder(bdev, kobj)))
|
|
|
|
free_bd_holder(bo);
|
2006-03-27 13:18:00 +04:00
|
|
|
mutex_unlock(&bdev->bd_mutex);
|
2006-03-27 13:17:57 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* bd_claim_by_disk - wrapper function for bd_claim_by_kobject()
|
|
|
|
*
|
|
|
|
* @bdev: block device to be claimed
|
|
|
|
* @holder: holder's signature
|
|
|
|
* @disk: holder's gendisk
|
|
|
|
*
|
|
|
|
* Call bd_claim_by_kobject() with getting @disk->slave_dir.
|
|
|
|
*/
|
|
|
|
int bd_claim_by_disk(struct block_device *bdev, void *holder,
|
|
|
|
struct gendisk *disk)
|
|
|
|
{
|
|
|
|
return bd_claim_by_kobject(bdev, holder, kobject_get(disk->slave_dir));
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(bd_claim_by_disk);
|
|
|
|
|
|
|
|
/**
|
|
|
|
* bd_release_from_disk - wrapper function for bd_release_from_kobject()
|
|
|
|
*
|
|
|
|
* @bdev: block device to be claimed
|
|
|
|
* @disk: holder's gendisk
|
|
|
|
*
|
|
|
|
* Call bd_release_from_kobject() and put @disk->slave_dir.
|
|
|
|
*/
|
|
|
|
void bd_release_from_disk(struct block_device *bdev, struct gendisk *disk)
|
|
|
|
{
|
|
|
|
bd_release_from_kobject(bdev, disk->slave_dir);
|
|
|
|
kobject_put(disk->slave_dir);
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(bd_release_from_disk);
|
|
|
|
#endif
|
|
|
|
|
2005-04-17 02:20:36 +04:00
|
|
|
/*
|
|
|
|
* Tries to open block device by device number. Use it ONLY if you
|
|
|
|
* really do not have anything better - i.e. when you are behind a
|
|
|
|
* truly sucky interface and all you are given is a device number. _Never_
|
|
|
|
* to be used for internal purposes. If you ever need it - reconsider
|
|
|
|
* your API.
|
|
|
|
*/
|
|
|
|
struct block_device *open_by_devnum(dev_t dev, unsigned mode)
|
|
|
|
{
|
|
|
|
struct block_device *bdev = bdget(dev);
|
|
|
|
int err = -ENOMEM;
|
|
|
|
int flags = mode & FMODE_WRITE ? O_RDWR : O_RDONLY;
|
|
|
|
if (bdev)
|
|
|
|
err = blkdev_get(bdev, mode, flags);
|
|
|
|
return err ? ERR_PTR(err) : bdev;
|
|
|
|
}
|
|
|
|
|
|
|
|
EXPORT_SYMBOL(open_by_devnum);
|
|
|
|
|
2006-07-03 11:25:33 +04:00
|
|
|
static int
|
|
|
|
blkdev_get_partition(struct block_device *bdev, mode_t mode, unsigned flags);
|
|
|
|
|
|
|
|
struct block_device *open_partition_by_devnum(dev_t dev, unsigned mode)
|
|
|
|
{
|
|
|
|
struct block_device *bdev = bdget(dev);
|
|
|
|
int err = -ENOMEM;
|
|
|
|
int flags = mode & FMODE_WRITE ? O_RDWR : O_RDONLY;
|
|
|
|
if (bdev)
|
|
|
|
err = blkdev_get_partition(bdev, mode, flags);
|
|
|
|
return err ? ERR_PTR(err) : bdev;
|
|
|
|
}
|
|
|
|
|
|
|
|
EXPORT_SYMBOL(open_partition_by_devnum);
|
|
|
|
|
|
|
|
|
2005-04-17 02:20:36 +04:00
|
|
|
/*
|
|
|
|
* This routine checks whether a removable media has been changed,
|
|
|
|
* and invalidates all buffer-cache-entries in that case. This
|
|
|
|
* is a relatively slow routine, so we have to try to minimize using
|
|
|
|
* it. Thus it is called only upon a 'mount' or 'open'. This
|
|
|
|
* is the best way of combining speed and utility, I think.
|
|
|
|
* People changing diskettes in the middle of an operation deserve
|
|
|
|
* to lose :-)
|
|
|
|
*/
|
|
|
|
int check_disk_change(struct block_device *bdev)
|
|
|
|
{
|
|
|
|
struct gendisk *disk = bdev->bd_disk;
|
|
|
|
struct block_device_operations * bdops = disk->fops;
|
|
|
|
|
|
|
|
if (!bdops->media_changed)
|
|
|
|
return 0;
|
|
|
|
if (!bdops->media_changed(bdev->bd_disk))
|
|
|
|
return 0;
|
|
|
|
|
2005-05-06 03:15:59 +04:00
|
|
|
if (__invalidate_device(bdev))
|
2005-04-17 02:20:36 +04:00
|
|
|
printk("VFS: busy inodes on changed media.\n");
|
|
|
|
|
|
|
|
if (bdops->revalidate_disk)
|
|
|
|
bdops->revalidate_disk(bdev->bd_disk);
|
|
|
|
if (bdev->bd_disk->minors > 1)
|
|
|
|
bdev->bd_invalidated = 1;
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
|
|
|
|
EXPORT_SYMBOL(check_disk_change);
|
|
|
|
|
|
|
|
void bd_set_size(struct block_device *bdev, loff_t size)
|
|
|
|
{
|
|
|
|
unsigned bsize = bdev_hardsect_size(bdev);
|
|
|
|
|
|
|
|
bdev->bd_inode->i_size = size;
|
|
|
|
while (bsize < PAGE_CACHE_SIZE) {
|
|
|
|
if (size & bsize)
|
|
|
|
break;
|
|
|
|
bsize <<= 1;
|
|
|
|
}
|
|
|
|
bdev->bd_block_size = bsize;
|
|
|
|
bdev->bd_inode->i_blkbits = blksize_bits(bsize);
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(bd_set_size);
|
|
|
|
|
[PATCH] lockdep: fix blkdev_open() warning
On Wed, 2006-08-09 at 07:57 +0200, Rolf Eike Beer wrote:
> =============================================
> [ INFO: possible recursive locking detected ]
> ---------------------------------------------
> parted/7929 is trying to acquire lock:
> (&bdev->bd_mutex){--..}, at: [<c105eb8d>] __blkdev_put+0x1e/0x13c
>
> but task is already holding lock:
> (&bdev->bd_mutex){--..}, at: [<c105eec6>] do_open+0x72/0x3a8
>
> other info that might help us debug this:
> 1 lock held by parted/7929:
> #0: (&bdev->bd_mutex){--..}, at: [<c105eec6>] do_open+0x72/0x3a8
> stack backtrace:
> [<c1003aad>] show_trace_log_lvl+0x58/0x15b
> [<c100495f>] show_trace+0xd/0x10
> [<c1004979>] dump_stack+0x17/0x1a
> [<c102dee5>] __lock_acquire+0x753/0x99c
> [<c102e3b0>] lock_acquire+0x4a/0x6a
> [<c1204501>] mutex_lock_nested+0xc8/0x20c
> [<c105eb8d>] __blkdev_put+0x1e/0x13c
> [<c105ecc4>] blkdev_put+0xa/0xc
> [<c105f18a>] do_open+0x336/0x3a8
> [<c105f21b>] blkdev_open+0x1f/0x4c
> [<c1057b40>] __dentry_open+0xc7/0x1aa
> [<c1057c91>] nameidata_to_filp+0x1c/0x2e
> [<c1057cd1>] do_filp_open+0x2e/0x35
> [<c1057dd7>] do_sys_open+0x38/0x68
> [<c1057e33>] sys_open+0x16/0x18
> [<c1002845>] sysenter_past_esp+0x56/0x8d
OK, I'm having a look here; its all new to me so bear with me.
blkdev_open() calls
do_open(bdev, ...,BD_MUTEX_NORMAL) and takes
mutex_lock_nested(&bdev->bd_mutex, BD_MUTEX_NORMAL)
then something fails, and we're thrown to:
out_first: where
if (bdev != bdev->bd_contains)
blkdev_put(bdev->bd_contains) which is
__blkdev_put(bdev->bd_contains, BD_MUTEX_NORMAL) which does
mutex_lock_nested(&bdev->bd_contains->bd_mutex, BD_MUTEX_NORMAL) <--- lockdep trigger
When going to out_first, dbev->bd_contains is either bdev or whole, and
since we take the branch it must be whole. So it seems to me the
following patch would be the right one:
[akpm@osdl.org: compile fix]
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Arjan van de Ven <arjan@linux.intel.com>
Acked-by: NeilBrown <neilb@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2006-08-27 12:23:31 +04:00
|
|
|
static int __blkdev_put(struct block_device *bdev, unsigned int subclass)
|
|
|
|
{
|
|
|
|
int ret = 0;
|
|
|
|
struct inode *bd_inode = bdev->bd_inode;
|
|
|
|
struct gendisk *disk = bdev->bd_disk;
|
|
|
|
|
|
|
|
mutex_lock_nested(&bdev->bd_mutex, subclass);
|
|
|
|
lock_kernel();
|
|
|
|
if (!--bdev->bd_openers) {
|
|
|
|
sync_blockdev(bdev);
|
|
|
|
kill_bdev(bdev);
|
|
|
|
}
|
|
|
|
if (bdev->bd_contains == bdev) {
|
|
|
|
if (disk->fops->release)
|
|
|
|
ret = disk->fops->release(bd_inode, NULL);
|
|
|
|
} else {
|
|
|
|
mutex_lock_nested(&bdev->bd_contains->bd_mutex,
|
|
|
|
subclass + 1);
|
|
|
|
bdev->bd_contains->bd_part_count--;
|
|
|
|
mutex_unlock(&bdev->bd_contains->bd_mutex);
|
|
|
|
}
|
|
|
|
if (!bdev->bd_openers) {
|
|
|
|
struct module *owner = disk->fops->owner;
|
|
|
|
|
|
|
|
put_disk(disk);
|
|
|
|
module_put(owner);
|
|
|
|
|
|
|
|
if (bdev->bd_contains != bdev) {
|
|
|
|
kobject_put(&bdev->bd_part->kobj);
|
|
|
|
bdev->bd_part = NULL;
|
|
|
|
}
|
|
|
|
bdev->bd_disk = NULL;
|
|
|
|
bdev->bd_inode->i_data.backing_dev_info = &default_backing_dev_info;
|
|
|
|
if (bdev != bdev->bd_contains)
|
|
|
|
__blkdev_put(bdev->bd_contains, subclass + 1);
|
|
|
|
bdev->bd_contains = NULL;
|
|
|
|
}
|
|
|
|
unlock_kernel();
|
|
|
|
mutex_unlock(&bdev->bd_mutex);
|
|
|
|
bdput(bdev);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
int blkdev_put(struct block_device *bdev)
|
|
|
|
{
|
|
|
|
return __blkdev_put(bdev, BD_MUTEX_NORMAL);
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(blkdev_put);
|
|
|
|
|
|
|
|
int blkdev_put_partition(struct block_device *bdev)
|
|
|
|
{
|
|
|
|
return __blkdev_put(bdev, BD_MUTEX_PARTITION);
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(blkdev_put_partition);
|
|
|
|
|
2006-07-03 11:25:33 +04:00
|
|
|
static int
|
|
|
|
blkdev_get_whole(struct block_device *bdev, mode_t mode, unsigned flags);
|
|
|
|
|
|
|
|
static int
|
|
|
|
do_open(struct block_device *bdev, struct file *file, unsigned int subclass)
|
2005-04-17 02:20:36 +04:00
|
|
|
{
|
|
|
|
struct module *owner = NULL;
|
|
|
|
struct gendisk *disk;
|
|
|
|
int ret = -ENXIO;
|
|
|
|
int part;
|
|
|
|
|
|
|
|
file->f_mapping = bdev->bd_inode->i_mapping;
|
|
|
|
lock_kernel();
|
|
|
|
disk = get_gendisk(bdev->bd_dev, &part);
|
|
|
|
if (!disk) {
|
|
|
|
unlock_kernel();
|
|
|
|
bdput(bdev);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
owner = disk->fops->owner;
|
|
|
|
|
2006-07-03 11:25:33 +04:00
|
|
|
mutex_lock_nested(&bdev->bd_mutex, subclass);
|
|
|
|
|
2005-04-17 02:20:36 +04:00
|
|
|
if (!bdev->bd_openers) {
|
|
|
|
bdev->bd_disk = disk;
|
|
|
|
bdev->bd_contains = bdev;
|
|
|
|
if (!part) {
|
|
|
|
struct backing_dev_info *bdi;
|
|
|
|
if (disk->fops->open) {
|
|
|
|
ret = disk->fops->open(bdev->bd_inode, file);
|
|
|
|
if (ret)
|
|
|
|
goto out_first;
|
|
|
|
}
|
|
|
|
if (!bdev->bd_openers) {
|
|
|
|
bd_set_size(bdev,(loff_t)get_capacity(disk)<<9);
|
|
|
|
bdi = blk_get_backing_dev_info(bdev);
|
|
|
|
if (bdi == NULL)
|
|
|
|
bdi = &default_backing_dev_info;
|
|
|
|
bdev->bd_inode->i_data.backing_dev_info = bdi;
|
|
|
|
}
|
|
|
|
if (bdev->bd_invalidated)
|
|
|
|
rescan_partitions(disk, bdev);
|
|
|
|
} else {
|
|
|
|
struct hd_struct *p;
|
|
|
|
struct block_device *whole;
|
|
|
|
whole = bdget_disk(disk, 0);
|
|
|
|
ret = -ENOMEM;
|
|
|
|
if (!whole)
|
|
|
|
goto out_first;
|
2006-07-03 11:25:33 +04:00
|
|
|
ret = blkdev_get_whole(whole, file->f_mode, file->f_flags);
|
2005-04-17 02:20:36 +04:00
|
|
|
if (ret)
|
|
|
|
goto out_first;
|
|
|
|
bdev->bd_contains = whole;
|
2006-07-03 11:25:33 +04:00
|
|
|
mutex_lock_nested(&whole->bd_mutex, BD_MUTEX_WHOLE);
|
2005-04-17 02:20:36 +04:00
|
|
|
whole->bd_part_count++;
|
|
|
|
p = disk->part[part - 1];
|
|
|
|
bdev->bd_inode->i_data.backing_dev_info =
|
|
|
|
whole->bd_inode->i_data.backing_dev_info;
|
|
|
|
if (!(disk->flags & GENHD_FL_UP) || !p || !p->nr_sects) {
|
|
|
|
whole->bd_part_count--;
|
2006-03-23 14:00:28 +03:00
|
|
|
mutex_unlock(&whole->bd_mutex);
|
2005-04-17 02:20:36 +04:00
|
|
|
ret = -ENXIO;
|
|
|
|
goto out_first;
|
|
|
|
}
|
|
|
|
kobject_get(&p->kobj);
|
|
|
|
bdev->bd_part = p;
|
|
|
|
bd_set_size(bdev, (loff_t) p->nr_sects << 9);
|
2006-03-23 14:00:28 +03:00
|
|
|
mutex_unlock(&whole->bd_mutex);
|
2005-04-17 02:20:36 +04:00
|
|
|
}
|
|
|
|
} else {
|
|
|
|
put_disk(disk);
|
|
|
|
module_put(owner);
|
|
|
|
if (bdev->bd_contains == bdev) {
|
|
|
|
if (bdev->bd_disk->fops->open) {
|
|
|
|
ret = bdev->bd_disk->fops->open(bdev->bd_inode, file);
|
|
|
|
if (ret)
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
if (bdev->bd_invalidated)
|
|
|
|
rescan_partitions(bdev->bd_disk, bdev);
|
|
|
|
} else {
|
2006-07-03 11:25:33 +04:00
|
|
|
mutex_lock_nested(&bdev->bd_contains->bd_mutex,
|
|
|
|
BD_MUTEX_PARTITION);
|
2005-04-17 02:20:36 +04:00
|
|
|
bdev->bd_contains->bd_part_count++;
|
2006-03-23 14:00:28 +03:00
|
|
|
mutex_unlock(&bdev->bd_contains->bd_mutex);
|
2005-04-17 02:20:36 +04:00
|
|
|
}
|
|
|
|
}
|
|
|
|
bdev->bd_openers++;
|
2006-03-23 14:00:28 +03:00
|
|
|
mutex_unlock(&bdev->bd_mutex);
|
2005-04-17 02:20:36 +04:00
|
|
|
unlock_kernel();
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
out_first:
|
|
|
|
bdev->bd_disk = NULL;
|
|
|
|
bdev->bd_inode->i_data.backing_dev_info = &default_backing_dev_info;
|
|
|
|
if (bdev != bdev->bd_contains)
|
[PATCH] lockdep: fix blkdev_open() warning
On Wed, 2006-08-09 at 07:57 +0200, Rolf Eike Beer wrote:
> =============================================
> [ INFO: possible recursive locking detected ]
> ---------------------------------------------
> parted/7929 is trying to acquire lock:
> (&bdev->bd_mutex){--..}, at: [<c105eb8d>] __blkdev_put+0x1e/0x13c
>
> but task is already holding lock:
> (&bdev->bd_mutex){--..}, at: [<c105eec6>] do_open+0x72/0x3a8
>
> other info that might help us debug this:
> 1 lock held by parted/7929:
> #0: (&bdev->bd_mutex){--..}, at: [<c105eec6>] do_open+0x72/0x3a8
> stack backtrace:
> [<c1003aad>] show_trace_log_lvl+0x58/0x15b
> [<c100495f>] show_trace+0xd/0x10
> [<c1004979>] dump_stack+0x17/0x1a
> [<c102dee5>] __lock_acquire+0x753/0x99c
> [<c102e3b0>] lock_acquire+0x4a/0x6a
> [<c1204501>] mutex_lock_nested+0xc8/0x20c
> [<c105eb8d>] __blkdev_put+0x1e/0x13c
> [<c105ecc4>] blkdev_put+0xa/0xc
> [<c105f18a>] do_open+0x336/0x3a8
> [<c105f21b>] blkdev_open+0x1f/0x4c
> [<c1057b40>] __dentry_open+0xc7/0x1aa
> [<c1057c91>] nameidata_to_filp+0x1c/0x2e
> [<c1057cd1>] do_filp_open+0x2e/0x35
> [<c1057dd7>] do_sys_open+0x38/0x68
> [<c1057e33>] sys_open+0x16/0x18
> [<c1002845>] sysenter_past_esp+0x56/0x8d
OK, I'm having a look here; its all new to me so bear with me.
blkdev_open() calls
do_open(bdev, ...,BD_MUTEX_NORMAL) and takes
mutex_lock_nested(&bdev->bd_mutex, BD_MUTEX_NORMAL)
then something fails, and we're thrown to:
out_first: where
if (bdev != bdev->bd_contains)
blkdev_put(bdev->bd_contains) which is
__blkdev_put(bdev->bd_contains, BD_MUTEX_NORMAL) which does
mutex_lock_nested(&bdev->bd_contains->bd_mutex, BD_MUTEX_NORMAL) <--- lockdep trigger
When going to out_first, dbev->bd_contains is either bdev or whole, and
since we take the branch it must be whole. So it seems to me the
following patch would be the right one:
[akpm@osdl.org: compile fix]
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Arjan van de Ven <arjan@linux.intel.com>
Acked-by: NeilBrown <neilb@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2006-08-27 12:23:31 +04:00
|
|
|
__blkdev_put(bdev->bd_contains, BD_MUTEX_WHOLE);
|
2005-04-17 02:20:36 +04:00
|
|
|
bdev->bd_contains = NULL;
|
|
|
|
put_disk(disk);
|
|
|
|
module_put(owner);
|
|
|
|
out:
|
2006-03-23 14:00:28 +03:00
|
|
|
mutex_unlock(&bdev->bd_mutex);
|
2005-04-17 02:20:36 +04:00
|
|
|
unlock_kernel();
|
|
|
|
if (ret)
|
|
|
|
bdput(bdev);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
int blkdev_get(struct block_device *bdev, mode_t mode, unsigned flags)
|
|
|
|
{
|
|
|
|
/*
|
|
|
|
* This crockload is due to bad choice of ->open() type.
|
|
|
|
* It will go away.
|
|
|
|
* For now, block device ->open() routine must _not_
|
|
|
|
* examine anything in 'inode' argument except ->i_rdev.
|
|
|
|
*/
|
|
|
|
struct file fake_file = {};
|
|
|
|
struct dentry fake_dentry = {};
|
|
|
|
fake_file.f_mode = mode;
|
|
|
|
fake_file.f_flags = flags;
|
|
|
|
fake_file.f_dentry = &fake_dentry;
|
|
|
|
fake_dentry.d_inode = bdev->bd_inode;
|
|
|
|
|
2006-07-03 11:25:33 +04:00
|
|
|
return do_open(bdev, &fake_file, BD_MUTEX_NORMAL);
|
2005-04-17 02:20:36 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
EXPORT_SYMBOL(blkdev_get);
|
|
|
|
|
2006-07-03 11:25:33 +04:00
|
|
|
static int
|
|
|
|
blkdev_get_whole(struct block_device *bdev, mode_t mode, unsigned flags)
|
|
|
|
{
|
|
|
|
/*
|
|
|
|
* This crockload is due to bad choice of ->open() type.
|
|
|
|
* It will go away.
|
|
|
|
* For now, block device ->open() routine must _not_
|
|
|
|
* examine anything in 'inode' argument except ->i_rdev.
|
|
|
|
*/
|
|
|
|
struct file fake_file = {};
|
|
|
|
struct dentry fake_dentry = {};
|
|
|
|
fake_file.f_mode = mode;
|
|
|
|
fake_file.f_flags = flags;
|
|
|
|
fake_file.f_dentry = &fake_dentry;
|
|
|
|
fake_dentry.d_inode = bdev->bd_inode;
|
|
|
|
|
|
|
|
return do_open(bdev, &fake_file, BD_MUTEX_WHOLE);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
|
|
|
blkdev_get_partition(struct block_device *bdev, mode_t mode, unsigned flags)
|
|
|
|
{
|
|
|
|
/*
|
|
|
|
* This crockload is due to bad choice of ->open() type.
|
|
|
|
* It will go away.
|
|
|
|
* For now, block device ->open() routine must _not_
|
|
|
|
* examine anything in 'inode' argument except ->i_rdev.
|
|
|
|
*/
|
|
|
|
struct file fake_file = {};
|
|
|
|
struct dentry fake_dentry = {};
|
|
|
|
fake_file.f_mode = mode;
|
|
|
|
fake_file.f_flags = flags;
|
|
|
|
fake_file.f_dentry = &fake_dentry;
|
|
|
|
fake_dentry.d_inode = bdev->bd_inode;
|
|
|
|
|
|
|
|
return do_open(bdev, &fake_file, BD_MUTEX_PARTITION);
|
|
|
|
}
|
|
|
|
|
2005-04-17 02:20:36 +04:00
|
|
|
static int blkdev_open(struct inode * inode, struct file * filp)
|
|
|
|
{
|
|
|
|
struct block_device *bdev;
|
|
|
|
int res;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Preserve backwards compatibility and allow large file access
|
|
|
|
* even if userspace doesn't ask for it explicitly. Some mkfs
|
|
|
|
* binary needs it. We might want to drop this workaround
|
|
|
|
* during an unstable branch.
|
|
|
|
*/
|
|
|
|
filp->f_flags |= O_LARGEFILE;
|
|
|
|
|
|
|
|
bdev = bd_acquire(inode);
|
|
|
|
|
2006-07-03 11:25:33 +04:00
|
|
|
res = do_open(bdev, filp, BD_MUTEX_NORMAL);
|
2005-04-17 02:20:36 +04:00
|
|
|
if (res)
|
|
|
|
return res;
|
|
|
|
|
|
|
|
if (!(filp->f_flags & O_EXCL) )
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
if (!(res = bd_claim(bdev, filp)))
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
blkdev_put(bdev);
|
|
|
|
return res;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int blkdev_close(struct inode * inode, struct file * filp)
|
|
|
|
{
|
|
|
|
struct block_device *bdev = I_BDEV(filp->f_mapping->host);
|
|
|
|
if (bdev->bd_holder == filp)
|
|
|
|
bd_release(bdev);
|
|
|
|
return blkdev_put(bdev);
|
|
|
|
}
|
|
|
|
|
|
|
|
static ssize_t blkdev_file_write(struct file *file, const char __user *buf,
|
|
|
|
size_t count, loff_t *ppos)
|
|
|
|
{
|
|
|
|
struct iovec local_iov = { .iov_base = (void __user *)buf, .iov_len = count };
|
|
|
|
|
|
|
|
return generic_file_write_nolock(file, &local_iov, 1, ppos);
|
|
|
|
}
|
|
|
|
|
|
|
|
static ssize_t blkdev_file_aio_write(struct kiocb *iocb, const char __user *buf,
|
|
|
|
size_t count, loff_t pos)
|
|
|
|
{
|
|
|
|
struct iovec local_iov = { .iov_base = (void __user *)buf, .iov_len = count };
|
|
|
|
|
|
|
|
return generic_file_aio_write_nolock(iocb, &local_iov, 1, &iocb->ki_pos);
|
|
|
|
}
|
|
|
|
|
2005-06-23 11:10:15 +04:00
|
|
|
static long block_ioctl(struct file *file, unsigned cmd, unsigned long arg)
|
2005-04-17 02:20:36 +04:00
|
|
|
{
|
|
|
|
return blkdev_ioctl(file->f_mapping->host, file, cmd, arg);
|
|
|
|
}
|
|
|
|
|
2006-06-28 15:26:44 +04:00
|
|
|
const struct address_space_operations def_blk_aops = {
|
2005-04-17 02:20:36 +04:00
|
|
|
.readpage = blkdev_readpage,
|
|
|
|
.writepage = blkdev_writepage,
|
|
|
|
.sync_page = block_sync_page,
|
|
|
|
.prepare_write = blkdev_prepare_write,
|
|
|
|
.commit_write = blkdev_commit_write,
|
|
|
|
.writepages = generic_writepages,
|
|
|
|
.direct_IO = blkdev_direct_IO,
|
|
|
|
};
|
|
|
|
|
2006-03-28 13:56:42 +04:00
|
|
|
const struct file_operations def_blk_fops = {
|
2005-04-17 02:20:36 +04:00
|
|
|
.open = blkdev_open,
|
|
|
|
.release = blkdev_close,
|
|
|
|
.llseek = block_llseek,
|
|
|
|
.read = generic_file_read,
|
|
|
|
.write = blkdev_file_write,
|
|
|
|
.aio_read = generic_file_aio_read,
|
|
|
|
.aio_write = blkdev_file_aio_write,
|
|
|
|
.mmap = generic_file_mmap,
|
|
|
|
.fsync = block_fsync,
|
2005-06-23 11:10:15 +04:00
|
|
|
.unlocked_ioctl = block_ioctl,
|
2005-04-17 02:20:36 +04:00
|
|
|
#ifdef CONFIG_COMPAT
|
|
|
|
.compat_ioctl = compat_blkdev_ioctl,
|
|
|
|
#endif
|
|
|
|
.readv = generic_file_readv,
|
|
|
|
.writev = generic_file_write_nolock,
|
|
|
|
.sendfile = generic_file_sendfile,
|
2006-05-01 21:59:32 +04:00
|
|
|
.splice_read = generic_file_splice_read,
|
|
|
|
.splice_write = generic_file_splice_write,
|
2005-04-17 02:20:36 +04:00
|
|
|
};
|
|
|
|
|
|
|
|
int ioctl_by_bdev(struct block_device *bdev, unsigned cmd, unsigned long arg)
|
|
|
|
{
|
|
|
|
int res;
|
|
|
|
mm_segment_t old_fs = get_fs();
|
|
|
|
set_fs(KERNEL_DS);
|
|
|
|
res = blkdev_ioctl(bdev->bd_inode, NULL, cmd, arg);
|
|
|
|
set_fs(old_fs);
|
|
|
|
return res;
|
|
|
|
}
|
|
|
|
|
|
|
|
EXPORT_SYMBOL(ioctl_by_bdev);
|
|
|
|
|
|
|
|
/**
|
|
|
|
* lookup_bdev - lookup a struct block_device by name
|
|
|
|
*
|
|
|
|
* @path: special file representing the block device
|
|
|
|
*
|
|
|
|
* Get a reference to the blockdevice at @path in the current
|
|
|
|
* namespace if possible and return it. Return ERR_PTR(error)
|
|
|
|
* otherwise.
|
|
|
|
*/
|
|
|
|
struct block_device *lookup_bdev(const char *path)
|
|
|
|
{
|
|
|
|
struct block_device *bdev;
|
|
|
|
struct inode *inode;
|
|
|
|
struct nameidata nd;
|
|
|
|
int error;
|
|
|
|
|
|
|
|
if (!path || !*path)
|
|
|
|
return ERR_PTR(-EINVAL);
|
|
|
|
|
|
|
|
error = path_lookup(path, LOOKUP_FOLLOW, &nd);
|
|
|
|
if (error)
|
|
|
|
return ERR_PTR(error);
|
|
|
|
|
|
|
|
inode = nd.dentry->d_inode;
|
|
|
|
error = -ENOTBLK;
|
|
|
|
if (!S_ISBLK(inode->i_mode))
|
|
|
|
goto fail;
|
|
|
|
error = -EACCES;
|
|
|
|
if (nd.mnt->mnt_flags & MNT_NODEV)
|
|
|
|
goto fail;
|
|
|
|
error = -ENOMEM;
|
|
|
|
bdev = bd_acquire(inode);
|
|
|
|
if (!bdev)
|
|
|
|
goto fail;
|
|
|
|
out:
|
|
|
|
path_release(&nd);
|
|
|
|
return bdev;
|
|
|
|
fail:
|
|
|
|
bdev = ERR_PTR(error);
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* open_bdev_excl - open a block device by name and set it up for use
|
|
|
|
*
|
|
|
|
* @path: special file representing the block device
|
|
|
|
* @flags: %MS_RDONLY for opening read-only
|
|
|
|
* @holder: owner for exclusion
|
|
|
|
*
|
|
|
|
* Open the blockdevice described by the special file at @path, claim it
|
|
|
|
* for the @holder.
|
|
|
|
*/
|
|
|
|
struct block_device *open_bdev_excl(const char *path, int flags, void *holder)
|
|
|
|
{
|
|
|
|
struct block_device *bdev;
|
|
|
|
mode_t mode = FMODE_READ;
|
|
|
|
int error = 0;
|
|
|
|
|
|
|
|
bdev = lookup_bdev(path);
|
|
|
|
if (IS_ERR(bdev))
|
|
|
|
return bdev;
|
|
|
|
|
|
|
|
if (!(flags & MS_RDONLY))
|
|
|
|
mode |= FMODE_WRITE;
|
|
|
|
error = blkdev_get(bdev, mode, 0);
|
|
|
|
if (error)
|
|
|
|
return ERR_PTR(error);
|
|
|
|
error = -EACCES;
|
|
|
|
if (!(flags & MS_RDONLY) && bdev_read_only(bdev))
|
|
|
|
goto blkdev_put;
|
|
|
|
error = bd_claim(bdev, holder);
|
|
|
|
if (error)
|
|
|
|
goto blkdev_put;
|
|
|
|
|
|
|
|
return bdev;
|
|
|
|
|
|
|
|
blkdev_put:
|
|
|
|
blkdev_put(bdev);
|
|
|
|
return ERR_PTR(error);
|
|
|
|
}
|
|
|
|
|
|
|
|
EXPORT_SYMBOL(open_bdev_excl);
|
|
|
|
|
|
|
|
/**
|
|
|
|
* close_bdev_excl - release a blockdevice openen by open_bdev_excl()
|
|
|
|
*
|
|
|
|
* @bdev: blockdevice to close
|
|
|
|
*
|
|
|
|
* This is the counterpart to open_bdev_excl().
|
|
|
|
*/
|
|
|
|
void close_bdev_excl(struct block_device *bdev)
|
|
|
|
{
|
|
|
|
bd_release(bdev);
|
|
|
|
blkdev_put(bdev);
|
|
|
|
}
|
|
|
|
|
|
|
|
EXPORT_SYMBOL(close_bdev_excl);
|