Input: at32psif - drop unnecessary error messages and other changes
Error messages after memory allocation failures are unnecessary and can be dropped, given that they are emitted as dev_dbg() so nobody except person actively debugging the driver would see them. Also replace jump to return 'goto l; ... l: return e;' with 'return e;' Signed-off-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
This commit is contained in:
Родитель
2057e15945
Коммит
009af5fdb4
|
@ -159,13 +159,12 @@ static int psif_open(struct serio *io)
|
||||||
|
|
||||||
retval = clk_enable(psif->pclk);
|
retval = clk_enable(psif->pclk);
|
||||||
if (retval)
|
if (retval)
|
||||||
goto out;
|
return retval;
|
||||||
|
|
||||||
psif_writel(psif, CR, PSIF_BIT(CR_TXEN) | PSIF_BIT(CR_RXEN));
|
psif_writel(psif, CR, PSIF_BIT(CR_TXEN) | PSIF_BIT(CR_RXEN));
|
||||||
psif_writel(psif, IER, PSIF_BIT(RXRDY));
|
psif_writel(psif, IER, PSIF_BIT(RXRDY));
|
||||||
|
|
||||||
psif->open = true;
|
psif->open = true;
|
||||||
out:
|
|
||||||
return retval;
|
return retval;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -210,16 +209,12 @@ static int __init psif_probe(struct platform_device *pdev)
|
||||||
int ret;
|
int ret;
|
||||||
|
|
||||||
psif = kzalloc(sizeof(struct psif), GFP_KERNEL);
|
psif = kzalloc(sizeof(struct psif), GFP_KERNEL);
|
||||||
if (!psif) {
|
if (!psif)
|
||||||
dev_dbg(&pdev->dev, "out of memory\n");
|
return -ENOMEM;
|
||||||
ret = -ENOMEM;
|
|
||||||
goto out;
|
|
||||||
}
|
|
||||||
psif->pdev = pdev;
|
psif->pdev = pdev;
|
||||||
|
|
||||||
io = kzalloc(sizeof(struct serio), GFP_KERNEL);
|
io = kzalloc(sizeof(struct serio), GFP_KERNEL);
|
||||||
if (!io) {
|
if (!io) {
|
||||||
dev_dbg(&pdev->dev, "out of memory\n");
|
|
||||||
ret = -ENOMEM;
|
ret = -ENOMEM;
|
||||||
goto out_free_psif;
|
goto out_free_psif;
|
||||||
}
|
}
|
||||||
|
@ -297,7 +292,6 @@ out_free_io:
|
||||||
kfree(io);
|
kfree(io);
|
||||||
out_free_psif:
|
out_free_psif:
|
||||||
kfree(psif);
|
kfree(psif);
|
||||||
out:
|
|
||||||
return ret;
|
return ret;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Загрузка…
Ссылка в новой задаче