USB-IP: Deletion of unnecessary checks before the function call "usb_put_dev"
The usb_put_dev() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Acked-by: Valentina Manea <valentina.manea.m@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Родитель
0bfed50544
Коммит
03f3df817d
|
@ -518,8 +518,7 @@ static int vhci_urb_enqueue(struct usb_hcd *hcd, struct urb *urb,
|
|||
dev_info(dev, "SetAddress Request (%d) to port %d\n",
|
||||
ctrlreq->wValue, vdev->rhport);
|
||||
|
||||
if (vdev->udev)
|
||||
usb_put_dev(vdev->udev);
|
||||
usb_put_dev(vdev->udev);
|
||||
vdev->udev = usb_get_dev(urb->dev);
|
||||
|
||||
spin_lock(&vdev->ud.lock);
|
||||
|
@ -539,8 +538,7 @@ static int vhci_urb_enqueue(struct usb_hcd *hcd, struct urb *urb,
|
|||
usbip_dbg_vhci_hc(
|
||||
"Not yet?:Get_Descriptor to device 0 (get max pipe size)\n");
|
||||
|
||||
if (vdev->udev)
|
||||
usb_put_dev(vdev->udev);
|
||||
usb_put_dev(vdev->udev);
|
||||
vdev->udev = usb_get_dev(urb->dev);
|
||||
goto out;
|
||||
|
||||
|
@ -831,8 +829,7 @@ static void vhci_device_reset(struct usbip_device *ud)
|
|||
vdev->speed = 0;
|
||||
vdev->devid = 0;
|
||||
|
||||
if (vdev->udev)
|
||||
usb_put_dev(vdev->udev);
|
||||
usb_put_dev(vdev->udev);
|
||||
vdev->udev = NULL;
|
||||
|
||||
if (ud->tcp_socket) {
|
||||
|
|
Загрузка…
Ссылка в новой задаче