can: mcba_usb: mcba_usb_start_xmit(): fix double dev_kfree_skb in error path
There is no need to call dev_kfree_skb() when usb_submit_urb() fails
because can_put_echo_skb() deletes original skb and
can_free_echo_skb() deletes the cloned skb.
Fixes: 51f3baad7d
("can: mcba_usb: Add support for Microchip CAN BUS Analyzer")
Link: https://lore.kernel.org/all/20220311080208.45047-1-hbh25y@gmail.com
Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
This commit is contained in:
Родитель
3d3925ff64
Коммит
04c9b00ba8
|
@ -364,7 +364,6 @@ static netdev_tx_t mcba_usb_start_xmit(struct sk_buff *skb,
|
||||||
xmit_failed:
|
xmit_failed:
|
||||||
can_free_echo_skb(priv->netdev, ctx->ndx, NULL);
|
can_free_echo_skb(priv->netdev, ctx->ndx, NULL);
|
||||||
mcba_usb_free_ctx(ctx);
|
mcba_usb_free_ctx(ctx);
|
||||||
dev_kfree_skb(skb);
|
|
||||||
stats->tx_dropped++;
|
stats->tx_dropped++;
|
||||||
|
|
||||||
return NETDEV_TX_OK;
|
return NETDEV_TX_OK;
|
||||||
|
|
Загрузка…
Ссылка в новой задаче