Merge branch 'hns-coding-style'
Guangbin Huang says: ==================== net: hns: clean up some code style issues This patchset clean up some code style issues. ==================== Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Коммит
052d601725
|
@ -462,8 +462,6 @@ static void hns_ae_adjust_link(struct hnae_handle *handle, int speed,
|
|||
default:
|
||||
break;
|
||||
}
|
||||
|
||||
return;
|
||||
}
|
||||
|
||||
static void hns_ae_get_ring_bdnum_limit(struct hnae_queue *queue,
|
||||
|
|
|
@ -914,8 +914,7 @@ static int hns_mac_get_info(struct hns_mac_cb *mac_cb)
|
|||
}
|
||||
} else if (is_acpi_node(mac_cb->fw_port)) {
|
||||
ret = hns_mac_register_phy(mac_cb);
|
||||
/*
|
||||
* Mac can work well if there is phy or not.If the port don't
|
||||
/* Mac can work well if there is phy or not.If the port don't
|
||||
* connect with phy, the return value will be ignored. Only
|
||||
* when there is phy but can't find mdio bus, the return value
|
||||
* will be handled.
|
||||
|
|
|
@ -56,31 +56,31 @@ static u32 dsaf_read_sub(struct dsaf_device *dsaf_dev, u32 reg)
|
|||
}
|
||||
|
||||
static void hns_dsaf_acpi_ledctrl_by_port(struct hns_mac_cb *mac_cb, u8 op_type,
|
||||
u32 link, u32 port, u32 act)
|
||||
u32 link, u32 port, u32 act)
|
||||
{
|
||||
union acpi_object *obj;
|
||||
union acpi_object obj_args[3], argv4;
|
||||
union acpi_object *obj;
|
||||
union acpi_object obj_args[3], argv4;
|
||||
|
||||
obj_args[0].integer.type = ACPI_TYPE_INTEGER;
|
||||
obj_args[0].integer.value = link;
|
||||
obj_args[1].integer.type = ACPI_TYPE_INTEGER;
|
||||
obj_args[1].integer.value = port;
|
||||
obj_args[2].integer.type = ACPI_TYPE_INTEGER;
|
||||
obj_args[2].integer.value = act;
|
||||
obj_args[0].integer.type = ACPI_TYPE_INTEGER;
|
||||
obj_args[0].integer.value = link;
|
||||
obj_args[1].integer.type = ACPI_TYPE_INTEGER;
|
||||
obj_args[1].integer.value = port;
|
||||
obj_args[2].integer.type = ACPI_TYPE_INTEGER;
|
||||
obj_args[2].integer.value = act;
|
||||
|
||||
argv4.type = ACPI_TYPE_PACKAGE;
|
||||
argv4.package.count = 3;
|
||||
argv4.package.elements = obj_args;
|
||||
argv4.type = ACPI_TYPE_PACKAGE;
|
||||
argv4.package.count = 3;
|
||||
argv4.package.elements = obj_args;
|
||||
|
||||
obj = acpi_evaluate_dsm(ACPI_HANDLE(mac_cb->dev),
|
||||
&hns_dsaf_acpi_dsm_guid, 0, op_type, &argv4);
|
||||
if (!obj) {
|
||||
dev_warn(mac_cb->dev, "ledctrl fail, link:%d port:%d act:%d!\n",
|
||||
link, port, act);
|
||||
return;
|
||||
}
|
||||
obj = acpi_evaluate_dsm(ACPI_HANDLE(mac_cb->dev),
|
||||
&hns_dsaf_acpi_dsm_guid, 0, op_type, &argv4);
|
||||
if (!obj) {
|
||||
dev_warn(mac_cb->dev, "ledctrl fail, link:%d port:%d act:%d!\n",
|
||||
link, port, act);
|
||||
return;
|
||||
}
|
||||
|
||||
ACPI_FREE(obj);
|
||||
ACPI_FREE(obj);
|
||||
}
|
||||
|
||||
static void hns_dsaf_acpi_locate_ledctrl_by_port(struct hns_mac_cb *mac_cb,
|
||||
|
@ -151,15 +151,15 @@ static void hns_cpld_set_led(struct hns_mac_cb *mac_cb, int link_status,
|
|||
}
|
||||
|
||||
static void hns_cpld_set_led_acpi(struct hns_mac_cb *mac_cb, int link_status,
|
||||
u16 speed, int data)
|
||||
u16 speed, int data)
|
||||
{
|
||||
if (!mac_cb) {
|
||||
pr_err("cpld_led_set mac_cb is null!\n");
|
||||
return;
|
||||
}
|
||||
if (!mac_cb) {
|
||||
pr_err("cpld_led_set mac_cb is null!\n");
|
||||
return;
|
||||
}
|
||||
|
||||
hns_dsaf_acpi_ledctrl_by_port(mac_cb, HNS_OP_LED_SET_FUNC,
|
||||
link_status, mac_cb->mac_id, data);
|
||||
hns_dsaf_acpi_ledctrl_by_port(mac_cb, HNS_OP_LED_SET_FUNC,
|
||||
link_status, mac_cb->mac_id, data);
|
||||
}
|
||||
|
||||
static void cpld_led_reset(struct hns_mac_cb *mac_cb)
|
||||
|
@ -174,16 +174,16 @@ static void cpld_led_reset(struct hns_mac_cb *mac_cb)
|
|||
|
||||
static void cpld_led_reset_acpi(struct hns_mac_cb *mac_cb)
|
||||
{
|
||||
if (!mac_cb) {
|
||||
pr_err("cpld_led_reset mac_cb is null!\n");
|
||||
return;
|
||||
}
|
||||
if (!mac_cb) {
|
||||
pr_err("cpld_led_reset mac_cb is null!\n");
|
||||
return;
|
||||
}
|
||||
|
||||
if (mac_cb->media_type != HNAE_MEDIA_TYPE_FIBER)
|
||||
return;
|
||||
if (mac_cb->media_type != HNAE_MEDIA_TYPE_FIBER)
|
||||
return;
|
||||
|
||||
hns_dsaf_acpi_ledctrl_by_port(mac_cb, HNS_OP_LED_SET_FUNC,
|
||||
0, mac_cb->mac_id, 0);
|
||||
hns_dsaf_acpi_ledctrl_by_port(mac_cb, HNS_OP_LED_SET_FUNC,
|
||||
0, mac_cb->mac_id, 0);
|
||||
}
|
||||
|
||||
static int cpld_set_led_id(struct hns_mac_cb *mac_cb,
|
||||
|
@ -521,7 +521,7 @@ static phy_interface_t hns_mac_get_phy_if(struct hns_mac_cb *mac_cb)
|
|||
reg = HNS_MAC_HILINK4_REG;
|
||||
else
|
||||
reg = HNS_MAC_HILINK3_REG;
|
||||
} else{
|
||||
} else {
|
||||
if (!HNS_DSAF_IS_DEBUG(mac_cb->dsaf_dev) && mac_id <= 3)
|
||||
reg = HNS_MAC_HILINK4V2_REG;
|
||||
else
|
||||
|
|
Загрузка…
Ссылка в новой задаче