PCI: mediatek-gen3: Fix refcount leak in mtk_pcie_init_irq_domains()
[ Upstream commitbf038503d5
] of_get_child_by_name() returns a node pointer with refcount incremented, so we should use of_node_put() on it when we don't need it anymore. Add missing of_node_put() to avoid refcount leak. Fixes:814cceebba
("PCI: mediatek-gen3: Add INTx support") Link: https://lore.kernel.org/r/20220601041259.56185-1-linmq006@gmail.com Signed-off-by: Miaoqian Lin <linmq006@gmail.com> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Reviewed-by: Miles Chen <miles.chen@mediatek.com> Acked-by: Jianjun Wang <jianjun.wang@mediatek.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Родитель
c99dca4ebc
Коммит
0675fe20da
|
@ -600,7 +600,8 @@ static int mtk_pcie_init_irq_domains(struct mtk_pcie_port *port)
|
|||
&intx_domain_ops, port);
|
||||
if (!port->intx_domain) {
|
||||
dev_err(dev, "failed to create INTx IRQ domain\n");
|
||||
return -ENODEV;
|
||||
ret = -ENODEV;
|
||||
goto out_put_node;
|
||||
}
|
||||
|
||||
/* Setup MSI */
|
||||
|
@ -623,6 +624,7 @@ static int mtk_pcie_init_irq_domains(struct mtk_pcie_port *port)
|
|||
goto err_msi_domain;
|
||||
}
|
||||
|
||||
of_node_put(intc_node);
|
||||
return 0;
|
||||
|
||||
err_msi_domain:
|
||||
|
@ -630,6 +632,8 @@ err_msi_domain:
|
|||
err_msi_bottom_domain:
|
||||
irq_domain_remove(port->intx_domain);
|
||||
|
||||
out_put_node:
|
||||
of_node_put(intc_node);
|
||||
return ret;
|
||||
}
|
||||
|
||||
|
|
Загрузка…
Ссылка в новой задаче