staging:rtl8192u: Refactor enum dm_ratr_sta_e usage - Style
The enumerated type dm_ratr_sta_e was defined in the file drivers/staging/rtl8192u/r8192U_dm.h but never actually used in that file. The only variable which uses this enumerated type is 'ratr_state', a member variable of the _rate_adaptive structure defined in the file drivers/staging/rtl8192u/r8192U.h. To clarify and place the enumerated type close to where it is used the type was moved to the drivers/staging/rtl8192u/r8192U.h file. In addition the member variable 'ratr_state' which uses the enumerated constants was declared as being of type 'u8'. This negates any advantage of the enumerated type, compiler type-checking, so that member variable's type has been changed to being of the enumerated type. The typedef from the enumerated type has been removed to clear the checkpatch issue with defining new types. Additionally the name of the type has been left as enum dynamic_ratr_state This is a coding style change and should have no impact on runtime code execution. Signed-off-by: John Whitmore <johnfwhitmore@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Родитель
e0043d14fc
Коммит
06761ce429
|
@ -662,9 +662,17 @@ typedef enum _RT_RF_TYPE_819xU {
|
|||
RF_PSEUDO_11N = 4,
|
||||
} RT_RF_TYPE_819xU, *PRT_RF_TYPE_819xU;
|
||||
|
||||
/* 2007/10/08 MH Define RATR state. */
|
||||
enum dynamic_ratr_state {
|
||||
DM_RATR_STA_HIGH = 0,
|
||||
DM_RATR_STA_MIDDLE = 1,
|
||||
DM_RATR_STA_LOW = 2,
|
||||
DM_RATR_STA_MAX
|
||||
};
|
||||
|
||||
typedef struct _rate_adaptive {
|
||||
u8 rate_adaptive_disabled;
|
||||
u8 ratr_state;
|
||||
enum dynamic_ratr_state ratr_state;
|
||||
u16 reserve;
|
||||
|
||||
u32 high_rssi_thresh_for_ra;
|
||||
|
|
|
@ -105,14 +105,6 @@ struct dig {
|
|||
long rssi_val;
|
||||
};
|
||||
|
||||
/* 2007/10/08 MH Define RATR state. */
|
||||
typedef enum tag_dynamic_ratr_state_definition {
|
||||
DM_RATR_STA_HIGH = 0,
|
||||
DM_RATR_STA_MIDDLE = 1,
|
||||
DM_RATR_STA_LOW = 2,
|
||||
DM_RATR_STA_MAX
|
||||
} dm_ratr_sta_e;
|
||||
|
||||
/* 2007/10/11 MH Define DIG operation type. */
|
||||
typedef enum tag_dynamic_init_gain_operation_type_definition {
|
||||
DIG_TYPE_THRESH_HIGH = 0,
|
||||
|
|
Загрузка…
Ссылка в новой задаче