media: dmxdev: fix error code for invalid ioctls

[ Upstream commit a145f64c61 ]

Returning -EINVAL when an ioctl is not implemented is a very
bad idea, as it is hard to distinguish from other error
contitions that an ioctl could lead. Replace it by its
right error code: -ENOTTY.

Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Mauro Carvalho Chehab 2018-02-11 05:44:21 -05:00 коммит произвёл Greg Kroah-Hartman
Родитель 7bc147610d
Коммит 07999bccf2
1 изменённых файлов: 1 добавлений и 1 удалений

Просмотреть файл

@ -1055,7 +1055,7 @@ static int dvb_demux_do_ioctl(struct file *file,
break;
default:
ret = -EINVAL;
ret = -ENOTTY;
break;
}
mutex_unlock(&dmxdev->mutex);