batman-adv: Place kref_get for orig_node_vlan near use
It is hard to understand why the refcnt is increased when it isn't done near the actual place the new reference is used. So using kref_get right before the place which requires the reference and in the same function helps to avoid accidental problems caused by incorrect reference counting. Signed-off-by: Sven Eckelmann <sven@narfation.org> Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch> Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
This commit is contained in:
Родитель
4c09a08b47
Коммит
09537d1869
|
@ -133,9 +133,9 @@ batadv_orig_node_vlan_new(struct batadv_orig_node *orig_node,
|
||||||
goto out;
|
goto out;
|
||||||
|
|
||||||
kref_init(&vlan->refcount);
|
kref_init(&vlan->refcount);
|
||||||
kref_get(&vlan->refcount);
|
|
||||||
vlan->vid = vid;
|
vlan->vid = vid;
|
||||||
|
|
||||||
|
kref_get(&vlan->refcount);
|
||||||
hlist_add_head_rcu(&vlan->list, &orig_node->vlan_list);
|
hlist_add_head_rcu(&vlan->list, &orig_node->vlan_list);
|
||||||
|
|
||||||
out:
|
out:
|
||||||
|
|
Загрузка…
Ссылка в новой задаче