nvme-tcp: avoid repeated request completion
The request may be executed asynchronously, and rq->state may be changed to IDLE. To avoid repeated request completion, only MQ_RQ_COMPLETE of rq->state is checked in nvme_tcp_complete_timed_out. It is not safe, so need adding check IDLE for rq->state. Signed-off-by: Sagi Grimberg <sagi@grimberg.me> Signed-off-by: Chao Leng <lengchao@huawei.com> Signed-off-by: Christoph Hellwig <hch@lst.de>
This commit is contained in:
Родитель
fdf58e02ad
Коммит
0a8a2c85b8
|
@ -2168,7 +2168,7 @@ static void nvme_tcp_complete_timed_out(struct request *rq)
|
||||||
struct nvme_ctrl *ctrl = &req->queue->ctrl->ctrl;
|
struct nvme_ctrl *ctrl = &req->queue->ctrl->ctrl;
|
||||||
|
|
||||||
nvme_tcp_stop_queue(ctrl, nvme_tcp_queue_id(req->queue));
|
nvme_tcp_stop_queue(ctrl, nvme_tcp_queue_id(req->queue));
|
||||||
if (!blk_mq_request_completed(rq)) {
|
if (blk_mq_request_started(rq) && !blk_mq_request_completed(rq)) {
|
||||||
nvme_req(rq)->status = NVME_SC_HOST_ABORTED_CMD;
|
nvme_req(rq)->status = NVME_SC_HOST_ABORTED_CMD;
|
||||||
blk_mq_complete_request(rq);
|
blk_mq_complete_request(rq);
|
||||||
}
|
}
|
||||||
|
|
Загрузка…
Ссылка в новой задаче