mm/swapfile.c: fix swap space leak in error path of swap_free_entries()
In swapcache_free_entries(), if swap_info_get_cont() returns NULL, something wrong occurs for the swap entry. But we should still continue to free the following swap entries in the array instead of skip them to avoid swap space leak. This is just problem in error path, where system may be in an inconsistent state, but it is still good to fix it. Link: http://lkml.kernel.org/r/20170421124739.24534-1-ying.huang@intel.com Signed-off-by: "Huang, Ying" <ying.huang@intel.com> Acked-by: Tim Chen <tim.c.chen@linux.intel.com> Cc: Rik van Riel <riel@redhat.com> Cc: Hugh Dickins <hughd@google.com> Cc: Shaohua Li <shli@kernel.org> Cc: Minchan Kim <minchan@kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Родитель
aa2369f11f
Коммит
0ccfece6ed
|
@ -1079,8 +1079,6 @@ void swapcache_free_entries(swp_entry_t *entries, int n)
|
|||
p = swap_info_get_cont(entries[i], prev);
|
||||
if (p)
|
||||
swap_entry_free(p, entries[i]);
|
||||
else
|
||||
break;
|
||||
prev = p;
|
||||
}
|
||||
if (p)
|
||||
|
|
Загрузка…
Ссылка в новой задаче