drm/i915/guc: Don't clear the cookie on doorbell destroy
If the HW has not processed the db invalidation request yet, clearing the cookie can generate a db ring. We clear the cookie when we (re-)allocate the doorbell so no need to do it on destroy as well as no one is going to look at it while the doorbell is inactive v2: fix typo in patch title (Michal) Cc: Michal Wajdeczko <michal.wajdeczko@intel.com> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Link: https://patchwork.freedesktop.org/patch/msgid/20181002215430.15049-2-daniele.ceraolospurio@intel.com
This commit is contained in:
Родитель
48b426a9b9
Коммит
0fc645f338
|
@ -209,7 +209,6 @@ static void __destroy_doorbell(struct intel_guc_client *client)
|
||||||
|
|
||||||
doorbell = __get_doorbell(client);
|
doorbell = __get_doorbell(client);
|
||||||
doorbell->db_status = GUC_DOORBELL_DISABLED;
|
doorbell->db_status = GUC_DOORBELL_DISABLED;
|
||||||
doorbell->cookie = 0;
|
|
||||||
|
|
||||||
/* Doorbell release flow requires that we wait for GEN8_DRB_VALID bit
|
/* Doorbell release flow requires that we wait for GEN8_DRB_VALID bit
|
||||||
* to go to zero after updating db_status before we call the GuC to
|
* to go to zero after updating db_status before we call the GuC to
|
||||||
|
|
Загрузка…
Ссылка в новой задаче